@bongos/core 1.19.526 → 1.19.528

package/tests/skill_lint.mjs

@@ -0,0 +1,73 @@
+// tests/skill_lint.mjs — the SKILL.md frontmatter linter reproduces the YAML failure modes that
+// silently broke ten skills (task 1003548), and the committed skills all pass it.
+import { strict as assert } from 'node:assert';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const lint = require('../scripts/gds/skill-lint.js');
+
+const fm = (desc, extra = '') => `---\nname: demo\ndescription: ${desc}\n${extra}---\n\nBody text.\n`;
+const run = (text) => lint.lintSkillFile(text, { file: path.join('x', '.claude', 'skills', 'demo', 'SKILL.md') });
+
+test('a plain description containing ": " is an error (the whole frontmatter would fail to parse)', () => {
+  const r = run(fm('Show the box and help them get on it: reconnect or wake.'));
+  assert.equal(r.errors.length, 1, r.errors.join('; '));
+  assert.match(r.errors[0], /colon-space/);
+  assert.match(r.errors[0], /description: >-/, 'the message carries the fix');
+});
+
+test('a plain description containing " #" is an error (YAML would truncate it as a comment)', () => {
+  const r = run(fm('Connect the box (ADR 0031, #701) and open the terminal.'));
+  assert.equal(r.errors.length, 1);
+  assert.match(r.errors[0], / #/);
+});
+
+test('the same text as a folded block scalar is clean', () => {
+  const r = run('---\nname: demo\ndescription: >-\n  Show the box and help them get on it: reconnect (ADR 0031, #701) or wake.\n---\n\nBody.\n');
+  assert.deepEqual(r.errors, []);
+  assert.match(r.description, /reconnect \(ADR 0031, #701\)/);
+});
+
+test('a double-quoted description is clean; an unclosed quote is an error', () => {
+  assert.deepEqual(run(fm('"Do it: now"')).errors, []);
+  assert.equal(run(fm('"Do it: now')).errors.length, 1);
+});
+
+test('a flow list in requires is valid YAML and not flagged', () => {
+  const r = run(fm('Fine text.', 'requires: [gh, main-checkout]\n'));
+  assert.deepEqual(r.errors, []);
+});
+
+test('missing name or description is an error; a folder/name mismatch is a warning', () => {
+  assert.match(run('---\nname: demo\n---\nBody\n').errors.join(' '), /missing or empty "description"/);
+  assert.match(run('---\ndescription: x\n---\nBody\n').errors.join(' '), /missing "name"/);
+  const r = lint.lintSkillFile('---\nname: other\ndescription: x\n---\nBody\n', { file: path.join('x', '.claude', 'skills', 'demo', 'SKILL.md') });
+  assert.match(r.warnings.join(' '), /differs from its folder/);
+});
+
+test('a long description warns; an over-cap one errors', () => {
+  assert.equal(run(fm('a'.repeat(450))).warnings.filter((w) => /chars/.test(w)).length, 1);
+  assert.equal(run(fm('a'.repeat(1100))).errors.filter((w) => /cap/.test(w)).length, 1);
+});
+
+test('no frontmatter at all is an error', () => {
+  assert.equal(run('# Title\n\nBody.\n').errors.length, 1);
+});
+
+test('the hook path filter matches only .claude/skills/<name>/SKILL.md', () => {
+  assert.ok(lint.isSkillMd('C:\\repo\\.claude\\skills\\dev\\SKILL.md'));
+  assert.ok(lint.isSkillMd('/repo/.claude/skills/dev/SKILL.md'));
+  assert.ok(!lint.isSkillMd('/repo/.claude/skills/dev/notes.md'));
+  assert.ok(!lint.isSkillMd('/repo/modules/ui-design/skills/dev/SKILL.md'));
+});
+
+test('every committed skill parses (the ten that did not on 2026-09-03 must stay fixed)', () => {
+  const report = lint.lintSkills(lint.listSkillFiles(ROOT));
+  const broken = report.results.filter((r) => r.errors.length).map((r) => path.relative(ROOT, r.file) + ': ' + r.errors.join('; '));
+  assert.deepEqual(broken, [], broken.join('\n'));
+  assert.ok(report.results.length >= 40, 'the repo ships dozens of skills; the lister found ' + report.results.length);
+});