@bongos/core 1.19.523 → 1.19.524

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.523",
-  "core_contract": "1.19.523",
-  "source_commit": "4d6bf53e6443bf737775e277080d2f14f574edad",
+  "core_version": "1.19.524",
+  "core_contract": "1.19.524",
+  "source_commit": "2bcf689e8a274d2d6fe6d95f0ae0cc94d8de9ad2",
   "source_ref": "HEAD",
-  "built_at": "2026-09-03T23:12:58.339Z",
+  "built_at": "2026-09-03T23:36:45.727Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 431,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2424,
-  "tree_sha256": "baf1d9a541cc968505997bdc199995e36491ed289791585d1d3dcf1bb66ff004",
+  "tree_sha256": "5b603403c990cba86562e75005310c23fd6ec06bfc6934190cb2f7b1edd8f596",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2597,7 +2597,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "595be3b748b8664a50fcde28667fbe25e1cf43894753499e9f7b0bbf30518e89"
+      "sha256": "dc3cb8274947a5bed3315b467d104b852e5ef4a9aea5642763765e2c3bfc5650"
     },
     {
       "path": "docs/modules-contract.md",
@@ -4847,7 +4847,7 @@
     {
       "path": "modules/hall-ui/public/oversight.css",
       "mode": "0000644",
-      "sha256": "7c6c29c37950665c90606b846afb6381628d2ab4c362be604bcf359831525051"
+      "sha256": "9aa3fd3f662274571e049eb9931f8dd575eef527a624bc6a5d57102061f54936"
     },
     {
       "path": "modules/hall-ui/public/pair.css",
@@ -5077,7 +5077,7 @@
     {
       "path": "modules/hall-ui/public/style.css",
       "mode": "0000644",
-      "sha256": "f3d877972513fa23f2819a91f34c4901ca5e692faad6dcf096377a6b1d5b1be4"
+      "sha256": "b37fa5714da911e20f1cab9bca3e4a76314065dd27cc59fad3bbb7ad9314370b"
     },
     {
       "path": "modules/hall-ui/public/task-detail.js",
@@ -7297,12 +7297,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "36fb0fa1abd3d8ec9b1bee4457ec3a8541e1b753aaaf9fcf93780ac65e3efc9a"
+      "sha256": "bc7bbba6148fa9d568b64a75b65ef180df5552277546b777ffdee8316f72105c"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "51c3aef45b0e71569102672d27df52abaff4814663a45da0731ac8b3e9557e0e"
+      "sha256": "f9383e8ec30bfc6a70fc13c2484732cbe20e97caac115737fb4942dd2e6c3588"
     },
     {
       "path": "public-docs/index.html",
@@ -8972,7 +8972,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "aaf11ce9202e128bdcdd317e26a27a2d1f1ff1a7f73d6d996dc0a79f879ad3b6"
+      "sha256": "40fd7f7332ab9375d8078e846d565e282b7daf64abfdb6b22eb21380e7cdae17"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10357,12 +10357,12 @@
     {
       "path": "tests/hall_audit.mjs",
       "mode": "0000644",
-      "sha256": "de4b33fd78de12daf1b6e07eeb3834ffd19e912ea81c1d2ba91a129a19e7382a"
+      "sha256": "7e73863dba1bb570f61e3415af6ba84ba74207d9efd11c9032873b2cc1734ee9"
     },
     {
       "path": "tests/hall_board_world.mjs",
       "mode": "0000644",
-      "sha256": "196742bcff58511c21c891011a48448ef95a292bd84dc164d3fccb2620de838a"
+      "sha256": "31013c61fa0099ae2195148aeef5c810996edafc667ea5bc2e4c7176570e4ee7"
     },
     {
       "path": "tests/hall_catalog_world.mjs",

package/docs/module-api-changelog.md

@@ -1483,5 +1483,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.521 with no explicit bump. run 33815020928. (task 1002620)
   1.19.523 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.522 with no explicit bump. run 33816191865. (task 1002620)
+  1.19.524 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.523 with no explicit bump. run 33818285201. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/oversight.css

@@ -284,7 +284,7 @@ a.fact-chip:hover { color: var(--accent-ink); border-color: var(--accent-ink); t
   align-items: center;
   justify-content: center;
   padding: 20px;
-  background: color-mix(in srgb, var(--ink) 40%, transparent);
+  background: var(--scrim);
 }
 .ov-modal {
   width: 100%;

package/modules/hall-ui/public/style.css

@@ -963,7 +963,7 @@ main:focus { outline: none; }
   position: fixed;
   inset: 0;
   z-index: var(--z-scrim);
-  background: rgba(0, 0, 0, .55);
+  background: var(--scrim);
 }
 
 /* Focus: the world's two-tone ring — a 2px accent-derived outline at 3px offset
@@ -2695,7 +2695,7 @@ main [id] { scroll-margin-top: calc(var(--topbar-h) + 16px); }
   position: fixed;
   inset: 0;
   z-index: 2000;
-  background: rgba(0, 0, 0, .55);
+  background: var(--scrim);
   display: flex;
   align-items: center;
   justify-content: center;
@@ -3190,7 +3190,7 @@ a.stat-tile:hover .stat-tile__sub { color: var(--ink-soft); }
 }
 
 .palette { position: fixed; inset: 0; z-index: 2100; }
-.palette__scrim { position: absolute; inset: 0; background: color-mix(in srgb, var(--ink) 45%, transparent); }
+.palette__scrim { position: absolute; inset: 0; background: var(--scrim); }
 .palette__panel {
   position: relative;
   margin: 10vh auto 0;

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.523",
+  "version": "1.19.524",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.523",
+      "version": "1.19.524",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.523",
+  "version": "1.19.524",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -45,7 +45,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.523'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.524'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/hall_audit.mjs

@@ -527,3 +527,69 @@ test('the command palette input rings from the token tier, inside its own box',
   assert.match(css, /\.palette__panel\s*\{[^}]*overflow:\s*hidden/, 'the panel still clips, so the inset form is still the right one');
   assert.match(rule[1], /outline-offset:\s*-|inset/, 'the indication sits inside the input, not outside it');
 });
+
+// ---- 11. the world has ONE scrim (task 1003568) ---------------------------
+
+// A scrim darkens what is behind it — in BOTH modes. That is why it cannot be
+// mixed from a ground token: `--ink` is near-black in light and #ffffff in
+// dark, so `color-mix(in srgb, var(--ink) N%, transparent)` paints a WHITE wash
+// over a dark page. `.palette__scrim` did exactly that, unnoticed, while three
+// other scrims in the same sheet each carried their own copy of the same
+// black-with-alpha literal. Task 1003495 gave the value a home as `--scrim`;
+// this pins that every scrim now spends it.
+const SCRIM_VALUE = 'rgba(0, 0, 0, .55)';
+
+test('every scrim in the hall spends --scrim, and none is mixed from a ground token', () => {
+  const sheets = fs.readdirSync(HALL).filter((f) => f.endsWith('.css'));
+  const offenders = [];
+  for (const f of sheets) {
+    const css = read(f).replace(/\/\*[\s\S]*?\*\//g, '');
+    for (const m of css.matchAll(/([^{}]*(?:scrim|::backdrop)[^{}]*)\{([^{}]*)\}/gi)) {
+      const [sel, body] = [m[1].trim().replace(/\s+/g, ' '), m[2]];
+      if (!/background(-color)?\s*:/.test(body)) continue; // not the painting rule
+      if (!/background(-color)?\s*:\s*var\(--scrim\)/.test(body)) {
+        offenders.push(`${f}: \`${sel}\` paints a scrim without var(--scrim)`);
+      }
+    }
+  }
+  assert.deepEqual(offenders, [], 'a scrim spends the token, never its own value');
+});
+
+test('no rule washes a whole surface with a ground token — the dark-mode inversion', () => {
+  // Mixing --ink into a SURFACE (var(--bg-card)) is the design system working —
+  // --surface-2 and --skeleton are meant to flip with the mode. Mixing it into
+  // `transparent` as a FLAT WASH over everything behind it is the bug: --ink is
+  // #ffffff in dark, so the wash turns white and lifts the page instead of
+  // dimming it. That is what .palette__scrim and .ov-modal-bg both did.
+  //
+  // The same mix INSIDE a gradient is not a wash — the diagram viewer's dotted
+  // "drawing board" texture spends it as one colour stop over the card's own
+  // ground, and there flipping with the mode is exactly right. So this matches
+  // only a mix that is the ENTIRE value of a background declaration.
+  const FLAT_INK_WASH = /background(?:-color)?\s*:\s*color-mix\(in srgb,\s*var\(--ink\)\s*\d+%\s*,\s*transparent\s*\)\s*;/g;
+  const bad = [];
+  for (const f of fs.readdirSync(HALL).filter((x) => x.endsWith('.css'))) {
+    const css = read(f).replace(/\/\*[\s\S]*?\*\//g, '');
+    for (const m of css.matchAll(FLAT_INK_WASH)) bad.push(`${f}: ${m[0].trim()}`);
+  }
+  assert.deepEqual(bad, [], 'a full-surface wash mixed from --ink inverts between modes — use var(--scrim)');
+});
+
+test('the wash guard CATCHES a scrim but spares a texture', () => {
+  const FLAT_INK_WASH = /background(?:-color)?\s*:\s*color-mix\(in srgb,\s*var\(--ink\)\s*\d+%\s*,\s*transparent\s*\)\s*;/;
+  assert.ok(FLAT_INK_WASH.test('.x { background: color-mix(in srgb, var(--ink) 40%, transparent); }'),
+    'a flat wash is caught');
+  assert.equal(FLAT_INK_WASH.test('.y { background: radial-gradient(circle, color-mix(in srgb, var(--ink) 5%, transparent) 1px, transparent 1.4px) 0 0 / 22px 22px, var(--bg-card); }'), false,
+    'the same mix as a gradient STOP is a texture over a ground, and flips correctly');
+  assert.equal(FLAT_INK_WASH.test('.z { background: color-mix(in srgb, var(--ink) 6%, var(--bg-card)); }'), false,
+    'mixing into a surface is the design system working as intended');
+});
+
+test('--scrim is defined once and does NOT flip with the mode', () => {
+  const css = read('style.css');
+  const defs = [...css.matchAll(/--scrim\s*:/g)];
+  assert.equal(defs.length, 1, '--scrim is declared exactly once; a per-mode override would defeat its whole purpose');
+  // And no sheet keeps a second copy of the value it holds.
+  const copies = [...css.matchAll(new RegExp(SCRIM_VALUE.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'), 'g'))];
+  assert.equal(copies.length, 1, `${SCRIM_VALUE} appears only in the --scrim declaration`);
+});

package/tests/hall_board_world.mjs

@@ -439,22 +439,18 @@ test('RUN: the three notices are inbox lines with a kind, a line and — where o
 // than scrolling in a row of their own (walk 1003309). The status tab strip
 // overflows too, but its row is overflow-x:auto and scrolls itself, which is
 // why the fix belongs on the control and not on the drawer.
-const ruleFor = (css, selector) => {
-  const re = new RegExp(`(?:^|\\r?\\n)${selector.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\s*\\{([^}]*)\\}`);
-  const m = re.exec(css);
-  assert.ok(m, `${selector} rule present in style.css`);
-  return m[1];
-};
 
 test('a filter control may shrink below its content, so the drawer never pushes the page', () => {
-  const filter = ruleFor(styleCss, '.filter');
+  const filter = rule(styleCss, '.filter');
+  assert.ok(filter, '.filter rule present in style.css');
   assert.match(filter, /min-width:\s*0\b/, '.filter is a flex item: min-width:auto is what pinned it to its content');
   assert.match(filter, /max-width:\s*100%/, 'and it may not exceed the row it sits in');
 
   // The select is the thing with the runaway intrinsic width. It keeps its
   // 150px floor for wide screens — a filter narrower than that is unreadable —
   // and gains a cap so a long option label cannot widen it past its cell.
-  const select = ruleFor(styleCss, '.filter select');
+  const select = rule(styleCss, '.filter select');
+  assert.ok(select, '.filter select rule present in style.css');
   assert.match(select, /max-width:\s*100%/, 'the select is capped to its cell');
   // The floor is expressed so it CANNOT itself pin the control: a bare 150px
   // would refuse to shrink in a cell narrower than 150px, which is the same
@@ -463,7 +459,9 @@ test('a filter control may shrink below its content, so the drawer never pushes
 
   // The free-text search box sits in the same wrapping row and would do the
   // same thing at 320 with its 200px floor.
-  assert.match(ruleFor(styleCss, '.filter input[type="search"]'), /max-width:\s*100%/,
+  const search = rule(styleCss, '.filter input[type="search"]');
+  assert.ok(search, '.filter input[type="search"] rule present in style.css');
+  assert.match(search, /max-width:\s*100%/,
     'the search box is capped the same way');
 });