@bongos/core 1.19.503 → 1.19.505

package/tests/hall_nav.mjs

@@ -193,6 +193,39 @@ test('href check actually CATCHES a dead link', () => {
   assert.equal(hrefResolves({ href: '/drachmae', external: false }), true);
 });
 
+// ── Community carries no rank flag (task 1003442, goal 1000075) ─────────────
+
+// The nav ladder as shell.js gateAllows() defines it, for ONE viewer: a signed-in
+// xenos. Restated here rather than imported because the point of this file is to
+// check the rendered markup against the rule, not to trust the source twice.
+const XENOS_SEES = { always: true, signed: true, work: false, member: false, government: false, archon: false };
+// The gates that encode a RANK floor. 'signed' is not one of them — it asks
+// whether you are here, not who you are.
+const RANK_GATES = new Set(['member', 'work', 'government', 'archon']);
+
+test('THE CORRECTION: Community shows a xenos two items, Collab and Builders', () => {
+  // Both items read 'member' until task 1003442, so a newcomer saw an empty
+  // Community group — while /builders/collab was already requireBuilderPage (no
+  // rank floor) and /builders/roster was already `null` in the page-gate ORACLE.
+  // The rank gate existed only in the nav list.
+  const community = parseNav(boot().sidebarHtml).find((g) => g.label === 'Community');
+  assert.ok(community, 'the Community group renders');
+  assert.equal(XENOS_SEES[community.headGate], true, 'the group HEAD is visible to a xenos');
+  const visible = community.items.filter((i) => XENOS_SEES[i.gate]);
+  assert.deepEqual(visible.map((i) => i.id), ['collab', 'roster'],
+    'a xenos sees exactly Collab and Builders');
+});
+
+test('neither Community page hides behind a rank the page itself does not enforce', () => {
+  // The invariant this task exists to restore: a nav flag may be narrower than
+  // the wall for cosmetic reasons (/profile does it), but it must never assert a
+  // RANK the page gate does not. /people keeps its rank flag legitimately — it
+  // fronts project.curate, which requireProjectCuratePage really does enforce.
+  const community = parseNav(boot().sidebarHtml).find((g) => g.label === 'Community');
+  const ranked = community.items.filter((i) => RANK_GATES.has(i.gate)).map((i) => i.id);
+  assert.deepEqual(ranked, ['people'], 'only /people carries a rank flag, and its API enforces one');
+});
+
 test('no group head is gated wider than its own items', () => {
   const bad = parseNav(boot().sidebarHtml).filter(headOutOfRange).map((g) => g.label);
   assert.deepEqual(bad, [], 'a head gated wider than every item would render a label over nothing');

package/tests/promote_goal_id.mjs

@@ -294,7 +294,10 @@ await test('DEGRADES: the hall re-fetches goals when the version changes, newest
   // Goals belong to a version; keeping stale options would offer a home the
   // server would reject.
   assert.match(HALL, /vsel\.addEventListener\('change'/);
-  assert.match(HALL, /await goalOptionsFor\(vsel\.value\)/);
+  // The second argument (task 1003516) scopes the filed goal hint to the version
+  // it was filed against — matched loosely so this pins the re-fetch, not the
+  // argument list.
+  assert.match(HALL, /await goalOptionsFor\(vsel\.value/);
 });
 
 await test('the CLI uses the GENERATED typed client method, not the raw escape hatch', () => {