@bongos/core 1.19.499 → 1.19.500

package/docs/copy-registry.json

@@ -383,7 +383,7 @@
       "occurrences": 3,
       "at": [
         "modules/hall-ui/public/goals-lib.js:32",
-        "modules/hall-ui/public/goals-render.js:621",
+        "modules/hall-ui/public/goals-render.js:631",
         "modules/hall-ui/public/goals.js:45"
       ]
     },
@@ -944,8 +944,8 @@
       "text": "Only an open goal can be managed.",
       "occurrences": 2,
       "at": [
-        "modules/hall-ui/public/goals-render.js:1031",
-        "modules/hall-ui/public/goals-render.js:1047"
+        "modules/hall-ui/public/goals-render.js:1042",
+        "modules/hall-ui/public/goals-render.js:1058"
       ]
     },
     {
@@ -954,8 +954,8 @@
       "text": "Only this goal's owner or a manager (or an Archon) may do this.",
       "occurrences": 2,
       "at": [
-        "modules/hall-ui/public/goals-render.js:1030",
-        "modules/hall-ui/public/goals-render.js:1046"
+        "modules/hall-ui/public/goals-render.js:1041",
+        "modules/hall-ui/public/goals-render.js:1057"
       ]
     },
     {
@@ -1274,8 +1274,8 @@
       "text": "This goal is not open.",
       "occurrences": 2,
       "at": [
-        "modules/hall-ui/public/goals-render.js:1001",
-        "modules/hall-ui/public/goals-render.js:1017"
+        "modules/hall-ui/public/goals-render.js:1012",
+        "modules/hall-ui/public/goals-render.js:1028"
       ]
     },
     {
@@ -1740,7 +1740,7 @@
       "surface": "builders-hall",
       "text": "+ Invite",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 949,
+      "line": 960,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -1947,7 +1947,7 @@
       "surface": "builders-hall",
       "text": "A protected-scope goal requires a Metic+ member.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 999,
+      "line": 1010,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -2352,7 +2352,7 @@
       "surface": "builders-hall",
       "text": "Awaiting the owner/manager's approval",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 843,
+      "line": 854,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3081,7 +3081,7 @@
       "surface": "builders-hall",
       "text": "Contribution to this goal",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 700,
+      "line": 711,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3288,7 +3288,7 @@
       "surface": "builders-hall",
       "text": "Could not change that just now.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1048,
+      "line": 1059,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3369,7 +3369,7 @@
       "surface": "builders-hall",
       "text": "Could not invite that builder just now.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1002,
+      "line": 1013,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3774,7 +3774,7 @@
       "surface": "builders-hall",
       "text": "Could not send the request just now.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1063,
+      "line": 1074,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3819,7 +3819,7 @@
       "surface": "builders-hall",
       "text": "Could not update visibility just now.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1032,
+      "line": 1043,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3855,7 +3855,7 @@
       "surface": "builders-hall",
       "text": "Could not {…} just now.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1018,
+      "line": 1029,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -4386,7 +4386,7 @@
       "surface": "builders-hall",
       "text": "Every task linked to this criterion has shipped — a Metic can confirm it",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 643,
+      "line": 654,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4404,7 +4404,7 @@
       "surface": "builders-hall",
       "text": "Everyone is already a member",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 965,
+      "line": 976,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4746,7 +4746,7 @@
       "surface": "builders-hall",
       "text": "Goal id",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 768,
+      "line": 779,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5241,7 +5241,7 @@
       "surface": "builders-hall",
       "text": "Invited.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 991,
+      "line": 1002,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -5304,7 +5304,7 @@
       "surface": "builders-hall",
       "text": "Join goal",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 853,
+      "line": 864,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5322,7 +5322,7 @@
       "surface": "builders-hall",
       "text": "Join requests",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1102,
+      "line": 1113,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5493,7 +5493,7 @@
       "surface": "builders-hall",
       "text": "Leave goal",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 840,
+      "line": 851,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5862,7 +5862,7 @@
       "surface": "builders-hall",
       "text": "Module scope — tasks authored in this goal are bounded to these modules",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 774,
+      "line": 785,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6303,7 +6303,7 @@
       "surface": "builders-hall",
       "text": "Not taking requests",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 848,
+      "line": 859,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6492,7 +6492,7 @@
       "surface": "builders-hall",
       "text": "Only an open goal can be managed.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1031,
+      "line": 1042,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -6501,7 +6501,7 @@
       "surface": "builders-hall",
       "text": "Only an open goal can be managed.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1047,
+      "line": 1058,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -6510,7 +6510,7 @@
       "surface": "builders-hall",
       "text": "Only this goal's owner or a manager (or an Archon) may do this.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1030,
+      "line": 1041,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -6519,7 +6519,7 @@
       "surface": "builders-hall",
       "text": "Only this goal's owner or a manager (or an Archon) may do this.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1046,
+      "line": 1057,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -6528,7 +6528,7 @@
       "surface": "builders-hall",
       "text": "Only this goal's owner or a manager (or an Archon) may invite.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1000,
+      "line": 1011,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -6771,7 +6771,7 @@
       "surface": "builders-hall",
       "text": "Pending invitations",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1103,
+      "line": 1114,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6924,7 +6924,7 @@
       "surface": "builders-hall",
       "text": "Private — join is by invitation or an approved request",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 786,
+      "line": 797,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7023,7 +7023,7 @@
       "surface": "builders-hall",
       "text": "Protected module scope — join by request; an Archon admits members",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 792,
+      "line": 803,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7464,7 +7464,7 @@
       "surface": "builders-hall",
       "text": "Request sent — the owner or a manager will review it.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1054,
+      "line": 1065,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -7473,7 +7473,7 @@
       "surface": "builders-hall",
       "text": "Request withdrawn.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1070,
+      "line": 1081,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8382,7 +8382,7 @@
       "surface": "builders-hall",
       "text": "Tasks could not be loaded.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 922,
+      "line": 933,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8562,7 +8562,7 @@
       "surface": "builders-hall",
       "text": "The goal's leads have paused applications; they can still invite you",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 848,
+      "line": 859,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8940,7 +8940,7 @@
       "surface": "builders-hall",
       "text": "This goal is Archon-mediated — request to join instead.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1014,
+      "line": 1025,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8949,7 +8949,7 @@
       "surface": "builders-hall",
       "text": "This goal is blocked until each prerequisite goal is achieved",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 780,
+      "line": 791,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8958,7 +8958,7 @@
       "surface": "builders-hall",
       "text": "This goal is not open.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1001,
+      "line": 1012,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8967,7 +8967,7 @@
       "surface": "builders-hall",
       "text": "This goal is not open.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1017,
+      "line": 1028,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8976,7 +8976,7 @@
       "surface": "builders-hall",
       "text": "This goal is open — joining directly instead.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1061,
+      "line": 1072,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8985,7 +8985,7 @@
       "surface": "builders-hall",
       "text": "This goal is private — request to join instead.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1015,
+      "line": 1026,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8994,7 +8994,7 @@
       "surface": "builders-hall",
       "text": "This goal is scoped to a protected module — only an Archon may add members.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 998,
+      "line": 1009,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -9003,7 +9003,7 @@
       "surface": "builders-hall",
       "text": "This goal isn't taking requests right now.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1062,
+      "line": 1073,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -9696,7 +9696,7 @@
       "surface": "builders-hall",
       "text": "You already have a pending request or invitation for this goal.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1059,
+      "line": 1070,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -9705,7 +9705,7 @@
       "surface": "builders-hall",
       "text": "You are already a member of this goal.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1060,
+      "line": 1071,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -9714,7 +9714,7 @@
       "surface": "builders-hall",
       "text": "You are not a member of this goal.",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1016,
+      "line": 1027,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -10632,7 +10632,7 @@
       "surface": "builders-hall",
       "text": "invited — awaiting their response",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 1094,
+      "line": 1105,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11082,7 +11082,7 @@
       "surface": "builders-hall",
       "text": "scope: {…}",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 774,
+      "line": 785,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11100,7 +11100,7 @@
       "surface": "builders-hall",
       "text": "shipped ·",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 696,
+      "line": 707,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11217,7 +11217,7 @@
       "surface": "builders-hall",
       "text": "task{…} shipped",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 737,
+      "line": 748,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11595,7 +11595,7 @@
       "surface": "builders-hall",
       "text": "{…} earned",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 737,
+      "line": 748,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11631,7 +11631,7 @@
       "surface": "builders-hall",
       "text": "{…} of {…} criteria satisfied",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 621,
+      "line": 631,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12225,7 +12225,7 @@
       "surface": "builders-hall",
       "text": "🔒 Private",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 786,
+      "line": 797,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12234,7 +12234,7 @@
       "surface": "builders-hall",
       "text": "🔒 Request to join",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 850,
+      "line": 861,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12243,7 +12243,7 @@
       "surface": "builders-hall",
       "text": "🛡 Archon-mediated",
       "file": "modules/hall-ui/public/goals-render.js",
-      "line": 792,
+      "line": 803,
       "origin": "js-markup",
       "confidence": "certain"
     },

package/docs/module-api-changelog.md

@@ -1435,5 +1435,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.497 with no explicit bump. run 33768753719. (task 1002620)
   1.19.499 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.498 with no explicit bump. run 33769500709. (task 1002620)
+  1.19.500 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.499 with no explicit bump. run 33772499045. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/goals-render.js

@@ -608,7 +608,13 @@
     if (back && state.current != null) back.setAttribute('href', `#/goal/${state.current}`);
   }
   const isPending = (c) => !c.satisfied && !!c.pending_review;
-  function completionSummaryHtml(g, crit, sat, ringSize) {
+  // criterionlessTaskCount: task 1003157's DONE WHEN item 2 — the count of this
+  // goal's tasks linked to no criterion, rendered beside the criteria rollup so
+  // the gap is visible here too, not only in the create-time advisory. Shown
+  // only when the goal HAS criteria (an empty-criteria goal has nothing to be
+  // unlinked from) and the count is >0 — silent otherwise, the goal_advisory
+  // fail-open posture.
+  function completionSummaryHtml(g, crit, sat, ringSize, criterionlessTaskCount) {
     const pending = crit.filter(isPending).length;
     // task 1002164 — an open goal used to punt confirmation to the /goal-review
     // CLI skill here; confirming now happens on this page, so the line reports
@@ -618,11 +624,16 @@
       : 'Open — a criterion becomes confirmable once every task linked to it has shipped.';
     const line = g.status === 'achieved' ? 'Goal achieved — every criterion confirmed.'
       : (g.status === 'archived' ? 'Archived.' : openLine);
+    const unlinked = crit.length > 0 && criterionlessTaskCount > 0
+      ? `<div style="font-size:12.5px;color:var(--ink-faint)">${fmtNum(criterionlessTaskCount)} `
+        + `task${criterionlessTaskCount === 1 ? '' : 's'} in this goal ${criterionlessTaskCount === 1 ? 'is' : 'are'} linked to no criterion.</div>`
+      : '';
     return `<div style="display:flex;align-items:center;gap:16px">
         ${ring(sat, crit.length, g.status === 'achieved', ringSize)}
         <div>
           <div style="font-weight:650">${sat} of ${crit.length} criteria satisfied</div>
           <div style="font-size:12.5px;color:var(--ink-faint)">${line}</div>
+          ${unlinked}
         </div>
       </div>`;
   }
@@ -655,11 +666,11 @@
     // task 1002164 — an archived/achieved goal has nothing left to confirm.
     const canConfirm = g.status === 'open' && canConfirmCriteria();
     const band = $('#goal-completion-body');
-    if (band) band.innerHTML = completionSummaryHtml(g, crit, sat, 56) + critListHtml(crit.slice(0, CRITERIA_CAP), false, canConfirm);
+    if (band) band.innerHTML = completionSummaryHtml(g, crit, sat, 56, d.criterionless_task_count) + critListHtml(crit.slice(0, CRITERIA_CAP), false, canConfirm);
     renderViewAllFoot('#goal-completion-foot', crit.length, CRITERIA_CAP, 'completion', 'criteria');
     setCount('#goal-completion-count', crit.length);
     const full = $('#goal-completion-full');
-    if (full) full.innerHTML = completionSummaryHtml(g, crit, sat, 64) + critListHtml(crit, true, canConfirm);
+    if (full) full.innerHTML = completionSummaryHtml(g, crit, sat, 64, d.criterionless_task_count) + critListHtml(crit, true, canConfirm);
     const back = $('#goal-completion-back');
     if (back && state.current != null) back.setAttribute('href', `#/goal/${state.current}`);
   }

package/modules/lifecycle/db-deps-criteria.js

@@ -315,6 +315,28 @@ async function resolveCriterionIds(versionId, refs) {
   return { ids, unresolved };
 }
 
+// countTasksWithoutCriterionLink — task 1003157's DONE WHEN item 2: the count of
+// this goal's tasks linked to NO done-when criterion, so the gap the create-time
+// advisory nudges about is also visible on the goal's own detail view (GET
+// /goals/:id) without waiting for a builder to file another task. kind='bug' is
+// excluded for the same reason buildGoalAdvisory (goal-advisory.js) goes quiet
+// for one: a bug fix is the goal's "fix category" and needs no criterion, so
+// counting it here would make an intentional non-link read as a standing defect.
+// `executor` defaults to the module pool but is overridable — the findCycle /
+// unsatisfiedDeps seam in this same file — so it's unit-testable with a fake
+// SQL-recording client and needs no live Postgres.
+async function countTasksWithoutCriterionLink(goalId, executor = pool) {
+  const { rows } = await executor.query(
+    `SELECT COUNT(*)::int AS n
+       FROM tasks t
+      WHERE t.goal_id = $1
+        AND t.kind <> 'bug'
+        AND NOT EXISTS (SELECT 1 FROM task_criteria tc WHERE tc.task_id = t.id)`,
+    [goalId]
+  );
+  return rows[0]?.n ?? 0;
+}
+
 // Read the criteria linked to a task, with the live "Cn" position + link source.
 
 async function getTaskCriteria(taskId) {
@@ -425,6 +447,7 @@ module.exports = {
   addTaskCriterion,
   addTaskDependency,
   attachTaskDepSummaries,
+  countTasksWithoutCriterionLink,
   findCycle,
   findDependencyCycle,
   getTaskCriteria,

package/modules/lifecycle/db.js

@@ -130,6 +130,7 @@ const {
   addTaskCriterion,
   addTaskDependency,
   attachTaskDepSummaries,
+  countTasksWithoutCriterionLink,
   findCycle,
   findDependencyCycle,
   getTaskCriteria,
@@ -309,6 +310,7 @@ module.exports = {
   addTaskCriterion,
   removeTaskCriterion,
   linkTaskCriteria,
+  countTasksWithoutCriterionLink,
   claimTask,
   claimUniqueViolationError,
   claimTasksBatch,