npm - @bongos/core - Versions diffs - 1.19.483 → 1.19.485 - Mend

@bongos/core 1.19.483 → 1.19.485

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (35) hide show

package/.bongos-core.json +64 -44
package/.claude/skills/builder-setup/SKILL.md +2 -0
package/.claude/skills/design/SKILL.md +2 -1
package/docs/copy-inventory.md +163 -175
package/docs/copy-registry.json +265 -402
package/docs/file-map.md +1 -1
package/docs/module-api-changelog.md +4 -0
package/modules/hall-ui/public/not-ready.html +14 -10
package/modules/hall-ui/public/not-ready.states.json +14 -0
package/modules/hall-ui/public/pair.css +17 -67
package/modules/hall-ui/public/pair.html +8 -1
package/modules/hall-ui/public/pair.states.json +14 -0
package/modules/hall-ui/public/panel.css +333 -0
package/modules/hall-ui/public/profile.css +85 -0
package/modules/hall-ui/public/profile.html +12 -5
package/modules/hall-ui/public/profile.states.json +15 -0
package/modules/hall-ui/public/settings.css +119 -336
package/modules/hall-ui/public/settings.html +28 -19
package/modules/hall-ui/public/settings.js +44 -35
package/modules/hall-ui/public/settings.states.json +16 -0
package/modules/hall-ui/public/style.css +5 -2
package/package-lock.json +2 -2
package/package.json +1 -1
package/scripts/gds/claim.js +33 -2
package/scripts/gds/claude-materialize.js +20 -1
package/scripts/gds/discipline-modes.json +2 -1
package/scripts/gds/fitness-checks-vocabulary.js +0 -1
package/src/module-api.js +1 -1
package/tests/claude_materialize.mjs +76 -0
package/tests/hall_settings_world.mjs +274 -0
package/tests/join_application_note.mjs +7 -15
package/tests/module-scope-map.mjs +1 -1
package/modules/hall-ui/public/my-projects.css +0 -62
package/modules/hall-ui/public/my-projects.html +0 -73
package/modules/hall-ui/public/my-projects.js +0 -153

package/modules/hall-ui/public/settings.html CHANGED Viewed

@@ -9,9 +9,11 @@
   <link rel="preconnect" href="https://fonts.googleapis.com">
   <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
   <link rel="stylesheet" href="/builders/style.css?v=2026-07-02-shell1">
-  <!-- Page-local styles (task 2172) — extracted from the old inline <style>
-       block per the hall placement rules; the rail comes from style.css's
-       shared .section-rail/.rail-link rules. -->
+  <!-- The PANEL archetype (task 1003308): the row, the switch, the field, the
+       chip control and the family's voices, shared with profile, pair and
+       not-ready. settings.css then holds only what this page
+       has — the rail layout, the group head, the token ladder, the voices grid. -->
+  <link rel="stylesheet" href="/builders/panel.css">
   <link rel="stylesheet" href="/builders/settings.css">
 </head>
 <body data-page="settings" data-page-title="Settings">
@@ -22,15 +24,22 @@
   <div class="app-body">
     <header class="app-topbar" id="app-topbar"></header>
     <div class="app-content">
-      <div class="page-head"><p class="page-head__sub" id="settings-sub">Loading your preferences…</p></div>
+      <!-- The page's ONE h1 (one-header-main-h1): the page's own name in the
+           room voice, because here the document is the page. The sub-line is
+           settings.js's — "Your preferences, <name>." and the two failure states. -->
+      <div class="page-head page-head--room page-head--panel">
+        <h1 id="settings-h1" class="page-head__h">settings</h1>
+        <p class="page-head__sub" id="settings-sub">Loading your preferences…</p>
+      </div>
       <main id="hall-main">
         <!-- Not-signed-in notice — shown by settings.js before it redirects, and
              as a fallback if reading the viewer fails. Deliberately OUTSIDE the
              grouped layout: full-width, ungrouped. -->
-        <section class="scroll" id="gate-scroll" aria-labelledby="gate-h" hidden>
-          <h2 id="gate-h" class="scroll__h">Not signed in</h2>
-          <p class="scroll__lede" id="gate-body">You're not signed in yet. Sign in to manage your preferences.</p>
+        <section class="scroll gate" id="gate-scroll" aria-labelledby="gate-h" hidden>
+          <h2 id="gate-h" class="gate__h">Not signed in</h2>
+          <p class="gate__lede" id="gate-body">You're not signed in yet. Sign in to manage your connections, your keys, your dev box and the way the hall behaves.</p>
+          <div class="row-end"><a class="pbtn pbtn--save" href="/api/bongos/auth/web/start">Sign in</a></div>
         </section>
         <!-- Grouped layout (task 1723 → kit, task 2172): the sections sit in six
@@ -68,10 +77,11 @@
                 and the work feed. Your sign-in and the credit for shipped work stay
                 tied to your account, not this label.
               </p>
+              <label class="field-label" for="display-name-input">Display name</label>
               <div class="display-name-row">
                 <input type="text" class="display-name-input" id="display-name-input"
                        maxlength="60" autocomplete="off" spellcheck="false"
-                       aria-label="Display name" placeholder="Your display name">
+                       placeholder="Your display name">
                 <button type="button" class="craft-save" id="display-name-save">Save</button>
               </div>
               <p class="settings-status" id="display-name-status" role="status" aria-live="polite"></p>
@@ -158,7 +168,7 @@
               </p>
               <div id="sessions-list" class="sessions-list" aria-live="polite"></div>
               <div class="settings-card">
-                <button type="button" class="settings-btn" id="sessions-revoke-all">Sign out everywhere</button>
+                <button type="button" class="settings-btn settings-btn--quiet" id="sessions-revoke-all">Sign out everywhere</button>
                 <span class="settings-card__hint">ends every session including this one — you will be asked to sign in again.</span>
               </div>
               <p class="section-note">Ending a session takes effect immediately; the token stops working on its very next request.</p>
@@ -213,11 +223,11 @@
               <div class="settings-card">
                 <a class="settings-btn" href="/downloads/devbox/mac-arm64">Download for Mac</a>
                 <a class="settings-btn" href="/downloads/devbox/win-x64">Download for Windows</a>
-                <span class="settings-card__hint">Intel Mac? <a href="/downloads/devbox/mac-x64">This one</a>.
-                  ARM Windows (Surface, Snapdragon, Parallels)? <a href="/downloads/devbox/win-arm64">This one</a>.</span>
-                <!-- #924: latest-release courtesy line; populated from /downloads/devbox/version -->
-                <span class="settings-card__hint" id="boxapp-latest" hidden></span>
               </div>
+              <p class="panel-hint">Intel Mac? <a href="/downloads/devbox/mac-x64">This one</a>.
+                ARM Windows (Surface, Snapdragon, Parallels)? <a href="/downloads/devbox/win-arm64">This one</a>.
+                <!-- #924: latest-release courtesy line; populated from /downloads/devbox/version -->
+                <span id="boxapp-latest" hidden></span></p>
               <p class="section-note">
                 First open: your computer warns about an unknown developer — expected
                 (we haven't bought the signing certificates yet; the app is ours).
@@ -252,7 +262,7 @@
                 claimed task. It never limits the work on the task itself. Your rank
                 sets the starting point; newcomers stay locked low.
               </p>
-              <div class="sound-rows" id="wander-rows"></div>
+              <div class="prows" id="wander-rows" role="radiogroup" aria-labelledby="wandering-h"></div>
               <p class="settings-status" id="wandering-status" role="status" aria-live="polite"></p>
               <p class="section-note" id="wandering-note"></p>
             </section>
@@ -287,7 +297,7 @@
               <div class="voices-wrap">
                 <table class="voices" id="voices-table">
                   <thead>
-                    <tr><th>Skill</th><th>Default</th><th>Your choice</th></tr>
+                    <tr><th scope="col">Skill</th><th scope="col">Default</th><th scope="col">Your choice</th></tr>
                   </thead>
                   <tbody id="voices-body"></tbody>
                 </table>
@@ -305,9 +315,8 @@
                 any you would rather not hear.
               </p>
               <div class="sound-volume" id="sound-volume" hidden>
-                <span class="sound-volume__label">Volume</span>
-                <input type="range" id="sound-volume-range" min="0" max="100" step="5" value="100"
-                       aria-label="Master sound volume">
+                <label class="field-label" for="sound-volume-range">Volume</label>
+                <input type="range" id="sound-volume-range" min="0" max="100" step="5" value="100">
                 <span class="sound-volume__pct" id="sound-volume-pct">100%</span>
               </div>
               <div class="sound-rows" id="sound-rows"></div>
@@ -360,7 +369,7 @@
 <script src="/builders/task-detail.js?v=2026-07-03-taskdetail"></script>
 <!-- #807: shared dev-box panel — loaded before settings.js so OTBBoxPanel exists. -->
 <script src="/builders/box-panel.js?v=2026-06-14-domutils"></script>
-<script src="/builders/settings.js?v=2026-07-10-regroup"></script>
+<script src="/builders/settings.js?v=2026-09-02-panel"></script>
 <!-- task 1003341: the Active sessions panel. Its own file rather than more of
      settings.js, which sits close to the 1500-line size ratchet. -->
 <script src="/builders/settings-sessions.js?v=2026-08-29-sessions"></script>

package/modules/hall-ui/public/settings.js CHANGED Viewed

@@ -134,6 +134,15 @@
   // Render one row per sound from `effective`. Each row: label + description and
   // an On/Off toggle button whose data-on reflects the effective enabled-state.
+  // The family switch (panel.css `.sw`): a role=switch button whose state is
+  // aria-checked, drawn as a track and a knob. Keeps the `.sound-toggle` class
+  // and `data-on`, which every delegated click handler on this page reads.
+  function switchHtml(on, label, extraAttrs = '') {
+    return `<button type="button" class="sound-toggle sw" role="switch" aria-checked="${on ? 'true' : 'false'}" ` +
+      `aria-label="${escapeHtml(label)}" data-on="${on ? '1' : '0'}"${extraAttrs}>` +
+      '<span class="sw__track"></span><span class="sw__knob"></span></button>';
+  }
   function renderSounds(data) {
     const wrap = $('#sound-rows');
     if (!wrap) return;
@@ -150,9 +159,7 @@
         `<div class="sound-row__label">${escapeHtml(row.label || row.sound)}</div>` +
         `<div class="sound-row__desc">${escapeHtml(row.desc || '')}</div>` +
         '</div>' +
-        `<button type="button" class="sound-toggle" data-sound="${escapeHtml(row.sound)}" ` +
-        `data-on="${on ? '1' : '0'}" aria-pressed="${on ? 'true' : 'false'}">` +
-        `${on ? 'On' : 'Off'}</button>` +
+        switchHtml(on, `Sound: ${row.label || row.sound}`, ` data-sound="${escapeHtml(row.sound)}"`) +
         '</div>'
       );
     }).join('');
@@ -405,25 +412,23 @@
       wrap.innerHTML = window.OTBKit.emptyStateHtml('No levels registered.');
       return;
     }
+    // One pick among four: a radio row per level (panel.css `.prow--pick`), the
+    // whole row its label. A level above the rank ceiling is a disabled radio
+    // that says so in the label voice rather than a dead "Rank-locked" button.
     wrap.innerHTML = levels.map((lv) => {
       const chosen = lv.n === eff;
-      const tag = lv.n === def ? ' <span class="voices__default">· default for your rank</span>' : '';
-      let btn;
-      if (!lv.allowed) {
-        btn = `<button type="button" class="sound-toggle" disabled data-level="${lv.n}" data-on="0">Rank-locked</button>`;
-      } else if (chosen) {
-        btn = `<button type="button" class="sound-toggle" data-level="${lv.n}" data-on="1" aria-pressed="true">Chosen</button>`;
-      } else {
-        btn = `<button type="button" class="sound-toggle" data-level="${lv.n}" data-on="0" aria-pressed="false">Choose</button>`;
-      }
+      const locked = !lv.allowed;
+      const id = `wander-${lv.n}`;
+      const tags = (lv.n === def ? '<span class="prow__tag">default for your rank</span>' : '') +
+        (locked ? '<span class="prow__tag">rank-locked</span>' : '');
       return (
-        `<div class="sound-row" data-level="${lv.n}">` +
-        '<div class="sound-row__text">' +
-        `<div class="sound-row__label">${escapeHtml(lv.label)}${tag}</div>` +
-        `<div class="sound-row__desc">${escapeHtml(lv.blurb || '')}</div>` +
-        '</div>' +
-        btn +
-        '</div>'
+        `<label class="prow prow--pick" for="${id}" data-level="${lv.n}"${locked ? ' aria-disabled="true"' : ''}>` +
+        `<input class="pradio" type="radio" name="wandering" id="${id}" value="${lv.n}"` +
+        `${chosen ? ' checked' : ''}${locked ? ' disabled' : ''}>` +
+        '<span class="prow__main">' +
+        `<span class="prow__label">${escapeHtml(lv.label)}${tags}</span>` +
+        `<span class="prow__desc">${escapeHtml(lv.blurb || '')}</span>` +
+        '</span></label>'
       );
     }).join('');
     const note = $('#wandering-note');
@@ -466,13 +471,13 @@
       const data = res.data;
       renderWandering(data);
       $('#wandering-scroll').hidden = false;
-      // Delegate clicks so post-render buttons stay wired (single-select).
+      // Delegate the change so post-render radios stay wired (single-select).
       const wrap = $('#wander-rows');
-      wrap.addEventListener('click', (e) => {
-        const b = e.target.closest('.sound-toggle');
-        if (!b || b.disabled || b.dataset.on === '1') return; // ignore locked + already-chosen
-        const level = Number(b.dataset.level);
-        if (Number.isInteger(level)) saveWandering(level, b);
+      wrap.addEventListener('change', (e) => {
+        const r = e.target.closest('.pradio');
+        if (!r || r.disabled || !r.checked) return; // ignore locked; a radio only fires on becoming checked
+        const level = Number(r.value);
+        if (Number.isInteger(level)) saveWandering(level, r);
       });
     } catch (err) {
       console.error('[settings] failed to load wandering', err);
@@ -497,11 +502,11 @@
       '<div class="sound-row" data-render="widgets">' +
       '<div class="sound-row__text">' +
       '<div class="sound-row__label">Rich in-feed cards' +
-      (isDefault ? ' <span class="voices__default">· default (on)</span>' : '') +
+      (isDefault ? '<span class="prow__tag">default (on)</span>' : '') +
       '</div>' +
       '<div class="sound-row__desc">Render session cards as widgets (prettier, costs tokens) instead of plain text (cheaper, identical info).</div>' +
       '</div>' +
-      `<button type="button" class="sound-toggle" data-on="${on ? '1' : '0'}" aria-pressed="${on ? 'true' : 'false'}">${on ? 'On' : 'Off'}</button>` +
+      switchHtml(on, 'Rich in-feed cards') +
       '</div>';
   }
@@ -579,7 +584,7 @@
       '<div class="sound-row__label">Show my cross-project record</div>' +
       `<div class="sound-row__desc">${escapeHtml(totalsLine + consentNote)} You always see your own numbers here.</div>` +
       '</div>' +
-      `<button type="button" class="sound-toggle" data-on="${on ? '1' : '0'}" aria-pressed="${on ? 'true' : 'false'}">${on ? 'Shown' : 'Hidden'}</button>` +
+      switchHtml(on, 'Show my cross-project record') +
       '</div>';
   }
@@ -637,10 +642,10 @@
   function privacyRow(key, label, state, on, desc, note) {
     return `<div class="sound-row" data-privacy="${key}">` +
       '<div class="sound-row__text">' +
-      `<div class="sound-row__label">${escapeHtml(label)}${note}</div>` +
+      `<div class="sound-row__label">${escapeHtml(label)}<span class="prow__tag">${escapeHtml(state)}</span>${note}</div>` +
       `<div class="sound-row__desc">${escapeHtml(desc)}</div>` +
       '</div>' +
-      `<button type="button" class="sound-toggle" data-on="${on ? '1' : '0'}" aria-pressed="${on ? 'true' : 'false'}">${state}</button>` +
+      switchHtml(on, `${label}: ${state}`) +
       '</div>';
   }
@@ -976,11 +981,14 @@
       const body = (res.data || {});
       if (!res.ok) throw new Error(body.message || `HTTP ${res.status}`);
       const expires = body.expires_at ? new Date(body.expires_at).toLocaleString() : 'unknown';
+      // The secret is QUOTED (settings.css `.quote`): a 64-character token cannot
+      // be a line of prose, so it sits one tonal step down with its own foot.
       result.innerHTML =
-        '<p>Fresh CLI token issued. Paste it in your terminal:</p>' +
-        `<pre>${escapeHtml(body.paste_command || '')}</pre>` +
-        '<p><button type="button" class="settings-btn" id="cli-reissue-copy">Copy</button>' +
-        `<span class="settings-card__hint" style="margin-left:0.6rem;">Expires ${escapeHtml(expires)} · refreshes on use.</span></p>`;
+        '<p class="cli-result__say">Fresh CLI token issued. Paste it in your terminal:</p>' +
+        '<div class="quote"><p class="quote__eyebrow">paste command</p>' +
+        `<pre class="quote__pre">${escapeHtml(body.paste_command || '')}</pre>` +
+        '<div class="quote__foot"><button type="button" class="settings-btn settings-btn--quiet" id="cli-reissue-copy">Copy</button>' +
+        `<span class="settings-card__hint">Expires ${escapeHtml(expires)} · refreshes on use.</span></div></div>`;
       result.hidden = false;
       const copyBtn = $('#cli-reissue-copy');
       if (copyBtn) copyBtn.addEventListener('click', async () => {
@@ -1037,10 +1045,11 @@
   function artKeyEntryHtml() {
     return (
+      '<label class="field-label" for="artkey-input">Your key</label>' +
       '<div class="artkey-entry-row">' +
       '<input type="password" class="artkey-input" id="artkey-input" autocomplete="off" ' +
       'spellcheck="false" placeholder="Paste your Google AI Studio key">' +
-      '<button type="button" class="settings-btn" id="artkey-save">Save key</button>' +
+      '<button type="button" class="settings-btn craft-save" id="artkey-save">Save key</button>' +
       '</div>' +
       `<p class="settings-card__hint">${getOneLink} · Stored encrypted; never shown again after saving.</p>`
     );

package/modules/hall-ui/public/settings.states.json ADDED Viewed

@@ -0,0 +1,16 @@
+{
+  "_": "The hall's SETTINGS page through modules/ui-design/kit/render.js (task 1003308). Every panel on it is a form the page script fills from a dozen /me/* reads, so the floors run against the hall-preview harness rather than the kit's own stub:\n\n  node scripts/hall-preview/server.js --port 4621 --fixture-me\n  node modules/ui-design/kit/render.js --states modules/hall-ui/public/settings.states.json --base-in http://builders.localhost:4621 --base-out http://builders.localhost:4621\n\nOne group renders at a time behind the section rail, so each rail group is its own state. There is no `out` state on purpose: settings.js answers a 401 by navigating to the sign-in flow, and a state whose page navigates away measures the destination, not this page (the not-signed-in gate panel is the non-401 failure render, pinned statically in tests/hall_settings_world.mjs).",
+  "page": "/settings",
+  "surface": "hall-ui",
+  "stub": { "prefix": "/builders/" },
+  "modeQuery": false,
+  "ignoreRequests": ["/api/(gds|bongos)/", "/downloads/devbox/"],
+  "ignoreConsole": ["/api/(gds|bongos)/", "/downloads/devbox/", "\b401\b", "\b404\b", "Unauthorized", "Not Found", "load failed", "Password field"],
+  "states": {
+    "account": { "auth": true, "actions": [["wait", 900]], "expect": { "visible": ["#settings-h1", "#display-name-input", "#craft-chips", "#privacy-rows"] } },
+    "access": { "auth": true, "url": "/settings#access", "actions": [["wait", 900]], "expect": { "visible": ["#cli-reissue-btn", "#sessions-list", "#artkey-card"] } },
+    "preferences": { "auth": true, "url": "/settings#preferences", "actions": [["wait", 900]], "expect": { "visible": ["#wander-rows", "#render-rows"] } },
+    "sound": { "auth": true, "url": "/settings#sound", "actions": [["wait", 900]], "expect": { "visible": ["#voices-table", "#sound-rows", "#event-sound-rows"] } }
+  },
+  "reducedMotion": { "auth": true, "actions": [["wait", 900]] }
+}

package/modules/hall-ui/public/style.css CHANGED Viewed

@@ -1693,7 +1693,10 @@ main [id] { scroll-margin-top: calc(var(--topbar-h) + 16px); }
   color: var(--ink-soft);
 }
 .profile__disc-label { color: var(--ink-faint); }
-.profile__disc-edit { font-size: 12.5px; }
+/* task 1003308: a link in the Standing card's fact line is a control and owes
+   the 24px floor (it measured 123x19); the prose-link recipe buys the height
+   with padding and hands the width back with the negative margin. */
+.profile__disc-edit { display: inline-block; min-width: 24px; min-height: 24px; padding: 3px 4px; margin: -3px -4px; font-size: 12.5px; }
 .profile__credits {
   display: flex;
   flex-direction: column;
@@ -1731,7 +1734,7 @@ main [id] { scroll-margin-top: calc(var(--topbar-h) + 16px); }
 .profile__budget--over { background: var(--danger-weak); color: var(--danger); border-color: color-mix(in srgb, var(--danger) 25%, transparent); }
 .profile__needs--action { background: var(--warn-weak); color: var(--warn); border-color: color-mix(in srgb, var(--warn) 25%, transparent); }
 .profile__needs--covered { background: var(--ok-weak); color: var(--ok); border-color: color-mix(in srgb, var(--ok) 22%, transparent); }
-.profile__needs-act { font-weight: 600; white-space: nowrap; }
+.profile__needs-act { display: inline-block; min-width: 24px; min-height: 24px; padding: 3px 4px; margin: -3px -4px; font-weight: 600; white-space: nowrap; }
 /* ADR 0120 part 5: owed-rebase gate banner — danger-tinted (it blocks new claims). */
 .profile__rebase { background: var(--danger-weak); color: var(--danger); border-color: color-mix(in srgb, var(--danger) 25%, transparent); }

package/package-lock.json CHANGED Viewed

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.483",
+  "version": "1.19.485",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.483",
+      "version": "1.19.485",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.483",
+  "version": "1.19.485",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/claim.js CHANGED Viewed

@@ -67,18 +67,49 @@ async function printRelevantLearnings(task) {
 // invalid map, or a discipline with no entry (engineer/artist today), prints
 // nothing and never breaks a successful claim.
 function printDisciplineMode(task) {
+  let mode = null;
   try {
     const discipline = task && task.discipline;
     if (!discipline) return;
     const raw = fs.readFileSync(path.join(__dirname, 'discipline-modes.json'), 'utf8');
     const modes = (JSON.parse(raw) || {}).modes || {};
-    const mode = modes[discipline];
+    mode = modes[discipline];
     if (!mode || !mode.directive) return;
     console.log('');
     console.log(`▶ ${mode.label || 'Working mode'} — /${mode.skill}`);
     console.log(`  ${mode.directive}`);
   } catch (_) {
     // never let the mode hint break a successful claim
+    return;
+  }
+  materializeModeSkills(mode);
+}
+// A task brings its own tools (task 1003486). A mode whose entry opts in with
+// `materializeModuleSkills` lands the module-owned skills its playbook names — for
+// `ui`, the ui-design taste kit /design sends the session to use — into THIS
+// checkout's .claude/skills/, as the untracked, self-ignored copies ADR 0224 defined.
+// Without it a builder is routed to /design, reads that impeccable and minimalist-ui
+// are the tools, and finds none of them on the machine with no error saying why.
+// Carried by the claim rather than a hook or a session start because a workbench is
+// not re-provisioned every session (owner decision 2026-09-02): it runs only when
+// someone actually claims work of that discipline.
+//
+// Fail-open in every branch, like the hint above it: the server already granted the
+// claim, so nothing here may throw past this point — a failure prints the one command
+// that does it by hand. The require is lazy so a claim of any other discipline never
+// pays for loading the materialiser (and a broken materialiser cannot stop a claim).
+function materializeModeSkills(mode) {
+  if (!mode || mode.materializeModuleSkills !== true) return;
+  try {
+    const { materializeModuleSkillsIntoCore, isCoreCheckoutRoot } = require('./claude-materialize');
+    const coreRoot = path.resolve(__dirname, '..', '..');
+    if (!isCoreCheckoutRoot(coreRoot)) return; // a scaffolded instance already has them from `bongos init`
+    const s = materializeModuleSkillsIntoCore({ coreRoot });
+    const n = s.materialized.length;
+    if (n) console.log(`  ✓ ${n} module-owned skill(s) for this mode are in .claude/skills/ (untracked copies — ADR 0224).`);
+  } catch (e) {
+    console.log(`  ⚠ could not land this mode's module-owned skills — run \`node scripts/gds/claude-materialize.js --module-skills-only\` (${e && e.message}).`);
   }
 }
@@ -638,4 +669,4 @@ if (require.main === module) {
   });
 }
-module.exports = { formatClaimFailure, claimErrorInfo, goalMembershipOfferPlan };
+module.exports = { formatClaimFailure, claimErrorInfo, goalMembershipOfferPlan, materializeModeSkills };

package/scripts/gds/claude-materialize.js CHANGED Viewed

@@ -28,6 +28,7 @@ const path = require('node:path');
 const { spawnSync } = require('node:child_process');
 const { VERBS } = require('../../bin/bongos.js'); // side-effect-free require (guarded main)
 const ic = require('../../src/instance-config'); // neutral configDir/envPrefix fallbacks (never a founder literal)
+const { isCorePackageName } = require('../../src/module-loader/catalog'); // one definition of "this checkout IS the core"
 const { renderInstanceClaudeMd } = require('./claude-md-template'); // task 2104 — the starter CLAUDE.md
 // script basename (e.g. "ship.js") → dedicated bongos verb, for verbs that map to a bare script with
@@ -469,6 +470,24 @@ function materializeClaude({ coreRoot, instanceDir, dryRun = false, overwrite =
 // core's own tracked .claude/skills/ carries is left to the core. Idempotent: every run first
 // removes what the last manifest named (so a skill a module stopped declaring does not
 // linger), then lands the current set; `clean` stops after the removal.
+// Is `root` the core CHECKOUT — a workbench a builder edits — rather than the core
+// package installed under a scaffolded instance's node_modules? Only a checkout's own
+// .claude/skills/ is the directory Claude Code reads for that project, so only there
+// does materialising the module-owned skills put them in front of anyone; an instance
+// already received them at ITS root from `bongos init`, and a second copy under
+// node_modules/@bongos/core would be invisible (task 1003486). Fail-soft by
+// construction: an unreadable package.json answers "not the core checkout", which is
+// the conservative no-op rather than a copy into a tree we could not identify.
+function isCoreCheckoutRoot(root) {
+  try {
+    const abs = path.resolve(root);
+    if (abs.split(/[\\/]+/).includes('node_modules')) return false;
+    return isCorePackageName(JSON.parse(fs.readFileSync(path.join(abs, 'package.json'), 'utf8')).name);
+  } catch (_) {
+    return false;
+  }
+}
 const MODULE_SKILLS_MANIFEST = '.module-skills.json';
 function readModuleSkillsManifest(skillsDir) {
   const m = readJsonSafe(path.join(skillsDir, MODULE_SKILLS_MANIFEST));
@@ -535,4 +554,4 @@ if (require.main === module) {
   process.exit(s.refused.length ? 1 : 0);
 }
-module.exports = { scriptToVerb, bongosify, transformSettings, copyTreeTransformed, materializeClaude, materializeModuleSkillsIntoCore, readModuleSkillsManifest, MODULE_SKILLS_MANIFEST, GDS_INVOCATION_RE, buildRebrandRules, rebrandText, disabledModuleSkills, moduleSkillRoster, moduleSkillSources, vendoredSkillGate, SKILL_NAME_RE, VENDOR_DEFAULT_POLICY };
+module.exports = { scriptToVerb, bongosify, transformSettings, copyTreeTransformed, materializeClaude, materializeModuleSkillsIntoCore, isCoreCheckoutRoot, readModuleSkillsManifest, MODULE_SKILLS_MANIFEST, GDS_INVOCATION_RE, buildRebrandRules, rebrandText, disabledModuleSkills, moduleSkillRoster, moduleSkillSources, vendoredSkillGate, SKILL_NAME_RE, VENDOR_DEFAULT_POLICY };

package/scripts/gds/discipline-modes.json CHANGED Viewed

@@ -1,5 +1,5 @@
 {
-  "_doc": "Discipline -> operating-playbook map (task 1267). A discipline whose work is best done as a *mode of working* rather than the default claim->build->ship loop names the skill that IS its playbook here. claim.js reads this after a successful claim: if the claimed task's `discipline` has an entry, it prints the entry's `directive` so the session opens the right playbook. There is NO classification step at claim time — `discipline` is already a column on the task. This is the whole discipline-fork mechanism: one carrier (the claim the builder already runs), one data lookup, no hooks, the Conductor untouched. Absence of an entry is the default: engineer and artist are intentionally NOT listed, so their claim output is unchanged and they stay in the standard build-and-ship loop. To give a discipline its own experience later, add an entry here and write the skill — no code change in claim.js. A missing or invalid version of this file must never break a claim (claim.js fails open).",
+  "_doc": "Discipline -> operating-playbook map (task 1267). A discipline whose work is best done as a *mode of working* rather than the default claim->build->ship loop names the skill that IS its playbook here. claim.js reads this after a successful claim: if the claimed task's `discipline` has an entry, it prints the entry's `directive` so the session opens the right playbook. There is NO classification step at claim time — `discipline` is already a column on the task. This is the whole discipline-fork mechanism: one carrier (the claim the builder already runs), one data lookup, no hooks, the Conductor untouched. Absence of an entry is the default: engineer and artist are intentionally NOT listed, so their claim output is unchanged and they stay in the standard build-and-ship loop. To give a discipline its own experience later, add an entry here and write the skill — no code change in claim.js. A missing or invalid version of this file must never break a claim (claim.js fails open). A mode entry may also set `\"materializeModuleSkills\": true` to have the claim land that mode's module-owned skills into this checkout's .claude/skills/ (task 1003486) — opt-in per discipline, core-checkout only, and fail-open like the hint itself, so a discipline that omits it claims exactly as before.",
   "modes": {
     "engineer": {
       "skill": "dev",
@@ -18,6 +18,7 @@
     },
     "ui": {
       "skill": "design",
+      "materializeModuleSkills": true,
       "label": "UI design session",
       "directive": "This is a UI task — interface DESIGN work (layout, wireframes, design systems, Figma / Claude-Design), split out of the pixel-art `artist` lane (ADR 0079). To work it, invoke the /design skill — the operating playbook for UI-design sessions, the only place the experience is defined. Like /paint it is show-first: communicate in mock-ups and rendered screens, not paragraphs about layout decisions — stage the change on your sandbox preview (/builder-stage) and look at the real interface before shipping. Keep the locked branding (config/branding.json) and the existing component conventions of the surface you touch (modules/status-ui, modules/hall-ui, public/game/ui). If no human is present (autonomous / bypass-permissions), produce the design, stage it for review, and park the screens rather than shipping interface changes blind. Open /design now rather than working this task the default way."
     }

package/scripts/gds/fitness-checks-vocabulary.js CHANGED Viewed

@@ -118,7 +118,6 @@ const GOAL_VOCAB_SURFACE = [
   // The FIFTH use (task 1003090): the hub's coarse project membership.
   'modules/platform-identity/platform-identity.js',
   'modules/platform-identity/routes/my-projects.js',
-  'modules/hall-ui/public/my-projects.js',
 ];
 // modules/lifecycle/db.js is 5k+ lines and legitimately says "role" about ranks
 // (the rank-sync port, builders.system_role). Scanning it whole would need an

package/src/module-api.js CHANGED Viewed

@@ -34,7 +34,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.483'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.485'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/claude_materialize.mjs CHANGED Viewed

@@ -9,6 +9,9 @@
 //   3. transformSettings — rewrites only the scripts/gds hook commands, keeps .claude/hooks/ ones.
 //   4. materializeClaude — copies + transforms skills into a target dir (no leftover node scripts/gds),
 //      writes settings.json, copies hooks; and NO-OPS when the target IS the core root (self-copy guard).
+//   5. task 1003486 — a UI task brings its own tools: the `materializeModuleSkills` opt-in on a
+//      discipline-modes entry, the core-checkout probe that keeps it out of a scaffolded instance,
+//      and the fail-open contract (a materialise error never breaks a claim the server already granted).
 //
 // Run:  node tests/claude_materialize.mjs
@@ -22,6 +25,7 @@ import { fileURLToPath } from 'node:url';
 const require = createRequire(import.meta.url);
 const ROOT = join(dirname(fileURLToPath(import.meta.url)), '..');
 const m = require('../scripts/gds/claude-materialize.js');
+const claim = require('../scripts/gds/claim.js');
 let passed = 0;
 let failed = 0;
@@ -484,5 +488,77 @@ t('--module-skills-only: the CLI entry refuses without the flag (usage, exit 2)
   rmSync(dir, { recursive: true, force: true });
 });
+// ---- task 1003486: claiming a ui task lands /design's tools in the checkout ----
+t('the materialise-at-claim trigger is DATA: the ui mode opts in, every other discipline claims exactly as before', () => {
+  const modes = JSON.parse(readFileSync(join(ROOT, 'scripts', 'gds', 'discipline-modes.json'), 'utf8')).modes;
+  assert.equal(modes.ui.materializeModuleSkills, true, 'a ui claim brings the skills /design names');
+  assert.equal(modes.ui.skill, 'design', 'and still routes to /design');
+  for (const d of ['engineer', 'ideator', 'artist']) {
+    assert.ok(!modes[d].materializeModuleSkills, `${d} did not opt in, so its claim output is unchanged`);
+  }
+});
+t('isCoreCheckoutRoot: true for a real core checkout, false for the core installed into an instance, false for anything unreadable', () => {
+  assert.equal(m.isCoreCheckoutRoot(ROOT), true, 'this checkout names itself the core and is not under node_modules');
+  assert.equal(m.isCoreCheckoutRoot(join(ROOT, 'node_modules', '@bongos', 'core')), false,
+    'a scaffolded instance runs claim.js from node_modules — materialising there would be invisible');
+  const other = mkdtempSync(join(tmpdir(), 'cm-not-core-'));
+  writeFileSync(join(other, 'package.json'), JSON.stringify({ name: 'some-instance' }));
+  assert.equal(m.isCoreCheckoutRoot(other), false, 'another checkout is that instance, not the core');
+  assert.equal(m.isCoreCheckoutRoot(join(other, 'nope')), false, 'an unreadable tree answers no — the conservative no-op');
+  rmSync(other, { recursive: true, force: true });
+});
+t('materializeModeSkills: a discipline that did not opt in does nothing, and a materialise failure prints one hint instead of breaking the claim', () => {
+  const lines = [];
+  const realLog = console.log;
+  console.log = (...a) => lines.push(a.join(' '));
+  const mPath = require.resolve('../scripts/gds/claude-materialize.js');
+  const realExports = require.cache[mPath].exports;
+  try {
+    for (const mode of [null, undefined, {}, { skill: 'dev' }, { materializeModuleSkills: false }, { materializeModuleSkills: 'yes' }]) {
+      claim.materializeModeSkills(mode);
+    }
+    assert.deepEqual(lines, [], 'no opt-in => nothing printed and nothing copied');
+    // forced failure in the materialise step: swallowed, one line, the manual command named
+    require.cache[mPath].exports = {
+      isCoreCheckoutRoot: () => true,
+      materializeModuleSkillsIntoCore: () => { throw new Error('disk on fire'); },
+    };
+    claim.materializeModeSkills({ materializeModuleSkills: true });
+    assert.equal(lines.length, 1, 'exactly one line, not a wall');
+    assert.match(lines[0], /claude-materialize\.js --module-skills-only/, 'the hint names the command that does it by hand');
+    assert.match(lines[0], /disk on fire/, 'and why it could not');
+    // a tree that is not the core checkout is a no-op even with the flag on
+    lines.length = 0;
+    require.cache[mPath].exports = {
+      isCoreCheckoutRoot: () => false,
+      materializeModuleSkillsIntoCore: () => { throw new Error('must never be called in an instance'); },
+    };
+    claim.materializeModeSkills({ materializeModuleSkills: true });
+    assert.deepEqual(lines, [], 'in a scaffolded instance the claim is unchanged — init already landed them');
+  } finally {
+    require.cache[mPath].exports = realExports;
+    console.log = realLog;
+  }
+});
+t('materializeModeSkills lands the real module-owned skills, self-ignored, and is byte-identical on a re-claim', () => {
+  const core = fakeCore();
+  // the real function resolves its own coreRoot, so drive the library the way it does
+  const first = m.materializeModuleSkillsIntoCore({ coreRoot: core });
+  assert.deepEqual(first.materialized, ['alpha']);
+  const manifest1 = readFileSync(join(core, '.claude', 'skills', m.MODULE_SKILLS_MANIFEST), 'utf8');
+  const ignore = readFileSync(join(core, '.claude', 'skills', '.gitignore'), 'utf8');
+  assert.ok(ignore.split('\n').includes('/alpha/'), 'a re-claim leaves git status clean: the copy ignores itself');
+  const second = m.materializeModuleSkillsIntoCore({ coreRoot: core });
+  assert.deepEqual(second.materialized, ['alpha'], 'idempotent: the re-claim lands the same set');
+  assert.equal(readFileSync(join(core, '.claude', 'skills', m.MODULE_SKILLS_MANIFEST), 'utf8'), manifest1, 'byte-identical manifest');
+  rmSync(core, { recursive: true, force: true });
+});
 console.log(`\nclaude_materialize: ${passed} passed, ${failed} failed`);
 process.exit(failed ? 1 : 0);