@bongos/core 1.19.466 → 1.19.468

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.466",
-  "core_contract": "1.19.466",
-  "source_commit": "5b915c14235b08df52728e3d94dc196d548791a3",
+  "core_version": "1.19.468",
+  "core_contract": "1.19.468",
+  "source_commit": "46a154331618a8c57ed0d178e7bfe13e180b7559",
   "source_ref": "HEAD",
-  "built_at": "2026-09-02T02:25:23.295Z",
+  "built_at": "2026-09-02T14:11:23.358Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
-    "docs_redacted": 407,
+    "docs_redacted": 408,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 1822,
+    "functional_verbatim": 1823,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2253,
-  "tree_sha256": "4bb527a26dc80efbf88ff9d1a853737b1a657a8f300f8fbf01e76b4146834f58",
+  "file_count": 2255,
+  "tree_sha256": "96abcd9bb3bfd8f8bfc4930c27fe91aa04b9f59717743a5b059f768854c865c3",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -1629,10 +1629,15 @@
       "mode": "0000644",
       "sha256": "717bdc174891ccf5bc8756b25f53eca016d4d6dfaeebec8d12bb2a6bfef56976"
     },
+    {
+      "path": "docs/adr/0225-privacy-suppresses-cross-project-surfaces-only.md",
+      "mode": "0000644",
+      "sha256": "f9f3a0b8ebe2d161e17e1c632bbbda71842c9476958294330420f28c6301f7db"
+    },
     {
       "path": "docs/adr/README.md",
       "mode": "0000644",
-      "sha256": "ec731cb900dc5b30287a370325042a4ead509759aba5688c32d91f293047c491"
+      "sha256": "7b353237a164c704ac247646b93c419b26cc5fd8e53ac81e63b553146df76c85"
     },
     {
       "path": "docs/api-reference.md",
@@ -2122,7 +2127,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "5e800493043ac5941fa8ed5f9efc66359a0622f79968fd7158a61651556c1cf3"
+      "sha256": "b0ee40d833a5f28cba9450cc355d4b2b922def1e95fed5725ebee8796f2918a6"
     },
     {
       "path": "docs/modules-contract.md",
@@ -3612,7 +3617,7 @@
     {
       "path": "modules/economy/credits.js",
       "mode": "0000644",
-      "sha256": "2269a87709349cd410bad2714189788d24c1edff3e654af5b47aacb93c415cdb"
+      "sha256": "06f1cc7080509864ea4f474627a7a35de8348fcf4f935a13fc62da38e2a67fa8"
     },
     {
       "path": "modules/economy/migrations/economy_001_fix_gds_shipper_description.sql",
@@ -3632,7 +3637,7 @@
     {
       "path": "modules/economy/reward.js",
       "mode": "0000644",
-      "sha256": "59952daf3cb8cadc33f5249fb07552949d390ba37c71299117a2d503f83e422a"
+      "sha256": "13cc932402c3cf0d2154507c6e6a462aeb98520a2214b8561ec01a6bb9245fd6"
     },
     {
       "path": "modules/economy/routes/cost.js",
@@ -6622,12 +6627,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "098654f260139d3b7b4d45ef87d7a15c3ca8a0ebb04ce36ba538e212c3dce351"
+      "sha256": "775fa829d773f6c39be8c93c544e77c005304ff78a3c879778292fd5dc806ee8"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "9670afc099badbbc922edd16e4cb6a1a99d370267cc15b2232af678b6c65f7b0"
+      "sha256": "0d5b71ad68cce7afe9f0d4b35f8f4105fad5f00f46e91f60659ebf064f288f62"
     },
     {
       "path": "public-docs/index.html",
@@ -8277,7 +8282,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "400ed351948806a44d6558bbc10d35158237d80c3101415acebb6d075747c3ae"
+      "sha256": "97199ab275115c07426ca83be7b0c618b3aebdb4b1e9349ab90ea989f8d625b4"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -9794,6 +9799,11 @@
       "mode": "0000644",
       "sha256": "63afe2afd59ff64e290234a0cc8d33a0f77b784d8c10c2d7147fe2ab3c114cd1"
     },
+    {
+      "path": "tests/idea_governance_pass_credit.mjs",
+      "mode": "0000644",
+      "sha256": "75af0cfce88da50c74a1c499e7308774b70eb05e31a3274246dd6b4c8fdb1b34"
+    },
     {
       "path": "tests/idea_grades.mjs",
       "mode": "0000644",

package/docs/adr/0225-privacy-suppresses-cross-project-surfaces-only.md

@@ -0,0 +1,84 @@
+# 0225 — Privacy suppresses cross-project surfaces only: a private builder still appears on their own project's roster
+
+- **Status:** Accepted
+- **Date:** 2026-09-02
+- **Tasks:** [#1003443](https://cloudbongos.com/builders#/task/1003443) (goal 1000075 — collaboration and the social hall; criterion `community-is-one-builders-page`)
+- **Related:** [ADR 0171](<redacted>.md) (owns `hide_stats` + `profile_state`, fail-closed consent in the READ path) · [`docs/specs/<redacted>.md`](../specs/<redacted>.md) (the spec this amends)
+
+## 1. Why this ADR exists
+
+The privacy spec is **accepted**, and for one case it defined its two flags
+inconsistently. Found 2026-08-30 while scoping the Builders page:
+
+- `hide_stats` suppresses *"everything derived from the **cross-project rollup**"* —
+  qualified, so a project's own in-hall leaderboard is plainly out of scope.
+- `account_visibility: private` said *"absent from search, **leaderboards**, sitemap"* —
+  **not** qualified, so it read as covering the in-project leaderboard too.
+
+Two readers could act on the same accepted spec and build opposite behaviour. Worse,
+PV2 requires *"ONE shared predicate used by every public read: … leaderboards …"*,
+while `modules/economy/credits.js`'s `leaderboard()` is a bare
+`SELECT … FROM builders ORDER BY total_credits DESC` — no join to
+`platform_identity_accounts`, no predicate at all. Read one way that is an unshipped
+PV2 violation sitting in main; read the other way it is correct. Nothing in the
+documents settled which.
+
+## 2. The decision
+
+**Privacy suppresses CROSS-PROJECT surfaces only.** Owner, 2026-08-30.
+
+A builder marked `private` is absent from `/u/<handle>`, platform search, the sitemap,
+Explore-adjacent surfaces and the recruiting reach — every surface that is *about the
+platform*. They still appear on the roster and leaderboard of a project they actually
+build on, because **a project's record of its own work is the project's business**. The
+flag governs how far a builder's identity travels, not whether the work they did for
+you is yours to show.
+
+Two things follow, and they are the point of writing this down:
+
+- **`credits.leaderboard()` is correct as written and needs no change.** Adding a
+  visibility predicate there would be a regression, not a fix — which is exactly what
+  a future session reading PV2 literally would have done.
+- **PV2's "every public read … leaderboards" means the cross-project leaderboards.**
+  The shared predicate still owns every surface it names; the in-project ledger was
+  never one of them.
+
+## 3. What changed
+
+The spec was amended rather than left to be re-litigated — the ambiguity was in its
+wording, so the wording is the fix (task 1003443):
+
+- the D1 `account_visibility` row now says *cross-project* leaderboards, and says
+  outright that the flag does not reach a project's own roster;
+- the two `active · private` matrix rows no longer say **"absent everywhere"** — the
+  single most misreadable phrase in the file — but "absent from every cross-project
+  surface";
+- the `active · public` rows qualify their "leaderboards" the same way, so the matrix
+  cannot be read against the table;
+- PV2's own ship-table row is qualified too;
+- and the boundary is stated as the **third rule** under D2, beside "`hide_stats`
+  beats everything", because that block is where a reader looks for the rules the
+  matrix encodes.
+
+## 4. Rejected
+
+**Making `private` hide a builder from the projects they build on.** It reads as the
+more privacy-protective option and is the reason the ambiguity was worth an owner
+decision rather than a coin flip. Rejected because it breaks the ledger: a project
+whose roster silently omits contributors cannot show who built it, credits and karma
+would be awarded to someone invisible on the surface that explains them, and the
+in-hall leaderboard would disagree with the task history any builder can already read.
+Privacy about *the platform* does not imply anonymity *inside a project you joined*.
+
+**Leaving it as a dated note in the spec.** The task offered this and it is the wrong
+shape: the decision resolves a stated ambiguity in an accepted spec and pins a piece
+of shipped code as deliberately predicate-free. That is an ADR's job — a note in a
+spec is not what a future session greps when it wonders why one leaderboard query has
+no visibility join.
+
+## 5. What this does not decide
+
+Whether an in-project roster may be made public to the world (a per-project
+visibility question the platform owns — goal 1000058's `platformVisibility`), and
+whether a builder can leave a project's roster entirely. Both are about the
+*project's* surface, not the account flag this ADR scopes.

package/docs/adr/README.md

@@ -311,5 +311,6 @@ This keeps the decision history honest and traceable.
 | 0222 | [**The image family under the hero-only rule: plates and hero objects, never screens; the mark is drawn; the board is a contact sheet; the pair and the sidecar are the output contract** ([task 1003328](https://cloudbongos.com/builders#/task/1003328) · goal 1000083). The four image skills of `Leonxlnx/taste-skill` (scanned `dangerous`, ADR 0198) are built around pictures of interfaces: one reference image per section, one app screen per flow step in a phone mockup, an identity board with the brand name rendered in, and a build loop whose truth is the generated image; the panel flagged the eagerness mandate, the image-count rule and the must-invoke-any-tool directive by name, and the owner's rule (2026-08-26/27) forbids the category. Decisions: **D1** the subject is the composition's plate slots and the count is the slot count; variety survives as anchors (field, beside-bleeding, masthead, orb, backdrop; text-left image-right refused), the palette lock is the pack, cross-frame consistency is one family (material, light, lens, ground). **D2** a screen is the surface itself: the mobile skill makes portrait plates for 390 / 320, the flow is the states file rendered by the kit, the bible is `DESIGN.md`, no phone mockup, native declines to `/design`. **D3** the source of truth for UI is the owner's references and the world; `image-to-code` reads them (analysis, extraction spec, faithful translation, drift as the failure mode, the clarity checklist) and the only image it may cause is the hero plate. **D4** the mark is drawn as inline SVG, the colour system is the pack, the type specimen is the faces on a real page, the applications are the kit's renders, the image direction is a hero-object family, the nine-panel board is a contact sheet of real parts. **D5** the output contract is DESIGN.md's pair and sidecar (JPEG dark plate, WebP alpha cutout, `<file>.<ext>.json` beside each, `--plate-*` tokens on `body`) through the instance's art pipeline key, the spend logged, a white ground through the remover, alpha verified with ffmpeg, never a crop. **D6** the worked example is the grove specimen's hero object, not the front door. **D7** the pins: the four declared, each naming the sidecar, "text-free" and the art key; no eagerness / count / per-section / must-invoke directive. Rejected: per-section images for reference only; phone mockups around real shots; a generated logo as a start; the plate on the front door; a shared base skill with wrappers.](<redacted>.md) | ui-design / skills / imagery |
 | 0223 | [**The anti-pattern detector is two tiers inside the kit: mechanical floors fail, craft tells warn, a false positive is waived in the file with its reason, and nothing new is installed** ([task 1003329](https://cloudbongos.com/builders#/task/1003329) · goal 1000083). The [detector] group of impeccable's rebuild spec (about sixty rules, a CLI plus a browser bundle wired to hooks, per-project ignores, in-file waivers, "a clean scan is a floor and never proof") lands as RULES in the kit that already exists, per the task body: no second tool, no bundle, no hook. Decisions: **D1** `kit/tells.js` carries the static rules and `check-mock.js` runs them after the platform rules and taste bans; `lib.js`'s `factsInPage` collects the computed-value twins as `tells` and `render.js` prints them as `~ tell:` lines per render, recorded in `report.json`, never counted as problems. Two tiers: floors FAIL (a bounce easing; a card nested in a card) and tells WARN (the icon-heading-text grid, hero metrics, section numbering, a kicker above the h1, a side stripe, a hard offset shadow, a coloured halo, decorative blur, a default typeface, a wide measure, a long headline, the same entrance everywhere, a geometric mask on a plate, glyphs as icons, a rainbow gradient, the browser surfaces nobody themed, proportional numerals, tiny type; rendered: measure, tiny text, numerals in cells, headline lines, an overshooting curve). **D2** the world decides which tells are floors: a kicker above the h1 is a FAIL where the instance's `DESIGN.md` bans the eyebrow (a new `eyebrow` taste key), a WARN elsewhere. **D3** a false positive is waived in the file with its reason (`kit-ignore: <rule prefix> (reason)` → a WAIVE row), `--raw` runs with none, `--no-tells` runs the platform rules only, `--json` prints rows with `fails` / `warns` counts; no per-project ignore config. **D4** not ported: the purple-to-blue tell (a literal colour already fails; hue is unresolvable under the fifteen), an injected overlay, the screenshot sampler (`contrast.js --url` is that pass), a cascade resolver (the browser is the resolver), native code, every hook. **D5** the pins: a clean fixture passes every rule, every rule class trips at its tier with the case count equal to the rule count, the promotion, the waiver / raw / json paths through the real CLI, `craftTells` as warnings; the hub mock and the three specimens still pass, `/projects` and the grove specimen still render ALL CLEAN. Rejected: a second CLI; every tell as a floor (the kit as the taste and the instance as the exception); a project-wide ignore config; an edit-time hook.](0223-the-detector-is-two-tiers-in-the-kit.md) | ui-design / kit |
 | 0224 | [**Module-owned skills reach the core checkout as untracked, self-ignored copies with a manifest: the self-copy guard stays, the dev path is a flag, and the file map skips what the module documents** ([task 1003330](https://cloudbongos.com/builders#/task/1003330) · goal 1000083). `materializeClaude`'s self-copy guard is right (a core copying itself is a no-op at best), but Claude Code discovers only `.claude/skills/` at the project root, so a builder IN the core checkout could not invoke any of the nine ui-design skills written there. Decisions: **D1** `node scripts/gds/claude-materialize.js --module-skills-only [--dry-run] [--clean]` calls `materializeModuleSkillsIntoCore`: the same roster, gate and slug rule as step 1b, verbatim copies (no bongosify: the checkout runs `node scripts/gds/…`), a core-owned name kept, a disabled module's excluded; the guard untouched. **D2** untracked and self-ignored: a generated `.claude/skills/.module-skills.json` manifest and a `.gitignore` that ignores itself, the manifest and every materialised dir; each run removes what the last manifest named then lands the current set (byte-identical on repeat; a dropped declaration disappears); `--clean` stops after the removal. **D3** `gen-file-map.js` and `tests/file_map.mjs` skip materialised names by the manifest (a module skill is documented by its module's README, not by the notes sidecar). **D4** init from a checkout that carries the copies still lands them through step 1b, transformed, and never the dotfiles. **D5** pinned end to end in `tests/claude_materialize.mjs`. Rejected: dropping the guard; committing the copies; symlinks or junctions; notes for dirs not in the repository.](<redacted>.md) | materialiser / skills |
+| 0225 | [**Privacy suppresses cross-project surfaces only: a private builder still appears on their own project's roster** ([task 1003443](https://cloudbongos.com/builders#/task/1003443) · goal 1000075). The accepted privacy spec defined its two flags inconsistently for one case: `hide_stats` suppresses "everything derived from the CROSS-PROJECT rollup" (qualified, so an in-project leaderboard is out of scope) while `account_visibility: private` said "absent from search, LEADERBOARDS, sitemap" (unqualified, so it read as covering the in-project one too) — and PV2 demands "ONE shared predicate used by every public read: … leaderboards …" while `modules/economy/credits.js`'s `leaderboard()` is a bare `SELECT … FROM builders` with no join and no predicate. Read one way that is an unshipped PV2 violation in main; read the other it is correct, and nothing settled which. **Owner decision (2026-08-30): privacy suppresses CROSS-PROJECT surfaces only.** A `private` builder is absent from `/u/<handle>`, platform search, the sitemap, Explore and the recruiting reach, and still appears on the roster of a project they build on — a project's record of its own work is the project's business. Two consequences are the point of recording it: `credits.leaderboard()` is **correct as written** (adding a predicate there would be a regression, not a fix — exactly what a literal PV2 reading would have done), and PV2's "leaderboards" means the cross-project ones. The spec was amended rather than annotated: the D1 row and both `active · public` matrix rows now say *cross-project*, the two `active · private` rows drop "absent everywhere" (the file's most misreadable phrase) for "absent from every cross-project surface", PV2's ship-table row is qualified, and the boundary lands as the **third rule** under D2 beside "`hide_stats` beats everything". Rejected: making `private` hide a builder from projects they build on (it reads as more protective and breaks the ledger — a roster that omits contributors cannot show who built the thing, and credits would accrue to someone invisible on the surface explaining them); and leaving it as a dated spec note (it pins shipped code as deliberately predicate-free, which is an ADR's job).](<redacted>.md) | privacy / spec |
 
 > ⚠️ **Numbering collisions are now machine-enforced, not narrated.** Twenty numbers are shared by two ADRs each — assigned in parallel sessions before anything checked. The files keep their filenames (renumbering would break every existing citation, and a number once assigned is never reused), and this table disambiguates each pair as `NNNN-a` / `NNNN-b`. The authoritative list is `LEGACY_DUPLICATE_ADRS` in [`scripts/gds/adr-namespace.js`](../../scripts/gds/adr-namespace.js), frozen by exact filename: a **new** collision — or a third file joining a legacy number, or a rename of either half — hard-fails the `unit` CI gate, as does an index row that points at no file or an ADR with no row. The list may only shrink. This paragraph used to narrate the collisions one by one and had fallen eight behind reality; see [ADR 0195](<redacted>.md) for why the check exists and why the pairs are grandfathered rather than renumbered.

package/docs/module-api-changelog.md

@@ -1369,5 +1369,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.464 with no explicit bump. run 33581328823. (task 1002620)
   1.19.466 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.465 with no explicit bump. run 33583122775. (task 1002620)
+  1.19.467 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.466 with no explicit bump. run 33638703282. (task 1002620)
+  1.19.468 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.467 with no explicit bump. run 33640370009. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/economy/credits.js

@@ -119,6 +119,11 @@ const IDEA_FULL_PASS_CREDIT = 5;   // owner: "gives 5 credits"
 const IDEA_FULL_PASS_BAR = 60;     // completeness 0-100; ADR 0172 proposed default
 const IDEA_TASK_SHIP_BASE = 5;     // stream 1: base credit per shipped task under an idea
 const QUICK_IDEA_FACTOR = 0.6;     // a quick/spark idea's grade factor (ADR 0172 default)
+// Stream 3 (IC5): a board-ratified Full Idea pays a share of a 100-credit
+// ceiling, in proportion to how complete the idea was. Owner: "30-100 credits
+// ... paid as a percent on the 100 credits for its fullness."
+const IDEA_GOVERNANCE_PASS_MAX = 100;   // owner: "up to 100 credits"
+const IDEA_GOVERNANCE_PASS_FLOOR = 30;  // owner: floor ~30 — see the note on the award fn
 
 // =========================================================================
 // Session token reward (flat cost-plus) — task 1005 (ADR 0054).
@@ -577,6 +582,114 @@ async function awardIdeaTaskShipCredit(client, { taskId, config = rewardConfig()
     : { credited: 0, reason: 'already_paid', ideaId: Number(ideaId), authorId: Number(authorId) };
 }
 
+// Stream 3 (ADR 0172 / goal 1000067 IC5): a Full Idea that PASSES the Board
+// Room's ratification vote pays a share of a 100-credit ceiling, scaled by the
+// idea's R142 completeness — "70%-complete + passes = 70". The ideator lane, so
+// it gates on config.ideatorCredit, never perTaskCredit.
+//
+// THE BOARD CALLS THIS THROUGH THE `reward` PORT, INSIDE ITS CLOSE TRANSACTION
+// (docs/specs/board-room-pass-event-contract.md, Decision 1) — not off the
+// `board.item.passed` seam event, because emitAsync swallows listener errors,
+// which is right for a Discord post and disqualifying for a payment. If this
+// write fails the close rolls back and the item stays open, so the vote is
+// retried rather than the author silently unpaid.
+//
+// RE-DRIVABLE BY DESIGN (contract Decision 5): the durable fact is the
+// `board_items` row with outcome='passed', not a delivered event. Nothing here
+// reads board state or requires a live listener, and the reason key makes a
+// blanket re-run safe, so a missed award can be reconciled by sweeping the
+// passed items and calling this again. No such sweep is scheduled in v1 — the
+// requirement is only that the shape permits one.
+//
+//   client             — pg client / pool (transaction participant)
+//   ideaId, authorId   — the ratified idea and its captured_by builder
+//   completenessScore  — the R142 score (0-100)
+//   subjectType        — the board subject, when the caller knows it; only
+//                        'full_idea' pays (contract Decision 2). Omitted means
+//                        "already filtered", which is how the board calls it.
+//   config             — resolved reward policy; gates on config.ideatorCredit
+//
+// Returns { credited, reason }:
+//   { credited: N, reason: 'paid' }                 — first pass for this idea
+//   { credited: 0, reason: 'already_paid' }         — a prior row for this idea
+//   { credited: 0, reason: 'not_a_full_idea' }      — an amendment pays nothing
+//   { credited: 0, reason: 'ideator_lane_off' }     — instance opted the lane out
+//   { credited: 0, reason: 'missing_author_or_idea' }
+//   { credited: 0, reason: 'no_completeness_score' }
+//
+// NO `below_bar` RETURN, deliberately (contract Decision 4): ADR 0175 §5 makes
+// the completeness bar the gate on OPENING a vote window at all, so an idea
+// below the bar can never reach a pass. Re-checking it here would imply the
+// board might send something it cannot.
+async function awardIdeaGovernancePassCredit(client, {
+  ideaId, authorId, completenessScore, subjectType, config = rewardConfig(),
+} = {}) {
+  // SUBJECT TYPE FIRST, ahead of the lane check that opens both sibling streams:
+  // a constitutional amendment traverses the same close path and is not an
+  // ideator payment at all, so whether the ideator lane is on is irrelevant to
+  // it. A re-drive sweep reading these reasons gets the truthful one.
+  if (subjectType != null && subjectType !== 'full_idea') {
+    return { credited: 0, reason: 'not_a_full_idea' };
+  }
+  if (config && config.ideatorCredit === false) {
+    return { credited: 0, reason: 'ideator_lane_off' };
+  }
+  if (ideaId == null) {
+    return { credited: 0, reason: 'missing_author_or_idea' };
+  }
+  if (completenessScore == null || !Number.isFinite(Number(completenessScore))) {
+    return { credited: 0, reason: 'no_completeness_score' };
+  }
+  // The parties come from the DB, not the call site (the R147 rule): there is
+  // exactly one place that decides who earns from an idea. `authorId` is a
+  // fallback for a caller holding an idea this lookup cannot see.
+  const parties = await ideaCreditParties(client, ideaId);
+  const resolvedAuthor = (parties && parties.authorId != null) ? parties.authorId : authorId;
+  if (resolvedAuthor == null) {
+    return { credited: 0, reason: 'missing_author_or_idea' };
+  }
+  // CLAMPED to [0,1] before scaling, so a malformed score can never pay out
+  // more than the ceiling (the stream-1 precedent). The floor then applies:
+  // it is UNREACHABLE under default config — ADR 0175 §5 gates window-opening
+  // on IDEA_FULL_PASS_BAR (60), so a real payout lands in [60,100] and max()
+  // never binds — but it ships because it is the owner's stated intent and goes
+  // live the moment either constant moves.
+  const pct = Math.max(0, Math.min(1, Number(completenessScore) / 100));
+  const delta = Math.max(
+    IDEA_GOVERNANCE_PASS_FLOOR,
+    Math.round(pct * IDEA_GOVERNANCE_PASS_MAX)
+  );
+  // Split with whoever DEVELOPED the spark, the same 70/30 as streams 1 and 2
+  // (ADR 0185) — the contract predates that split and names the author alone;
+  // mirroring the sibling streams, as it asks, means splitting here too.
+  const payees = splitIdeaCredit(delta, {
+    authorId: resolvedAuthor,
+    developedBy: parties ? parties.developedBy : null,
+  });
+  if (payees.length === 0) {
+    return { credited: 0, reason: 'zero_after_scaling' };
+  }
+  // ONCE PER IDEA, FOREVER. A resubmission that passes again, a re-close, a
+  // replay, or a concurrent request all resolve to this same key and book
+  // nothing further. Builder-scoped so the NOT EXISTS hits
+  // idx_credit_log_builder (credit_log is a CORE table — a module migration may
+  // not add an index on `reason`), and because a split books one row per payee
+  // under ONE reason, a reason-only predicate would refuse the second payee.
+  // task_id is NULL: an idea credit has no task.
+  const reason = `idea.credit.governance_pass:${ideaId}`;
+  const scorePct = Math.round(Number(completenessScore));
+  const { credited, payees: booked } = await bookIdeaSplit(client, {
+    payees,
+    reason,
+    describe: (p) => `Full Idea #${ideaId} ratified by the board (completeness ${scorePct}/100) → ${p.delta}c to its ${p.role.replace(/_/g, ' ')} (ideator lane stream 3, ADR 0172${p.role === 'developer' || p.role === 'spark_author' ? '; split ADR 0185' : ''})`,
+  });
+  return {
+    credited,
+    reason: credited > 0 ? 'paid' : 'already_paid',
+    payees: booked,
+  };
+}
+
 // Award the flat cost-plus session token reward, idempotent per session_id
 // (task 1005, ADR 0054). Called inside the same transaction as the session
 // upsert (see upsertSessionRecordWithReward).
@@ -824,6 +937,7 @@ module.exports = {
   maybeAwardIdeaPromotionBonus,
   awardIdeaFullPassCredit,
   awardIdeaTaskShipCredit,
+  awardIdeaGovernancePassCredit,
   // the spark-handoff split (task 1002923 / BV1.R147, ADR 0185)
   splitIdeaCredit,
   IDEA_DEVELOPER_SHARE,
@@ -831,6 +945,8 @@ module.exports = {
   IDEA_FULL_PASS_BAR,
   IDEA_TASK_SHIP_BASE,
   QUICK_IDEA_FACTOR,
+  IDEA_GOVERNANCE_PASS_MAX,
+  IDEA_GOVERNANCE_PASS_FLOOR,
   awardSessionTokenReward,
   NET_NEGATIVE_BONUS,
   SUBTRACTOR_THRESHOLD,

package/modules/economy/reward.js

@@ -28,6 +28,11 @@ module.exports = {
   awardIdeaFullPassCredit: (...a) => credits.awardIdeaFullPassCredit(...a),
   // ADR 0172 IC4 — stream 1: pay the idea's author per shipped task, grade-scaled (replaces the 25% slice at ship).
   awardIdeaTaskShipCredit: (...a) => credits.awardIdeaTaskShipCredit(...a),
+  // ADR 0172 IC5 — stream 3: a board-ratified Full Idea pays up to 100, scaled by completeness.
+  // The board's close transaction resolves this port and calls this with its own
+  // `client` (docs/specs/board-room-pass-event-contract.md) — the port is how
+  // money crosses the wall; the `board.item.passed` event never carries a payment.
+  awardIdeaGovernancePassCredit: (...a) => credits.awardIdeaGovernancePassCredit(...a),
   awardNetNegativeBonus: (...a) => credits.awardNetNegativeBonus(...a),
   awardSessionTokenReward: (...a) => credits.awardSessionTokenReward(...a),
   // gamification hooks the lifecycle fires at claim/ship

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.466",
+  "version": "1.19.468",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.466",
+      "version": "1.19.468",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.466",
+  "version": "1.19.468",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -33,7 +33,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.466'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.468'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/idea_governance_pass_credit.mjs

@@ -0,0 +1,243 @@
+// tests/idea_governance_pass_credit.mjs
+//
+// task 1002999 (BV1.R175 / IC5, goal 1000067) — stream 3 of the ideator credit
+// lane: a Full Idea that PASSES the Board Room's ratification vote pays a share
+// of a 100-credit ceiling, scaled by its R142 completeness. ADR 0172 §3, and
+// docs/specs/board-room-pass-event-contract.md (the agreement with the board).
+//
+// The done-when as assertions: a ratified Full Idea books round(completeness%)
+// once; a constitutional amendment books nothing; re-running never double-pays;
+// cost-plus-only does NOT suppress it (it gates on ideatorCredit, never
+// perTaskCredit); an instance that opts the ideator lane out pays nothing.
+//
+// The credit fn is exercised over a stub client that records statements and
+// simulates the WHERE-NOT-EXISTS idempotency, so the idempotency logic is proven
+// without a DB — the tests/idea_full_pass_credit.mjs harness, unchanged.
+//
+// Run:  node tests/idea_governance_pass_credit.mjs
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const credits = require('../modules/economy/credits.js');
+
+let passed = 0;
+let failed = 0;
+async function test(name, fn) {
+  try { await fn(); passed++; console.log(`  ok  ${name}`); }
+  catch (err) { failed++; console.error(`  FAIL ${name}\n    ${err.message}`); }
+}
+
+// A stub client whose credit_log "table" is an in-memory set of (builder, reason)
+// pairs, so INSERT ... WHERE NOT EXISTS behaves exactly like Postgres: a second
+// insert for the same pair is a no-op (rowCount 0). `developedBy` defaults to
+// null — an idea nobody else developed — and is set explicitly by the split test.
+function stubClient({ authorId = null, developedBy = null } = {}) {
+  const rows = [];
+  return {
+    rows,
+    async query(sql, params) {
+      // The parties lookup — who authored this idea, and who developed it.
+      if (/FROM idea_inbox i/i.test(sql) && /developed_by/i.test(sql)) {
+        return { rows: authorId == null ? [] : [{ captured_by: authorId, developed_by: developedBy }] };
+      }
+      // The idempotency predicate must scope by builder_id AND reason: a split
+      // books two rows under ONE reason, so a reason-only predicate would
+      // silently refuse the second payee (and credit_log is a CORE table, so a
+      // module migration cannot add an index on `reason` anyway).
+      const builderId = params[0];
+      const reason = params[3];
+      assert.match(sql, /builder_id = \$1 AND reason = \$4/, 'idempotency check must scope by builder_id AND reason');
+      const exists = rows.some((r) => r.builder_id === builderId && r.reason === reason);
+      if (exists) return { rowCount: 0, rows: [] };
+      rows.push({ builder_id: builderId, task_id: params[1], delta: params[2], reason, description: params[4] });
+      return { rowCount: 1, rows: [] };
+    },
+  };
+}
+
+const ON = { ideatorCredit: true };
+
+await test('a ratified Full Idea pays its completeness percent of the 100 ceiling', async () => {
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 9, authorId: 3, completenessScore: 70, config: ON });
+  assert.equal(r.credited, 70, 'the owner\'s worked example: 70%-complete + passes = 70');
+  assert.equal(r.reason, 'paid');
+  assert.equal(c.rows.length, 1);
+  assert.equal(c.rows[0].delta, 70);
+  assert.equal(c.rows[0].builder_id, 3);
+  assert.equal(c.rows[0].reason, 'idea.credit.governance_pass:9');
+  assert.equal(c.rows[0].task_id, null, 'an idea credit has no task');
+});
+
+await test('a fully-complete idea pays the whole 100-credit ceiling, never more', async () => {
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 1, authorId: 3, completenessScore: 100, config: ON });
+  assert.equal(r.credited, credits.IDEA_GOVERNANCE_PASS_MAX);
+  assert.equal(r.credited, 100);
+});
+
+await test('a malformed over-100 score is clamped to the ceiling, not paid out', async () => {
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 2, authorId: 3, completenessScore: 420, config: ON });
+  assert.equal(r.credited, 100, 'the ceiling holds even when the input is nonsense');
+});
+
+await test('re-running pays nothing — once per idea, forever', async () => {
+  const c = stubClient({ authorId: 3 });
+  const opts = { ideaId: 9, authorId: 3, completenessScore: 80, config: ON };
+  const first = await credits.awardIdeaGovernancePassCredit(c, opts);
+  const second = await credits.awardIdeaGovernancePassCredit(c, opts);
+  const third = await credits.awardIdeaGovernancePassCredit(c, opts);
+  assert.equal(first.credited, 80);
+  assert.equal(second.credited, 0);
+  assert.equal(second.reason, 'already_paid');
+  assert.equal(third.credited, 0);
+  assert.equal(c.rows.length, 1, 'exactly one credit_log row ever, across three calls');
+});
+
+await test('a constitutional amendment books nothing — subject_type is load-bearing', async () => {
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, {
+    ideaId: null, authorId: 3, completenessScore: null,
+    subjectType: 'constitutional_amendment', config: ON,
+  });
+  assert.equal(r.credited, 0);
+  assert.equal(r.reason, 'not_a_full_idea');
+  assert.equal(c.rows.length, 0, 'an amendment traverses the same close path and must pay nobody');
+});
+
+await test('subject_type is checked BEFORE the lane flag, so a sweep gets the truthful reason', async () => {
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, {
+    ideaId: 5, authorId: 3, completenessScore: 90,
+    subjectType: 'constitutional_amendment', config: { ideatorCredit: false },
+  });
+  assert.equal(r.reason, 'not_a_full_idea', 'an amendment is not an ideator payment at all');
+});
+
+await test('an explicit full_idea subject pays exactly as an omitted one does', async () => {
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, {
+    ideaId: 7, authorId: 3, completenessScore: 65, subjectType: 'full_idea', config: ON,
+  });
+  assert.equal(r.credited, 65, 'the board omits subjectType because it has already filtered; a sweep passes it');
+});
+
+await test('COST-PLUS-ONLY does NOT suppress it: the ideator lane pays regardless of perTaskCredit', async () => {
+  // the live cloudbongos.com policy: builder estimate off, ideator lane on
+  const policy = credits.rewardPolicy({ mode: 'cost-plus-only' });
+  assert.equal(policy.perTaskCredit, false);
+  assert.equal(policy.ideatorCredit, true);
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 5, authorId: 3, completenessScore: 75, config: policy });
+  assert.equal(r.credited, 75, 'paid despite cost-plus-only — this is the whole point of ADR 0172');
+});
+
+await test('an instance that opts the ideator lane out pays nothing', async () => {
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 6, authorId: 3, completenessScore: 90, config: { ideatorCredit: false } });
+  assert.equal(r.credited, 0);
+  assert.equal(r.reason, 'ideator_lane_off');
+  assert.equal(c.rows.length, 0);
+});
+
+await test('an unscorable idea books 0 — and it is NOT reported as below a bar', async () => {
+  // There is deliberately no `below_bar` return: ADR 0175 §5 makes the
+  // completeness bar the gate on OPENING a window, so a sub-bar idea can never
+  // reach a pass. A null score means the score is MISSING, not low.
+  const c = stubClient({ authorId: 3 });
+  assert.equal((await credits.awardIdeaGovernancePassCredit(c, { ideaId: 1, authorId: 3, completenessScore: null, config: ON })).reason, 'no_completeness_score');
+  assert.equal((await credits.awardIdeaGovernancePassCredit(c, { ideaId: 2, authorId: 3, completenessScore: undefined, config: ON })).reason, 'no_completeness_score');
+  assert.equal((await credits.awardIdeaGovernancePassCredit(c, { ideaId: 3, authorId: 3, completenessScore: 'x', config: ON })).reason, 'no_completeness_score');
+  assert.equal(c.rows.length, 0, 'nothing written when there is no score to scale by');
+});
+
+await test('a missing author or idea is a safe 0, never a throw', async () => {
+  const noIdea = stubClient({ authorId: 3 });
+  assert.equal((await credits.awardIdeaGovernancePassCredit(noIdea, { ideaId: null, authorId: 3, completenessScore: 90, config: ON })).reason, 'missing_author_or_idea');
+  // An idea the lookup cannot see AND no caller-supplied author → still a safe 0.
+  const unknown = stubClient();   // lookup returns no row
+  assert.equal((await credits.awardIdeaGovernancePassCredit(unknown, { ideaId: 6, authorId: null, completenessScore: 90, config: ON })).reason, 'missing_author_or_idea');
+  assert.equal(unknown.rows.length, 0);
+});
+
+await test('the DB is authoritative for the author; the argument is only a fallback', async () => {
+  const known = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(known, { ideaId: 6, authorId: null, completenessScore: 90, config: ON });
+  assert.equal(r.credited, 90);
+  assert.equal(known.rows[0].builder_id, 3, 'paid the author the DB names');
+
+  // ...and when the lookup finds nothing, the passed author is still honoured,
+  // so a caller holding an idea this module cannot see is not silently unpaid.
+  const invisible = stubClient();
+  const f = await credits.awardIdeaGovernancePassCredit(invisible, { ideaId: 6, authorId: 7, completenessScore: 90, config: ON });
+  assert.equal(f.credited, 90);
+  assert.equal(invisible.rows[0].builder_id, 7);
+});
+
+await test('a developed spark splits 70/30 with its developer, conserving the total', async () => {
+  // ADR 0185, the same rule streams 1 and 2 apply. The contract for this stream
+  // predates the split and names the author alone; mirroring the sibling
+  // streams, as it asks, means splitting here too.
+  const c = stubClient({ authorId: 3, developedBy: 8 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 4, authorId: 3, completenessScore: 70, config: ON });
+  assert.equal(r.credited, 70, 'the total is conserved across the two payees');
+  assert.equal(c.rows.length, 2);
+  const dev = c.rows.find((x) => x.builder_id === 8);
+  const author = c.rows.find((x) => x.builder_id === 3);
+  assert.equal(dev.delta, 49, '70% of 70, rounded');
+  assert.equal(author.delta, 21, 'the remainder — never independently rounded');
+  assert.equal(dev.reason, author.reason, 'one reason key, two rows — hence the builder-scoped predicate');
+});
+
+await test('a self-developed spark collapses to one payee, so nobody is under-paid', async () => {
+  const c = stubClient({ authorId: 3, developedBy: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 11, authorId: 3, completenessScore: 70, config: ON });
+  assert.equal(r.credited, 70);
+  assert.equal(c.rows.length, 1, 'two rows for one builder would hit the idempotency predicate and UNDER-pay');
+});
+
+await test('the floor pays 30 on a sub-30 score — a branch unreachable under default config', async () => {
+  // NOT A REAL SCENARIO, and deliberately not faked into one: ADR 0175 §5 gates
+  // window-opening on IDEA_FULL_PASS_BAR, so a real payout lands in [60,100]
+  // and max() never binds. The branch is exercised by handing the function an
+  // input the board cannot currently send — never by lowering the bar in a
+  // fixture, which would look like a scenario it is not. It ships because it is
+  // the owner's stated intent and goes live the moment either constant moves.
+  const c = stubClient({ authorId: 3 });
+  const r = await credits.awardIdeaGovernancePassCredit(c, { ideaId: 12, authorId: 3, completenessScore: 10, config: ON });
+  assert.equal(r.credited, credits.IDEA_GOVERNANCE_PASS_FLOOR);
+  assert.equal(r.credited, 30);
+});
+
+await test('the floor really is unreachable at the shipped constants — the finding, as an assertion', async () => {
+  const lowestPassablePayout = Math.round(credits.IDEA_FULL_PASS_BAR / 100 * credits.IDEA_GOVERNANCE_PASS_MAX);
+  assert.ok(
+    lowestPassablePayout > credits.IDEA_GOVERNANCE_PASS_FLOOR,
+    `bar ${credits.IDEA_FULL_PASS_BAR} pays ${lowestPassablePayout}, above the ${credits.IDEA_GOVERNANCE_PASS_FLOOR} floor — if this ever fails, the floor has become live and the branch above is a real scenario`
+  );
+});
+
+await test('all three ideator streams use distinct reason keys, so one idea can earn on each', async () => {
+  const c = stubClient({ authorId: 3 });
+  await credits.awardIdeaFullPassCredit(c, { ideaId: 20, authorId: 3, completenessScore: 90, config: ON });
+  await credits.awardIdeaGovernancePassCredit(c, { ideaId: 20, authorId: 3, completenessScore: 90, config: ON });
+  assert.equal(c.rows.length, 2, 'stream 2 and stream 3 both paid the same idea');
+  assert.equal(c.rows[0].reason, 'idea.credit.full_pass:20');
+  assert.equal(c.rows[1].reason, 'idea.credit.governance_pass:20');
+  assert.equal(c.rows[0].delta + c.rows[1].delta, 95, '5 for the grade, 90 for the ratification');
+});
+
+await test('the award rides the reward PORT, so the board can resolve it', async () => {
+  const reward = require('../modules/economy/reward.js');
+  assert.equal(typeof reward.awardIdeaGovernancePassCredit, 'function',
+    'board.js duck-types on exactly this name; without it the close is a silent no-op');
+  const c = stubClient({ authorId: 3 });
+  const r = await reward.awardIdeaGovernancePassCredit(c, { ideaId: 30, authorId: 3, completenessScore: 60, config: ON });
+  assert.equal(r.credited, 60, 'delegated, not spread — the port reaches the live function');
+});
+
+console.log(`\nidea_governance_pass_credit: ${passed} passed, ${failed} failed`);
+if (failed > 0) process.exit(1);