@bongos/core 1.19.461 → 1.19.463

package/modules/ui-design/skills/impeccable/reference/shape.md

@@ -0,0 +1,23 @@
+# `impeccable shape` — the bounded discovery interview
+
+**When:** before any new visual work, or when the brief block in the ship notes has holes (no audience, no primary action, no mode). Planning only: **no code, no contract, no persistence** beyond the brief block itself.
+
+**Runs in:** any of the four cases. In case 4 (no visual authority) it is also where the session says out loud that the neutral pack is the world.
+
+## The interview
+
+One round by default, **two or three questions per round**, each about outcomes and product behaviour rather than implementation (the owner may not be an engineer). Prefer the harness's structured question widget where one exists; otherwise three numbered questions in one message. A second round only when the first left a fork open, and never a third.
+
+Pick the questions from what the homes do not already answer. Read `docs/project-context.template.md` and the task body first; ask nothing they settle.
+
+- **Who is this for and what do they come to do?** The visitor mode falls out of the answer: persuade, operate, read, or experience. Pick it from the surface, not the product.
+- **What is the one action, and what proof makes them take it?** A ledger's proof is the data itself; a landing's is a plate and a sentence; a settings page's is that nothing is hidden.
+- **What must not change?** The named rules of the world bind by default; the question is which existing content, behaviour or identity is out of scope for this pass.
+- **Refine or redesign?** Say what each means in one line (refinement keeps the look; redesign keeps the truth and replaces the look) and make them pick. No blend.
+- **Mockup first or straight to code?** Asked once, as its own question, and recorded in the brief; a surface with a settled world usually goes straight to code and proves itself in the kit.
+
+Where the product-truth file is still the scaffold, the round covers its sections too (platform, users, purpose, positioning, constraints, brand commitments, accessibility), **at least one real answer** before anything is treated as known; an inferred fact is labelled *inferred* in the brief and disclosed up front. Invented social proof, pricing and figures are banned; an undecided fact is recorded as *undecided*, never padded.
+
+## The return
+
+A confirmed written brief in the brief block's shape, read back to the person in full and confirmed with one word before it is written into the ship notes. Proposed edits to `docs/project-context.template.md` are listed as a diff for the owner, not applied by this playbook. Then hand off: a new marketing surface goes to `design-taste-frontend`, a working surface to the `/design` loop, and a change to an existing one to the playbook the brief names.

package/modules/ui-design/skills/impeccable/reference/typeset.md

@@ -0,0 +1,24 @@
+# `impeccable typeset` — type on a role scale, on the pack's faces
+
+**When:** type feels off: sizes that do not relate, a headline that wraps to three lines, prose that runs wide, numbers that jitter. Edits: yes, on the type tokens and the rules that read them.
+
+**Runs in:** every case. The faces are the pack's two stacks in every case; a brief that names another typeface gets the nearest face the pack carries and a line in the notes.
+
+## The role scale
+
+Name the roles the surface uses before setting a size: **display, headline, title, body, label, caption, data**. Each maps to one token on `body` (size, line-height, weight, tracking, and the face it takes from the two stacks). A size that belongs to no role is deleted. The world's hierarchy caps the count; the chrome world's display voice is light, tight-tracked and lowercase, its headline holds two lines, its labels are a mono face and are the only place it shouts.
+
+- **Measure**: prose 65 to 75 characters (`max-width` in `ch`), and the measure is spent on the reading text, not on a container.
+- **The display ceiling**: a `clamp()` whose upper bound is the world's, and a tracking floor at display sizes so a big face does not fall apart.
+- **Balance**: `text-wrap: balance` on headings, `pretty` on prose, and no orphaned last word on a headline at 1440 or 390.
+- **Data**: `font-variant-numeric: tabular-nums` on anything a ledger produced, so a live refresh does not reflow the row.
+- **Loading**: `font-display: swap` with a fallback sized to the web face (`size-adjust`, `ascent-override`) so nothing shifts when it arrives.
+- **Case**: sentence case for headlines and prose, the world's lowercase for its display voice and controls, uppercase only in a label face the world names.
+
+## Verify from computed values
+
+The kit's shots at 1440 / 390 / 320 with real copy from the fixtures: no overflow, the headline within the world's line count, the measure within range, the bar on one row. Measure the rendered line length, do not estimate it.
+
+## The return
+
+The role tokens declared once; every text rule reading a role; the shots clean at all three widths in both modes; the ship notes list any role the world's `DESIGN.md` does not name, as a gap for the owner rather than a size this page invented.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.461",
+  "version": "1.19.463",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.461",
+      "version": "1.19.463",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.461",
+  "version": "1.19.463",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -33,7 +33,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.461'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.463'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/hall_roster_world.mjs

@@ -0,0 +1,287 @@
+// tests/hall_roster_world.mjs — the roster and ledger pages in the chrome world
+// (task 1003470, goal 1000081): goals, sessions, people and scouting,
+// REDESIGNED rather than re-skinned. Static pins over the shipped source plus
+// two runs of the pure goals lib: the goals list is one panel with three lenses
+// in the open and the rest behind the kit's disclosure, the readiness is the
+// family's figure band in the same dot language as the roll line, the view
+// toggle is a view and not a filter, the accent lands on the one live door; the
+// two directory pages are ONE page (the legacy door renders the same body from
+// the same script) and the directory shows the avatar, the name and the login
+// the API returns; the session ledger drops the nowrap + wrapper pair that broke
+// its sticky header, makes every id a door, and names its floor from the pack.
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const PUB = path.join(ROOT, 'modules', 'hall-ui', 'public');
+const FIX = path.join(ROOT, 'scripts', 'hall-preview', 'fixtures');
+const read = (f) => fs.readFileSync(path.join(PUB, f), 'utf8').replace(/\r\n/g, '\n');
+const readJson = (f) => JSON.parse(fs.readFileSync(path.join(FIX, f), 'utf8'));
+// Negative pins read the code, not its comments (a comment that says what left
+// would otherwise fail the pin that says it left).
+const decomment = (src) => src.replace(/\/\*[\s\S]*?\*\//g, '').replace(/^\s*\/\/.*$/gm, '');
+const STYLE = read('style.css');
+const OVERSIGHT = read('oversight.css');
+// A token is defined in the shell, the family sheet, or the page sheet itself
+// (goals.css declares --ring, the ring column's width, on its own list).
+const tokensDefined = (css, where) => {
+  for (const t of new Set([...css.matchAll(/var\((--[a-z0-9-]+)\)/g)].map((m) => m[1]))) {
+    const declared = (src) => new RegExp(`(^\\s*|[{;]\\s*)${t}:`, 'm').test(src);
+    assert.ok(declared(STYLE) || declared(OVERSIGHT) || declared(css),
+      `${where} spends ${t}, which neither style.css, oversight.css nor the sheet itself defines`);
+  }
+};
+const noAlias = (rawCss, where) => {
+  const css = decomment(rawCss);
+  const alias = css.match(/--(surface|surface-2|border|border-strong|accent-weak|accent-text)\b/g) || [];
+  assert.deepEqual(alias, [], `${where} spends a compat alias: ${alias.join(', ')}`);
+  const hexes = css.match(/#[0-9a-f]{3,8}\b/gi) || [];
+  assert.deepEqual(hexes, [], `${where} carries literal colours: ${hexes.join(', ')}`);
+};
+const block = (css, sel) => {
+  const i = css.indexOf(`\n${sel} {`);
+  assert.ok(i >= 0, `${sel} has a rule`);
+  return css.slice(i, css.indexOf('}', i));
+};
+
+// goals-lib.js is pure: RUN it under the two globals it reads.
+function goalsLib() {
+  const sandbox = {
+    window: {
+      OTB: { escapeHtml: (s) => String(s).replace(/[&<>"']/g, (c) => ({ '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' }[c])) },
+      OTBTaskLib: { msOf: () => 0, taskActivityMs: () => 0 },
+    },
+  };
+  vm.createContext(sandbox);
+  vm.runInContext(read('goals-lib.js'), sandbox, { filename: 'goals-lib.js' });
+  return sandbox.window.OTBGoalsLib;
+}
+
+// =========================================================================
+// GOALS — the archetype page
+// =========================================================================
+
+test('goals: the list is ONE panel — the shell\'s .scroll around the filters, the count line and the groups', () => {
+  const html = read('goals.html');
+  const list = html.slice(html.indexOf('id="goals-list-view"'), html.indexOf('id="goal-detail-view"'));
+  assert.match(list, /<div class="scroll goals-panel">/, 'the panel is the shell\'s .scroll');
+  for (const id of ['goals-filters', 'goals-count', 'goals-view', 'goal-grid', 'goals-pager-mount']) {
+    assert.ok(list.includes(`id="${id}"`), `#${id} sits inside the list view`);
+  }
+  const panelStart = list.indexOf('class="scroll goals-panel"');
+  assert.ok(list.indexOf('id="goals-filters"') > panelStart, 'the filter bar is INSIDE the panel, not on the ground above it');
+  const fam = html.indexOf('/builders/oversight.css');
+  assert.ok(fam > 0 && html.indexOf('/builders/goals.css') > fam, 'goals.html links the family sheet before its own');
+  const css = read('goals.css');
+  assert.doesNotMatch(block(css, '.gr-list'), /background:\s*var\(--bg-card\)|border-radius/, '.gr-list is no longer a second panel per group');
+});
+
+test('goals: three lenses in the open, five behind the kit\'s disclosure, and no View select', () => {
+  const src = read('goals-page.js');
+  const spec = src.slice(src.indexOf("mount: $('#goals-filters')"), src.indexOf('onChange: onListFilterChange'));
+  const ids = (part) => [...part.matchAll(/id: '(f-goal-[a-z-]+)'/g)].map((m) => m[1]);
+  const primary = spec.slice(spec.indexOf('primary: ['), spec.indexOf('overflow: ['));
+  const overflow = spec.slice(spec.indexOf('overflow: ['));
+  assert.deepEqual(ids(primary), ['f-goal-version', 'f-goal-status', 'f-goal-order'], 'the open bar is version, state, order');
+  assert.deepEqual(ids(overflow), ['f-goal-mine', 'f-goal-owner', 'f-goal-category', 'f-goal-role', 'f-goal-stale'],
+    'the five rarely-turned lenses sit behind Filters — where the kit counts and chips them');
+  assert.ok(!spec.includes("id: 'f-goal-view'"), 'rows|cards is not a filter-bar control');
+});
+
+test('goals: rows|cards is a segmented view toggle that still writes #f-goal-view and the saved pref', () => {
+  const html = read('goals.html');
+  assert.match(html, /<div class="viewtoggle" role="group" aria-label="View" id="goals-view">/);
+  assert.match(html, /<input type="hidden" id="f-goal-view" value="list">/, 'the hidden input is what renderList forks on');
+  assert.match(html, /data-view="list" aria-pressed="true"/);
+  assert.match(html, /data-view="cards" aria-pressed="false"/);
+  const src = read('goals-page.js');
+  assert.match(src, /function setGoalView\(view, opts\)/);
+  assert.match(src, /b\.setAttribute\('aria-pressed', String\(b\.dataset\.view === view\)\)/, 'the buttons carry the pressed state');
+  assert.match(src, /if \(savedGoalView === 'cards'\) setGoalView\('cards', \{ fire: false \}\)/, 'the saved pref restores the toggle without a render');
+  const css = read('goals.css');
+  const pressed = block(css, '.viewtoggle__btn[aria-pressed="true"]');
+  assert.match(pressed, /var\(--accent-tint\)/, 'the pressed side takes the current-thing tint');
+  assert.doesNotMatch(pressed, /var\(--accent\)/, 'never the accent fill: a view is not a live door');
+});
+
+test('goals: the readiness is the family figure band, in the roll line\'s own dot language', () => {
+  const src = read('goals-render.js');
+  const body = src.slice(src.indexOf('function renderList'), src.indexOf('\n  function ', src.indexOf('function renderList') + 1));
+  assert.match(body, /<div class="ov-figs gr-figs">/, 'the band is .ov-figs');
+  for (const label of ['Ready to claim', 'In progress', 'Blocked', 'Criteria met']) {
+    assert.ok(body.includes(`fig('${label}'`), `the band carries "${label}"`);
+  }
+  assert.match(body, /gr-mark gr-mark--\$\{mark\}/, 'the label\'s dot is the shared .gr-mark');
+  assert.match(body, /<div class="ov-group__head"><span class="ov-group__name">/, 'the groups take the family head');
+  for (const gone of ['gr-summary', 'gr-sec', 'gr-sm']) assert.ok(!src.includes(gone), `${gone} is gone`);
+  const lib = goalsLib();
+  const roll = lib.goalRollLine({ ready: 1, active: 0, blocked: 2, backlog: 0 });
+  assert.match(roll, /gr-mark gr-mark--ready/);
+  assert.match(roll, /gr-mark gr-mark--blocked/);
+  assert.doesNotMatch(roll, /style=/, 'the dot colours are classes, not inline styles');
+  const css = read('goals.css');
+  assert.match(block(css, '.gr-mark--blocked'), /var\(--warn\)/, 'blocked is the warn colour, the pill\'s own');
+});
+
+test('goals: the row\'s right column is one action or one state, and the accent lands on the live door only', () => {
+  const src = read('goals-render.js');
+  const facts = src.slice(src.indexOf('function goalRenderFacts'), src.indexOf('function goalRowHtml'));
+  assert.match(facts, /class="btn-accent gr-claim" href="#\/task\//, '"claim next" is the shell\'s accent door');
+  assert.match(facts, /class="btn-ghost gr-drill"/, 'the blocked door is a ghost pill');
+  assert.match(facts, /gr-state gr-state--ok">\$\{checkSvg\('gr-state__mark'\)\}achieved/, 'achieved is a drawn check, not a glyph');
+  assert.doesNotMatch(facts, /[✓✔]/, 'no typed check mark');
+  assert.match(facts, /\+ chips\.join\(''\)\n\s*\+ catHtml\n/, 'the category chip rides in the facts line with the others');
+  assert.doesNotMatch(src, /class="gr-meta"/, 'the meta run under the title is gone');
+  const lib = goalsLib();
+  assert.match(lib.ring(1, 3, false), /stroke="var\(--ink\)"/, 'an open goal\'s arc is ink');
+  assert.match(lib.ring(3, 3, true), /stroke="var\(--ok\)"/, 'an achieved goal\'s arc is the ok colour');
+  assert.doesNotMatch(read('goals-lib.js'), /var\(--accent\)/, 'the lib spends no accent');
+});
+
+test('goals: the card is the row folded — no box, one fact source, the subtitle as its tooltip', () => {
+  const src = read('goals-render.js');
+  const card = src.slice(src.indexOf('function goalCardHtml'), src.indexOf('function renderList'));
+  assert.match(card, /\$\{factsHtml\}/, 'the card renders the same facts line');
+  assert.match(card, /\$\{idHtml\}/, 'with the id inside the title');
+  assert.match(card, /class="goal-card__foot">\$\{right\}/, 'and the same right-column state as its foot');
+  const css = read('goals.css');
+  const cardRule = block(css, '.goal-card');
+  assert.doesNotMatch(cardRule, /border(-radius)?:/, 'a card inside the panel draws no box');
+  assert.match(block(css, '.goal-grid'), /gap: 1px 0; background: var\(--rule-soft\)/, 'the hairline is painted BETWEEN rows by the grid');
+  assert.ok(!/goal-card--skel|goal-card--blocked/.test(css), 'the old card skeleton and the dashed blocked card are gone');
+  assert.match(read('goals-page.js'), /gr-row gr-row--skel/, 'the boot skeleton is row-shaped');
+});
+
+test('goals.css and people.css spend only the fifteen, and every token they name exists', () => {
+  for (const f of ['goals.css', 'people.css']) {
+    const css = read(f);
+    noAlias(css, f);
+    tokensDefined(css, f);
+  }
+});
+
+// =========================================================================
+// PEOPLE + SCOUTING — one directory, two doors
+// =========================================================================
+
+test('scouting is the same page as people: one body, one script, no script of its own', () => {
+  const people = read('people.html');
+  const scouting = read('scouting.html');
+  const bodyOf = (html) => html.slice(html.indexOf('<body'));
+  assert.equal(bodyOf(scouting), bodyOf(people), 'the two bodies are byte-identical');
+  assert.ok(!fs.existsSync(path.join(PUB, 'scouting.js')), 'scouting.js is gone — the third rendering of one endpoint');
+  assert.doesNotMatch(scouting, /<style[^>]*>/, 'the legacy door carries no inline style');
+  for (const html of [people, scouting]) {
+    assert.match(html, /\/builders\/people\.js/);
+    assert.match(html, /\/builders\/people\.css/);
+    assert.match(html, /\/builders\/dom-utils\.js/, 'the toolkit the rank label and the number formats come from');
+    assert.match(html, /<h1 class="page-head__h">People<\/h1>/);
+  }
+});
+
+test('the directory row shows the avatar, the name and the login the API returns, and the name is a door', () => {
+  const src = read('people.js');
+  assert.match(src, /b\.avatar_url\s*\?\s*'<img class="dir-avatar" src="' \+ esc\(b\.avatar_url\)/, 'the avatar the pages dropped');
+  assert.match(src, /dir-avatar dir-avatar--initial/, 'an initial when there is none');
+  assert.match(src, /return b\.display_name \|\| b\.github_login \|\| \('#' \+ b\.github_id\);/, 'the display name reads first');
+  assert.match(src, /class="lb-name dir-name" href="https:\/\/github\.com\/' \+ encodeURIComponent\(b\.github_login\)/,
+    'the shell\'s .lb-name, to the one page every listed builder has');
+  assert.match(src, /'<span class="dir-login">@' \+ esc\(b\.github_login\)/, 'the login under the name says where the door goes');
+  assert.match(src, /<span class="fact-chip">' \+ esc\(String\(d\)\)/, 'crafts are chips');
+  assert.doesNotMatch(src, /class="num"/, 'the shell\'s ledger__num, not the bare .num scouting.js had corrected');
+  assert.match(src, /class="ledger__num"/);
+});
+
+test('the directory has a search, a sort and a craft lens on the kit bar, and pages through the kit', () => {
+  const src = read('people.js');
+  assert.match(src, /kit\.makeFilterBar\(\{/);
+  assert.match(src, /search: \{ id: 'people-q'/);
+  assert.match(src, /\{ id: 'people-sort', label: 'Sort'/);
+  assert.match(src, /\{ id: 'people-craft', label: 'Craft'/);
+  assert.match(src, /kit\.makePager\('people'/);
+  assert.match(src, /kit\.makeLedger\(\{/);
+  assert.doesNotMatch(src, /createElement\('table'\)/, 'no hand-built table');
+});
+
+test('the directory names its floor from the pack, and never says Archon-only', () => {
+  const src = read('people.js');
+  assert.match(src, /rankLabel\('metic'\)/);
+  assert.doesNotMatch(decomment(src), /Archon-only/);
+  assert.doesNotMatch(read('people.html'), /Archon/);
+});
+
+// =========================================================================
+// SESSIONS
+// =========================================================================
+
+test('sessions: the nowrap + wrapper pair is gone, and with it the sticky-header overlay', () => {
+  const css = decomment(read('sessions.css'));
+  assert.doesNotMatch(css, /white-space:\s*nowrap/, 'no blanket nowrap on every cell');
+  assert.doesNotMatch(css, /ledger-table-wrap/, 'no wrapper — the shell\'s card strip handles a phone');
+  assert.doesNotMatch(read('sessions.html'), /ledger-table-wrap/);
+  assert.doesNotMatch(css, /var\(--info\)|ledger-sid/, 'the session id is no longer painted in the info colour');
+  noAlias(css, 'sessions.css');
+  tokensDefined(css, 'sessions.css');
+});
+
+test('sessions: every id on a row is a door, the earned figure is shown, the totals ride the top strip', () => {
+  const src = read('sessions.js');
+  assert.match(src, /<a class="fact-chip" href="\/builders\/task\/\$\{encodeURIComponent\(String\(t\)\)\}">task \$\{escapeHtml\(String\(t\)\)\}<\/a>/,
+    'a task id is a chip to the task page');
+  assert.match(src, /<a class="lb-name" href="\/builders\/profile\?id=\$\{encodeURIComponent\(String\(s\.builder_id\)\)\}">/, 'the builder is a door to their profile');
+  assert.match(src, /<span class="ov-mono" title="\$\{escapeHtml\(s\.session_id\)\}">/, 'the session id is a mono fact with the full id on hover');
+  assert.match(src, /fmtInt\(s\.drachmae_earned\)/, 'what the session earned is on the row');
+  assert.doesNotMatch(src, /`#\$\{escapeHtml\(t\)\}`/, 'no bare hash-prefixed task text');
+  const html = read('sessions.html');
+  assert.match(html, /<section class="ov-summary" id="stats-scroll"/, 'the totals are the top-of-page strip');
+  assert.match(html, /<div class="stat-row" id="stats-body"><\/div>/);
+  const ths = (html.match(/<th[ >]/g) || []).length;
+  assert.equal(ths, 9, 'nine columns: session, builder, tasks, earned, turns, tokens, tool errors, duration, recorded');
+  assert.match(src, /colspan="9"/, 'the empty row spans them all');
+  const fam = html.indexOf('/builders/oversight.css');
+  assert.ok(fam > 0 && html.indexOf('/builders/sessions.css') > fam, 'sessions.html links the family sheet before its own');
+});
+
+test('sessions: the floor is written from the pack\'s rank label, never a hardcoded rank', () => {
+  const src = read('sessions.js');
+  const sealed = src.slice(src.indexOf('function showSealed'), src.indexOf('// ---- paging state'));
+  assert.match(sealed, /const floor = rankLabel\('metic'\)/);
+  assert.match(sealed, /\$\('#gate-h'\)\.textContent = `\$\{floor\} and up`/);
+  assert.doesNotMatch(decomment(src), /Archons only|Metic rank up|Archon-only/);
+  assert.doesNotMatch(read('sessions.html'), /Archon/);
+});
+
+// =========================================================================
+// The harness carries what the pages read, and the states files ask for the new states
+// =========================================================================
+
+test('the harness feeds: rollups for every goal, the category set, avatars on the directory', () => {
+  const goals = readJson('goals.json').goals;
+  const rollups = readJson('goals__rollups.json').rollups;
+  const byGoal = new Set(rollups.map((r) => String(r.goal_id)));
+  for (const g of goals) assert.ok(byGoal.has(String(g.id)), `goal ${g.id} has a rollup row`);
+  assert.ok(rollups.some((r) => r.next_ready_id), 'at least one row has a claimable next task');
+  assert.ok(rollups.some((r) => r.blocked > 0 && r.ready === 0 && r.active === 0), 'at least one goal is blocked-only');
+  assert.ok(goals.some((g) => g.subtitle), 'some goals carry a subtitle');
+  assert.ok(goals.some((g) => g.category && g.category.slug), 'some goals carry a category');
+  const cats = readJson('work-categories.json').categories;
+  assert.ok(cats.length >= 2 && cats.every((c) => c.slug && c.label));
+  const dir = readJson('scouting.json').builders;
+  assert.ok(dir.some((b) => b.avatar_url) && dir.some((b) => !b.avatar_url), 'the directory fixture has builders with and without an avatar');
+});
+
+test('the states files exercise the redesign\'s new states', () => {
+  const goals = JSON.parse(read('goals.states.json'));
+  assert.ok(goals.states.filters && goals.states.cards, 'goals: the Filters disclosure and the cards view are measured');
+  assert.deepEqual(goals.states.cards.expect.value, [['#f-goal-view', 'cards']]);
+  const people = JSON.parse(read('people.states.json'));
+  assert.ok(people.states.search, 'people: a search is measured');
+  const scouting = JSON.parse(read('scouting.states.json'));
+  assert.deepEqual(scouting.states.board.expect.visible, ['#people-scroll'], 'scouting expects the People panel');
+  const sessions = JSON.parse(read('sessions.states.json'));
+  assert.deepEqual(sessions.states.ledger.expect.visible, ['#stats-scroll', '#sessions-scroll']);
+});

package/tests/ui_design_skills.mjs

@@ -107,6 +107,47 @@ test('the taste core of task 1003325 exists as four in-house skills and every on
   }
 });
 
+// ── the impeccable method (task 1003326, ADR 0221): one skill, one playbook per sub-command ──
+const IMPECCABLE = path.join(SKILLS, 'impeccable');
+const IMPECCABLE_SUBCOMMANDS = ['shape', 'audit', 'critique', 'polish', 'harden', 'animate', 'typeset', 'colorize', 'layout', 'adapt', 'distill', 'clarify', 'onboard', 'optimize', 'document', 'extract'];
+
+test('impeccable is one in-house skill whose sixteen sub-commands each own exactly one playbook under reference/', () => {
+  assert.ok(ownDirs.includes('impeccable'), 'skills/impeccable/SKILL.md exists');
+  assert.ok(manifest.contributes.skills.includes('impeccable'), 'declared in contributes.skills');
+  const skill = read(path.join(IMPECCABLE, 'SKILL.md'));
+  const refDir = path.join(IMPECCABLE, 'reference');
+  const onDisk = fs.readdirSync(refDir).filter((f) => f.endsWith('.md')).map((f) => f.replace(/\.md$/, '')).sort();
+  for (const sub of IMPECCABLE_SUBCOMMANDS) {
+    assert.ok(onDisk.includes(sub), `reference/${sub}.md exists (the task body names it)`);
+    assert.ok(skill.includes(`reference/${sub}.md`), `SKILL.md routes \`${sub}\` to its playbook`);
+  }
+  for (const ref of onDisk) assert.ok(skill.includes(`reference/${ref}.md`), `reference/${ref}.md is routed from SKILL.md (no orphan playbook)`);
+  for (const ref of onDisk) {
+    const text = read(path.join(refDir, `${ref}.md`));
+    assert.ok(!text.includes(policy.preamble.begin), `reference/${ref}.md carries no preamble copy (the block is pinned once, in SKILL.md, and governs every playbook)`);
+    assert.ok(text.trim().length > 400, `reference/${ref}.md is a playbook, not a stub`);
+  }
+});
+
+test('impeccable carries none of the behaviour that made its origin dangerous: no hooks, no bypass agent, no telemetry, no remote bundle, no live-server token', () => {
+  const files = [path.join(IMPECCABLE, 'SKILL.md'), ...fs.readdirSync(path.join(IMPECCABLE, 'reference')).map((f) => path.join(IMPECCABLE, 'reference', f))];
+  for (const f of files) {
+    const text = read(f);
+    const rel = path.relative(ROOT, f).split(path.sep).join('/');
+    assert.doesNotMatch(text, /bypassPermissions|--dangerously-skip-permissions/, `${rel}: no permission bypass`);
+    assert.doesNotMatch(text, /\b(write|add|install|register)\b[^.\n]{0,60}\b(PostToolUse|PreToolUse|Stop)\b[^.\n]{0,40}\bhooks?\b/i, `${rel}: no step writes a hook into a harness config`);
+    assert.doesNotMatch(text, /\b(write|edit|patch)\b[^.\n]{0,40}\bsettings(\.local)?\.json\b/i, `${rel}: no step edits settings.json`);
+    assert.doesNotMatch(text, /\b(enable|send|collect|report|emit)s?\b[^.\n]{0,40}\btelemetry\b|\btelemetry\b[^.\n]{0,40}\b(is|are|stays|defaults?)\s+(on|enabled|sent)\b/i, `${rel}: no step turns on or sends telemetry (naming the ban is fine; directing it is not)`);
+    assert.doesNotMatch(text, /\b(curl|wget|fetch|download)\b[^.\n]{0,60}\bhttps?:\/\//i, `${rel}: no remote bundle download`);
+    assert.doesNotMatch(text, /\b(auth|access|bearer|helper)\s+token\b/i, `${rel}: no live-server token`);
+    assert.doesNotMatch(text, /(disregard|ignore)\b[^.\n]{0,40}\b(system prompt|harness)/i, `${rel}: no instruction-override directive`);
+  }
+  const skill = read(path.join(IMPECCABLE, 'SKILL.md'));
+  assert.match(skill, /playwright/i, 'the live loop is the playwright plugin, named as a prerequisite');
+  assert.match(skill, /kit\/render\.js/, 'the headless loop is the kit');
+  assert.match(skill, /1003329/, 'the detector is named as its own task, not shipped here');
+});
+
 test('every in-house SKILL.md opens with the PLATFORM PREAMBLE, byte-identical to PREAMBLE.md, exactly once, right after its frontmatter', () => {
   const pre = read(path.join(SKILLS, 'PREAMBLE.md')).trimEnd();
   for (const name of ownDirs) {

package/modules/hall-ui/public/scouting.js

@@ -1,73 +0,0 @@
-// scouting.js — the internal Archon-only cross-project scouting view (ADR 0141 §4,
-// task #1002114). Fetches /api/gds/scouting (Archon-gated server-side) and renders a
-// ranked table. A non-Archon gets a 403 and sees the Archon-only notice — the data
-// endpoint's rank gate is the real protection ("NOT shown to builders"). All network
-// values are rendered via textContent — never innerHTML.
-(function () {
-  'use strict';
-  var body = document.getElementById('body');
-
-  function el(tag, cls) { var e = document.createElement(tag); if (cls) e.className = cls; return e; }
-  function td(text, cls) { var c = el('td', cls); c.textContent = text; return c; }
-
-  function fmtRecency(iso) {
-    if (!iso) return '—';
-    var t = Date.parse(iso);
-    if (isNaN(t)) return '—';
-    var days = Math.floor((Date.now() - t) / 86400000);
-    if (days <= 0) return 'today';
-    if (days === 1) return '1 day ago';
-    if (days < 30) return days + ' days ago';
-    return Math.floor(days / 30) + ' mo ago';
-  }
-
-  function render(builders) {
-    body.className = '';
-    body.textContent = '';
-    if (!builders || builders.length === 0) {
-      body.className = 'profile__placeholder';
-      body.textContent = 'No cross-project activity reported yet.';
-      return;
-    }
-    // table.ledger, appended straight into #body: the design system's table
-    // styling, and #body becomes the :has(> .ledger) phone scroll strip.
-    var table = el('table', 'ledger');
-    var thead = el('thead');
-    var hr = el('tr');
-    [['Builder', ''], ['Projects', 'ledger__num'], ['Credits', 'ledger__num'], ['Ships', 'ledger__num'], ['Karma', 'ledger__num'], ['Disciplines', ''], ['Last active', '']]
-      .forEach(function (h) { var th = el('th', h[1]); th.textContent = h[0]; hr.appendChild(th); });
-    thead.appendChild(hr); table.appendChild(thead);
-    var tbody = el('tbody');
-    builders.forEach(function (b) {
-      var tr = el('tr');
-      var who = el('td');
-      var name = el('span', 'who');
-      name.textContent = b.github_login || b.display_name || ('#' + b.github_id);
-      who.appendChild(name);
-      tr.appendChild(who);
-      tr.appendChild(td(String(b.project_count != null ? b.project_count : '—'), 'ledger__num'));
-      tr.appendChild(td(String(b.total_credits != null ? b.total_credits : 0), 'ledger__num'));
-      tr.appendChild(td(String(b.total_tasks_shipped != null ? b.total_tasks_shipped : 0), 'ledger__num'));
-      tr.appendChild(td(String(b.total_karma != null ? b.total_karma : 0), 'ledger__num'));
-      tr.appendChild(td(Array.isArray(b.disciplines) ? b.disciplines.join(', ') : '—'));
-      tr.appendChild(td(fmtRecency(b.last_active)));
-      tbody.appendChild(tr);
-    });
-    table.appendChild(tbody);
-    body.appendChild(table);
-  }
-
-  fetch('/api/gds/scouting', { headers: { Accept: 'application/json' } })
-    .then(function (r) {
-      if (r.status === 403 || r.status === 401) { throw { archon: true }; }
-      if (!r.ok) throw new Error('http ' + r.status);
-      return r.json();
-    })
-    .then(function (data) { render(data && data.builders); })
-    .catch(function (e) {
-      body.className = 'profile__placeholder';
-      body.textContent = (e && e.archon)
-        ? 'This view is Archon-only.'
-        : 'Couldn’t load the scouting view right now.';
-    });
-}());