@bongos/core 1.19.459 → 1.19.460

package/modules/hall-ui/public/copy-desk.states.json

@@ -1,12 +1,12 @@
 {
-  "_": "Copy desk — the one-voice review queue. Its confirm dialog is a real <dialog>, so its ::backdrop is the sheet's single sanctioned literal (black with alpha as a scrim). Written with the re-skin (task 1003307) so this page is MEASURED at three widths in both modes rather than looked at once.",
+  "_": "Copy desk — the one-voice review queue. Its two dialogs are real <dialog>s, so their ::backdrop is the sheet's single sanctioned literal (black with alpha as a scrim). Written with the re-skin (task 1003307) so this page is MEASURED at three widths in both modes rather than looked at once; the redesign (task 1003471) put a queue, ten duplicates and a search's hits in the harness so the rows and both dialogs can be looked at.",
   "page": "/builders/copy-desk",
   "surface": "hall-ui",
   "stub": {
     "prefix": "/builders/"
   },
   "modeQuery": false,
-  "_feeds": "The kit's own stub carries no feed for this page, so against it the page renders its EMPTY and SKELETON states — which is the point: those are states the floors must hold in. Against the hall-preview harness the same states render populated. Every declared 404 below is a fixture the harness does not carry, named rather than hidden.",
+  "_feeds": "The kit's own stub carries no feed for this page, so against it the page renders its EMPTY state — which is the point: that is a state the floors must hold in. Against the hall-preview harness the same states render populated: copy-desk__queue.json (six flags across open, resolved and dismissed, with a gone target, a moved one and a whole-surface one; ten real duplicates) and copy-desk__strings.json (a search's hits). Every declared 404 below is a feed the kit's stub does not carry, named rather than hidden. The composer and closer states use clickIfVisible because against the stub the buttons do not exist.",
   "ignoreRequests": [
     "/api/(gds|bongos)/me$",
     "/api/(gds|bongos)/me/",
@@ -45,6 +45,63 @@
     },
     "out": {
       "auth": false
+    },
+    "search": {
+      "auth": true,
+      "actions": [
+        [
+          "wait",
+          700
+        ],
+        [
+          "fill",
+          "#cd-search",
+          "save"
+        ],
+        [
+          "wait",
+          600
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#cd-results"
+        ]
+      }
+    },
+    "composer": {
+      "auth": true,
+      "actions": [
+        [
+          "wait",
+          700
+        ],
+        [
+          "clickIfVisible",
+          ".cd-flag-btn"
+        ],
+        [
+          "wait",
+          250
+        ]
+      ]
+    },
+    "closer": {
+      "auth": true,
+      "actions": [
+        [
+          "wait",
+          700
+        ],
+        [
+          "clickIfVisible",
+          ".cd-close-btn"
+        ],
+        [
+          "wait",
+          250
+        ]
+      ]
     }
   },
   "reducedMotion": {

package/modules/hall-ui/public/oversight.css

@@ -1,9 +1,12 @@
 /* oversight.css — the oversight family's archetype (task 1003469, goal
-   1000081): what a oversight ROW is in the chrome world, and the pieces the
+   1000081): what an oversight ROW is in the chrome world, and the pieces the
    four pages (government, watch, harbor, gate) share around it — the figure
    band inside a panel, the group head, the inline form, the grant toggle, the
    confirm modal. The third family sheet after record.css and room.css: a page
-   sheet holds only what one page has and the others do not.
+   sheet holds only what one page has and the others do not. The collaboration
+   pages (collab, copy desk — task 1003471) ride the same row rather than a
+   fourth: a page whose repeated thing is a titled row with facts and actions
+   links this sheet before its own.
 
    Every panel is the shell's .scroll; every heading its .scroll__h; every state
    pill its .fact-pill; every table its .ledger. This sheet adds nothing the
@@ -150,6 +153,12 @@ button.ov-row[aria-pressed="true"] .ov-row__title { color: var(--accent-ink); }
    The shell's glass .stat-row, given the air a panel would have under it. */
 .ov-summary { margin: 0 0 var(--sp-md); }
 
+/* A chip that is a door (the task or goal a row is about) keeps the chip's
+   faint ink at rest — a coloured chip would read as a second status — and
+   takes the link ink on hover, the way the row's title link does. */
+a.fact-chip { color: var(--ink-faint); }
+a.fact-chip:hover { color: var(--accent-ink); border-color: var(--accent-ink); text-decoration: none; }
+
 /* ---- plain facts and the machine's words ------------------------------------ */
 .ov-fact { font-size: 12.5px; color: var(--ink-faint); font-variant-numeric: tabular-nums; }
 .ov-fact b { color: var(--ink-soft); font-weight: 500; }

package/modules/lifecycle/help-requests.js

@@ -49,6 +49,16 @@ async function craftsForBuilder(builderId, deps = {}) {
 }
 
 const COLS = 'id, requested_by, needs_craft, needs_builder_id, what_is_stuck, task_id, goal_id, status, created_at, updated_at';
+// The two list reads also NAME the people on a row — who is asking (the fact
+// the collab page owes a helper: "who to answer", task 1003471) and who a
+// by-name ask is addressed to — through two LEFT JOINs on builders. COLS stays
+// bare for the writes, whose RETURNING cannot reach a joined alias.
+const LIST_COLS = `${COLS.split(', ').map((c) => `h.${c}`).join(', ')}, `
+  + 'a.github_login AS requested_by_login, a.display_name AS requested_by_name, '
+  + 'n.github_login AS needs_builder_login, n.display_name AS needs_builder_name';
+const LIST_FROM = 'FROM lifecycle_help_requests h '
+  + 'LEFT JOIN builders a ON a.id = h.requested_by '
+  + 'LEFT JOIN builders n ON n.id = h.needs_builder_id';
 const MAX_STUCK = 4000;
 // Defence in depth: both reads are bounded today (open-status churn, per-builder
 // scope), but an unsettled pile should degrade the page, not the server.
@@ -130,11 +140,11 @@ async function listOpenForBuilder({ builderId, crafts = [], limit = MAX_ROWS },
   const activePool = deps.pool || pool;
   const safeCrafts = (Array.isArray(crafts) ? crafts : []).filter((c) => HELP_CRAFTS.includes(c));
   const { rows } = await activePool.query(
-    `SELECT ${COLS} FROM lifecycle_help_requests
-      WHERE status = 'open'
-        AND requested_by <> $1
-        AND (needs_builder_id = $1 OR needs_craft = ANY($2::text[]))
-      ORDER BY created_at DESC, id DESC
+    `SELECT ${LIST_COLS} ${LIST_FROM}
+      WHERE h.status = 'open'
+        AND h.requested_by <> $1
+        AND (h.needs_builder_id = $1 OR h.needs_craft = ANY($2::text[]))
+      ORDER BY h.created_at DESC, h.id DESC
       LIMIT $3`,
     [builderId, safeCrafts, capRows(limit)]
   );
@@ -181,9 +191,9 @@ function craftMapSql(col) {
 async function listMine({ builderId, status = null, limit = MAX_ROWS }, deps = {}) {
   const activePool = deps.pool || pool;
   const { rows } = await activePool.query(
-    `SELECT ${COLS} FROM lifecycle_help_requests
-      WHERE requested_by = $1 AND ($2::text IS NULL OR status = $2)
-      ORDER BY created_at DESC, id DESC
+    `SELECT ${LIST_COLS} ${LIST_FROM}
+      WHERE h.requested_by = $1 AND ($2::text IS NULL OR h.status = $2)
+      ORDER BY h.created_at DESC, h.id DESC
       LIMIT $3`,
     [builderId, status, capRows(limit)]
   );

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.459",
+  "version": "1.19.460",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.459",
+      "version": "1.19.460",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.459",
+  "version": "1.19.460",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -33,7 +33,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.459'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.460'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/collab_page.mjs

@@ -53,22 +53,26 @@ test('an unknown age reads as fresh, never as an accusation', () => {
 
 test('ageing changes how a row LOOKS, not only where it sits', () => {
   // The whole point of the clause. Each band must have its own visual treatment
-  // in CSS, or "visibly aging" is just a sort order with extra steps.
+  // in CSS, or "visibly aging" is just a sort order with extra steps. Since the
+  // redesign (task 1003471) the treatment is the age PILL's colour in the row's
+  // right column — a glance down the list reads the column — and never a
+  // coloured band down the row's edge, which this world does not draw.
   const css = read('modules', 'hall-ui', 'public', 'collab.css');
   const L = lib();
   for (const b of L.BANDS) {
-    assert.match(css, new RegExp(`\\.cb-item--${b.id}\\b`), `${b.id} has its own styling`);
+    assert.match(css, new RegExp(`^\\.cb-age--${b.id}\\s*\\{[^}]*color: var\\(--`, 'm'), `${b.id} has its own colour`);
   }
-  assert.match(css, /\.cb-item--stale\s*\{[^}]*border-left-color/, 'the band reads down a list at a glance');
+  assert.match(css, /\.cb-age--stale\s*\{[^}]*var\(--danger\)/, 'stale reads down a list at a glance, in the danger ink');
   // Colour alone is not a message and not everyone sees it.
-  assert.match(css, /\.cb-item--stale \.cb-age/, 'and the words are emphasised too');
+  assert.match(css, /\.cb-age--stale\s*\{[^}]*font-weight/, 'and the words are emphasised too');
+  assert.ok(!/border-left/.test(css), 'no coloured band');
 });
 
 test('the row markup carries the band class and the label', () => {
   const js = read('modules', 'hall-ui', 'public', 'collab.js');
-  assert.match(js, /cb-item--\$\{L\.ageBand\(/, 'the class comes from the band');
-  assert.match(js, /cb-age cb-age--\$\{band\.id\}/, 'and so does the chip');
+  assert.match(js, /cb-age cb-age--\$\{band\.id\}/, 'the pill\'s class comes from the band');
   assert.match(js, /escapeHtml\(band\.label\)/, 'the label is rendered, escaped');
+  assert.match(js, /L\.ageBand\(req\.created_at, nowMs\)/, 'through the lib, so the boundaries are the tested ones');
 });
 
 test('oldest first WITHIN the page, in addition to the band', () => {
@@ -143,7 +147,9 @@ test('every CSS token the page uses exists in style.css', () => {
   const css = read('modules', 'hall-ui', 'public', 'collab.css');
   const style = read('modules', 'hall-ui', 'public', 'style.css');
   const used = new Set([...css.matchAll(/var\((--[a-z-]+)\)/g)].map((x) => x[1]));
-  assert.ok(used.size >= 5);
+  // Four since the redesign (task 1003471): the sheet holds only the age
+  // bands' inks, the row and the panel being the archetype's and the shell's.
+  assert.ok(used.size >= 4);
   for (const t of used) {
     assert.ok(new RegExp(`^\\s*${t}:`, 'm').test(style), `${t} must be defined (idea 1000821)`);
   }

package/tests/hall_collab_world.mjs

@@ -0,0 +1,214 @@
+// tests/hall_collab_world.mjs — the collaboration pages in the chrome world
+// (task 1003471, goal 1000081): collab and the copy desk, redesigned on the
+// hall's row archetype (oversight.css) rather than re-skinned. Static pins over
+// the shipped source: the family sheet is linked and the page sheets spend only
+// the fifteen, every list is the family's row and the card-in-a-card is gone,
+// state is colour and never opacity, the facts the audit found thrown away (who
+// is asking; the duplicate total; the surface count) are rendered, the server
+// names the asker, the dialogs are the family modal, the lists that grow are
+// paged through the kit, and the harness carries what the pages read.
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const PUB = path.join(ROOT, 'modules', 'hall-ui', 'public');
+const FIX = path.join(ROOT, 'scripts', 'hall-preview', 'fixtures');
+const read = (f) => fs.readFileSync(path.join(PUB, f), 'utf8').replace(/\r\n/g, '\n');
+const readRoot = (...p) => fs.readFileSync(path.join(ROOT, ...p), 'utf8').replace(/\r\n/g, '\n');
+const PAGES = ['collab', 'copy-desk'];
+
+// collab-lib.js is pure, so RUN it rather than grep it.
+function lib() {
+  const win = {};
+  new Function('window', read('collab-lib.js'))(win);
+  return win.OTBCollabLib;
+}
+
+test('both pages link the family sheet, before their own', () => {
+  for (const p of PAGES) {
+    const html = read(`${p}.html`);
+    const fam = html.indexOf('/builders/oversight.css');
+    const own = html.indexOf(`/builders/${p}.css`);
+    assert.ok(fam > 0, `${p}.html links oversight.css`);
+    assert.ok(own > fam, `${p}.html links its own sheet after the family's`);
+  }
+});
+
+test('the page sheets spend only the fifteen, in px, and never opacity', () => {
+  for (const p of PAGES) {
+    const css = read(`${p}.css`);
+    const hexes = css.match(/#[0-9a-f]{3,8}\b/gi) || [];
+    assert.deepEqual(hexes, [], `${p}.css carries literal colours: ${hexes.join(', ')}`);
+    assert.ok(!/\d(\.\d+)?rem\b/.test(css), `${p}.css sizes in px plus tokens, not rem`);
+    assert.ok(!/opacity\s*:/.test(css), `${p}.css carries state as colour, never opacity`);
+    assert.ok(!/border-left/.test(css), `${p}.css paints no coloured band`);
+  }
+  // The one literal the copy desk keeps: the native dialog's scrim.
+  const cd = read('copy-desk.css');
+  const literals = cd.match(/rgba?\([^)]*\)/g) || [];
+  assert.deepEqual(literals, ['rgba(0, 0, 0, 0.55)'], 'black with alpha as a scrim, and nothing else');
+  assert.match(cd, /\.cd-dialog::backdrop \{ background: rgba\(0, 0, 0, 0\.55\); \}/, 'and it is spent on ::backdrop');
+});
+
+test('every list is the family\'s row, and the card-in-a-card is gone', () => {
+  for (const p of PAGES) assert.match(read(`${p}.js`), /class="ov-row/, `${p}.js renders .ov-row`);
+  // A class name, whole: `cd-stat` must not match the `cd-status` filter id.
+  const gone = (src, cls) => !new RegExp(`${cls}(?![a-z])`).test(src);
+  for (const old of ['cb-item', 'cb-list', 'cb-ctx']) {
+    assert.ok(gone(read('collab.js'), old) && gone(read('collab.css'), `\\.${old}`), `collab no longer emits ${old}`);
+  }
+  for (const old of ['cd-card', 'cd-stat', 'cd-tag', 'cd-filters__select', 'cd-browse', 'cd-empty']) {
+    assert.ok(gone(read('copy-desk.js'), old) && gone(read('copy-desk.css'), `\\.${old}`), `copy desk no longer emits ${old}`);
+  }
+  for (const p of PAGES) assert.match(read(`${p}.html`), /class="empty-state"/, `${p}.html empties with the kit's own state`);
+});
+
+// ---- collab: the facts the audit found thrown away ---------------------------
+test('collab renders WHO IS ASKING, as a door to their profile', () => {
+  const L = lib();
+  assert.equal(L.askerOf({ requested_by: 92, requested_by_name: 'Preview Gamma', requested_by_login: 'preview-gamma' }), 'Preview Gamma');
+  assert.equal(L.askerOf({ requested_by: 92, requested_by_login: 'preview-gamma' }), 'preview-gamma', 'the login when there is no display name');
+  assert.equal(L.askerOf({ requested_by: 92 }), 'builder 92', 'an older server\'s bare id is still a name, never nothing');
+  const js = read('collab.js');
+  assert.match(js, /L\.askerOf\(req\)/, 'the row asks the lib who is asking');
+  assert.match(js, /\/builders\/profile\?id=\$\{escapeHtml\(String\(req\.requested_by\)\)\}/, 'and links the hall\'s per-builder profile');
+  assert.match(js, /asked by \$\{who\}/, 'as a fact on the row');
+});
+
+test('the server names the people on a row through a join, and the writes stay bare', () => {
+  const src = readRoot('modules', 'lifecycle', 'help-requests.js');
+  assert.match(src, /requested_by_login, a\.display_name AS requested_by_name/, 'the asker is joined');
+  assert.match(src, /needs_builder_login, n\.display_name AS needs_builder_name/, 'and the by-name addressee');
+  assert.match(src, /LEFT JOIN builders a ON a\.id = h\.requested_by/, 'a LEFT join, so a row never vanishes with its builder');
+  for (const fn of ['listOpenForBuilder', 'listMine']) {
+    const body = src.slice(src.indexOf(`async function ${fn}`));
+    assert.match(body.slice(0, 700), /SELECT \$\{LIST_COLS\} \$\{LIST_FROM\}/, `${fn} reads the joined columns`);
+  }
+  const upd = src.slice(src.indexOf('async function setHelpRequestStatus'));
+  assert.match(upd.slice(0, 600), /RETURNING \$\{COLS\}/, 'the UPDATE cannot reach a joined alias, so it returns the bare columns');
+});
+
+test('the first line is decided: the ask\'s first sentence is the title, the rest the sub, no word lost', () => {
+  const L = lib();
+  const two = L.titleOf('The record exits to the board. I cannot tell which link does it.');
+  assert.deepEqual(two, { title: 'The record exits to the board.', rest: 'I cannot tell which link does it.' });
+  const one = L.titleOf('Is there a safe order of operations?');
+  assert.deepEqual(one, { title: 'Is there a safe order of operations?', rest: '' }, 'one sentence is the whole title');
+  const long = 'A'.repeat(150) + '. Then more.';
+  assert.equal(L.titleOf(long).title, long, 'a first sentence too long to be a line keeps the whole ask together');
+  assert.equal(L.titleOf('docs/x.md is stale and y.js too').title, 'docs/x.md is stale and y.js too', 'a dot inside a path is not a sentence break');
+  const t = L.titleOf('  padded.  and trailing   ');
+  assert.equal(`${t.title} ${t.rest}`, 'padded. and trailing', 'nothing is clipped');
+  const js = read('collab.js');
+  assert.match(js, /L\.titleOf\(req\.what_is_stuck\)/);
+  assert.match(js, /class="ov-row__title">\$\{escapeHtml\(t\.title\)\}/);
+  assert.match(js, /class="ov-row__sub">\$\{escapeHtml\(t\.rest\)\}/);
+});
+
+test('"asked of you" reads in runs — by name first, then each craft', () => {
+  const L = lib();
+  assert.equal(L.groupOf({ needs_builder_id: 95 }).id, 'you');
+  assert.equal(L.groupOf({ needs_craft: 'artist' }).label, 'asked of artists');
+  assert.match(L.addressedTo({ needs_builder_id: 7, needs_builder_name: 'Preview Alpha' }, 9), /Preview Alpha by name/, 'a named addressee is named');
+  const js = read('collab.js');
+  assert.match(js, /ov-group__head/, 'each run has the family\'s group head');
+  assert.match(js, /Number\(b\.id === 'you'\) - Number\(a\.id === 'you'\)/, 'and the personal run sorts first');
+});
+
+test('the age is a state pill in the row\'s right column, and every band has its own colour', () => {
+  const css = read('collab.css');
+  const L = lib();
+  for (const b of L.BANDS) assert.match(css, new RegExp(`^\\.cb-age--${b.id}\\s*\\{[^}]*color: var\\(--`, 'm'), `${b.id} has its own colour rule`);
+  assert.match(css, /\.cb-age--stale\s*\{[^}]*var\(--danger\)/, 'stale is the danger ink');
+  assert.match(css, /\.cb-age--aging\s*\{[^}]*var\(--warn\)/, 'aging is the warn ink');
+  const js = read('collab.js');
+  assert.match(js, /class="fact-pill cb-age cb-age--\$\{band\.id\}"/, 'the pill is the shell\'s fact-pill');
+  assert.match(js, /<div class="ov-row__right">\$\{ageChip\(req, nowMs\)\}/, 'in the right column, so a glance down the list reads the ages');
+});
+
+// ---- the copy desk: quieter, and no fact lost ----------------------------------
+test('the copy desk\'s counts are the shell\'s glass strip, carrying two facts the boxes dropped', () => {
+  assert.match(read('copy-desk.html'), /class="stat-row ov-summary cd-summary" id="cd-summary-scroll"/);
+  const js = read('copy-desk.js');
+  assert.match(js, /stat-tile__num/, 'the figure is the shell\'s tile');
+  assert.match(js, /of \$\{int\(c\.duplicates_total\)\} said more than once/, 'the duplicate total was never shown before');
+  assert.match(js, /across \$\{int\(surfaces\)\} surface/, 'nor the surface count');
+  assert.ok(!/cd-stat__n/.test(js), 'the bordered box is gone');
+});
+
+test('state is colour from the verification vocabulary, never opacity', () => {
+  const js = read('copy-desk.js');
+  assert.match(js, /pill\('fact-pill--open', 'already flagged'\)/);
+  assert.match(js, /pill\('fact-pill--ok', 'looked at'\)/);
+  assert.match(js, /pill\('', 'untouched'\)/, 'the untouched row is the plain pill: colour marks the exception in a list that is mostly work');
+  assert.match(js, /pill\('fact-pill--warn', 'target gone'/);
+  assert.match(js, /f\.status === 'resolved' \? 'fact-pill--ok' : 'fact-pill--quiet'/);
+});
+
+test('the filters and the search are the kit\'s bar; the duplicates are paged through the kit', () => {
+  const js = read('copy-desk.js');
+  assert.equal((js.match(/kit\.makeFilterBar\(\{/g) || []).length, 2, 'two bars: the queue\'s filters and the search');
+  for (const id of ['cd-status', 'cd-surface', 'cd-search']) assert.match(js, new RegExp(`id: '${id}'`), `${id} is a kit control`);
+  assert.match(js, /kit\.makePager\('cd-dupes'/);
+  assert.match(js, /kit\.paginate\(ordered, dupePager\)/);
+  assert.match(js, /kit\.wirePager\(dupePager, rerender\)/);
+  assert.match(read('copy-desk.html'), /src="\/builders\/hall-kit\.js/, 'the page loads the kit');
+});
+
+test('the two dialogs are the family modal on a native <dialog>, with the number input in a field', () => {
+  const html = read('copy-desk.html');
+  assert.equal((html.match(/<dialog id="cd-(close-)?dialog" class="ov-modal cd-dialog">/g) || []).length, 2);
+  assert.match(html, /<div class="ov-field ov-field--wide">\s*<label class="ov-field__l" for="cd-close-task">[^<]*<\/label>\s*<input type="number" id="cd-close-task"/, 'the number input sits in the family field, which restates the 30px pill');
+  assert.ok(!/<label[^>]*>[^<]*<span class="cd-dialog__hint"/.test(html), 'no hint lives inside a label (the label voice would uppercase it)');
+  assert.equal((html.match(/class="ov-form__why"/g) || []).length, 3, 'the three hints are the form\'s own explainer line');
+  assert.match(html, /class="btn-accent" id="cd-submit"/, 'the accent door files the flag');
+});
+
+test('the copy desk renders MORE facts per row than any other page, and lost none', () => {
+  const js = read('copy-desk.js');
+  for (const fact of ['flagged_by_name', 'flagged_by_login', 'flagged_at', 'resolution_note', 'resolved_task_id',
+    'text_at_flag', 'file_at_flag', 'line_at_flag', 'f.current.file', 'f.current.line', 'f.moved', 'target_state',
+    'd.at', 'd.occurrences', 'd.surface', 'e.origin', 'e.file', 'truncated', 'blind_spots', 'freshness_check', 'r.at']) {
+    assert.ok(js.includes(fact), `${fact} is still rendered`);
+  }
+  assert.match(js, /said, when flagged:/, 'the snapshot is still labelled as the snapshot');
+  assert.match(js, /whole surface/, 'a surface-scope flag still says so');
+});
+
+test('the closing floor is the pack\'s rank label, not a Greek name in the markup', () => {
+  assert.ok(!/Metic\+/.test(read('copy-desk.html')), 'no "Metic+" in the lede');
+  assert.match(read('copy-desk.html'), /<span id="cd-close-rank">/);
+  assert.match(read('copy-desk.js'), /rankLabel\('metic'\)/);
+});
+
+// ---- the harness carries what the pages read ------------------------------------
+test('the harness fixtures exist and carry the shapes the pages read', () => {
+  const fx = (n) => JSON.parse(fs.readFileSync(path.join(FIX, `${n}.json`), 'utf8'));
+  const forMe = fx('help-requests__for-me');
+  assert.ok(Array.isArray(forMe.help_requests) && forMe.help_requests.length >= 4, 'four asks, one per band');
+  assert.ok(forMe.help_requests.every((r) => r.requested_by_name && r.what_is_stuck && r.created_at), 'each names its asker');
+  assert.ok(forMe.help_requests.some((r) => r.needs_builder_id != null), 'one is by name');
+  assert.deepEqual(forMe.crafts, ['builder']);
+  const mine = fx('help-requests__mine');
+  assert.ok(mine.help_requests.length >= 2 && mine.help_requests.every((r) => String(r.requested_by) === '95'), 'the viewer\'s own (me.json is builder 95)');
+  const q = fx('copy-desk__queue');
+  assert.ok(q.flags.some((f) => f.target_state === 'gone') && q.flags.some((f) => f.moved) && q.flags.some((f) => f.scope === 'surface'), 'a gone target, a moved one, a whole-surface one');
+  assert.ok(q.flags.some((f) => f.status === 'resolved') && q.flags.some((f) => f.status === 'dismissed'), 'and both closed outcomes');
+  assert.ok(q.duplicates.length >= 8 && q.duplicates.every((d) => Array.isArray(d.at) && d.at.length === d.occurrences), 'real duplicates with their places');
+  assert.ok(q.registry.at && q.registry.freshness_check && q.registry.counts && q.registry.surfaces, 'the registry block the note reads');
+  const s = fx('copy-desk__strings');
+  assert.ok(Array.isArray(s.entries) && s.entries.length > 0 && typeof s.matched === 'number' && 'truncated' in s && 'limit' in s);
+});
+
+test('the states files walk the new states', () => {
+  const cd = JSON.parse(read('copy-desk.states.json'));
+  assert.deepEqual(Object.keys(cd.states), ['queue', 'out', 'search', 'composer', 'closer']);
+  assert.deepEqual(cd.states.search.actions[1], ['fill', '#cd-search', 'save']);
+  assert.deepEqual(cd.states.composer.actions[1], ['clickIfVisible', '.cd-flag-btn'], 'clickIfVisible: against the kit\'s stub the button does not exist');
+  assert.deepEqual(cd.states.closer.actions[1], ['clickIfVisible', '.cd-close-btn']);
+  const cb = JSON.parse(read('collab.states.json'));
+  assert.deepEqual(cb.states.board.expect.visible, ['#cb-for-me']);
+});