@bongos/core 1.19.454 → 1.19.456

package/tests/goal_suggest.mjs

@@ -24,7 +24,7 @@ import { makeRunner } from './helpers.mjs';
 
 process.env.NODE_ENV = 'test';
 const require = createRequire(import.meta.url);
-const { suggestGoals, goalSuggestHandler, SUGGEST_LIMIT } = require('../modules/lifecycle/goal-suggest.js');
+const { suggestGoals, suggestGoalForCapture, goalSuggestHandler, SUGGEST_LIMIT } = require('../modules/lifecycle/goal-suggest.js');
 const { test, summary } = makeRunner();
 
 const V = 'BONGOS-V1';
@@ -192,4 +192,110 @@ await test('the handler clamps limit into a sane range', async () => {
   }
 });
 
+// =========================================================================
+// suggestGoalForCapture — ONE goal, or none, for a filing with nobody to choose
+// (task 1003067 / BV1.R11). The HTTP suggester offers a human five options; a
+// Discord message has no human in the loop, so this collapses to a single
+// confident answer and declines whenever "confident" is not available.
+// =========================================================================
+
+const fakeDb = ({ versions = [], goals = [], throws = null, calls = null } = {}) => ({
+  listVersions: async () => { if (throws === 'versions') throw new Error('boom'); return versions; },
+  listGoals: async (args) => {
+    if (calls) calls.push(args);
+    if (throws === 'goals') throw new Error('boom');
+    return goals;
+  },
+});
+
+const BUILDING = { id: 'BONGOS-V1', status: 'building' };
+const SHIPPED = { id: 'GDS-V3', status: 'shipped' };
+const HALL_GOAL = { id: 81, title: 'Builders hall in the world', scope_modules: ['hall-ui'], version_id: 'BONGOS-V1' };
+const ECON_GOAL = { id: 78, title: 'Project money out', scope_modules: ['economy'], version_id: 'BONGOS-V1' };
+
+await test('suggestGoalForCapture: the one building version, and the goal the words match', async () => {
+  const got = await suggestGoalForCapture(
+    { title: 'the hall sidebar collapses on mobile', body: '' },
+    { db: fakeDb({ versions: [BUILDING, SHIPPED], goals: [ECON_GOAL, HALL_GOAL] }) }
+  );
+  assert.equal(got.id, 81, 'the hall goal, not the economy one');
+  assert.equal(got.version_id, 'BONGOS-V1', 'and the version comes from the version row, never a hardcode');
+  assert.ok(got.score > 0);
+});
+
+await test('suggestGoalForCapture: a SHIPPED version is never the home (idea 1000771)', async () => {
+  const got = await suggestGoalForCapture(
+    { title: 'the hall sidebar collapses', body: '' },
+    { db: fakeDb({ versions: [SHIPPED], goals: [HALL_GOAL] }) }
+  );
+  assert.equal(got, null, 'nothing is open to work, so there is no home — the filing goes to the inbox');
+});
+
+// This instance runs BONGOS-V1 and CB-V1 concurrently. An earlier cut declined
+// whenever more than one version was open, which would have returned null for
+// every report ever filed — a dead feature that looked like prudence. The goal
+// carries the version, so rank across all of them and let the winner say.
+await test('suggestGoalForCapture: TWO open versions ⇒ rank across BOTH, winner names its version', async () => {
+  const CB_GOAL = { id: 99, title: 'The front door', scope_modules: ['public-landing'], version_id: 'CB-V1' };
+  const got = await suggestGoalForCapture(
+    { title: 'the front door hero is broken', body: '' },
+    { db: fakeDb({ versions: [BUILDING, { id: 'CB-V1', status: 'building' }], goals: [HALL_GOAL, CB_GOAL] }) }
+  );
+  assert.equal(got.id, 99, 'the goal on the OTHER open version can win');
+  assert.equal(got.version_id, 'CB-V1', 'and it reports its own version, not the first one open');
+});
+
+await test('suggestGoalForCapture: a goal on a CLOSED version is never a home, even if it matches best', async () => {
+  const DEAD_GOAL = { id: 12, title: 'the hall sidebar and hall chrome', scope_modules: ['hall-ui'], version_id: 'GDS-V3' };
+  const got = await suggestGoalForCapture(
+    { title: 'the hall sidebar collapses', body: '' },
+    { db: fakeDb({ versions: [BUILDING, SHIPPED], goals: [DEAD_GOAL, ECON_GOAL] }) }
+  );
+  assert.equal(got, null, 'the better-matching goal sits on a shipped version — idea 1000771 exactly');
+});
+
+await test('suggestGoalForCapture: asks for open goals across ALL versions, not one', async () => {
+  const calls = [];
+  await suggestGoalForCapture(
+    { title: 'the hall sidebar collapses', body: '' },
+    { db: fakeDb({ versions: [BUILDING], goals: [HALL_GOAL], calls }) }
+  );
+  assert.equal(calls.length, 1, 'one query, not one per version');
+  assert.equal(calls[0].status, 'open');
+  assert.equal(calls[0].versionId, undefined, 'unscoped — the open-version filter is applied in JS');
+});
+
+await test('suggestGoalForCapture: no confident match ⇒ null, not the first goal dressed up', async () => {
+  const got = await suggestGoalForCapture(
+    { title: 'zzzz qqqq nothing matches this', body: '' },
+    { db: fakeDb({ versions: [BUILDING], goals: [HALL_GOAL, ECON_GOAL] }) }
+  );
+  assert.equal(got, null);
+});
+
+await test('suggestGoalForCapture: empty draft ⇒ null without touching the db', async () => {
+  let touched = false;
+  const db = { listVersions: async () => { touched = true; return [BUILDING]; }, listGoals: async () => [] };
+  assert.equal(await suggestGoalForCapture({ title: '   ', body: '' }, { db }), null);
+  assert.equal(touched, false, 'nothing to rank against ⇒ no query');
+});
+
+await test('suggestGoalForCapture: a db failure SHRUGS — it never throws at a bug report', async () => {
+  for (const throws of ['versions', 'goals']) {
+    const got = await suggestGoalForCapture(
+      { title: 'the hall sidebar collapses', body: '' },
+      { db: fakeDb({ versions: [BUILDING], goals: [HALL_GOAL], throws }) }
+    );
+    assert.equal(got, null, `a ${throws} failure degrades to "no home", never to a lost report`);
+  }
+});
+
+await test('suggestGoalForCapture: the catch-all is never offered as a home', async () => {
+  const got = await suggestGoalForCapture(
+    { title: 'general problem in BONGOS', body: '' },
+    { db: fakeDb({ versions: [BUILDING], goals: [{ id: 3, title: 'BONGOS-V1 — general', scope_modules: [], version_id: 'BONGOS-V1' }] }) }
+  );
+  assert.equal(got, null, 'a bucket is not a workspace — dropped for EVERY open version, not just one');
+});
+
 summary();