@bongos/core 1.19.451 → 1.19.452

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.451",
-  "core_contract": "1.19.451",
-  "source_commit": "f2d301bff1deca7496735a9b24aed2ced913a54a",
+  "core_version": "1.19.452",
+  "core_contract": "1.19.452",
+  "source_commit": "a59941e00bdc972cede45d82263d6bb9a334d59d",
   "source_ref": "HEAD",
-  "built_at": "2026-09-01T19:29:54.090Z",
+  "built_at": "2026-09-01T19:56:39.788Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 371,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2183,
-  "tree_sha256": "e1ab49577ffad8bf559f652561719a2590467717b87c215918689cc2e740a31e",
+  "tree_sha256": "d6e755d26822b3fbb320367835d28cb2e6e317309a6da4985730541e202fec63",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2092,7 +2092,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "ff76a324ccf245e1fd66a1aa9524c488fa4f54929e070c7b7d048b04521cbf0d"
+      "sha256": "1b44d9a28067aee44f6461a6ec2ff31dcbcd1d92aba9b5e5d53ac97dcb782cbe"
     },
     {
       "path": "docs/modules-contract.md",
@@ -4647,7 +4647,7 @@
     {
       "path": "modules/lifecycle/db-tasks.js",
       "mode": "0000644",
-      "sha256": "745663b0a264ae742702919fc9486f49723010dd797e1fe7151de5d65b98bf21"
+      "sha256": "cf646edc2f71e39aee26cb5648cc25915b5688c7d6356345c0365ada37fdb400"
     },
     {
       "path": "modules/lifecycle/db-versions.js",
@@ -6302,12 +6302,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "288c4f929ae1ec0e24e6ffbb9a911683acf04b6fe8f5e324df3c5c42c1086043"
+      "sha256": "a24646cf791a4ef41bf5fbca236cf24a27c9d05ba0f4419483054f38b849688e"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "dc7522ac5de90eec2d4764a2268601149b1215b3ad3d989326243cca2aab67ea"
+      "sha256": "76ba0c0adc1241f0051796e43d8519486163d142b23a57704d60aabd56806cb6"
     },
     {
       "path": "public-docs/index.html",
@@ -7957,7 +7957,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "c9498ea93c030472ed6d09afe79001e23d0fe2c3045f7b5d51b660d0237bcdb8"
+      "sha256": "4b7bee96fc2dfb083dcc43f811b46f135c4103cf719e68546ee2b898569cfc65"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -8977,7 +8977,7 @@
     {
       "path": "tests/goal_advisory.mjs",
       "mode": "0000644",
-      "sha256": "7488d41a0d962f681f9482e4c06f518f38be824e8fa936b5bd7b1c1b70838c3d"
+      "sha256": "1b1c403574132def4c4beb98595987e90b720a851f29e42f643f1f00f285da5c"
     },
     {
       "path": "tests/goal_category.mjs",
@@ -10747,7 +10747,7 @@
     {
       "path": "tests/task_goal_link.mjs",
       "mode": "0000644",
-      "sha256": "d4f417d485cde211b7664c017f1909eb31bd86539cfc0128a08bf2b474023b80"
+      "sha256": "514be815c0466e4e2865ad85cb7a2ca206e5b46abc7b345da2c36278667c8bb2"
     },
     {
       "path": "tests/task_lib.mjs",

package/docs/module-api-changelog.md

@@ -1339,5 +1339,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.449 with no explicit bump. run 33414986466. (task 1002620)
   1.19.451 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.450 with no explicit bump. run 33549781105. (task 1002620)
+  1.19.452 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.451 with no explicit bump. run 33552353620. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/lifecycle/db-tasks.js

@@ -23,6 +23,20 @@ const { deriveRequiredRank, highestRank } = require('./db-rank-authz.js');
 // -------------------------------------------------------------------------
 
 
+// The version statuses that can still receive new work. 'shipped' and 'frozen' are
+// closed: a version whose scope is sealed cannot be told about a bug found afterwards.
+// Mirrors the CHECK constraint on versions.status (migrations/003_pms.sql).
+const VERSION_STATUSES_OPEN_TO_WORK = new Set(['planning', 'building']);
+
+// versionAcceptsNewWork — PURE, FAIL-CLOSED. Is this version still a place work can
+// land? Exported so the truth table is pinned by a DB-free unit test, and so a caller
+// that needs the same judgement asks this instead of respelling the status list.
+// Anything unrecognised (null, a typo, a status added later) reads false: filing into
+// a version we cannot vouch for is the failure this predicate exists to prevent.
+function versionAcceptsNewWork(status) {
+  return typeof status === 'string' && VERSION_STATUSES_OPEN_TO_WORK.has(status);
+}
+
 // task 1763: resolve a version's catch-all "<version> — general" goal (created by
 // migration 160, created_by NULL). This is the fallback goal a goal-less task
 // defaults into (see createTask) so the "every task belongs to a goal" invariant
@@ -32,14 +46,39 @@ const { deriveRequiredRank, highestRank } = require('./db-rank-authz.js');
 // unit-testable DB-free. The title mirrors migration 160's insert exactly (a spaced
 // em-dash); it is built by ../goal-advisory.generalGoalTitle so this SQL and the
 // advisory that detects the same goal can never disagree (task 1002539).
+//
+// task 1003061 (BV1.R03): it also refuses a CLOSED version's catch-all. That is the
+// 1000771 failure shape — Discord #bugs hardcoded GDS-V3, a shipped version, so every
+// bug reported through it resolved into "GDS-V3 — general" and was filed somewhere
+// nobody would ever look again. routeIdeaToGoal (BV1.R01) already refuses an EXPLICIT
+// goal on a closed version; this closes the IMPLICIT door that every other create
+// vector walks through. Returning null is deliberately NOT an error: the create still
+// succeeds with goal_id NULL, and the orphan advisory then says so out loud — a task
+// visibly without a home beats one quietly entombed.
+//
+// The status is judged in JS rather than the WHERE clause so the rule is one exported,
+// unit-tested predicate instead of a string list duplicated into SQL. The JOIN is inner
+// on purpose: a goal whose version row is missing is not a home either.
 async function generalGoalIdForVersion(versionId, deps = {}) {
   if (versionId == null) return null;
   const activePool = (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : pool;
   const { rows } = await activePool.query(
-    'SELECT id FROM goals WHERE version_id = $1 AND title = $2 LIMIT 1',
+    `SELECT g.id, v.status AS version_status
+       FROM goals g
+       JOIN versions v ON v.id = g.version_id
+      WHERE g.version_id = $1 AND g.title = $2
+      LIMIT 1`,
     [versionId, generalGoalTitle(versionId)]
   );
-  return rows[0] ? rows[0].id : null;
+  if (!rows[0]) return null;
+  if (!versionAcceptsNewWork(rows[0].version_status)) {
+    log.debug(
+      { versionId, versionStatus: rows[0].version_status ?? null, goalId: rows[0].id },
+      'catch-all goal refused: version is closed to new work (task 1003061)'
+    );
+    return null;
+  }
+  return rows[0].id;
 }
 
 async function createTask({
@@ -870,4 +909,5 @@ module.exports = {
   updateTaskRequiresRank,
   updateTaskSecuritySensitive,
   updateTaskStatus,
+  versionAcceptsNewWork,
 };

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.451",
+  "version": "1.19.452",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.451",
+      "version": "1.19.452",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.451",
+  "version": "1.19.452",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -33,7 +33,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.451'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.452'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/goal_advisory.mjs

@@ -108,7 +108,7 @@ await test('candidateGoals is total — non-array, empty, and missing scope_modu
 
 await test('db.js resolves the catch-all through generalGoalTitle — no second spelling', () => {
   assert.match(dbSrc, /require\('\.\/goal-advisory\.js'\)/, 'db.js imports the shared helper');
-  assert.match(dbSrc, /title = \$2 LIMIT 1/, 'the SQL binds the title rather than inlining it');
+  assert.match(dbSrc, /g\.title = \$2/, 'the SQL binds the title rather than inlining it');
   assert.equal(
     (dbSrc.match(/' — general'/g) || []).length, 0,
     'the em-dash literal must exist in exactly ONE place (goal-advisory.js), not in db.js too'

package/tests/task_goal_link.mjs

@@ -12,6 +12,8 @@
 //       - null versionId → null and NO SQL (nothing to resolve).
 //       - a version id → exactly one SELECT keyed on (version_id, the spaced
 //         em-dash title match), bound param [versionId], returning the id or null.
+//       - a CLOSED version (shipped/frozen) → null even when the goal exists, so
+//         the create lands goal-less rather than in a tomb (task 1003061).
 //
 //   routes/tasks.js — the router still BUILDS after the PATCH /tasks/:id goal_id
 //     extension (imports resolve; the factory returns a router). The SQL + the
@@ -29,6 +31,10 @@ process.env.NODE_ENV = 'test';
 const require = createRequire(import.meta.url);
 const db = require('../modules/lifecycle/db.js');
 const { generalGoalIdForVersion } = db;
+// versionAcceptsNewWork is INTERNAL to the tasks slice (task 1003061): db.js is the
+// facade for the call sites, and re-exporting a predicate nothing outside this file
+// calls would only widen the facade. Required from where it lives instead.
+const { versionAcceptsNewWork } = require('../modules/lifecycle/db-tasks.js');
 const buildTasksRouter = require('../modules/lifecycle/routes/tasks.js');
 
 const { test, summary } = makeRunner();
@@ -55,17 +61,21 @@ await test('null / undefined versionId → null, and NO SQL is issued', async ()
   }
 });
 
-await test('a version with a general goal → returns its id via one SELECT on the em-dash title', async () => {
-  const pool = fakePool([{ id: 3 }]);
+await test('a BUILDING version with a general goal → returns its id via one SELECT on the em-dash title', async () => {
+  const pool = fakePool([{ id: 3, version_status: 'building' }]);
   const out = await generalGoalIdForVersion('BONGOS-V1', { pool });
 
   assert.equal(out, 3, 'returns the general goal id');
   assert.equal(pool.queries.length, 1, 'exactly one SELECT');
   const q = pool.queries[0];
+  // task 1003061 (BV1.R03): the lookup now JOINs versions and brings the version
+  // status back, so the resolver can refuse a closed version's catch-all.
+  assert.match(q.sql, /JOIN versions/, 'the lookup reaches the version, not just the goal');
+  assert.match(q.sql, /AS version_status/, 'and carries its status back to be judged');
   // task 1002539: the title is no longer inlined in SQL — it is BOUND, built by the
   // shared goal-advisory.generalGoalTitle so this lookup and the orphan advisory that
   // names the same goal cannot drift apart.
-  assert.match(q.sql, /SELECT id FROM goals WHERE version_id = \$1 AND title = \$2/,
+  assert.match(q.sql, /WHERE g\.version_id = \$1 AND g\.title = \$2/,
     'keyed on version_id + a BOUND title (one definition, in goal-advisory.js)');
   assert.match(q.sql, /LIMIT 1/, 'single row');
   assert.deepEqual(q.params, ['BONGOS-V1', 'BONGOS-V1 — general'],
@@ -81,7 +91,7 @@ await test('a version with no general goal → null (caller leaves goal_id NULL,
 });
 
 await test('the em-dash in the title match is U+2014 (not a hyphen/en-dash) — or the backfill silently matches nothing', async () => {
-  const pool = fakePool([{ id: 9 }]);
+  const pool = fakePool([{ id: 9, version_status: 'building' }]);
   await generalGoalIdForVersion('V2', { pool });
   // The em-dash moved from the SQL text into the BOUND param (task 1002539); assert
   // it there, which is stricter — the exact string Postgres compares.
@@ -92,6 +102,54 @@ await test('the em-dash in the title match is U+2014 (not a hyphen/en-dash) —
   assert.ok(!title.includes(' – general'), 'not an en dash');
 });
 
+// =========================================================================
+// task 1003061 (BV1.R03) — the catch-all must never be a TOMB.
+//
+// The 1000771 failure: Discord #bugs hardcoded GDS-V3, a SHIPPED version, so every
+// reported bug resolved into "GDS-V3 — general" and was filed where nobody would look
+// again. routeIdeaToGoal (BV1.R01) already refuses an EXPLICIT goal on a closed
+// version; this closes the IMPLICIT door — the goal-less fallback that every other
+// create vector (POST /tasks, capture, newcomer-restock, seeds) walks through.
+//
+// A closed version's catch-all resolves to null, so createTask leaves goal_id NULL and
+// the orphan advisory (goal-advisory.js) speaks up. Loud silence beats a quiet tomb.
+
+await test('versionAcceptsNewWork: only a version still open for work can receive it', () => {
+  assert.equal(versionAcceptsNewWork('building'), true, 'building — the live case');
+  assert.equal(versionAcceptsNewWork('planning'), true, 'planning — a legitimate future home');
+  assert.equal(versionAcceptsNewWork('shipped'), false, 'shipped — the 1000771 tomb');
+  assert.equal(versionAcceptsNewWork('frozen'), false, 'frozen — closed to new work');
+});
+
+await test('versionAcceptsNewWork fails CLOSED on anything it does not recognise', () => {
+  for (const v of [null, undefined, '', 'BUILDING', 'archived', 42, {}]) {
+    assert.equal(versionAcceptsNewWork(v), false, `refuses ${JSON.stringify(v)}`);
+  }
+});
+
+await test("a SHIPPED version's catch-all does not resolve — the create lands goal-less, not in a tomb", async () => {
+  const pool = fakePool([{ id: 3, version_status: 'shipped' }]);
+  const out = await generalGoalIdForVersion('GDS-V3', { pool });
+  assert.equal(out, null, 'the goal EXISTS and is still refused — that is the whole point');
+  assert.equal(pool.queries.length, 1, 'it did look — it just declined what it found');
+});
+
+await test("a FROZEN version's catch-all does not resolve either", async () => {
+  const pool = fakePool([{ id: 4, version_status: 'frozen' }]);
+  assert.equal(await generalGoalIdForVersion('OLD-V1', { pool }), null);
+});
+
+await test("a PLANNING version's catch-all still resolves (a future home is a real home)", async () => {
+  const pool = fakePool([{ id: 5, version_status: 'planning' }]);
+  assert.equal(await generalGoalIdForVersion('NEXT-V1', { pool }), 5);
+});
+
+await test('a row with no readable version status resolves to null (fail closed)', async () => {
+  const pool = fakePool([{ id: 6 }]);
+  assert.equal(await generalGoalIdForVersion('MYSTERY-V1', { pool }), null,
+    'an unjoinable or absent version is not a home');
+});
+
 // -------------------------------------------------------------------------
 await test('routes/tasks.js still builds after the goal_id PATCH extension', () => {
   assert.equal(typeof buildTasksRouter, 'function', 'module exports the router factory');