@bongos/core 1.19.426 → 1.19.428

package/tests/profile_privacy_owner_view.mjs

@@ -76,23 +76,28 @@ const GHOST = '5150';  // active · PRIVATE         — the owner-renders subjec
 const SHY = '6060';    // active · public · HIDDEN — the no-partial-numbers subject
 const NOSY = '7777';   // active · public          — the stranger at the side door
 
+// ADR 0213 (task 1002913): consent is profile_state AND an acceptance of the
+// platform terms, both written by the same statement — so a consented fixture
+// carries both, and one carrying only the first is a row from before the terms.
+const ACCEPTED_AT = '2026-08-29T00:00:00.000Z';
+
 const ACCOUNTS = [
   { id: 1, github_id: OCTO, github_login: 'octo', display_name: 'Octo', avatar_url: null,
     handle: 'octo', previous_handle: null, handle_changed_at: null, bio: null, links: null,
     display_name_source: 'github', created_at: 'T0', updated_at: 'T0',
-    profile_state: 'active', account_visibility: 'public', hide_stats: false, recruiter_discoverable: null },
+    profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'public', hide_stats: false, recruiter_discoverable: null },
   { id: 2, github_id: GHOST, github_login: 'ghost', display_name: 'Ghost', avatar_url: null,
     handle: 'ghost', previous_handle: null, handle_changed_at: null, bio: 'ghost-bio-515007', links: null,
     display_name_source: 'github', created_at: 'T0', updated_at: 'T0',
-    profile_state: 'active', account_visibility: 'private', hide_stats: false, recruiter_discoverable: null },
+    profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'private', hide_stats: false, recruiter_discoverable: null },
   { id: 3, github_id: SHY, github_login: 'shy', display_name: 'Shy', avatar_url: null,
     handle: 'shy', previous_handle: null, handle_changed_at: null, bio: null, links: null,
     display_name_source: 'github', created_at: 'T0', updated_at: 'T0',
-    profile_state: 'active', account_visibility: 'public', hide_stats: true, recruiter_discoverable: null },
+    profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'public', hide_stats: true, recruiter_discoverable: null },
   { id: 4, github_id: NOSY, github_login: 'nosy', display_name: 'Nosy', avatar_url: null,
     handle: 'nosy', previous_handle: null, handle_changed_at: null, bio: null, links: null,
     display_name_source: 'github', created_at: 'T0', updated_at: 'T0',
-    profile_state: 'active', account_visibility: 'public', hide_stats: false, recruiter_discoverable: null },
+    profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'public', hide_stats: false, recruiter_discoverable: null },
 ];
 
 // Every number and name the cross-project rollup can produce, per account.
@@ -135,6 +140,10 @@ function sentinelsOf(githubId) {
 // anything else throws — a WHERE it cannot read must never degrade to no WHERE.
 const KNOWN_COLUMNS = new Set(['profile_state', 'account_visibility', 'hide_stats', 'github_id', 'handle', 'previous_handle']);
 
+// Columns this interpreter can answer an IS [NOT] NULL test on — a different
+// syntax from the literal comparisons above, hence its own set (ADR 0213).
+const KNOWN_NULL_TESTS = new Set(['terms_accepted_at']);
+
 /**
  * Build a row test from a statement's own WHERE text. Literal comparisons carry
  * as much weight as placeholders here: the effective-visibility predicate is
@@ -144,8 +153,18 @@ const KNOWN_COLUMNS = new Set(['profile_state', 'account_visibility', 'hide_stat
 function accountFilter(where, params) {
   const tests = [];
   const consumed = new Set();
+  // NULL-test terms actually turned into a filter, as opposed to column names
+  // merely recognised. The final sweep compares the two (ADR 0213).
+  const modelled = new Set();
 
   if (/\bprofile_state = 'active'/.test(where)) tests.push((r) => r.profile_state === 'active');
+  // The ADR 0213 consent half. It is a NULL test, not a literal comparison, so
+  // neither sweep below would see it — an unmodelled IS NOT NULL degrades to no
+  // filter exactly like an unread $N, which is what those sweeps exist to refuse.
+  if (/\bterms_accepted_at IS NOT NULL/.test(where)) {
+    modelled.add('terms_accepted_at');
+    tests.push((r) => r.terms_accepted_at != null);
+  }
   if (/\baccount_visibility = 'public'/.test(where)) tests.push((r) => r.account_visibility === 'public');
   if (/\bNOT (?:[a-z_]+\.)?hide_stats\b/.test(where)) tests.push((r) => !r.hide_stats);
 
@@ -173,6 +192,14 @@ function accountFilter(where, params) {
       throw new Error(`fake pool: unrecognised literal comparison on ${m[1]} in "${where}"`);
     }
   }
+  for (const m of where.matchAll(/\b([a-z_]+)\s+IS\s+(?:NOT\s+)?NULL\b/gi)) {
+    if (!KNOWN_NULL_TESTS.has(m[1])) {
+      throw new Error(`fake pool: unrecognised NULL test on ${m[1]} in "${where}"`);
+    }
+    if (!modelled.has(m[1])) {
+      throw new Error(`fake pool: NULL test on ${m[1]} in "${where}" was recognised but never MODELLED — the clause is present and this interpreter is ignoring it`);
+    }
+  }
   return (r) => tests.every((fn) => fn(r));
 }
 

package/tests/profile_route.mjs

@@ -354,25 +354,28 @@ const PROOF_PROJECTS = [
 const sumOf = (k) => PROOF_PROJECTS.reduce((n, p) => n + p[k], 0);
 
 // The one account row the reads consult. setAccountHideStats mutates it.
-const hubAccount = { profile_state: 'active', account_visibility: 'public', hide_stats: false, handle: 'r06-handle' };
+// ADR 0213 (task 1002913): consent is profile_state AND an acceptance of the
+// platform terms, both stamped by the same upsertAccount branch.
+const ACCEPTED_AT = '2026-08-29T00:00:00.000Z';
+const hubAccount = { profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'public', hide_stats: false, handle: 'r06-handle' };
 
 // The scouting "table": one visible builder plus the THREE that consent and
 // visibility exclude (the private row joined at task 1002967 — the same axis,
 // enforced by the same shared predicate).
 const SCOUTING_TABLE = [
-  { profile_state: 'active', account_visibility: 'public', hide_stats: false,
+  { profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'public', hide_stats: false,
     row: { github_id: '11', github_login: 'r06-visible', display_name: 'Visible', avatar_url: null,
       project_count: 2, total_credits: 5, total_tasks_shipped: 1, total_karma: 0,
       last_active: '2026-08-01T00:00:00.000Z', disciplines: ['engineer'] } },
-  { profile_state: 'active', account_visibility: 'public', hide_stats: true,
+  { profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'public', hide_stats: true,
     row: { github_id: '12', github_login: HIDDEN_LOGIN, display_name: 'Hidden', avatar_url: null,
       project_count: 7, total_credits: 88817, total_tasks_shipped: 6613, total_karma: 5519,
       last_active: '2026-08-02T00:00:00.000Z', disciplines: ['ui'] } },
-  { profile_state: 'provisional', account_visibility: 'public', hide_stats: false,
+  { profile_state: 'provisional', terms_accepted_at: null, account_visibility: 'public', hide_stats: false,
     row: { github_id: '13', github_login: PROV_LOGIN, display_name: 'Provisional', avatar_url: null,
       project_count: 1, total_credits: 71713, total_tasks_shipped: 1, total_karma: 0,
       last_active: '2026-08-03T00:00:00.000Z', disciplines: [] } },
-  { profile_state: 'active', account_visibility: 'private', hide_stats: false,
+  { profile_state: 'active', terms_accepted_at: ACCEPTED_AT, account_visibility: 'private', hide_stats: false,
     row: { github_id: '14', github_login: PRIVATE_LOGIN, display_name: 'Private', avatar_url: null,
       project_count: 3, total_credits: 63127, total_tasks_shipped: 4409, total_karma: 2287,
       last_active: '2026-08-04T00:00:00.000Z', disciplines: ['engineer'] } },
@@ -389,6 +392,7 @@ const engine = {
     if (/AS project_count/.test(sql)) {
       let rows = SCOUTING_TABLE;
       if (/pa\.profile_state = 'active'/.test(sql)) rows = rows.filter((r) => r.profile_state === 'active');
+      if (/pa\.terms_accepted_at IS NOT NULL/.test(sql)) rows = rows.filter((r) => r.terms_accepted_at != null);
       if (/pa\.account_visibility = 'public'/.test(sql)) rows = rows.filter((r) => r.account_visibility === 'public');
       if (/NOT pa\.hide_stats/.test(sql)) rows = rows.filter((r) => !r.hide_stats);
       return { rows: rows.map((r) => ({ ...r.row })) };
@@ -398,10 +402,13 @@ const engine = {
       hubAccount.hide_stats = !!params[4];
       return { rows: [{ github_id: String(HUB_GITHUB_ID), github_login: 'jaxri', ...hubAccount }] };
     }
-    // getPublicProfileExtras' consent read — three columns since task 1002967
-    // wired the existence axis in (the shared rollupIsVisible port reads them).
-    if (/SELECT profile_state, account_visibility, hide_stats/.test(sql)) {
+    // getPublicProfileExtras' consent read. Matched on the columns it must
+    // carry rather than on the exact SELECT list: pinning the full list meant
+    // that adding terms_accepted_at (ADR 0213) silently unhooked this branch and
+    // the read fell through to the wrong answer with every other test green.
+    if (/SELECT profile_state,.*hide_stats/.test(sql) && /FROM platform_identity_accounts/.test(sql)) {
       return { rows: [{ profile_state: hubAccount.profile_state,
+        terms_accepted_at: hubAccount.terms_accepted_at,
         account_visibility: hubAccount.account_visibility, hide_stats: hubAccount.hide_stats }] };
     }
     // getRollupForBuilder's per-project rows (the client_id → origin two-hop).