@bongos/core 1.19.419 → 1.19.420

package/tests/projects_hub.mjs

@@ -613,6 +613,75 @@ test('every table column has a source — Type is declared, never guessed', () =
   assert.match(SCRIPT, /type: state\.projType/, 'the create request carries the declared type');
 });
 
+test('every per-step hook in show() still points at the panel it belongs to (renumbering guard)', () => {
+  // The renumbering risk is NOT the data-next attributes (guarded above) — it is
+  // show()'s side-effect hooks, which key off bare integers. Point one at the
+  // wrong panel and the wizard still navigates perfectly while silently never
+  // probing repo access, never re-checking the handle, or rendering a stale
+  // review. Derived from the panels map so this survives the next renumbering.
+  const map = SCRIPT.match(/var panels = \{([^}]*)\}/)[1];
+  const STEP = {};
+  for (const m of map.matchAll(/(\d+):\s*'([a-z-]+)'/g)) STEP[m[2]] = Number(m[1]);
+  const show = SCRIPT.slice(SCRIPT.indexOf('function show(step, moveFocus)'));
+  const body = show.slice(0, show.search(/\n\s*\/\* One delegated pair on the rail/));
+
+  assert.ok(body.includes(`if (step === ${STEP['panel-home']}) { syncHome();`),
+    'the repo probe fires on the Home panel');
+  assert.ok(body.includes(`if (step === ${STEP['panel-address']}) { checkSlugAvailable(); renderAddrPanel(); }`),
+    'the handle re-check fires on the Address panel');
+  assert.ok(body.includes(`if (step === ${STEP['panel-review']}) renderReview();`),
+    'the review is rendered on the Review panel');
+  assert.ok(body.includes(`'wizDone', step === ${STEP['panel-done']}`),
+    'the done panel is the one that takes the whole card');
+  // and the About panel claims no hook of its own — it has nothing to fetch
+  assert.ok(!body.includes(`if (step === ${STEP['panel-detail']})`),
+    'the optional step needs no side effect; adding one would give it a way to fail');
+});
+
+test('the About step is OFFERED by every form and can be walked past — the skip is a real control (task 1002334)', () => {
+  const about = (HUB.match(/<section class="panel" id="panel-detail"[\s\S]*?<\/section>/) || [''])[0];
+  assert.ok(about, '#panel-detail ships as real markup');
+  assert.match(about, /id="f-desc"/, 'it asks what the owner is building — the publish gate half');
+  assert.match(about, /id="teamCards"/, 'and who is building it — what the recommendations read');
+  // the skip must be its OWN button: "leave it blank and press Next" is an
+  // escape hatch the visitor has to infer, which is not an optional step
+  assert.match(about, /id="skipDetail"/, 'the skip is a control, not an inference');
+  assert.match(about, /Optional/, 'and the panel says so before it asks');
+  // the consequence of skipping is stated where the choice is made
+  assert.match(SCRIPT, /stays off the public map until it has one/,
+    'skipping names its cost (ADR 0182 D4), never leaves it to be discovered later');
+  // nothing in validateStep may gate the About step
+  const validate = SCRIPT.slice(SCRIPT.indexOf('function validateStep('));
+  const map = SCRIPT.match(/var panels = \{([^}]*)\}/)[1];
+  const aboutStep = Number((map.match(/(\d+):\s*'panel-detail'/) || [, 0])[1]);
+  assert.ok(aboutStep > 0, 'the About panel is in the map');
+  assert.ok(!validate.slice(0, validate.indexOf('function ', 1)).includes(`if (step === ${aboutStep}) {`),
+    'the optional step has no validation clause — Next past an empty answer is the point');
+});
+
+test('the About answers travel on the create request, and an empty one is OMITTED not blanked', () => {
+  assert.match(SCRIPT, /description: String\(state\.description \|\| ''\)\.trim\(\) \|\| undefined/,
+    'a skipped description is absent from the body — an empty string would read as answered');
+  assert.match(SCRIPT, /detail: state\.teamShape \? \{ team_shape: state\.teamShape \} : undefined/,
+    'and an unanswered team shape is never guessed into the request');
+  // the review is the last screen before Create, so the skip's cost is restated there
+  const review = (SCRIPT.match(/function renderReview\(\)\s*\{([\s\S]*?)\n    \}/) || [, ''])[1];
+  assert.match(review, /off the public map until you add it/,
+    'the review row states the consequence rather than a bare dash');
+  assert.match(review, /\['About',/, 'and the About answer has a row of its own');
+});
+
+test('a renumbering of the wizard invalidates old drafts — the key carries the version', () => {
+  // task 1002772 renumbered once and bumped to -v2; task 1002334 renumbered again.
+  // A draft replayed under a different numbering lands on the wrong panel with the
+  // rail already marking the skipped steps done.
+  const key = (SCRIPT.match(/var DRAFT_KEY = '([^']+)'/) || [, ''])[1];
+  assert.match(key, /-v\d+$/, 'the draft key is versioned');
+  const panels = (SCRIPT.match(/var panels = \{([^}]*)\}/) || [, ''])[1];
+  const count = [...panels.matchAll(/\d+:\s*'panel-/g)].length;
+  assert.equal(count, 8, 'gate + six numbered steps + done — bump DRAFT_KEY when this changes');
+});
+
 test('header and body agree on the column count', () => {
   // a stray <td> shifts every cell after it — silent, and only visible on screen
   const n = ((HUB.match(/<thead>([\s\S]*?)<\/thead>/) || [, ''])[1].match(/<th/g) || []).length;

package/tests/projects_hub_pre_uat.mjs

@@ -28,6 +28,20 @@ const fn = (name) => {
   return next < 0 ? rest : rest.slice(0, next);
 };
 
+// The step indices are DERIVED from the panels map, not typed (task 1002334
+// renumbered them a second time and every literal below broke). What these
+// blocks actually claim is "the DONE panel" and "the step before it" — say
+// that, and the next renumbering costs nothing.
+const PANELS = (() => {
+  const m = SCRIPT.match(/var panels = \{([^}]*)\}/);
+  assert.ok(m, 'the panels map must exist');
+  const map = {};
+  for (const p of m[1].matchAll(/(\d+):\s*'([a-z-]+)'/g)) map[Number(p[1])] = p[2];
+  return map;
+})();
+const STEP = Object.fromEntries(Object.entries(PANELS).map(([n, id]) => [id, Number(n)]));
+const DONE = STEP['panel-done'];
+
 /* ── the gate says why GitHub will ask for repository access ── */
 test('the gate explains the repo scope BEFORE GitHub does — on the path every founder takes', () => {
   const gate = (HUB.match(/<section class="panel" id="panel-gate"[\s\S]*?<\/section>/) || [''])[0];
@@ -203,7 +217,9 @@ test('the wizard’s 401 recoveries keep the repo scope they already granted', (
 });
 
 test('a resumed draft past Home still probes repo access before Create', () => {
-  assert.match(SCRIPT, /else if \(step > 3 && step < 6 && authKnown && repoAccess === null\) ensureRepoAccess\(\);/);
+  assert.ok(SCRIPT.includes(
+    `else if (step > ${STEP['panel-home']} && step < ${DONE} && authKnown && repoAccess === null) ensureRepoAccess();`),
+    'every step between Home and the done panel re-probes');
 });
 
 test('a half-typed custom domain says why Next is dead; a taken handle silences the format cheer', () => {
@@ -447,13 +463,16 @@ test('a manifest error says a plain sentence, folds the route text, and sends a
 
 test('the rail at the done panel keeps its marker on Create until the project answers', () => {
   const rail = fn('paintRail');
-  assert.match(rail, /var landed = step === 6 && !!\(live && live\.instStatus === 'active'\);/);
-  assert.match(rail, /var cur = step === 6 \? 5 : step;/);
+  assert.ok(rail.includes(`var landed = step === ${DONE} && !!(live && live.instStatus === 'active');`),
+    'the rail only finishes on the done panel');
+  assert.ok(rail.includes(`var cur = step === ${DONE} ? ${DONE - 1} : step;`),
+    'the done panel keeps the marker on the last numbered beat');
   assert.match(rail, /li\.classList\.toggle\('done', landed \|\| n < cur\);/);
   assert.match(rail, /if \(now\) li\.setAttribute\('aria-current', 'step'\); else li\.removeAttribute\('aria-current'\);/);
   assert.match(fn('show'), /paintRail\(step\);/, 'show() paints through it');
   assert.doesNotMatch(fn('show'), /classList\.toggle\('done'/, 'and no longer marks the rail on its own');
-  assert.match(SCRIPT, /live\.instStatus = inst\.status; renderSteps\(\);\n\s*if \(state\.step === 6\) paintRail\(6\);/, 'the done-panel poll repaints when the status moves');
+  assert.ok(SCRIPT.includes(`if (state.step === ${DONE}) paintRail(${DONE});`),
+    'the done-panel poll repaints when the status moves');
   assert.match(HUB, /<li class="now" data-step="1" aria-current="step">/, 'the static rail starts with the same marker');
 });
 
@@ -560,7 +579,10 @@ test('the hub has one main landmark, a heading for the map, a footer, and a skip
 });
 
 test('completed rail steps are a way back, the repo picker is honest ARIA, the card inerts the page', () => {
-  assert.match(fn('paintRail'), /if \(step < 6 && n < cur\) \{\n\s*li\.setAttribute\('role', 'button'\);\n\s*li\.setAttribute\('tabindex', '0'\);\n\s*li\.setAttribute\('data-goto', String\(n\)\);/, 'only answered steps become buttons, and none once the project is filed');
+  assert.ok(fn('paintRail').includes(`if (step < ${DONE} && n < cur) {`),
+    'only answered steps become buttons, and none once the project is filed');
+  assert.ok(fn('paintRail').includes("li.setAttribute('data-goto', String(n));"),
+    'and an answered step carries the goto the delegated handler reads');
   assert.match(SCRIPT, /railEl\.addEventListener\('click'/);
   assert.match(SCRIPT, /railEl\.addEventListener\('keydown'/);
   assert.match(SCRIPT, /show\(Number\(li\.getAttribute\('data-goto'\)\), true\)/, 'a deliberate step: focus moves');

package/tests/provision.mjs

@@ -1673,6 +1673,26 @@ await ta('federateInstance(--apply): registers the client on the hub bound to th
   });
 });
 
+await ta('federateInstance: the project-detail answers ride to the catalog row — and a SKIP stays skipped (task 1002334)', async () => {
+  await withEnv(HUB_ENV, async () => {
+    // The instance row holds what the owner said at creation; the catalog row is
+    // where the publish gate reads it (ADR 0182 D4). Dropping the answer on this
+    // one hop would leave a project that DID describe itself in dark matter,
+    // which would make the whole optional step decorative.
+    const told = { ...coTenantWithDomain, type: 'game', description: 'A co-op farming game.' };
+    const pi = fakePI();
+    const deps = { apply: true, log: () => {}, platformIdentity: pi, hubKeys: hubKeysOn, db: { query: async () => ({ rows: [{ github_id: 'gh-owner-1' }] }) } };
+    await P.federateInstance(told, deps);
+    assert.equal(pi.calls[0].description, 'A co-op farming game.', 'the description reaches the hub registration');
+    assert.equal(pi.calls[0].type, 'game', 'alongside the declared type it follows');
+
+    // the skipped case: absent, never an empty string invented on the way
+    const skipped = fakePI();
+    await P.federateInstance(coTenantWithDomain, { ...deps, platformIdentity: skipped });
+    assert.equal(skipped.calls[0].description, undefined, 'a skipped interview passes nothing — upsertProject COALESCEs, so it nulls nothing either');
+  });
+});
+
 await ta('federateInstance(dry-run): registers NOTHING, returns a placeholder block (so webEnvBody can still compose)', async () => {
   await withEnv(HUB_ENV, async () => {
     const pi = fakePI();