@bongos/core 1.19.412 → 1.19.414

package/tests/landing_legal_pages.mjs

@@ -160,3 +160,13 @@ for (const p of PAGES) {
     }
   });
 }
+
+// ── dark only (task 1003336) ──────────────────────────────────────────────
+
+test('the legal pages are dark only — data-mode="dark" fixed on <html>, no mode script (task 1003336)', () => {
+  for (const p of PAGES) {
+    const html = read(p.file);
+    assert.match(html, /^<html lang="en" data-mode="dark">/m, `${p.file}: dark is fixed on <html>`);
+    assert.doesNotMatch(html, /cb-color-mode|setAttribute\('data-mode'/, `${p.file}: nothing reads or writes a mode`);
+  }
+});

package/tests/landing_page.mjs

@@ -55,8 +55,6 @@ const PAGE_CSS = PAGE_STYLES.replace(/\/\*[\s\S]*?\*\//g, '');
 // The page script minus its comments — these assertions are about what the code
 // DOES, and the comments quote the very shapes being ruled out.
 const CODE = HTML.split('<script>').pop().replace(/\/\*[\s\S]*?\*\//g, '');
-// The pre-paint mode script, which is the FIRST <script> in <head>.
-const PREPAINT = HTML.split('<script>')[1].split('</script>')[0];
 
 // ── (1) the apex conditional ───────────────────────────────────────────────
 
@@ -255,11 +253,11 @@ test('every dark-mode rule is written twice — the block and its media twin (C2
   const explicit = (PAGE_CSS.match(/:root\[data-mode="dark"\]/g) || []).length;
   const media = (PAGE_CSS.match(/:root:not\(\[data-mode="light"\]\)/g) || []).length;
   assert.equal(explicit, media, 'a dark rule with no prefers-color-scheme twin only half-works');
-  // the shipped page writes four: the mode-toggle icon swap (.sun and .moon are
-  // one selector list each), the wide plate/geometry token block, and the two
-  // narrow ones. The floor is the count observed at the build, so deleting a
-  // twin fails even when the pair stays balanced.
-  assert.ok(explicit >= 4, `expected at least 4 dark rules, found ${explicit}`);
+  // the shipped page writes two: the wide plate/geometry token block and the
+  // narrow one (the mode-toggle icon swap left with the toggle, task 1003336).
+  // The floor is the count observed at the build, so deleting a twin fails even
+  // when the pair stays balanced.
+  assert.ok(explicit >= 2, `expected at least 2 dark rules, found ${explicit}`);
 });
 
 test('the page links world.css root-absolute, and does not fork the hub sheet', () => {
@@ -504,16 +502,15 @@ test('the tagline is one server-stamped string, split for the composition only',
   assert.match(PAGE_CSS, /h1 \.whole\{[^}]*white-space:normal/, 'the whole-tagline fallback must wrap');
 });
 
-test('the mode is resolved before first paint, and ?mode= wins', () => {
-  // A stored dark choice applied by the deferred script flashes the light page
-  // first; and ?mode= is how a reviewer walks both modes on one URL, which the
-  // render probes depend on.
-  assert.match(PREPAINT, /URLSearchParams\(location\.search\)\.get\('mode'\)/);
-  assert.match(PREPAINT, /localStorage\.getItem\('cb-color-mode'\)/);
-  assert.match(PREPAINT, /setAttribute\('data-mode'/);
-  // it is in <head>, ahead of the stylesheet link and the body
-  assert.ok(HTML.indexOf('cb-color-mode') < HTML.indexOf('<body>'));
-  assert.match(CODE, /localStorage\.setItem\('cb-color-mode', next\)/, 'the toggle persists the choice');
+test('the apex is dark only: data-mode="dark" is fixed on <html>, nothing reads or writes a mode (task 1003336)', () => {
+  // The owner's call on the planets review: light stays the builders' hall's.
+  // A fixed attribute beats a script — nothing to flash, nothing to persist,
+  // and the OS preference never reaches the page.
+  assert.match(HTML, /^<html lang="en" data-mode="dark">/m);
+  assert.doesNotMatch(HTML, /cb-color-mode/, 'no persisted choice is read or written');
+  assert.doesNotMatch(HTML, /URLSearchParams\(location\.search\)\.get\('mode'\)/, '?mode= no longer walks a second mode');
+  assert.doesNotMatch(HTML, /matchMedia\('\(prefers-color-scheme: dark\)'\)/, 'no OS-preference read in script');
+  assert.doesNotMatch(CODE, /setAttribute\('data-mode'/, 'nothing flips the mode');
 });
 
 // ── the assertions tests/platform_boot.mjs will make once the apex flips ───
@@ -530,13 +527,13 @@ test('the page satisfies the parked platform_boot assertions', () => {
 // the profile band. Everything a visitor can reach is markup; the script only
 // opens and closes. These pin the shape the grader could not see from a diff.
 
-test('the bar is markup: the mark, the Projects trigger, the mode glyph, the sign-in door (task 1003300)', () => {
+test('the bar is markup: the mark, the Projects trigger, the sign-in door — and no mode glyph (tasks 1003300, 1003336)', () => {
   const body = HTML.split('<body>')[1].split('<script>')[0];
   assert.match(body, /<header class="topbar bar">/, 'one bar, the hub\'s class beside the page\'s');
   assert.match(body, /<a class="barMark" href="\/" aria-label="\{\{productName\}\}">\s*<svg viewBox="0 0 26 20"/, 'the static mark is the way home, labelled from the stamped name');
   assert.match(body, /<span class="mark-word">\{\{productName\}\}<\/span>/, 'the product name as plain type, folded away under 900');
   assert.match(body, /<button class="trig" type="button" id="projTrig" data-menu="projects" aria-expanded="false" aria-controls="menuProjects">Projects<svg class="cv"/);
-  assert.match(body, /<button class="modeBtn" id="mode" type="button" aria-label="Toggle light or dark">/);
+  assert.doesNotMatch(body, /modeBtn|id="mode"|class="moon"|class="sun"/, 'the mode glyph left the bar — the apex is dark only (task 1003336)');
   assert.match(body, /<span class="whoSlot" id="who">\s*<a class="pill signin" href="\/api\/bongos\/auth\/web\/start\?return=\/">Sign in<\/a>\s*<\/span>/, 'the door stands in the identity slot until the session resolves');
   // what left with the pill bar
   assert.doesNotMatch(body, /class="pill nav-pill"|class="right-pills"|class="pill mark-pill"|data-nav="home"/, 'no nav pill, no right pills, no Home');

package/tests/projects_hub.mjs

@@ -297,7 +297,7 @@ test('no id is declared twice — the wizard merge had four collisions to clear'
   // id makes the second node unreachable by getElementById and the first
   // silently wins. Scan the real markup only (JS builds ids like `dom-<iid>`
   // from fragments that would false-positive here).
-  const afterHead = HUB.slice(HUB.indexOf('</script>') + '</script>'.length);
+  const afterHead = HUB.slice(HUB.indexOf('<body'));
   const markup = afterHead.slice(0, afterHead.indexOf('<script>'));
   assert.ok(markup.includes('id="view-new"'), 'the markup slice must span the views');
   const ids = [...markup.matchAll(/\sid="([^"]+)"/g)].map((m) => m[1]);

package/tests/projects_hub_pre_uat.mjs

@@ -581,13 +581,14 @@ test('completed rail steps are a way back, the repo picker is honest ARIA, the c
   assert.equal((HUB.match(/aria-controls="projectsList"/g) || []).length, 5, 'the five state filters name the list they filter');
 });
 
-test('control nits: orb cursor, caret under reduced motion, mode label, home label, held reduce-motion query, target sizes', () => {
+test('control nits: orb cursor, caret under reduced motion, no mode switch, home label, held reduce-motion query, target sizes', () => {
   assert.doesNotMatch(COSMOS, /\.orb\{flex:0 0 54px;[^}]*cursor:pointer/, 'the base orb is not a pointer');
   assert.match(COSMOS, /\na\.orb\{cursor:pointer;\}/, 'only the linked orb is');
   assert.doesNotMatch(COSMOS, /\.orb\.ghost\{[^}]*cursor:default/);
   assert.doesNotMatch(HUB, /\.shell \.caret/, 'no caret to hide — the hub mark is static (task 1003300)');
-  assert.match(fn('paintModeToggle'), /el\.setAttribute\('aria-label', dark \? 'Switch to light mode' : 'Switch to dark mode'\);/);
-  assert.doesNotMatch(fn('paintModeToggle'), /aria-pressed/);
+  assert.doesNotMatch(SCRIPT, /modeToggle|paintModeToggle|resolvedMode|cb-color-mode/, 'the mode switch left the hub — the apex is dark only (task 1003336)');
+  assert.doesNotMatch(HUB, /id="modeToggle"|class="modeBtn"/);
+  assert.match(HUB, /^<html lang="en" data-mode="dark">/m, 'dark is fixed on <html>');
   assert.match(SCRIPT, /\$\('barMark'\)\.setAttribute\('aria-label', productName \+ ' — home'\);/, 'the mark — the only way home — is labelled from the product name');
   assert.match(SCRIPT, /var REDUCED_MQ = window\.matchMedia \? window\.matchMedia\('\(prefers-reduced-motion: reduce\)'\) : null;/);
   assert.match(SCRIPT, /if \(REDUCED\) stopSky\(\); else startSky\(\);/, 'a mid-session flip stops or restarts the sky');

package/tests/ui_design_kit.mjs

@@ -39,6 +39,12 @@ test('the shipped states files validate and sit beside the page they name', () =
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
     assert.equal(path.basename(rel), `${lib.pageName(json.page)}.states.json`, `${rel} is named for its page`);
   }
+  // the apex is dark only (task 1003336): its states files name the one mode, and
+  // render.js reads it as the default so a plain `--page /` never renders light
+  for (const rel of ['public-landing/projects.states.json', 'public-landing/index.states.json']) {
+    assert.deepEqual(readJson(rel).modes, ['dark'], `${rel}: the apex renders dark only`);
+    assert.equal(readJson(rel).modeQuery, false, `${rel}: no query walks a second mode`);
+  }
 });
 
 test('the shipped probes files validate', () => {
@@ -60,6 +66,10 @@ test('a states file that breaks the contract is refused with the reason named',
   assert.ok(bad.errors.some((e) => /states\.ok\.auth/.test(e)));
   const stub = lib.validateStatesFile({ page: '/x', stub: { prefix: 'builders' }, states: { a: {} } });
   assert.ok(stub.errors.some((e) => /stub\.prefix/.test(e)));
+  const modes = lib.validateStatesFile({ page: '/x', modes: ['sepia'], states: { a: {} } });
+  assert.ok(modes.errors.some((e) => e.startsWith('modes:')), 'an unknown mode is refused');
+  assert.ok(lib.validateStatesFile({ page: '/x', modes: [], states: { a: {} } }).errors.some((e) => e.startsWith('modes:')), 'an empty modes list is refused');
+  assert.deepEqual(lib.validateStatesFile({ page: '/x', modes: ['dark'], states: { a: {} } }).errors, [], 'one declared mode is the dark-only shape');
 });
 
 test('a probes file needs a name and an expectation per probe, and cannot continue from nothing', () => {