@bongos/core 1.19.40 → 1.19.41

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.40",
-  "core_contract": "1.19.40",
-  "source_commit": "512e419a012e048b5e7d5904053cbc45df054a09",
+  "core_version": "1.19.41",
+  "core_contract": "1.19.41",
+  "source_commit": "ef65ee2c6121ae010e5ad2c1ac67b349cf9b9161",
   "source_ref": "HEAD",
-  "built_at": "2026-08-11T16:35:25.688Z",
+  "built_at": "2026-08-11T16:42:56.706Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 289,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 1523,
-  "tree_sha256": "39b4dbb47e0100a520bddafb358c1c89d7a74bc6975261774d9dd12059d544dc",
+  "tree_sha256": "8bdaf758774aaff55446f0ca5ac714795f728937d893a1085e21cf14db853915",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -3377,12 +3377,12 @@
     {
       "path": "modules/lifecycle/db.js",
       "mode": "0000644",
-      "sha256": "c7dfc49df888857c8975077a069e8730d16926d8e92776f09489f69a40068f31"
+      "sha256": "57c88852ff0aa9f0b3673fa62b35f352d92cc9070e7872137003e395c42eb026"
     },
     {
       "path": "modules/lifecycle/done-when.js",
       "mode": "0000644",
-      "sha256": "803ce237622eaba321c6fd87db1645b8ba474af3d3486643aa9d52a6b2bd27d1"
+      "sha256": "4e6f6af1cdaf026466155c1b0656a0e89872aa2bb264f36c50997ec4f069e808"
     },
     {
       "path": "modules/lifecycle/github-push.js",
@@ -4027,12 +4027,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "290c88cdeae475bf124eb3e74292108c669006b69414d258ae3d961b9e80f743"
+      "sha256": "3d5765b40ed913e05bea697ecb878e98fa799e667a5352d4d8f37236a0b671b4"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "316768e98e388920e8710c944cd4fbfd7c2bf947a742a3aa6698d66b35e838e6"
+      "sha256": "552a8ef2e0d6b1a69377cbf67bdc0b49574312a68b0ac4162bc606db5870afff"
     },
     {
       "path": "public-docs/index.html",
@@ -5652,7 +5652,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "a122aca901bb83b94b1d475a651eae90c7a7f72251703ce3a81cd14dcf39fe66"
+      "sha256": "f1c39c1f5862092c57f1c5f5232dfce0a9ac41376838899c92c286df3178936f"
     },
     {
       "path": "src/module-loader/loader.js",
@@ -6172,7 +6172,7 @@
     {
       "path": "tests/criterion_progress.mjs",
       "mode": "0000644",
-      "sha256": "3ba6ac8556e9f5f0cd57f724cc136d024d64f684ff1d892bf6825e1b8ec0822d"
+      "sha256": "e5b5ccf87a34658b3b25e4289caf702fbc44d77bacfec5bd823d5f6666ff213b"
     },
     {
       "path": "tests/criterion_proposal.mjs",
@@ -6442,7 +6442,7 @@
     {
       "path": "tests/goal_achievement.mjs",
       "mode": "0000644",
-      "sha256": "0838db3cbd5922e47777a25828b2a1b662284a251c5b8309610da634d448c90a"
+      "sha256": "a6ddb674d4ce1f6da9eb7b653ef92b9f0fcc85387e70bdf5358aff84ef518824"
     },
     {
       "path": "tests/goal_advisory.mjs",
@@ -6482,7 +6482,7 @@
     {
       "path": "tests/goal_routes.mjs",
       "mode": "0000644",
-      "sha256": "cfd76bf4bd4ed22702861833966cd3eb02dee9815d11d0429cb2773ae17a48ad"
+      "sha256": "4fd3ec8ef855b0131e17931908e9aebf16238d45febdf0b8306e2908152e2655"
     },
     {
       "path": "tests/goal_scope_check.mjs",

package/modules/lifecycle/db.js

@@ -893,7 +893,10 @@ async function listCriteriaForGoal(goalId, deps = {}) {
      counts AS (
        SELECT tc.criterion_id,
               count(*)::int                                        AS linked_tasks,
-              count(*) FILTER (WHERE t.status <> 'shipped')::int    AS unshipped_tasks
+              -- task 1002651 (migration 017's family): abandoned is a terminal
+              -- state (deliberately cut), not pending work — it must not hold a
+              -- criterion's "met — pending review" flip hostage forever.
+              count(*) FILTER (WHERE t.status NOT IN ('shipped', 'abandoned'))::int AS unshipped_tasks
          FROM task_criteria tc
          JOIN tasks t ON t.id = tc.task_id
         WHERE tc.criterion_id IN (SELECT id FROM crit)

package/modules/lifecycle/done-when.js

@@ -126,7 +126,7 @@ async function listPendingReviewCriteria({ versionId = null } = {}, deps = {}) {
          JOIN tasks t          ON t.id = tc.task_id
         WHERE c.satisfied = false
         GROUP BY c.id
-       HAVING count(*) FILTER (WHERE t.status <> 'shipped') = 0
+       HAVING count(*) FILTER (WHERE t.status NOT IN ('shipped', 'abandoned')) = 0
      ),
      goal_unsat AS (
        SELECT goal_id, count(*)::int AS unsatisfied
@@ -269,7 +269,9 @@ function buildCriterionProgress(versionId, rows, unattributedCount = 0, goalRows
     const counts = { total: c.tasks.length };
     for (const t of c.tasks) counts[t.status] = (counts[t.status] || 0) + 1;
     const shipped = counts.shipped || 0;
-    const remaining = c.tasks.filter((t) => t.status !== 'shipped');
+    // task 1002651: abandoned is terminal (cut work, migration 017's family) —
+    // it is not "remaining" and must not block the pending-review flip.
+    const remaining = c.tasks.filter((t) => t.status !== 'shipped' && t.status !== 'abandoned');
     // Auto-flag (ADR 0086 §6 / BV1.R63): a criterion is "met — pending review"
     // when it has ≥1 linked task and every one has shipped, but it has NOT yet
     // been confirmed (satisfied=false). Purely DERIVED — no stored column, no

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.40",
+  "version": "1.19.41",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.40",
+      "version": "1.19.41",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.40",
+  "version": "1.19.41",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -507,8 +507,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.38 with no explicit bump. run 31512284325. (task 1002620)
 //   1.19.40 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.39 with no explicit bump. run 31513136724. (task 1002620)
+//   1.19.41 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.40 with no explicit bump. run 31513793491. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.40'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.41'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/criterion_progress.mjs

@@ -247,6 +247,40 @@ test('isPendingReview: agrees with the rollup it was extracted from', () => {
   assert.equal(b.pending_review, false);
 });
 
+// --- task 1002651 (idea 1000635): abandoned tasks are terminal, not "remaining" ---
+
+test('1002651 one shipped + one abandoned → remaining=0, criterion flips to pending review', () => {
+  const rows = [
+    row(1, 20, 'c-ab', false, 300, 'landed', 'shipped'),
+    row(1, 20, 'c-ab', false, 301, 'cut', 'abandoned'),
+  ];
+  const c = buildCriterionProgress('V', rows, 0).criteria[0];
+  assert.equal(c.counts.remaining, 0, 'the abandoned task no longer counts as unshipped');
+  assert.deepEqual(c.remaining, [], 'the remaining list omits deliberately-cut work');
+  assert.equal(c.counts.abandoned, 1, 'the per-status bucket still reports it honestly');
+  assert.equal(c.pending_review, true, 'the criterion surfaces for human confirm instead of hanging forever');
+});
+
+test('1002651 abandoned does not hide genuinely unshipped work', () => {
+  const rows = [
+    row(1, 21, 'c-mix', false, 310, 'landed', 'shipped'),
+    row(1, 21, 'c-mix', false, 311, 'cut', 'abandoned'),
+    row(1, 21, 'c-mix', false, 312, 'in-flight', 'ready'),
+  ];
+  const c = buildCriterionProgress('V', rows, 0).criteria[0];
+  assert.equal(c.counts.remaining, 1);
+  assert.deepEqual(c.remaining.map((t) => t.id), [312], 'only the live task remains');
+  assert.equal(c.pending_review, false, 'live work still blocks the flip');
+});
+
+test('1002651 an all-abandoned criterion surfaces for review rather than auto-satisfying silently', () => {
+  const rows = [row(1, 22, 'c-cut', false, 320, 'cut', 'abandoned')];
+  const c = buildCriterionProgress('V', rows, 0).criteria[0];
+  // linked>0 + unshipped=0 → pending review: a human confirms or rejects what
+  // "met" means for a criterion whose entire linked work was cut.
+  assert.equal(c.pending_review, true);
+});
+
 console.log('');
 console.log(`criterionProgress aggregation tests: ${passed} passed, ${failed} failed`);
 if (failed > 0) process.exit(1);

package/tests/goal_achievement.mjs

@@ -138,7 +138,9 @@ await test('listPendingReviewCriteria: SQL encodes the auto-flag (all shipped) +
   const sql = String(find(pool.queries, /WITH pending AS/).sql).replace(/\s+/g, ' ');
   // The derivation: satisfied=false AND every linked task shipped (zero non-shipped).
   assert.match(sql, /c\.satisfied = false/, 'only unconfirmed criteria are pending');
-  assert.match(sql, /HAVING count\(\*\) FILTER \(WHERE t\.status <> 'shipped'\) = 0/, 'all linked tasks must be shipped');
+  // task 1002651: abandoned is terminal (cut work) — it must not hold the queue
+  // entry hostage, so the filter counts only live-and-unshipped tasks.
+  assert.match(sql, /HAVING count\(\*\) FILTER \(WHERE t\.status NOT IN \('shipped', 'abandoned'\)\) = 0/, 'all LIVE linked tasks must be shipped');
   assert.match(sql, /is_last_in_goal/, 'surfaces whether confirming completes the goal');
 });
 

package/tests/goal_routes.mjs

@@ -173,6 +173,17 @@ await test('listCriteriaForGoal: pending_review false once the criterion is conf
   assert.equal(out.pending_review, false);
 });
 
+await test('listCriteriaForGoal: the unshipped filter excludes abandoned (task 1002651)', async () => {
+  const pool = critPool([critRow()]);
+  await listCriteriaForGoal(3, { pool });
+  const sel = find(pool.queries, CRIT_SQL_RE);
+  assert.match(
+    sel.sql,
+    /FILTER \(WHERE t\.status NOT IN \('shipped', 'abandoned'\)\)/,
+    'an abandoned linked task must not hold the pending-review flip hostage (migration 017 family)'
+  );
+});
+
 await test('listCriteriaForGoal: pending_review false with NO linked tasks (vacuous truth guard)', async () => {
   const pool = critPool([critRow({ satisfied: false, linked_tasks: 0, unshipped_tasks: 0 })]);
   const [out] = await listCriteriaForGoal(3, { pool });