@bongos/core 1.19.380 → 1.19.382

package/tests/session_records.mjs

@@ -112,27 +112,144 @@ test('snippetOf flattens whitespace, caps length, and scrubs', () => {
 });
 
 // ---------- resolveTranscriptPath (#551: worktree sessions) ----------
+//
+// FIXTURE NOTE: the expected transcript path is DERIVED via encodeProjectPath(
+// path.resolve(dir)) rather than hard-coded as its POSIX encoding. path.resolve
+// is platform-dependent — on win32 '/proj' resolves to 'C:\\\\proj', which encodes
+// to 'C--proj', not '-proj' — so hard-coded encodings made these two tests fail
+// on Windows while passing in Linux CI. Deriving them asserts the same behaviour
+// on both. (POSIX encoding itself is pinned separately below.)
+const sidPath = (base, dir, sid) =>
+  path.join(base, 'projects', encodeProjectPath(path.resolve(dir)), `${sid}.jsonl`);
 
 test('resolveTranscriptPath prefers the session CWD (worktree) over REPO_ROOT', () => {
   const sid = 'abc-123';
   const base = '/fake/.claude';
   const worktree = '/proj/.claude/worktrees/wt1';
   const mainRepo = '/proj';
-  const wtPath = path.join(base, 'projects', '-proj--claude-worktrees-wt1', `${sid}.jsonl`);
+  const wtPath = sidPath(base, worktree, sid);
   // Only the worktree-encoded path exists — the bug looked at REPO_ROOT first.
-  const got = resolveTranscriptPath(sid, [worktree, mainRepo], { base, existsFn: (p) => p === wtPath });
+  const got = resolveTranscriptPath(sid, [worktree, mainRepo], {
+    base,
+    existsFn: (p) => p === wtPath,
+    readdirFn: () => [],
+  });
   assert.equal(got, wtPath);
 });
 
 test('resolveTranscriptPath falls back to REPO_ROOT, else null', () => {
   const sid = 'abc-123';
   const base = '/fake/.claude';
-  const mainPath = path.join(base, 'projects', '-proj', `${sid}.jsonl`);
+  const mainPath = sidPath(base, '/proj', sid);
   assert.equal(
-    resolveTranscriptPath(sid, ['/proj/.claude/worktrees/wt1', '/proj'], { base, existsFn: (p) => p === mainPath }),
+    resolveTranscriptPath(sid, ['/proj/.claude/worktrees/wt1', '/proj'], {
+      base,
+      existsFn: (p) => p === mainPath,
+      readdirFn: () => [],
+    }),
     mainPath
   );
-  assert.equal(resolveTranscriptPath(sid, ['/a', '/b'], { base, existsFn: () => false }), null);
+  assert.equal(
+    resolveTranscriptPath(sid, ['/a', '/b'], { base, existsFn: () => false, readdirFn: () => [] }),
+    null
+  );
+});
+
+// ---------- resolveTranscriptPath scan fallback (task 1002505) ----------
+//
+// The two fast paths above NARROW the miss, they do not seal it: the session
+// driving a ship need not be rooted in process.cwd() OR REPO_ROOT. A session
+// rooted in ANOTHER repo can file a task here and ship it (proven on task
+// 1002475), and before this fallback both probes missed, classifyUploadSkip
+// returned transcript_not_found, no session_record was written, and the
+// cost-plus reward — the only stream this instance pays (ADR 0146) — never
+// booked. The fallback scans every dir under <base>/projects for
+// <sessionId>.jsonl; a session id is a UUID, so a filename hit is unambiguous.
+
+test('resolveTranscriptPath finds a transcript rooted in a DIFFERENT project dir (the 1002475 shape)', () => {
+  const sid = 'e53f445b-308a-454e-9ac1-9c22d0188a37';
+  const base = '/fake/.claude';
+  // The orchestrating session lived under an unrelated repo's encoded dir, so
+  // neither the claim worktree nor REPO_ROOT could ever match it.
+  const foreign = path.join(base, 'projects', 'C--Users-x-Git-repos-other-project', `${sid}.jsonl`);
+  const got = resolveTranscriptPath(sid, ['/proj/.claude/worktrees/wt1', '/proj'], {
+    base,
+    existsFn: (p) => p === foreign,
+    readdirFn: () => ['C--Users-x-Git-repos-other-project', '-proj', '-proj--claude-worktrees-wt1'],
+  });
+  assert.equal(got, foreign);
+});
+
+test('resolveTranscriptPath scan only matches the exact session id — no mis-attribution', () => {
+  const sid = 'abc-123';
+  const base = '/fake/.claude';
+  const other = path.join(base, 'projects', '-somewhere-else', 'def-456.jsonl');
+  assert.equal(
+    resolveTranscriptPath(sid, ['/proj'], {
+      base,
+      existsFn: (p) => p === other,
+      readdirFn: () => ['-somewhere-else'],
+    }),
+    null
+  );
+});
+
+test('resolveTranscriptPath does not scan when a fast path hits (precedence unchanged)', () => {
+  const sid = 'abc-123';
+  const base = '/fake/.claude';
+  const wtPath = sidPath(base, '/proj/.claude/worktrees/wt1', sid);
+  let scanned = 0;
+  const got = resolveTranscriptPath(sid, ['/proj/.claude/worktrees/wt1', '/proj'], {
+    base,
+    existsFn: (p) => p === wtPath,
+    readdirFn: () => { scanned++; return []; },
+  });
+  assert.equal(got, wtPath);
+  assert.equal(scanned, 0, 'the scan must not run once a fast path has matched');
+});
+
+test('resolveTranscriptPath fills opts.tried: the fast paths, plus ONE scan summary', () => {
+  const sid = 'abc-123';
+  const base = '/fake/.claude';
+  const tried = [];
+  const got = resolveTranscriptPath(sid, ['/proj/.claude/worktrees/wt1', '/proj'], {
+    base,
+    existsFn: () => false,
+    readdirFn: () => ['-a', '-b', '-c'],
+    tried,
+  });
+  assert.equal(got, null);
+  // Two exact fast paths...
+  assert.equal(tried[0], sidPath(base, '/proj/.claude/worktrees/wt1', sid));
+  assert.equal(tried[1], sidPath(base, '/proj', sid));
+  // ...then a single bounded summary, not one line per scanned dir, so the
+  // transcript_not_found reason stays readable however many projects exist.
+  assert.equal(tried.length, 3);
+  assert.ok(tried[2].includes('scanned 3 project dirs'), tried[2]);
+});
+
+test('resolveTranscriptPath survives an unreadable projects dir and says so', () => {
+  const sid = 'abc-123';
+  const base = '/fake/.claude';
+  const tried = [];
+  const got = resolveTranscriptPath(sid, ['/proj'], {
+    base,
+    existsFn: () => false,
+    readdirFn: () => { throw new Error('ENOENT'); },
+    tried,
+  });
+  assert.equal(got, null, 'a missing/unreadable projects dir must not throw into the ship path');
+  assert.ok(tried[tried.length - 1].includes('could not read the projects dir'), tried.join(' ; '));
+});
+
+test('resolveTranscriptPath tolerates a null/absent projectDirs list', () => {
+  const sid = 'abc-123';
+  const base = '/fake/.claude';
+  const hit = path.join(base, 'projects', '-only-dir', `${sid}.jsonl`);
+  assert.equal(
+    resolveTranscriptPath(sid, null, { base, existsFn: (p) => p === hit, readdirFn: () => ['-only-dir'] }),
+    hit
+  );
 });
 
 // ---------- encodeProjectPath (task 1002471: win32 separators) ----------