@bongos/core 1.19.373 → 1.19.375

package/tests/sound_player.mjs

@@ -343,3 +343,41 @@ test('playerFor never throws and returns null or a [cmd, args] pair', () => {
     assert.ok(Array.isArray(got[1]));
   }
 });
+
+// ---------------------------------------------------------------------------
+// readPrefs honours the path it was GIVEN (task 1003293).
+//
+// The legacy-path fallback used to fire for any unreadable path, so a caller
+// naming an explicit file silently received a different one — the user's real
+// prefs. That made the two fail-open tests above pass in CI (no prefs on a
+// runner) and fail on any machine where the builder had saved sound settings:
+// green where nobody looks, red where everybody does. The fallback is still
+// right for the DEFAULT call; it is wrong the moment a caller names a file.
+// ---------------------------------------------------------------------------
+
+test('an explicit missing path fails open — it never substitutes another file', () => {
+  // The regression: write a legacy-shaped prefs file at the pre-rename location
+  // and prove an explicit path still ignores it. Skipped if the real file exists,
+  // because this test must never clobber a builder's own settings.
+  const legacy = player.LEGACY_PREFS_PATH;
+  if (!legacy || fs.existsSync(legacy)) {
+    // Nothing to plant, but the invariant is still checkable: an absent explicit
+    // path must yield the fail-open default, whatever the legacy file holds.
+    const p = player.readPrefs(path.join(os.tmpdir(), `otb-absent-${process.pid}.json`));
+    assert.equal(p.volume, 100);
+    assert.equal(p.enabled('ship'), true);
+    return;
+  }
+  fs.mkdirSync(path.dirname(legacy), { recursive: true });
+  fs.writeFileSync(legacy, JSON.stringify({ volume: 11, ship: false }));
+  try {
+    const p = player.readPrefs(path.join(os.tmpdir(), `otb-absent-${process.pid}.json`));
+    assert.equal(p.volume, 100, 'an explicit path must not inherit the legacy file volume');
+    assert.equal(p.enabled('ship'), true, 'an explicit path must not inherit legacy mutes');
+    // …while the DEFAULT call still honours it — the fallback is not removed.
+    const d = player.readPrefs();
+    assert.equal(d.volume, 11, 'the default path must still fall back to the legacy file');
+  } finally {
+    fs.unlinkSync(legacy);
+  }
+});