@bongos/core 1.19.364 → 1.19.366

package/docs/copy-registry.json

@@ -1025,7 +1025,7 @@
       "occurrences": 2,
       "at": [
         "modules/hall-ui/public/gate.js:205",
-        "modules/hall-ui/public/government.js:859"
+        "modules/hall-ui/public/government.js:879"
       ]
     },
     {
@@ -1608,7 +1608,7 @@
       "surface": "builders-hall",
       "text": ", membership",
       "file": "modules/hall-ui/public/government.js",
-      "line": 803,
+      "line": 823,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -1932,7 +1932,7 @@
       "surface": "builders-hall",
       "text": "An objection returns the idea to its author with your reason and the section it faults \\u2014 the feedback they revise against.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 758,
+      "line": 777,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -2103,7 +2103,7 @@
       "surface": "builders-hall",
       "text": "As configuration:",
       "file": "modules/hall-ui/public/government.js",
-      "line": 650,
+      "line": 657,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -2148,7 +2148,7 @@
       "surface": "builders-hall",
       "text": "Assigned {…} to builder {…}.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 408,
+      "line": 407,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -2373,7 +2373,7 @@
       "surface": "builders-hall",
       "text": "Cast objection",
       "file": "modules/hall-ui/public/government.js",
-      "line": 758,
+      "line": 777,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -2436,7 +2436,7 @@
       "surface": "builders-hall",
       "text": "Charter library",
       "file": "modules/hall-ui/public/government.js",
-      "line": 627,
+      "line": 634,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -2679,7 +2679,7 @@
       "surface": "builders-hall",
       "text": "Closed sittings",
       "file": "modules/hall-ui/public/government.js",
-      "line": 829,
+      "line": 849,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3003,7 +3003,7 @@
       "surface": "builders-hall",
       "text": "Could not assign: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 413,
+      "line": 412,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3093,7 +3093,7 @@
       "surface": "builders-hall",
       "text": "Could not create rank: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 393,
+      "line": 392,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3129,7 +3129,7 @@
       "surface": "builders-hall",
       "text": "Could not load government data just now.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 901,
+      "line": 921,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3201,7 +3201,7 @@
       "surface": "builders-hall",
       "text": "Could not load the Board Room just now.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 821,
+      "line": 841,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3210,7 +3210,7 @@
       "surface": "builders-hall",
       "text": "Could not load the constitution just now.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 645,
+      "line": 652,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3363,7 +3363,7 @@
       "surface": "builders-hall",
       "text": "Could not remove: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 321,
+      "line": 320,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3390,7 +3390,7 @@
       "surface": "builders-hall",
       "text": "Could not reset: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 260,
+      "line": 259,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3633,7 +3633,7 @@
       "surface": "builders-hall",
       "text": "Could not vote: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 785,
+      "line": 805,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3651,7 +3651,7 @@
       "surface": "builders-hall",
       "text": "Could not {…}: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 273,
+      "line": 272,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3678,7 +3678,7 @@
       "surface": "builders-hall",
       "text": "Create a custom rank first.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 404,
+      "line": 403,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3714,7 +3714,7 @@
       "surface": "builders-hall",
       "text": "Created rank {…}.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 387,
+      "line": 386,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -4326,7 +4326,7 @@
       "surface": "builders-hall",
       "text": "Full Idea",
       "file": "modules/hall-ui/public/government.js",
-      "line": 686,
+      "line": 693,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4596,7 +4596,7 @@
       "surface": "builders-hall",
       "text": "How a project moves between structures over time — summarized from the synthesis:",
       "file": "modules/hall-ui/public/government.js",
-      "line": 627,
+      "line": 634,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4614,7 +4614,7 @@
       "surface": "builders-hall",
       "text": "How it has changed",
       "file": "modules/hall-ui/public/government.js",
-      "line": 650,
+      "line": 657,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4677,7 +4677,7 @@
       "surface": "builders-hall",
       "text": "How this project is governed — the constitution it runs, the Board Room, and the ranks & permissions that administer it.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 888,
+      "line": 908,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -5703,7 +5703,7 @@
       "surface": "builders-hall",
       "text": "No custom ranks yet",
       "file": "modules/hall-ui/public/government.js",
-      "line": 310,
+      "line": 309,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5775,7 +5775,7 @@
       "surface": "builders-hall",
       "text": "No machine principals declared.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 332,
+      "line": 331,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5811,7 +5811,7 @@
       "surface": "builders-hall",
       "text": "No rank assignments yet.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 284,
+      "line": 283,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5838,7 +5838,7 @@
       "surface": "builders-hall",
       "text": "No sitting has closed yet.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 830,
+      "line": 850,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5892,7 +5892,7 @@
       "surface": "builders-hall",
       "text": "No votes yet{…}.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 704,
+      "line": 714,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6459,7 +6459,7 @@
       "surface": "builders-hall",
       "text": "Permissions is the Archon administration surface. The Constitution and the Board Room are yours to read.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 872,
+      "line": 892,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6918,7 +6918,7 @@
       "surface": "builders-hall",
       "text": "Removed {…} from builder {…}.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 317,
+      "line": 316,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -7062,7 +7062,7 @@
       "surface": "builders-hall",
       "text": "Reset to default",
       "file": "modules/hall-ui/public/government.js",
-      "line": 224,
+      "line": 223,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -7080,7 +7080,7 @@
       "surface": "builders-hall",
       "text": "Reset {…} to its default permissions?\\n\\nEvery change you've made to this rank is discarded, and it takes effect for every builder at this rank on their next request.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 252,
+      "line": 251,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -7107,7 +7107,7 @@
       "surface": "builders-hall",
       "text": "Restricted.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 859,
+      "line": 879,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -7404,7 +7404,7 @@
       "surface": "builders-hall",
       "text": "Selectable today",
       "file": "modules/hall-ui/public/government.js",
-      "line": 627,
+      "line": 634,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8016,7 +8016,7 @@
       "surface": "builders-hall",
       "text": "The developmental ladder: {…}. Formality is adopted only where informal coordination breaks.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 633,
+      "line": 640,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8187,7 +8187,7 @@
       "surface": "builders-hall",
       "text": "The seven government structures, for getting a team up to speed before deciding when to flip a switch.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 627,
+      "line": 634,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8408,11 +8408,11 @@
       "confidence": "certain"
     },
     {
-      "id": "e901434bebd7",
+      "id": "675a43171070",
       "surface": "builders-hall",
-      "text": "This is your idea \\u2014 its author does not vote on it. The board decides; a return comes back to you with its reason.",
+      "text": "This is your idea. You can vote on it \\u2014 your position belongs on the record \\u2014 but it can\\u2019t be decided by your vote alone, and a vote on your own idea earns no karma.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 754,
+      "line": 775,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8637,7 +8637,7 @@
       "surface": "builders-hall",
       "text": "Vote yes",
       "file": "modules/hall-ui/public/government.js",
-      "line": 758,
+      "line": 777,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8781,7 +8781,7 @@
       "surface": "builders-hall",
       "text": "What this project runs today",
       "file": "modules/hall-ui/public/government.js",
-      "line": 650,
+      "line": 657,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8889,7 +8889,7 @@
       "surface": "builders-hall",
       "text": "Why \\u2014 the reason the author will act on",
       "file": "modules/hall-ui/public/government.js",
-      "line": 758,
+      "line": 777,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9060,7 +9060,7 @@
       "surface": "builders-hall",
       "text": "You have not voted on this item. Casting arrives with the vote form.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 802,
+      "line": 822,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9087,7 +9087,7 @@
       "surface": "builders-hall",
       "text": "You voted",
       "file": "modules/hall-ui/public/government.js",
-      "line": 801,
+      "line": 821,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9402,7 +9402,7 @@
       "surface": "builders-hall",
       "text": "active builder{…}: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 627,
+      "line": 634,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9483,7 +9483,7 @@
       "surface": "builders-hall",
       "text": "as configuration: {…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 621,
+      "line": 628,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9573,7 +9573,7 @@
       "surface": "builders-hall",
       "text": "cannot be read, so",
       "file": "modules/hall-ui/public/government.js",
-      "line": 499,
+      "line": 498,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9627,7 +9627,7 @@
       "surface": "builders-hall",
       "text": "documented for later",
       "file": "modules/hall-ui/public/government.js",
-      "line": 619,
+      "line": 626,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9690,7 +9690,7 @@
       "surface": "builders-hall",
       "text": "first vote",
       "file": "modules/hall-ui/public/government.js",
-      "line": 517,
+      "line": 516,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9933,7 +9933,7 @@
       "surface": "builders-hall",
       "text": "ladder · read-only",
       "file": "modules/hall-ui/public/government.js",
-      "line": 123,
+      "line": 122,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9978,7 +9978,7 @@
       "surface": "builders-hall",
       "text": "means expressible through the real configuration — a rank-based membership plus a pass rule — with no new code. This project has",
       "file": "modules/hall-ui/public/government.js",
-      "line": 627,
+      "line": 634,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10050,7 +10050,7 @@
       "surface": "builders-hall",
       "text": "no clock",
       "file": "modules/hall-ui/public/government.js",
-      "line": 527,
+      "line": 534,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10113,7 +10113,7 @@
       "surface": "builders-hall",
       "text": "objected to",
       "file": "modules/hall-ui/public/government.js",
-      "line": 711,
+      "line": 721,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10203,7 +10203,7 @@
       "surface": "builders-hall",
       "text": "or above",
       "file": "modules/hall-ui/public/government.js",
-      "line": 511,
+      "line": 510,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10257,7 +10257,7 @@
       "surface": "builders-hall",
       "text": "recommended at your headcount",
       "file": "modules/hall-ui/public/government.js",
-      "line": 620,
+      "line": 627,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10311,7 +10311,7 @@
       "surface": "builders-hall",
       "text": "selectable today",
       "file": "modules/hall-ui/public/government.js",
-      "line": 618,
+      "line": 625,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10356,7 +10356,7 @@
       "surface": "builders-hall",
       "text": "tally: {…} yes · {…} no — sitting under",
       "file": "modules/hall-ui/public/government.js",
-      "line": 803,
+      "line": 823,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10590,7 +10590,7 @@
       "surface": "builders-hall",
       "text": "your vote",
       "file": "modules/hall-ui/public/government.js",
-      "line": 708,
+      "line": 718,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10689,7 +10689,7 @@
       "surface": "builders-hall",
       "text": "{…} minutes",
       "file": "modules/hall-ui/public/government.js",
-      "line": 532,
+      "line": 539,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10770,7 +10770,7 @@
       "surface": "builders-hall",
       "text": "{…} proposed",
       "file": "modules/hall-ui/public/government.js",
-      "line": 544,
+      "line": 551,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10779,7 +10779,7 @@
       "surface": "builders-hall",
       "text": "{…} reset to its default {…} permissions.",
       "file": "modules/hall-ui/public/government.js",
-      "line": 256,
+      "line": 255,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -10914,7 +10914,7 @@
       "surface": "builders-hall",
       "text": "{…} · via rank",
       "file": "modules/hall-ui/public/government.js",
-      "line": 294,
+      "line": 293,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10995,7 +10995,7 @@
       "surface": "builders-hall",
       "text": "· {…} permission{…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 132,
+      "line": 131,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11103,7 +11103,7 @@
       "surface": "builders-hall",
       "text": "— {…}{…}",
       "file": "modules/hall-ui/public/government.js",
-      "line": 622,
+      "line": 629,
       "origin": "js-markup",
       "confidence": "certain"
     },

package/docs/file-map.md

@@ -412,12 +412,24 @@ To install on a new machine, symlink each routine's directory under `~/.claude/s
 ├── lifecycle-card.js         ← PostToolUse: deterministic delivery of MUTATING lifecycle cards (claim/ship/release) — the write-side mirror of session-cards.js (task 1288)
 ├── pre-compact.js            ← PreCompact: thin reader around eviction-policy.js — emits an eviction directive (blocks to drop + one-line recovery stubs) at the compaction seam (task 1349)
 ├── eviction-policy.js        ← pure deterministic in-session compaction classifier (transcript turns → eviction set + replacement stubs); no I/O, unit-tested in tests/eviction_policy.mjs; consumed by pre-compact.js (task 1348)
-├── stop-sound.js             ← Stop: completion sound on macOS (afplay; Glass / Hero on /tmp/otb-celebrate); silent no-op on other OSes
+├── stop-sound.js             ← ⚠ ABSENT from this repo (see the note below). Superseded anyway: the turn-end sound is now `scripts/gds/turn-end-sound.js`, wired as the Stop hook in `.claude/settings.json` and cross-platform rather than macOS-only (task 1003272)
 └── stop-refcheck.js          ← Stop: deterministic backstop that catches a bare `#NNN` Bongos ref in live session text (autolinks to a 404 GitHub issue) and asks for the clickable form (follow-on to task 929)
 ```
 
+> **⚠ THIS TREE IS STALE: 12 of the 13 files listed above are NOT in this repo** — only `secret-gate.js` exists on disk, and `.claude/settings.json` wires just `SessionStart` (three `scripts/gds/*` probes + the sound-prefs mirror), `PreToolUse` (secret-gate) and `Stop` (`scripts/gds/turn-end-sound.js`). The hook tree went the same way as `.claude/sounds/` — absent from every commit, lost when core was re-seeded to 1.18.0 (task 1003272 found and fixed the sound half of that). Do not assume a hook named here runs; check `.claude/settings.json`. Auditing and either restoring or deleting the other twelve is its own task, not a doc edit.
+
 (Before [#671](https://example.com/builders#/task/671) these ran via `bash` shims — `sync-env-local.sh`, `conductor.sh`, `onboarding-ship-logs.sh`, `rank-change-greeting.sh`, `pull-memory.sh` — which failed on Windows without Git Bash. The Node entries above replaced them.)
 
+**Notification sounds** at `.claude/sounds/` + `modules/hall-ui/public/*.wav` (task 1003272 — the local half of the 5-event sound system, which had never been committed):
+
+```
+.claude/sounds/
+└── play.js                   ← the local player. playSound(<wavName>) — fire-and-forget, never throws, spawns the platform player detached (afplay / paplay / aplay / ffplay / PowerShell SoundPlayer); scales the WAV itself for the master volume because aplay and SoundPlayer have no volume flag. Reads the prefs mirror at instance-config.configPath('sound-prefs.json') with the pre-rename ~/.config/otb/ as fallback. Required (guarded) by scripts/gds/ship-state.js; runnable directly: `node .claude/sounds/play.js ship`
+```
+
+The five base assets live ONCE, in `modules/hall-ui/public/` — served at `/builders/<name>.wav` for the Settings previews and read from the same directory by the player:
+`chime.wav` (pre-existing) plus `alert.wav`, `ship.wav`, `triumph.wav`, `fanfare.wav`, all generated by [`scripts/gds/gen-sounds.js`](../scripts/gds/gen-sounds.js) (`--check` verifies freshness; it never touches `chime.wav`).
+
 **On the droplet (`REDACTED_IP`):**
 
 ```

package/modules/builder-settings/event-sound-prefs.js

@@ -2,12 +2,22 @@
 // src/bongos/event-sound-prefs.js — per-builder per-event sound variant selection
 // (task 582). Extends the mute-toggle system (sound-prefs.js) with variant
 // picking: for each of 5 build events a builder can choose which world-themed
-// sound variant plays. Each variant maps to an EXISTING .wav in .claude/sounds/;
-// the dedicated world-themed audio assets (lyre-pluck.wav etc.) ship separately.
+// sound variant plays. Each variant maps to an EXISTING base .wav; the dedicated
+// per-variant audio (lyre-pluck.wav etc.) would ship separately.
+//
+// WHERE THE BASE WAVS ACTUALLY LIVE (corrected, task 1003272): modules/hall-ui/
+// public/, served at /builders/<name>.wav and read from that same directory by
+// .claude/sounds/play.js. This comment used to say .claude/sounds/, which was
+// true of no commit in this repo's history — for months FOUR of the five base
+// wavs did not exist anywhere, so every variant below except the two backed by
+// `chime` resolved to a 404 and played nothing. All five exist now, and
+// tests/sound_player.mjs asserts that every `wav` named here has a real file.
 
 // 5 build events, ordered for the UI. Each has a world-themed default variant
-// plus alternates. `wav` is the existing .claude/sounds/<name>.wav that backs
-// the variant until dedicated audio ships.
+// plus alternates. `wav` is the existing base sound that backs the variant until
+// dedicated audio ships. Each event's two variants deliberately name DIFFERENT
+// base wavs, so switching the picker audibly changes something — a picker whose
+// options all sounded identical would be a worse lie than no picker.
 const EVENTS = Object.freeze([
   {
     id:    'user-input',