@bongos/core 1.19.36 → 1.19.37

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.36",
-  "core_contract": "1.19.36",
-  "source_commit": "f97b75c015a281b9492699354142dadb85b5458c",
+  "core_version": "1.19.37",
+  "core_contract": "1.19.37",
+  "source_commit": "606cc770b09032c6ab385e1326f79b08c19e0083",
   "source_ref": "HEAD",
-  "built_at": "2026-08-11T15:56:45.212Z",
+  "built_at": "2026-08-11T16:06:38.933Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 287,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1210,
+    "functional_verbatim": 1211,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1518,
-  "tree_sha256": "59a933fb3e3a4fdc442f52821778e28dc3c5ca384160bcdeb6639512f861a0fc",
+  "file_count": 1519,
+  "tree_sha256": "faa022ab6fb5e04c311cd4d24d2991b07d15fb5fa565dffa0862d87fdf1e546d",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -3367,7 +3367,7 @@
     {
       "path": "modules/lifecycle/db.js",
       "mode": "0000644",
-      "sha256": "77528182c408edf2b8f3e07382bb83f97a7d668b979e97e60e4ff0c2e1bc7109"
+      "sha256": "c7dfc49df888857c8975077a069e8730d16926d8e92776f09489f69a40068f31"
     },
     {
       "path": "modules/lifecycle/done-when.js",
@@ -3442,7 +3442,7 @@
     {
       "path": "modules/lifecycle/routes/claims.js",
       "mode": "0000644",
-      "sha256": "6e30cf7169736737ea7aeac0aa1af9e5f31ed8ea79f08796cc2da9ed9ae03577"
+      "sha256": "92065e0a5cfd2a5d76bbf04f4efafe0e2b3bc31cf616136963d4c07fad25047e"
     },
     {
       "path": "modules/lifecycle/routes/dependencies.js",
@@ -4017,12 +4017,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "ba0c267dd729a028da03734f1aa527c2fcae016932cdbaea2d1650bc184ef8e4"
+      "sha256": "acab5dbbe8ab00da496f534457882de0c115d441e9f0e38fae6f5a901a4b3f47"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "30c2010f68e93023955954526ed962a366d4150e5b9a07a78ff0b1ac04f7b27c"
+      "sha256": "c33f5baf3eddd6b7bdcf80af532dc04d290e394b5c51b90931aa52d0ead94e6a"
     },
     {
       "path": "public-docs/index.html",
@@ -4547,7 +4547,7 @@
     {
       "path": "scripts/gds/claim.js",
       "mode": "0000644",
-      "sha256": "23f9932dd79c63915679eeb175e2fc6d95e43b840dba78336c23504c85617987"
+      "sha256": "6f09d9344f57039c07d2de943dabb48dbf717226aa2667f4163dab47fb74428a"
     },
     {
       "path": "scripts/gds/classify-discipline.js",
@@ -5057,7 +5057,7 @@
     {
       "path": "scripts/gds/run-unit-tests.js",
       "mode": "0000644",
-      "sha256": "7f0ad4e54c0e5c251f00c78c7a6065d4a8db7bc88f0492c75bc63f8929108203"
+      "sha256": "ce8856194aa805d1f62d47d4b04bac05168c0c748f869a094476a28b9db2a30a"
     },
     {
       "path": "scripts/gds/sandbox-stage.js",
@@ -5642,7 +5642,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "b7a1d663d910c88b285298b741d8fe6b7edb6b6c7644a59ea81f087549182ef0"
+      "sha256": "8066ee5e98e151dfc62228626a99a86f362697410aac483de27c75851cc3bdea"
     },
     {
       "path": "src/module-loader/loader.js",
@@ -6042,7 +6042,12 @@
     {
       "path": "tests/claim_error_surface.mjs",
       "mode": "0000644",
-      "sha256": "6273b5b86f0fecd24bcb54a36a673ec9d42f81180d602d5d374fc9d07a511072"
+      "sha256": "365f498d290298e0cd74888aff080cfbf3439e5e0cf2dd883291f39dface27e7"
+    },
+    {
+      "path": "tests/claim_gate_open_blocker.mjs",
+      "mode": "0000644",
+      "sha256": "e62324e8e504e4f2788355b1ed1ffc5b1d434ef0ef0e72c18751236436e10c49"
     },
     {
       "path": "tests/claim_gate_rebase.mjs",

package/modules/lifecycle/db.js

@@ -2586,6 +2586,23 @@ async function claimTask({ taskId, builderId, worktreeName, headSha, creatorSess
       throw { code: 'TASK_NOT_READY', currentStatus: task.status };
     }
 
+    // task 1002650 (idea 1000644): the claimable FEED filters out ready tasks
+    // with an open blocker link, but the direct claim-by-id path never checked —
+    // the feed hid the trap and this path walked into it. Mirror migration 176's
+    // task_is_fully_unblocked clause so both gates enforce the same rule.
+    const { rows: openBlockers } = await client.query(
+      `SELECT b.id, b.title
+         FROM task_blockers tb
+         JOIN blockers b ON b.id = tb.blocker_id
+        WHERE tb.task_id = $1
+          AND b.status = 'open'
+        ORDER BY b.id`,
+      [taskId]
+    );
+    if (openBlockers.length > 0) {
+      throw { code: 'OPEN_BLOCKER', blockers: openBlockers };
+    }
+
     // Three-rank model (task #360 / ADR 0018; V3.R15 #239): a Xenos is the
     // sandboxed entry rank and may claim ONLY tasks explicitly opened to them
     // (newcomer_friendly). Metic+ (the approved working rank) and Archon claim
@@ -2893,6 +2910,27 @@ async function claimTasksBatch({ taskIds, builderId, worktreePrefix, creatorSess
       }
     }
 
+    // task 1002650 (idea 1000644): same open-blocker rule as claimTask — the
+    // batch path must not sidestep the gate the feed and single claim enforce.
+    const { rows: blockedRows } = await client.query(
+      `SELECT tb.task_id, b.id, b.title
+         FROM task_blockers tb
+         JOIN blockers b ON b.id = tb.blocker_id
+        WHERE tb.task_id = ANY($1::bigint[])
+          AND b.status = 'open'
+        ORDER BY b.id`,
+      [uniqIds]
+    );
+    const blockersByTask = new Map();
+    for (const r of blockedRows) {
+      const list = blockersByTask.get(Number(r.task_id)) || [];
+      list.push({ id: r.id, title: r.title });
+      blockersByTask.set(Number(r.task_id), list);
+    }
+    for (const [blockedTaskId, blockers] of blockersByTask) {
+      failures.push({ task_id: blockedTaskId, reason: 'OPEN_BLOCKER', blockers });
+    }
+
     // Three-rank model (task #360 / ADR 0018; V3.R15 #239): a Xenos may
     // batch-claim only tasks explicitly opened to them (newcomer_friendly).
     // Mirrors the single claimTask gate so the batch path can't be used to

package/modules/lifecycle/routes/claims.js

@@ -250,6 +250,10 @@ module.exports = function buildClaimsRouter() {
           err.code === 'TOUCHES_CONFLICT' ? 409 :
           err.code === 'MODULE_CONFLICT' ? 409 :
           err.code === 'DEPS_NOT_SHIPPED' ? 409 :
+          // task 1002650 (idea 1000644): a ready task with an open blocker link is
+          // hidden from the claimable feed; the direct claim-by-id gate now
+          // enforces the same rule instead of letting the claim walk into the trap.
+          err.code === 'OPEN_BLOCKER' ? 409 :
           // ADR 0120 part 3: the builder owes a rebase on an un-landed confirmed
           // task (reconciler-flagged needs_rebase); NEW claims are gated until
           // they land or release it. Existing claims are unaffected.
@@ -285,6 +289,12 @@ module.exports = function buildClaimsRouter() {
           const ids = (err.rebaseTasks || []).map((t) => `task ${t.id}`);
           err.hint = `Your queue is gated: ${ids.length} confirmed task(s) await your rebase (${ids.join(', ') || 'unknown'}). Land each (rebase its branch + re-ship, or /merge-mode) — or /builder-release it — then claim new work.`;
         }
+        // task 1002650: name the blocker(s) and the way forward — the same rule
+        // the claimable feed enforces, spoken at the gate instead of a bare 409.
+        if (err.code === 'OPEN_BLOCKER') {
+          const names = (err.blockers || []).map((b) => `blocker ${b.id} ("${b.title}")`);
+          err.hint = `This task is waiting on ${names.join(', ') || 'an open blocker'}. Resolve it first (/blocker-solve N drives one to done; resolving auto-promotes its linked tasks) — or pick another task from /builder-start.`;
+        }
         return res.fail(err.code, status, { ...err });
       }
       console.error('[gds] POST /claims', err);

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.36",
+  "version": "1.19.37",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.36",
+      "version": "1.19.37",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.36",
+  "version": "1.19.37",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/claim.js

@@ -256,6 +256,13 @@ function formatClaimFailure(r, taskId) {
     lines.push('Ship those first (or release them) and try again.');
     return { lines, exit: 1 };
   }
+  if (code === 'OPEN_BLOCKER') {
+    // task 1002650: the same rule the claimable feed enforces, spoken at the gate.
+    lines.push(`Task #${taskId} is waiting on an open blocker:`);
+    for (const b of d.blockers || []) lines.push(`  - blocker ${b.id}  ${b.title}`);
+    lines.push('Resolve it first (/blocker-solve N drives one to done; resolving auto-promotes its linked tasks) — or pick another task from /builder-start.');
+    return { lines, exit: 1 };
+  }
   // Fallback — still readable: the message + code, never a raw [object Object].
   lines.push(`Claim failed (${r ? r.status : '?'})${code ? ` [${code}]` : ''}${message ? `: ${message}` : ''}.`);
   return { lines, exit: 1 };

package/scripts/gds/run-unit-tests.js

@@ -73,7 +73,7 @@ const INTEGRATION = new Set([
   // platform-server — network + package build + a spawned server, run by its own
   // .github/workflows/consumer-layout-boot.yml, not this DB-free gate (task 2142).
   'consumer_layout_boot',
-  'claim_gate_rebase', 'clawback_confirmed_backlog', 'discord_autojoin', 'discord_oauth',
+  'claim_gate_open_blocker', 'claim_gate_rebase', 'clawback_confirmed_backlog', 'discord_autojoin', 'discord_oauth',
   'governance_fold_bench', 'governance_live_proof', 'linkify_refs', 'memory_isolation',
   'memory_pull', 'needs_rebase', 'parallel-load', 'reward_mode_cost_plus_only',
   'session_records', 'setup_smoke',

package/src/module-api.js

@@ -499,8 +499,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.34 with no explicit bump. run 31507293725. (task 1002620)
 //   1.19.36 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.35 with no explicit bump. run 31509715311. (task 1002620)
+//   1.19.37 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.36 with no explicit bump. run 31510590459. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.36'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.37'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/claim_error_surface.mjs

@@ -36,6 +36,7 @@ t('never dumps [object Object] for any known code', () => {
     'session_already_has_bound_claim',
     'newcomer_must_ship_first', 'ALREADY_CLAIMED', 'MODULE_CONFLICT',
     'TOUCHES_CONFLICT', 'TASK_NOT_READY', 'TASK_NOT_FOUND', 'DEPS_NOT_SHIPPED',
+    'OPEN_BLOCKER',
     'some_unmapped_future_code',
   ];
   for (const c of codes) {
@@ -87,6 +88,17 @@ t('DEPS_NOT_SHIPPED: lists each blocking dependency', () => {
   assert.match(out, /Dep A/);
 });
 
+// task 1002650: the wave-5 speech standard — the refusal names the blocker
+// (id + title) and the remedy, not a bare 409.
+t('OPEN_BLOCKER: names the blocker and the way forward', () => {
+  const out = text(formatClaimFailure(
+    envelope('OPEN_BLOCKER', { blockers: [{ id: 1000094, title: 'Owner must verify the installer' }] }), 9));
+  assert.match(out, /blocker 1000094/);
+  assert.match(out, /Owner must verify the installer/);
+  assert.match(out, /blocker-solve/);
+  assert.match(out, /pick another task/);
+});
+
 t('MODULE_CONFLICT + TOUCHES_CONFLICT: list conflicting task titles', () => {
   const mc = text(formatClaimFailure(
     envelope('MODULE_CONFLICT', { module_key: 'economy', conflictTaskTitles: ['Bar'] }), 4));

package/tests/claim_gate_open_blocker.mjs

@@ -0,0 +1,93 @@
+// tests/claim_gate_open_blocker.mjs — task 1002650 (idea 1000644, real DB).
+//
+// The open-blocker claim gate: a ready task linked to an OPEN blocker is
+// hidden from the claimable feed (CLAIMABLE_SQL), but the direct claim-by-id
+// path never checked — POST /claims walked straight into the trap the feed was
+// hiding. claimTask and claimTasksBatch now refuse with OPEN_BLOCKER, naming
+// the blocker, mirroring migration 176's task_is_fully_unblocked clause.
+// Real-DB integration test (self-skips without a reachable Postgres; in the
+// INTEGRATION set so the default DB-free lane never runs it).
+//
+// Run:  DATABASE_URL=... node tests/claim_gate_open_blocker.mjs
+
+import { createRequire } from 'node:module';
+import { strict as assert } from 'node:assert';
+const require = createRequire(import.meta.url);
+const { Pool } = require('pg');
+
+const pool = new Pool({ connectionString: process.env.DATABASE_URL || undefined });
+try {
+  await pool.query('SELECT 1');
+} catch (e) {
+  console.log(`claim_gate_open_blocker.mjs SKIPPED — no reachable Postgres (${e.code || e.message}).`);
+  await pool.end().catch(() => {});
+  process.exit(0);
+}
+
+const seams = require('../src/module-seams.js');
+if (!seams.hasProvider('reward')) seams.registerProvider('reward', require('../modules/economy/reward.js'));
+const db = require('../modules/lifecycle/db.js');
+
+const VER = 'ZZZ-OB', WORKER = 90000301, TRAP = 90000302, CONTROL = 90000303, BLOCKER = 90000304;
+const q = (sql, params) => pool.query(sql, params).then((r) => r.rows);
+
+async function cleanup() {
+  await q(`DELETE FROM builder_achievements WHERE builder_id=$1`, [WORKER]).catch(() => {});
+  await q(`DELETE FROM credit_log WHERE builder_id=$1 OR task_id = ANY($2::bigint[])`, [WORKER, [TRAP, CONTROL]]).catch(() => {});
+  await q(`DELETE FROM claims WHERE task_id = ANY($1::bigint[])`, [[TRAP, CONTROL]]).catch(() => {});
+  await q(`DELETE FROM task_blockers WHERE task_id = ANY($1::bigint[])`, [[TRAP, CONTROL]]).catch(() => {});
+  await q(`DELETE FROM blockers WHERE id=$1`, [BLOCKER]).catch(() => {});
+  await q(`DELETE FROM tasks WHERE id = ANY($1::bigint[])`, [[TRAP, CONTROL]]).catch(() => {});
+  await q(`DELETE FROM builders WHERE id=$1`, [WORKER]).catch(() => {});
+  await q(`DELETE FROM versions WHERE id=$1`, [VER]).catch(() => {});
+}
+
+let pass = 0;
+const ok = (cond, msg) => { assert.ok(cond, msg); console.log(`  ok  ${msg}`); pass++; };
+
+try {
+  await cleanup();
+  await q(`INSERT INTO versions (id,name,status,track) VALUES ($1,'ob','planning','internal') ON CONFLICT (id) DO NOTHING`, [VER]);
+  // Archon so no rank/newcomer gate interferes; the gate under test is OPEN_BLOCKER.
+  await q(`INSERT INTO builders (id,github_id,github_login,display_name,rank) VALUES ($1,'ob-w','ob-worker','OB Worker','archon')`, [WORKER]);
+  // TRAP: ready (feed-hidden) with an open blocker linked. CONTROL: ready, clean.
+  await q(`INSERT INTO tasks (id,version_id,title,status,credits_reward,kind) VALUES ($1,$2,'trap','ready',10,'feature')`, [TRAP, VER]);
+  await q(`INSERT INTO tasks (id,version_id,title,status,credits_reward,kind) VALUES ($1,$2,'control','ready',10,'feature')`, [CONTROL, VER]);
+  await q(`INSERT INTO blockers (id,title,status) VALUES ($1,'Owner must flip the switch','open')`, [BLOCKER]);
+  await q(`INSERT INTO task_blockers (task_id,blocker_id) VALUES ($1,$2)`, [TRAP, BLOCKER]);
+
+  // 1) Direct claim-by-id is refused with OPEN_BLOCKER, naming the blocker.
+  let threw = null;
+  try {
+    await db.claimTask({ taskId: String(TRAP), builderId: String(WORKER), worktreeName: 'ob-trap' });
+  } catch (e) { threw = e; }
+  ok(threw && threw.code === 'OPEN_BLOCKER', `claim refused with OPEN_BLOCKER (got ${threw && (threw.code || threw.message)})`);
+  ok(Array.isArray(threw.blockers) && threw.blockers.some((b) => Number(b.id) === BLOCKER),
+    'the 409 names the blocker id');
+  ok(threw.blockers.every((b) => typeof b.title === 'string' && b.title.length > 0),
+    'each named blocker carries its title (the wave-5 speech payload)');
+  const trapStatus = (await q(`SELECT status FROM tasks WHERE id=$1`, [TRAP]))[0].status;
+  ok(trapStatus === 'ready', 'the refused task stays ready (no partial claim)');
+
+  // 2) The batch path enforces the same rule — no sidestep via /builder-sequence.
+  let batchThrew = null;
+  try {
+    await db.claimTasksBatch({ taskIds: [TRAP, CONTROL], builderId: String(WORKER), worktreePrefix: 'ob-batch' });
+  } catch (e) { batchThrew = e; }
+  ok(batchThrew && batchThrew.code === 'BATCH_FAILED', `batch claim refused (got ${batchThrew && (batchThrew.code || batchThrew.message)})`);
+  ok((batchThrew.failures || []).some((f) => Number(f.task_id) === TRAP && f.reason === 'OPEN_BLOCKER'),
+    'the batch failure names the trapped task with reason OPEN_BLOCKER');
+
+  // 3) Resolving the blocker opens the gate.
+  await q(`UPDATE blockers SET status='resolved', resolved_at=now() WHERE id=$1`, [BLOCKER]);
+  const claim = await db.claimTask({ taskId: String(TRAP), builderId: String(WORKER), worktreeName: 'ob-trap' });
+  ok(claim && claim.id && Number(claim.task_id) === TRAP, 'claim succeeds once the blocker is resolved');
+
+  console.log(`\nclaim_gate_open_blocker (task 1002650): ${pass} passed, 0 failed`);
+} catch (e) {
+  console.error('claim_gate_open_blocker.mjs FAILED:', e.stack || e.message);
+  process.exitCode = 1;
+} finally {
+  await cleanup();
+  await pool.end();
+}