@bongos/core 1.19.339 → 1.19.340

package/tests/projects_hub.mjs

@@ -293,7 +293,7 @@ test('the new view balances its own tree — the map-only walkers never covered
   // lives there too; a lopsided div in the wizard block would be caught by
   // nothing else while silently reparenting the footer.
   const start = HUB.indexOf('<section id="view-new"');
-  const end = HUB.indexOf('<div class="foot"');
+  const end = HUB.indexOf('<footer class="foot"');
   assert.ok(start !== -1 && end > start, 'need the view-new span');
   const wiz = HUB.slice(start, end);
   assert.equal((wiz.match(/<div\b/g) || []).length, (wiz.match(/<\/div>/g) || []).length,

package/tests/projects_hub_pre_uat.mjs

@@ -69,14 +69,14 @@ test('a queued standup lights "Request filed", not "Standing it up" — on the c
   const strip = fn('stripFor');
   assert.match(strip, /if \(s === 'requested'\) \{[\s\S]*?stripMarkup\(revive \? 'revive' : 'standup', 0, 0,/, 'card: requested → stage 0 current');
   assert.match(strip, /if \(s === 'provisioning'\) \{[\s\S]*?stripMarkup\(revive \? 'revive' : 'standup', 1, 1,/, 'card: provisioning → stage 1 current');
-  assert.match(SCRIPT, /if \(s === 'requested'\) \{\n\s*el\.innerHTML = progressMarkup\(0, 0,/, 'done panel: requested → stage 0 current');
+  assert.match(SCRIPT, /if \(s === 'requested'\) \{\n\s*setProgress\(progressMarkup\(0, 0,/, 'done panel: requested → stage 0 current');
   assert.doesNotMatch(SCRIPT, /Waiting for a runner/, '"runner" is operator vocabulary');
   assert.doesNotMatch(SCRIPT, /a runner picks it up/, '"runner" is operator vocabulary (retry message)');
 });
 
 /* ── the done panel never lies at the end of its watch, and never opens a door early ── */
 test('the 33-minute hand-off keeps a snag honest and keeps its flow', () => {
-  assert.match(SCRIPT, /if \(ticks > 400\) \{[\s\S]*?if \(live\.instStatus !== 'error'\) \{[\s\S]*?Still working[\s\S]*?watchFlow\);/, 'no "still building" over an error; the strip keeps its vocabulary');
+  assert.match(SCRIPT, /if \(ticks > 400\) \{[\s\S]*?if \(live\.instStatus !== 'error'\) \{[\s\S]*?Still working[\s\S]*?watchFlow\)/, 'no "still building" over an error; the strip keeps its vocabulary');
   assert.doesNotMatch(SCRIPT, /Still building — this tab will stop watching now/);
   assert.match(SCRIPT, /progressMarkup\(1, 1, m\.slice\(5\), 'isErr', watchFlow\)/, 'the session-expiry message keeps its flow too');
 });
@@ -190,7 +190,7 @@ test('a live private-repo project is not told it is broken', () => {
 test('Back moves between views — a deliberate view change is a history entry', () => {
   assert.match(SCRIPT, /history\.pushState\(null, '', '\?view=' \+ v \+ idPart\)/);
   assert.match(SCRIPT, /history\.replaceState\(null, '', '\?view=' \+ v \+ idPart\)/, 'boot + background settles still rewrite in place');
-  assert.match(SCRIPT, /window\.addEventListener\('popstate', function \(\) \{ setView\(viewFromUrl\(\)\); \}\)/);
+  assert.match(SCRIPT, /window\.addEventListener\('popstate', function \(\) \{ closeCard\(\); setView\(viewFromUrl\(\)\); \}\)/);
   assert.match(SCRIPT, /else if \(v === 'manage' && a\.dataset\.nav === 'mine'\) a\.setAttribute\('aria-current', 'page'\)/, 'manage keeps the Your-projects pill lit');
 });
 
@@ -300,7 +300,7 @@ test('decision 9 — only mouse-driven focus on a wizard heading goes ringless',
 
 test('decision 10 — both footers carry the open-source (AGPL-3.0) link, in link ink', () => {
   const AGPL = /<a href="https:\/\/www\.gnu\.org\/licenses\/agpl-3\.0\.html" target="_blank" rel="noopener">Open source \(AGPL-3\.0\)<\/a>\./;
-  const hubFoot = (HUB.match(/<div class="foot">[\s\S]*?<\/div>/) || [''])[0];
+  const hubFoot = (HUB.match(/<footer class="foot">[\s\S]*?<\/footer>/) || [''])[0];
   const indexFoot = (INDEX.match(/<div class="foot">[\s\S]*?<\/div>/) || [''])[0];
   assert.match(hubFoot, AGPL, 'projects.html');
   assert.match(indexFoot, AGPL, 'index.html');
@@ -362,3 +362,84 @@ test('card action results announce, nothing under the pointer is deleted, and fo
   assert.match(fn('focusKeyOf'), /data-teardown-yes'\) \|\| el\.hasAttribute\('data-teardown-no'\)\) return '\[data-teardown\]'/, 'Yes / Keep land back on the door that opened them');
   assert.match(fn('focusCardControl'), /li\.querySelector\('\.actions a, \.actions button'\) \|\|\n\s*li\.querySelector\('details\.attachFold summary'\)/, 'nearest control as the fallback');
 });
+
+/* ── accessibility follow-ups (task 1003246) ── */
+test('the done panel’s progress region is stable, change-only, and says each stage’s state', () => {
+  assert.match(HUB, /<div id="liveProgress" role="status" aria-live="polite"><\/div>/, 'the live region is the static wrapper');
+  assert.doesNotMatch(fn('progressMarkup'), /aria-live/, 'the rebuilt strip carries no live-region attributes');
+  assert.match(fn('progressMarkup'), /\(c === 'now' \? ' aria-current="step"' : ''\)/, 'the current stage is marked');
+  assert.match(fn('progressMarkup'), /<span class="vh">, ' \+ word \+ '<\/span>/, 'each stage says its state to a screen reader');
+  assert.match(fn('setProgress'), /if \(!el \|\| html === lastProgHtml\) return;/, 'an identical tick performs no DOM write');
+  assert.doesNotMatch(SCRIPT, /\$\('liveProgress'\)\.innerHTML =/, 'every write goes through setProgress');
+  assert.doesNotMatch(fn('renderProgress'), /el\.innerHTML =/, 'renderProgress included');
+  assert.match(SCRIPT, /lastStepsHtml = '';\n\s*lastProgHtml = '';/, 'starting another project resets both guards');
+  assert.match(COSMOS, /\.vh\{position:absolute;width:1px;height:1px;overflow:hidden;clip-path:inset\(50%\);white-space:nowrap;\}/, 'the visually-hidden utility is in cosmos');
+  assert.match(fn('stripMarkup'), /role="status" aria-live="polite"/, 'the mine-card strip is left alone this pass');
+});
+
+test('the map table sorts from the keyboard and an owned row’s name is a real link', () => {
+  assert.match(HUB, /<th class="colName" data-sort="name" aria-sort="ascending"><button type="button" class="thSort">Project<\/button><\/th>/);
+  assert.match(HUB, /<th class="right" data-sort="builders"><button type="button" class="thSort">Builders<\/button><\/th>/);
+  assert.match(SCRIPT, /var btn = th\.querySelector\('button'\);\n\s*if \(!btn\) return;\n\s*btn\.addEventListener\('click'/, 'the listener sits on the button, not the th');
+  assert.doesNotMatch(SCRIPT, /th\.style\.cursor/, 'no JS-set cursor on the th');
+  assert.match(COSMOS, /\.tbl th button\{all:unset;cursor:pointer;\}/);
+  assert.match(COSMOS, /\.tbl th button:focus-visible\{outline:2px solid var\(--accent\);outline-offset:2px;\}/, 'keyboard focus on the sort button is visible');
+  const generated = (SCRIPT.match(/return '<tr data-generated([\s\S]*?)'<\/tr>';/) || [, ''])[1];
+  assert.match(generated, /<a class="ptitle" data-manage="' \+ esc\(String\(p\._inst\.id\)\) \+ '" href="\?view=manage&id=' \+ esc\(String\(p\._inst\.id\)\) \+ '">/, 'an owned row’s title is a manage anchor');
+  const rows = SCRIPT.slice(SCRIPT.indexOf("$('mapRows').addEventListener('click'"));
+  const branch = rows.indexOf("closest('a[data-manage]')");
+  const bail = rows.indexOf("if (ev.target.closest && ev.target.closest('a')) return;");
+  assert.ok(branch > 0 && bail > branch, 'the manage branch runs before the anchor bail-out');
+  assert.match(HUB, /Sort by Project or Builders\./, 'the hint names the two sortable columns');
+  assert.match(COSMOS, /\.tbl \.ptitle\{[^}]*text-decoration:none;\}/, 'the link wears the title’s ink, not the UA underline');
+});
+
+test('the hub has one main landmark, a heading for the map, a footer, and a skip link', () => {
+  const main = HUB.indexOf('<main id="hubMain">');
+  const map = HUB.indexOf('<section id="view-map">');
+  const close = HUB.indexOf('\n</main>');
+  const foot = HUB.indexOf('<footer class="foot">');
+  assert.ok(main > 0 && main < map && close > HUB.indexOf('<section id="view-new"') && foot > close, 'the four views sit inside #hubMain, the footer after it');
+  assert.equal((HUB.match(/<main\b/g) || []).length, 1, 'exactly one main');
+  assert.match(HUB, /<section id="view-map">\n\s*<h1 class="vh">The project map<\/h1>/, 'the map view has a heading');
+  assert.match(HUB, /<a class="skip vh" href="#hubMain">Skip to content<\/a>\n<header class="shell">/, 'the skip link is the first thing before the shell');
+  assert.match(HUB, /\.skip:focus\{position:fixed;top:8px;left:8px;/, 'it becomes a real pill on focus');
+  assert.doesNotMatch(HUB, /<main class="card">/, 'the old inner main is a div');
+});
+
+test('completed rail steps are a way back, the repo picker is honest ARIA, the card inerts the page', () => {
+  assert.match(fn('paintRail'), /if \(step < 6 && n < cur\) \{\n\s*li\.setAttribute\('role', 'button'\);\n\s*li\.setAttribute\('tabindex', '0'\);\n\s*li\.setAttribute\('data-goto', String\(n\)\);/, 'only answered steps become buttons, and none once the project is filed');
+  assert.match(SCRIPT, /railEl\.addEventListener\('click'/);
+  assert.match(SCRIPT, /railEl\.addEventListener\('keydown'/);
+  assert.match(SCRIPT, /show\(Number\(li\.getAttribute\('data-goto'\)\), true\)/, 'a deliberate step: focus moves');
+  assert.match(COSMOS, /\.steps li\[role=button\]\{cursor:pointer;\}/);
+  assert.match(COSMOS, /\.steps li\[role=button\]:focus-visible\{outline:2px solid var\(--accent\);/);
+  assert.doesNotMatch(HUB, /role="listbox"/);
+  assert.doesNotMatch(SCRIPT, /role="option"/);
+  assert.match(HUB, /<div id="ghList" class="ghlist" role="group" aria-label="Your repositories"><\/div>/, 'the label survives the listbox role');
+  assert.match(SCRIPT, /class="ghrow" data-full="' \+ esc\(r\.full_name\) \+ '" aria-current="' \+ \(r\.full_name === sel\) \+ '"/, 'the chosen row is aria-current');
+  assert.match(HUB, /\.ghrow\[aria-current=true\]\{/, 'and painted through it');
+  assert.doesNotMatch(HUB, /aria-selected/, 'aria-selected went with the option role');
+  assert.match(SCRIPT, /if \(ev\.key !== 'Escape' \|\| \$\('ghList'\)\.hidden\) return;\n\s*ev\.stopPropagation\(\);\n\s*\$\('ghSearch'\)\.focus\(\);\n\s*closeRepoList\(\);/, 'Escape closes the list after handing focus back');
+  assert.match(SCRIPT, /if \(ev\.relatedTarget && !\$\('ghAdopt'\)\.contains\(ev\.relatedTarget\)\) closeRepoList\(\);/, 'focus leaving the picker closes it; a null relatedTarget is left alone');
+  assert.match(fn('openCard'), /\$\('cardScrim'\)\.hidden = false;\n\s*pageInert\(true\);\n\s*\$\('cardClose'\)\.focus\(\);/);
+  assert.match(fn('closeCard'), /pageInert\(false\);[^\n]*\n\s*if \(cardReturn && cardReturn\.focus\) cardReturn\.focus\(\);/, 'inert is lifted before focus is handed back');
+  assert.match(fn('pageInert'), /'a\.skip, header\.shell, footer\.foot, #view-mine, #view-new, #view-manage, #view-map > :not\(#cardScrim\)'/, 'the map is inerted a child at a time — the card is its child; the skip link sits outside the shell and goes too');
+  assert.match(SCRIPT, /'popstate', function \(\) \{ closeCard\(\); setView\(viewFromUrl\(\)\); \}/, 'Back closes the card, so the page is never left inert');
+  assert.equal((HUB.match(/aria-controls="projectsList"/g) || []).length, 5, 'the five state filters name the list they filter');
+});
+
+test('control nits: orb cursor, caret under reduced motion, mode label, home label, held reduce-motion query, target sizes', () => {
+  assert.doesNotMatch(COSMOS, /\.orb\{flex:0 0 54px;[^}]*cursor:pointer/, 'the base orb is not a pointer');
+  assert.match(COSMOS, /\na\.orb\{cursor:pointer;\}/, 'only the linked orb is');
+  assert.doesNotMatch(COSMOS, /\.orb\.ghost\{[^}]*cursor:default/);
+  assert.match(HUB, /@media \(prefers-reduced-motion:reduce\)\{\.shell \.caret\{display:none;\}\}/, 'the caret hides instead of freezing solid');
+  assert.match(fn('paintModeToggle'), /el\.setAttribute\('aria-label', dark \? 'Switch to light mode' : 'Switch to dark mode'\);/);
+  assert.doesNotMatch(fn('paintModeToggle'), /aria-pressed/);
+  assert.match(SCRIPT, /\$\('markLeft'\)\.parentNode\.setAttribute\('aria-label', productName \+ ' — home'\);\n\s*if \(REDUCED \|\|/, 'the home link is labelled before the typing loop’s early return');
+  assert.match(SCRIPT, /var REDUCED_MQ = window\.matchMedia \? window\.matchMedia\('\(prefers-reduced-motion: reduce\)'\) : null;/);
+  assert.match(SCRIPT, /if \(REDUCED\) stopSky\(\); else startSky\(\);/, 'a mid-session flip stops or restarts the sky');
+  assert.match(SCRIPT, /REDUCED_MQ\.addEventListener\('change', onReducedChange\)/);
+  assert.match(HUB, /\.again\{[^}]*padding:6px 2px;min-height:24px;/);
+  assert.match(HUB, /\nsummary\{min-height:24px;padding:3px 0;\}/, 'every fold is a 24px target; the disclosure marker stays');
+});