@bongos/core 1.19.337 → 1.19.339

package/modules/lifecycle/routes/goals.js

@@ -62,6 +62,8 @@ const JOIN_REQUEST_RESPONSE_ACTIONS = ['approve', 'deny']; // an owner/manager/A
 // membership half of the wall; the protected-module rank check is enforced per-route
 // (scope is never self-granted).
 const { authorizeCreateJoinRequest, authorizeGoalTaskCreate, authorizeInvitationAccept, authorizeInvitationResponse, authorizeJoinRequestResponse, authorizeMembershipKindChange, authorizeOwnershipTransfer, authorizeWithdrawJoinRequest, decorateGoalScope, isMemberOrArchon, protectedScopeAdmissionBlock } = require('./goal-route-authz.js');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = api.logger('lifecycle');
 module.exports = function buildGoalsRouter() {
   const router = express.Router();
 
@@ -118,7 +120,7 @@ module.exports = function buildGoalsRouter() {
       }
       return res.status(201).json({ ok: true, goal, succeeds_goal_id: succeedsId });
     } catch (err) {
-      console.error('[gds] POST /goals', err);
+      log.error('[gds] POST /goals', err);
       return res.fail('goal_create_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -134,7 +136,7 @@ module.exports = function buildGoalsRouter() {
       const goals = await db.listGoals({ versionId: version || null, status: status || null });
       return res.json({ goals: goals.map(decorateGoalScope) });
     } catch (err) {
-      console.error('[gds] GET /goals', err);
+      log.error('[gds] GET /goals', err);
       return res.fail('list_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -165,7 +167,7 @@ module.exports = function buildGoalsRouter() {
       if (err && err.code === 'SET_MISMATCH') {
         return res.fail('set_mismatch', { status: 400, message: err.message });
       }
-      console.error('[gds] POST /goals/reorder', err);
+      log.error('[gds] POST /goals/reorder', err);
       return res.fail('reorder_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -190,7 +192,7 @@ module.exports = function buildGoalsRouter() {
       const inbox = await db.listInboxFor(req.builder.id);
       return res.json(inbox);
     } catch (err) {
-      console.error('[gds] GET /goals/inbox', err);
+      log.error('[gds] GET /goals/inbox', err);
       return res.fail('inbox_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -210,7 +212,7 @@ module.exports = function buildGoalsRouter() {
       ]);
       return res.json({ goal: decorateGoalScope(goal), members, criteria, dependencies });
     } catch (err) {
-      console.error('[gds] GET /goals/:id', err);
+      log.error('[gds] GET /goals/:id', err);
       return res.fail('fetch_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -254,7 +256,7 @@ module.exports = function buildGoalsRouter() {
       const member = await db.addGoalMember({ goalId: id, builderId: req.builder.id, membershipKind: 'member', resolvedBy: req.builder.id });
       return res.status(201).json({ ok: true, member });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/join', err);
+      log.error('[gds] POST /goals/:id/join', err);
       return res.fail('join_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -269,7 +271,7 @@ module.exports = function buildGoalsRouter() {
       if (!removed) return res.fail('not_a_member', 409);
       return res.json({ ok: true });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/leave', err);
+      log.error('[gds] POST /goals/:id/leave', err);
       return res.fail('leave_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -309,7 +311,7 @@ module.exports = function buildGoalsRouter() {
       if (err && err.code === 'PENDING_EXISTS') {
         return res.fail('request_pending', { status: 409, message: 'You already have a pending request or invitation for this goal.' });
       }
-      console.error('[gds] POST /goals/:id/requests', err);
+      log.error('[gds] POST /goals/:id/requests', err);
       return res.fail('request_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -371,7 +373,7 @@ module.exports = function buildGoalsRouter() {
       if (!outcome) return res.fail('not_pending', { status: 409, message: 'The request changed underneath this response — re-read and retry.' });
       return res.json({ ok: true, action, request: outcome.request, member: outcome.member });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/requests/:reqId/respond', err);
+      log.error('[gds] POST /goals/:id/requests/:reqId/respond', err);
       return res.fail('request_respond_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -430,7 +432,7 @@ module.exports = function buildGoalsRouter() {
       if (err && err.code === 'PENDING_EXISTS') {
         return res.fail('invite_pending', { status: 409, message: 'That builder already has a pending invitation or request for this goal.' });
       }
-      console.error('[gds] POST /goals/:id/invitations', err);
+      log.error('[gds] POST /goals/:id/invitations', err);
       return res.fail('invite_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -478,7 +480,7 @@ module.exports = function buildGoalsRouter() {
       if (!outcome) return res.fail('not_pending', { status: 409, message: 'The invitation changed underneath this response — re-read and retry.' });
       return res.json({ ok: true, action, request: outcome.request, member: outcome.member });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/invitations/:reqId/respond', err);
+      log.error('[gds] POST /goals/:id/invitations/:reqId/respond', err);
       return res.fail('invitation_respond_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -506,7 +508,7 @@ module.exports = function buildGoalsRouter() {
       const requests = await db.listPendingRequestsForGoal(id);
       return res.json({ requests });
     } catch (err) {
-      console.error('[gds] GET /goals/:id/requests', err);
+      log.error('[gds] GET /goals/:id/requests', err);
       return res.fail('fetch_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -529,7 +531,7 @@ module.exports = function buildGoalsRouter() {
       if (!resolved) return res.fail('not_pending', { status: 409, message: 'The request changed underneath this withdrawal — re-read and retry.' });
       return res.json({ ok: true, request: resolved });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/requests/:reqId/withdraw', err);
+      log.error('[gds] POST /goals/:id/requests/:reqId/withdraw', err);
       return res.fail('withdraw_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -598,7 +600,7 @@ module.exports = function buildGoalsRouter() {
       const member = await db.addGoalMember({ goalId: id, builderId, membershipKind, resolvedBy: req.builder.id });
       return res.status(201).json({ ok: true, member });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/members', err);
+      log.error('[gds] POST /goals/:id/members', err);
       return res.fail('add_member_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -659,7 +661,7 @@ module.exports = function buildGoalsRouter() {
       }
       return res.json({ ok: true, member, changed: true });
     } catch (err) {
-      console.error('[gds] PATCH /goals/:id/members/:builderId', err);
+      log.error('[gds] PATCH /goals/:id/members/:builderId', err);
       return res.fail('membership_change_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -704,7 +706,7 @@ module.exports = function buildGoalsRouter() {
       }
       return res.json({ ok: true, goal: updated, changed: true });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/transfer', err);
+      log.error('[gds] POST /goals/:id/transfer', err);
       return res.fail('transfer_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -749,7 +751,7 @@ module.exports = function buildGoalsRouter() {
         cross_goals_considered: crossGoal.map((c) => ({ id: Number(c.goal.id), title: c.goal.title })),
       });
     } catch (err) {
-      console.error('[gds] GET /goals/:id/conflicts', err);
+      log.error('[gds] GET /goals/:id/conflicts', err);
       return res.fail('conflicts_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -891,7 +893,7 @@ module.exports = function buildGoalsRouter() {
         requires_rank: updated.requires_rank,
       });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/conflicts/resolve', err);
+      log.error('[gds] POST /goals/:id/conflicts/resolve', err);
       return res.fail('conflict_resolve_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -915,7 +917,7 @@ module.exports = function buildGoalsRouter() {
       const updated = await db.setGoalStatus({ goalId: id, status: 'archived' });
       return res.json({ ok: true, goal: updated });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/archive', err);
+      log.error('[gds] POST /goals/:id/archive', err);
       return res.fail('archive_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -938,7 +940,7 @@ module.exports = function buildGoalsRouter() {
       const updated = await db.setGoalStatus({ goalId: id, status: 'open' });
       return res.json({ ok: true, goal: updated });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/reopen', err);
+      log.error('[gds] POST /goals/:id/reopen', err);
       return res.fail('reopen_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -982,7 +984,7 @@ module.exports = function buildGoalsRouter() {
       const updated = await db.addGoalScopeModules({ goalId: id, modules: add });
       return res.json({ ok: true, goal: updated });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/scope', err);
+      log.error('[gds] POST /goals/:id/scope', err);
       return res.fail('scope_widen_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -1116,7 +1118,7 @@ module.exports = function buildGoalsRouter() {
           const updated = await hierarchy.attachParent(task.id, parentTaskId);
           attachedParentId = updated.parent_task_id != null ? Number(updated.parent_task_id) : null;
         } catch (err) {
-          console.error('[gds] POST /goals/:id/tasks attachParent', err);
+          log.error('[gds] POST /goals/:id/tasks attachParent', err);
           return res.fail('parent_attach_failed', { status: 409, message: `Task #${task.id} was created under the goal, but attaching it under parent #${parentTaskId} failed (${(err && err.code) || 'unknown'}).`, details: { code: err && err.code, task } });
         }
       }
@@ -1130,7 +1132,7 @@ module.exports = function buildGoalsRouter() {
         requires_rank: task.requires_rank,
       });
     } catch (err) {
-      console.error('[gds] POST /goals/:id/tasks', err);
+      log.error('[gds] POST /goals/:id/tasks', err);
       return res.fail('goal_task_create_failed', { status: 500, message: 'internal error' });
     }
   });

package/modules/lifecycle/routes/task-write-routes.js

@@ -26,6 +26,8 @@ const { classifyTaskKind, VALID_KINDS, VALID_DISCIPLINES, VOTABLE_TASK_STATUSES,
 const { isModuleKey, moduleKeys } = api.moduleScopeMap;
 const { validateOrRespond, LIMITS, parseId } = api;
 const { badKind, detectsMigration } = require('./task-route-helpers.js');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = api.logger('lifecycle');
 
 module.exports = function registerTaskWriteRoutes(router) {
   // Task create/promote/edit (plan/scope mutation) is Metic+ as of ADR 0090
@@ -225,7 +227,7 @@ module.exports = function registerTaskWriteRoutes(router) {
             { limit: 3 }
           );
         } catch (e) {
-          console.error('[gds] POST /tasks suggest-criteria (non-blocking)', e && e.message);
+          log.error('[gds] POST /tasks suggest-criteria (non-blocking)', e && e.message);
         }
       }
       // task 1002539 — the orphan-task advisory (the /goal-create auto-pickup
@@ -241,7 +243,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         goal_advisory, est_advisory: await require('../est-advisory').buildEstAdvisory({ db, task }), // task 1003148
       });
     } catch (err) {
-      console.error('[gds] POST /tasks', err);
+      log.error('[gds] POST /tasks', err);
       res.fail('create_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -386,7 +388,7 @@ module.exports = function registerTaskWriteRoutes(router) {
           return res.fail('goal_version_mismatch', { status: 409, message: `Goal #${goalId} is in version '${goal.version_id}' but task #${id} is in '${task.version_id}'. A task can only join a goal in its own version.` });
         }
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id goal_id', err);
+        log.error('[gds] PATCH /tasks/:id goal_id', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -424,7 +426,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskParallelSafe(id, body.parallel_safe);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id parallel_safe', err);
+        log.error('[gds] PATCH /tasks/:id parallel_safe', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -433,7 +435,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskSecuritySensitive(id, body.security_sensitive);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id security_sensitive', err);
+        log.error('[gds] PATCH /tasks/:id security_sensitive', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -442,7 +444,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskAutomationTag(id, body.automation_tag);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id automation_tag', err);
+        log.error('[gds] PATCH /tasks/:id automation_tag', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -451,7 +453,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskNeedsMigration(id, body.needs_migration);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id needs_migration', err);
+        log.error('[gds] PATCH /tasks/:id needs_migration', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -460,7 +462,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskModuleKey(id, body.module_key ?? null);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id module_key', err);
+        log.error('[gds] PATCH /tasks/:id module_key', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -469,7 +471,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskDescription(id, body.description);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id description', err);
+        log.error('[gds] PATCH /tasks/:id description', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -478,7 +480,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskGoal(id, body.goal_id);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id goal_id', err);
+        log.error('[gds] PATCH /tasks/:id goal_id', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -487,7 +489,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskRequiresRank(id, body.requires_rank);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id requires_rank', err);
+        log.error('[gds] PATCH /tasks/:id requires_rank', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -496,7 +498,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskKind(id, body.kind);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id kind', err);
+        log.error('[gds] PATCH /tasks/:id kind', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -505,7 +507,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskDiscipline(id, body.discipline);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id discipline', err);
+        log.error('[gds] PATCH /tasks/:id discipline', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -515,7 +517,7 @@ module.exports = function registerTaskWriteRoutes(router) {
         updated = await db.updateTaskNewcomerFriendly(id, incoming);
         if (!updated) return res.fail('task_not_found', 404);
       } catch (err) {
-        console.error('[gds] PATCH /tasks/:id newcomer_friendly', err);
+        log.error('[gds] PATCH /tasks/:id newcomer_friendly', err);
         return res.fail('patch_failed', { status: 500, message: 'internal error' });
       }
     }
@@ -535,7 +537,7 @@ module.exports = function registerTaskWriteRoutes(router) {
           500;
         return res.fail(err.code, status, { ...err });
       }
-      console.error('[gds] PATCH /tasks/:id', err);
+      log.error('[gds] PATCH /tasks/:id', err);
       res.fail('patch_failed', { status: 500, message: 'internal error' });
     }
   });

package/modules/lifecycle/routes/tasks.js

@@ -42,6 +42,8 @@ const PUBLISH_BUNDLE_MAX_BYTES = 20 * 1024 * 1024; // 20 MB decoded bundle
 // Mirrors ship.js sanitizeGitHubRefs (which lives in scripts/ and isn't requirable
 // here).
 const { MIGRATION_KEYWORD_RE, VALID_FITS, badKind, deHashRefs, detectsMigration, gateTaskOwnership, graderBypassEnabled, isVerifyTask, peerVoteNet, postGateAuthorTrust, rankAttestsGateTrust } = require('./task-route-helpers.js');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = api.logger('lifecycle');
 const registerTaskWriteRoutes = require('./task-write-routes.js'); // task 1003206 — POST /tasks + PATCH /tasks/:id
 module.exports = function buildTasksRouter() {
   const router = express.Router();
@@ -146,7 +148,7 @@ module.exports = function buildTasksRouter() {
       }
       res.json({ disciplines });
     } catch (err) {
-      console.error('[gds] GET /tasks/newcomer-floor', err);
+      log.error('[gds] GET /tasks/newcomer-floor', err);
       res.fail('newcomer_floor_failed', 500);
     }
   });
@@ -167,7 +169,7 @@ module.exports = function buildTasksRouter() {
       const stamped = results.reduce((n, r) => n + (Array.isArray(r.stamped) ? r.stamped.length : 0), 0);
       res.json({ ok: true, stamped, results });
     } catch (err) {
-      console.error('[gds] POST /tasks/newcomer-restock', err);
+      log.error('[gds] POST /tasks/newcomer-restock', err);
       res.fail('newcomer_restock_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -470,7 +472,7 @@ module.exports = function buildTasksRouter() {
       if (err.code === 'TASK_NOT_CONFIRMED') {
         return res.fail('task_not_confirmed', 409);
       }
-      console.error('[gds] POST /tasks/:id/ship', err);
+      log.error('[gds] POST /tasks/:id/ship', err);
       res.fail('ship_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -522,7 +524,7 @@ module.exports = function buildTasksRouter() {
           `actually passed, with { "verified": true }. Re-run /builder-ship ${id} --verified once it has.` });
     }
     if (graderBypassEnabled()) {
-      console.log(`[gds] grader-bypass confirm: builder ${req.builder.id} (${req.builder.rank}) confirming task ${id} with GRADER_BYPASS_ENABLED on`);
+      log.info(`[gds] grader-bypass confirm: builder ${req.builder.id} (${req.builder.rank}) confirming task ${id} with GRADER_BYPASS_ENABLED on`);
     }
     try {
       const result = await db.confirmTask({ taskId: id, builderId: req.builder.id });
@@ -531,7 +533,7 @@ module.exports = function buildTasksRouter() {
       if (err.code === 'TASK_NOT_COMPLETED') {
         return res.fail('task_not_completed', 409);
       }
-      console.error('[gds] POST /tasks/:id/confirm', err);
+      log.error('[gds] POST /tasks/:id/confirm', err);
       res.fail('confirm_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -569,7 +571,7 @@ module.exports = function buildTasksRouter() {
       if (err.code === 'TASK_HAS_ACTIVE_CLAIM') {
         return res.fail('task_has_active_claim', { status: 409, message: 'release the active claim before abandoning' });
       }
-      console.error('[gds] POST /tasks/:id/abandon', err);
+      log.error('[gds] POST /tasks/:id/abandon', err);
       res.fail('abandon_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -615,7 +617,7 @@ module.exports = function buildTasksRouter() {
     } catch (err) {
       // Log the detail server-side; don't return err.message — a raw Postgres
       // error can leak schema internals (table/column/constraint names).
-      console.error('[gds] GET /tasks/peer-votes/feed', err);
+      log.error('[gds] GET /tasks/peer-votes/feed', err);
       res.fail('feed_failed', 500);
     }
   });
@@ -636,7 +638,7 @@ module.exports = function buildTasksRouter() {
       const result = await db.tallyPeerVotes();
       res.json(result);
     } catch (err) {
-      console.error('[gds] POST /tasks/peer-votes/tally', err);
+      log.error('[gds] POST /tasks/peer-votes/tally', err);
       res.fail('tally_failed', 500);
     }
   });
@@ -717,7 +719,7 @@ module.exports = function buildTasksRouter() {
       const { net, total } = await peerVoteNet(id);
       res.json({ ok: true, task_id: id, my_vote: vote === 0 ? null : vote, net_votes: net, total_votes: total });
     } catch (err) {
-      console.error('[gds] POST /tasks/:id/vote', err);
+      log.error('[gds] POST /tasks/:id/vote', err);
       res.fail('vote_failed', 500);
     }
   });
@@ -819,7 +821,7 @@ module.exports = function buildTasksRouter() {
       if (err.code === 'TASK_NOT_GRADABLE') {
         return res.fail('task_not_gradable', 409, { current_status: err.current_status });
       }
-      console.error('[gds] POST /tasks/:id/grade', err);
+      log.error('[gds] POST /tasks/:id/grade', err);
       res.fail('grade_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -860,7 +862,7 @@ module.exports = function buildTasksRouter() {
       if (err.code === 'OPEN_REQUEST_EXISTS') {
         return res.fail('open_request_exists', 409);
       }
-      console.error('[gds] POST /tasks/:id/override-request', err);
+      log.error('[gds] POST /tasks/:id/override-request', err);
       res.fail('override_request_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -962,7 +964,7 @@ module.exports = function buildTasksRouter() {
       try {
         await db.setClaimPublishedSha({ taskId: id, builderId: req.builder.id, sha: pushedSha });
       } catch (e) {
-        console.error('[gds] setClaimPublishedSha (non-blocking)', id, e && e.message);
+        log.error('[gds] setClaimPublishedSha (non-blocking)', id, e && e.message);
       }
       return res.status(201).json({
         ok: true, pr_url: pr.url, pr_number: pr.number, head_sha: pushedSha, auto_merge: autoMerge,
@@ -983,7 +985,7 @@ module.exports = function buildTasksRouter() {
       // is a one-line diagnosis, not a multi-hour opaque-`publish_failed` mystery
       // (the BV1.R04/R05 incident: ~2h of bare GIT_FAILED with no cause). Return the
       // step + a short scrubbed reason to the (ownership-gated) builder too.
-      console.error(
+      log.error(
         '[gds] POST /tasks/:id/publish-branch', e.code || e.message,
         e.git_step ? `step=${e.git_step}` : '',
         e.stderr ? `stderr=${e.stderr}` : ''
@@ -1026,7 +1028,7 @@ module.exports = function buildTasksRouter() {
         const proof = await githubPush.landProvenForTask({ taskId: id, publishedSha, status });
         if (!proof.proven) {
           reconcile_blocked = proof.reason;
-          console.warn(`[gds] publish-status reconcile BLOCKED task ${id}: ${proof.reason}`);
+          log.warn(`[gds] publish-status reconcile BLOCKED task ${id}: ${proof.reason}`);
         }
       }
       if (githubPush.landConfirmed(status) && !reconcile_blocked) {
@@ -1062,14 +1064,14 @@ module.exports = function buildTasksRouter() {
         try {
           merge_driver = await githubPush.mergeIfGreen({ branch });
         } catch (e) {
-          console.error('[gds] publish-status merge-driver (non-blocking):', e && e.message);
+          log.error('[gds] publish-status merge-driver (non-blocking):', e && e.message);
         }
       }
       return res.json({ ok: true, ...status, reconciled, reconcile_blocked, merge_driver });
     } catch (e) {
       if (e.code === 'NO_REPO_INFO') return res.fail('no_repo_info', 500);
       if (e.code === 'APP_NOT_INSTALLED') return res.fail('push_unconfigured', { status: 503, message: appNotInstalledMessage(e) });
-      console.error('[gds] GET /tasks/:id/publish-status', e.code || e.message);
+      log.error('[gds] GET /tasks/:id/publish-status', e.code || e.message);
       return res.fail('status_failed', 502);
     }
   });
@@ -1107,7 +1109,7 @@ module.exports = function buildTasksRouter() {
     try {
       await db.setClaimPublishedSha({ taskId: id, builderId: req.builder.id, sha: headSha });
     } catch (e) {
-      console.error('[gds] setClaimPublishedSha via attest-gate (non-blocking)', id, e && e.message);
+      log.error('[gds] setClaimPublishedSha via attest-gate (non-blocking)', id, e && e.message);
     }
     if (!githubPush.isConfigured()) {
       return res.fail('push_unconfigured', { status: 503, message: 'No server push credential (GitHub App / GITHUB_PUSH_TOKEN) to post the gate attestation. ' +
@@ -1129,7 +1131,7 @@ module.exports = function buildTasksRouter() {
       const rows = await db.listOverrideRequests({ status });
       res.json({ requests: rows });
     } catch (err) {
-      console.error('[gds] GET /override-requests', err);
+      log.error('[gds] GET /override-requests', err);
       res.fail('list_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -1169,7 +1171,7 @@ module.exports = function buildTasksRouter() {
         // misattribute. 409 — the request is left open for inspection.
         return res.fail('override_no_requester', { status: 409, message: 'internal error' });
       }
-      console.error('[gds] POST /override-requests/:id/decide', err);
+      log.error('[gds] POST /override-requests/:id/decide', err);
       res.fail('decide_failed', { status: 500, message: 'internal error' });
     }
   });