@bongos/core 1.19.337 → 1.19.338

package/modules/discord/discord-bot.js

@@ -27,6 +27,8 @@
 const auth = require('./auth');
 const db = require('./db');
 const ic = require('../../src/module-api');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = ic.logger('discord');
 
 let client = null;        // the live discord.js Client (or null when disabled/down)
 let starting = false;     // guard against double-start
@@ -165,7 +167,7 @@ function makeInboundChannelHandler({ channelId, aggregator, logLabel }) {
         messageId: msg.id,
       });
     } catch (err) {
-      console.error(`[discord-bot] ${logLabel} error:`, err.message);
+      log.error(`[discord-bot] ${logLabel} error:`, err.message);
     }
   };
 }
@@ -192,11 +194,11 @@ function getClient() {
 // boot) can't be taken down by Discord.
 async function start() {
   if (!botEnabled()) {
-    console.log('[discord-bot] disabled (DISCORD_BOT_ENABLED is not "true") — not connecting.');
+    log.info('[discord-bot] disabled (DISCORD_BOT_ENABLED is not "true") — not connecting.');
     return null;
   }
   if (client || starting) {
-    console.log('[discord-bot] start() called but a client is already active — skipping.');
+    log.info('[discord-bot] start() called but a client is already active — skipping.');
     return client;
   }
 
@@ -204,7 +206,7 @@ async function start() {
   if (!token) {
     // Enabled but no token: a misconfiguration, not a crash. Log loudly and
     // bail so the rest of the server still boots.
-    console.error('[discord-bot] DISCORD_BOT_ENABLED is on but no bot token is configured '
+    log.error('[discord-bot] DISCORD_BOT_ENABLED is on but no bot token is configured '
       + '(set DISCORD_BOT_TOKEN or bot_token in ~/.config/otb/discord-bot.json) — not connecting.');
     return null;
   }
@@ -240,10 +242,10 @@ async function start() {
     c.once(Events.ClientReady, (ready) => {
       const guilds = ready.guilds?.cache?.size ?? 0;
       // ready.user.tag is the bot's name#id — safe to log; the TOKEN never is.
-      console.log(`[discord-bot] connected as ${ready.user.tag} — in ${guilds} guild(s).`);
+      log.info(`[discord-bot] connected as ${ready.user.tag} — in ${guilds} guild(s).`);
       if (guilds === 0) {
         const worldName = (() => { try { return ic.branding().identity?.worldName || 'project'; } catch { return 'project'; } })();
-        console.log(`[discord-bot] note: bot is in 0 guilds. Invite it to the ${worldName} `
+        log.info(`[discord-bot] note: bot is in 0 guilds. Invite it to the ${worldName} `
           + 'server (F5/role-sync needs it there with Manage Roles) before role/reaction features can act.');
       }
       // Ensure all managed rank roles exist in the guild — creates any missing
@@ -254,7 +256,7 @@ async function start() {
         ? ready.guilds?.cache?.get(roleSync.loadGuildId()) || null
         : ready.guilds?.cache?.first() || null;
       roleSync.ensureRankRoles(guild).catch((e) =>
-        console.error('[discord-bot] ensureRankRoles failed:', e.message));
+        log.error('[discord-bot] ensureRankRoles failed:', e.message));
 
       // F5 role-sync (ADR 0033 §4): an initial reconcile once connected, then a
       // periodic sweep. Both best-effort — a Discord perms/hierarchy problem
@@ -278,21 +280,21 @@ async function start() {
     // discord.js auto-reconnects transient gateway drops on its own; we only
     // LOG the lifecycle so an operator can see the connection's health in the
     // journal. No custom reconnect loop — that would fight the library.
-    c.on(Events.Error, (err) => console.error('[discord-bot] client error:', err.message));
-    c.on(Events.Warn, (msg) => console.warn('[discord-bot] warning:', msg));
-    c.on(Events.ShardError, (err) => console.error('[discord-bot] shard error:', err.message));
+    c.on(Events.Error, (err) => log.error('[discord-bot] client error:', err.message));
+    c.on(Events.Warn, (msg) => log.warn('[discord-bot] warning:', msg));
+    c.on(Events.ShardError, (err) => log.error('[discord-bot] shard error:', err.message));
     c.on(Events.ShardDisconnect, (event, id) =>
-      console.warn(`[discord-bot] shard ${id} disconnected (code ${event?.code}) — discord.js will attempt to reconnect.`));
+      log.warn(`[discord-bot] shard ${id} disconnected (code ${event?.code}) — discord.js will attempt to reconnect.`));
     c.on(Events.ShardReconnecting, (id) =>
-      console.log(`[discord-bot] shard ${id} reconnecting…`));
+      log.info(`[discord-bot] shard ${id} reconnecting…`));
     c.on(Events.ShardResume, (id) =>
-      console.log(`[discord-bot] shard ${id} resumed.`));
+      log.info(`[discord-bot] shard ${id} resumed.`));
     // 'invalidated' = the session can't be recovered (e.g. token revoked).
     // discord.js will NOT auto-reconnect; reconnecting would hammer the API.
     // Log loudly, tear down, and leave it for a human — a revoked token is an
     // operator action, not a transient blip.
     c.on(Events.Invalidated, () => {
-      console.error('[discord-bot] session invalidated (token revoked or auth failed) — '
+      log.error('[discord-bot] session invalidated (token revoked or auth failed) — '
         + 'destroying client; a human must re-check the token and restart.');
       stop().catch(() => {});
     });
@@ -303,7 +305,7 @@ async function start() {
     // event loop on every 👍 guild-wide (F4 efficiency finding). Config is
     // boot-time anyway (changing it needs a restart, like the kill-switch).
     const shipFeedChannelId = loadShipFeedChannelId();
-    console.log(shipFeedChannelId
+    log.info(shipFeedChannelId
       ? `[discord-bot] watching #ship-feed (${shipFeedChannelId}) for 👍 upvotes.`
       : '[discord-bot] no DISCORD_SHIP_FEED_CHANNEL_ID set — upvoting is inert (no channel pinned).');
 
@@ -311,14 +313,14 @@ async function start() {
     // builder). Resolved once at startup; null → the approval surface is inert
     // (fail-closed — the bot won't act on reactions in arbitrary channels).
     const memberApprovalsChannelId = loadMemberApprovalsChannelId();
-    console.log(memberApprovalsChannelId
+    log.info(memberApprovalsChannelId
       ? `[discord-bot] watching #member-approvals (${memberApprovalsChannelId}) for Archon 👍/👎.`
       : '[discord-bot] no DISCORD_MEMBER_APPROVALS_CHANNEL_ID set — member approvals are inert (no channel pinned).');
 
     // F6 inbound: the #ideas channel whose messages become idea_inbox entries.
     // Resolved once at startup (config is boot-time). Null → inbound is inert.
     const ideasChannelId = loadIdeasChannelId();
-    console.log(ideasChannelId
+    log.info(ideasChannelId
       ? `[discord-bot] watching #ideas (${ideasChannelId}) for inbound ideas.`
       : '[discord-bot] no DISCORD_IDEAS_CHANNEL_ID set — inbound idea filing is inert (no channel pinned).');
 
@@ -328,7 +330,7 @@ async function start() {
     // startup; onFlush is the real filing path (recordInboundIdea).
     const ideaAggregator = inbound.createIdeaAggregator({
       onFlush: (combined) => inbound.recordInboundIdea(combined).then((result) => {
-        console.log(`[discord-bot] #ideas burst → ${result.outcome}${result.ideaId ? ` (idea #${result.ideaId}, ${result.images || 0} img)` : (result.reason ? ` (${result.reason})` : '')}`);
+        log.info(`[discord-bot] #ideas burst → ${result.outcome}${result.ideaId ? ` (idea #${result.ideaId}, ${result.images || 0} img)` : (result.reason ? ` (${result.reason})` : '')}`);
         return result;
       }),
     });
@@ -337,7 +339,7 @@ async function start() {
     // tasks (kind='bug') straight-through, under the anti-abuse guard in
     // discord-bugs.js. Resolved once at startup. Null → bug intake is inert.
     const bugsChannelId = loadBugsChannelId();
-    console.log(bugsChannelId
+    log.info(bugsChannelId
       ? `[discord-bot] watching #bugs (${bugsChannelId}) for inbound bug-tasks.`
       : '[discord-bot] no DISCORD_BUGS_CHANNEL_ID set — inbound bug filing is inert (no channel pinned).');
 
@@ -346,7 +348,7 @@ async function start() {
     // real filing path (recordInboundBug). Built once at startup.
     const bugAggregator = bugs.createBugAggregator({
       onFlush: (combined) => bugs.recordInboundBug(combined).then((result) => {
-        console.log(`[discord-bot] #bugs burst → ${result.outcome}${result.taskId ? ` (task #${result.taskId}, ${result.status}, ${result.images || 0} img)` : (result.reason ? ` (${result.reason})` : '')}`);
+        log.info(`[discord-bot] #bugs burst → ${result.outcome}${result.taskId ? ` (task #${result.taskId}, ${result.status}, ${result.images || 0} img)` : (result.reason ? ` (${result.reason})` : '')}`);
         return result;
       }),
     });
@@ -385,9 +387,9 @@ async function start() {
         // systemd journal is less access-controlled than audit_log (Archon-only),
         // which already records the id with surface='discord_bot'. Log only the
         // task + outcome here (Hacker finding).
-        console.log(`[discord-bot] 👍 on task #${taskId} → ${result.outcome}`);
+        log.info(`[discord-bot] 👍 on task #${taskId} → ${result.outcome}`);
       } catch (err) {
-        console.error('[discord-bot] reaction handler error:', err.message);
+        log.error('[discord-bot] reaction handler error:', err.message);
       }
     });
 
@@ -438,9 +440,9 @@ async function start() {
         }
         // Don't log the reacting Discord id (audit_log already records it,
         // Archon-only). Log only the record + outcome.
-        console.log(`[discord-bot] approval ${kind} #${marker.id} (${decision}) → ${result.outcome}`);
+        log.info(`[discord-bot] approval ${kind} #${marker.id} (${decision}) → ${result.outcome}`);
       } catch (err) {
-        console.error('[discord-bot] approval handler error:', err.message);
+        log.error('[discord-bot] approval handler error:', err.message);
       }
     });
 
@@ -478,9 +480,9 @@ async function start() {
         if (!builder) return;          // unlinked arrival — nothing to sync
         const roleSync = require('./discord-role-sync');
         const r = await roleSync.syncBuilderRole(builder.id);
-        console.log(`[discord-bot] member joined → role-sync for builder ${builder.id}: ${r.ok ? (r.noop ? 'noop' : 'synced') : r.reason}`);
+        log.info(`[discord-bot] member joined → role-sync for builder ${builder.id}: ${r.ok ? (r.noop ? 'noop' : 'synced') : r.reason}`);
       } catch (err) {
-        console.error('[discord-bot] member-add handler error:', err.message);
+        log.error('[discord-bot] member-add handler error:', err.message);
       }
     });
 
@@ -488,14 +490,14 @@ async function start() {
     // login() rejects on a bad token / network failure — catch it so a Discord
     // problem never propagates into the HTTP boot path.
     await c.login(token).catch((err) => {
-      console.error('[discord-bot] login failed:', err.message);
+      log.error('[discord-bot] login failed:', err.message);
       // Tear the half-built client down so a later start() can retry cleanly.
       try { c.destroy(); } catch (_) { /* ignore */ }
       client = null;
     });
     return client;
   } catch (err) {
-    console.error('[discord-bot] failed to start:', err.message);
+    log.error('[discord-bot] failed to start:', err.message);
     client = null;
     return null;
   } finally {
@@ -508,8 +510,8 @@ async function start() {
 function runRoleReconcile(trigger) {
   const roleSync = require('./discord-role-sync');
   roleSync.reconcileAll()
-    .then((r) => console.log(`[discord-bot] role-sync reconcile (${trigger}): ${r.synced}/${r.total} linked builders synced.`))
-    .catch((err) => console.error(`[discord-bot] role-sync reconcile (${trigger}) failed:`, err.message));
+    .then((r) => log.info(`[discord-bot] role-sync reconcile (${trigger}): ${r.synced}/${r.total} linked builders synced.`))
+    .catch((err) => log.error(`[discord-bot] role-sync reconcile (${trigger}) failed:`, err.message));
 }
 
 // Run the ADR 0037 channel reconcile sweep (best-effort, lazy-required). Makes
@@ -518,10 +520,10 @@ function runChannelReconcile(trigger) {
   const channels = require('./discord-channels');
   channels.reconcileChannels()
     .then((r) => {
-      if (!r.ok) console.log(`[discord-bot] channel reconcile (${trigger}): skipped (${r.reason}).`);
-      else console.log(`[discord-bot] channel reconcile (${trigger}): ${r.applied} applied, ${r.failed} failed of ${r.total}.`);
+      if (!r.ok) log.info(`[discord-bot] channel reconcile (${trigger}): skipped (${r.reason}).`);
+      else log.info(`[discord-bot] channel reconcile (${trigger}): ${r.applied} applied, ${r.failed} failed of ${r.total}.`);
     })
-    .catch((err) => console.error(`[discord-bot] channel reconcile (${trigger}) failed:`, err.message));
+    .catch((err) => log.error(`[discord-bot] channel reconcile (${trigger}) failed:`, err.message));
 }
 
 // Graceful shutdown — close the gateway connection. Safe to call when never
@@ -536,9 +538,9 @@ async function stop() {
   client = null;
   try {
     await c.destroy();
-    console.log('[discord-bot] disconnected.');
+    log.info('[discord-bot] disconnected.');
   } catch (err) {
-    console.error('[discord-bot] error during shutdown:', err.message);
+    log.error('[discord-bot] error during shutdown:', err.message);
   }
 }
 

package/modules/discord/discord-role-sync.js

@@ -27,6 +27,8 @@ const path = require('node:path');
 const os = require('node:os');
 const db = require('./db');
 const ic = require('../../src/module-api');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = ic.logger('discord');
 
 // The live ranks that map to a Discord role badge = the full rank ladder, in
 // order low→high. Sourced from db.LIVE_RANK_LADDER — the server-side single
@@ -134,7 +136,7 @@ async function syncBuilderRole(builderId, deps = realDeps) {
     return { ok: true, add, removed: remove };
   } catch (err) {
     // Most likely a Discord permission/hierarchy problem — log, don't throw.
-    console.error(`[discord-bot] role-sync failed for builder ${builderId}:`, err.message);
+    log.error(`[discord-bot] role-sync failed for builder ${builderId}:`, err.message);
     return { ok: false, reason: 'error', error: err.message };
   }
 }
@@ -177,14 +179,14 @@ async function ensureRankRoles(guild) {
       });
       if (!res.ok) {
         const text = await res.text();
-        console.error(`[discord-bot] ensureRankRoles: failed to create ${rank} role (${res.status}): ${text}`);
+        log.error(`[discord-bot] ensureRankRoles: failed to create ${rank} role (${res.status}): ${text}`);
         continue;
       }
       const role = await res.json();
       created[rank] = role.id;
-      console.log(`[discord-bot] ensureRankRoles: created ${rank} role (id=${role.id})`);
+      log.info(`[discord-bot] ensureRankRoles: created ${rank} role (id=${role.id})`);
     } catch (e) {
-      console.error(`[discord-bot] ensureRankRoles: error creating ${rank} role:`, e.message);
+      log.error(`[discord-bot] ensureRankRoles: error creating ${rank} role:`, e.message);
     }
   }
 
@@ -199,9 +201,9 @@ async function ensureRankRoles(guild) {
       const cfg = JSON.parse(ic.readConfigFileSync('discord-bot.json') || '{}');
       cfg.role_ids = Object.assign({}, cfg.role_ids || {}, created);
       fs.writeFileSync(cfgPath, JSON.stringify(cfg, null, 4), 'utf8');
-      console.log(`[discord-bot] ensureRankRoles: saved ${Object.keys(created).join(', ')} to config.`);
+      log.info(`[discord-bot] ensureRankRoles: saved ${Object.keys(created).join(', ')} to config.`);
     } catch (e) {
-      console.error('[discord-bot] ensureRankRoles: could not save role ids to config:', e.message);
+      log.error('[discord-bot] ensureRankRoles: could not save role ids to config:', e.message);
     }
   }
 
@@ -241,13 +243,13 @@ async function ensureRankRoles(guild) {
               body: JSON.stringify({ color: desired }),
             });
             if (recolorRes.ok) {
-              console.log(`[discord-bot] ensureRankRoles: recolored ${rank} role to #${desired.toString(16).padStart(6, '0')}`);
+              log.info(`[discord-bot] ensureRankRoles: recolored ${rank} role to #${desired.toString(16).padStart(6, '0')}`);
             } else {
               const text = await recolorRes.text();
-              console.error(`[discord-bot] ensureRankRoles: recolor ${rank} failed (${recolorRes.status}): ${text}`);
+              log.error(`[discord-bot] ensureRankRoles: recolor ${rank} failed (${recolorRes.status}): ${text}`);
             }
           } catch (e) {
-            console.error(`[discord-bot] ensureRankRoles: error recoloring ${rank} role:`, e.message);
+            log.error(`[discord-bot] ensureRankRoles: error recoloring ${rank} role:`, e.message);
           }
         }
 
@@ -273,15 +275,15 @@ async function ensureRankRoles(guild) {
           });
           if (patchRes.ok) {
             const order = highToLow.filter((r) => finalMap[r]).join(' > ');
-            console.log(`[discord-bot] ensureRankRoles: reordered roles (${order})`);
+            log.info(`[discord-bot] ensureRankRoles: reordered roles (${order})`);
           } else {
             const text = await patchRes.text();
-            console.error(`[discord-bot] ensureRankRoles: role reorder failed (${patchRes.status}): ${text}`);
+            log.error(`[discord-bot] ensureRankRoles: role reorder failed (${patchRes.status}): ${text}`);
           }
         }
       }
     } catch (e) {
-      console.error('[discord-bot] ensureRankRoles: error reordering roles:', e.message);
+      log.error('[discord-bot] ensureRankRoles: error reordering roles:', e.message);
     }
   }
 

package/modules/government/routes/government.js

@@ -25,6 +25,8 @@ const db = require('../db');
 const sessionScopes = require('../session-scopes');
 const boardMembership = require('../board-membership');
 const board = require('../board');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = api.logger('government');
 
 // The port surface. Deliberately narrow: resolution + the catalog reads a gate or
 // the Archon tab needs. It grows with R98-R101 (principals, session-scopes,
@@ -208,7 +210,7 @@ module.exports = function buildGovernmentRouter() {
       const ranks = await db.listRanksWithGrants();
       res.json({ ranks });
     } catch (err) {
-      console.error('[gds] GET /government/ranks', err);
+      log.error('[gds] GET /government/ranks', err);
       res.fail('ranks_list_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -242,7 +244,7 @@ module.exports = function buildGovernmentRouter() {
       const assignments = await db.listAssignments();
       res.json({ assignments });
     } catch (err) {
-      console.error('[gds] GET /government/assignments', err);
+      log.error('[gds] GET /government/assignments', err);
       res.fail('assignments_list_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -272,7 +274,7 @@ module.exports = function buildGovernmentRouter() {
       if (err && err.code === '23505') {
         return res.fail('rank_exists', 409, { rank_key: rankKey });
       }
-      console.error('[gds] POST /government/ranks', err);
+      log.error('[gds] POST /government/ranks', err);
       res.fail('rank_create_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -307,7 +309,7 @@ module.exports = function buildGovernmentRouter() {
       const granted = await db.grantRankPermission({ rankKey, permissionKey });
       res.json({ ok: true, rank_key: rankKey, permission_key: permissionKey, granted });
     } catch (err) {
-      console.error('[gds] PUT /government/ranks/:rankKey/permissions/:permissionKey', err);
+      log.error('[gds] PUT /government/ranks/:rankKey/permissions/:permissionKey', err);
       res.fail('grant_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -326,7 +328,7 @@ module.exports = function buildGovernmentRouter() {
       const removed = await db.revokeRankPermission({ rankKey, permissionKey });
       res.json({ ok: true, rank_key: rankKey, permission_key: permissionKey, removed });
     } catch (err) {
-      console.error('[gds] DELETE /government/ranks/:rankKey/permissions/:permissionKey', err);
+      log.error('[gds] DELETE /government/ranks/:rankKey/permissions/:permissionKey', err);
       res.fail('revoke_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -361,7 +363,7 @@ module.exports = function buildGovernmentRouter() {
       const count = await db.resetRankGrants({ rankKey, permissionKeys: keys });
       res.json({ ok: true, rank_key: rankKey, seeded_rank: rank.seeded_rank, permission_count: count });
     } catch (err) {
-      console.error('[gds] POST /government/ranks/:rankKey/reset', err);
+      log.error('[gds] POST /government/ranks/:rankKey/reset', err);
       res.fail('reset_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -391,7 +393,7 @@ module.exports = function buildGovernmentRouter() {
       if (err && err.code === '23503') {
         return res.fail('builder_not_found', 404, { builder_id: req.body.builder_id });
       }
-      console.error('[gds] POST /government/assignments', err);
+      log.error('[gds] POST /government/assignments', err);
       res.fail('assign_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -409,7 +411,7 @@ module.exports = function buildGovernmentRouter() {
       const removed = await db.unassignRank({ builderId, rankKey });
       res.json({ ok: true, builder_id: builderId, rank_key: rankKey, removed });
     } catch (err) {
-      console.error('[gds] DELETE /government/assignments/:builderId/:rankKey', err);
+      log.error('[gds] DELETE /government/assignments/:builderId/:rankKey', err);
       res.fail('unassign_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -427,7 +429,7 @@ module.exports = function buildGovernmentRouter() {
       const view = await board.boardRoomView({ closedLimit: 20 });
       res.json({ ...view, viewer_id: String(req.builder.id) });
     } catch (err) {
-      console.error('[gds] GET /government/board/items', err);
+      log.error('[gds] GET /government/board/items', err);
       res.fail('board_read_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -442,7 +444,7 @@ module.exports = function buildGovernmentRouter() {
     try {
       res.json(await board.constitutionView({ historyLimit: 50 }));
     } catch (err) {
-      console.error('[gds] GET /government/constitution', err);
+      log.error('[gds] GET /government/constitution', err);
       res.fail('constitution_read_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -498,7 +500,7 @@ module.exports = function buildGovernmentRouter() {
       }
       res.status(201).json({ ok: true, amendment: out.amendment, item: out.item });
     } catch (err) {
-      console.error('[gds] POST /government/board/items', err);
+      log.error('[gds] POST /government/board/items', err);
       res.fail('propose_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -548,7 +550,7 @@ module.exports = function buildGovernmentRouter() {
         try {
           closure = await board.maybeCloseAfterVote(itemId);
         } catch (closeErr) {
-          console.error('[gds] post-vote close failed (vote recorded, close left to the expiry sweep):', closeErr);
+          log.error('[gds] post-vote close failed (vote recorded, close left to the expiry sweep):', closeErr);
         }
       }
       // Idempotent re-cast reads back the standing vote — 200, not 201, and no
@@ -561,7 +563,7 @@ module.exports = function buildGovernmentRouter() {
         ...(closure && closure.closed ? { item_closed: true, outcome: closure.outcome } : {}),
       });
     } catch (err) {
-      console.error('[gds] POST /government/board/items/:itemId/votes', err);
+      log.error('[gds] POST /government/board/items/:itemId/votes', err);
       res.fail('vote_failed', { status: 500, message: 'internal error' });
     }
   });

package/modules/ideas/routes/inbox.js

@@ -8,6 +8,8 @@ const inbox = require('../inbox');
 // and the deterministic scorer (R142) — both pure, both walk the declaration.
 const { validateFieldValues, templateFor, fieldOrder } = require('../templates');
 const { completenessScore, weakestSectionPayload, scoreFieldValues } = require('../completeness');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = api.logger('ideas');
 const { validateOrRespond, LIMITS, parseId } = api;
 
 const INBOX_STATUS_VALUES = ['open', 'promoted', 'discarded', 'merged'];
@@ -94,7 +96,7 @@ module.exports = function buildInboxRouter() {
       try {
         v = validateFieldValues(body.field_values ?? {}, templateKey ? { templateKey } : undefined);
       } catch (validationErr) {
-        console.error('[gds] POST /inbox field-values validation threw:', validationErr);
+        log.error('[gds] POST /inbox field-values validation threw:', validationErr);
         return res.fail('invalid_field_values', 400, { errors: [{ field: null, reason: 'unvalidatable' }], template_key: templateKey ?? null });
       }
       if (!v.ok) return res.fail('invalid_field_values', 400, { errors: v.errors, template_key: templateKey ?? null });
@@ -155,7 +157,7 @@ module.exports = function buildInboxRouter() {
               if (r && r.credited > 0) idea.ideator_credit = r.credited;
             }
           } catch (creditErr) {
-            console.error('[gds] POST /inbox full-idea pass-credit failed (idea captured + graded, credit skipped):', creditErr);
+            log.error('[gds] POST /inbox full-idea pass-credit failed (idea captured + graded, credit skipped):', creditErr);
             // no warning surfaced — the idea and its grade are intact; the credit
             // is the only thing missed, and a reconcile/re-grade path can pay it.
           }
@@ -193,12 +195,12 @@ module.exports = function buildInboxRouter() {
               }
             }
           } catch (boardErr) {
-            console.error('[gds] POST /inbox board-window open failed (idea captured + graded, window skipped):', boardErr);
+            log.error('[gds] POST /inbox board-window open failed (idea captured + graded, window skipped):', boardErr);
             // R11's expiry poller sweeps open items, not missed opens; a missed
             // open is recoverable by resubmission (R13) — capture stays intact.
           }
         } catch (gradeErr) {
-          console.error('[gds] POST /inbox full-grade write failed (idea captured, landing as quick):', gradeErr);
+          log.error('[gds] POST /inbox full-grade write failed (idea captured, landing as quick):', gradeErr);
           grade_warning = 'captured_but_ungraded';
         }
       }
@@ -242,7 +244,7 @@ module.exports = function buildInboxRouter() {
           500;
         return res.fail(err.code, status, { ...err });
       }
-      console.error('[gds] POST /inbox', err);
+      log.error('[gds] POST /inbox', err);
       res.fail('capture_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -272,7 +274,7 @@ module.exports = function buildInboxRouter() {
       const open_count = await inbox.countOpenIdeas({ viewerRank });
       res.json({ ideas, open_count });
     } catch (err) {
-      console.error('[gds] GET /inbox', err);
+      log.error('[gds] GET /inbox', err);
       res.fail('list_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -451,7 +453,7 @@ module.exports = function buildInboxRouter() {
       if (!idea) return res.fail('idea_not_found', 404);
       res.json({ idea });
     } catch (err) {
-      console.error('[gds] GET /inbox/:id', err);
+      log.error('[gds] GET /inbox/:id', err);
       res.fail('idea_read_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -494,7 +496,7 @@ module.exports = function buildInboxRouter() {
       try {
         v = validateFieldValues(req.body.field_values, templateKey ? { templateKey } : undefined);
       } catch (validationErr) {
-        console.error('[gds] POST /inbox/:id/resubmit validation threw:', validationErr);
+        log.error('[gds] POST /inbox/:id/resubmit validation threw:', validationErr);
         return res.fail('invalid_field_values', 400, { errors: [{ field: null, reason: 'unvalidatable' }] });
       }
       if (!v.ok) return res.fail('invalid_field_values', 400, { errors: v.errors, template_key: templateKey ?? null });
@@ -507,7 +509,7 @@ module.exports = function buildInboxRouter() {
       let rejection = null;
       if (government && government.latestRejectionForIdea) {
         try { rejection = await government.latestRejectionForIdea(id); }
-        catch (e) { console.error('[gds] resubmit: rejection lookup failed (continuing without):', e); }
+        catch (e) { log.error('[gds] resubmit: rejection lookup failed (continuing without):', e); }
       }
       if (!rejection || !rejection.section_key) {
         const flag = weakestSectionPayload(idea.field_values, templateKey ? { templateKey } : undefined);
@@ -539,7 +541,7 @@ module.exports = function buildInboxRouter() {
           if (r && r.credited > 0) out.ideator_credit = r.credited;
         }
       } catch (creditErr) {
-        console.error('[gds] resubmit: pass-credit failed (regrade intact, credit skipped):', creditErr);
+        log.error('[gds] resubmit: pass-credit failed (regrade intact, credit skipped):', creditErr);
       }
 
       let board_window;
@@ -553,7 +555,7 @@ module.exports = function buildInboxRouter() {
           }
         }
       } catch (boardErr) {
-        console.error('[gds] resubmit: board-window open failed (regrade intact, window skipped):', boardErr);
+        log.error('[gds] resubmit: board-window open failed (regrade intact, window skipped):', boardErr);
       }
 
       res.json({
@@ -563,7 +565,7 @@ module.exports = function buildInboxRouter() {
         ...(board_window ? { board_window } : {}),
       });
     } catch (err) {
-      console.error('[gds] POST /inbox/:id/resubmit', err);
+      log.error('[gds] POST /inbox/:id/resubmit', err);
       res.fail('resubmit_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -994,7 +996,7 @@ module.exports = function buildInboxRouter() {
           500;
         return res.fail(err.code, status, { ...err });
       }
-      console.error('[gds] PATCH /inbox/:id', err);
+      log.error('[gds] PATCH /inbox/:id', err);
       res.fail('update_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -1050,7 +1052,7 @@ module.exports = function buildInboxRouter() {
         if (err && err.code === '23505') {
           return res.fail('CRITERION_ALREADY_RATIFIED', 409, { detail: 'A criterion with this proposal ref already exists on the target version.' });
         }
-        console.error('[gds] POST /inbox/:id/ratify', err);
+        log.error('[gds] POST /inbox/:id/ratify', err);
         res.fail('ratify_failed', { status: 500, message: 'internal error' });
       }
     }

package/modules/lifecycle/routes/claims.js

@@ -12,6 +12,8 @@ const { validateOrRespond, LIMITS, parseId } = api;
 // task 1003153: the DEAD dependency edge (a dep that was abandoned, so can never
 // satisfy) — one pure definition shared with the CLI + the detector.
 const { deadDepHint, splitDeadDeps } = require('../dead-deps.js');
+// task 1003208: structured logging (pino via the doorway) — was console.*.
+const log = api.logger('lifecycle');
 
 // V3.R33 (#254): input validation guards. Length caps + shape checks at the
 // top of every write handler. Schemas describe KNOWN-field constraints only —
@@ -155,7 +157,7 @@ async function gateOneActiveClaimPerSession(req, res, next) {
     activeClaimsForSession = await db.getActiveClaimsForSession(creatorSessionId);
   } catch (err) {
     // FAIL-CLOSED. A lookup failure must not let a commingling second claim land.
-    console.error('[gds] gateOneActiveClaimPerSession lookup failed (failing closed):', err);
+    log.error('[gds] gateOneActiveClaimPerSession lookup failed (failing closed):', err);
     return res.fail('session_claim_check_failed', { status: 409, message: 'Could not verify this worktree has no other claim in flight. Try again, or start a fresh worktree for this task.' });
   }
   const decision = shouldRefuseSessionClaim({ activeClaimsForSession, creatorSessionId, worktreeName });
@@ -188,7 +190,7 @@ async function gateNewcomerClaim(req, res, next) {
     }
     next();
   } catch (err) {
-    console.error('[gds] gateNewcomerClaim failed:', err);
+    log.error('[gds] gateNewcomerClaim failed:', err);
     // Fail open — onboarding plumbing must never brick a claim attempt.
     next();
   }
@@ -249,7 +251,7 @@ module.exports = function buildClaimsRouter() {
         try {
           await onboarding.restockForClaim(task);
         } catch (e) {
-          console.log('[gds] newcomer chore restock after claim failed (non-blocking):', e && e.message);
+          log.info('[gds] newcomer chore restock after claim failed (non-blocking):', e && e.message);
         }
       }
       // V3.R51 (#270): claim.worktree_name is the SERVER-DECIDED name. If the
@@ -344,7 +346,7 @@ module.exports = function buildClaimsRouter() {
         }
         return res.fail(err.code, status, { ...err });
       }
-      console.error('[gds] POST /claims', err);
+      log.error('[gds] POST /claims', err);
       res.fail('claim_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -407,7 +409,7 @@ module.exports = function buildClaimsRouter() {
       if (err && err.code === 'BUILDER_INACTIVE') {
         return res.fail('BUILDER_INACTIVE', 403);
       }
-      console.error('[gds] POST /claims/batch', err);
+      log.error('[gds] POST /claims/batch', err);
       res.fail('batch_claim_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -445,7 +447,7 @@ module.exports = function buildClaimsRouter() {
       if (err && err.code === 'BATCH_EMPTY') {
         return res.fail('claim_ids_required', 400);
       }
-      console.error('[gds] POST /claims/batch/release', err);
+      log.error('[gds] POST /claims/batch/release', err);
       res.fail('batch_release_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -479,7 +481,7 @@ module.exports = function buildClaimsRouter() {
       if (err && err.code === 'BATCH_EMPTY') {
         return res.fail('task_ids_required', 400);
       }
-      console.error('[gds] POST /claims/batch/validate', err);
+      log.error('[gds] POST /claims/batch/validate', err);
       res.fail('batch_validate_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -543,7 +545,7 @@ module.exports = function buildClaimsRouter() {
           500;
         return res.fail(err.code, status, { ...err });
       }
-      console.error('[gds] POST /claims/:id/resolve', err);
+      log.error('[gds] POST /claims/:id/resolve', err);
       res.fail('resolve_failed', { status: 500, message: 'internal error' });
     }
   });
@@ -596,7 +598,7 @@ module.exports = function buildClaimsRouter() {
         if (err && err.code === 'BAD_CLAIM_ID') {
           return res.fail('bad_claim_id', 400);
         }
-        console.error('[gds] POST /claims/:id/release-on-behalf', err);
+        log.error('[gds] POST /claims/:id/release-on-behalf', err);
         res.fail('release_on_behalf_failed', { status: 500, message: 'internal error' });
       }
     }