@bongos/core 1.19.331 → 1.19.333

package/src/module-api.js

@@ -1089,8 +1089,12 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.329 with no explicit bump. run 32789596635. (task 1002620)
 //   1.19.331 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.330 with no explicit bump. run 32791877167. (task 1002620)
+//   1.19.332 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.331 with no explicit bump. run 32793033453. (task 1002620)
+//   1.19.333 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.332 with no explicit bump. run 32793666555. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.331'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.333'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/auth_admission_gate.mjs

@@ -13,6 +13,7 @@
 import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
 import { readFileSync } from 'node:fs';
+import { authSource } from './helpers.mjs';
 
 const require = createRequire(import.meta.url);
 const auth = require('../src/bongos/auth.js');
@@ -150,7 +151,8 @@ t('no login passed (legacy callers) behaves exactly as before — BLOCKED', () =
 console.log('\nfirstTimeAdmissionBlocked — every call-site passes `login` (SR-19 non-drift, #1970):');
 
 t('completeWebFlow + pollDeviceFlow both pass `login` to the gate', () => {
-  const src = readFileSync(new URL('../src/bongos/auth.js', import.meta.url), 'utf8');
+  // task 1003206: the auth flows are auth.js + auth-*.js now — read the family.
+  const src = authSource();
   const re = /firstTimeAdmissionBlocked\s*\(\s*\{[^}]*\}/g;
   const callSites = [];
   for (let m = re.exec(src); m; m = re.exec(src)) {

package/tests/est_advisory.mjs

@@ -30,6 +30,7 @@
 import { strict as assert } from 'node:assert';
 import fs from 'node:fs';
 import { createRequire } from 'node:module';
+import { taskRoutesSource } from './helpers.mjs';
 
 const require = createRequire(import.meta.url);
 const { adviseEstimate, pickRatio, buildEstAdvisory, MIN_MATERIAL_DELTA, SCALE_OK_RATIO } =
@@ -171,7 +172,8 @@ await t('the route attaches est_advisory to the 201 body, non-blocking', () => {
   // literal because modules/lifecycle/routes/tasks.js is over the size ratchet's
   // cap and main sits exactly AT the baseline — so this feature had to land at
   // net-zero lines in that file. Asserting the shape keeps the fold honest.
-  const src = fs.readFileSync(new URL('../modules/lifecycle/routes/tasks.js', import.meta.url), 'utf8');
+  // task 1003206: the task router is tasks.js + task-*.js now — read the family.
+  const src = taskRoutesSource();
   const body201 = (src.match(/res\.status\(201\)\.json\(\{[\s\S]*?\}\);/) || [''])[0];
   assert.ok(body201, 'found the 201 response body');
   assert.match(body201, /est_advisory:/, 'est_advisory rides the create response');

package/tests/goal_advisory.mjs

@@ -17,14 +17,15 @@ import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
 import { readFileSync } from 'node:fs';
 import http from 'node:http';
-import { makeRunner, lifecycleDbSource } from './helpers.mjs';
+import { makeRunner, lifecycleDbSource, taskRoutesSource } from './helpers.mjs';
 
 process.env.NODE_ENV = 'test';
 
 const require = createRequire(import.meta.url);
 const { adviseGoal, candidateGoals, generalGoalTitle, buildGoalAdvisory } = require('../modules/lifecycle/goal-advisory.js');
 
-const tasksSrc = readFileSync(new URL('../modules/lifecycle/routes/tasks.js', import.meta.url), 'utf8');
+// task 1003206: the task router is tasks.js + task-*.js now — read the family.
+const tasksSrc = taskRoutesSource();
 // task 1003204: the lifecycle data layer is db.js + db-*.js now — read the family.
 const dbSrc = lifecycleDbSource();
 const { test, summary } = makeRunner();

package/tests/goal_criterion_confirm_ui.mjs

@@ -40,6 +40,11 @@ const TASK_LIB_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/tas
 // task 1003135: the page's pure presentational helpers moved to goals-lib.js
 // (window.OTBGoalsLib) — run the REAL file too, same reasoning as task-lib above.
 const GOALS_LIB_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-lib.js'), 'utf8');
+// task 1003206: the page's view painters moved to goals-render.js
+// (window.OTBGoalsRender) — the second half of the same carve. Run the REAL file
+// too, for the same reason: this is the only test that executes either board, so
+// stubbing the renderers would let them rot unwatched.
+const GOALS_RENDER_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-render.js'), 'utf8');
 
 const { test, summary } = makeRunner();
 
@@ -136,6 +141,7 @@ async function render({ rank = 'metic', goalStatus = 'open', criteria = Object.v
   vm.createContext(sandbox);
   vm.runInContext(TASK_LIB_SRC, sandbox, { filename: 'task-lib.js' });
   vm.runInContext(GOALS_LIB_SRC, sandbox, { filename: 'goals-lib.js' });
+  vm.runInContext(GOALS_RENDER_SRC, sandbox, { filename: 'goals-render.js' });
   vm.runInContext(SRC, sandbox, { filename: 'goals-page.js' });
 
   // Let boot()'s promise chain settle (me → goals → details → route → render).

package/tests/goal_subtitle.mjs

@@ -18,6 +18,7 @@ import { createRequire } from 'node:module';
 import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { goalsPageSource } from './helpers.mjs';
 
 const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
@@ -179,9 +180,11 @@ test('an unset subtitle is hidden; a set one is shown trimmed', () => {
 });
 
 test('on a LIST the subtitle is a tooltip, never a second visible line', () => {
-  const js = read('modules', 'hall-ui', 'public', 'goals-page.js');
+  // task 1003206: the row/card painters moved to goals-render.js — the second half
+  // of the carve goals-lib.js began — so read the family, not one filename.
+  const js = goalsPageSource();
   // The helper lives in goals-lib.js — the file that exists because
-  // goals-page.js is over the excess-lines ratchet (task 1003135).
+  // goals-page.js was over the excess-lines ratchet (task 1003135).
   const lib = read('modules', 'hall-ui', 'public', 'goals-lib.js');
   assert.match(lib, /function subtitleAttr/);
   assert.match(lib, /escapeHtml\(t\)/, 'escaped, since it lands in an attribute');

package/tests/goals_card_view.mjs

@@ -12,10 +12,11 @@ import { strict as assert } from 'node:assert';
 import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
-import { makeRunner } from './helpers.mjs';
+import { makeRunner, goalsPageSource } from './helpers.mjs';
 
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
-const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-page.js'), 'utf8');
+// task 1003206: the view painters moved to goals-render.js — read the family.
+const SRC = goalsPageSource();
 const CSS = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals.css'), 'utf8');
 const { test, summary } = makeRunner();
 
@@ -28,7 +29,13 @@ await test('both views render from ONE fact source (goalRenderFacts) so they can
 });
 
 await test('renderList forks on the f-goal-view toggle AFTER grouping/filter/sort (both views share them)', () => {
-  const body = SRC.slice(SRC.indexOf('function renderList'), SRC.indexOf('drag-to-reorder: RETIRED'));
+  // task 1003206: renderList moved to goals-render.js while the 'drag-to-reorder:
+  // RETIRED' marker that used to bound it stayed in goals-page.js, so slicing
+  // between the two now spans two files (or inverts). Bound the body by the next
+  // top-level function instead — that IS what 'renderList's body' means.
+  const start = SRC.indexOf('function renderList');
+  const nextFn = SRC.indexOf('\n  function ', start + 1);
+  const body = SRC.slice(start, nextFn > start ? nextFn : undefined);
   assert.match(body, /#f-goal-view/, 'the fork reads the toggle');
   const sortIdx = body.indexOf('sortGoals(');
   const forkIdx = body.indexOf('#f-goal-view');

package/tests/grader_generated_provenance.mjs

@@ -36,6 +36,7 @@ import { createRequire } from 'node:module';
 import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { fitnessSource } from './helpers.mjs';
 
 const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
@@ -44,7 +45,8 @@ const prov = require(path.join(ROOT, 'modules/grading/generated-provenance.js'))
 // ---- 1. lockstep with the fitness gate ----
 
 test('the generator roster matches fitness.js checkGeneratedArtifactsFresh exactly', () => {
-  const src = fs.readFileSync(path.join(ROOT, 'scripts/gds/fitness.js'), 'utf8');
+  // task 1003206: the gate is fitness.js + fitness-*.js now — read the family.
+  const src = fitnessSource();
   const fn = src.slice(src.indexOf('function checkGeneratedArtifactsFresh'));
   const body = fn.slice(0, fn.indexOf('\nfunction ', 1));
 

package/tests/hall_palette.mjs

@@ -18,6 +18,7 @@ import fs from 'node:fs';
 import path from 'node:path';
 import vm from 'node:vm';
 import { fileURLToPath } from 'node:url';
+import { hallSource } from './helpers.mjs';
 
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const HALL = path.join(ROOT, 'modules/hall-ui/public');
@@ -90,7 +91,8 @@ function declaredHrefs(prefixTest) {
 }
 
 test('Standing section anchors exist in builders.js and are routable in shell.js', () => {
-  const groups = [...read('builders.js').matchAll(/\{ key: '([a-z]+)', label: '[^']+' \}/g)].map((m) => m[1]);
+  // task 1003206: STANDING_GROUPS moved to hall-render.js — read the family.
+  const groups = [...hallSource().matchAll(/\{ key: '([a-z]+)', label: '[^']+' \}/g)].map((m) => m[1]);
   assert.ok(groups.length >= 4, `sanity: found STANDING_GROUPS (${groups})`);
   const declared = declaredHrefs((h) => h.startsWith('/#standing-')).map((h) => h.replace('/#', ''));
   assert.ok(declared.length, 'palette declares Standing sections');

package/tests/helpers.mjs

@@ -124,34 +124,67 @@ export function requireHostModule(require, spec, note) {
   }
 }
 
-// lifecycleDbSource — the LIFECYCLE data layer as one source string.
+// ── carved-family source readers (tasks 1003204–1003206, goal 1000079) ────────
 //
-// task 1003204 (goal 1000079) split the 5,748-line modules/lifecycle/db.js into
-// db.js (a pure re-export facade) + twelve cohesive db-*.js units. A pile of
-// tests assert things about "the data layer" by regexing its source — that the
-// claim paths gate on requires_rank, that a literal appears in exactly one
-// place, that dependency CRUD points at the right table. Those assertions were
-// always about the LAYER, not about one filename, so they read the whole family
-// here. Reading the family (rather than repointing each test at whichever db-*
-// unit happens to hold the code today) also means a future re-carve moves code
-// between units without silently disarming the assertion.
+// The de-monolith work split four big files into a facade plus siblings:
+// modules/lifecycle/db.js, scripts/gds/ship.js, scripts/gds/fitness.js and
+// modules/lifecycle/routes/tasks.js. A pile of tests assert things about one of
+// those SUBJECTS by regexing its source — that every claim path gates on
+// requires_rank, that a literal appears in exactly one place, that a gate
+// precedes the first write. Those assertions were always about the subject, not
+// about a filename, so they read the whole family.
+//
+// Reading the family (rather than repointing each test at whichever sibling
+// happens to hold the code today) also means a future re-carve can move code
+// between siblings without silently disarming the assertion.
+function familySource(dir, matches) {
+  return fs.readdirSync(dir).filter(matches).sort()
+    .map((f) => fs.readFileSync(path.join(dir, f), 'utf8')).join('\n');
+}
+
+// The LIFECYCLE data layer: db.js (a re-export facade) + the twelve db-*.js units.
 export function lifecycleDbSource(modulesDir = path.join(ROOT, 'modules')) {
-  const dir = path.join(modulesDir, 'lifecycle');
-  const files = fs.readdirSync(dir)
-    .filter((f) => f === 'db.js' || (f.startsWith('db-') && f.endsWith('.js')))
-    .sort();
-  return files.map((f) => fs.readFileSync(path.join(dir, f), 'utf8')).join('\n');
+  return familySource(path.join(modulesDir, 'lifecycle'),
+    (f) => f === 'db.js' || (f.startsWith('db-') && f.endsWith('.js')));
 }
 
-// shipCliSource — the ship CLI as one source string.
-//
-// The companion to lifecycleDbSource above, for the same reason: task 1003205
-// carved the 4,613-line scripts/gds/ship.js into ship.js (a re-export facade +
-// the CLI entry point) plus ship-*.js phase modules. Tests that assert "the ship
-// CLI does X" by regexing its source mean the CLI as a whole, not one file.
+// The SHIP CLI: ship.js (facade + entry point) + the ship-*.js phase modules.
 export function shipCliSource(scriptsDir = path.join(ROOT, 'scripts', 'gds')) {
-  const files = fs.readdirSync(scriptsDir)
-    .filter((f) => f === 'ship.js' || (f.startsWith('ship-') && f.endsWith('.js')))
-    .sort();
-  return files.map((f) => fs.readFileSync(path.join(scriptsDir, f), 'utf8')).join('\n');
+  return familySource(scriptsDir,
+    (f) => f === 'ship.js' || (f.startsWith('ship-') && f.endsWith('.js')));
+}
+
+// The architecture-fitness GATE: fitness.js (registry + runner), fitness-lib.js
+// and the fitness-checks-*.js clusters. fitness-ratchets.js is deliberately in —
+// it has always been a registered check module of the same gate.
+export function fitnessSource(scriptsDir = path.join(ROOT, 'scripts', 'gds')) {
+  return familySource(scriptsDir,
+    (f) => f === 'fitness.js' || (f.startsWith('fitness-') && f.endsWith('.js')));
+}
+
+// The BUILDERS' HALL page script: builders.js (state, data loading, wiring) plus
+// hall-render.js, the view painters task 1003206 carved out of it.
+export function hallSource(pubDir = path.join(ROOT, 'modules', 'hall-ui', 'public')) {
+  return familySource(pubDir, (f) => f === 'builders.js' || f === 'hall-render.js');
+}
+
+// The GOALS page script: goals-page.js plus its two carved siblings — goals-lib.js
+// (pure helpers, task 1003135) and goals-render.js (view painters, task 1003206).
+export function goalsPageSource(pubDir = path.join(ROOT, 'modules', 'hall-ui', 'public')) {
+  return familySource(pubDir, (f) => ['goals-page.js', 'goals-lib.js', 'goals-render.js'].includes(f));
+}
+
+// The KERNEL IDENTITY surface: auth.js (session resolution, the middleware and the
+// page gates) plus the auth-*.js flow modules (config, admission, GitHub, IdP,
+// Discord).
+export function authSource(srcDir = path.join(ROOT, 'src', 'bongos')) {
+  return familySource(srcDir,
+    (f) => f === 'auth.js' || (f.startsWith('auth-') && f.endsWith('.js')));
+}
+
+// The TASK ROUTER: routes/tasks.js plus the task-*.js route modules it registers
+// (task-write-routes.js holds POST /tasks and PATCH /tasks/:id).
+export function taskRoutesSource(modulesDir = path.join(ROOT, 'modules')) {
+  return familySource(path.join(modulesDir, 'lifecycle', 'routes'),
+    (f) => f === 'tasks.js' || (f.startsWith('task-') && f.endsWith('.js')));
 }

package/tests/lib_sh_resolution.mjs

@@ -28,6 +28,7 @@ import { spawnSync } from 'node:child_process';
 import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { fitnessSource } from './helpers.mjs';
 
 const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
@@ -122,7 +123,8 @@ test('gds_api_base falls back to the instance, never a foreign host', (t) => {
 // ---- 3. the guard can now SEE a .sh re-hardcode ----------------------------
 
 test('the host-identity fitness scan covers .sh', () => {
-  const src = fs.readFileSync(path.join(GDS, 'fitness.js'), 'utf8');
+  // task 1003206: the gate is fitness.js + fitness-*.js now — read the family.
+  const src = fitnessSource();
   assert.match(src, /IDENTITY_SCAN_EXTS = new Set\(\[[^\]]*'\.sh'/,
     'the scan extension set must include .sh, or no shell script is ever checked');
 });

package/tests/membership_kind_lockstep.mjs

@@ -36,6 +36,7 @@ import { test } from 'node:test';
 import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { authSource } from './helpers.mjs';
 
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const read = (rel) => fs.readFileSync(path.join(ROOT, rel), 'utf8');
@@ -101,7 +102,8 @@ test('the value mapping is one shared function, not repeated inline', () => {
 });
 
 test('the sender writes BOTH spellings, computing the kind once (the cross-version window)', () => {
-  const auth = read('src/bongos/auth.js');
+  // task 1003206: the auth flows are auth.js + auth-*.js now — read the family.
+  const auth = authSource();
   const body = auth.slice(auth.indexOf('async function reportMembershipCheckIn'), auth.indexOf('async function reportMembershipCheckIn') + 2400);
   assert.match(body, /membership_kind: kind/, 'the new field goes on the wire');
   assert.match(body, /role: kind === 'member' \? 'builder' : kind/,

package/tests/migration_allocation.mjs

@@ -28,7 +28,7 @@ import { readFileSync } from 'node:fs';
 import { fileURLToPath } from 'node:url';
 import { dirname, join } from 'node:path';
 import { createRequire } from 'node:module';
-import { lifecycleDbSource } from './helpers.mjs';
+import { lifecycleDbSource, taskRoutesSource } from './helpers.mjs';
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const repoRoot = join(__dirname, '..');
@@ -52,7 +52,8 @@ const migrationSql = read('migrations', '081_tasks_needs_migration.sql');
 // the tasks db slice + the tasks route carved to modules/lifecycle/ at BV1.R86.
 // task 1003204: the lifecycle data layer is db.js + db-*.js now — read the family.
 const dbSrc = lifecycleDbSource();
-const routesSrc = read('modules', 'lifecycle', 'routes', 'tasks.js');
+// task 1003206: the task router is tasks.js + task-*.js now — read the family.
+const routesSrc = taskRoutesSource();
 const captureSrc = read('scripts', 'gds', 'capture.js');
 
 // The allocator's trigger, reproduced as a pure predicate. This is the exact
@@ -148,6 +149,8 @@ function shouldReserveMigrationNumber(task) {
   // "migration"/"schema" compounds, and a wrong verdict must be correctable
   // via PATCH. Behavioral tests use the real exported detectsMigration.
   const require = createRequire(import.meta.url);
+  // task 1003206: detectsMigration moved to task-route-helpers.js; tasks.js still
+  // re-exports it, so this keeps exercising the router's own public surface.
   const { detectsMigration } = require('../modules/lifecycle/routes/tasks.js');
 
   await test('classifier ignores code-migration and API-schema phrasing (task 1002648)', () => {

package/tests/patch_gate_ordering.mjs

@@ -18,8 +18,10 @@
 import assert from 'node:assert/strict';
 import { test } from 'node:test';
 import { readFileSync } from 'node:fs';
+import { taskRoutesSource } from './helpers.mjs';
 
-const src = readFileSync(new URL('../modules/lifecycle/routes/tasks.js', import.meta.url), 'utf8');
+// task 1003206: PATCH /tasks/:id now lives in task-write-routes.js — read the family.
+const src = taskRoutesSource();
 
 // The PATCH handler slice: router.patch('/tasks/:id' … up to the next route.
 function patchSlice(source) {

package/tests/projects_hub_pre_uat.mjs

@@ -309,3 +309,56 @@ test('decision 10 — both footers carry the open-source (AGPL-3.0) link, in lin
   assert.ok(indexFoot.indexOf('<!--apex-only:end-->') < indexFoot.search(AGPL), 'index.html: after the apex-only block');
   assert.match(COSMOS, /\.foot a\{color:var\(--link-ink\);font-weight:700;text-decoration:none;\}/, 'never the browser’s blue');
 });
+
+/* ── the should-fix remainder (task 1003244) ── */
+test('an unmapped create failure gets a plain sentence with the raw text folded under Technical details', () => {
+  const friendly = fn('friendlyCreateError');
+  assert.match(friendly, /return '';\n\s*\}/, 'unmapped codes return nothing — the caller folds them');
+  assert.doesNotMatch(friendly, /Couldn’t file the request: ' \+/, 'the raw message is no longer the headline');
+  for (const code of ['slug_taken', 'bad_slug', 'domain_reserved', 'domain_taken', 'bad_domain', 'repo_scope_required', 'request_failed']) {
+    assert.match(friendly, new RegExp(`code === '${code}'`), `${code} stays headline-only`);
+  }
+  assert.match(friendly, /belongs to the platform’s own domain/, 'domain_reserved covers both server branches');
+  assert.match(fn('createFailureMarkup'), /Nothing was created — you can try again\.' \+\n\s*'<details><summary>Technical details<\/summary><p>' \+ esc\(err && err\.message/);
+  assert.match(SCRIPT, /if \(friendly\) alertBox\.textContent = friendly;\n\s*else alertBox\.innerHTML = createFailureMarkup\(err\);/);
+  assert.match(COSMOS, /\.alert details p\{[^}]*font-family:var\(--font-mono\)/, 'the raw text reads as code, inside the alert');
+});
+
+test('a manifest error says a plain sentence, folds the route text, and sends a domainless project to its address', () => {
+  const steps = fn('renderStepOauthApp');
+  assert.doesNotMatch(steps, /'GitHub setup hit a snag' \+ \(live\.manifestMsg \? ': ' \+ esc\(live\.manifestMsg\)/, 'the raw route text is no longer the headline');
+  assert.match(steps, /else if \(live\.manifestCode === 'domain_required'\) snag = 'This project needs an address first — attach one from <a href="\?view=mine">your projects page<\/a>/);
+  assert.match(steps, /\(raw \? '<details><summary>Technical details<\/summary><p>' \+ esc\(raw\) \+ '<\/p><\/details>' : ''\)/);
+  assert.match(SCRIPT, /e\.code = \(d\.error && d\.error\.code\) \|\| '';/, 'the route code travels with the error');
+  assert.match(SCRIPT, /live\.manifestCode = String\(\(err && err\.code\) \|\| ''\);/);
+  assert.equal((SCRIPT.match(/manifestMsg: '', manifestCode: '', appSlug: null/g) || []).length, 2, 'both resets carry the code');
+});
+
+test('the rail at the done panel keeps its marker on Create until the project answers', () => {
+  const rail = fn('paintRail');
+  assert.match(rail, /var landed = step === 6 && !!\(live && live\.instStatus === 'active'\);/);
+  assert.match(rail, /var cur = step === 6 \? 5 : step;/);
+  assert.match(rail, /li\.classList\.toggle\('done', landed \|\| n < cur\);/);
+  assert.match(rail, /if \(now\) li\.setAttribute\('aria-current', 'step'\); else li\.removeAttribute\('aria-current'\);/);
+  assert.match(fn('show'), /paintRail\(step\);/, 'show() paints through it');
+  assert.doesNotMatch(fn('show'), /classList\.toggle\('done'/, 'and no longer marks the rail on its own');
+  assert.match(SCRIPT, /live\.instStatus = inst\.status; renderSteps\(\);\n\s*if \(state\.step === 6\) paintRail\(6\);/, 'the done-panel poll repaints when the status moves');
+  assert.match(HUB, /<li class="now" data-step="1" aria-current="step">/, 'the static rail starts with the same marker');
+});
+
+test('card action results announce, nothing under the pointer is deleted, and focus stays on the card', () => {
+  assert.match(fn('renderCard'), /id="msg-' \+ iid \+ '" role="status" aria-live="polite">/, 'the card slot is a live region');
+  assert.match(HUB, /<div class="projMsg" id="mMsg" role="status" aria-live="polite"><\/div>/, 'so is the manage page’s');
+  assert.doesNotMatch(SCRIPT, /act\.innerHTML = '<span class="projMsg">Asking…<\/span>'/, 'no action replaces the row it was pressed in');
+  assert.match(fn('doTeardown'), /quietActions\(id\);\n\s*msg\(id, 'Asking…'\);/);
+  assert.match(fn('reProvision'), /quietActions\(id\);\n\s*msg\(id, 'Asking…'\);/);
+  assert.match(fn('quietActions'), /act\.querySelectorAll\('button'\)\.forEach\(function \(b\) \{ b\.disabled = true; \}\);/);
+  assert.match(fn('quietActions'), /li\.setAttribute\('data-focus-back', ''\)/, 'a disabled button that held focus leaves a note');
+  assert.match(fn('askTeardown'), /<div class="confirmRow" tabindex="-1">/);
+  assert.match(fn('askTeardown'), /if \(row && row\.focus\) row\.focus\(\);/, 'the question takes focus when the button goes');
+  const card = fn('renderCard');
+  assert.match(card, /var wasInside = li\.contains\(document\.activeElement\) && document\.activeElement !== li;/);
+  assert.match(card, /else if \(focusBack\) focusCardControl\(inst\.id, prefer\);/);
+  assert.match(fn('focusKeyOf'), /data-teardown-yes'\) \|\| el\.hasAttribute\('data-teardown-no'\)\) return '\[data-teardown\]'/, 'Yes / Keep land back on the door that opened them');
+  assert.match(fn('focusCardControl'), /li\.querySelector\('\.actions a, \.actions button'\) \|\|\n\s*li\.querySelector\('details\.attachFold summary'\)/, 'nearest control as the fallback');
+});

package/tests/rank_tier_single_source.mjs

@@ -124,9 +124,18 @@ test('static ladder copies carry the exact canonical ladder', () => {
   }
 });
 
-const STATIC_MAP_FILES = ['modules/hall-ui/public/builders.js', 'modules/hall-ui/public/goals-page.js'];
+// task 1003206 carved the hall page scripts up; the rank tier maps travelled with
+// the renderers that read them, so the pin and the allowlist follow the code.
+const HALL_SCRIPTS = ['modules/hall-ui/public/builders.js', 'modules/hall-ui/public/goals-page.js',
+  'modules/hall-ui/public/hall-render.js', 'modules/hall-ui/public/goals-render.js'];
+// Filtered INSIDE the test, not at module scope: extractRankMaps is declared
+// further down, so calling it up here is a temporal-dead-zone crash.
+const staticMapFiles = () => HALL_SCRIPTS.filter(
+  (rel) => extractRankMaps(fs.readFileSync(path.join(ROOT, rel), 'utf8')).length > 0);
 test('hall static tier maps match the kernel map', () => {
-  for (const rel of STATIC_MAP_FILES) {
+  const files = staticMapFiles();
+  assert.ok(files.length > 0, 'at least one hall script must carry the tier map');
+  for (const rel of files) {
     const src = fs.readFileSync(path.join(ROOT, rel), 'utf8');
     const maps = extractRankMaps(src);
     assert.ok(maps.length > 0, `${rel}: expected a rank tier map`);
@@ -146,7 +155,11 @@ const MAP_ALLOWLIST = new Set([
   'scripts/gds/box-connect-lib.js',
   'modules/dev-box/boxes.js',
   'modules/hall-ui/public/builders.js',
-  'modules/hall-ui/public/goals-page.js',
+  // task 1003206 carved the hall page scripts up. builders.js KEPT its map (the
+  // renderers read it through the injected ctx), while goals-page.js's travelled
+  // into goals-render.js — so goals-page.js is pruned and hall-render.js is never
+  // added. The allowlist fails on a stale entry, which is the check working.
+  'modules/hall-ui/public/goals-render.js',
 ]);
 // Where a rank-ladder array literal is allowed to exist.
 const LADDER_ALLOWLIST = new Set([

package/tests/reward_gate.mjs

@@ -25,7 +25,7 @@ const db = require('../modules/lifecycle/db.js');
 // the SAME singleton object db.js captured, so mutating its .query stubs the INSERT
 // createTask runs — no database needed.
 const sharedPool = require('../src/module-api.js').pool;
-import { lifecycleDbSource } from './helpers.mjs';
+import { lifecycleDbSource, taskRoutesSource } from './helpers.mjs';
 
 const __dir = dirname(fileURLToPath(import.meta.url));
 const root = join(__dir, '..');
@@ -132,7 +132,8 @@ t('null task is a no-op (no throw, no assignment)', () => {
 // ---------------------------------------------------------------------------
 console.log('\nenforcement points (source-wiring — AUTO-ASSIGN):');
 
-const tasksRouteSrc = readFileSync(join(root, 'modules/lifecycle/routes/tasks.js'), 'utf8');
+// task 1003206: POST /tasks now lives in task-write-routes.js — read the family.
+const tasksRouteSrc = taskRoutesSource();
 // task 1003204: the lifecycle data layer is db.js + db-*.js now — read the family.
 const dbSrc = lifecycleDbSource();
 const migration178 = readFileSync(join(root, 'migrations/178_reward_gate_auto_assign_revert_autopromote.sql'), 'utf8');