@bongos/core 1.19.299 → 1.19.301

package/modules/hall-ui/public/ideas.js

@@ -26,6 +26,15 @@
 // here would be a second copy of a DIFFERENT rule — the exact mistake this file
 // is organised to avoid — so the gauge reports completeness and stops there.
 //
+// TWO MODES, ONE FORM (task 1002930 / R154). Opened plainly, the composer FILES a
+// new Full Idea. Opened as ?develop=<id> from the spark queue below, it DEVELOPS
+// an existing spark: the spark's own words are shown above the fields, its title
+// becomes a read-only fact rather than an editable input (developing an idea must
+// not quietly rename it out from under its author), and filing calls
+// POST /inbox/:id/develop instead of POST /inbox. The five fields, the meter, the
+// validation and the draft behaviour are identical — which is the point of reusing
+// this surface rather than building a second one that drifts from it.
+//
 // DRAFTS ARE LOCAL. "A partial draft is not lost on navigation" is a done-when,
 // and a half-written thought is not something to put in the database: it has no
 // title yet, no grade, and nothing downstream should be able to see it. It lives
@@ -38,9 +47,17 @@
   const api = window.BongosClient.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false });
   const { escapeHtml, $, toast } = window.OTB;
 
-  // One key, this page only. Versioned by template key at save time so a project
-  // that changes its template (R156) cannot restore a draft shaped for the old one.
-  const DRAFT_KEY = 'hall-full-idea-draft';
+  // One key per THING BEING WRITTEN. A new idea and a spark being developed are
+  // different drafts, and sharing one key would let a half-written new idea
+  // overwrite someone's development work (or restore itself into it). Versioned by
+  // template key at save time too, so a project that changes its template (R156)
+  // cannot restore a draft shaped for the old one.
+  const developId = () => {
+    const m = /[?&]develop=(\d+)\b/.exec(location.search);
+    return m ? m[1] : null;
+  };
+  const DEVELOP_ID = developId();
+  const DRAFT_KEY = DEVELOP_ID ? `hall-full-idea-draft:develop:${DEVELOP_ID}` : 'hall-full-idea-draft';
   const SCORE_DEBOUNCE_MS = 300;
   const DRAFT_DEBOUNCE_MS = 500;
 
@@ -187,7 +204,9 @@
     // problem, not a capture error). Matching that exactly means the button never
     // promises an outcome the server will refuse, and never blocks one it accepts.
     const missingRequired = template.fields.some((f) => f.required && !fieldEl(f.key).value.trim());
-    $('#fi-submit').disabled = filing || missingRequired || !titleEl().value.trim();
+    // In develop mode the title is the existing idea's and is not editable, so it
+    // cannot be a reason to keep the button off.
+    $('#fi-submit').disabled = filing || missingRequired || (!DEVELOP_ID && !titleEl().value.trim());
   }
 
   async function scoreNow() {
@@ -209,7 +228,7 @@
     // round-trip: it depends only on what is typed.
     if (lastScore) renderScore(lastScore);
     else $('#fi-submit').disabled = filing
-      || !titleEl().value.trim()
+      || (!DEVELOP_ID && !titleEl().value.trim())
       || template.fields.some((f) => f.required && !fieldEl(f.key).value.trim());
   }
 
@@ -251,14 +270,22 @@
     showErr('');
     $('#fi-submit').disabled = true;
 
-    const r = await api.inbox.postInbox({
-      body: {
-        title: titleEl().value.trim(),
-        grade: 'full',
-        template_key: template.key,
-        field_values: collect(),
-      },
-    });
+    // The one behavioural fork between the two modes. Developing is an act on an
+    // EXISTING idea, so it carries no title and no grade: the row already has
+    // both, and R146 preserves them along with its author.
+    const r = DEVELOP_ID
+      ? await api.inbox.postInboxIdDevelop({
+        id: DEVELOP_ID,
+        body: { field_values: collect(), template_key: template.key },
+      })
+      : await api.inbox.postInbox({
+        body: {
+          title: titleEl().value.trim(),
+          grade: 'full',
+          template_key: template.key,
+          field_values: collect(),
+        },
+      });
 
     filing = false;
     if (!r.ok) {
@@ -275,17 +302,28 @@
     // grade write did not, and says so. Repeat that here instead of claiming a
     // Full Idea was stored when the response says otherwise.
     const landedFull = idea && idea.grade === 'full';
-    toast(landedFull
-      ? `Filed as a Full Idea${score == null ? '' : ` — ${score}/100`}.`
-      : 'Filed, but stored as a quick idea — the grade could not be written.');
+    if (DEVELOP_ID) {
+      // The split is the developer's business: they earned a share of it and the
+      // author kept theirs, and saying so is how the handoff stops feeling like
+      // giving work away (R147 / ADR 0185).
+      const credited = r.data && r.data.idea && r.data.idea.ideator_credit;
+      toast(`Developed${score == null ? '' : ` — ${score}/100`}${credited ? `. ${credited} credits split with its author.` : '.'}`);
+    } else {
+      toast(landedFull
+        ? `Filed as a Full Idea${score == null ? '' : ` — ${score}/100`}.`
+        : 'Filed, but stored as a quick idea — the grade could not be written.');
+    }
 
-    titleEl().value = '';
+    if (!DEVELOP_ID) titleEl().value = '';
     for (const f of template.fields) fieldEl(f.key).value = '';
     lastScore = null;
     renderScore(null);
     note('');
     if (idea && idea.id) {
-      $('#fi-sub').innerHTML = `Filed <a href="/#/idea/${encodeURIComponent(idea.id)}">idea ${escapeHtml(String(idea.id))}</a>. Write another below.`;
+      // The detail PAGE (task 1002929 / R153), not the #/idea/N overlay: the
+      // thing just filed has five prose answers, which is what the page is for.
+      const base = location.hostname.startsWith('builders.') ? '' : '/builders';
+      $('#fi-sub').innerHTML = `Filed <a href="${base}/idea/${encodeURIComponent(idea.id)}">idea ${escapeHtml(String(idea.id))}</a>. Write another below.`;
     }
   }
 
@@ -305,6 +343,79 @@
   // boot
   // ---------------------------------------------------------------------------
 
+  // ---------------------------------------------------------------------------
+  // the spark queue (task 1002930 / R154)
+  // ---------------------------------------------------------------------------
+
+  const hallBase = () => (location.hostname.startsWith('builders.') ? '' : '/builders');
+
+  function renderQueue(sparks, count) {
+    const host = $('#fi-queue');
+    if (!sparks || sparks.length === 0) {
+      // An answer, not a blank space — and it says how one gets here, since the
+      // only way to fill this queue is for an author to offer something up.
+      host.innerHTML = '<p class="fi-queue-empty">Nothing is waiting. A spark appears here when its author offers a quick idea up for development.</p>';
+      return;
+    }
+    const total = Number.isInteger(count) ? count : sparks.length;
+    const more = total > sparks.length ? `<p class="fi-note">Showing ${sparks.length} of ${total}.</p>` : '';
+    host.innerHTML = `<div class="fi-queue">${sparks.map((sp) => {
+      const who = sp.filed_by_login ? `@${escapeHtml(sp.filed_by_login)}` : 'an unnamed builder';
+      const when = sp.captured_at ? ` · ${escapeHtml(String(sp.captured_at).slice(0, 10))}` : '';
+      return `
+        <div class="fi-spark">
+          <p class="fi-spark__title"><a href="${hallBase()}/idea/${encodeURIComponent(sp.id)}">${escapeHtml(sp.title || `Idea ${sp.id}`)}</a></p>
+          <span class="fi-spark__who">had by ${who}${when}</span>
+          <a class="fi-spark__go btn btn--ghost" href="?develop=${encodeURIComponent(sp.id)}">Develop this →</a>
+        </div>`;
+    }).join('')}</div>${more}`;
+  }
+
+  async function loadQueue() {
+    const r = await api.inbox.getInboxSparks({});
+    // The queue is secondary to the composer: an outage here must not stop
+    // someone writing, so it degrades to a line rather than an error state.
+    if (!r.ok || !r.data) {
+      $('#fi-queue').innerHTML = '<p class="fi-queue-empty">Could not load the queue just now.</p>';
+      return;
+    }
+    renderQueue(r.data.sparks, r.data.count);
+  }
+
+  // ---------------------------------------------------------------------------
+  // develop mode
+  // ---------------------------------------------------------------------------
+
+  // Show the spark's own words above the fields, and make the title a FACT rather
+  // than an input. Returns false when the idea cannot be developed, so boot can
+  // say why instead of presenting a form that will 409.
+  function enterDevelopMode(idea) {
+    if (idea.grade !== 'spark') {
+      $('#fi-sub').textContent = idea.grade === 'full'
+        ? `Idea ${idea.id} has already been developed into a Full Idea.`
+        : `Idea ${idea.id} is not a Big Idea Spark — only its author can offer it up for development.`;
+      $('#fi-form').hidden = true;
+      return false;
+    }
+    $('#fi-develop').hidden = false;
+    $('#fi-develop-title').textContent = idea.title || `Idea ${idea.id}`;
+    $('#fi-develop-body').textContent = String(idea.body_md || '').trim();
+    $('#fi-develop-who').textContent = idea.filed_by_login
+      ? `had by @${idea.filed_by_login}${idea.captured_at ? ` · ${String(idea.captured_at).slice(0, 10)}` : ''} — they keep the credit for the thought`
+      : 'they keep the credit for the thought';
+    // The title is the existing idea's. Shown, not editable: developing an idea
+    // must not quietly rename it out from under its author.
+    const t = titleEl();
+    t.value = idea.title || '';
+    t.readOnly = true;
+    t.tabIndex = -1;
+    $('#fi-title-label').hidden = true;
+    t.hidden = true;
+    $('#fi-submit').textContent = 'Develop this idea';
+    $('#fi-sub').textContent = 'Answer the five questions and this spark becomes a Full Idea.';
+    return true;
+  }
+
   async function main() {
     const r = await api.inbox.getInboxTemplate({});
     if (!r.ok || !r.data || !r.data.template) {
@@ -323,6 +434,22 @@
     $('#fi-form').addEventListener('submit', file);
     $('#fi-clear').addEventListener('click', discard);
 
+    // The queue loads on every visit, develop mode or not: having just picked one
+    // up, seeing what else is waiting is the natural next thing.
+    loadQueue();
+
+    if (DEVELOP_ID) {
+      const d = await api.inbox.getInboxId({ id: DEVELOP_ID });
+      if (!d.ok || !d.data || !d.data.idea) {
+        $('#fi-sub').textContent = `Could not load idea ${DEVELOP_ID}.`;
+        $('#fi-form').hidden = true;
+        return;
+      }
+      if (!enterDevelopMode(d.data.idea)) return;
+      // Re-run the button rule now that the title requirement is lifted.
+      onEdit();
+    }
+
     if (usable) {
       note('Draft restored.');
       scoreNow();

package/modules/hall-ui/public/task-detail.js

@@ -118,6 +118,19 @@
     }
     if (r.shipped_at) nodes.push(h('p', 'deeplink-card__note', 'Shipped ' + fmtRel(r.shipped_at)));
 
+    // task 1002929 (R153): an idea now has a real page, and this card cannot show
+    // a Full Idea's five prose answers legibly — so it stops pretending to and
+    // points at the page instead. The overlay KEEPS the triage panel below (~320
+    // lines of promote/merge/discard); this is the summary→detail relationship the
+    // Work board already has with /task/:id, not a replacement.
+    if (kind === 'idea') {
+      var fv = h('p', 'deeplink-card__note');
+      var fl = h('a', 'deeplink-card__link', r.grade === 'full' ? 'Read the full idea →' : 'Open this idea →');
+      fl.href = hallBase() + '/idea/' + encodeURIComponent(r.id);
+      fv.appendChild(fl);
+      nodes.push(fv);
+    }
+
     // task 759 → task 1002447: Metic+ idea triage, right in the overlay (no
     // /idea-triage skill and no LLM in the loop). 759 shipped Discard alone;
     // 1002447 adds the other two verbs so the whole verdict set is reachable

package/modules/ideas/inbox.js

@@ -507,11 +507,24 @@ async function listOpenIdeas({ kind = null, limit = 50, viewerRank = null } = {}
   return rows;
 }
 
+// The by-id read. It carries the two people's LOGINS as well as their ids
+// (task 1002929 / R153): an idea's attribution is a claim about humans, and
+// "captured_by: 41" is not attribution to anyone reading it. Named to match the
+// R145 spark queue's `filed_by_login` so the two idea surfaces agree.
+//
+// Both joins are LEFT: a builder row can be missing (an FK that went
+// ON DELETE SET NULL), and an idea nobody developed has no developer at all —
+// which is the common case, not an error. A plain JOIN here would drop most of
+// the inbox, the same trap the grade join documents above.
 async function getIdea(id) {
   const { rows } = await pool.query(
-    `SELECT ${IDEA_COLS_Q}, ${GRADE_COLS_Q}
+    `SELECT ${IDEA_COLS_Q}, ${GRADE_COLS_Q},
+            ba.github_login AS filed_by_login,
+            bd.github_login AS developed_by_login
        FROM idea_inbox i
        ${IDEA_JOIN_GRADE}
+       LEFT JOIN builders ba ON ba.id = i.captured_by
+       LEFT JOIN builders bd ON bd.id = g.developed_by
       WHERE i.id = $1`,
     [id]
   );

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.299",
+  "version": "1.19.301",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.299",
+      "version": "1.19.301",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.299",
+  "version": "1.19.301",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/bongos/serve-internal.js

@@ -881,9 +881,15 @@ function mountInternalSurfaces(app) {
   // needs its own two-segment match ahead of the single-segment resolution
   // below. Same gate tier as Work/Roadmap/Goals (SIGNEDIN_BUILDERS_PAGE_RE).
   const TASK_DETAIL_PAGE_RE = /^\/builders\/task\/(\d+)\/?$/;
+  // task 1002929 (R153 of goal 1000062): the idea-detail page is the SECOND
+  // two-segment hall page — /builders/idea/:id — for the same reason task 751 gave
+  // the task one: a record with real prose in it deserves a shareable URL and
+  // working back/forward, not a modal. Same gate tier as the task page.
+  const IDEA_DETAIL_PAGE_RE = /^\/builders\/idea\/(\d+)\/?$/;
   function buildersHtmlName(reqPath) {
     if (reqPath === '/builders' || reqPath === '/builders/') return 'index.html';
     if (TASK_DETAIL_PAGE_RE.test(reqPath)) return buildersHtml['task.html'] ? 'task.html' : null;
+    if (IDEA_DETAIL_PAGE_RE.test(reqPath)) return buildersHtml['idea.html'] ? 'idea.html' : null;
     // e.g. /builders/ranks or /builders/ranks.html → ranks.html
     const m = reqPath.match(BUILDERS_PAGE_RE);
     if (m) {
@@ -956,7 +962,7 @@ function mountInternalSurfaces(app) {
     // behind the proxy's path normalization.
     const norm = path.posix.normalize(req.path);
     if (SIGNEDIN_BUILDERS_PAGE_RE.test(norm) || SIGNEDIN_BUILDERS_PREFIX_RE.test(norm)
-      || TASK_DETAIL_PAGE_RE.test(norm)) {
+      || TASK_DETAIL_PAGE_RE.test(norm) || IDEA_DETAIL_PAGE_RE.test(norm)) {
       return gdsAuth.requireBuilderPage(req, res, next);
     }
     next();

package/src/module-api.js

@@ -1025,8 +1025,12 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.297 with no explicit bump. run 32597859474. (task 1002620)
 //   1.19.299 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.298 with no explicit bump. run 32600322268. (task 1002620)
+//   1.19.300 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.299 with no explicit bump. run 32601521458. (task 1002620)
+//   1.19.301 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.300 with no explicit bump. run 32602146266. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.299'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.301'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');