@bongos/core 1.19.279 → 1.19.281

package/tests/claim_error_surface.mjs

@@ -14,7 +14,7 @@ import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
 
 const require = createRequire(import.meta.url);
-const { formatClaimFailure } = require('../scripts/gds/claim.js');
+const { formatClaimFailure, claimErrorInfo, goalMembershipOfferPlan } = require('../scripts/gds/claim.js');
 
 let passed = 0;
 let failed = 0;
@@ -36,7 +36,7 @@ t('never dumps [object Object] for any known code', () => {
     'session_already_has_bound_claim',
     'newcomer_must_ship_first', 'ALREADY_CLAIMED', 'MODULE_CONFLICT',
     'TOUCHES_CONFLICT', 'TASK_NOT_READY', 'TASK_NOT_FOUND', 'DEPS_NOT_SHIPPED',
-    'OPEN_BLOCKER',
+    'OPEN_BLOCKER', 'GOAL_MEMBERSHIP_REQUIRED',
     'some_unmapped_future_code',
   ];
   for (const c of codes) {
@@ -138,5 +138,58 @@ t('unknown code: fallback carries code + message, exit 1', () => {
   assert.match(text(r), /boom/);
 });
 
+// ---- task 1003138: the goal-membership refusal is resolvable in-session ----
+// The task-1003137 gate returns 403 GOAL_MEMBERSHIP_REQUIRED with { goal_id,
+// visibility, action: join|apply, goal_title? }. claim.js offers the join (or
+// files the application) inline; these pin the pure halves — the offer plan and
+// the non-interactive fallthrough rendering.
+
+t('GOAL_MEMBERSHIP_REQUIRED fallthrough: join names the one-command path, apply names the approval wait', () => {
+  const join = text(formatClaimFailure(
+    envelope('GOAL_MEMBERSHIP_REQUIRED', { goal_id: 1000045, visibility: 'public', action: 'join', goal_title: 'Public builder profiles' }, 'not a member', 403), 1002784));
+  assert.match(join, /goal 1000045/);
+  assert.match(join, /Public builder profiles/);
+  assert.match(join, /--join/, 'join path advertises the one-command re-run');
+  const apply = text(formatClaimFailure(
+    envelope('GOAL_MEMBERSHIP_REQUIRED', { goal_id: 1000099, visibility: 'private', action: 'apply' }, 'not a member', 403), 5));
+  assert.match(apply, /goal 1000099/);
+  assert.match(apply, /approv/i, 'apply path says approval gates the claim');
+});
+
+t('goalMembershipOfferPlan: join offer matches the owner-approved shape (goal named, title shown, [Y/n])', () => {
+  const p = goalMembershipOfferPlan({ goal_id: 1000045, visibility: 'public', action: 'join', goal_title: 'Public builder profiles' }, 1002784);
+  assert.equal(p.action, 'join');
+  assert.match(p.headerLines[0], /Task 1002784 lives in goal 1000045/);
+  assert.match(p.headerLines[1], /"Public builder profiles" \(public\)/);
+  assert.match(p.headerLines[2], /not a member/i);
+  assert.equal(p.question, 'Join goal 1000045 and claim? [Y/n] ');
+});
+
+t('goalMembershipOfferPlan: private goal offers apply and shows no title (there is none to leak)', () => {
+  const p = goalMembershipOfferPlan({ goal_id: 1000099, visibility: 'private', action: 'apply' }, 5);
+  assert.equal(p.action, 'apply');
+  assert.deepEqual(p.headerLines, ['✗ Goal 1000099 is private.']);
+  assert.equal(p.question, 'Apply to join? [Y/n] ');
+});
+
+t('goalMembershipOfferPlan: public protected-scope goal offers apply and says why', () => {
+  const p = goalMembershipOfferPlan({ goal_id: 7, visibility: 'public', action: 'apply', goal_title: 'Core wall' }, 5);
+  assert.equal(p.action, 'apply');
+  assert.match(p.headerLines[0], /Archon-mediated/i);
+});
+
+t('goalMembershipOfferPlan: a malformed body plans nothing (falls back to formatClaimFailure)', () => {
+  assert.equal(goalMembershipOfferPlan(null, 5), null);
+  assert.equal(goalMembershipOfferPlan({ action: 'join' }, 5), null, 'no goal_id → no plan');
+  assert.equal(goalMembershipOfferPlan({ goal_id: 7, action: 'teleport' }, 5), null, 'unknown action → no plan');
+});
+
+t('claimErrorInfo: reads envelope and flat shapes identically', () => {
+  const env = claimErrorInfo(envelope('X', { a: 1 }, 'msg'));
+  assert.equal(env.code, 'X'); assert.equal(env.message, 'msg'); assert.equal(env.d.a, 1);
+  const flat = claimErrorInfo({ status: 409, data: { error: 'X', a: 1 } });
+  assert.equal(flat.code, 'X'); assert.equal(flat.d.a, 1);
+});
+
 console.log(`\nclaim_error_surface: ${passed} passed, ${failed} failed`);
 process.exit(failed === 0 ? 0 : 1);

package/tests/goal_criterion_confirm_ui.mjs

@@ -37,6 +37,9 @@ const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-page.j
 // the REAL file in the same context rather than stubbing it — stubbing would let
 // the extraction rot without this, the only test that executes either board.
 const TASK_LIB_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/task-lib.js'), 'utf8');
+// task 1003135: the page's pure presentational helpers moved to goals-lib.js
+// (window.OTBGoalsLib) — run the REAL file too, same reasoning as task-lib above.
+const GOALS_LIB_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-lib.js'), 'utf8');
 
 const { test, summary } = makeRunner();
 
@@ -132,6 +135,7 @@ async function render({ rank = 'metic', goalStatus = 'open', criteria = Object.v
   sandbox.globalThis = sandbox;
   vm.createContext(sandbox);
   vm.runInContext(TASK_LIB_SRC, sandbox, { filename: 'task-lib.js' });
+  vm.runInContext(GOALS_LIB_SRC, sandbox, { filename: 'goals-lib.js' });
   vm.runInContext(SRC, sandbox, { filename: 'goals-page.js' });
 
   // Let boot()'s promise chain settle (me → goals → details → route → render).

package/tests/goals_lib.mjs

@@ -0,0 +1,70 @@
+// tests/goals_lib.mjs — the Goals page's extracted pure helpers (goals-lib.js,
+// task 1003135). Pins (a) that the lib loads standalone in a bare window — it
+// must not silently grow a dependency on the page's IIFE state, which is the
+// whole reason it could move out of the oversized goals-page.js — and (b) the
+// behaviour of the helpers the page destructures.
+//
+// Run:  node tests/goals_lib.mjs
+
+import { strict as assert } from 'node:assert';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+import { makeRunner } from './helpers.mjs';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-lib.js'), 'utf8');
+const { test, summary } = makeRunner();
+
+const windowObj = {};
+const sandbox = { window: windowObj, Set, Map, Math, Number, String, Array, Object, Date, JSON };
+sandbox.globalThis = sandbox;
+vm.createContext(sandbox);
+vm.runInContext(SRC, sandbox, { filename: 'goals-lib.js' });
+const lib = windowObj.OTBGoalsLib;
+
+await test('loads standalone in a bare window (no page-state dependency) and exports the full surface', () => {
+  assert.ok(lib, 'window.OTBGoalsLib must be set');
+  for (const k of ['DONE_STATUSES', 'CUT_STATUSES', 'isTodoStatus', 'ring', 'memberName',
+    'readinessOf', 'EMPTY_ROLLUP', 'goalRollLine', 'matchesTodoSearch', 'msOf', 'taskActivityMs']) {
+    assert.ok(k in lib, `missing export: ${k}`);
+  }
+});
+
+await test('readinessOf buckets match the task-1002439 rules', () => {
+  assert.equal(lib.readinessOf({ status: 'shipped' }), 'done');
+  assert.equal(lib.readinessOf({ status: 'abandoned' }), 'cut');
+  assert.equal(lib.readinessOf({ status: 'active' }), 'active');
+  assert.equal(lib.readinessOf({ status: 'ready' }), 'ready');
+  assert.equal(lib.readinessOf({ status: 'backlog', blocked_by: [{ satisfied: false }] }), 'blocked');
+  assert.equal(lib.readinessOf({ status: 'backlog' }), 'backlog');
+});
+
+await test('matchesTodoSearch: bare number, #N and title fragments all match (task 1003135 search semantics)', () => {
+  const t = { id: 1002163, title: 'Show the goal id on the row' };
+  assert.ok(lib.matchesTodoSearch(t, ''));
+  assert.ok(lib.matchesTodoSearch(t, '1002163'));
+  assert.ok(lib.matchesTodoSearch(t, '#1002163'));
+  assert.ok(lib.matchesTodoSearch(t, '2163'), 'substring id match');
+  assert.ok(lib.matchesTodoSearch(t, 'goal id'));
+  assert.ok(!lib.matchesTodoSearch(t, 'zzz'));
+  assert.ok(lib.matchesTodoSearch(t, '#'), 'a lone # narrows nothing');
+});
+
+await test('goalRollLine renders only non-zero buckets; ring is well-formed SVG', () => {
+  const line = lib.goalRollLine({ ready: 2, active: 0, blocked: 1, backlog: 0 });
+  assert.match(line, /<b>2<\/b> ready/);
+  assert.match(line, /<b>1<\/b> blocked/);
+  assert.ok(!line.includes('in progress'), 'zero buckets are omitted');
+  assert.equal(lib.goalRollLine({ ready: 0, active: 0, blocked: 0, backlog: 0 }), '');
+  assert.match(lib.ring(2, 5, false), /aria-label="2 of 5 criteria satisfied"/);
+});
+
+await test('memberName label idiom: display name, then @login, then builder #id', () => {
+  assert.equal(lib.memberName({ display_name: 'A', github_login: 'a', builder_id: 1 }), 'A');
+  assert.equal(lib.memberName({ github_login: 'a', builder_id: 1 }), '@a');
+  assert.equal(lib.memberName({ builder_id: 1 }), 'builder #1');
+});
+
+summary();