@bongos/core 1.19.254 → 1.19.255

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.254",
-  "core_contract": "1.19.254",
-  "source_commit": "5955d399c73ae928fb94ecf67c3c1a59f2688dcd",
+  "core_version": "1.19.255",
+  "core_contract": "1.19.255",
+  "source_commit": "85c97e23dbe8dee636e134ee8f5eac4983051c1f",
   "source_ref": "HEAD",
-  "built_at": "2026-08-19T02:09:24.775Z",
+  "built_at": "2026-08-19T02:17:10.653Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 315,
     "agent_docs_stubbed": 22,
-    "functional_verbatim": 1347,
+    "functional_verbatim": 1348,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1684,
-  "tree_sha256": "a11f4b0d4a9487d13e0c01a48dcf28c80f4f008045403cc5388cb40c72bd3462",
+  "file_count": 1685,
+  "tree_sha256": "d3086bc5b3687de018836883dc4e7a1af8239ce05719be7c6b2af45a4876619d",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -4437,12 +4437,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "c880668f9420934895a29f1442f4db984dbaea35a93de7399f97353d6e5356f9"
+      "sha256": "edf60a53538729a978886acc667ba4b8a81f654924873b138520f54e52ad6bf6"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "80552b01c8d22ddfa1f5bf0e479dfe27c4e62e2e932555237f418bbe18edfd22"
+      "sha256": "aad3432c2f8c51687d6b16e5caf66fd2c7e01901cb9756ccca2fd700fe117021"
     },
     {
       "path": "public-docs/index.html",
@@ -6062,7 +6062,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "0f52e5cbb0bc88abd77cdc790b563c8a2766ed6d4a5a73240343b15655f07442"
+      "sha256": "b34d89b988d753c21364242217269cce8fb4db8719598bd6f2c458507ffad512"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6522,7 +6522,7 @@
     {
       "path": "tests/claude_materialize.mjs",
       "mode": "0000644",
-      "sha256": "ba55196528236a9473d7038f00f7c7c0d6c8bd9fd05bfe2b11d94688e97cdb90"
+      "sha256": "6d31d8597e3b1e9e7efde56f9a3839715cfa87378e7555f0fa3b26b09346a569"
     },
     {
       "path": "tests/clawback_confirmed_backlog.mjs",
@@ -7272,7 +7272,7 @@
     {
       "path": "tests/hook_user_agents.mjs",
       "mode": "0000644",
-      "sha256": "7289010b4d9e52bce152b4acba1cd6e17f747756719664c7f7e07ac818f885b7"
+      "sha256": "ed1e14050ba219a52736c2cd70f4d4333a345fb0018211c85293a995c7f0aac7"
     },
     {
       "path": "tests/host_topology_skips.mjs",
@@ -8014,6 +8014,11 @@
       "mode": "0000644",
       "sha256": "886bf7096cbdb3b758010eb0ee24e15bd74033a7bff0064b742585440cdeee79"
     },
+    {
+      "path": "tests/secret_gate.mjs",
+      "mode": "0000644",
+      "sha256": "20de62b7d869763c703317dae4bc3896cbf4308d1211c8fcbffbfbd32465b1b5"
+    },
     {
       "path": "tests/security_docs.mjs",
       "mode": "0000644",

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.254",
+  "version": "1.19.255",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.254",
+      "version": "1.19.255",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.254",
+  "version": "1.19.255",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -935,8 +935,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.252 with no explicit bump. run 32205833181. (task 1002620)
 //   1.19.254 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.253 with no explicit bump. run 32207504942. (task 1002620)
+//   1.19.255 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.254 with no explicit bump. run 32207967928. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.254'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.255'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/claude_materialize.mjs

@@ -214,7 +214,15 @@ t('materializeClaude: copied hooks carry NO founder origin/config-dir; a disable
   writeFileSync(join(dir, 'config', 'branding.json'), JSON.stringify({ domains: { publicOrigin: 'https://demo.cloudbongos.com', buildersOrigin: 'https://demo.cloudbongos.com', statusOrigin: 'https://demo.cloudbongos.com', oauthOrigin: 'https://demo.cloudbongos.com' }, configDir: 'cloudbongos', envPrefix: 'CLOUDBONGOS' }));
   writeFileSync(join(dir, 'config', 'modules.json'), JSON.stringify({ modules: { 'art-pipeline': false } }));
   const res = m.materializeClaude({ coreRoot: ROOT, instanceDir: dir, dryRun: false });
-  assert.ok(res.rebrandRules > 0, 'rebrand rules were built from the OTB→demo branding delta');
+  // Founder core → demo: a branding delta exists and rules are built. The NEUTRAL
+  // core now carries its own dev-loop hooks (task 1003125), so this body runs there
+  // too — where no founder delta exists by design and rules are legitimately zero.
+  // The founder-specific assertions below self-scope on that signal; the offender
+  // walk and the core-skill materialization checks run in both environments.
+  const founderDelta = res.rebrandRules > 0;
+  if (!founderDelta) {
+    assert.equal(res.rebrandRules, 0, 'neutral core: no founder→instance branding delta');
+  }
 
   // (a) no copied hook may still name the founder origin or config dir.
   const offenders = [];
@@ -226,8 +234,11 @@ t('materializeClaude: copied hooks carry NO founder origin/config-dir; a disable
   assert.deepEqual(offenders, [], `founder origin/config-dir survived in: ${offenders.join(', ')}`);
 
   // (b) art-pipeline is off → its otb-* skills are excluded; a core skill remains.
-  assert.ok(res.excludedSkills.includes('otb-tile-generate'), `art-pipeline skill excluded (got ${res.excludedSkills.join(',')})`);
-  assert.ok(!existsSync(join(dir, '.claude', 'skills', 'otb-tile-generate')), 'excluded skill not written');
+  //     (The exclusion map, like the rebrand rules, resolves on a founder core.)
+  if (founderDelta) {
+    assert.ok(res.excludedSkills.includes('otb-tile-generate'), `art-pipeline skill excluded (got ${res.excludedSkills.join(',')})`);
+    assert.ok(!existsSync(join(dir, '.claude', 'skills', 'otb-tile-generate')), 'excluded skill not written');
+  }
   assert.ok(existsSync(join(dir, '.claude', 'skills', 'builder-ship')), 'a core skill is still materialized');
   rmSync(dir, { recursive: true, force: true });
 });

package/tests/hook_user_agents.mjs

@@ -61,7 +61,15 @@ t('every hook User-Agent uses the neutral cloud-bongos- prefix (no founder-brand
       if (!ua.startsWith(NEUTRAL_PREFIX)) offenders.push(`${f}: '${ua}'`);
     }
   }
-  assert.ok(uaCount > 0, 'expected at least one User-Agent literal across the hooks (regex drift?)');
+  // Drift canary, scoped: the neutral core may carry hooks that make no HTTP
+  // calls at all (e.g. .claude/hooks/secret-gate.js, task 1003125), so demand a
+  // regex match only when some hook raw-contains the header name — raw substring
+  // present with zero regex matches is the drift this canary exists to catch.
+  const rawMentions = hookFiles.some((f) =>
+    fs.readFileSync(path.join(HOOKS_DIR, f), 'utf8').includes('User-Agent'));
+  if (rawMentions) {
+    assert.ok(uaCount > 0, 'hooks mention User-Agent but the regex matched none (regex drift?)');
+  }
   assert.equal(
     offenders.length, 0,
     `hook User-Agent(s) not neutral (must start with "${NEUTRAL_PREFIX}"):\n  ${offenders.join('\n  ')}`

package/tests/secret_gate.mjs

@@ -0,0 +1,124 @@
+// tests/secret_gate.mjs — the PreToolUse prevent layer (task 1003125, goal 1000076).
+// The gate's contract: block high-confidence secret shapes in Write/Edit/Bash
+// payloads, allow the files whose job is to hold those shapes, and fail OPEN on
+// anything it does not understand (it is the cooperative layer — ADR 0043 shape;
+// the CI scan and the weekly patrol are the nets behind it).
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const gate = require(path.join(ROOT, '.claude', 'hooks', 'secret-gate.js'));
+
+const ENV_OFF = {}; // no kill-switch
+
+// Realistic-shaped fakes (NOT real credentials — lengths and prefixes only).
+const FAKE = {
+  anthropic: 'sk-ant-api03-Zx9Yw8Vu7Ts6Rq5Po4Nm3Lk2Jh1Gf0De',
+  github: 'ghp_Ab1Cd2Ef3Gh4Ij5Kl6Mn7Op8Qr9St0Uv1Wx2Y',
+  aws: 'AKIAIOSFODNN7EXAMPLE',
+  slack: 'xoxb-1234567890-abcdefghij',
+  stripe: 'sk_live_Ab1Cd2Ef3Gh4Ij5Kl6M',
+  pem: '-----BEGIN OPENSSH PRIVATE KEY-----\nb3BlbnNzaA\n-----END OPENSSH PRIVATE KEY-----',
+  dburl: 'postgres://gds:hunter2secret@db.internal:5432/app',
+};
+
+test('blocks a Write whose content carries a provider-prefixed token', () => {
+  for (const [name, value] of Object.entries(FAKE)) {
+    const v = gate.decide(
+      { tool_name: 'Write', tool_input: { file_path: 'src/bongos/newfile.js', content: `const k = "${value}";` } },
+      ENV_OFF,
+    );
+    assert.equal(v.block, true, `expected block for ${name}`);
+    assert.match(v.reason, /secret-gate: blocked/);
+  }
+});
+
+test('blocks an Edit new_string and a MultiEdit edit the same way', () => {
+  assert.equal(
+    gate.decide({ tool_name: 'Edit', tool_input: { file_path: 'server.js', new_string: FAKE.github } }, ENV_OFF).block,
+    true,
+  );
+  assert.equal(
+    gate.decide(
+      { tool_name: 'MultiEdit', tool_input: { file_path: 'server.js', edits: [{ new_string: 'clean' }, { new_string: FAKE.aws }] } },
+      ENV_OFF,
+    ).block,
+    true,
+  );
+});
+
+test('blocks a Bash command smuggling a literal token; allows ordinary commands', () => {
+  assert.equal(
+    gate.decide({ tool_name: 'Bash', tool_input: { command: `echo "${FAKE.anthropic}" >> notes.txt` } }, ENV_OFF).block,
+    true,
+  );
+  for (const cmd of [
+    'git commit -m "feat: rotate the key handling (ADR 0022)"',
+    'export GH_TOKEN=$(gh auth token -u somebuilder) && git fetch origin',
+    'npm test',
+  ]) {
+    assert.equal(gate.decide({ tool_name: 'Bash', tool_input: { command: cmd } }, ENV_OFF).block, false, `false positive on: ${cmd}`);
+  }
+});
+
+test('clean writes pass; short/placeholder shapes below the length floors pass', () => {
+  for (const content of [
+    'const label = "use your ghp_ token here";', // prefix alone, no 30-char body
+    'sk-ant- keys resolve from the env lane',
+    'AKIA is the AWS key id prefix',
+    'const url = "postgres://localhost:5432/app";', // no embedded password
+  ]) {
+    assert.equal(
+      gate.decide({ tool_name: 'Write', tool_input: { file_path: 'docs/notes.md', content } }, ENV_OFF).block,
+      false,
+      `false positive on: ${content}`,
+    );
+  }
+});
+
+test('allowlisted paths may hold secret shapes (fixtures, detectors, ADRs, the gate itself)', () => {
+  for (const fp of [
+    'tests/bfg.mjs',
+    `${ROOT}/tests/bfg.mjs`, // absolute form matches too (segment-anchored)
+    'docs/adr/0022-secrets-policy.md',
+    'modules/security/artifact-scan/detectors/credentials.js',
+    '.claude/hooks/secret-gate.js',
+    '.gitleaks.toml',
+  ]) {
+    const v = gate.decide({ tool_name: 'Write', tool_input: { file_path: fp, content: FAKE.pem } }, ENV_OFF);
+    assert.equal(v.block, false, `allowlist miss for ${fp}`);
+  }
+  // …but the allowlist is by SEGMENT, not substring: a lookalike dir stays blocked.
+  assert.equal(
+    gate.decide({ tool_name: 'Write', tool_input: { file_path: 'src/latests/x.js', content: FAKE.pem } }, ENV_OFF).block,
+    true,
+    'lookalike path must not satisfy the tests/ allowlist',
+  );
+});
+
+test('Bash never gets the path allowlist (commands have no file_path)', () => {
+  const v = gate.decide(
+    { tool_name: 'Bash', tool_input: { file_path: 'tests/bfg.mjs', command: `echo ${FAKE.github}` } },
+    ENV_OFF,
+  );
+  assert.equal(v.block, true);
+});
+
+test('kill-switch disables the gate; malformed payloads fail open', () => {
+  assert.equal(
+    gate.decide({ tool_name: 'Write', tool_input: { file_path: 'x.js', content: FAKE.github } }, { BONGOS_SECRET_GATE_OFF: '1' }).block,
+    false,
+  );
+  assert.equal(gate.decide(null, ENV_OFF).block, false);
+  assert.equal(gate.decide({}, ENV_OFF).block, false);
+  assert.equal(gate.decide({ tool_name: 'Write' }, ENV_OFF).block, false);
+});
+
+test('unknown writing tools are scanned via the stringified payload, not skipped', () => {
+  const v = gate.decide({ tool_name: 'FutureWriteTool', tool_input: { blob: FAKE.stripe } }, ENV_OFF);
+  assert.equal(v.block, true);
+});