@bongos/core 1.19.249 → 1.19.250

package/modules/hall-ui/public/copy-desk.js

@@ -0,0 +1,352 @@
+// modules/hall-ui/public/copy-desk.js — the hall "Copy desk" tab
+// (/builders/copy-desk). Task 1003113 / R02 of goal 1000074, the artist's loop.
+//
+// The surface half of the flag: R01 built the inventory of every string the
+// product shows a person; the copy-desk module turned "this one is wrong" into a
+// row; this page is where an artist reads those rows and where everyone else
+// files them.
+//
+// FOUR PANELS, IN THE ORDER AN ARTIST WOULD WORK:
+//   1. the counts — what is outstanding, and the fast pile
+//   2. Flagged — the queue itself, newest first, open by default
+//   3. Said more than once — the deterministic duplicate signal, minus what has
+//      already been flagged or dismissed
+//   4. Find something to flag — search the whole inventory
+//
+// NO LIVE CMS. Nothing on this page edits a string. The composer collects a
+// JUDGEMENT (kind + reason); the fix ships as a claimed, graded task. There is
+// deliberately no "new text" field — see modules/copy-desk/tests/copy_no_cms.mjs.
+
+(() => {
+  'use strict';
+
+  const API = '/api/bongos';
+  const api = window.BongosClient.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false });
+  const { escapeHtml, $, toast, fmtInt } = window.OTB;
+
+  let viewer = null;
+  let queue = null;
+  // The composer's current target, set when a "Flag" button is pressed.
+  let target = null;
+  let closing = null;
+
+  // ---------------------------------------------------------------------------
+  // rendering helpers
+  // ---------------------------------------------------------------------------
+
+  // A string shown as evidence is UNTRUSTED text from the product's own source
+  // tree, rendered into this page — so it is escaped like any other user data,
+  // and clipped so one runaway template literal cannot push the queue off screen.
+  function quote(text, max = 240) {
+    const s = String(text == null ? '' : text);
+    const clipped = s.length > max ? `${s.slice(0, max)}…` : s;
+    return `<q class="cd-quote">${escapeHtml(clipped)}</q>`;
+  }
+
+  function where(file, line) {
+    if (!file) return '';
+    return `<span class="cd-where">${escapeHtml(file)}${Number.isInteger(line) ? `:${line}` : ''}</span>`;
+  }
+
+  const KIND_LABEL = {
+    'off-voice': 'off voice', slop: 'slop', unclear: 'unclear',
+    stale: 'stale', duplicate: 'duplicate', typo: 'typo', other: 'flagged',
+  };
+
+  // The three states a flag's target can be in (registry.js annotateFlag).
+  // 'gone' is the interesting one and is spelled out rather than iconified: it
+  // means the sentence was edited or deleted since the flag was filed, which is
+  // a strong hint the flag is resolvable — but a hint for a person to act on,
+  // never something the server closes on its own.
+  function targetState(f) {
+    if (f.target_state === 'gone') {
+      return '<span class="cd-tag cd-tag--gone" title="The string this flag names is no longer in the registry — it was edited or removed. Probably already fixed; confirm and close it.">target gone</span>';
+    }
+    if (f.moved) {
+      return '<span class="cd-tag cd-tag--moved" title="Same text, different place — it moved file or line since the flag was filed.">moved</span>';
+    }
+    return '';
+  }
+
+  function canClose(f) {
+    if (!viewer) return false;
+    if (String(f.flagged_by) === String(viewer.id)) return true;
+    return viewer.rank === 'metic' || viewer.rank === 'archon';
+  }
+
+  function flagRow(f) {
+    const who = escapeHtml(f.flagged_by_name || f.flagged_by_login || 'someone');
+    const when = f.flagged_at ? new Date(f.flagged_at).toLocaleDateString() : '';
+    // Show the live text when the string is still there, and the snapshot when it
+    // is not — labelled, so "what it says now" is never confused with "what it
+    // said when someone objected".
+    const body = f.current
+      ? `${quote(f.current.text)} ${where(f.current.file, f.current.line)}`
+      : `<span class="cd-snapshot-label">said, when flagged:</span> ${quote(f.text_at_flag)} ${where(f.file_at_flag, f.line_at_flag)}`;
+
+    const scopeLine = f.scope === 'surface'
+      ? `<span class="cd-tag">whole surface</span> <span class="cd-where">${escapeHtml(f.surface)}</span>`
+      : body;
+
+    const closed = f.status !== 'open'
+      ? `<p class="cd-closed"><strong>${escapeHtml(f.status)}</strong>${f.resolved_task_id ? ` in task ${escapeHtml(String(f.resolved_task_id))}` : ''} — ${escapeHtml(f.resolution_note || '')}</p>`
+      : '';
+
+    return `<article class="cd-card" data-flag="${escapeHtml(String(f.id))}">
+      <div class="cd-card__head">
+        <span class="cd-tag cd-tag--kind">${escapeHtml(KIND_LABEL[f.kind] || f.kind)}</span>
+        ${targetState(f)}
+        <span class="cd-byline">${who} · ${escapeHtml(when)}</span>
+      </div>
+      <div class="cd-card__target">${scopeLine}</div>
+      <p class="cd-reason">${escapeHtml(f.reason)}</p>
+      ${closed}
+      ${f.status === 'open' && canClose(f)
+        ? `<div class="cd-card__actions"><button class="btn btn--ghost cd-close-btn" data-flag="${escapeHtml(String(f.id))}">Close…</button></div>`
+        : ''}
+    </article>`;
+  }
+
+  function dupeRow(d) {
+    const state = d.flagged
+      ? '<span class="cd-tag cd-tag--flagged">already flagged</span>'
+      : d.settled
+        ? '<span class="cd-tag cd-tag--settled">looked at</span>'
+        : '<span class="cd-tag cd-tag--untouched">untouched</span>';
+    const places = (d.at || []).map((a) => `<li>${escapeHtml(a)}</li>`).join('');
+    return `<article class="cd-card">
+      <div class="cd-card__head">
+        ${state}
+        <span class="cd-byline">${escapeHtml(String(d.occurrences))} places · ${escapeHtml(d.surface)}</span>
+      </div>
+      <div class="cd-card__target">${quote(d.text)}</div>
+      <ul class="cd-places">${places}</ul>
+      ${d.flagged ? '' : `<div class="cd-card__actions"><button class="btn btn--ghost cd-flag-btn"
+        data-id="${escapeHtml(d.id)}" data-surface="${escapeHtml(d.surface)}" data-text="${escapeHtml(d.text)}">Flag this…</button></div>`}
+    </article>`;
+  }
+
+  function resultRow(e) {
+    return `<article class="cd-card cd-card--slim">
+      <div class="cd-card__target">${quote(e.text)} ${where(e.file, e.line)}</div>
+      <div class="cd-card__actions">
+        <span class="cd-byline">${escapeHtml(e.surface)} · ${escapeHtml(e.origin || '')}</span>
+        ${e.flagged
+          ? '<span class="cd-tag cd-tag--flagged">already flagged</span>'
+          : `<button class="btn btn--ghost cd-flag-btn" data-id="${escapeHtml(e.id)}" data-surface="${escapeHtml(e.surface)}" data-text="${escapeHtml(e.text)}">Flag this…</button>`}
+      </div>
+    </article>`;
+  }
+
+  // ---------------------------------------------------------------------------
+  // paint
+  // ---------------------------------------------------------------------------
+
+  function paintStats() {
+    const c = queue.counts;
+    const r = queue.registry || {};
+    const total = (r.counts && r.counts.strings) || 0;
+    $('#cd-stats').innerHTML = [
+      ['Open flags', c.flags_open],
+      ['Target since edited', c.flags_target_gone],
+      ['Duplicates untouched', c.duplicates_untouched],
+      ['Strings inventoried', total],
+    ].map(([label, n]) =>
+      `<div class="cd-stat"><span class="cd-stat__n">${escapeHtml(String(fmtInt ? fmtInt(n) : n))}</span><span class="cd-stat__l">${escapeHtml(label)}</span></div>`
+    ).join('');
+
+    // Say which artifact this page is describing, and how to check it is current.
+    // The registry has no timestamp by design (its generator is deterministic and
+    // carries no clock), so this page must not imply one — it names the file and
+    // the command instead of showing an age that would be the checkout's.
+    const blind = (r.blind_spots || []).length;
+    $('#cd-registry-note').innerHTML =
+      `Read from <code>${escapeHtml(r.at || 'the copy registry')}</code> as committed. `
+      + `It is generated, not live: run <code>${escapeHtml(r.freshness_check || 'node scripts/gds/copy-inventory.js --check')}</code> to see whether it still matches the tree.`
+      + (blind ? ` This inventory has ${blind} documented blind spot${blind === 1 ? '' : 's'} — server-side messages, skill prose and runtime-composed strings are not in it, so it is not every word the project says.` : '');
+  }
+
+  function paintFlags() {
+    const el = $('#cd-flags');
+    if (!queue.flags.length) {
+      el.innerHTML = '<div class="cd-empty">Nothing flagged here. That is either good news or an unread queue — the duplicates below are the cheapest place to find out.</div>';
+      return;
+    }
+    el.innerHTML = queue.flags.map(flagRow).join('');
+  }
+
+  function paintDupes() {
+    const el = $('#cd-dupes');
+    const rows = queue.duplicates || [];
+    if (!rows.length) { el.innerHTML = '<div class="cd-empty">No duplicated strings in the registry.</div>'; return; }
+    // Untouched first — it is the only part of this list that is work.
+    const ordered = [...rows].sort((a, b) =>
+      (Number(a.flagged || a.settled) - Number(b.flagged || b.settled)) || (b.occurrences - a.occurrences));
+    el.innerHTML = ordered.map(dupeRow).join('');
+  }
+
+  function paintSurfaces() {
+    const sel = $('#cd-surface');
+    const surfaces = Object.keys((queue.registry && queue.registry.surfaces) || {});
+    sel.innerHTML = '<option value="">All surfaces</option>'
+      + surfaces.map((s) => `<option value="${escapeHtml(s)}">${escapeHtml(s)}</option>`).join('');
+  }
+
+  // ---------------------------------------------------------------------------
+  // load
+  // ---------------------------------------------------------------------------
+
+  async function loadQueue() {
+    const status = $('#cd-status').value;
+    const surface = $('#cd-surface').value;
+    const qs = new URLSearchParams({ status });
+    if (surface) qs.set('surface', surface);
+
+    const res = await api.request('GET', `${API}/copy-desk/queue?${qs}`);
+    if (!res.ok) {
+      const code = res.data && res.data.error && res.data.error.code;
+      const detail = (res.data && res.data.error && res.data.error.details) || {};
+      $('#cd-sub').textContent = code === 'registry_missing'
+        ? `No copy registry on this instance yet. Run ${detail.run || 'node scripts/gds/copy-inventory.js'} and commit it.`
+        : 'Could not load the copy desk.';
+      $('#cd-flags').innerHTML = '<div class="cd-empty">—</div>';
+      $('#cd-dupes').innerHTML = '<div class="cd-empty">—</div>';
+      return;
+    }
+    queue = res.data;
+    if (!$('#cd-surface').value && $('#cd-surface').options.length <= 1) paintSurfaces();
+    $('#cd-sub').textContent = 'The words this project shows people — what has been flagged, and what nobody has looked at.';
+    paintStats();
+    paintFlags();
+    paintDupes();
+  }
+
+  let searchTimer = null;
+  async function runSearch() {
+    const q = $('#cd-search').value.trim();
+    const surface = $('#cd-surface').value;
+    if (!q) { $('#cd-results').innerHTML = ''; $('#cd-search-count').textContent = ''; return; }
+
+    const qs = new URLSearchParams({ q });
+    if (surface) qs.set('surface', surface);
+    const res = await api.request('GET', `${API}/copy-desk/strings?${qs}`);
+    if (!res.ok) { $('#cd-search-count').textContent = 'Search failed.'; return; }
+
+    const { entries, matched, truncated, limit } = res.data;
+    // Say what is NOT shown. A silently capped list reads as a complete one.
+    $('#cd-search-count').textContent = truncated
+      ? `${matched} matches — showing the first ${limit}. Narrow the search to see the rest.`
+      : `${matched} match${matched === 1 ? '' : 'es'}.`;
+    $('#cd-results').innerHTML = entries.map(resultRow).join('');
+  }
+
+  // ---------------------------------------------------------------------------
+  // the composer
+  // ---------------------------------------------------------------------------
+
+  function openComposer(t) {
+    target = t;
+    $('#cd-dialog-target').innerHTML = t.string_id
+      ? `${quote(t.text)}<br><span class="cd-where">${escapeHtml(t.surface)}</span>`
+      : `<span class="cd-tag">whole surface</span> <span class="cd-where">${escapeHtml(t.surface)}</span>`;
+    $('#cd-reason').value = '';
+    $('#cd-dialog-err').textContent = '';
+    $('#cd-dialog').showModal();
+  }
+
+  async function submitFlag() {
+    const reason = $('#cd-reason').value.trim();
+    // Mirror the server's floor locally so the common case answers instantly —
+    // but the server and the DB constraint are the real gates, not this.
+    if (reason.replace(/\s+/g, ' ').length < 10) {
+      $('#cd-dialog-err').textContent = 'A flag needs a reason an artist can act on. What is wrong with it, and what would better look like?';
+      return;
+    }
+    const body = {
+      scope: target.string_id ? 'string' : 'surface',
+      surface: target.surface,
+      reason,
+      kind: $('#cd-kind').value,
+    };
+    if (target.string_id) body.string_id = target.string_id;
+
+    const res = await api.request('POST', `${API}/copy-desk/flags`, { body });
+    if (!res.ok) {
+      const err = (res.data && res.data.error) || {};
+      const d = err.details || {};
+      $('#cd-dialog-err').textContent = d.what_this_means || d.why || err.message || 'Could not file the flag.';
+      return;
+    }
+    $('#cd-dialog').close();
+    toast('Flagged. It is in the queue.');
+    await loadQueue();
+    if ($('#cd-search').value.trim()) await runSearch();
+  }
+
+  function openCloser(id) {
+    closing = queue.flags.find((f) => String(f.id) === String(id));
+    if (!closing) return;
+    $('#cd-close-target').innerHTML = `${quote(closing.reason, 160)}`;
+    $('#cd-close-note').value = '';
+    $('#cd-close-task').value = '';
+    $('#cd-close-err').textContent = '';
+    $('#cd-close-dialog').showModal();
+  }
+
+  async function submitClose() {
+    const note = $('#cd-close-note').value.trim();
+    if (note.replace(/\s+/g, ' ').length < 10) {
+      $('#cd-close-err').textContent = 'Closing is a judgement too — say what you decided, so the next person does not re-litigate it.';
+      return;
+    }
+    const body = { status: $('#cd-close-status').value, resolution_note: note };
+    const taskId = $('#cd-close-task').value.trim();
+    if (taskId) body.resolved_task_id = Number(taskId);
+
+    const res = await api.request('POST', `${API}/copy-desk/flags/${encodeURIComponent(closing.id)}/close`, { body });
+    if (!res.ok) {
+      const err = (res.data && res.data.error) || {};
+      const d = err.details || {};
+      $('#cd-close-err').textContent = d.what_this_means || d.why || err.message || 'Could not close the flag.';
+      return;
+    }
+    $('#cd-close-dialog').close();
+    toast('Closed.');
+    await loadQueue();
+  }
+
+  // ---------------------------------------------------------------------------
+  // wire
+  // ---------------------------------------------------------------------------
+
+  document.addEventListener('click', (ev) => {
+    const flagBtn = ev.target.closest('.cd-flag-btn');
+    if (flagBtn) {
+      openComposer({
+        string_id: flagBtn.dataset.id,
+        surface: flagBtn.dataset.surface,
+        text: flagBtn.dataset.text,
+      });
+      return;
+    }
+    const closeBtn = ev.target.closest('.cd-close-btn');
+    if (closeBtn) openCloser(closeBtn.dataset.flag);
+  });
+
+  $('#cd-cancel').addEventListener('click', () => $('#cd-dialog').close());
+  $('#cd-submit').addEventListener('click', submitFlag);
+  $('#cd-close-cancel').addEventListener('click', () => $('#cd-close-dialog').close());
+  $('#cd-close-submit').addEventListener('click', submitClose);
+  $('#cd-status').addEventListener('change', loadQueue);
+  $('#cd-surface').addEventListener('change', () => { loadQueue(); if ($('#cd-search').value.trim()) runSearch(); });
+  $('#cd-search').addEventListener('input', () => {
+    clearTimeout(searchTimer);
+    searchTimer = setTimeout(runSearch, 200);
+  });
+
+  (async () => {
+    const me = await api.request('GET', `${API}/me`);
+    if (me.ok) viewer = me.data.builder || me.data;
+    await loadQueue();
+  })();
+})();

package/modules/hall-ui/public/shell.js

@@ -122,6 +122,15 @@
       // active-nav detection (#nav-work), the 'work' gate case, and the server
       // page-gate all keep working — only the visible label and order change.
       { id: 'work', label: 'Tasks', icon: 'work', href: '/work', gate: 'signed' },
+      // task 1003113 (R02 of goal 1000074): the artist's queue over the words the
+      // product shows people. gate 'signed' and NOT a craft gate — filing a flag
+      // is open to every role on purpose (the engineer who wrote the toast and
+      // the newcomer who could not read the button are the two people most
+      // likely to notice bad copy, and neither is the artist), and an artist is a
+      // craft rather than a rank, so hiding this behind one would hide the
+      // artist's own queue from the artist. The module gate drops the tab on an
+      // instance that disables copy-desk.
+      { id: 'copy-desk', label: 'Copy desk', icon: 'docs', href: '/copy-desk', gate: 'signed', module: 'copy-desk' },
     ] },
     // Your own numbers. task 2174 folded Achievements into Standing and this task
     // retires its nav entry; VIEW_ALIASES still routes #achievements here, so old

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.249",
+  "version": "1.19.250",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.249",
+      "version": "1.19.250",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.249",
+  "version": "1.19.250",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/run-unit-tests.js

@@ -73,7 +73,17 @@ const INTEGRATION = new Set([
   // platform-server — network + package build + a spawned server, run by its own
   // .github/workflows/consumer-layout-boot.yml, not this DB-free gate (task 2142).
   'consumer_layout_boot',
-  'claim_gate_open_blocker', 'claim_gate_rebase', 'clawback_confirmed_backlog', 'discord_autojoin', 'discord_oauth',
+  'claim_gate_open_blocker', 'claim_gate_rebase', 'clawback_confirmed_backlog',
+  // task 1003113: the copy_desk_flags schema half. The module's own tests are
+  // DB-free and cover the pure layer; the rules that MATTER here live in the
+  // schema — a CHECK-constraint reason floor whose whole argument is that no
+  // future write path evades it, a PARTIAL unique index whose partiality is the
+  // design, and a close guarded on the open status so two closers cannot both
+  // win. None of those are testable without a real transaction engine.
+  // (Prose here avoids single-quoted tokens: the pairing guard below parses this
+  // set out of the source, so a quoted word in a comment reads as an entry.)
+  'copy_desk_flags_db',
+  'discord_autojoin', 'discord_oauth',
   // RENAMED by ADR 0174 (goal 1000068) — these entries said governance_* until task
   // 1003091. A curated set keyed by a stem that no longer exists silently stops
   // covering its file: both of these dropped OUT of the integration set and INTO the

package/src/bongos/module-scope-map.js

@@ -216,6 +216,23 @@ const MODULE_GLOBS = {
     'modules/game/', 'src/preview-server.js',
   ],
   'art-pipeline': ['modules/art-pipeline/'],
+  // --- the COPY half of the design contract: the artist's loop over user-facing
+  //     TEXT (goal 1000074). ADR 0081 gave design TOKENS a repo-owned source of
+  //     truth; text had none. R01 built the inventory (the copy-inventory
+  //     generator + its committed registry under docs/), R02 the flag + queue on
+  //     top of it. The generator travels with the domain but stays under
+  //     scripts/gds/ — the memory/ideas precedent (a command travels with its
+  //     domain, design 02§1). The generated artifacts are listed as exact paths
+  //     so a copy task's touches[] can name them without claiming all of docs/.
+  //     KEY IS 'copy-desk', NOT 'copy': the branding contract already owns a
+  //     `copy` block (branding.copy.tagline/hallName/notFound), so the bare word
+  //     collides with kernel code and reds the "core carries no module code"
+  //     fitness check on the English word alone.
+  'copy-desk': [
+    'modules/copy-desk/',
+    'scripts/gds/copy-inventory.js',
+    'docs/copy-registry.json', 'docs/copy-inventory.md',
+  ],
   // --- the declarative agent registry (goal 1000038, ADR 0083 default:false):
   //     agent definitions reconciled at deploy into agents_definitions + a per-fire
   //     agents_runs ledger. Carved to modules/agents/ at foundation time, so the

package/src/bongos/serve-internal.js

@@ -922,8 +922,18 @@ function mountInternalSurfaces(app) {
   // thetes redirected exactly that reader to /builders/not-ready. Owner's call
   // (task 1002710) — the RANK floor is gone; sign-in is unchanged.
   // The link-hiding in shell.js is only cosmetic; these are the real gates.
+  // task 1003113: copy-desk joins this tier rather than a higher one. Filing a
+  // flag is open to every rank by design (see the nav comment in shell.js), so
+  // the page's only real gate is sign-in — the writes behind it self-gate, and
+  // closing someone else's flag is checked server-side at metic-or-author.
+  //
+  // NB the assignment below must stay `const NAME_RE = /…/;` with NOTHING between
+  // the `=` and the literal: tests/hall_page_gate_map.mjs reconstructs the whole
+  // URL→gate map by parsing this file statically, and a comment in that gap drops
+  // the regex out of its map — which reads as "every page on this tier is
+  // ungated". It fails loudly by design; keep prose above the const.
   const SIGNEDIN_BUILDERS_PAGE_RE =
-    /^\/builders\/(?:work|pair|settings|atlas|modules|goals|roadmap|primer(?:\.md)?|diagrams)(?:\.html)?\/?$/;
+    /^\/builders\/(?:work|pair|settings|atlas|modules|goals|roadmap|copy-desk|primer(?:\.md)?|diagrams)(?:\.html)?\/?$/;
   // The diagram image assets under /builders/diagrams/ ride the same tier as the
   // page that embeds them.
   const SIGNEDIN_BUILDERS_PREFIX_RE = /^\/builders\/diagrams\//;

package/src/module-api.js

@@ -925,8 +925,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.247 with no explicit bump. run 32198208766. (task 1002620)
 //   1.19.249 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.248 with no explicit bump. run 32199293372. (task 1002620)
+//   1.19.250 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.249 with no explicit bump. run 32203357427. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.249'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.250'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');