@bongos/core 1.19.247 → 1.19.249

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.247",
-  "core_contract": "1.19.247",
-  "source_commit": "34586475492a431129c3612b15bfc96828177bf6",
+  "core_version": "1.19.249",
+  "core_contract": "1.19.249",
+  "source_commit": "992220580b9a449998b6c24f857cf0e770bb05cb",
   "source_ref": "HEAD",
-  "built_at": "2026-08-18T23:31:27.304Z",
+  "built_at": "2026-08-18T23:57:42.981Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 312,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1329,
+    "functional_verbatim": 1330,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1662,
-  "tree_sha256": "8eef4ef670a75bd7d852d9e5d23425374d6bcd2513a0196f502761410001bc64",
+  "file_count": 1663,
+  "tree_sha256": "b7562afed829bda45658ec0e21c2c045fd7d4828b7074f2d4834937bb15d0121",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -4347,12 +4347,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "a83fced3f633cdf5b808849c457288968d47be1b7c5298004dc350f75b3ddeba"
+      "sha256": "72b91522dadad774aa718d0b832f77d942d427175b52285eb15416e4f95a1337"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "d90aea68a4820402ff80446a1b18960f18b833e91162e17c50f2c780d6c4fb26"
+      "sha256": "480de6ffb6a5f6da702e74843627d5083d9dec4a76e9efcb6a1e49f97ade8cbb"
     },
     {
       "path": "public-docs/index.html",
@@ -4847,7 +4847,7 @@
     {
       "path": "scripts/gds/cli-lib.js",
       "mode": "0000644",
-      "sha256": "83d27d14600c4c8ec8912c7ad8ce771e0e34903ccc9b567dcc27cb95aeb3c37d"
+      "sha256": "95574e210b1fd215b10c7664da109b0698b18aa7724daa736bade6d752318f63"
     },
     {
       "path": "scripts/gds/code.js",
@@ -5572,7 +5572,7 @@
     {
       "path": "scripts/gds/start.js",
       "mode": "0000644",
-      "sha256": "ecb7f326b9ef642e330b3f1d5dd68cf40ee76e451552291804b4a71a28cfab40"
+      "sha256": "cb37801c6ef35a64734af422c9651b287236c4d67f7ed72a63e1cd75a94d8b38"
     },
     {
       "path": "scripts/gds/status.js",
@@ -5802,7 +5802,7 @@
     {
       "path": "src/bongos/module-scope-map.js",
       "mode": "0000644",
-      "sha256": "277097c686b695688dee35d158c4bb8384b4a5a89c61f30c7bda7d9f4b477bee"
+      "sha256": "e0c20565bb59c93fa9fff0aafa5eb246a0b16564604d18b5ae9ca350dd9e1a44"
     },
     {
       "path": "src/bongos/module-submissions.js",
@@ -5972,7 +5972,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "d810e3307f867bb1495e40227c233cf57f3ee82cd9ee7e052eae43ac4e4eecff"
+      "sha256": "79234cc30c410a215492f897139bf042c2ff58f778e490d18ec3f65a6fd860f8"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6439,6 +6439,11 @@
       "mode": "0000644",
       "sha256": "b9258f690d5dc7c87bcbb12d510b3071a38669777ae9a92a99e683e76ea15e83"
     },
+    {
+      "path": "tests/cli_dispatcher.mjs",
+      "mode": "0000644",
+      "sha256": "3e3e17428a6c8f50ce0512cfacc4e18e0b6a2c506d185fa5f2adf21c9feffe9f"
+    },
     {
       "path": "tests/cli_exit_no_abort.mjs",
       "mode": "0000644",
@@ -7437,7 +7442,7 @@
     {
       "path": "tests/module-scope-map.mjs",
       "mode": "0000644",
-      "sha256": "9eb05d38e5138e0da16d57d1d4c8768528dbc052acbc1a9d5d5e7cef7d38f06c"
+      "sha256": "2b7bc9594489401b3dd67070c3e549d0a81347abb625a04fe19a41a178af8857"
     },
     {
       "path": "tests/module_api.mjs",

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.247",
+  "version": "1.19.249",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.247",
+      "version": "1.19.249",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.247",
+  "version": "1.19.249",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/cli-lib.js

@@ -141,6 +141,49 @@ function noKeepAliveDispatcher() {
   return _noKeepAliveDispatcher;
 }
 
+// task 1002670 — the vendored Agent above is only valid as a `dispatcher` for
+// Node's built-in fetch when the two undici copies speak the same internal
+// handler protocol. Node 26 bundles undici 8 while package.json overrides pin
+// the vendored copy at ^6, so built-in fetch rejects the v6 Agent with
+// InvalidArgumentError('invalid onError method') / UND_ERR_INVALID_ARG *before
+// any network I/O* — and every CLI then misreported a pure client-side bug as
+// "this instance isn't reachable yet". The pairing can't be predicted from
+// version numbers alone (a v6 Agent works fine under Node 24's undici 7), so
+// the selection is empirical: try the vendored Agent, and on the first
+// incompat rejection drop it for the rest of the process and retry the request
+// once on the default dispatcher.
+function isDispatcherIncompatError(err) {
+  const seen = new Set();
+  for (let e = err; e && typeof e === 'object' && !seen.has(e); e = e.cause) {
+    seen.add(e);
+    if (e.code === 'UND_ERR_INVALID_ARG' || e.name === 'InvalidArgumentError') return true;
+  }
+  return false;
+}
+
+// Test-only: reset the tried-once singleton so tests/cli_dispatcher.mjs can
+// exercise the selection/fallback from a clean slate regardless of what earlier
+// (real) requests did to it on this Node version.
+function _noKeepAliveResetForTest() {
+  _noKeepAliveDispatcher = undefined;
+  _noKeepAliveTried = false;
+}
+
+async function dispatchedFetch(url, init = {}, fetchImpl = fetch) {
+  const injected = init.dispatcher !== undefined && init.dispatcher === _noKeepAliveDispatcher;
+  try {
+    return await fetchImpl(url, init);
+  } catch (err) {
+    if (!injected || !isDispatcherIncompatError(err)) throw err;
+    // The vendored Agent is incompatible with this Node's built-in fetch.
+    // Stop offering it process-wide, then retry on the default dispatcher.
+    _noKeepAliveDispatcher = undefined;
+    const retry = { ...init };
+    delete retry.dispatcher;
+    return fetchImpl(url, retry);
+  }
+}
+
 // cliExit(code) — the post-request replacement for process.exit(code). Records the
 // exit status and lets node exit naturally once the loop drains, which is what
 // keeps the UV_HANDLE_CLOSING abort above from firing. Callers must `return` after
@@ -463,7 +506,7 @@ async function apiCall(method, urlPath, body = null, opts = {}) {
   // account billing, so identity is not an auth boundary. anthropic_user_id is
   // still kept in the session as cosmetic attribution; it is simply not
   // transmitted as a header.
-  const res = await fetch(`${base}${urlPath}`, {
+  const res = await dispatchedFetch(`${base}${urlPath}`, {
     method,
     headers,
     body: body ? JSON.stringify(body) : null,
@@ -531,7 +574,7 @@ async function cliClient(opts = {}) {
     init = init || {};
     init.headers = Object.assign({ 'User-Agent': CLI_USER_AGENT }, init.headers);
     if (init.dispatcher === undefined) init.dispatcher = noKeepAliveDispatcher();
-    const res = await fetch(url, init);
+    const res = await dispatchedFetch(url, init);
     if (res.status === 401 && !allowUnauthenticated && !_unauthExitInFlight) {
       _unauthExitInFlight = true;
       printUnauthGuidanceAndExit();
@@ -817,6 +860,10 @@ module.exports = {
   readSessionToken,
   apiCall,
   cliExit,
+  isDispatcherIncompatError,
+  dispatchedFetch,
+  noKeepAliveDispatcher,
+  _noKeepAliveResetForTest,
   cliClient,
   requireSession,
   printUnauthGuidanceAndExit,

package/scripts/gds/start.js

@@ -52,7 +52,7 @@
 //
 // Returns JSON if --json is passed (for the slash command to parse cleanly).
 
-const { cliClient, requireSession, fmtUsd, printOnboardingNudge, printCostWarning, printNeedsNudge, hallBase, API_BASE, rewardPolicy, costPlusOnlyNote } = require('./cli-lib');
+const { cliClient, requireSession, fmtUsd, printOnboardingNudge, printCostWarning, printNeedsNudge, hallBase, API_BASE, rewardPolicy, costPlusOnlyNote, isDispatcherIncompatError } = require('./cli-lib');
 const { contextPack, formatContextPackCompact } = require('./context-pack');
 const { depsFinding } = require('./preflight');
 
@@ -507,6 +507,10 @@ function rankCrossDisciplineRecommendations(claimable, preferredDisciplines, lim
 // builder-start skill routes those + the pre-install "bongos not found" case.
 function isConnectionError(err) {
   if (!err) return false;
+  // task 1002670: a dispatcher/argument bug (e.g. a vendored undici Agent the
+  // built-in fetch rejects with UND_ERR_INVALID_ARG) throws before any network
+  // I/O. That is a CLIENT bug — never present it as "instance isn't reachable".
+  if (isDispatcherIncompatError(err)) return false;
   const codes = ['ECONNREFUSED', 'ENOTFOUND', 'ECONNRESET', 'EAI_AGAIN', 'ETIMEDOUT', 'UND_ERR_CONNECT_TIMEOUT', 'UND_ERR_SOCKET'];
   const code = err.code || (err.cause && err.cause.code) || '';
   if (codes.includes(code)) return true;

package/src/bongos/module-scope-map.js

@@ -274,6 +274,27 @@ const MODULE_GLOBS = {
     'scripts/gds/box.js', 'scripts/gds/box-auth-check.js', 'scripts/gds/box-connect-lib.js',
     'scripts/gds/smoke-box.sh',
   ],
+  // --- the dev-hygiene enforcement surfaces: CI workflows, the agent permission/
+  //     hook files, git hooks, root manifests, and the fitness/entropy tooling
+  //     (task 1003124, goal 1000076). Before this key, NO key resolved these paths,
+  //     so the continuous-red-team goal could not wall its own work (the
+  //     1002690/1002736 precedent). Most of these paths were ALREADY in the
+  //     protected-surfaces registry (ADR 0043) — what was missing was ownership —
+  //     so `protected` DERIVES true via the .github/ / package.json / .husky/ /
+  //     .claude-hooks overlap. Boundaries: '.claude/scheduled-tasks/' stays with
+  //     autonomy and '.claude/agents/' with agents (their source surfaces);
+  //     '.claude/skills/' stays with whichever module ships the skill.
+  //     '.npmrc' and '.gitleaks.toml' are pre-carved territory for goal 1000076's
+  //     R-tasks (the carve precedes the feature — ADR 0086 §4).
+  devsecops: [
+    '.github/',
+    '.claude/settings.json', '.claude/hooks/',
+    '.husky/',
+    '.npmrc', '.gitleaks.toml',
+    'package.json', 'package-lock.json',
+    'scripts/gds/fitness.js', 'scripts/gds/docs-entropy.js',
+    'scripts/gds/redteam-patrol.js',
+  ],
 };
 
 // A glob set is protected iff it overlaps the imported PROTECTED_GLOBS — the one

package/src/module-api.js

@@ -921,8 +921,12 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.245 with no explicit bump. run 32197129803. (task 1002620)
 //   1.19.247 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.246 with no explicit bump. run 32197488065. (task 1002620)
+//   1.19.248 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.247 with no explicit bump. run 32198208766. (task 1002620)
+//   1.19.249 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.248 with no explicit bump. run 32199293372. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.247'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.249'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/cli_dispatcher.mjs

@@ -0,0 +1,133 @@
+// tests/cli_dispatcher.mjs — dispatcher selection/fallback for the CLI fetch path
+// (task 1002670).
+//
+// THE BUG. cli-lib's noKeepAliveDispatcher() builds an Agent from the VENDORED
+// undici (package.json overrides pin ^6) and hands it to Node's BUILT-IN fetch as
+// `dispatcher`. Whether that pairing works is an internal-protocol accident of the
+// two undici versions: it works on Node 24 (built-in undici 7), and on Node 26
+// (built-in undici 8) it throws InvalidArgumentError('invalid onError method') /
+// UND_ERR_INVALID_ARG before any network I/O — and every CLI then misreported the
+// client-side bug as "this instance isn't reachable yet".
+//
+// THE CONTRACT PINNED HERE:
+//   1. isDispatcherIncompatError() recognizes the incompat shapes (top-level and
+//      wrapped in `cause`, per built-in fetch's TypeError('fetch failed')) and
+//      rejects genuine network-error shapes.
+//   2. dispatchedFetch() retries exactly once on the default dispatcher when the
+//      injected vendored Agent is rejected — and does NOT mask other failures or
+//      caller-supplied dispatchers.
+//   3. start.js's isConnectionError() returns false for the incompat shapes, so a
+//      dispatcher bug can never render the "instance isn't reachable" card.
+//   4. End-to-end on THIS Node: the real built-in fetch + the real vendored Agent
+//      reach a live local server (on Node 26 this is the case that used to die).
+//
+// Run:  node --test tests/cli_dispatcher.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import http from 'node:http';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const cli = require('../scripts/gds/cli-lib.js');
+const { isConnectionError } = require('../scripts/gds/start.js');
+
+function incompatError() {
+  const cause = new TypeError('invalid onError method');
+  cause.name = 'InvalidArgumentError';
+  cause.code = 'UND_ERR_INVALID_ARG';
+  return new TypeError('fetch failed', { cause });
+}
+
+function connRefusedError() {
+  const cause = new Error('connect ECONNREFUSED 127.0.0.1:1');
+  cause.code = 'ECONNREFUSED';
+  return new TypeError('fetch failed', { cause });
+}
+
+test('isDispatcherIncompatError: recognizes UND_ERR_INVALID_ARG wrapped in cause', () => {
+  assert.equal(cli.isDispatcherIncompatError(incompatError()), true);
+});
+
+test('isDispatcherIncompatError: recognizes a bare InvalidArgumentError (no wrapper)', () => {
+  const err = new TypeError('invalid onError method');
+  err.name = 'InvalidArgumentError';
+  assert.equal(cli.isDispatcherIncompatError(err), true);
+});
+
+test('isDispatcherIncompatError: rejects genuine network errors', () => {
+  assert.equal(cli.isDispatcherIncompatError(connRefusedError()), false);
+  assert.equal(cli.isDispatcherIncompatError(new Error('socket hang up')), false);
+  assert.equal(cli.isDispatcherIncompatError(null), false);
+});
+
+test('isDispatcherIncompatError: survives a self-referential cause chain', () => {
+  const err = new Error('loop');
+  err.cause = err;
+  assert.equal(cli.isDispatcherIncompatError(err), false);
+});
+
+test('end-to-end on this Node: real fetch + vendored Agent reach a live server', async () => {
+  const server = http.createServer((req, res) => {
+    res.setHeader('content-type', 'application/json');
+    res.end(JSON.stringify({ ok: true, path: req.url }));
+  });
+  await new Promise((r) => server.listen(0, '127.0.0.1', r));
+  const { port } = server.address();
+  try {
+    // Exactly what apiCall does: built-in fetch, vendored no-keep-alive Agent
+    // injected. On Node 26 without the fallback this rejected before any I/O.
+    const res = await cli.dispatchedFetch(`http://127.0.0.1:${port}/api/gds/me`, {
+      method: 'GET',
+      headers: { 'Content-Type': 'application/json' },
+      dispatcher: cli.noKeepAliveDispatcher(),
+    });
+    assert.equal(res.status, 200);
+    const data = await res.json();
+    assert.equal(data.ok, true);
+  } finally {
+    server.close();
+  }
+});
+
+// NOTE: on Node 26 the end-to-end test above already fired the fallback and
+// dropped the singleton, so each test below resets it to a clean slate.
+
+test('dispatchedFetch: retries once without dispatcher when the vendored Agent is rejected', async () => {
+  cli._noKeepAliveResetForTest();
+  const vendored = cli.noKeepAliveDispatcher();
+  assert.ok(vendored !== undefined, 'vendored undici Agent should resolve in this repo');
+
+  const calls = [];
+  const fakeFetch = async (url, init) => {
+    calls.push(init.dispatcher);
+    if (init.dispatcher !== undefined) throw incompatError();
+    return { ok: true, status: 200 };
+  };
+  const res = await cli.dispatchedFetch('http://x/', { dispatcher: vendored }, fakeFetch);
+  assert.equal(res.status, 200);
+  assert.deepEqual(calls, [vendored, undefined]);
+
+  // After one incompat rejection the broken Agent is dropped process-wide:
+  // later calls get the default dispatcher instead of retrying the broken one.
+  assert.equal(cli.noKeepAliveDispatcher(), undefined);
+});
+
+test('dispatchedFetch: does not retry a caller-supplied dispatcher, or non-incompat errors', async () => {
+  const foreign = { name: 'someone-elses-dispatcher' };
+  let calls = 0;
+  const rejectingFetch = async () => { calls++; throw incompatError(); };
+  await assert.rejects(() => cli.dispatchedFetch('http://x/', { dispatcher: foreign }, rejectingFetch));
+  assert.equal(calls, 1);
+
+  calls = 0;
+  const networkFail = async () => { calls++; throw connRefusedError(); };
+  await assert.rejects(() => cli.dispatchedFetch('http://x/', {}, networkFail), /fetch failed/);
+  assert.equal(calls, 1);
+});
+
+test('start.js isConnectionError: dispatcher bug is NOT a connection error', () => {
+  assert.equal(isConnectionError(incompatError()), false);
+  assert.equal(isConnectionError(connRefusedError()), true);
+  assert.equal(isConnectionError(new Error('getaddrinfo ENOTFOUND nope.example')), true);
+});

package/tests/module-scope-map.mjs

@@ -166,3 +166,43 @@ test('agents joined the roster (task 1002736) — the territory goals 1000038/39
   assert.equal(covers('src/bongos/auth.js'), false, 'the wall must not cover the kernel auth core');
   assert.equal(covers('.claude/scheduled-tasks/bfg/SKILL.md'), false, 'scheduled-tasks belongs to autonomy, not agents');
 });
+
+test('devsecops joined the roster (task 1003124) — the enforcement territory goal 1000076 walls', () => {
+  // Before this, .github/, .claude/settings.json + hooks, .husky/, the root
+  // manifests, and the fitness/entropy tooling were covered by NO key, so the
+  // continuous-red-team goal (1000076) could not wall its own work.
+  assert.ok(scope.isModuleKey('devsecops'), 'roster missing module "devsecops"');
+  const globs = scope.globsForModules(['devsecops']);
+  assert.ok(globs.includes('.github/'), 'devsecops owns the CI workflow surface');
+  assert.ok(globs.includes('.claude/hooks/'), 'devsecops owns the agent hook surface');
+  assert.ok(globs.includes('scripts/gds/fitness.js'), 'the fitness tool travels with the domain');
+  // Derived, not hand-set: .github/, package.json, .husky/, .claude/hooks/ and
+  // .claude/settings.json all sit in the ADR 0043 protected-surfaces registry, so
+  // this key MUST derive protected — creating/widening a goal into it is Archon-only.
+  assert.equal(scope.isProtectedModule('devsecops'), true, 'devsecops must derive protected (trust-core overlap)');
+  assert.equal(
+    scope.scopeForModule('devsecops').protected,
+    scope.isProtected(globs),
+    'protected must be the faithful derivation, never a literal',
+  );
+  // Asserted through the REAL consumer (directional containment), not re-implemented.
+  const covers = (touch) => gsc.scopeSubset(['devsecops'], [touch]).ok;
+  for (const touch of [
+    '.github/workflows/unit.yml',        // the CI gate R03/R04 extend
+    '.claude/settings.json',             // the deny rules R02 adds
+    '.claude/hooks/secret-gate.js',      // the PreToolUse hook R02 adds
+    '.npmrc',                            // the install-script policy R04 lands
+    'package.json',                      // dependency manifest (R04/R07)
+    '.gitleaks.toml',                    // the scanner config R03 lands
+    'scripts/gds/fitness.js',            // the ratchet pack R06 extends
+    'scripts/gds/docs-entropy.js',       // the entropy scanner behind the ratchet
+  ]) {
+    assert.equal(covers(touch), true, `wall does not cover ${touch}`);
+  }
+  // …and still BOUNDS: the trust kernel, the sibling .claude surfaces, and the
+  // lifecycle CLIs stay outside this wall.
+  assert.equal(covers('src/bongos/auth.js'), false, 'the wall must not cover the kernel auth core');
+  assert.equal(covers('.claude/scheduled-tasks/bfg/SKILL.md'), false, 'scheduled-tasks belongs to autonomy, not devsecops');
+  assert.equal(covers('.claude/skills/builder-ship/SKILL.md'), false, 'skills stay with the module that ships them');
+  assert.equal(covers('scripts/gds/ship.js'), false, 'the ship pipeline belongs to lifecycle, not devsecops');
+});