@bongos/core 1.19.236 → 1.19.237

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.236",
-  "core_contract": "1.19.236",
-  "source_commit": "0a9c519e8b99e0d694e966d655d9b8a2a8f0eb3b",
+  "core_version": "1.19.237",
+  "core_contract": "1.19.237",
+  "source_commit": "eaeb8fe89968c0626abe204eb28a8f30caf91a35",
   "source_ref": "HEAD",
-  "built_at": "2026-08-18T16:55:12.932Z",
+  "built_at": "2026-08-18T17:14:57.073Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 311,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1320,
+    "functional_verbatim": 1322,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1652,
-  "tree_sha256": "7fe9b6616b232257cbe77dced905478c770425991cbc992686b266c61f984739",
+  "file_count": 1654,
+  "tree_sha256": "53eb12ad4fd9752bd82babaf455317c7f3600dc379b40042cdbd29db67bef408",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2687,7 +2687,7 @@
     {
       "path": "modules/dev-box/app/src/vendor/bongos-client.cjs",
       "mode": "0000644",
-      "sha256": "b0bd3bbad51ea1b68f7fd36165d77fce12939cde82b37cd2266a00c103002f4b"
+      "sha256": "5c99db7b6b1b59e595c3c6a7002cf7baa3b130a198213b007448d02a427883f1"
     },
     {
       "path": "modules/dev-box/app/test/unit.mjs",
@@ -2739,6 +2739,11 @@
       "mode": "0000644",
       "sha256": "a3261a569a381ed4b19f6f5d32598a9cec09f62be51533fd6b7c5272d53b63d3"
     },
+    {
+      "path": "modules/discord/board-broadcast.js",
+      "mode": "0000644",
+      "sha256": "545b65d5db473617de01f19fa3ee3f154373e7696f8549624e441e327181c4e6"
+    },
     {
       "path": "modules/discord/bug-attachments.js",
       "mode": "0000644",
@@ -2747,7 +2752,7 @@
     {
       "path": "modules/discord/db.js",
       "mode": "0000644",
-      "sha256": "543afaee208f27d5a6a68c55b08395cd29f1091ffae2bfca1df0cdf9b7b64b5e"
+      "sha256": "79188ee4a6934be0783f18e718a025390e337abdf201c3a521e75b5cdf1e8c0b"
     },
     {
       "path": "modules/discord/discord-approvals.js",
@@ -2797,7 +2802,7 @@
     {
       "path": "modules/discord/module.json",
       "mode": "0000644",
-      "sha256": "20dbf26cfca116f5035e90a7ceec83baa29670bbd5c56dc03a1003db2983edf4"
+      "sha256": "506d3c99714060d6fcce93e971546430692591a74df86260d04c07910a185831"
     },
     {
       "path": "modules/discord/pollers/discord-bot.js",
@@ -2812,7 +2817,7 @@
     {
       "path": "modules/discord/routes/discord.js",
       "mode": "0000644",
-      "sha256": "6c3d77cb86ea3f9328de88c8ddf02a1af95e3c95ed92559bf380f627f7f59f48"
+      "sha256": "a1de692d790297b2f2286c00980aa981e0ece68fbddabf882a4fcb140ff8132b"
     },
     {
       "path": "modules/discord/ship-broadcast.js",
@@ -2822,7 +2827,7 @@
     {
       "path": "modules/discord/webhook.js",
       "mode": "0000644",
-      "sha256": "ebf32fb813b9ca84eaade229cad2206ea7de35399c121a893b78a46a1b3af0b0"
+      "sha256": "cd93f8e837f5fbf92777ff46114ef0ff7e0d3d19b96df750e4c159c1ed42c293"
     },
     {
       "path": "modules/economy/CLAUDE.md",
@@ -2902,7 +2907,7 @@
     {
       "path": "modules/government/board.js",
       "mode": "0000644",
-      "sha256": "d9f0a9fa68180b7aad47e68edcf0859598d03bf2688bbd64ab286b7facd4d8af"
+      "sha256": "a73c72cb9101a74f0d01fbdb4b87101687b54fc876a98bcef6f3bffafc29b5ad"
     },
     {
       "path": "modules/government/catalog.js",
@@ -3272,12 +3277,12 @@
     {
       "path": "modules/hall-ui/public/government.html",
       "mode": "0000644",
-      "sha256": "b21f881ddb943b46a82a2e613485f451b84dd763f73d3d4cedf7afcf66982d30"
+      "sha256": "7962d925606ec7c33e9579ebe8bdc45ef29b35899bacfb18d36af71a314629e2"
     },
     {
       "path": "modules/hall-ui/public/government.js",
       "mode": "0000644",
-      "sha256": "246a14606c8d7b2d58d4ecb7afb9ed0f8a9d543f8c40d85e321a169ef9750fcd"
+      "sha256": "b1de692afb7abb2bd95a91a31d7c8d244c9a9f702c8ab3d73214bb23472614ec"
     },
     {
       "path": "modules/hall-ui/public/hall-kit.js",
@@ -4322,12 +4327,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "f5abc3db63111a1a16cbe3d1dab016100dd4fd2327c515bfca2aeecad46d4fe9"
+      "sha256": "0aa89af9e9b19d147dac4f2e227a5c83e551f017c214a93a1b8fdc1b06bbd181"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "868413f24489f75a2b26faab9a4a60fb25f5348c514aa73895a074da1f15f0e4"
+      "sha256": "504c5178ba2a13a17ed7c187fcc07760980e1f34f0e9ded12b0e45f3c30d5d40"
     },
     {
       "path": "public-docs/index.html",
@@ -5942,7 +5947,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "052bbf66213891c419bee8571c5140474a9544fb3a21b8cc0aa12dacaf05a2b9"
+      "sha256": "87b7144a9581bd6f2877671b4624aed2bb872ad7456ec1d8208493a53e604150"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6619,6 +6624,11 @@
       "mode": "0000644",
       "sha256": "9765fcdc48191281115dfaac650719ac8f84257b602d1e83c351e9b9ad6d2949"
     },
+    {
+      "path": "tests/discord_board_broadcast.mjs",
+      "mode": "0000644",
+      "sha256": "d2b3406427e242c09a0913643ebe6726a6e738d3a3cf576d0de6e4fd21b0c1f9"
+    },
     {
       "path": "tests/discord_bot.mjs",
       "mode": "0000644",

package/modules/dev-box/app/src/vendor/bongos-client.cjs

@@ -348,8 +348,14 @@ function createClient(opts = {}) {
       postGovernmentAssignments: (args) => request("POST", "/government/assignments", { hasBody: true }, args),
       // DELETE /government/assignments/{builderId}/{rankKey} — rank: archon — DELETE /government/assignments/:builderId/:rankKey
       deleteGovernmentAssignmentsBuilderIdRankKey: (args) => request("DELETE", "/government/assignments/{builderId}/{rankKey}", { hasBody: false }, args),
+      // GET /government/board/items — rank: any-builder — GET /government/board/items
+      getGovernmentBoardItems: (args) => request("GET", "/government/board/items", { hasBody: false }, args),
+      // POST /government/board/items — rank: metic+archon — POST /government/board/items
+      postGovernmentBoardItems: (args) => request("POST", "/government/board/items", { hasBody: true }, args),
       // POST /government/board/items/{itemId}/votes — rank: any-builder — POST /government/board/items/:itemId/votes
       postGovernmentBoardItemsItemIdVotes: (args) => request("POST", "/government/board/items/{itemId}/votes", { hasBody: true }, args),
+      // GET /government/constitution — rank: any-builder — GET /government/constitution
+      getGovernmentConstitution: (args) => request("GET", "/government/constitution", { hasBody: false }, args),
       // GET /government/permissions — rank: archon — GET /government/permissions
       getGovernmentPermissions: (args) => request("GET", "/government/permissions", { hasBody: false }, args),
       // GET /government/ranks — rank: archon — GET /government/ranks

package/modules/discord/board-broadcast.js

@@ -0,0 +1,105 @@
+// modules/discord/board-broadcast.js — the Board Room announcer
+// (BV1.R21 of goal 1000069, ADR 0175 §8).
+//
+// On window open, the board channel hears that a vote is wanted: the members
+// under the item's SNAPSHOTTED constitution are @mentioned (the mention IS the
+// "vote within X" notice, and Discord's own mobile app IS the mobile push — no
+// new surface), with a deep link straight to the Board Room in the hall.
+//
+// DISCORD IS OUTBOUND-ONLY HERE (§8, and the C6 criterion): this posts, it
+// reads nothing inbound and casts nothing — an objection needs a reason and a
+// section, which a reaction cannot express, so the hall is the only voting
+// surface and this message is a doorway to it.
+//
+// THE MENTION EXCEPTION: webhook.postWebhookMentions allowlists exactly the
+// member ids the GOVERNMENT PORT resolved — server data, never message text —
+// under the item's snapshot, so an amendment mid-sitting cannot change who is
+// summoned to an already-open item. A member without a Discord link is named
+// in text instead (visible, unpinged, honest). #871's parse:[] still stands:
+// nothing typed into content can ever ring anyone.
+//
+// BEST-EFFORT BY DESIGN, like every broadcast in this module: it never throws,
+// so a Discord hiccup can never fail a window open — the room in the hall is
+// the durable surface, this is the nudge.
+
+'use strict';
+
+const api = require('../../src/module-api');
+const db = require('./db');
+const webhook = require('./webhook');
+
+// Compose + post the announcement. deps injectable for the DB-free tests:
+//   resolveMembers(constitution) → the government port's resolveBoardMembers
+//   getLink(builderId)           → db.getDiscordLink
+//   post(channel, text, userIds) → webhook.postWebhookMentions
+// Strip markdown-significant characters from a builder-editable name so a
+// crafted display name cannot carry formatting, links or lookalike mentions on
+// the back of a legitimate announcement. The PING vector is already closed by
+// allowed_mentions; this closes the cosmetic/phishing one.
+function plainName(name) {
+  // '.' is stripped too: Discord auto-links bare domains, so a name shaped
+  // like one must not survive as a clickable.
+  return String(name).replace(/[\`*_~|@#>\[\]()<:.\/]/g, '').trim().slice(0, 64) || 'a member';
+}
+
+async function postBoardAnnouncement(payload, deps = {}) {
+  const result = { posted: false, skipped: null, mentioned: [], named: [] };
+  if (!payload || payload.item_id == null) { result.skipped = 'no_item'; return result; }
+  const log = deps.log || console.log;
+  try {
+    const government = deps.government !== undefined ? deps.government : (api.resolveOptional && api.resolveOptional('government'));
+    const resolveMembers = deps.resolveMembers
+      || (government && government.resolveBoardMembers ? (c) => government.resolveBoardMembers(c) : null);
+    if (!resolveMembers) { result.skipped = 'no_government_port'; return result; }
+    const members = await resolveMembers(payload.constitution || {});
+    if (!members || !members.length) { result.skipped = 'empty_board'; return result; }
+
+    // ONE bulk query for the whole board's links — never a per-member await.
+    const getLinks = deps.getLinks
+      || (async (ids) => db.getDiscordLinks(ids));
+    let links = new Map();
+    try { links = await getLinks(members.map((m) => m.builder_id)); } catch (_) { /* unlinked reads as unlinked */ }
+    const mentions = [];
+    for (const m of members) {
+      const link = links.get(String(m.builder_id));
+      const discordId = link && (link.discord_user_id || link.discordUserId);
+      if (discordId) {
+        result.mentioned.push(String(discordId));
+        mentions.push(`<@${discordId}>`);
+      } else {
+        // Named, visible, unpinged — an unlinked member still sees their name
+        // when they read the room; linking is their call, not a gate. Names are
+        // builder-editable profile text, so markdown-significant characters are
+        // stripped: a crafted display name must not carry links or formatting
+        // on the back of a legitimate announcement.
+        const safe = plainName(m.display_name || m.github_login || `builder ${m.builder_id}`);
+        result.named.push(safe);
+        mentions.push(safe);
+      }
+    }
+
+    const subject = payload.subject_type === 'constitutional_amendment'
+      ? 'A constitutional amendment'
+      : 'A Full Idea';
+    const clock = payload.window_minutes
+      ? `within ${payload.window_minutes} minutes`
+      : 'at your convenience — the sitting has no clock and closes on the first vote';
+    const origin = ((api.branding && api.branding().domains) || {}).buildersOrigin || '';
+    // Straight to THAT item: ?item=<id> — the Board Room panel reads it and
+    // scrolls to / highlights the named sitting (the hash stays the tab).
+    const link = `${origin ? origin.replace(/\/$/, '') : ''}/government?item=${encodeURIComponent(payload.item_id)}#board-room`;
+    const line = `\u{1F3DB}\u{FE0F} ${subject} is before the board (item ${payload.item_id}). `
+      + `${mentions.join(' ')} — your vote is wanted ${clock}. Vote in the hall: ${link}`;
+
+    const post = deps.post || webhook.postWebhookMentions;
+    await post('board_room', line, result.mentioned);
+    result.posted = true;
+    log(`[discord] board announcement posted (item ${payload.item_id}; ${result.mentioned.length} mentioned, ${result.named.length} named)`);
+  } catch (e) {
+    result.skipped = 'post_failed';
+    log(`[discord] board announcement skipped (window open unaffected): ${e && e.message}`);
+  }
+  return result;
+}
+
+module.exports = { postBoardAnnouncement };

package/modules/discord/db.js

@@ -46,6 +46,18 @@ async function listDiscordLinks() {
   return rows;
 }
 
+// Bulk twin of getDiscordLink (R21): one query for a whole board's links —
+// the announcer mentions every member, and a per-member await is an N+1 the
+// grader rightly flagged. Returns a Map keyed by builder_id AS A STRING.
+async function getDiscordLinks(builderIds) {
+  if (!builderIds || !builderIds.length) return new Map();
+  const { rows } = await pool.query(
+    `SELECT builder_id, discord_user_id FROM discord_links WHERE builder_id = ANY($1::bigint[])`,
+    [builderIds],
+  );
+  return new Map(rows.map((r) => [String(r.builder_id), r]));
+}
+
 async function getDiscordLink(builderId) {
   const { rows } = await pool.query(
     `SELECT builder_id, discord_user_id, linked_at FROM discord_links WHERE builder_id = $1`,
@@ -82,6 +94,7 @@ module.exports = {
   getBuilderByDiscordUserId,
   listDiscordLinks,
   getDiscordLink,
+  getDiscordLinks,
   countRecentDiscordBugFilings,
   recordApplause,
   // kernel db helpers, re-exported off the doorway (one `db.*` namespace)

package/modules/discord/module.json

@@ -11,6 +11,6 @@
     "uiSections": []
   },
   "provides": ["discord.isLinked"],
-  "consumes": ["ideas.capture"],
+  "consumes": ["ideas.capture", "government"],
   "dependencies": { "discord.js": "^14.26.4" }
 }

package/modules/discord/routes/discord.js

@@ -17,6 +17,7 @@ const api = require('../../../src/module-api');
 const auth = require('../auth');
 const db = require('../db');
 const shipBroadcast = require('../ship-broadcast');
+const boardBroadcast = require('../board-broadcast');
 const roleSync = require('../discord-role-sync');
 
 // The module's kernel seams, registered when this factory runs (the loader runs
@@ -43,6 +44,7 @@ const roleSync = require('../discord-role-sync');
 let _shipListenerOff = null;
 let _strandListenerOff = null;
 let _roleSyncListenerOff = null;
+let _boardListenerOff = null;
 function registerSeams() {
   if (!api.hasProvider('discord.isLinked')) {
     api.registerProvider('discord.isLinked', async (builderId) => !!(await db.getDiscordLink(builderId)));
@@ -58,6 +60,10 @@ function registerSeams() {
   _shipListenerOff = api.on('task.shipped', (task) => shipBroadcast.postShipBroadcast(task));
   if (_strandListenerOff) _strandListenerOff();
   _strandListenerOff = api.on('task.strand-flagged', (info) => shipBroadcast.postStrandNotice(info));
+  // R21 (goal 1000069): a window opening in the Board Room summons its members
+  // — the government module emits, this module posts. Outbound only (§8).
+  if (_boardListenerOff) _boardListenerOff();
+  _boardListenerOff = api.on('board.item.opened', (payload) => boardBroadcast.postBoardAnnouncement(payload));
   if (_roleSyncListenerOff) _roleSyncListenerOff();
   _roleSyncListenerOff = api.on('builder.role-sync-needed', ({ builderId }) =>
     roleSync.syncBuilderRole(builderId).catch((e) =>

package/modules/discord/webhook.js

@@ -27,6 +27,7 @@ const WEBHOOKS_PATH = api.configPath('discord-webhooks.json');
 const CHANNELS = new Set([
   'ship_news', 'ship_feed', 'security_ship_feed',
   'member_approvals',
+  'board_room',
 ]);
 
 function loadWebhooks() {
@@ -43,7 +44,11 @@ function loadWebhooks() {
   return cfg;
 }
 
-async function postWebhook(channel, text) {
+// One poster core; the two entry points differ ONLY in allowed_mentions.
+// #871's rule holds in both: parse:[] always, so nothing typed INTO content can
+// ever ring — postWebhookMentions adds an explicit server-resolved user
+// allowlist and nothing else.
+async function postCore(channel, text, allowedMentions) {
   if (!CHANNELS.has(channel)) {
     throw new Error(`Unknown Discord channel '${channel}'. Known: ${[...CHANNELS].join(', ')}`);
   }
@@ -56,13 +61,10 @@ async function postWebhook(channel, text) {
   }
   // Discord hard-caps message content at 2000 chars.
   const content = String(text).slice(0, 2000);
-  // SECURITY (#871): suppress ALL mention pings. The content is DB-sourced and
-  // attacker-influenceable; allowed_mentions:{parse:[]} renders text verbatim but
-  // fires zero notifications. (Discord defaults to parsing mentions when omitted.)
   const res = await fetch(url, {
     method: 'POST',
     headers: { 'Content-Type': 'application/json' },
-    body: JSON.stringify({ content, allowed_mentions: { parse: [] } }),
+    body: JSON.stringify({ content, allowed_mentions: allowedMentions }),
   });
   if (!res.ok) {
     const body = await res.text().catch(() => '');
@@ -71,4 +73,22 @@ async function postWebhook(channel, text) {
   return { ok: true, status: res.status }; // 204 No Content on success
 }
 
-module.exports = { CHANNELS, WEBHOOKS_PATH, loadWebhooks, postWebhook };
+// SECURITY (#871): suppress ALL mention pings. The content is DB-sourced and
+// attacker-influenceable; allowed_mentions:{parse:[]} renders text verbatim but
+// fires zero notifications. (Discord defaults to parsing mentions when omitted.)
+async function postWebhook(channel, text) {
+  return postCore(channel, text, { parse: [] });
+}
+
+// postWebhookMentions — the ONE sanctioned exception to #871's blanket mention
+// suppression (R21 of goal 1000069: "the mention IS the 'vote within X'
+// notice"). Still parse:[] — nothing typed INTO the content can ever ping — but
+// an explicit `users` allowlist lets exactly the named ids ring. The ids must
+// come from the board-membership resolve (server data), NEVER from message
+// text; the cap of 20 is a sanity bound far above any real board.
+async function postWebhookMentions(channel, text, userIds = []) {
+  const users = [...new Set(userIds.filter((u) => /^\d+$/.test(String(u))))].slice(0, 20).map(String);
+  return postCore(channel, text, { parse: [], users });
+}
+
+module.exports = { CHANNELS, WEBHOOKS_PATH, loadWebhooks, postWebhook, postWebhookMentions };

package/modules/government/board.js

@@ -81,9 +81,31 @@ async function openWindowForFullIdea({ ideaId, completenessScore } = {}) {
     windowMinutes: board.window_minutes,
   });
   if (!item) return { opened: false, reason: 'already_open', item: await db.getOpenBoardItem('full_idea', id) };
+  await emitWindowOpened(item);
   return { opened: true, item };
 }
 
+// The window-open courtesy event (R21's feed): emitAsync AFTER the row exists,
+// for non-deciding reactions only — the Discord announcer mentions the members
+// whose vote is wanted and deep-links the hall. Best-effort by construction
+// (emitAsync isolates listener errors), and nothing that decides or pays may
+// subscribe: the row is the durable fact, the event is a nudge.
+async function emitWindowOpened(item) {
+  try {
+    if (api.emitAsync) {
+      await api.emitAsync('board.item.opened', {
+        item_id: String(item.id),
+        subject_type: item.subject_type,
+        subject_id: String(item.subject_id),
+        opened_by: item.opened_by == null ? null : String(item.opened_by),
+        closes_at: item.closes_at || null,
+        window_minutes: item.constitution ? item.constitution.window_minutes ?? null : null,
+        constitution: item.constitution || null,
+      });
+    }
+  } catch (_) { /* a nudge that fails is a quiet sitting, never a failed open */ }
+}
+
 // ── the vote (BV1.R08 of goal 1000069, ADR 0175 §§4/6/9) ────────────────────
 //
 // OPEN BALLOT, ONE VOTE, NO EDITING. A vote is member + direction + timestamp,
@@ -450,6 +472,7 @@ async function proposeAmendment({ proposal, rationaleMd = null, proposedBy } = {
     windowMinutes: board.window_minutes,
   });
   // A fresh amendment id can never collide with the one-open-per-subject index.
+  if (item) await emitWindowOpened(item);
   return { ok: true, amendment, item };
 }
 

package/modules/hall-ui/public/government.html

@@ -99,6 +99,6 @@
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/dom-utils.js?v=2026-06-16-gate"></script>
 <script src="/builders/hall-kit.js"></script>
-<script src="/builders/government.js?v=2026-08-18-vote-form"></script>
+<script src="/builders/government.js?v=2026-08-18-board-announce"></script>
 </body>
 </html>

package/modules/hall-ui/public/government.js

@@ -704,7 +704,7 @@
     const myLine = item.closed_at ? '' : (mine
       ? `<p class="gov-grid-note">You voted <strong>${escapeHtml(mine.direction)}</strong>. One vote per member — no changes.</p>`
       : `<p class="gov-grid-note">You have not voted on this item. Casting arrives with the vote form.</p>`);
-    return `<section class="gov-section">
+    return `<section class="gov-section" id="board-item-${escapeHtml(item.id)}">
       <div class="gov-section__head">${subjectLine(item)} ${state}</div>
       ${amendmentDetail}
       <p class="gov-grid-note">tally: ${yes} yes · ${no} no — sitting under <code>${escapeHtml((item.constitution && item.constitution.pass_rule) || '?')}</code>, membership <code>${escapeHtml((item.constitution && item.constitution.membership) || '?')}</code></p>
@@ -732,6 +732,17 @@
       (open || window.OTBKit.emptyStateHtml('Nothing is before the board. When a Full Idea clears the completeness grade, its window opens here.'))
       + `<h2 class="gov-h">Closed sittings</h2>`
       + (closed || `<p class="gov-empty">No sitting has closed yet.</p>`);
+    // R21: the Discord announcement deep-links ?item=<id>#board-room — land the
+    // reader on THAT sitting. Query, not hash (the hash is the tab, makeTabs
+    // owns it); a missing or unknown id is simply the room as usual.
+    const wanted = new URLSearchParams(window.location.search).get('item');
+    if (wanted) {
+      const el = document.getElementById(`board-item-${wanted}`);
+      if (el) {
+        el.scrollIntoView({ block: 'start' });
+        el.style.outline = '2px solid var(--color-text-success, #4a4)';
+      }
+    }
     // R17: the cast buttons. One delegated listener; the SERVER refuses every
     // illegitimate cast regardless (membership, anti-self, closed, expired) —
     // the form is a courtesy, the route is the wall.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.236",
+  "version": "1.19.237",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.236",
+      "version": "1.19.237",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.236",
+  "version": "1.19.237",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -899,8 +899,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.234 with no explicit bump. run 32161981393. (task 1002620)
 //   1.19.236 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.235 with no explicit bump. run 32162811851. (task 1002620)
+//   1.19.237 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.236 with no explicit bump. run 32164526454. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.236'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.237'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/discord_board_broadcast.mjs

@@ -0,0 +1,121 @@
+// tests/discord_board_broadcast.mjs — announce a window (BV1.R21 of goal
+// 1000069, ADR 0175 §8 / criterion C6): mention the members, deep-link the hall.
+//
+// DB-free, deps-injected (the postShipBroadcast testing shape). The invariants:
+//   1. THE MENTION ALLOWLIST IS EXACTLY THE LINKED MEMBERS — ids come from the
+//      government port's resolve under the item's SNAPSHOT, never from text;
+//      an unlinked member is NAMED, visible and unpinged.
+//   2. OUTBOUND-ONLY AND BEST-EFFORT — a Discord hiccup, a missing port, or an
+//      empty board is a named skip, never a throw (a failed nudge must never
+//      fail a window open).
+//   3. THE EMITTER FIRES ON FRESH OPENS ONLY — an idempotent re-open (the
+//      already_open path) summons nobody twice.
+//   4. #871 SURVIVES — the poster keeps parse:[] and only rings the explicit
+//      user allowlist; content can never ping anyone on its own.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const { postBoardAnnouncement } = require(path.join(ROOT, 'modules', 'discord', 'board-broadcast.js'));
+const webhook = require(path.join(ROOT, 'modules', 'discord', 'webhook.js'));
+
+const MONARCHY = { membership: 'rank:archon', pass_rule: 'first_ratifier', window_minutes: null, close_early_on_full_turnout: true };
+const payload = (over = {}) => ({
+  item_id: '11', subject_type: 'full_idea', subject_id: '7', opened_by: null,
+  closes_at: null, window_minutes: null, constitution: MONARCHY, ...over,
+});
+const member = (id, login) => ({ builder_id: String(id), github_login: login, display_name: login });
+
+test('linked members are @mentioned on the allowlist; unlinked members are named, unpinged', async () => {
+  let posted = null;
+  const out = await postBoardAnnouncement(payload({ window_minutes: 90 }), {
+    resolveMembers: async (c) => { assert.deepEqual(c, MONARCHY, 'summoned under the item SNAPSHOT'); return [member(1, 'linked-one'), member(2, 'unlinked-two')]; },
+    getLinks: async (ids) => {
+      assert.deepEqual(ids, ['1', '2'], 'ONE bulk query for the whole board — never a per-member await');
+      return new Map([['1', { discord_user_id: '111222333' }]]);
+    },
+    post: async (channel, text, userIds) => { posted = { channel, text, userIds }; },
+    log: () => {},
+  });
+  assert.equal(out.posted, true);
+  assert.deepEqual(out.mentioned, ['111222333']);
+  assert.deepEqual(out.named, ['unlinked-two']);
+  assert.equal(posted.channel, 'board_room');
+  assert.deepEqual(posted.userIds, ['111222333'], 'the allowlist is EXACTLY the linked members — never parsed from text');
+  assert.ok(posted.text.includes('<@111222333>'));
+  assert.ok(posted.text.includes('unlinked-two'), 'the unlinked member is still named');
+  assert.ok(posted.text.includes('within 90 minutes'), 'the mention IS the vote-within-X notice');
+  assert.ok(posted.text.includes('/government?item=11#board-room'), 'deep-links THAT item — the panel scrolls to it');
+});
+
+test('a clockless sitting says so, and an amendment names its subject honestly', async () => {
+  let text = null;
+  await postBoardAnnouncement(payload({ subject_type: 'constitutional_amendment', subject_id: '5' }), {
+    resolveMembers: async () => [member(1, 'a')],
+    getLinks: async () => new Map([['1', { discord_user_id: '9' }]]),
+    post: async (_c, t) => { text = t; },
+    log: () => {},
+  });
+  assert.ok(text.includes('constitutional amendment'));
+  assert.ok(text.includes('no clock'), 'a monarchy sitting has no deadline to claim');
+});
+
+test('missing port, empty board, and a Discord failure are named skips — NEVER throws', async () => {
+  assert.deepEqual(await postBoardAnnouncement(payload(), { government: null, log: () => {} }),
+    { posted: false, skipped: 'no_government_port', mentioned: [], named: [] });
+  assert.equal((await postBoardAnnouncement(payload(), { resolveMembers: async () => [], log: () => {} })).skipped, 'empty_board');
+  const out = await postBoardAnnouncement(payload(), {
+    resolveMembers: async () => [member(1, 'a')],
+    getLinks: async () => new Map([['1', { discord_user_id: '9' }]]),
+    post: async () => { throw new Error('discord down'); },
+    log: () => {},
+  });
+  assert.deepEqual({ posted: out.posted, skipped: out.skipped }, { posted: false, skipped: 'post_failed' });
+  assert.equal((await postBoardAnnouncement(null, { log: () => {} })).skipped, 'no_item');
+});
+
+test('the emitter fires on FRESH opens only, and the listener is registered (source pins)', () => {
+  const board = fs.readFileSync(path.join(ROOT, 'modules', 'government', 'board.js'), 'utf8');
+  const open = board.slice(board.indexOf('async function openWindowForFullIdea'), board.indexOf('async function emitWindowOpened'));
+  assert.ok(open.indexOf('already_open') < open.indexOf('emitWindowOpened(item)'),
+    'the idempotent re-open path returns BEFORE the emit — nobody is summoned twice');
+  assert.match(board, /emitAsync\('board\.item\.opened'/, 'the event exists');
+  const routes = fs.readFileSync(path.join(ROOT, 'modules', 'discord', 'routes', 'discord.js'), 'utf8');
+  assert.match(routes, /api\.on\('board\.item\.opened', \(payload\) => boardBroadcast\.postBoardAnnouncement\(payload\)\)/,
+    'the discord module subscribes — government emits, discord posts, nothing decides');
+  const manifest = JSON.parse(fs.readFileSync(path.join(ROOT, 'modules', 'discord', 'module.json'), 'utf8'));
+  assert.ok(manifest.consumes.includes('government'), 'the port consumption is declared');
+});
+
+test('#871 survives: the mention poster keeps parse:[] and rings only the explicit allowlist', () => {
+  const src = fs.readFileSync(path.join(ROOT, 'modules', 'discord', 'webhook.js'), 'utf8');
+  const block = src.slice(src.indexOf('async function postWebhookMentions'));
+  assert.match(block, /postCore\(channel, text, \{ parse: \[\], users \}\)/,
+    'content can never ping on its own — only the server-resolved ids ring');
+  const plain = src.slice(src.indexOf('async function postWebhook('), src.indexOf('async function postWebhookMentions'));
+  assert.match(plain, /postCore\(channel, text, \{ parse: \[\] \}\)/,
+    'the default poster stays fully suppressed — #871 verbatim');
+  assert.match(block, /slice\(0, 20\)/, 'the allowlist is sanity-bounded');
+  assert.match(block, /\^\\d\+\$/, 'only numeric snowflake ids survive the filter');
+  assert.ok(webhook.CHANNELS.has('board_room'), 'the channel key exists');
+});
+
+test('an unlinked member\'s crafted display name is stripped of markdown and links', async () => {
+  let text = null;
+  await postBoardAnnouncement(payload(), {
+    resolveMembers: async () => [{ builder_id: '3', github_login: 'x', display_name: '[click me](https://evil.example) **@everyone**' }],
+    getLinks: async () => new Map(),
+    post: async (_c, t) => { text = t; },
+    log: () => {},
+  });
+  assert.ok(!text.includes('['), 'no markdown link syntax survives');
+  assert.ok(!/\w\.\w/.test(text.replace(/Vote in the hall:.*$/,'')), 'no linkable residue survives (Discord auto-links bare domains)');
+  assert.ok(!text.includes('**'), 'no formatting survives');
+  assert.ok(!text.includes('@everyone'), 'no lookalike mention survives (the ping was already dead; now the text is too)');
+  assert.ok(text.includes('click me'), 'the words themselves remain — visible, honest, inert');
+});