@bongos/core 1.19.235 → 1.19.236

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.235",
-  "core_contract": "1.19.235",
-  "source_commit": "b91cbff1532b00e3cdd2204e713b35cf093c9b02",
+  "core_version": "1.19.236",
+  "core_contract": "1.19.236",
+  "source_commit": "0a9c519e8b99e0d694e966d655d9b8a2a8f0eb3b",
   "source_ref": "HEAD",
-  "built_at": "2026-08-18T16:46:17.722Z",
+  "built_at": "2026-08-18T16:55:12.932Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 311,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1319,
+    "functional_verbatim": 1320,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1651,
-  "tree_sha256": "d20a6edcee7ad8a7e81eefec0b07689a820b194634cdb5350c8c4263127990ea",
+  "file_count": 1652,
+  "tree_sha256": "7fe9b6616b232257cbe77dced905478c770425991cbc992686b266c61f984739",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2902,7 +2902,7 @@
     {
       "path": "modules/government/board.js",
       "mode": "0000644",
-      "sha256": "9d3d9414ca1c1bafc901a7343cdccafc7261b0dba492134a9a1064e6b3d82b61"
+      "sha256": "d9f0a9fa68180b7aad47e68edcf0859598d03bf2688bbd64ab286b7facd4d8af"
     },
     {
       "path": "modules/government/catalog.js",
@@ -2917,7 +2917,7 @@
     {
       "path": "modules/government/db.js",
       "mode": "0000644",
-      "sha256": "ab75e3e0fd2b7eee747e525403f8a2ea863dbf1f4332cb3c6ec1b413ed7af7e3"
+      "sha256": "d50b12547863df08cf32c606fe91187e1239f5b0d339f9d34ed9f3b5403b3d15"
     },
     {
       "path": "modules/government/migrations/governance_001_tables.sql",
@@ -3272,12 +3272,12 @@
     {
       "path": "modules/hall-ui/public/government.html",
       "mode": "0000644",
-      "sha256": "87ec2d8c002edf0a440e658cb29e567a07544bc36bb535d4cb0fd5130629a92e"
+      "sha256": "b21f881ddb943b46a82a2e613485f451b84dd763f73d3d4cedf7afcf66982d30"
     },
     {
       "path": "modules/hall-ui/public/government.js",
       "mode": "0000644",
-      "sha256": "505003cd76eb3760459ed53555b5c0803e1efaffb2e17ee15c7ed032a1607289"
+      "sha256": "246a14606c8d7b2d58d4ecb7afb9ed0f8a9d543f8c40d85e321a169ef9750fcd"
     },
     {
       "path": "modules/hall-ui/public/hall-kit.js",
@@ -4322,12 +4322,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "7731f20b3114fe6a083c06fe6b92d0048e4d5d136ba4fcc49f9a10f66c9577e5"
+      "sha256": "f5abc3db63111a1a16cbe3d1dab016100dd4fd2327c515bfca2aeecad46d4fe9"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "844c9c21b09d3d41cd8663a37d651ec717a5ba25d5fb24fda5e57930ca278cb2"
+      "sha256": "868413f24489f75a2b26faab9a4a60fb25f5348c514aa73895a074da1f15f0e4"
     },
     {
       "path": "public-docs/index.html",
@@ -5942,7 +5942,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "c3a588bdcb0781e8f71dd492f26b09a2212ababebf52e511dccb9018ad84f89b"
+      "sha256": "052bbf66213891c419bee8571c5140474a9544fb3a21b8cc0aa12dacaf05a2b9"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6887,13 +6887,18 @@
     {
       "path": "tests/government_board_view.mjs",
       "mode": "0000644",
-      "sha256": "104dbfd5510f4abf4580cf89f57e4be15667b4b6e6f171a2635786bfd4d65f9e"
+      "sha256": "827d743080201f11b2282aaa77d37149aaddaddc42b2b444c260a2696a7727ca"
     },
     {
       "path": "tests/government_board_vote.mjs",
       "mode": "0000644",
       "sha256": "c1b9b0963dde0c033bd0eb411b63032a51edaa3d91751100593b7e3b4999c017"
     },
+    {
+      "path": "tests/government_board_vote_ui.mjs",
+      "mode": "0000644",
+      "sha256": "a9e46b10cf9b6c17550f22463d13caa0d4b63d87d4fc63d087dd14e4b95b8312"
+    },
     {
       "path": "tests/government_board_window.mjs",
       "mode": "0000644",

package/modules/government/board.js

@@ -499,7 +499,17 @@ async function boardRoomView({ closedLimit = 20 } = {}) {
   }
   const project = (item) => {
     const subject = item.subject_type === 'full_idea'
-      ? (() => { const r = ideaById.get(String(item.subject_id)); return r ? { title: r.title, author_id: String(r.captured_by) } : null; })()
+      ? (() => {
+          const r = ideaById.get(String(item.subject_id));
+          return r ? {
+            title: r.title,
+            author_id: String(r.captured_by),
+            // R17: the voter decides with the idea in front of them.
+            field_values: r.field_values || null,
+            template_key: r.template_key || null,
+            completeness_score: r.completeness_score ?? null,
+          } : null;
+        })()
       : (() => { const r = amendmentById.get(String(item.subject_id)); return r ? { proposed: r.proposed, rationale_md: r.rationale_md, author_id: r.proposed_by == null ? null : String(r.proposed_by) } : null; })();
     return {
       id: String(item.id),

package/modules/government/db.js

@@ -493,8 +493,15 @@ async function getVotesForItems(itemIds) {
 // an amendment its proposed block + rationale.
 async function getIdeaSubjects(ideaIds) {
   if (!ideaIds || !ideaIds.length) return [];
+  // The five sections ride along (R17): the full idea must be IN FRONT of the
+  // voter while they decide — that context is the entire reason voting happens
+  // in the hall rather than on a reaction. LEFT JOIN: an idea whose grade row
+  // is somehow gone still shows its title.
   const { rows } = await pool.query(
-    `SELECT id, title, captured_by FROM idea_inbox WHERE id = ANY($1::bigint[])`,
+    `SELECT i.id, i.title, i.captured_by, g.field_values, g.template_key, g.completeness_score
+       FROM idea_inbox i
+       LEFT JOIN ideas_grades g ON g.idea_id = i.id
+      WHERE i.id = ANY($1::bigint[])`,
     [ideaIds],
   );
   return rows;

package/modules/hall-ui/public/government.html

@@ -99,6 +99,6 @@
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/dom-utils.js?v=2026-06-16-gate"></script>
 <script src="/builders/hall-kit.js"></script>
-<script src="/builders/government.js?v=2026-08-18-charter-library"></script>
+<script src="/builders/government.js?v=2026-08-18-vote-form"></script>
 </body>
 </html>

package/modules/hall-ui/public/government.js

@@ -80,6 +80,17 @@
     unknown_permission: 'The permission catalog does not define that key.',
     bad_rank_key: 'Rank keys are kebab-case: lowercase letters, digits, dashes.',
     validation_failed: 'Missing or invalid fields.',
+    // the vote refusals (R17 over R08's route)
+    not_board_member: 'Only members of this item\u2019s board may vote on it \u2014 membership follows the rules that were in force when the window opened.',
+    anti_self_vote: 'You can\u2019t vote on your own idea \u2014 that\u2019s the line that keeps ratification honest.',
+    item_closed: 'This sitting has closed \u2014 refreshing.',
+    vote_window_expired: 'This sitting\u2019s clock has run out \u2014 the sweep is closing it.',
+    objection_needs_reason: 'An objection must say why \u2014 write the reason.',
+    objection_needs_section: 'An objection must point at exactly one section of the idea.',
+    yes_carries_nothing: 'A yes carries no reason or section \u2014 those belong to objections.',
+    bad_direction: 'A vote is yes or no \u2014 nothing else.',
+    item_not_found: 'That item no longer exists \u2014 refreshing.',
+    bad_item_id: 'That item id isn\u2019t valid.',
   };
   const friendlyError = (code) => ERROR_COPY[code] || null;
 
@@ -610,6 +621,76 @@
     return `<div class="gov-section">${rows}</div>`;
   }
 
+  // ---- the vote form (R17) -----------------------------------------------------
+
+  // The five section labels, mirrored from the base template declaration
+  // (modules/ideas/templates.js — the words the author saw when writing; a test
+  // holds the two equal, since browser code cannot import a server module).
+  const SECTION_LABELS = {
+    purpose: 'Purpose of Idea',
+    big_picture: 'What does the Big Picture look like',
+    why_had: 'Why did you have the Idea',
+    why_matters: 'Why does the Idea Matter',
+    fit: 'How does the Idea Fit into the big picture of the project',
+  };
+
+  // The idea's five sections, IN FRONT of the voter — the entire reason voting
+  // happens in the hall rather than on a reaction. Rendered in template order.
+  function ideaSectionsHtml(item) {
+    const fv = item.subject && item.subject.field_values;
+    if (!fv) return '';
+    const rows = Object.keys(SECTION_LABELS).map((key) => `
+      <div class="gov-perm">
+        <div class="gov-perm__main">
+          <code class="gov-perm__key">${escapeHtml(SECTION_LABELS[key])}</code>
+          <div class="gov-perm__guards">${escapeHtml(String(fv[key] ?? ''))}</div>
+        </div>
+      </div>`).join('');
+    const score = item.subject.completeness_score;
+    return `<details class="gov-section"><summary class="gov-section__head">The idea, in full${score != null ? ` \u00b7 completeness ${escapeHtml(String(score))}/100` : ''}</summary>${rows}</details>`;
+  }
+
+  function voteFormHtml(item, viewerId) {
+    if (item.closed_at) return '';
+    const mine = item.votes.find((v) => String(v.voter_id) === String(viewerId));
+    if (mine) return '';
+    if (item.subject_type === 'full_idea' && item.subject && String(item.subject.author_id) === String(viewerId)) {
+      return `<p class="gov-grid-note">This is your idea \u2014 its author does not vote on it. The board decides; a return comes back to you with its reason.</p>`;
+    }
+    const sections = Object.keys(SECTION_LABELS).map((key) => `
+      <label class="gov-perm" style="cursor:pointer"><input type="radio" name="vote-section-${escapeHtml(item.id)}" value="${escapeHtml(key)}"> <span>${escapeHtml(SECTION_LABELS[key])}</span></label>`).join('');
+    return `<div class="gov-vote" data-item="${escapeHtml(item.id)}">
+      <button type="button" class="gov-btn" data-vote="yes">Vote yes</button>
+      <details class="gov-vote__no">
+        <summary class="gov-btn gov-btn--ghost">Object\u2026</summary>
+        <p class="gov-grid-note">An objection returns the idea to its author with your reason and the section it faults \u2014 the feedback they revise against.</p>
+        <textarea class="gov-input" data-vote-reason placeholder="Why \u2014 the reason the author will act on" maxlength="5000" rows="3"></textarea>
+        <div class="gov-vote__sections">${sections}</div>
+        <button type="button" class="gov-btn" data-vote="no">Cast objection</button>
+      </details>
+    </div>`;
+  }
+
+  async function castVoteFromRoom(itemId, direction, container) {
+    const body = { direction };
+    if (direction === 'no') {
+      const reason = (container.querySelector('[data-vote-reason]') || {}).value || '';
+      const picked = container.querySelector(`input[name="vote-section-${itemId}"]:checked`);
+      body.reason_md = reason;
+      if (picked) body.section_key = picked.value;
+    }
+    try {
+      const out = await sendJson('POST', `/government/board/items/${encodeURIComponent(itemId)}/votes`, body);
+      toast(out.item_closed
+        ? `Vote cast \u2014 the sitting closed: ${out.outcome}.`
+        : 'Vote cast.');
+    } catch (err) {
+      if (err && err.kind === '401') return;
+      toast(`Could not vote: ${err.message || err}`);
+    }
+    loadBoard(); // re-render either way — the room shows what stands
+  }
+
   function itemCard(item, viewerId) {
     const yes = item.votes.filter((v) => v.direction === 'yes').length;
     const no = item.votes.filter((v) => v.direction === 'no').length;
@@ -628,7 +709,9 @@
       ${amendmentDetail}
       <p class="gov-grid-note">tally: ${yes} yes · ${no} no — sitting under <code>${escapeHtml((item.constitution && item.constitution.pass_rule) || '?')}</code>, membership <code>${escapeHtml((item.constitution && item.constitution.membership) || '?')}</code></p>
       ${myLine}
+      ${item.closed_at ? '' : ideaSectionsHtml(item)}
       ${ballotHtml(item, viewerId)}
+      ${voteFormHtml(item, viewerId)}
     </section>`;
   }
 
@@ -649,6 +732,16 @@
       (open || window.OTBKit.emptyStateHtml('Nothing is before the board. When a Full Idea clears the completeness grade, its window opens here.'))
       + `<h2 class="gov-h">Closed sittings</h2>`
       + (closed || `<p class="gov-empty">No sitting has closed yet.</p>`);
+    // R17: the cast buttons. One delegated listener; the SERVER refuses every
+    // illegitimate cast regardless (membership, anti-self, closed, expired) —
+    // the form is a courtesy, the route is the wall.
+    box.querySelectorAll('.gov-vote [data-vote]').forEach((btn) => {
+      btn.addEventListener('click', () => {
+        const wrap = btn.closest('.gov-vote');
+        btn.disabled = true;
+        castVoteFromRoom(wrap.dataset.item, btn.dataset.vote, wrap);
+      });
+    });
   }
 
   // ---- init ----------------------------------------------------------------

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.235",
+  "version": "1.19.236",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.235",
+      "version": "1.19.236",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.235",
+  "version": "1.19.236",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -897,8 +897,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.233 with no explicit bump. run 32161368847. (task 1002620)
 //   1.19.235 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.234 with no explicit bump. run 32161981393. (task 1002620)
+//   1.19.236 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.235 with no explicit bump. run 32162811851. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.235'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.236'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/government_board_view.mjs

@@ -56,7 +56,7 @@ test('the assembled view: enrichment, the open ballot, the snapshot, the databas
     },
     getIdeaSubjects: async (ids) => {
       assert.deepEqual(ids.map(String).sort(), ['6', '7']);
-      return [{ id: 7n, title: 'A big idea', captured_by: 9n }]; // idea 6 is GONE — deleted subject
+      return [{ id: 7n, title: 'A big idea', captured_by: 9n, field_values: { purpose: 'p' }, template_key: 'base-v1', completeness_score: 82 }]; // idea 6 is GONE — deleted subject
     },
     getAmendmentSubjects: async (ids) => {
       assert.deepEqual(ids.map(String), ['5']);
@@ -68,7 +68,9 @@ test('the assembled view: enrichment, the open ballot, the snapshot, the databas
   assert.equal(view.closed.length, 1);
 
   const idea = view.open[0];
-  assert.deepEqual(idea.subject, { title: 'A big idea', author_id: '9' }, 'an idea shows its title + author (R17 greys anti-self from this)');
+  assert.deepEqual(idea.subject,
+    { title: 'A big idea', author_id: '9', field_values: { purpose: 'p' }, template_key: 'base-v1', completeness_score: 82 },
+    'an idea shows its title, author, AND its five sections — the voter decides with the idea in front of them (R17)');
   assert.equal(idea.remaining_seconds, 540, 'the DATABASE clock, passed through — the client never does clock math');
   assert.deepEqual(idea.constitution, MONARCHY, 'the SNAPSHOT rides along — the room describes the rule the item runs under');
   assert.equal(idea.votes.length, 1);

package/tests/government_board_vote_ui.mjs

@@ -0,0 +1,70 @@
+// tests/government_board_vote_ui.mjs — the vote UI (BV1.R17 of goal 1000069,
+// criteria C2/C5): cast, reason box, five-section picker — with the full idea
+// in front of the voter, which is the entire reason voting happens in the hall
+// rather than on a Discord reaction.
+//
+// Browser code cannot be imported into node tests wholesale (it is an IIFE over
+// the DOM), so these are SOURCE PINS over the exact seams that must not drift —
+// the same technique the palette and hall audits use — plus one real cross-
+// module equality: the section labels against the template declaration.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const CLIENT = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', 'government.js'), 'utf8');
+const { BASE_TEMPLATE } = require(path.join(ROOT, 'modules', 'ideas', 'templates.js'));
+const board = require(path.join(ROOT, 'modules', 'government', 'board.js'));
+
+test('the five section labels ARE the template declaration — key and label, in order', () => {
+  const block = CLIENT.slice(CLIENT.indexOf('const SECTION_LABELS'), CLIENT.indexOf('function ideaSectionsHtml'));
+  const declared = [...block.matchAll(/(\w+): '([^']+)'/g)].map((m) => [m[1], m[2]]);
+  const template = BASE_TEMPLATE.fields.map((f) => [f.key, f.label]);
+  assert.deepEqual(declared, template,
+    'the voter reads the same five section names the author wrote under — held equal here because browser code cannot import the server module');
+});
+
+test('the idea is in front of the voter: sections render from the subject, in template order', () => {
+  assert.match(CLIENT, /item\.subject\.field_values|subject && item\.subject\.field_values/,
+    'the sections come from the board view payload, never a second fetch');
+  assert.match(CLIENT, /Object\.keys\(SECTION_LABELS\)\.map/,
+    'rendered in the declared order — jsonb key order is never trusted');
+  const card = CLIENT.slice(CLIENT.indexOf('function itemCard'), CLIENT.indexOf('async function loadBoard'));
+  assert.match(card, /ideaSectionsHtml\(item\)/, 'the sections sit ON the item card, above the ballot');
+});
+
+test('an objection needs the reason AND exactly one section; a yes sends neither', () => {
+  const cast = CLIENT.slice(CLIENT.indexOf('async function castVoteFromRoom'), CLIENT.indexOf('function itemCard'));
+  assert.match(cast, /if \(direction === 'no'\)/, 'reason + section are attached only to an objection');
+  assert.match(cast, /body\.reason_md = reason/, 'the reason box feeds reason_md');
+  assert.match(cast, /body\.section_key = picked\.value/, 'the picker feeds exactly one section_key');
+  assert.match(cast, /\/government\/board\/items\/.*\/votes/, 'casts into R08\'s route — the server is the wall');
+  assert.match(cast, /loadBoard\(\)/, 'the room re-renders either way — it shows what stands');
+  assert.match(cast, /item_closed/, 'a cast that CLOSED the sitting says so (first_ratifier / full turnout)');
+});
+
+test('the author of a full_idea sees the anti-self note instead of a form — amendments do not', () => {
+  const form = CLIENT.slice(CLIENT.indexOf('function voteFormHtml'), CLIENT.indexOf('async function castVoteFromRoom'));
+  assert.match(form, /subject_type === 'full_idea'[^]*author_id.*viewerId/,
+    'the grey-out is SUBJECT-TYPED, mirroring castVote\'s carve-out — an amendment proposer may vote (§7)');
+  assert.match(form, /does not vote on it/, 'the note says why, not just no');
+  assert.match(form, /if \(mine\) return ''/, 'one vote per member — a cast voter gets no second form');
+  assert.match(form, /if \(item\.closed_at\) return ''/, 'closed sittings take no votes');
+});
+
+test('every refusal castVote can return has friendly copy', () => {
+  // The route maps board.js's typed refusals to res.fail codes; the client's
+  // ERROR_COPY must name each one so a refused vote explains itself.
+  const source = fs.readFileSync(path.join(ROOT, 'modules', 'government', 'board.js'), 'utf8');
+  const castBlock = source.slice(source.indexOf('function validateVote'), source.indexOf('// ── close + tally'));
+  const reasons = [...new Set([...castBlock.matchAll(/reason: '([a-z_]+)'/g)].map((m) => m[1]))];
+  assert.ok(reasons.length >= 6, `sanity: found castVote's refusal set (${reasons})`);
+  const copyBlock = CLIENT.slice(CLIENT.indexOf('const ERROR_COPY'), CLIENT.indexOf('const friendlyError'));
+  for (const r of reasons) {
+    assert.ok(copyBlock.includes(`${r}:`), `ERROR_COPY must explain '${r}'`);
+  }
+});