@bongos/core 1.19.23 → 1.19.24

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.23",
-  "core_contract": "1.19.23",
-  "source_commit": "fcdc2c0100a2b96183b34980f7c33572b67c7d1f",
+  "core_version": "1.19.24",
+  "core_contract": "1.19.24",
+  "source_commit": "e17b55346ce6c5a5b0e7c17be12fd87f49805bfa",
   "source_ref": "HEAD",
-  "built_at": "2026-08-11T01:44:34.493Z",
+  "built_at": "2026-08-11T01:49:44.456Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 285,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 1510,
-  "tree_sha256": "80499ca716f5acc869706f3832aba22ffa0facdf31abd6eca71baec9b273d628",
+  "tree_sha256": "238b6875fb5bfeb460a7d827d8b671f23f910870fdfffaa09977138b1537865c",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -4002,12 +4002,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "969211290cee8ccee357109c325ff4741c8cce3319d520b22506126099beea7e"
+      "sha256": "642ec17a7c466b31700ea4759e0f3f3f1622f016bd5ce39122ac50ae1b393449"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "b00d5423d5019e305bb488af793202ccb4d3089da6c129851e32f85ea4219904"
+      "sha256": "00411692affd964ada475f325a9e810cd2d351d5b168500d32759a70ef2af627"
     },
     {
       "path": "public-docs/index.html",
@@ -5522,7 +5522,7 @@
     {
       "path": "src/bongos/routes/auth.js",
       "mode": "0000644",
-      "sha256": "2cacde2aa0984457904c0a29cc0dd0d41e32be89b7b6e401d885662805c3de5e"
+      "sha256": "b1389bf7cb4d53a27d332106ddbcd9327d76521c2330b4763d4ed0919c52f2a5"
     },
     {
       "path": "src/bongos/routes/backup.js",
@@ -5627,7 +5627,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "0e4203ec0098beb9a54a4ea56b3c5701cfca5bb02b6676114a9257f5b353aff5"
+      "sha256": "08c66b410a4563d54fa8e8f6c0cf0ab077bf95b902923eb785419e8f261ebe99"
     },
     {
       "path": "src/module-loader/loader.js",
@@ -5797,7 +5797,7 @@
     {
       "path": "tests/auth_error_brand.mjs",
       "mode": "0000644",
-      "sha256": "e28bdcf3149d3baa15fdd4d5a44276953abfa3633ff37923f75355be746fc840"
+      "sha256": "e94cdcd827f8e981b62c4f9f403678d5dda0af6e5fb5cbf1cb667b94eb1bfc49"
     },
     {
       "path": "tests/auth_flow_slice1.mjs",

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.23",
+  "version": "1.19.24",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.23",
+      "version": "1.19.24",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.23",
+  "version": "1.19.24",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/bongos/routes/auth.js

@@ -21,6 +21,14 @@ function escapeHtml(s) {
 //   subtitle — replaces the default header sub-line
 //   cta      — { href, label } for the primary button (default: retry sign-in)
 //   note     — replaces the default troubleshooting footnote
+// The instance's own word for the admitting rank, for per-branch error strings
+// (task 1002616, the 1439 follow-up): core error surfaces never hardcode
+// "Archon" — a non-OTB instance names its own role (branding rankLabels.archon;
+// ADR 0062 §3). Used as "the ${admitterLabel()}", so labels stay grammatical.
+function admitterLabel() {
+  try { return branding().rankLabels?.archon || 'owner'; } catch { return 'owner'; }
+}
+
 function renderAuthErrorPage(heading, detail, opts = {}) {
   // Every fixed string on this page — the tab-title suffix, epigraph, page
   // heading, sub-line, and retry button — is owned by the instance branding
@@ -500,7 +508,7 @@ module.exports = function buildAuthRouter() {
     if (!code || !state || state !== expectedState) {
       return res.status(400).type('text/html').send(renderAuthErrorPage(
         'State mismatch',
-        'The handshake-cookie did not match the state GitHub returned. This usually means the sign-in took too long (cookie expired after 10 minutes) or the request crossed an origin boundary. Start over and the gate will open.',
+        'The handshake-cookie did not match the state GitHub returned. This usually means the sign-in took too long (cookie expired after 10 minutes) or the request crossed an origin boundary. Start over and sign in again.',
       ));
     }
     try {
@@ -584,18 +592,18 @@ module.exports = function buildAuthRouter() {
         }
         return res.status(403).type('text/html').send(renderAuthErrorPage(
           'This account is not approved yet',
-          'Signing in with GitHub is only for builders an Archon has already approved. If you are new, request access at the builders’ hall — an Archon will approve you, then this sign-in will let you in. If you were just approved, the Archon may still need to mark you invited; give it a moment and try again.',
+          `Signing in with GitHub is only for builders the ${admitterLabel()} has already approved. If you are new, request access at the builders’ hall — once the ${admitterLabel()} approves you, this sign-in will let you in. If you were just approved, it may take a moment to be marked invited; try again shortly.`,
           {
             subtitle: 'Sign-in is for approved builders. New here? Request access first.',
             cta: { href: '/builders', label: 'Go to the hall & request access' },
-            note: 'Already approved and still blocked? Ask the Archon to confirm your request was marked “invited.”',
+            note: `Already approved and still blocked? Ask the ${admitterLabel()} to confirm your request was marked “invited.”`,
           },
         ));
       }
       console.error('[gds] web/callback', err);
       res.status(500).type('text/html').send(renderAuthErrorPage(
         'The handshake threw an error',
-        `The server tried to exchange the auth code for a session and something went wrong: ${err.message}. Try again; if it persists, the Archon must investigate the server logs.`,
+        `The server tried to exchange the auth code for a session and something went wrong: ${err.message}. Try again; if it persists, ask the ${admitterLabel()} to investigate the server logs.`,
       ));
     }
   });
@@ -727,7 +735,7 @@ module.exports = function buildAuthRouter() {
       console.error('[gds] discord/callback', err);
       res.status(500).type('text/html').send(renderAuthErrorPage(
         'The Discord link threw an error',
-        'Linking failed unexpectedly. Try again; if it persists, the Archon must check the server logs.',
+        `Linking failed unexpectedly. Try again; if it persists, ask the ${admitterLabel()} to check the server logs.`,
         { cta: { href: '/builders', label: 'Back to the hall' } },
       ));
     }
@@ -1061,3 +1069,6 @@ module.exports.reqHost = reqHost;
 // The auth-error page renderer (task 1439): pure over the branding pack, so a
 // test can prove every visible string is brand-owned (no OTB lore baked in).
 module.exports.renderAuthErrorPage = renderAuthErrorPage;
+// The admitting-rank label for per-branch strings (task 1002616) — exported for
+// the same reason: the test proves the label is pack-owned, never "Archon".
+module.exports.admitterLabel = admitterLabel;

package/src/module-api.js

@@ -473,8 +473,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.21 with no explicit bump. run 31449168428. (task 1002620)
 //   1.19.23 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.22 with no explicit bump. run 31450197816. (task 1002620)
+//   1.19.24 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.23 with no explicit bump. run 31450459825. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.23'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.24'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/auth_error_brand.mjs

@@ -67,6 +67,33 @@ const escapeHtml = (s) => String(s ?? '').replace(/[&<>"']/g, (c) => ({
   '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;',
 }[c]));
 
+// ---- task 1002616: the per-branch CALL-SITE strings are lore-free too ----
+// Task 1439 made the TEMPLATE brand-aware but deliberately scoped out the
+// heading/detail arguments each callback error branch passes in. Those still
+// said "an Archon has already approved", "the Archon must investigate", and
+// "the gate will open" — instance lore rendered on every instance.
+
+test('call-site strings: no hardcoded Archon/gate lore in the auth error branches (task 1002616)', async () => {
+  const { readFileSync } = await import('node:fs');
+  const src = readFileSync(new URL('../src/bongos/routes/auth.js', import.meta.url), 'utf8');
+  // The four exact leaks, pinned so they cannot return verbatim…
+  assert.doesNotMatch(src, /gate will open/, 'state-mismatch branch must not carry gate lore');
+  assert.doesNotMatch(src, /an Archon has already approved|an Archon will approve/, 'NOT_APPROVED branch must not hardcode Archon');
+  assert.doesNotMatch(src, /Ask the Archon\b/, 'the NOT_APPROVED note must not hardcode Archon');
+  assert.doesNotMatch(src, /the Archon must (investigate|check)/, 'the 500 branches must not hardcode Archon');
+  // …and the label helper is actually what the branches interpolate.
+  assert.match(src, /admitterLabel\(\)/, 'branches resolve the instance label at render time');
+});
+
+test('admitterLabel: pack-owned with a neutral fallback (task 1002616)', () => {
+  const { admitterLabel } = authMod;
+  const label = admitterLabel();
+  const pack = loadBranding({ env: {} });
+  const expected = pack.rankLabels?.archon || 'owner';
+  assert.equal(label, expected, 'the label is the ambient pack’s rankLabels.archon');
+  assert.notEqual(label.trim(), '', 'never empty');
+});
+
 test('renderAuthErrorPage interpolates the branding pack, not hardcoded lore', () => {
   // Whatever pack is ambient in this checkout, the rendered page must carry ITS
   // authError values and ITS worldName — that is the pack-driven property.