@bongos/core 1.19.219 → 1.19.220

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.219",
-  "core_contract": "1.19.219",
-  "source_commit": "c74ac31eedb3ec3676f8517b51302df625298931",
+  "core_version": "1.19.220",
+  "core_contract": "1.19.220",
+  "source_commit": "c0428ccbca81e3243f981295653e2996e9cda202",
   "source_ref": "HEAD",
-  "built_at": "2026-08-18T03:06:20.562Z",
+  "built_at": "2026-08-18T03:14:10.378Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 311,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1302,
+    "functional_verbatim": 1303,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1634,
-  "tree_sha256": "4da1158ccf79b2a7a5253dad319cc74192493be9bda2e6a8874df8c60f581cc5",
+  "file_count": 1635,
+  "tree_sha256": "aac7f97a1131f16c75b768382681a70085520bf75be38b35124497b3d734e097",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2964,6 +2964,11 @@
       "mode": "0000644",
       "sha256": "75913af702d6529c9a5cf2e2c42d9c329eea92ae99274fb71f2524520de4cfbf"
     },
+    {
+      "path": "modules/government/migrations/government_005_seeded_rank_descriptions.sql",
+      "mode": "0000644",
+      "sha256": "dc570f8871b578a8af965ffbc91fc4e195f2e7fce7d7886166f0025ac2b47bce"
+    },
     {
       "path": "modules/government/module.json",
       "mode": "0000644",
@@ -4287,12 +4292,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "ac23681c5493a57f1faca551e4896e4a7a4e2dabb6246bf2a84c39ae6e571257"
+      "sha256": "352bfdf3484cd27c33da65632970d50a1b99e164008d45b2689cb365fee16720"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "7122e5cca352a5abc317d25267eba6c0bab955febf2179bf362a896be424d0bc"
+      "sha256": "719aa0ff0ff7323f96ad1257c3505c5929943f64d3e00f9cdb6f4fce78dc150e"
     },
     {
       "path": "public-docs/index.html",
@@ -5907,7 +5912,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "d509a7e4f16027ccef999e8aadf1a2cef5368bce5cd0c3bda3b7eb61cbceaa5f"
+      "sha256": "6f39901735ba86e7abd2b5770b36146104ac47dec250131ac24eeca6754ef5f2"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6907,7 +6912,7 @@
     {
       "path": "tests/government_seed.mjs",
       "mode": "0000644",
-      "sha256": "e7f980f02abfb057d725beaf5730fdd71f4e8249af2180bf4a355632481330d6"
+      "sha256": "8240fef8ed5b7e9a4c16e17e8dd5ffa522a99e320d41229f58f2214e00bcf160"
     },
     {
       "path": "tests/government_session_scope.mjs",

package/modules/government/migrations/government_005_seeded_rank_descriptions.sql

@@ -0,0 +1,78 @@
+-- government_005_seeded_rank_descriptions.sql — the last "role" on the government
+-- side: the four seeded ranks still DESCRIBE themselves as rank-roles
+-- (task 1003083 / goal 1000068, criterion govt-ranks-not-roles). Decision of
+-- record: ADR 0174.
+--
+-- ── WHAT WAS MISSED, AND WHY ────────────────────────────────────────────────
+-- The rename cleaned the CONFIG TEMPLATE but never the LIVE ROWS.
+-- config/government.neutral.json already reads "Seeded rank — …" for all four,
+-- so the repo looks correct and a fresh instance boots with the right words in
+-- its template. But `GET /api/bongos/government/ranks` reads the DB, and on the
+-- live database every seeded row still carries the text governance_002 wrote:
+--
+--   archon : 'Seeded rank-role — top authority. Adds the admin + system (non-grantable) powers.'
+--   metic  : 'Seeded rank-role — the trusted working rank. Adds review/triage/authoring.'
+--   thetes : 'Seeded rank-role — graduated newcomer. Adds the general claim queue.'
+--   xenos  : 'Seeded rank-role — the sandboxed entry rank. Own-work + public read.'
+--
+-- government_001 renamed the TABLES and government_002 renamed the permission
+-- KEYS; neither touched this column. The hall's Government tab renders these
+-- strings, so the surface goal 1000068 renamed has been displaying the reserved
+-- word to the Owner ever since.
+--
+-- ── WHY THE FITNESS WALL DID NOT CATCH IT ───────────────────────────────────
+-- Check 19 (checkVocabularyWall, scripts/gds/fitness.js) scans FILES on the
+-- government surface, and only .js/.json/.html/.css at that. It cannot see DB
+-- row text. That is the rule working as designed, not a hole in it — which is
+-- precisely why this needed a migration rather than a lint fix.
+--
+-- ── WHY THIS CORRECTS FORWARD INSTEAD OF EDITING governance_002 ─────────────
+-- governance_002 is applied and run-once (schema_migrations is stem-keyed), so
+-- editing its text would change history without changing any database. It also
+-- stays deliberately spelled the old way: it is the factual record of what was
+-- once true, which is exactly the carve-out ADR 0174 grants the historical
+-- migrations. government_002 (the permission-key rename) is the worked example
+-- this copies. On a FRESH install the two converge — governance_002 seeds the
+-- old text, this rewrites it — so both paths end identically.
+--
+-- ── THE GUARD IS LOAD-BEARING ───────────────────────────────────────────────
+-- The WHERE clause matches the OLD SEEDED TEXT EXACTLY rather than blanket-
+-- updating by rank_key. A host may have relabelled a seeded rank through
+-- config (config/government.json may relabel a seeded rank — it may never
+-- re-grant one), and overwriting a deliberate customisation with our template
+-- would be a silent regression dressed as a typo fix. Matching the exact string
+-- governance_002 wrote touches only rows nobody has edited. It also makes this
+-- migration idempotent: re-running it matches nothing.
+--
+-- NAMING ONLY. No grant, floor, or authority change; is_system and seeded_rank
+-- are untouched; no row is inserted or deleted. Safe to run against a database
+-- where some or all four have already been corrected by hand.
+--
+-- ROLLBACK — reverse the mapping (lossless; restores the governance_002 text):
+--   UPDATE government_ranks SET description = replace(description, 'Seeded rank —', 'Seeded rank-role —')
+--    WHERE is_system AND rank_key IN ('xenos','thetes','metic','archon')
+--      AND description LIKE 'Seeded rank —%';
+
+BEGIN;
+
+UPDATE government_ranks AS g
+   SET description = v.new_description
+  FROM (VALUES
+    ('xenos',
+     'Seeded rank-role — the sandboxed entry rank. Own-work + public read.',
+     'Seeded rank — the sandboxed entry rank. Own-work + public read.'),
+    ('thetes',
+     'Seeded rank-role — graduated newcomer. Adds the general claim queue.',
+     'Seeded rank — graduated newcomer. Adds the general claim queue.'),
+    ('metic',
+     'Seeded rank-role — the trusted working rank. Adds review/triage/authoring.',
+     'Seeded rank — the trusted working rank. Adds review/triage/authoring.'),
+    ('archon',
+     'Seeded rank-role — top authority. Adds the admin + system (non-grantable) powers.',
+     'Seeded rank — top authority. Adds the admin + system (non-grantable) powers.')
+  ) AS v(rank_key, old_description, new_description)
+ WHERE g.rank_key = v.rank_key
+   AND g.is_system
+   AND g.description = v.old_description;
+
+COMMIT;

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.219",
+  "version": "1.19.220",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.219",
+      "version": "1.19.220",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.219",
+  "version": "1.19.220",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -865,8 +865,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.217 with no explicit bump. run 32086598601. (task 1002620)
 //   1.19.219 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.218 with no explicit bump. run 32094215476. (task 1002620)
+//   1.19.220 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.219 with no explicit bump. run 32094701831. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.219'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.220'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/government_seed.mjs

@@ -37,6 +37,7 @@ const NON_GRANT_MIGRATIONS = new Set([
   'government_001_rename_from_governance.sql',     // ADR 0174 table rename (task 1003004)
   'government_002_rename_permission_keys.sql',     // ADR 0174 key rename (task 1003006)
   'government_003_board_tables.sql',               // ADR 0175 Board Room schema (task 1003016)
+  'government_005_seeded_rank_descriptions.sql',   // ADR 0174 seeded-description text fix (task 1003083)
 ]);
 
 // Permission keys RENAMED after the grant migrations that first granted them.
@@ -142,6 +143,35 @@ test('later grant migrations are idempotent + transactional', () => {
   }
 });
 
+// The bug this guards (task 1003083): goal 1000068 renamed the government, and
+// config/government.neutral.json was updated to say "Seeded rank — …". The LIVE
+// government_ranks rows were not, so `GET /government/ranks` — and the hall tab
+// that renders it — kept serving governance_002's "Seeded rank-role — …" long
+// after the rename shipped. Two lists of the same strings, only one maintained:
+// exactly the drift this file exists to prevent, in the one column nobody had
+// pointed a test at. The vocabulary fitness wall cannot see it either — Check 19
+// scans .js/.json/.html/.css files, never DB row text or .sql.
+test('the description correction lands EXACTLY the config template text (no second list that drifts)', () => {
+  const correction = fs.readFileSync(path.join(MIG_DIR, 'government_005_seeded_rank_descriptions.sql'), 'utf8');
+  const neutral = JSON.parse(fs.readFileSync(path.join(ROOT, 'config', 'government.neutral.json'), 'utf8'));
+
+  // Each VALUES row is ('<rank_key>', '<old_description>', '<new_description>').
+  const rows = [...stripComments(correction).matchAll(/\(\s*'([a-z]+)'\s*,\s*'([^']+)'\s*,\s*'([^']+)'\s*\)/g)]
+    .map(([, rankKey, , newDescription]) => [rankKey, newDescription]);
+
+  assert.equal(rows.length, RANK_ORDER.length,
+    'the correction must cover every seeded rank, not a subset');
+
+  for (const [rankKey, newDescription] of rows) {
+    const template = neutral.ranks[rankKey];
+    assert.ok(template, `${rankKey}: not a rank in config/government.neutral.json`);
+    assert.equal(newDescription, template.description,
+      `${rankKey}: the migration writes text the config template does not carry — the two lists have drifted again`);
+    assert.ok(!/\brole/i.test(newDescription),
+      `${rankKey}: "role" is reserved for the crafts (ADR 0174) — a rank describes itself as a rank`);
+  }
+});
+
 test('migration objects are all governance_-namespaced (ADR 0083 §5)', () => {
   for (const sql of [tablesSql, seedSql]) {
     for (const m of sql.matchAll(/CREATE (?:TABLE|INDEX)(?: IF NOT EXISTS)? (\w+)/g)) {