@bongos/core 1.19.204 → 1.19.206

package/tests/publish_reconciler.mjs

@@ -212,6 +212,69 @@ test('no push credential → no-op (skipped: unconfigured), never touches the DB
   assert.equal(deps._calls.status.length, 0, 'must not call GitHub when unconfigured');
 });
 
+// task 1003049 — an App with id + key but no repo installation passes isConfigured,
+// then every per-branch call throws APP_NOT_INSTALLED into a best-effort catch:
+// silent stranding. The sweep must instead say it loudly ONCE and park.
+test('1003049 App configured but NOT installed → loud one-time WARN, sweep parked, heals when installed', async () => {
+  const deps = mkDeps({ configured: true, rows: [{ task_id: 1, builder_id: 9, worktree_name: 'wt' }] });
+  deps.warnState = {};
+  let installed = false;
+  deps.githubPush.appConfigured = () => true;
+  deps.githubPush.getInstallationToken = async () => {
+    if (!installed) {
+      throw Object.assign(new Error('APP_NOT_INSTALLED'), {
+        code: 'APP_NOT_INSTALLED', owner: 'someowner', repo: 'somerepo',
+        install_url: 'https://github.com/apps/x/installations/new',
+      });
+    }
+    return 'tok';
+  };
+  const r1 = await reconciler.runSweep(deps);
+  assert.equal(r1.skipped, 'app_not_installed');
+  assert.equal(deps._calls.status.length, 0, 'no per-branch GitHub calls while uninstallable');
+  const warns = () => deps._calls.errors.filter((m) => /not installed/.test(m));
+  assert.equal(warns().length, 1, 'warned exactly once');
+  assert.match(warns()[0], /someowner\/somerepo/, 'names the repo');
+  assert.match(warns()[0], /installations\/new/, 'carries the install URL');
+  const r2 = await reconciler.runSweep(deps);
+  assert.equal(r2.skipped, 'app_not_installed');
+  assert.equal(warns().length, 1, 'the streak stays quiet');
+  installed = true;
+  const r3 = await reconciler.runSweep(deps);
+  assert.ok(!r3.skipped, 'an installed App lets the sweep run again');
+});
+
+test('1003049 foreign-install watch: WARNs once per streak on installs beyond the repo owner, re-arms when clean', async () => {
+  const deps = mkDeps({ configured: true, rows: [] });
+  deps.warnState = {};
+  let roster = [{ id: 2, account: 'stranger' }];
+  deps.githubPush.appConfigured = () => true;
+  deps.githubPush.getInstallationToken = async () => 'tok';
+  deps.githubPush.foreignInstallations = async () => roster;
+  const warns = () => deps._calls.errors.filter((m) => /beyond the repo owner/.test(m));
+  await reconciler.runSweep(deps);
+  assert.equal(warns().length, 1, 'a foreign install is surfaced loudly');
+  assert.match(warns()[0], /stranger/, 'names the account');
+  await reconciler.runSweep(deps);
+  assert.equal(warns().length, 1, 'the streak stays quiet');
+  roster = [];
+  await reconciler.runSweep(deps);
+  roster = [{ id: 9, account: 'other' }];
+  await reconciler.runSweep(deps);
+  assert.equal(warns().length, 2, 'a clean roster re-arms the warning');
+});
+
+test('1003049 a transient App-token exchange failure does NOT park the sweep', async () => {
+  const deps = mkDeps({ configured: true, rows: [] });
+  deps.warnState = {};
+  deps.githubPush.appConfigured = () => true;
+  deps.githubPush.getInstallationToken = async () => {
+    throw Object.assign(new Error('boom'), { code: 'APP_TOKEN_FAILED', status: 500 });
+  };
+  const r = await reconciler.runSweep(deps);
+  assert.ok(!r.skipped, 'transient exchange failures are per-branch territory, not a park');
+});
+
 test('a landed branch → shipTask + broadcast fire, reconciled=1, attributed to the claim holder', async () => {
   const deps = mkDeps({
     rows: [{ task_id: 1096, builder_id: 7, worktree_name: 't1096-helpers', published_head_sha: ON_MAIN }],

package/tests/tool_scan_engine.mjs

@@ -60,8 +60,10 @@ async function test(name, fn) {
 
 const pens = [];
 const outsideDirs = [];
+const tmpDirs = [];
 function tmp(prefix) {
   const d = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), prefix)));
+  tmpDirs.push(d);
   return d;
 }
 
@@ -327,6 +329,17 @@ await test('fixture B: a clean scan normalizes into a persistable row', async ()
 
 for (const q of pens) { try { q.cleanup(); } catch { /* best effort */ } }
 for (const d of outsideDirs) { try { fs.rmSync(d, { recursive: true, force: true }); } catch { /* best effort */ } }
+// tmpDirs are the OUTER wrappers (pen tmpRoots + victim homes) — pen.cleanup()
+// removes only the pen root inside, so these must be swept explicitly.
+for (const d of tmpDirs) { try { fs.rmSync(d, { recursive: true, force: true }); } catch { /* best effort */ } }
+
+// The wrapper dirs tmp() creates OUTLIVE pen.cleanup() (which removes only the
+// pen root inside them) — 24 empty bongos-scan-host-* leftovers piled up in
+// Temp before this was verified (task 1003058). Prove the teardown is total.
+await test('teardown leaves none of this run\'s temp dirs behind', () => {
+  const leaked = tmpDirs.filter((d) => fs.existsSync(d));
+  assert.deepEqual(leaked, [], `leaked temp dirs: ${leaked.join(', ')}`);
+});
 
 console.log('');
 console.log(`tool_scan_engine: ${passed} passed, ${failed} failed`);