@bongos/core 1.19.185 → 1.19.186

package/src/bongos/serve-internal.js

@@ -751,7 +751,7 @@ function mountInternalSurfaces(app) {
   // The /watch monitoring page and the /harbor dev-box management page (idea 257)
   // and the /gate page (task 1179) all sit behind `page.view.government` — Metic
   // and up since ADR 0157. Same server-side page gate, same posture: a builder
-  // without the permission never receives the shell (requireGovernancePage — named
+  // without the permission never receives the shell (requireGovernmentPage — named
   // requireArchonPage before ADR 0157 — redirects them to the hall, and an
   // unauthenticated visitor into sign-in). The subdomain shim above has already
   // rewritten the bare /watch + /harbor + /gate onto /builders/*. (Defense in
@@ -766,13 +766,13 @@ function mountInternalSurfaces(app) {
   // data never leaked (the route gate held), but the page was the one item in the
   // group without a wall. Gated here so the group is uniform (task 1002710).
   const SESSIONS_PAGE_RE = /^\/builders\/sessions(?:\.html)?\/?$/;
-  // The /governance roles-and-permissions tab (BV1.R113) sits one floor higher:
+  // The /government ranks-and-permissions tab (BV1.R113) sits one floor higher:
   // the `government.manage` atom itself (archon), the same key its data routes
-  // check — requireGovernanceManagePage, not the metic-floored gate above.
-  const GOVERNANCE_PAGE_RE = /^\/builders\/governance(?:\.html)?\/?$/;
+  // check — requireGovernmentManagePage, not the metic-floored gate above.
+  const GOVERNMENT_PAGE_RE = /^\/builders\/government(?:\.html)?\/?$/;
   // The /people builder directory (task 1002577): gated on `project.curate`, the
   // exact permission its data route (GET /scouting) checks — same posture as the
-  // /governance tab above (the page can never drift wider than the API it fronts).
+  // /government tab above (the page can never drift wider than the API it fronts).
   const PEOPLE_PAGE_RE = /^\/builders\/people(?:\.html)?\/?$/;
   // /scouting is the LEGACY twin of /people — the same /api/gds/scouting directory,
   // left behind when task 1002577 graduated it into the hall. It has no nav entry
@@ -787,10 +787,10 @@ function mountInternalSurfaces(app) {
     const norm = path.posix.normalize(req.path);
     if (WATCH_PAGE_RE.test(norm) || HARBOR_PAGE_RE.test(norm) || GATE_PAGE_RE.test(norm)
       || SESSIONS_PAGE_RE.test(norm)) {
-      return gdsAuth.requireGovernancePage(req, res, next);
+      return gdsAuth.requireGovernmentPage(req, res, next);
     }
-    if (GOVERNANCE_PAGE_RE.test(norm)) {
-      return gdsAuth.requireGovernanceManagePage(req, res, next);
+    if (GOVERNMENT_PAGE_RE.test(norm)) {
+      return gdsAuth.requireGovernmentManagePage(req, res, next);
     }
     if (PEOPLE_PAGE_RE.test(norm) || SCOUTING_PAGE_RE.test(norm)) {
       return gdsAuth.requireProjectCuratePage(req, res, next);

package/src/module-api.js

@@ -797,8 +797,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.183 with no explicit bump. run 31974847472. (task 1002620)
 //   1.19.185 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.184 with no explicit bump. run 31976564067. (task 1002620)
+//   1.19.186 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.185 with no explicit bump. run 31977207459. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.185'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.186'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/auth_resolve_failure.mjs

@@ -93,17 +93,17 @@ test('AUDIT: every async middleware mounted directly on a router owns its reject
   // rot: a NEW bare `async function require*` added later fails this test.
   //   requireBuilder            — the API gate. Guarded here (BV1.R109-follow-up).
   //   requireBuilderPage         \
-  //   requireGovernancePage       \
-  //   requireGovernanceManagePage  > all five delegate to runPageGate, guarded by BV1.R107.
+  //   requireGovernmentPage       \
+  //   requireGovernmentManagePage  > all five delegate to runPageGate, guarded by BV1.R107.
   //   requireNonXenosPage         /  (the R113 roles-tab gate; the /people curate gate)
   //   requireProjectCuratePage   /
   // Anything else async and router-mounted must be added with its own try/catch.
   const src = fs.readFileSync(path.join(ROOT, 'src', 'bongos', 'auth.js'), 'utf8');
   const asyncMw = [...src.matchAll(/^async function (require\w+|allow\w+)\s*\(req, res, next\)/gm)].map((m) => m[1]);
-  assert.deepEqual(asyncMw.sort(), ['requireBuilder', 'requireBuilderPage', 'requireGovernanceManagePage', 'requireGovernancePage', 'requireNonXenosPage', 'requireProjectCuratePage'],
+  assert.deepEqual(asyncMw.sort(), ['requireBuilder', 'requireBuilderPage', 'requireGovernmentManagePage', 'requireGovernmentPage', 'requireNonXenosPage', 'requireProjectCuratePage'],
     'a new async router middleware appeared — give it a try/catch and add it here');
   // The page gates must actually delegate (that is WHY they are safe).
-  for (const name of ['requireBuilderPage', 'requireGovernancePage', 'requireGovernanceManagePage', 'requireNonXenosPage', 'requireProjectCuratePage']) {
+  for (const name of ['requireBuilderPage', 'requireGovernmentPage', 'requireGovernmentManagePage', 'requireNonXenosPage', 'requireProjectCuratePage']) {
     const fn = src.slice(src.indexOf(`async function ${name}`));
     assert.match(sliceFn(fn), /runPageGate\(/, `${name} must delegate to the guarded runPageGate`);
   }

package/tests/governance_abuse_matrix.mjs

@@ -264,9 +264,9 @@ test('V4: mass-assignment on role create is refused outright (strict schema)', a
 test('V4: a clean role create is never system and carries no grants', async () => {
   const r = await call('POST', '/government/ranks', { rank_key: 'sneaky-role', label: 'Sneaky' });
   assert.equal(r.status, 201);
-  assert.equal(r.json.role.is_system, false, 'a created role is never system');
-  assert.equal(r.json.role.seeded_rank, null);
-  assert.deepEqual(r.json.role.permissions, [], 'creation carries no grants');
+  assert.equal(r.json.rank.is_system, false, 'a created role is never system');
+  assert.equal(r.json.rank.seeded_rank, null);
+  assert.deepEqual(r.json.rank.permissions, [], 'creation carries no grants');
   const c = calls.find(([k]) => k === 'createRole');
   assert.deepEqual(Object.keys(c[1]).sort(), ['createdBy', 'description', 'label', 'rankKey'],
     'nothing beyond the four whitelisted fields reaches the db');

package/tests/governance_page_gates.mjs

@@ -50,13 +50,13 @@ const resolver = require('../modules/government/resolver.js');
 const wandering = require('../modules/builder-settings/wandering-prefs.js');
 const { attachFail } = require('../src/bongos/middleware/error-envelope.js');
 
-const GATES = ['requireBuilderPage', 'requireNonXenosPage', 'requireGovernancePage'];
+const GATES = ['requireBuilderPage', 'requireNonXenosPage', 'requireGovernmentPage'];
 const LIVE_RANKS = ['xenos', 'thetes', 'metic', 'archon'];
 
 // ═══ the ORACLE — hand-written, from the rank tests R107 deleted ═════════════
 // requireBuilderPage    admitted any session at all     → every live rank
 // requireNonXenosPage   admitted rank !== 'xenos'       → thetes and up
-// requireGovernancePage admitted rank === 'archon'      → archon only …until ADR 0157
+// requireGovernmentPage admitted rank === 'archon'      → archon only …until ADR 0157
 //
 // ADR 0157 (owner decision, 2026-08-05) lowered `page.view.government` archon→metic, so
 // the monitoring pages (/watch, /harbor, /gate) now open to the working rank. That gate
@@ -71,7 +71,7 @@ const LIVE_RANKS = ['xenos', 'thetes', 'metic', 'archon'];
 const PRE_R107_AUDIENCE = {
   requireBuilderPage: { xenos: true, thetes: true, metic: true, archon: true },
   requireNonXenosPage: { xenos: false, thetes: true, metic: true, archon: true },
-  requireGovernancePage: { xenos: false, thetes: false, metic: true, archon: true },
+  requireGovernmentPage: { xenos: false, thetes: false, metic: true, archon: true },
 };
 // Where a SIGNED-IN builder who fails the gate is sent. Never the sign-in flow —
 // they already have a session, so that would loop. Since task 1002613 (map N-1)
@@ -81,12 +81,12 @@ const PRE_R107_AUDIENCE = {
 const DENIED_TO = {
   requireBuilderPage: '/builders',
   requireNonXenosPage: '/builders/not-ready',
-  requireGovernancePage: '/builders',
+  requireGovernmentPage: '/builders',
 };
 const GATE_PERMISSION = {
   requireBuilderPage: 'page.view.public',
   requireNonXenosPage: 'page.view.builder',
-  requireGovernancePage: 'page.view.government',
+  requireGovernmentPage: 'page.view.government',
 };
 const deniedLoc = (gate, { unavailable = false } = {}) =>
   `${DENIED_TO[gate]}?denied=${GATE_PERMISSION[gate]}${unavailable ? '&reason=unavailable' : ''}`;
@@ -95,7 +95,7 @@ const GATE_FLOOR = {
   requireBuilderPage: 'xenos',
   requireNonXenosPage: 'thetes',
   // ADR 0157: `page.view.government` floor archon→metic.
-  requireGovernancePage: 'metic',
+  requireGovernmentPage: 'metic',
 };
 const SIGN_IN = '/api/gds/auth/web/start';
 
@@ -249,16 +249,16 @@ test('B4: the page gates resolve per request — no memoised authority (ADR 0016
   });
   const req = { headers: { cookie: 'gds_session=validtoken' } };
   let admitted = false;
-  await auth.requireGovernancePage(req, fakeRes(), () => { admitted = true; });
+  await auth.requireGovernmentPage(req, fakeRes(), () => { admitted = true; });
   assert.equal(admitted, true, 'an Archon should reach the page');
   keys = []; // the role is revoked between requests
   const second = fakeRes();
   let admittedAgain = false;
-  await auth.requireGovernancePage(req, second, () => { admittedAgain = true; });
+  await auth.requireGovernmentPage(req, second, () => { admittedAgain = true; });
   seams._reset();
   assert.equal(calls, 2, 'the resolver must be consulted on every request');
   assert.equal(admittedAgain, false, 'a revoked role must deny on the very next request');
-  assert.equal(second._redirect.loc, deniedLoc('requireGovernancePage'));
+  assert.equal(second._redirect.loc, deniedLoc('requireGovernmentPage'));
 });
 
 test('B5: every permission a page gate names is a real catalog key', async () => {

package/tests/governance_routes.mjs

@@ -189,8 +189,8 @@ test('without government.manage EVERY route 403s (reads included)', async () =>
 test('GET /government/ranks returns the role list with grants', async () => {
   const r = await call('GET', '/government/ranks');
   assert.equal(r.status, 200);
-  assert.equal(r.json.roles[0].rank_key, 'metic');
-  assert.deepEqual(r.json.roles[0].permissions, ['task.create']);
+  assert.equal(r.json.ranks[0].rank_key, 'metic');
+  assert.deepEqual(r.json.ranks[0].permissions, ['task.create']);
 });
 
 test('GET /government/permissions renders the catalog: grantable flags + principals, no DB call', async () => {
@@ -221,8 +221,8 @@ test('GET /government/assignments returns builder↔role rows', async () => {
 test('POST /government/ranks creates a custom role, created_by = the session builder', async () => {
   const r = await call('POST', '/government/ranks', { rank_key: 'triage-helper', label: 'Triage helper' });
   assert.equal(r.status, 201);
-  assert.equal(r.json.role.rank_key, 'triage-helper');
-  assert.equal(r.json.role.is_system, false);
+  assert.equal(r.json.rank.rank_key, 'triage-helper');
+  assert.equal(r.json.rank.is_system, false);
   const c = calls.find(([k]) => k === 'createRole');
   assert.equal(c[1].createdBy, 42, 'created_by must be the session builder, never input');
 });

package/tests/hall_nav.mjs

@@ -127,21 +127,22 @@ function hrefResolves(item) {
 
 test('sidebar groups read by audience, in order', () => {
   const nav = parseNav(boot().sidebarHtml);
-  // 'Archon' → 'Governance' in ADR 0157: the group's pages opened to Metic, so a header
+  // 'Archon' → 'Governance' in ADR 0157 (the group's pages opened to Metic, so a header
+  // naming the top rank was wrong), then → 'Government' by ADR 0174: a header
   // reading "Archon" over items a Metic can open would misdescribe the ladder.
-  assert.deepEqual(nav.map((g) => g.label), ['', 'You', 'Community', 'Docs', 'Governance']);
+  assert.deepEqual(nav.map((g) => g.label), ['', 'You', 'Community', 'Docs', 'Government']);
   assert.deepEqual(nav[0].items.map((i) => i.id), ['home', 'roadmap', 'goals', 'work'],
     'the unlabeled group is the project itself (task 1002425 order)');
   assert.deepEqual(nav[1].items.map((i) => i.id), ['standing', 'profile'], 'You = your own numbers');
   // People (task 1002577): the /scouting directory graduated into the hall.
   // Gated cosmetically to match its data endpoint — `project.curate`, floor METIC,
-  // so the nav entry reads 'governance' since task 1002710 (it said 'archon', which
+  // so the nav entry reads 'government' since ADR 0174 (it said 'archon', then
   // was stricter than the wall). requireProjectCuratePage is the wall server-side.
   assert.deepEqual(nav[2].items.map((i) => i.id), ['leaderboard', 'people'], 'Community = everyone else');
   assert.deepEqual(nav[3].items.map((i) => i.id),
     ['primer', 'ranks', 'economy', 'diagrams', 'atlas', 'modules', 'apidocs'], 'Docs = reference material');
-  // 'governance' (the Roles tab, BV1.R113) is the group's one archon-gated item.
-  assert.deepEqual(nav[4].items.map((i) => i.id), ['watch', 'harbor', 'gate', 'sessions', 'governance']);
+  // 'government' (the Permissions tab, BV1.R113) is the group's one archon-gated item.
+  assert.deepEqual(nav[4].items.map((i) => i.id), ['watch', 'harbor', 'gate', 'sessions', 'government']);
 });
 
 test('Economy lives in Docs and points at the reward-schedule page', () => {
@@ -190,11 +191,11 @@ test('Achievements has no nav entry, but #achievements still routes to Standing'
 
 test('collapsible groups carry a stable storage key (collapse persistence)', () => {
   const html = boot().sidebarHtml;
-  // 'archon' → 'governance' follows the ADR 0157 relabel. The slug is the
+  // 'archon' → 'governance' → 'government' follows ADR 0157 then ADR 0174. The slug is the
   // hall-nav-collapsed storage key, so any builder who had collapsed the old "archon"
   // group gets the new one expanded once — cosmetic, and preferable to keeping a stale
   // slug that no longer matches the visible label.
-  for (const g of ['you', 'community', 'docs', 'governance']) {
+  for (const g of ['you', 'community', 'docs', 'government']) {
     assert.match(html, new RegExp(`data-group="${g}"`), `${g} is collapsible (hall-nav-collapsed key)`);
   }
   assert.ok(!/nav-group--collapsible[^>]*>(?!<button)/.test(html.split('<div class="nav-group')[1] || ''),

package/tests/hall_page_gate_map.mjs

@@ -35,9 +35,9 @@ const SRC = fs.readFileSync(path.join(ROOT, 'src/bongos/serve-internal.js'), 'ut
 // Audiences (the floors live in modules/government/catalog.js; the gate
 // functions in src/bongos/auth.js):
 //   requireBuilderPage          page.view.public    any signed-in builder (xenos+)
-//   requireGovernancePage       page.view.government  metic+   (ADR 0157)
+//   requireGovernmentPage       page.view.government  metic+   (ADR 0157)
 //   requireProjectCuratePage    project.curate        metic+
-//   requireGovernanceManagePage government.manage     archon
+//   requireGovernmentManagePage government.manage     archon
 const ORACLE = {
   // Any signed-in builder — no rank floor.
   '/builders/work': 'requireBuilderPage',
@@ -57,10 +57,10 @@ const ORACLE = {
   '/builders/diagrams/02-b.png': 'requireBuilderPage',
 
   // Metic+ operator surfaces (the Governance nav group).
-  '/builders/watch': 'requireGovernancePage',
-  '/builders/harbor': 'requireGovernancePage',
-  '/builders/gate': 'requireGovernancePage',
-  '/builders/sessions': 'requireGovernancePage',
+  '/builders/watch': 'requireGovernmentPage',
+  '/builders/harbor': 'requireGovernmentPage',
+  '/builders/gate': 'requireGovernmentPage',
+  '/builders/sessions': 'requireGovernmentPage',
 
   // Metic+ via the `project.curate` atom — the exact permission GET /scouting
   // checks, so neither page can drift wider than the API it fronts.
@@ -68,7 +68,7 @@ const ORACLE = {
   '/builders/scouting': 'requireProjectCuratePage',
 
   // Archon.
-  '/builders/governance': 'requireGovernanceManagePage',
+  '/builders/government': 'requireGovernmentManagePage',
 
   // Deliberately UNGATED — the landing card, the rank ladder, the reward
   // schedule and a builder's public portfolio all render for a stranger.
@@ -124,7 +124,7 @@ test('the static parse actually found the gate wiring', () => {
   // If this file is ever restructured past the parser, these two fail LOUDLY
   // rather than letting every row below pass vacuously against an empty map.
   assert.ok(DISPATCH.some((d) => d.gate === 'requireBuilderPage'));
-  assert.ok(DISPATCH.some((d) => d.gate === 'requireGovernancePage'));
+  assert.ok(DISPATCH.some((d) => d.gate === 'requireGovernmentPage'));
 });
 
 test('every hall URL routes to the page gate the oracle names', () => {