@bongos/core 1.19.180 → 1.19.181

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.180",
-  "core_contract": "1.19.180",
-  "source_commit": "0e35108a1b162d8346e1262bf6453f991bd41de9",
+  "core_version": "1.19.181",
+  "core_contract": "1.19.181",
+  "source_commit": "3335e6696cc6d8b3c0a4d800860f76287c1fcc03",
   "source_ref": "HEAD",
-  "built_at": "2026-08-16T21:08:29.177Z",
+  "built_at": "2026-08-16T21:10:51.840Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 308,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1276,
+    "functional_verbatim": 1277,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1605,
-  "tree_sha256": "31a11588f3d36ea469e0fc02f4e295ffe55eac4b68f3a9979a49d44acddbaddb",
+  "file_count": 1606,
+  "tree_sha256": "411dfd39dd80ffce17841372dfaf756045f842fb17380c1caca33aa10251bc42",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2842,7 +2842,7 @@
     {
       "path": "modules/economy/credits.js",
       "mode": "0000644",
-      "sha256": "b6f8c6fcabe6cb9f5eb83e936d129509004c86969d5e0d16a9653ff06b88f7ac"
+      "sha256": "71248889315a29d2a1714ad55ffc685987d862b74e877a29ac2de010bea140f3"
     },
     {
       "path": "modules/economy/migrations/economy_001_fix_gds_shipper_description.sql",
@@ -2857,7 +2857,7 @@
     {
       "path": "modules/economy/reward.js",
       "mode": "0000644",
-      "sha256": "2a354daf06e344a613c8ad7df12ed6e534a9920f49b9f62b54e29b64ead59546"
+      "sha256": "59952daf3cb8cadc33f5249fb07552949d390ba37c71299117a2d503f83e422a"
     },
     {
       "path": "modules/economy/routes/cost.js",
@@ -3532,7 +3532,7 @@
     {
       "path": "modules/lifecycle/db.js",
       "mode": "0000644",
-      "sha256": "5e7dc6c267384eb3b691f49ec82631425151b97d2208eaf342922bf46146965f"
+      "sha256": "3b7e1979609fa7ba55253e193596d8d0db169925574934083232057dcd1b3e6a"
     },
     {
       "path": "modules/lifecycle/done-when.js",
@@ -4242,12 +4242,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "f9e97249b5dcb223b1c8910bfe85a239d9948cbf721ec303989a553d601b48dd"
+      "sha256": "eb81d3478ad0a0cf69bc7595c726032d4e815e3a63c4c3c4a62ff56c5a8e5e0f"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "395d13208f43926545b37afc8dab7d3a833809a036fba5a268247c198a8dfc66"
+      "sha256": "c1255deacb68b9b3ea77218a7d5a9072b8203d1b0c4549d25f62eda4a12626a6"
     },
     {
       "path": "public-docs/index.html",
@@ -5852,7 +5852,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "20924c6aa2d3ab24769ca059983064cab32c103fc979a6749a80021fcf7321d7"
+      "sha256": "4d1b546ca70ac1b708cab0aec7a1933bf2e877e3d4ce6f170fdb9c5702df5ce9"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6999,6 +6999,11 @@
       "mode": "0000644",
       "sha256": "cd782459f1e4e6ca6df8a0349521aedcc6a867128240a78d2f00e15f0fd5f259"
     },
+    {
+      "path": "tests/idea_task_ship_credit.mjs",
+      "mode": "0000644",
+      "sha256": "e7f0807491c094fddedd518380af73a98c7ac17ac9d42736d9ed9a7cd6d4bf51"
+    },
     {
       "path": "tests/idea_templates.mjs",
       "mode": "0000644",

package/modules/economy/credits.js

@@ -117,6 +117,8 @@ const IDEA_BONUS_FRACTION = 0.25; // 25% slice to the idea's original capturer
 // (per-task-ship IC4, governance-pass IC5) will be siblings of this function.
 const IDEA_FULL_PASS_CREDIT = 5;   // owner: "gives 5 credits"
 const IDEA_FULL_PASS_BAR = 60;     // completeness 0-100; ADR 0172 proposed default
+const IDEA_TASK_SHIP_BASE = 5;     // stream 1: base credit per shipped task under an idea
+const QUICK_IDEA_FACTOR = 0.6;     // a quick/spark idea's grade factor (ADR 0172 default)
 
 // =========================================================================
 // Session token reward (flat cost-plus) — task 1005 (ADR 0054).
@@ -385,6 +387,74 @@ async function awardIdeaFullPassCredit(client, { ideaId, authorId, completenessS
     : { credited: 0, reason: 'already_paid' };
 }
 
+// Stream 1 (ADR 0172 / goal 1000067 IC4): as each task descended from an idea
+// SHIPS, pay the idea's author IDEA_TASK_SHIP_BASE credits, SCALED by the idea's
+// grade — a Full Idea by its completeness, a Quick/Spark idea by a flat factor.
+// The ideator lane, so it gates on config.ideatorCredit, never perTaskCredit.
+//
+// THIS REPLACES the ADR 0023 25% idea-promotion slice (maybeAwardIdeaPromotionBonus).
+// The lifecycle ship hook (awardLandingCredit) now calls THIS instead of the
+// slice, so there is one idea-credit-on-ship path, not two (ADR 0172 §4). The
+// old function stays for its unit tests + any compat caller, but is no longer
+// wired at ship.
+//
+// LINEAGE READ, NOT A CODE IMPORT. It reads the ideas-owned lineage + grade
+// tables directly (ideas_task_lineage → idea_inbox → ideas_grades), exactly as
+// maybeAwardIdeaPromotionBonus reads idea_inbox — a cross-table SQL read is
+// allowed across the module boundary; a cross-module require is not.
+//
+//   client   — pg client / pool (transaction participant)
+//   taskId   — the task that just shipped
+//   config   — resolved reward policy; gates on config.ideatorCredit
+//
+// Returns { credited, reason, ideaId, authorId } — credited 0 with a reason for
+// every no-pay path (no source idea, lane off, already paid). Idempotent per
+// (idea, task) via reason='idea.credit.task_ship:<idea>:<task>', builder-scoped
+// so the NOT EXISTS hits idx_credit_log_builder (the IC2 index lesson).
+async function awardIdeaTaskShipCredit(client, { taskId, config = rewardConfig() } = {}) {
+  if (config && config.ideatorCredit === false) {
+    return { credited: 0, reason: 'ideator_lane_off' };
+  }
+  // Which idea does this task descend from, who authored it, and at what grade?
+  const { rows } = await client.query(
+    `SELECT l.idea_id,
+            i.captured_by,
+            COALESCE(g.grade, 'quick')        AS grade,
+            g.completeness_score              AS completeness
+       FROM ideas_task_lineage l
+       JOIN idea_inbox i        ON i.id = l.idea_id
+       LEFT JOIN ideas_grades g ON g.idea_id = l.idea_id
+      WHERE l.task_id = $1`,
+    [taskId]
+  );
+  if (rows.length === 0 || rows[0].captured_by == null) {
+    return { credited: 0, reason: 'no_source_idea', ideaId: null, authorId: null };
+  }
+  const { idea_id: ideaId, captured_by: authorId, grade, completeness } = rows[0];
+  // Grade factor: a Full Idea earns in proportion to its completeness; a Quick
+  // or Spark idea (no completeness score) earns the flat quick factor. A full
+  // idea with no score yet also falls back to the quick factor rather than 0 —
+  // the work shipped, the idea is at least quick-grade.
+  const factor = (grade === 'full' && completeness != null && Number.isFinite(Number(completeness)))
+    ? Math.max(0, Math.min(1, Number(completeness) / 100))
+    : QUICK_IDEA_FACTOR;
+  const delta = Math.round(IDEA_TASK_SHIP_BASE * factor);
+  if (delta <= 0) {
+    return { credited: 0, reason: 'zero_after_scaling', ideaId: Number(ideaId), authorId: Number(authorId) };
+  }
+  const reason = `idea.credit.task_ship:${ideaId}:${taskId}`;
+  const description = `Task #${taskId} shipped under idea #${ideaId} (${grade}${completeness != null ? ` ${Math.round(Number(completeness))}%` : ''}) → ${delta}c to its author (ideator lane stream 1, ADR 0172)`;
+  const { rowCount } = await client.query(
+    `INSERT INTO credit_log (builder_id, task_id, delta, reason, description)
+     SELECT $1, $2, $3, $4, $5
+      WHERE NOT EXISTS (SELECT 1 FROM credit_log WHERE builder_id = $1 AND reason = $4)`,
+    [authorId, taskId, delta, reason, description]
+  );
+  return rowCount > 0
+    ? { credited: delta, reason: 'paid', ideaId: Number(ideaId), authorId: Number(authorId) }
+    : { credited: 0, reason: 'already_paid', ideaId: Number(ideaId), authorId: Number(authorId) };
+}
+
 // Award the flat cost-plus session token reward, idempotent per session_id
 // (task 1005, ADR 0054). Called inside the same transaction as the session
 // upsert (see upsertSessionRecordWithReward).
@@ -596,8 +666,11 @@ module.exports = {
   insertMultipliedConfirmCredit,
   maybeAwardIdeaPromotionBonus,
   awardIdeaFullPassCredit,
+  awardIdeaTaskShipCredit,
   IDEA_FULL_PASS_CREDIT,
   IDEA_FULL_PASS_BAR,
+  IDEA_TASK_SHIP_BASE,
+  QUICK_IDEA_FACTOR,
   awardSessionTokenReward,
   NET_NEGATIVE_BONUS,
   SUBTRACTOR_THRESHOLD,

package/modules/economy/reward.js

@@ -26,6 +26,8 @@ module.exports = {
   maybeAwardIdeaPromotionBonus: (...a) => credits.maybeAwardIdeaPromotionBonus(...a),
   // ADR 0172 IC2 — the ideator credit lane (stream 2): a passing Full Idea pays its author, once.
   awardIdeaFullPassCredit: (...a) => credits.awardIdeaFullPassCredit(...a),
+  // ADR 0172 IC4 — stream 1: pay the idea's author per shipped task, grade-scaled (replaces the 25% slice at ship).
+  awardIdeaTaskShipCredit: (...a) => credits.awardIdeaTaskShipCredit(...a),
   awardNetNegativeBonus: (...a) => credits.awardNetNegativeBonus(...a),
   awardSessionTokenReward: (...a) => credits.awardSessionTokenReward(...a),
   // gamification hooks the lifecycle fires at claim/ship

package/modules/lifecycle/db.js

@@ -3597,9 +3597,19 @@ async function awardLandingCredit(client, { taskId, creditedBuilderId, creditsRe
   const credit = await reward.insertMultipliedConfirmCredit(
     client, creditedBuilderId, taskId, creditsReward, kind, 'task.shipped'
   );
-  const ideaBonus = await reward.maybeAwardIdeaPromotionBonus(
-    client, taskId, creditedBuilderId, credit.creditsAwarded
-  );
+  // Stream 1 of the ideator credit lane (ADR 0172 / IC4) REPLACES the ADR 0023
+  // 25% idea-promotion slice here — one idea-credit-on-ship path, not two
+  // (ADR 0172 §4). Unlike the slice (25% of the builder estimate, so zero under
+  // cost-plus-only), this pays 5×grade-factor on the IDEATOR lane, so an idea
+  // earns as its work ships even when per-task builder credit is withheld. It
+  // reads the one-idea-many-tasks lineage (ideas_task_lineage, IC3), so a Full
+  // Idea that became a whole goal pays on every one of its shipped tasks — the
+  // old slice only saw the single promoted_to_task_id. `maybeAwardIdeaPromotionBonus`
+  // stays on the port for its unit tests / any compat caller, but is no longer
+  // wired at ship. Guarded so a null return (lane off, no source idea) is fine.
+  const ideaBonus = reward.awardIdeaTaskShipCredit
+    ? await reward.awardIdeaTaskShipCredit(client, { taskId })
+    : null;
   return {
     creditsAwarded: credit.creditsAwarded,
     creditsRaw: credit.raw,

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.180",
+  "version": "1.19.181",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.180",
+      "version": "1.19.181",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.180",
+  "version": "1.19.181",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -787,8 +787,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.178 with no explicit bump. run 31972209764. (task 1002620)
 //   1.19.180 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.179 with no explicit bump. run 31972568511. (task 1002620)
+//   1.19.181 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.180 with no explicit bump. run 31972686846. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.180'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.181'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/idea_task_ship_credit.mjs

@@ -0,0 +1,117 @@
+// tests/idea_task_ship_credit.mjs
+//
+// task 1002998 (BV1.R174 / IC4, goal 1000067) — stream 1 of the ideator credit
+// lane: as each task descended from an idea SHIPS, pay the idea's author
+// 5 × grade-factor, once. ADR 0172. Replaces the ADR 0023 25% slice at ship.
+//
+// The done-when as assertions: a shipped task under a Full Idea pays
+// 5 × completeness%; under a Quick idea pays 5 × the flat factor; a Full Idea
+// that became a GOAL pays on EVERY one of its shipped tasks (the one-idea-many-
+// tasks point); re-running never double-pays per (idea, task); cost-plus-only
+// does NOT suppress it; a task with no source idea pays nothing.
+//
+// awardIdeaTaskShipCredit is exercised over a stub client whose credit_log is a
+// set of reasons and whose lineage/idea/grade SELECT returns a scripted row —
+// so the grade-factor math and the per-(idea,task) idempotency are proven
+// without a DB.
+//
+// Run:  node tests/idea_task_ship_credit.mjs
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const credits = require('../modules/economy/credits.js');
+
+let passed = 0;
+let failed = 0;
+async function test(name, fn) {
+  try { await fn(); passed++; console.log(`  ok  ${name}`); }
+  catch (err) { failed++; console.error(`  FAIL ${name}\n    ${err.message}`); }
+}
+
+// `source` is the {idea_id, captured_by, grade, completeness} the lineage SELECT
+// returns for a task (null → no source idea). `credited` is the in-memory ledger.
+function stubClient(source) {
+  const credited = [];
+  return {
+    credited,
+    async query(sql, params) {
+      if (/FROM ideas_task_lineage/i.test(sql)) {
+        return { rows: source ? [source] : [] };
+      }
+      if (/INSERT INTO credit_log/i.test(sql)) {
+        assert.match(sql, /builder_id = \$1 AND reason = \$4/, 'idempotency must be builder-scoped for the index');
+        const reason = params[3];
+        if (credited.some((r) => r.reason === reason)) return { rowCount: 0, rows: [] };
+        credited.push({ builder_id: params[0], task_id: params[1], delta: params[2], reason });
+        return { rowCount: 1, rows: [] };
+      }
+      return { rows: [] };
+    },
+  };
+}
+
+const ON = { ideatorCredit: true };
+
+await test('a shipped task under a FULL idea pays 5 × completeness%', async () => {
+  const c = stubClient({ idea_id: 7, captured_by: 3, grade: 'full', completeness: 80 });
+  const r = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  assert.equal(r.credited, 4, '5 × 0.80 = 4');
+  assert.equal(r.reason, 'paid');
+  assert.equal(c.credited[0].builder_id, 3);
+  assert.equal(c.credited[0].reason, 'idea.credit.task_ship:7:100');
+});
+
+await test('a shipped task under a QUICK idea pays 5 × the flat factor', async () => {
+  const c = stubClient({ idea_id: 7, captured_by: 3, grade: 'quick', completeness: null });
+  const r = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  assert.equal(r.credited, Math.round(credits.IDEA_TASK_SHIP_BASE * credits.QUICK_IDEA_FACTOR)); // 5 × 0.6 = 3
+});
+
+await test('a full idea with 100% pays the full base; a spark falls back to the quick factor', async () => {
+  const full = stubClient({ idea_id: 7, captured_by: 3, grade: 'full', completeness: 100 });
+  assert.equal((await credits.awardIdeaTaskShipCredit(full, { taskId: 100, config: ON })).credited, 5);
+  const spark = stubClient({ idea_id: 7, captured_by: 3, grade: 'spark', completeness: null });
+  assert.equal((await credits.awardIdeaTaskShipCredit(spark, { taskId: 100, config: ON })).credited, 3);
+});
+
+await test('one idea → many tasks: EACH shipped task pays (the whole point of stream 1)', async () => {
+  // same idea 7, three different tasks — three separate credits
+  for (const taskId of [100, 101, 102]) {
+    const c = stubClient({ idea_id: 7, captured_by: 3, grade: 'full', completeness: 80 });
+    const r = await credits.awardIdeaTaskShipCredit(c, { taskId, config: ON });
+    assert.equal(r.credited, 4, `task ${taskId} pays`);
+    assert.equal(c.credited[0].reason, `idea.credit.task_ship:7:${taskId}`, 'distinct per task');
+  }
+});
+
+await test('re-running the same (idea, task) never double-pays', async () => {
+  const c = stubClient({ idea_id: 7, captured_by: 3, grade: 'full', completeness: 80 });
+  const first = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  const second = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  assert.equal(first.credited, 4);
+  assert.equal(second.credited, 0);
+  assert.equal(second.reason, 'already_paid');
+  assert.equal(c.credited.length, 1);
+});
+
+await test('COST-PLUS-ONLY does NOT suppress stream 1 — the ideator lane pays', async () => {
+  const policy = credits.rewardPolicy({ mode: 'cost-plus-only' });
+  assert.equal(policy.perTaskCredit, false);
+  const c = stubClient({ idea_id: 7, captured_by: 3, grade: 'full', completeness: 80 });
+  const r = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: policy });
+  assert.equal(r.credited, 4, 'paid despite cost-plus-only');
+});
+
+await test('the lane opted out, or a task with no source idea, pays nothing', async () => {
+  const off = stubClient({ idea_id: 7, captured_by: 3, grade: 'full', completeness: 80 });
+  assert.equal((await credits.awardIdeaTaskShipCredit(off, { taskId: 100, config: { ideatorCredit: false } })).reason, 'ideator_lane_off');
+  const orphan = stubClient(null);
+  const r = await credits.awardIdeaTaskShipCredit(orphan, { taskId: 100, config: ON });
+  assert.equal(r.credited, 0);
+  assert.equal(r.reason, 'no_source_idea');
+});
+
+console.log(`\nidea_task_ship_credit: ${passed} passed, ${failed} failed`);
+if (failed > 0) process.exit(1);