@bongos/core 1.19.175 → 1.19.176

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.175",
-  "core_contract": "1.19.175",
-  "source_commit": "93e75e5bd9554037be1ec34ec0a428d9eec8db0c",
+  "core_version": "1.19.176",
+  "core_contract": "1.19.176",
+  "source_commit": "9b6c711a358a67610bdb81e8776bc689a0b9cdd8",
   "source_ref": "HEAD",
-  "built_at": "2026-08-16T20:19:55.300Z",
+  "built_at": "2026-08-16T20:39:00.850Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
-    "docs_redacted": 305,
+    "docs_redacted": 306,
     "agent_docs_stubbed": 21,
     "functional_verbatim": 1273,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1599,
-  "tree_sha256": "e99154c282f827663b8bf2628c82b2ea12e0285235bc7d46844f88d25a8f2fd7",
+  "file_count": 1600,
+  "tree_sha256": "fe346cc282c27c1ec0f17e6dc13d3a82795f14343fa9e42f120b3df9a3138546",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -1339,6 +1339,11 @@
       "mode": "0000644",
       "sha256": "0bfe5ce46139bf9ee236868317cc80ee10eb8747d5606d0dd0fe9f2580ea5177"
     },
+    {
+      "path": "docs/adr/0172-per-craft-compensation-ideator-credit-lane.md",
+      "mode": "0000644",
+      "sha256": "d06219f51351c1dd73f7ba556c855e678a2e55e79dacd06419c212a6a24fcc64"
+    },
     {
       "path": "docs/adr/README.md",
       "mode": "0000644",
@@ -2827,7 +2832,7 @@
     {
       "path": "modules/economy/credits.js",
       "mode": "0000644",
-      "sha256": "fd80563444ebb62c5d8a5e7d766a557f85bb90bb2d67f368f41e589f6b0d0ec3"
+      "sha256": "38526b1d7a095fc48d062ddd645df074f381d2ef0e0aac6593ff306601659904"
     },
     {
       "path": "modules/economy/migrations/economy_001_fix_gds_shipper_description.sql",
@@ -4222,12 +4227,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "76f039bc2d79508787cf452ae0d84cafde39f3b43e492af622baf67f64b881a6"
+      "sha256": "07c720a5ef0a0e1e93727688e9c6c87e00ab43f289efa7cbb8eebea6f3cdbba9"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "9628ea87ea7a532bfb4776e9587bb916e4b9249b91cf72da1d28d0b7d3589ad2"
+      "sha256": "d014a9180d2a66087029d00f9f10da48fbc8ee3be7a88db11280bc35da7fd611"
     },
     {
       "path": "public-docs/index.html",
@@ -5832,7 +5837,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "1a5f88144d3ee5bcd4729388f02e9d5bc62541740df4ef256914c9aa8434d1e6"
+      "sha256": "9459525829ea38080db6cc5e757ef7be130c3da00c6563324e892bf605313d8d"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6372,7 +6377,7 @@
     {
       "path": "tests/credit_grant.mjs",
       "mode": "0000644",
-      "sha256": "b483d3a13198f2acd5d721ff5164a6e315ea7294d4f1cfd7c4c2d9279f914f5e"
+      "sha256": "2b871880fc9e6d636c5fb93d2641abad964f4d3e0ed1e78939b12dc849a7631d"
     },
     {
       "path": "tests/criterion_authoring_gate.mjs",

package/docs/adr/0172-per-craft-compensation-ideator-credit-lane.md

@@ -0,0 +1,146 @@
+# 0172 — Per-craft compensation: the ideator credit lane, separate from cost-plus
+
+- **Status:** Accepted
+- **Date:** 2026-08-16
+- **Deciders:** Lars (owner / Archon), Claude (Opus 5)
+- **Track:** `internal` (Cloud Bongos — economy)
+- **Task:** BV1.R171 ([#1002995](https://cloudbongos.com/builders#/task/1002995)) — the foundation of the **Ideator compensation** goal ([#1000067](https://cloudbongos.com/builders#/goal/1000067)).
+- **Builds on:** [ADR 0054](<redacted>.md) (cost-plus session reward), [ADR 0146](<redacted><redacted>.md) (`rewardPolicy` + the `cost-plus-only` mode), [ADR 0023](<redacted>.md) (kind multipliers + the 25% idea-promotion slice), [ADR 0120](<redacted>.md) (pay-on-land).
+- **Relates to:** goal 1000062 (three grades of idea — R141/R142/R143 shipped), idea 1000738 (the Board Room).
+- **Gates:** IC2 ([#1002996](https://cloudbongos.com/builders#/task/1002996)) · IC3 ([#1002997](https://cloudbongos.com/builders#/task/1002997)) · IC4 ([#1002998](https://cloudbongos.com/builders#/task/1002998)) · IC5 ([#1002999](https://cloudbongos.com/builders#/task/1002999)) · IC6 ([#1003000](https://cloudbongos.com/builders#/task/1003000)).
+
+---
+
+## Context
+
+Cloud Bongos pays **one kind of worker one way**. The equity stream is the
+cost-plus session reward ([ADR 0054](<redacted>.md)):
+`round(true_cost_usd × (1 + margin))`, booked when a shipped session lands. On
+top of that, [ADR 0023](<redacted>.md) pays the
+capturer of a promoted idea a **25% slice** of the resulting task's estimate
+when it ships, and [ADR 0146](<redacted><redacted>.md)
+lets an instance switch to `cost-plus-only`, which **withholds every per-task
+estimate payout — the idea slice included** (it is a fraction of a payout that
+is now zero, so it "cascades to 0", `credits.js:235`). cloudbongos.com runs
+`cost-plus-only`.
+
+Two things are now true at once, and they conflict:
+
+1. The **ABI model** (goal 1000062, the owner's Holy Workshop Trinity brief)
+   makes the **ideator** a first-class craft whose *output is a Full Idea* — a
+   deliverable, scored on completeness (R142, shipped). The owner wants that
+   craft **paid in credits**, on three streams (below).
+2. On the live instance those credits **cannot be paid**, because they ride the
+   very per-task estimate path `cost-plus-only` exists to withhold.
+
+The owner resolved it with a principle, 2026-08-16:
+
+> *"this should [be] separate from cost plus, an idea-tor should get paid
+> differently than an artist and builder."*
+
+Compensation is **per-craft**. A builder earning cost-plus for shipping and an
+ideator earning credits for thinking are **not the same reward being tuned two
+ways** — they are two different lanes. The `cost-plus-only` switch governs the
+*builder estimate* lane; it must not reach across and silence the *ideator*
+lane, because that lane is a different craft's pay.
+
+## Decision
+
+### 1. Compensation is per-craft; the ideator credit lane is its own reward, exempt from the `cost-plus-only` gate
+
+The reward model gains a **named lane per craft**, not a single tunable payout:
+
+- **Builder (engineer)** — the cost-plus session reward ([ADR 0054](<redacted>.md)) plus, where `mode !== 'cost-plus-only'`, the per-task estimate ([ADR 0146](<redacted><redacted>.md)). Unchanged.
+- **Ideator** — the **idea credit lane** defined here (three streams, §3). Governed by its **own** policy flag, **never** by `perTaskCredit`.
+- **Artist** — a lane of its own, **deliberately left unspecified here** (the artist craft — grading, copy, voice — is scoped in later ABI work). This ADR reserves the *shape* (a named lane) so the artist lane slots in the same way; it does not define the artist's pay.
+
+The rule that makes this real and testable: **no ideator-lane credit is ever
+gated on `perTaskCredit`.** `cost-plus-only` withholds the builder estimate and
+nothing else.
+
+### 2. `rewardPolicy` grows an ideator dimension; the gate is separate from `perTaskCredit`
+
+`rewardPolicy(rawReward)` (`modules/economy/credits.js`) today returns
+`{ marginPct, usdPeg, mode, perTaskCredit }`, where
+`perTaskCredit = mode !== 'cost-plus-only'`. It gains an **independent** flag:
+
+```
+ideatorCredit: <resolved from reward config; default TRUE>
+```
+
+`ideatorCredit` is **not derived from `mode`.** An instance in `cost-plus-only`
+still has `ideatorCredit: true` unless it explicitly opts the ideator lane out.
+The ideator-credit writers (IC2/IC4/IC5) gate on `config.ideatorCredit`, never
+on `config.perTaskCredit` — the same shape as the existing per-task gate at
+`credits.js:238`, pointed at a different flag. An instance that wants *no*
+ideator pay sets it false; the default pays.
+
+### 3. The three ideator streams (the credit model)
+
+All three book to `credit_log` under **ideator-lane reasons** (namespace
+`idea.credit.*`), distinct from `task.shipped`, `task.confirmed`,
+`idea_promotion_bonus`, and the session cost-plus. Idempotency keys are named
+per stream so a re-grade / re-ship / re-vote never double-pays.
+
+- **Stream 2 — a passing Full Idea pays 5 credits, once** (IC2, buildable now).
+  When a Full Idea (R143) clears the completeness bar, book **5** to its author,
+  once, `reason='idea.credit.full_pass'`, idempotent on `(idea_id, reason)`. The
+  bar is a completeness threshold set in the reward config (default proposed:
+  **60/100** — the R142 score at which four of five base fields are
+  substantively answered). Buildable today: R142 + R143 shipped.
+
+- **Stream 1 — 5 credits per shipped task under the idea, scaled by idea grade**
+  (IC4). As each task descended from an idea (the IC3 lineage) first reaches
+  `shipped`, book `round(5 × gradeFactor)` to the idea's author, once per
+  `(idea_id, task_id)`, `reason='idea.credit.task_ship'`.
+  `gradeFactor = completeness%/100` for a Full Idea; for a **Quick Idea** (no
+  completeness score) a flat `QUICK_IDEA_FACTOR` (default proposed **0.6**).
+  **This REPLACES the ADR 0023 25% slice** (§4).
+
+- **Stream 3 — a board-room-passed idea pays up to 100 × completeness%** (IC5,
+  future). When a Full Idea passes the project's governance vote (the Board
+  Room, idea 1000738 — *not yet built*), book
+  `max(floor, round(completeness% × 100))` to its author, once per idea,
+  `reason='idea.credit.governance_pass'`. Owner floor ~**30**. Consumes the
+  Board Room's pass event; invents no parallel vote.
+
+### 4. The ADR 0023 idea-promotion slice is retired in favour of stream 1
+
+The 25% slice (`IDEA_BONUS_FRACTION = 0.25`, `reason='idea_promotion_bonus'`)
+and stream 1 are **two rules for the same thing** — "an idea earns when its work
+ships." Running both would pay an idea twice on every ship. Stream 1 (IC4) is
+the go-forward rule; when IC4 lands it **removes** the 0.25 slice write, so
+there is one idea-credit-on-ship path, not two. Until IC4 lands, the 0023 slice
+stays (harmlessly zero on `cost-plus-only` today). The switch-over is a single
+change inside IC4, guarded so no window pays both.
+
+### 5. Two structural facts the streams depend on (recorded, not built here)
+
+- **Stream 1 needs one idea → many tasks.** `idea_inbox.promoted_to_task_id` is
+  a single FK. IC3 adds the many-tasks lineage — **preferred shape: an
+  ideas-owned `idea_tasks` join keyed by task id**, so it needs no `ALTER` on
+  the protected `tasks` table and the work stays inside the `ideas` module wall.
+  Set at promotion and at develop (R146).
+- **Stream 3 needs the Board Room.** IC5 waits on idea 1000738.
+
+## Consequences
+
+- **cloudbongos.com can pay ideators on `cost-plus-only`.** The whole reason
+  this goal exists. Builders keep earning cost-plus and nothing else; ideators
+  earn the idea lane; the two no longer collide. IC6 proves both hold at once.
+- **`rewardPolicy` stays a pure function** — one added field, resolved from
+  reward config, unit-testable without the `branding()` cache (the ADR 0146
+  pattern). No new table: the thresholds/factors (pass bar, quick factor,
+  governance floor) are **policy constants in `credits.js`** for the same
+  reasons ADR 0023 kept the kind multipliers in code — they deserve a review +
+  ADR + commit trail, not a hot-path UPDATE. A future migration can promote them
+  to a table if per-instance tuning is wanted.
+- **Artist pay is deliberately unresolved.** This ADR commits to the *shape*
+  (per-craft lanes) so the artist lane lands the same way; it does not price the
+  artist craft. That is later ABI work, and pretending to settle it here would
+  be a decision made without the design.
+- **The numbers are proposed defaults, not owner-locked.** The pass bar (60),
+  quick factor (0.6), and governance floor (30) are this ADR's starting values;
+  each is a one-constant change and each downstream task (IC2/IC4/IC5) surfaces
+  its own for confirmation. The owner set the *structure* (5 / grade-scaled /
+  up-to-100-by-fullness); these fill the gaps the structure left open.

package/modules/economy/credits.js

@@ -159,13 +159,23 @@ const REWARD_MODE_COST_PLUS_ONLY = 'cost-plus-only';
 // policy. Exported so a test can assert the mapping without touching the memoized
 // branding() cache (mirrors computeSessionTokenReward's pure/impure split). The
 // derived `perTaskCredit` boolean is what the per-task credit writer gates on.
+//
+// PER-CRAFT COMPENSATION (ADR 0172): `ideatorCredit` is a SEPARATE lane from the
+// builder per-task estimate. It is NOT derived from `mode` — an instance in
+// `cost-plus-only` still pays ideators (ideatorCredit stays true) because that
+// switch governs the builder estimate, not a different craft's pay. The ideator
+// credit writers (IC2/IC4/IC5) gate on `ideatorCredit`, never on `perTaskCredit`.
+// An instance opts the ideator lane out with `reward.ideatorCredit: false`;
+// absent/any-non-false → the default TRUE (a pre-ADR-0172 config keeps paying).
 function rewardPolicy(rawReward) {
   const r = rawReward || {};
   const marginPct = Number.isFinite(Number(r.marginPct)) ? Number(r.marginPct) : REWARD_MARGIN_PCT;
   const usdPeg = Number.isFinite(Number(r.usdPeg)) && Number(r.usdPeg) > 0 ? Number(r.usdPeg) : 1;
   const mode = r.mode === REWARD_MODE_COST_PLUS_ONLY ? REWARD_MODE_COST_PLUS_ONLY : REWARD_MODE_DEFAULT;
   const perTaskCredit = mode !== REWARD_MODE_COST_PLUS_ONLY;
-  return { marginPct, usdPeg, mode, perTaskCredit };
+  // Default-on, opt-out-only: only an explicit `false` withholds the ideator lane.
+  const ideatorCredit = r.ideatorCredit !== false;
+  return { marginPct, usdPeg, mode, perTaskCredit, ideatorCredit };
 }
 
 // Per-instance reward policy, resolved over the code defaults. Best-effort: a

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.175",
+  "version": "1.19.176",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.175",
+      "version": "1.19.176",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.175",
+  "version": "1.19.176",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -777,8 +777,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.173 with no explicit bump. run 31969032984. (task 1002620)
 //   1.19.175 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.174 with no explicit bump. run 31970199477. (task 1002620)
+//   1.19.176 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.175 with no explicit bump. run 31971125373. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.175'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.176'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/credit_grant.mjs

@@ -516,6 +516,36 @@ await test('rewardPolicy: unknown/garbage mode → default (a typo never silentl
   assert.equal(rewardPolicy(undefined).perTaskCredit, true);
 });
 
+// ── ADR 0172: the ideator credit lane is SEPARATE from the builder estimate ──
+
+await test('rewardPolicy: ideatorCredit defaults ON, and a pre-0172 config keeps paying ideators', () => {
+  assert.equal(rewardPolicy({}).ideatorCredit, true, 'absent flag → the default TRUE');
+  assert.equal(rewardPolicy(null).ideatorCredit, true);
+  // a config written before this ADR (no ideatorCredit key) must not silently
+  // withhold the new lane
+  assert.equal(rewardPolicy({ mode: 'cost-plus-and-estimate', marginPct: 20 }).ideatorCredit, true);
+});
+
+await test('rewardPolicy: cost-plus-only WITHHOLDS the builder estimate but NOT the ideator lane', () => {
+  const p = rewardPolicy({ mode: 'cost-plus-only' });
+  assert.equal(p.perTaskCredit, false, 'the builder per-task estimate is off');
+  assert.equal(p.ideatorCredit, true, 'the ideator lane is a different craft\'s pay — unaffected');
+  // this is the whole point of ADR 0172: the two flags are independent
+  assert.notEqual(p.perTaskCredit, p.ideatorCredit);
+});
+
+await test('rewardPolicy: ideatorCredit is opt-out-only — only an explicit false withholds it', () => {
+  assert.equal(rewardPolicy({ ideatorCredit: false }).ideatorCredit, false, 'explicit opt-out');
+  // and it is orthogonal to mode: an instance can pay per-task estimate but NOT ideators
+  const p = rewardPolicy({ mode: 'cost-plus-and-estimate', ideatorCredit: false });
+  assert.equal(p.perTaskCredit, true);
+  assert.equal(p.ideatorCredit, false);
+  // any non-false value (a typo, a truthy) stays ON — never a silent zeroing
+  for (const v of [true, 1, 'yes', undefined, null]) {
+    assert.equal(rewardPolicy({ ideatorCredit: v }).ideatorCredit, true, `ideatorCredit=${JSON.stringify(v)} pays`);
+  }
+});
+
 await test('rewardPolicy: cost-plus-only still honors a custom margin + peg', () => {
   const p = rewardPolicy({ mode: 'cost-plus-only', marginPct: 35, usdPeg: 2 });
   assert.equal(p.perTaskCredit, false);