@bongos/core 1.19.170 → 1.19.171

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.170",
-  "core_contract": "1.19.170",
-  "source_commit": "2fd8009b960bd910fe95b3169d504adc7fe309d1",
+  "core_version": "1.19.171",
+  "core_contract": "1.19.171",
+  "source_commit": "d102a0205fd62edcc81a804a8c439af4cde60606",
   "source_ref": "HEAD",
-  "built_at": "2026-08-16T18:45:10.150Z",
+  "built_at": "2026-08-16T19:20:36.950Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 305,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1268,
+    "functional_verbatim": 1269,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1594,
-  "tree_sha256": "938326e2e51b3c2bf0a7ab516c8444005ec95028f247df10cc55bedae67b099f",
+  "file_count": 1595,
+  "tree_sha256": "1596294ffbb9fe146a18ced51823d4b074c23b5dd47601619bcd16752c5eaf04",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -3317,12 +3317,12 @@
     {
       "path": "modules/hall-ui/public/profile.html",
       "mode": "0000644",
-      "sha256": "cd3148ae6a22d7e7fff8e0b4a07aed2fe6d27b4e0b6e5b450bd2a63b3f078713"
+      "sha256": "b8d5fb31d92f6d65e8f257d10c77f4ee0aa0ebec50d977d4c7d918ff2253da1e"
     },
     {
       "path": "modules/hall-ui/public/profile.js",
       "mode": "0000644",
-      "sha256": "be57f192368280ac1ae2b0b820f89daf59512f9f89d9ad23414c42cbf09a462e"
+      "sha256": "a4cf0c4c2d088fd1fb84c41c93cc28e2acd2b656b0bc995cd46043881b3611fa"
     },
     {
       "path": "modules/hall-ui/public/ranks.html",
@@ -4212,12 +4212,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "0b596f97bbd28b6ddfda4a9265effcb0ea8711a4bb57948c35b80d7cf79c23d9"
+      "sha256": "90e1fc07f655eb2874620b5a85f965e4f32cc20aeddb552dbc8885c4681150d9"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "ae9625129bd03cb29845f65e1be3abd91c48259d85a9c23095370e43a0a0e8aa"
+      "sha256": "2b1408849261b93418e448820da8081a7ec83fa6b5c2a51b9e1aa5dca7456efb"
     },
     {
       "path": "public-docs/index.html",
@@ -5477,7 +5477,7 @@
     {
       "path": "scripts/hall-preview/server.js",
       "mode": "0000644",
-      "sha256": "b6550cee568d8e8082c30512979256872d71d0d7f1810d061f5dbffad8a76979"
+      "sha256": "1cd66475d610b107b0f3b7f19688133e7c482b41b034e2cef6009d552df31cb2"
     },
     {
       "path": "scripts/migrate.sh",
@@ -5822,7 +5822,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "28605499539ca63e000ac2fc52af1a3d75dbb2fd947846426619a189a2afd92b"
+      "sha256": "17202c8572c75ca1af5cd2eee1c8dd1ba4b6ea4c5fd7cd757eaf97907d26a268"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -7389,6 +7389,11 @@
       "mode": "0000644",
       "sha256": "3b3045a6143d67c963516ed5703b5dabb9b8945a392118721e6a0a56258f1732"
     },
+    {
+      "path": "tests/profile_ui_cross_project.mjs",
+      "mode": "0000644",
+      "sha256": "6a7a223a678b56333befaed017429e5b9d8a81e4405efae72a23355902517d9d"
+    },
     {
       "path": "tests/project_stats.mjs",
       "mode": "0000644",

package/modules/hall-ui/public/profile.html

@@ -40,6 +40,14 @@
           </div>
         </section>
 
+        <!-- Cross-project record — hub-only (ADR 0171). profile.js reveals this
+             only when the profile response carries a cross_project key; on a
+             vanilla instance the key is absent and the section never renders. -->
+        <section class="scroll" id="xp-scroll" aria-labelledby="xp-h" hidden>
+          <h2 id="xp-h" class="scroll__h">Cross-project record</h2>
+          <div id="xp-body"></div>
+        </section>
+
         <!-- Achievements — the builder's earned shelf. -->
         <section class="scroll scroll--bare" id="ach-scroll" aria-labelledby="ach-h">
           <h2 id="ach-h" class="scroll__h">Achievements</h2>
@@ -66,6 +74,10 @@
             </tbody>
           </table>
         </section>
+
+        <!-- Reserved slots — connections, guilds, and actions (profile-page
+             spec sections 6–8) mount here in later phases; keeping the order
+             fixed now means the page is not re-laid-out twice (Decision 5). -->
       </main>
 
       <footer class="app-foot" id="app-foot"></footer>
@@ -83,6 +95,6 @@
 <!-- shared frontend toolkit (window.OTB) — loaded before profile.js, which pulls from it. -->
 <script src="/builders/dom-utils.js?v=2026-06-14-domutils"></script>
 <script src="/builders/brand-apply.js?v=2026-06-27-r75"></script>
-<script src="/builders/profile.js?v=2026-08-04-reward1"></script>
+<script src="/builders/profile.js?v=2026-08-16-r04"></script>
 </body>
 </html>

package/modules/hall-ui/public/profile.js

@@ -160,6 +160,82 @@
     }).join('');
   }
 
+  // ---- render: cross-project record (hub-only, ADR 0171 / task 1002280) ----
+  //
+  // The section reveals only when the response carries a cross_project KEY —
+  // present iff the hub port resolved; on a vanilla instance the key is absent
+  // and the section stays hidden (degrade, don't 500). A null value means "no
+  // public cross-project record" — hidden, provisional, or none, deliberately
+  // indistinguishable — so all three render the same private line and NOTHING
+  // derived from the rollup (no partial numbers; a count plus a hidden total is
+  // a leak by subtraction). The response is viewer-independent (ADR 0171 D4):
+  // self is detected client-side by comparing the /me id, and the self "toggle"
+  // is a link to the real control in Settings (R03). No caching assumptions —
+  // hub profile responses are no-store (ADR 0171 D5).
+
+  function xpProjectRow(p) {
+    const name = escapeHtml(p.name || 'Project');
+    // origin is third-party-reported; link only a well-formed https URL.
+    const origin = typeof p.origin === 'string' && /^https:\/\//.test(p.origin) ? p.origin : null;
+    const nameCell = origin ? `<a href="${escapeHtml(origin)}" rel="noopener">${name}</a>` : name;
+    // rank_held is THAT project's standing as it reported it — plain text, never
+    // the local rank badge or the instance's own rank labels (spec Decision 1).
+    const held = typeof p.rank_held === 'string' && p.rank_held
+      ? escapeHtml(p.rank_held.charAt(0).toUpperCase() + p.rank_held.slice(1))
+      : '—';
+    return `<tr><td>${nameCell}</td><td>${held}</td></tr>`;
+  }
+
+  function renderCrossProject(data, selfId) {
+    const section = $('#xp-scroll');
+    const body = $('#xp-body');
+    if (!section || !body) return;
+    if (!data || !('cross_project' in data)) {
+      section.hidden = true;
+      return;
+    }
+    // ids may serialize as strings (pg bigint) — compare canonicalized.
+    const isSelf = selfId != null && data.builder && String(data.builder.id) === String(selfId);
+    const manage = isSelf
+      ? `<p class="scroll__lede">This is you — <a href="/settings#cross-project">manage its visibility in Settings → Cross-project record</a>.</p>`
+      : '';
+    const cp = data.cross_project;
+    if (!cp) {
+      body.innerHTML = `<p class="scroll__lede">This builder keeps their track record private.</p>${manage}`;
+      section.hidden = false;
+      return;
+    }
+    const t = cp.totals || {};
+    const tiles =
+      `<div class="stat-row">` +
+      tile('Projects', fmtNum(t.projects)) +
+      tile('Works shipped', fmtNum(t.works_shipped)) +
+      tile('Credits', fmtNum(t.credits)) +
+      tile('Karma', fmtNum(t.karma)) +
+      `</div>`;
+    const discs = Array.isArray(cp.disciplines) ? cp.disciplines.filter((d) => typeof d === 'string') : [];
+    const metaBits = [];
+    if (discs.length) metaBits.push(`Disciplines: ${discs.join(', ')}`);
+    if (cp.last_active) metaBits.push(`Last active ${fmtDate(cp.last_active)}`);
+    const meta = metaBits.length ? `<p class="scroll__lede">${escapeHtml(metaBits.join(' · '))}</p>` : '';
+    const named = Array.isArray(cp.projects) ? cp.projects : [];
+    const moreCount = Number(cp.more_projects) || 0;
+    const projectsTable = named.length
+      ? `<table class="ledger">
+           <thead><tr><th>Project</th><th title="That project's own standing, as reported by that project.">Standing there</th></tr></thead>
+           <tbody>${named.map(xpProjectRow).join('')}</tbody>
+         </table>`
+      : '';
+    const more = moreCount > 0
+      ? `<p class="scroll__lede">+ ${fmtNum(moreCount)} more project${moreCount === 1 ? '' : 's'} not publicly listed.</p>`
+      : '';
+    const none = !named.length && !moreCount
+      ? `<p class="scroll__lede">No cross-project activity reported yet.</p>`
+      : '';
+    body.innerHTML = tiles + meta + projectsTable + more + none + manage;
+    section.hidden = false;
+  }
+
   // ---- states -------------------------------------------------------------
 
   function showMessage(text) {
@@ -167,13 +243,14 @@
     if (sub) sub.textContent = text;
   }
 
-  function renderProfile(data) {
+  function renderProfile(data, selfId) {
     const builder = data.builder || {};
     const name = builder.display_name || builder.github_login || 'Builder';
     const shipped = Number(data.shipped_count) || 0;
     showMessage(`${name} — ${rankLabel(normalizeRank(builder.rank))} · ${fmtNum(shipped)} work${shipped === 1 ? '' : 's'} shipped`);
     renderHead(builder);
     renderNumbers(data.shipped_count, data.achievements);
+    renderCrossProject(data, selfId);
     renderAchievements(data.achievements);
     renderWorks(data.recent_ships);
   }
@@ -197,23 +274,39 @@
     const ach = $('#ach-grid'); if (ach) ach.innerHTML = '';
     const works = $('#works-table tbody'); if (works) works.innerHTML = '';
     const worksLede = $('#works-lede'); if (worksLede) worksLede.hidden = true;
+    const xp = $('#xp-scroll'); if (xp) xp.hidden = true;
   }
 
-  async function fetchProfile(id) {
+  async function fetchProfile(id, selfId) {
     const res = await api.request('GET', `${API}/builders/${encodeURIComponent(id)}/profile`);
     if (res.status === 404) {
       showMessage('No builder found with that id.');
       return;
     }
     if (!res.ok) throw new Error(`profile → ${res.status}`);
-    renderProfile(res.data || {});
+    renderProfile(res.data || {}, selfId);
+  }
+
+  // The viewer's own builder id, or null when signed out / unresolvable. Used
+  // ONLY for client-side self-detection (ADR 0171 D4 — the profile response is
+  // viewer-independent); a failure here just means no self link renders.
+  async function resolveSelfId() {
+    try {
+      const me = await api.request('GET', `${API}/me`);
+      if (!me.ok) return null;
+      const builder = (me.data && me.data.builder) ? me.data.builder : me.data;
+      return (builder && builder.id) || null;
+    } catch (err) {
+      console.error('[profile] /me self-detect failed', err);
+      return null;
+    }
   }
 
   async function load() {
     const idParam = new URLSearchParams(location.search).get('id');
     try {
       if (idParam) {
-        await fetchProfile(idParam);
+        await fetchProfile(idParam, await resolveSelfId());
         return;
       }
       // No id — soft-resolve the viewer's OWN id from /me (no hard redirect; a
@@ -230,7 +323,7 @@
         renderEmpty();
         return;
       }
-      await fetchProfile(selfId);
+      await fetchProfile(selfId, selfId);
     } catch (err) {
       console.error('[profile] failed to load', err);
       showMessage('Could not load this profile. Return to the hall and try again.');

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.170",
+  "version": "1.19.171",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.170",
+      "version": "1.19.171",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.170",
+  "version": "1.19.171",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/hall-preview/server.js

@@ -81,6 +81,7 @@ const FIXTURE_FALLBACKS = [
   [/^blockers\/\d+$/, 'blockers__detail'],
   [/^analytics\/builder\/\d+$/, 'analytics__builder'],
   [/^builders\/\d+\/active-claims$/, 'builders__active-claims'],
+  [/^builders\/\d+\/profile$/, 'builders__profile'],
 ];
 
 function loadFixture(name) {

package/src/module-api.js

@@ -767,8 +767,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.168 with no explicit bump. run 31964702865. (task 1002620)
 //   1.19.170 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.169 with no explicit bump. run 31965483417. (task 1002620)
+//   1.19.171 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.170 with no explicit bump. run 31967255167. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.170'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.171'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/profile_ui_cross_project.mjs

@@ -0,0 +1,182 @@
+// tests/profile_ui_cross_project.mjs — the profile page's cross-project section
+// (task 1002280, R04 · goal 1000045, ADR 0171).
+//
+// EXECUTES the real modules/hall-ui/public/profile.js in a minimal DOM stub
+// (the hall_signout.mjs pattern) against canned API responses, and asserts the
+// consent-sensitive render contract:
+//
+//   - no `cross_project` key in the response (vanilla instance) → the section
+//     stays hidden entirely;
+//   - `cross_project: null` (hidden / provisional / none — indistinguishable by
+//     design) → the "keeps their track record private" line renders and NOTHING
+//     derived from the rollup does (no tiles, no digits — a count plus a hidden
+//     total is a leak by subtraction);
+//   - the self hide-toggle is client-side only (ADR 0171 D4): the Settings link
+//     renders iff the /me id matches the profile id, on both the ?id= and the
+//     own-profile load paths;
+//   - the full object renders totals tiles, named project rows (https origins
+//     linked, anything else plain text), `rank_held` as plain text — never the
+//     local rank-badge component (spec Decision 1) — and the counted-never-named
+//     "+N more" line.
+//
+// Pure vm + file-read (no DB/network) — runs in the DB-free unit gate.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/profile.js'), 'utf8');
+const HTML = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/profile.html'), 'utf8');
+
+// ---- fixtures -------------------------------------------------------------
+
+const BUILDER = {
+  id: 7, github_login: 'pheidias', display_name: 'Pheidias', avatar_url: null,
+  rank: 'metic', total_credits: 120, karma: 3, created_at: '2026-01-01T00:00:00.000Z',
+  preferred_disciplines: ['engineer'],
+};
+
+const CP_FULL = {
+  totals: { projects: 3, credits: 150, works_shipped: 7, karma: 4 },
+  disciplines: ['engineer', 'ui'],
+  last_active: '2026-08-01T00:00:00.000Z',
+  projects: [
+    { name: 'Public Proj', origin: 'https://pub.example', rank_held: 'metic' },
+    { name: 'Odd Origin', origin: 'http://insecure.example', rank_held: null },
+  ],
+  more_projects: 1,
+};
+
+const baseProfile = () => ({ builder: { ...BUILDER }, shipped_count: 1, recent_ships: [], achievements: [] });
+
+// ---- harness --------------------------------------------------------------
+
+// Boot profile.js with canned /me + profile responses; returns the memoised
+// element map after the async load() settles.
+async function boot({ search = '', me, profile } = {}) {
+  const els = new Map();
+  const makeEl = () => ({
+    hidden: false, textContent: '', _html: '',
+    set innerHTML(v) { this._html = String(v); }, get innerHTML() { return this._html; },
+  });
+  const $ = (sel) => { if (!els.has(sel)) els.set(sel, makeEl()); return els.get(sel); };
+  // Mirror the markup: the section ships with the `hidden` attribute.
+  $('#xp-scroll').hidden = true;
+
+  const escapeHtml = (s) => String(s)
+    .replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
+  const api = {
+    async request(_method, url) {
+      if (url === '/api/bongos/me') return me ?? { status: 401, ok: false, data: null };
+      if (/\/builders\/[^/]+\/profile$/.test(url)) return profile ?? { status: 404, ok: false, data: null };
+      return { status: 404, ok: false, data: null };
+    },
+  };
+  const windowObj = {
+    __BRANDING__: {},
+    BongosClient: { createClient: () => api },
+    OTB: {
+      $, escapeHtml,
+      fmtNum: (n) => String(Number(n) || 0),
+      fmtDate: (d) => String(d).slice(0, 10),
+      rankLabel: (r) => r,
+      toast() {},
+    },
+  };
+  const sandbox = {
+    window: windowObj, location: { search }, URLSearchParams, console,
+  };
+  sandbox.globalThis = sandbox;
+  vm.createContext(sandbox);
+  vm.runInContext(SRC, sandbox, { filename: 'profile.js' });
+  // load() is fire-and-forget; let its await chain settle.
+  for (let i = 0; i < 4; i++) await new Promise((r) => setImmediate(r));
+  return { els, $ };
+}
+
+const meOk = (id) => ({ status: 200, ok: true, data: { builder: { id } } });
+const profileOk = (data) => ({ status: 200, ok: true, data });
+
+// ---- the markup ships the section hidden ----------------------------------
+
+test('profile.html carries the hidden cross-project section + reserved slots', () => {
+  assert.match(HTML, /<section[^>]*id="xp-scroll"[^>]*hidden>/, 'the section must ship hidden — it reveals only when the response carries a cross_project key');
+  assert.match(HTML, /Reserved slots[\s\S]*connections, guilds, and actions/, 'the spec Decision 5 slot reservation must stay in the layout');
+});
+
+// ---- vanilla instance: key absent → section absent -------------------------
+
+test('no cross_project key (vanilla instance) → the section stays hidden', async () => {
+  const { $ } = await boot({ search: '?id=7', me: meOk(99), profile: profileOk(baseProfile()) });
+  assert.equal($('#xp-scroll').hidden, true);
+  assert.equal($('#xp-body').innerHTML, '');
+});
+
+// ---- cross_project: null → private line, nothing derived -------------------
+
+test('cross_project null, stranger view → private line only, no numbers, no self link', async () => {
+  const data = { ...baseProfile(), cross_project: null };
+  const { $ } = await boot({ search: '?id=7', me: meOk(99), profile: profileOk(data) });
+  const xp = $('#xp-scroll');
+  const html = $('#xp-body').innerHTML;
+  assert.equal(xp.hidden, false, 'on the hub the section reveals even when the record is private');
+  assert.match(html, /keeps their track record private/);
+  assert.ok(!html.includes('stat-tile'), 'no tiles in the private state');
+  assert.ok(!/\d/.test(html), 'no digits at all — no partial numbers (leak by subtraction)');
+  assert.ok(!html.includes('/settings#cross-project'), 'no self link for a stranger');
+});
+
+test('cross_project null, self view via ?id= → private line + the Settings link', async () => {
+  const data = { ...baseProfile(), cross_project: null };
+  // /me id as a STRING (pg bigint serialization) against the numeric profile id
+  // — self-detection must be serialization-proof.
+  const { $ } = await boot({ search: '?id=7', me: meOk('7'), profile: profileOk(data) });
+  const html = $('#xp-body').innerHTML;
+  assert.match(html, /keeps their track record private/);
+  assert.ok(html.includes('/settings#cross-project'), 'the self hide-toggle links to Settings → Cross-project record');
+});
+
+test('self view with no ?id= (own-profile path) also gets the Settings link', async () => {
+  const data = { ...baseProfile(), cross_project: null };
+  const { $ } = await boot({ search: '', me: meOk(7), profile: profileOk(data) });
+  assert.ok($('#xp-body').innerHTML.includes('/settings#cross-project'));
+});
+
+// ---- the full record -------------------------------------------------------
+
+test('full cross_project → tiles, named rows, plain-text standing, +N more', async () => {
+  const data = { ...baseProfile(), cross_project: CP_FULL };
+  const { $ } = await boot({ search: '?id=7', me: meOk(99), profile: profileOk(data) });
+  const xp = $('#xp-scroll');
+  const html = $('#xp-body').innerHTML;
+  assert.equal(xp.hidden, false);
+  assert.equal((html.match(/stat-tile__num/g) || []).length, 4, 'projects / works shipped / credits / karma tiles');
+  assert.match(html, /Public Proj/);
+  assert.ok(html.includes('href="https://pub.example"'), 'a well-formed https origin links out');
+  assert.match(html, /Odd Origin/);
+  assert.ok(!html.includes('href="http://insecure.example"'), 'a non-https origin renders as plain text');
+  assert.match(html, /Metic/, 'rank_held renders capitalized as that project\'s own standing');
+  assert.ok(!html.includes('rank-badge'), 'never the local rank-badge component for another project\'s rank (spec Decision 1)');
+  assert.match(html, /\+ 1 more project/, 'non-public projects are counted, never named');
+  assert.match(html, /Disciplines: engineer, ui/);
+  assert.match(html, /Last active 2026-08-01/);
+  assert.ok(!html.includes('/settings#cross-project'), 'no self link for a stranger');
+});
+
+test('zero-activity record → the empty line, no project table', async () => {
+  const cp = { ...CP_FULL, projects: [], more_projects: 0 };
+  const { $ } = await boot({ search: '?id=7', me: meOk(99), profile: profileOk({ ...baseProfile(), cross_project: cp }) });
+  const html = $('#xp-body').innerHTML;
+  assert.match(html, /No cross-project activity reported yet\./);
+  assert.ok(!html.includes('<table'), 'no empty ledger');
+});
+
+// ---- signed-out empty state ------------------------------------------------
+
+test('signed-out visitor with no ?id= → empty state keeps the section hidden', async () => {
+  const { $ } = await boot({ search: '', me: { status: 401, ok: false, data: null } });
+  assert.equal($('#xp-scroll').hidden, true);
+});