@bongos/core 1.19.131 → 1.19.132

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.131",
-  "core_contract": "1.19.131",
-  "source_commit": "7fc91a6722c91cd40c09ce632c2a765377952e49",
+  "core_version": "1.19.132",
+  "core_contract": "1.19.132",
+  "source_commit": "450f890ee24a473026548ea2cf82cf69ac1d6d9c",
   "source_ref": "HEAD",
-  "built_at": "2026-08-15T03:23:58.787Z",
+  "built_at": "2026-08-15T03:38:15.933Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 303,
     "agent_docs_stubbed": 21,
-    "functional_verbatim": 1247,
+    "functional_verbatim": 1248,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 1571,
-  "tree_sha256": "81215c25cbaed99553dba15247df2e2f9daf37245d8144df0a5e32b507b4c0b9",
+  "file_count": 1572,
+  "tree_sha256": "d0e21da3aa85bb9e774ef6c921a2cc4be514b8dab592b7a1b3fa8bb07e8be485",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -4172,12 +4172,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "ad651e607ce3937ca8522552d21ecfbaa03108734f9c7987c79a2e8ef8a7c7f3"
+      "sha256": "26a0143ba944f1edf0c163992ecd6f447fa911d16d7b8161578c7b1bc6725a48"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "178ddf3d5958c428d370e3381cdca505455abe6006b9f920245de0062bc2d5aa"
+      "sha256": "763b31a597012a53b4f7b6c0c0ce9a30e10ba13206468820d16dcc5d04d972ec"
     },
     {
       "path": "public-docs/index.html",
@@ -4767,7 +4767,7 @@
     {
       "path": "scripts/gds/docs-entropy.js",
       "mode": "0000644",
-      "sha256": "afeea5e6c75a8cb7ac9bb8ee3eefc828102866dc3ae6836b0dc28946c56cb330"
+      "sha256": "1a7cbe47158e4de63c1b788d6bb4f682584723a45c1824ab2ae3fbf92a54fbce"
     },
     {
       "path": "scripts/gds/doctor.js",
@@ -5762,7 +5762,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "fd76c822f4e795248c2c010052dab9cce8cc237a5f501fbf90e66c413c58eac6"
+      "sha256": "9754ad61248f7a9ccf1b4361bf7de1895318872a4994f74f53668151c60f8aeb"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -6242,7 +6242,7 @@
     {
       "path": "tests/cloud_bongos_pack.mjs",
       "mode": "0000644",
-      "sha256": "715fecde91ee9dff56dfca9b9da46a47b49322b0dd50aad1bd606491f551fe06"
+      "sha256": "087d0379a559ebb858e8e42458754cfb93720a5222e5f85fb81995851ce811be"
     },
     {
       "path": "tests/conductor.mjs",
@@ -6484,6 +6484,11 @@
       "mode": "0000644",
       "sha256": "d9fd04cc3f2fcb3b4a9945c1e743c44445a216a10648fa619f74716b381468f3"
     },
+    {
+      "path": "tests/docs_entropy.mjs",
+      "mode": "0000644",
+      "sha256": "4d64164d45d6b81d706074b8394da4f3d0f7f8c5263a37a287a163d6a746a96b"
+    },
     {
       "path": "tests/docs_openapi_route.mjs",
       "mode": "0000644",

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.131",
+  "version": "1.19.132",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.131",
+      "version": "1.19.132",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.131",
+  "version": "1.19.132",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/docs-entropy.js

@@ -16,37 +16,50 @@
 //
 // Exit codes:
 //   0  scan complete
-//   1  fatal error
+//   1  fatal error (including a scan defect: zero markdown files enumerated)
 
 'use strict';
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { execSync } = require('node:child_process');
-const { hasFlag, cliClient, requireSession } = require('./cli-lib');
+const { execFileSync } = require('node:child_process');
+const { hasFlag, cliClient, requireSession, cliExit } = require('./cli-lib');
 
 const REPO_ROOT = path.resolve(__dirname, '..', '..');
 const MIN_DUPE_CHARS = 120;    // minimum paragraph length to flag as duplicate
 const MAX_DUPES_REPORTED = 20; // cap to avoid flooding the report
 
-// Shell helper — returns stdout or null on failure.
-function sh(cmd) {
+// ---------- file collection ----------
+
+// argv array, never a shell string: `git ls-files '*.md'` as a string runs
+// through cmd.exe on Windows, where the quotes are literal, so git matched
+// nothing and the whole scan reported on zero files (task 1002526).
+function gitLsFiles(args) {
   try {
-    return execSync(cmd, {
+    return execFileSync('git', args, {
       cwd: REPO_ROOT,
       encoding: 'utf8',
-      stdio: ['ignore', 'pipe', 'ignore'],
-    }).trim();
-  } catch (_) {
-    return null;
+      stdio: ['ignore', 'pipe', 'pipe'],
+    });
+  } catch (err) {
+    const detail = String(err.stderr || err.message || '').trim();
+    throw new Error(`docs-entropy: \`git ${args.join(' ')}\` failed in ${REPO_ROOT}: ${detail}`);
   }
 }
 
-// ---------- file collection ----------
-
-function collectMarkdownFiles() {
-  const out = sh("git ls-files '*.md'");
-  return out ? out.split('\n').map(f => f.trim()).filter(Boolean) : [];
+// Throws rather than returning [] — an empty enumeration in a repo that tracks
+// hundreds of .md files is a broken scan, and a lint that silently reports on
+// nothing is worse than one that fails.
+function collectMarkdownFiles({ run = gitLsFiles } = {}) {
+  const out = run(['ls-files', '*.md']);
+  const files = String(out || '').split('\n').map(f => f.trim()).filter(Boolean);
+  if (!files.length) {
+    throw new Error(
+      `docs-entropy: scan defect — enumerated 0 tracked markdown files under ${REPO_ROOT}. ` +
+      'This repo tracks hundreds, so this is a broken scan (bad git invocation or wrong cwd), not a clean result.'
+    );
+  }
+  return files;
 }
 
 // ---------- parsing ----------
@@ -326,10 +339,12 @@ async function docsEntropyMain() {
   const fileIdeas = hasFlag('--file-ideas', args);
   const verbose   = hasFlag('--verbose', args);
 
-  const relFiles = collectMarkdownFiles();
-  if (!relFiles.length) {
-    console.error('docs-entropy: no tracked markdown files found');
-    process.exit(1);
+  let relFiles;
+  try {
+    relFiles = collectMarkdownFiles();
+  } catch (err) {
+    console.error(err.message);
+    return cliExit(1);
   }
 
   const linkFindings  = scanStaleLinks(relFiles);
@@ -350,9 +365,12 @@ async function docsEntropyMain() {
   };
 
   if (asJson) {
+    // cliExit, not process.exit: the JSON here can run well past the 64KB pipe
+    // buffer, and process.exit() drops unflushed stdout — CI saw the payload
+    // truncated mid-string (PR 148's flaky unit run). Natural exit flushes.
     console.log(JSON.stringify(result, null, 2));
     if (fileIdeas) await fileToInbox(staleLinks, brokenAnchors, dupes);
-    process.exit(0);
+    return cliExit(0);
   }
 
   console.log('Docs entropy scan');
@@ -390,13 +408,13 @@ async function docsEntropyMain() {
     await fileToInbox(staleLinks, brokenAnchors, dupes);
   }
 
-  process.exit(0);
+  cliExit(0);
 }
 
 if (require.main === module) {
   docsEntropyMain().catch((err) => {
     console.error('fatal:', err);
-    process.exit(1);
+    cliExit(1);
   });
 }
 

package/src/module-api.js

@@ -689,8 +689,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.129 with no explicit bump. run 31861289412. (task 1002620)
 //   1.19.131 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.130 with no explicit bump. run 31861682626. (task 1002620)
+//   1.19.132 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.131 with no explicit bump. run 31862317758. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.131'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.132'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/cloud_bongos_pack.mjs

@@ -71,14 +71,16 @@ test('R74: themeMarkup paints the backdrop only when the pack supplies one', ()
   assert.match(themeMarkup(clientBranding(vanilla()).theme), /body\{background:.+\}/);
 });
 
-test('customer-0: GDS_BRANDING_FILE selects the cloudbongos.com instance pack (task 1374)', () => {
+test('customer-0: GDS_BRANDING_FILE selects the cloudbongos.com instance pack (task 1374)', (t) => {
   // The live dogfood instance runs from the SAME checkout as OTB; the env knob
   // points this process at its own pack (deltas over neutral) instead of OTB's
   // config/branding.json. Proves the brand-switch + the cloudbongos pack content.
   // Both packs are INSTANCE content — the neutral core ships neither, so this
   // asserts one deployment's config (task 1002470). The selector MECHANISM is
   // proven unconditionally by the fixture test below.
-  if (!existsSync(join(ROOT, 'config/branding.cloudbongos.json'))) return;
+  // Report the absence as a SKIP, not a silent pass — a case that asserts nothing
+  // must not read as green coverage (task 1002526).
+  if (!existsSync(join(ROOT, 'config/branding.cloudbongos.json'))) return t.skip('no config/branding.cloudbongos.json on this checkout');
   const b = loadBranding({ env: { GDS_BRANDING_FILE: 'config/branding.cloudbongos.json' } });
   assert.equal(b.identity.productName, 'Cloud Bongos'); // from neutral
   assert.equal(b.currency.label, 'credits');            // from neutral, not "drachmae"
@@ -91,11 +93,11 @@ test('customer-0: GDS_BRANDING_FILE selects the cloudbongos.com instance pack (t
   assert.equal(b.firstAdmin, 'lars589');
 });
 
-test('customer-0: no GDS_BRANDING_FILE still resolves the instance pack (default unchanged)', () => {
+test('customer-0: no GDS_BRANDING_FILE still resolves the instance pack (default unchanged)', (t) => {
   // The OTB process (server.js) sets no GDS_BRANDING_FILE → config/branding.json.
   // Same instance-content caveat as above: with no instance pack the correct default
   // IS the neutral starter, which is what the vanilla tests in this file already pin.
-  if (!existsSync(INSTANCE_PATH)) return;
+  if (!existsSync(INSTANCE_PATH)) return t.skip('no config/branding.json (instance pack) on this checkout');
   const b = loadBranding({ env: {} });
   assert.notDeepEqual(b.identity, vanilla().identity, 'the instance pack must win over neutral by default');
 });

package/tests/docs_entropy.mjs

@@ -0,0 +1,55 @@
+// tests/docs_entropy.mjs — the markdown entropy lint actually scans (task 1002526).
+//
+// The bug this pins: collectMarkdownFiles() shelled out to the STRING
+// `git ls-files '*.md'`. On Windows that runs through cmd.exe, where the single
+// quotes are literal, so git matched nothing — docs-entropy reported on zero
+// files on every Windows checkout, a lint that proved nothing. Two guarantees:
+//   1. enumeration goes through an argv ARRAY (no shell quoting to get wrong),
+//   2. zero tracked markdown files is treated as a SCAN DEFECT and errors
+//      loudly — this repo tracks hundreds, so an empty result is never real.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { execFileSync } from 'node:child_process';
+import { createRequire } from 'node:module';
+import { fileURLToPath } from 'node:url';
+import path from 'node:path';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SCANNER = path.join(ROOT, 'scripts', 'gds', 'docs-entropy.js');
+const { collectMarkdownFiles } = require(SCANNER); // require.main-guarded → no scan on import
+
+test('collectMarkdownFiles passes the glob as an argv array, never a shell string', () => {
+  let seen = null;
+  const files = collectMarkdownFiles({ run: (args) => { seen = args; return 'a.md\nb.md\n'; } });
+  assert.ok(Array.isArray(seen), 'git args must be an array — a shell string is what broke Windows');
+  assert.deepEqual(seen, ['ls-files', '*.md'], 'the glob reaches git unquoted');
+  assert.deepEqual(files, ['a.md', 'b.md']);
+});
+
+test('zero tracked markdown files is a loud scan defect, not a clean empty result', () => {
+  assert.throws(
+    () => collectMarkdownFiles({ run: () => '' }),
+    /scan defect/i,
+    'an empty enumeration must name itself a defect so the lint cannot silently prove nothing',
+  );
+});
+
+test('a failing git invocation propagates instead of collapsing to zero files', () => {
+  // The old sh() helper caught every failure and returned null → [] → a scan of
+  // nothing. The enumeration must never swallow its own failure.
+  assert.throws(
+    () => collectMarkdownFiles({ run: () => { throw new Error('not a git repository'); } }),
+    /not a git repository/,
+  );
+});
+
+test('the real scan enumerates the repo (the regression: it reported on 0 files)', () => {
+  const stdout = execFileSync(process.execPath, [SCANNER, '--json'], {
+    cwd: ROOT, encoding: 'utf8', maxBuffer: 64 * 1024 * 1024,
+  });
+  const result = JSON.parse(stdout);
+  assert.ok(result.scanned_files > 50, `expected hundreds of markdown files, scanned ${result.scanned_files}`);
+  assert.ok(Number.isFinite(result.stale_links));
+  assert.ok(Number.isFinite(result.broken_anchors));
+});