@bongos/core 1.19.1073 → 1.19.1075

package/tests/project_modules_ui.mjs

@@ -56,7 +56,7 @@ for (const fn of ['function ensureModsCatalog(', 'function renderMods(', 'functi
 const CATALOG = {
   core: ['memory', 'lifecycle', 'hall-ui'],
   optional: [
-    { key: 'dev-box', label: 'Dev box', summary: 'A shared machine your builders work on.' },
+    { key: 'npm-release', label: 'npm release', summary: 'Publishes each release of your project to npm.' },
     { key: 'discord', label: 'Discord', summary: 'Mirrors what ships into a Discord channel.' },
     { key: 'agents', label: 'Agents', summary: 'Lets AI builders claim and ship work on their own.' },
   ],
@@ -76,7 +76,7 @@ function parseRows(html) {
 
 // Boot the region against a scripted catalog + detail channel and hand back the
 // handles a test drives it with.
-function boot({ selected = ['dev-box'], source = 'chosen', catalog = CATALOG, catalogOk = true, patchAnswer } = {}) {
+function boot({ selected = ['npm-release'], source = 'chosen', catalog = CATALOG, catalogOk = true, patchAnswer } = {}) {
   const requests = [];
   const els = new Map();
   const listeners = new Map();
@@ -156,14 +156,14 @@ function boot({ selected = ['dev-box'], source = 'chosen', catalog = CATALOG, ca
 
 test('the band renders the optional catalog the server offered — a row and a sentence each', async () => {
   // Arrange
-  const ui = boot({ selected: ['dev-box'] });
+  const ui = boot({ selected: ['npm-release'] });
 
   // Act
   await ui.render();
 
   // Assert
-  assert.deepEqual(ui.rows().map((r) => r.key), ['dev-box', 'discord', 'agents']);
-  assert.deepEqual(ui.rows().map((r) => r.label), ['Dev box', 'Discord', 'Agents']);
+  assert.deepEqual(ui.rows().map((r) => r.key), ['npm-release', 'discord', 'agents']);
+  assert.deepEqual(ui.rows().map((r) => r.label), ['npm release', 'Discord', 'Agents']);
   for (const r of ui.rows()) assert.ok(r.summary.length > 20, `${r.label} says what it is for`);
 });
 
@@ -171,11 +171,11 @@ test('what the project runs today is what is switched on — resolved by the ser
   // A project that SKIPPED the picker reads as its own starter bundle, and the
   // band must show that set rather than an empty one: the whole point of
   // effectiveModules resolving `source: 'bundle'` on the way out.
-  const ui = boot({ selected: ['dev-box', 'discord'], source: 'bundle' });
+  const ui = boot({ selected: ['npm-release', 'discord'], source: 'bundle' });
 
   await ui.render();
 
-  assert.deepEqual(ui.rows().filter((r) => r.on).map((r) => r.key), ['dev-box', 'discord']);
+  assert.deepEqual(ui.rows().filter((r) => r.on).map((r) => r.key), ['npm-release', 'discord']);
   assert.deepEqual(ui.rows().filter((r) => !r.on).map((r) => r.key), ['agents']);
 });
 
@@ -185,7 +185,7 @@ test('the always-on core is COUNTED and stated, and is not a row anyone can swit
   await ui.render();
 
   assert.match(ui.slot(), /the same 3 core parts/, 'the clause names how many, from the server\'s own list');
-  assert.deepEqual(ui.rows().map((r) => r.key), ['dev-box', 'discord', 'agents'], 'and no core key is on the band');
+  assert.deepEqual(ui.rows().map((r) => r.key), ['npm-release', 'discord', 'agents'], 'and no core key is on the band');
   for (const key of CATALOG.core) {
     assert.equal(ui.rows().some((r) => r.key === key), false, `${key} is not a choice`);
   }
@@ -196,26 +196,26 @@ test('a toggle issues the write — the WHOLE list, in catalog order, on the own
   const ui = boot({ selected: ['discord'] });
   await ui.render();
 
-  // Act — switch the dev box ON
-  await ui.click('dev-box');
+  // Act — switch npm release ON
+  await ui.click('npm-release');
 
   // Assert
   const patch = ui.requests.find((r) => r.method === 'PATCH');
   assert.ok(patch, 'a PATCH was sent');
   assert.equal(patch.url, '/api/bongos/provisioning/instances/18/detail');
-  assert.deepEqual(JSON.parse(patch.body), { modules: ['dev-box', 'discord'] },
+  assert.deepEqual(JSON.parse(patch.body), { modules: ['npm-release', 'discord'] },
     'catalog order, exactly as the column stores it — never append order');
   assert.equal(patch.credentials, 'same-origin', 'the cookie session is the auth — this page carries no token');
 });
 
 test('a toggle can REMOVE one too — the same list, one key shorter', async () => {
-  const ui = boot({ selected: ['dev-box', 'agents'] });
+  const ui = boot({ selected: ['npm-release', 'agents'] });
   await ui.render();
 
   await ui.click('agents');
 
   const patch = ui.requests.find((r) => r.method === 'PATCH');
-  assert.deepEqual(JSON.parse(patch.body), { modules: ['dev-box'] });
+  assert.deepEqual(JSON.parse(patch.body), { modules: ['npm-release'] });
 });
 
 test('switching the last one off sends an empty list — a real answer, not a skipped write', async () => {
@@ -243,8 +243,8 @@ test('the band repaints from the PLATFORM’S answer, and says the save changed
 
 test('a refusal is SAID in the server’s own words, and the band goes back to what the row still holds', async () => {
   const ui = boot({
-    selected: ['dev-box'],
-    patchAnswer: Promise.resolve({ ok: false, status: 400, _json: { error: { code: 'bad_modules', message: 'Unknown module "discrod" — the choices are: dev-box, discord, agents.' } } }),
+    selected: ['npm-release'],
+    patchAnswer: Promise.resolve({ ok: false, status: 400, _json: { error: { code: 'bad_modules', message: 'Unknown module "discrod" — the choices are: npm-release, discord, agents.' } } }),
   });
   await ui.render();
 
@@ -252,7 +252,7 @@ test('a refusal is SAID in the server’s own words, and the band goes back to w
 
   assert.equal(ui.msg().className, 'projMsg err');
   assert.match(ui.msg().textContent, /Unknown module "discrod"/);
-  assert.deepEqual(ui.rows().filter((r) => r.on).map((r) => r.key), ['dev-box'],
+  assert.deepEqual(ui.rows().filter((r) => r.on).map((r) => r.key), ['npm-release'],
     'a refused write leaves the band showing the project’s real set');
 });
 
@@ -269,7 +269,7 @@ test('a signed-out save offers a way back in rather than a dead end', async () =
 });
 
 test('a catalog that ANSWERED badly says so; nothing about the project is claimed to have changed', async () => {
-  const ui = boot({ selected: ['dev-box'], catalogOk: false });
+  const ui = boot({ selected: ['npm-release'], catalogOk: false });
 
   await ui.render();
   await ui.settle();

package/tests/projects_hub.mjs

@@ -707,14 +707,14 @@ test('the About answers travel on the create request, and an empty one is OMITTE
 
 test('a renumbering of the wizard invalidates old drafts — the key carries the version', () => {
   // task 1002772 renumbered once and bumped to -v2; task 1002334 renumbered again;
-  // task 1002339 (the module picker) is the third. A draft replayed under a
+  // task 1002339 (the module picker) is the third; task 1004351 (the app step) the fourth. A draft replayed under a
   // different numbering lands on the wrong panel with the rail already marking
   // the skipped steps done.
   const key = (SCRIPT.match(/var DRAFT_KEY = '([^']+)'/) || [, ''])[1];
   assert.match(key, /-v\d+$/, 'the draft key is versioned');
   const panels = (SCRIPT.match(/var panels = \{([^}]*)\}/) || [, ''])[1];
   const count = [...panels.matchAll(/\d+:\s*'panel-/g)].length;
-  assert.equal(count, 9, 'gate + seven numbered steps + done — bump DRAFT_KEY when this changes');
+  assert.equal(count, 10, 'gate + eight numbered steps + done — bump DRAFT_KEY when this changes');
 });
 
 test('every row lays the same five parts — the ledger has no ragged row', () => {
@@ -2133,9 +2133,9 @@ test('the wizard takes the world by scope: no card ground, the six-step strip as
   assert.ok(at > -1, 'the #view-new block exists in cosmos.css');
   const block = COSMOS.slice(at);
   assert.match(block, /#view-new \.card\{background:none;border-radius:0;box-shadow:none;/, 'no card ground');
-  // seven tracks since task 1002339 added the Modules step; the count is the
+  // eight tracks since task 1004351 added the App step (seven since 1002339); the count is the
   // rail's own, so it moves with the panels map rather than being a magic number
-  assert.match(block, /#view-new \.steps\{display:grid;grid-template-columns:repeat\(7,1fr\);/, 'the strip lays a track per numbered step');
+  assert.match(block, /#view-new \.steps\{display:grid;grid-template-columns:repeat\(8,1fr\);/, 'the strip lays a track per numbered step');
   assert.match(block, /#view-new \.steps li::before\{content:"";position:absolute;top:-4px;left:0;right:auto;width:7px;height:7px;/, 'the connector becomes the 7px dot');
   assert.match(block, /#view-new \.steps li\.now::before\{background:var\(--accent\);border-color:var\(--accent\);outline:4px solid/, 'the lit step carries the accent and an outline halo');
   assert.match(block, /#view-new \.panel h1\{font-weight:300;[^}]*text-transform:lowercase;/, 'the step title in the display voice, lowercase');
@@ -2182,7 +2182,7 @@ test('the wizard\'s own structures wear the world: hairline fields, cells of one
   assert.match(block, /\.addrBig code\{display:block;font-family:var\(--font-display\);/, 'the address stands in the display voice');
   assert.doesNotMatch(block, /linear-gradient/, 'no tinted plates');
   assert.doesNotMatch(block, /box-shadow:(?!none)/, 'no box shadow in the wizard block');
-  assert.match(HUB, /<div class="nav">\s*<button type="button" class="btn ghost" data-back="6">← Back<\/button>\s*<button type="button" class="btn big" id="doCreate">Create my project<\/button>/, 'the review\'s doors sit on one row, back then the primary');
+  assert.match(HUB, /<div class="nav">\s*<button type="button" class="btn ghost" data-back="7">← Back<\/button>\s*<button type="button" class="btn big" id="doCreate">Create my project<\/button>/, 'the review\'s doors sit on one row, back then the primary');
   assert.match(HUB, /<h2 class="stepsHead" id="doneStepsHead">Your steps — the parts only you can play<\/h2>/, 'the steps heading is the label face by class, not an inline style (the id is where a skipped invite step hands focus on, task 1002346)');
   // what is enqueued is unchanged (ADR 0111): the filing body the control plane reads
   assert.match(SCRIPT, /body: JSON\.stringify\(\{\s*slug: state\.slug,/, 'the filing still carries the slug first');

package/tests/projects_hub_app_step.mjs

@@ -0,0 +1,138 @@
+// tests/projects_hub_app_step.mjs — the create wizard's "where your app runs" step,
+// EXECUTED (task 1004351, ADR 0345).
+//
+// The step is a native radio group, so almost all of its behaviour is one rule: the
+// review may only ever name a place the owner could actually pick. Render is listed
+// but disabled until the connect flow lands (task 1004352), and "decide later" is the
+// owner's ruling for the default. A static regex cannot tell a guard that works from
+// one that is never consulted, so — as tests/projects_hub_module_picker.mjs does for
+// the picker — this slices the block out of projects.html by its own sentinels and
+// runs it in `vm` under a small DOM stub.
+//
+// Run:  node --test --test-reporter=tap tests/projects_hub_app_step.mjs
+
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HUB = fs.readFileSync(path.join(ROOT, 'modules', 'public-landing', 'public', 'projects.html'), 'utf8').replace(/\r\n/g, '\n');
+
+const START = '/* the app step (task 1004351)';
+const END = '    function renderReview() {';
+const from = HUB.indexOf(START);
+const to = HUB.indexOf(END, from);
+assert.ok(from > -1, 'the app-step block opens with its sentinel comment');
+assert.ok(to > from, 'the app-step block ends where renderReview begins');
+const BLOCK = HUB.slice(from, to);
+
+const PANEL = (HUB.match(/<section class="panel" id="panel-app"[\s\S]*?<\/section>/) || [''])[0];
+
+// Two radios, built from the real markup so the harness cannot drift from the page.
+function radiosFromMarkup(renderEnabled) {
+  return [...PANEL.matchAll(/<input type="radio" name="appPlatform" value="([a-z-]+)"([^>]*)>/g)].map((m) => ({
+    name: 'appPlatform',
+    value: m[1],
+    disabled: m[1] === 'render' ? !renderEnabled && /\sdisabled/.test(m[2]) : /\sdisabled/.test(m[2]),
+    checked: /\schecked/.test(m[2]),
+  }));
+}
+
+function load({ draft = {}, renderEnabled = false } = {}) {
+  const inputs = radiosFromMarkup(renderEnabled);
+  let changeHandler = null;
+  const saves = [];
+  const root = {
+    querySelector(sel) {
+      if (sel === '#appOpts') return { addEventListener: (ev, fn) => { if (ev === 'change') changeHandler = fn; } };
+      throw new Error('unexpected selector ' + sel);
+    },
+    querySelectorAll(sel) {
+      assert.equal(sel, '#appOpts input[name=appPlatform]');
+      return inputs;
+    },
+  };
+  const state = Object.assign({ appPlatform: 'later' }, draft);
+  const ctx = { root, state, saveDraft: () => saves.push(state.appPlatform) };
+  vm.createContext(ctx);
+  vm.runInContext(BLOCK + '\nthis.api = { appPlatformChoice, syncAppStep, appRow };', ctx);
+  return { ...ctx.api, inputs, state, saves, change: (value) => changeHandler({ target: inputs.find((i) => i.value === value) }) };
+}
+
+test('the panel is real markup: Render listed but not pickable yet, Decide later the default', () => {
+  assert.ok(PANEL, '#panel-app exists');
+  assert.match(PANEL, /<input type="radio" name="appPlatform" value="render" disabled/, 'Render cannot be picked until task 1004352');
+  assert.match(PANEL, /<span class="soonTag">Coming soon<\/span>/, 'and says so in words, not by colour alone');
+  assert.match(PANEL, /<input type="radio" name="appPlatform" value="later" checked>/, 'Decide later is the default');
+  assert.match(PANEL, /We host your Builders' hall/, 'the step says the hall is ours to host (ADR 0345 D1), in the page\'s one spelling of it');
+  assert.match(PANEL, /<form data-next="8">/, 'Next leads to the review');
+  assert.match(PANEL, /data-back="6"/, 'Back returns to the address step');
+});
+
+test('the step sits between Address and Review in the panels map and on the rail', () => {
+  assert.match(HUB, /6: 'panel-address', 7: 'panel-app', 8: 'panel-review', 9: 'panel-done'/);
+  assert.match(HUB, /<li data-step="7"><span class="snum">7<\/span><span class="slbl">App<\/span><\/li>/);
+  assert.match(HUB, /<li data-step="8"><span class="snum">8<\/span><span class="slbl">Create<\/span><\/li>/);
+  assert.match(HUB, /data-back="7">← Back<\/button>\n\s*<button type="button" class="btn big" id="doCreate">/, "the review's Back returns to the app step");
+  assert.match(HUB, /if \(step === 7\) syncAppStep\(\);\n\s*if \(step === 8\) renderReview\(\);/, 'entering the step repaints it from the draft');
+});
+
+test('a fresh draft reads "decide later"', () => {
+  const w = load();
+  assert.equal(w.appPlatformChoice(), 'later');
+  assert.equal(w.appRow(), 'Not chosen yet — you can decide later');
+});
+
+test('a draft that names Render while Render is not pickable still reads "decide later"', () => {
+  // The rule: the review never names a place the owner could not actually pick.
+  const w = load({ draft: { appPlatform: 'render' } });
+  assert.equal(w.appPlatformChoice(), 'later');
+  assert.equal(w.appRow(), 'Not chosen yet — you can decide later');
+  w.syncAppStep();
+  assert.deepEqual(w.inputs.filter((i) => i.checked).map((i) => i.value), ['later'], 'and the step shows Decide later checked');
+});
+
+test('once Render is pickable, choosing it is what the review names', () => {
+  const w = load({ renderEnabled: true });
+  w.change('render');
+  assert.equal(w.state.appPlatform, 'render');
+  assert.deepEqual(w.saves, ['render'], 'the choice is saved to the draft');
+  assert.equal(w.appRow(), 'Render, on your own account');
+  w.syncAppStep();
+  assert.deepEqual(w.inputs.filter((i) => i.checked).map((i) => i.value), ['render']);
+});
+
+test('a change on a disabled radio is ignored, and an unknown or missing value reads "decide later"', () => {
+  const w = load();
+  w.change('render');
+  assert.equal(w.state.appPlatform, 'later', 'a disabled option never reaches the draft');
+  assert.deepEqual(w.saves, []);
+  for (const v of [undefined, '', 'vercel', 'x"]']) {
+    assert.equal(load({ draft: { appPlatform: v } }).appPlatformChoice(), 'later', `appPlatform=${JSON.stringify(v)}`);
+  }
+});
+
+test('the review carries the hall row and the app row in place of the old Shape row', () => {
+  const render = HUB.slice(HUB.indexOf('function renderReview()'));
+  const rows = render.slice(0, render.indexOf("$('reviewList').innerHTML"));
+  assert.ok(rows.includes("['Builders\\' hall', 'Hosted by us, on the platform’s current release'],"), 'the hall row');
+  assert.match(rows, /\['App', appRow\(\)\]/);
+  assert.doesNotMatch(rows, /\['Shape',/, 'the Shape row is gone');
+});
+
+test('the rail grid has one column per step, so adding a step never wraps the rail', () => {
+  // Adding the app step made the rail eight beats in a seven-column grid: at 1440 the
+  // Create beat wrapped onto a second row. The count lives in the shared sheet, so the
+  // two must be checked against each other, not each on its own.
+  const css = fs.readFileSync(path.join(ROOT, 'modules', 'public-landing', 'public', 'assets', 'cosmos.css'), 'utf8');
+  const cols = Number((css.match(/#view-new \.steps\{display:grid;grid-template-columns:repeat\((\d+),1fr\)/) || [])[1]);
+  const beats = [...HUB.matchAll(/<li[^>]*data-step="\d+"/g)].length;
+  assert.equal(cols, beats, 'the #view-new rail grid carries exactly one column per rail step');
+});
+
+test('the hall is spelled one way on this page', () => {
+  assert.doesNotMatch(HUB, /Builders Hall/, 'no "Builders Hall" beside the page\'s own "Builders\' hall"');
+});