@bongos/core 1.19.1073 → 1.19.1074

package/tests/projects_hub_app_step.mjs

@@ -0,0 +1,138 @@
+// tests/projects_hub_app_step.mjs — the create wizard's "where your app runs" step,
+// EXECUTED (task 1004351, ADR 0345).
+//
+// The step is a native radio group, so almost all of its behaviour is one rule: the
+// review may only ever name a place the owner could actually pick. Render is listed
+// but disabled until the connect flow lands (task 1004352), and "decide later" is the
+// owner's ruling for the default. A static regex cannot tell a guard that works from
+// one that is never consulted, so — as tests/projects_hub_module_picker.mjs does for
+// the picker — this slices the block out of projects.html by its own sentinels and
+// runs it in `vm` under a small DOM stub.
+//
+// Run:  node --test --test-reporter=tap tests/projects_hub_app_step.mjs
+
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HUB = fs.readFileSync(path.join(ROOT, 'modules', 'public-landing', 'public', 'projects.html'), 'utf8').replace(/\r\n/g, '\n');
+
+const START = '/* the app step (task 1004351)';
+const END = '    function renderReview() {';
+const from = HUB.indexOf(START);
+const to = HUB.indexOf(END, from);
+assert.ok(from > -1, 'the app-step block opens with its sentinel comment');
+assert.ok(to > from, 'the app-step block ends where renderReview begins');
+const BLOCK = HUB.slice(from, to);
+
+const PANEL = (HUB.match(/<section class="panel" id="panel-app"[\s\S]*?<\/section>/) || [''])[0];
+
+// Two radios, built from the real markup so the harness cannot drift from the page.
+function radiosFromMarkup(renderEnabled) {
+  return [...PANEL.matchAll(/<input type="radio" name="appPlatform" value="([a-z-]+)"([^>]*)>/g)].map((m) => ({
+    name: 'appPlatform',
+    value: m[1],
+    disabled: m[1] === 'render' ? !renderEnabled && /\sdisabled/.test(m[2]) : /\sdisabled/.test(m[2]),
+    checked: /\schecked/.test(m[2]),
+  }));
+}
+
+function load({ draft = {}, renderEnabled = false } = {}) {
+  const inputs = radiosFromMarkup(renderEnabled);
+  let changeHandler = null;
+  const saves = [];
+  const root = {
+    querySelector(sel) {
+      if (sel === '#appOpts') return { addEventListener: (ev, fn) => { if (ev === 'change') changeHandler = fn; } };
+      throw new Error('unexpected selector ' + sel);
+    },
+    querySelectorAll(sel) {
+      assert.equal(sel, '#appOpts input[name=appPlatform]');
+      return inputs;
+    },
+  };
+  const state = Object.assign({ appPlatform: 'later' }, draft);
+  const ctx = { root, state, saveDraft: () => saves.push(state.appPlatform) };
+  vm.createContext(ctx);
+  vm.runInContext(BLOCK + '\nthis.api = { appPlatformChoice, syncAppStep, appRow };', ctx);
+  return { ...ctx.api, inputs, state, saves, change: (value) => changeHandler({ target: inputs.find((i) => i.value === value) }) };
+}
+
+test('the panel is real markup: Render listed but not pickable yet, Decide later the default', () => {
+  assert.ok(PANEL, '#panel-app exists');
+  assert.match(PANEL, /<input type="radio" name="appPlatform" value="render" disabled/, 'Render cannot be picked until task 1004352');
+  assert.match(PANEL, /<span class="soonTag">Coming soon<\/span>/, 'and says so in words, not by colour alone');
+  assert.match(PANEL, /<input type="radio" name="appPlatform" value="later" checked>/, 'Decide later is the default');
+  assert.match(PANEL, /We host your Builders' hall/, 'the step says the hall is ours to host (ADR 0345 D1), in the page\'s one spelling of it');
+  assert.match(PANEL, /<form data-next="8">/, 'Next leads to the review');
+  assert.match(PANEL, /data-back="6"/, 'Back returns to the address step');
+});
+
+test('the step sits between Address and Review in the panels map and on the rail', () => {
+  assert.match(HUB, /6: 'panel-address', 7: 'panel-app', 8: 'panel-review', 9: 'panel-done'/);
+  assert.match(HUB, /<li data-step="7"><span class="snum">7<\/span><span class="slbl">App<\/span><\/li>/);
+  assert.match(HUB, /<li data-step="8"><span class="snum">8<\/span><span class="slbl">Create<\/span><\/li>/);
+  assert.match(HUB, /data-back="7">← Back<\/button>\n\s*<button type="button" class="btn big" id="doCreate">/, "the review's Back returns to the app step");
+  assert.match(HUB, /if \(step === 7\) syncAppStep\(\);\n\s*if \(step === 8\) renderReview\(\);/, 'entering the step repaints it from the draft');
+});
+
+test('a fresh draft reads "decide later"', () => {
+  const w = load();
+  assert.equal(w.appPlatformChoice(), 'later');
+  assert.equal(w.appRow(), 'Not chosen yet — you can decide later');
+});
+
+test('a draft that names Render while Render is not pickable still reads "decide later"', () => {
+  // The rule: the review never names a place the owner could not actually pick.
+  const w = load({ draft: { appPlatform: 'render' } });
+  assert.equal(w.appPlatformChoice(), 'later');
+  assert.equal(w.appRow(), 'Not chosen yet — you can decide later');
+  w.syncAppStep();
+  assert.deepEqual(w.inputs.filter((i) => i.checked).map((i) => i.value), ['later'], 'and the step shows Decide later checked');
+});
+
+test('once Render is pickable, choosing it is what the review names', () => {
+  const w = load({ renderEnabled: true });
+  w.change('render');
+  assert.equal(w.state.appPlatform, 'render');
+  assert.deepEqual(w.saves, ['render'], 'the choice is saved to the draft');
+  assert.equal(w.appRow(), 'Render, on your own account');
+  w.syncAppStep();
+  assert.deepEqual(w.inputs.filter((i) => i.checked).map((i) => i.value), ['render']);
+});
+
+test('a change on a disabled radio is ignored, and an unknown or missing value reads "decide later"', () => {
+  const w = load();
+  w.change('render');
+  assert.equal(w.state.appPlatform, 'later', 'a disabled option never reaches the draft');
+  assert.deepEqual(w.saves, []);
+  for (const v of [undefined, '', 'vercel', 'x"]']) {
+    assert.equal(load({ draft: { appPlatform: v } }).appPlatformChoice(), 'later', `appPlatform=${JSON.stringify(v)}`);
+  }
+});
+
+test('the review carries the hall row and the app row in place of the old Shape row', () => {
+  const render = HUB.slice(HUB.indexOf('function renderReview()'));
+  const rows = render.slice(0, render.indexOf("$('reviewList').innerHTML"));
+  assert.ok(rows.includes("['Builders\\' hall', 'Hosted by us, on the platform’s current release'],"), 'the hall row');
+  assert.match(rows, /\['App', appRow\(\)\]/);
+  assert.doesNotMatch(rows, /\['Shape',/, 'the Shape row is gone');
+});
+
+test('the rail grid has one column per step, so adding a step never wraps the rail', () => {
+  // Adding the app step made the rail eight beats in a seven-column grid: at 1440 the
+  // Create beat wrapped onto a second row. The count lives in the shared sheet, so the
+  // two must be checked against each other, not each on its own.
+  const css = fs.readFileSync(path.join(ROOT, 'modules', 'public-landing', 'public', 'assets', 'cosmos.css'), 'utf8');
+  const cols = Number((css.match(/#view-new \.steps\{display:grid;grid-template-columns:repeat\((\d+),1fr\)/) || [])[1]);
+  const beats = [...HUB.matchAll(/<li[^>]*data-step="\d+"/g)].length;
+  assert.equal(cols, beats, 'the #view-new rail grid carries exactly one column per rail step');
+});
+
+test('the hall is spelled one way on this page', () => {
+  assert.doesNotMatch(HUB, /Builders Hall/, 'no "Builders Hall" beside the page\'s own "Builders\' hall"');
+});

package/tests/projects_hub_module_picker.mjs

@@ -414,7 +414,7 @@ test('the review names the set even when the picker was never opened (task 10023
   // and the module NAMES are not known. "None — just the core" would be a false
   // promise on the last screen before Create: the server is about to apply the
   // type's bundle. The row says that instead, then repaints when the read lands.
-  const h = boot({ state: { projType: 'game', step: 7 } });
+  const h = boot({ state: { projType: 'game', step: 8 } });   // 8 = the review since task 1004351
 
   // Arrange + Act — the review asks for the value before the read can answer
   const first = h.extrasRow();
@@ -820,7 +820,7 @@ test('with nothing switched on the count says only what is shown', async () => {
 });
 
 test('the review names the hidden picks too — a filter never reaches the create request', async () => {
-  const h = boot({ state: { projType: 'game', step: 7 } });
+  const h = boot({ state: { projType: 'game', step: 8 } });   // 8 = the review since task 1004351
   await h.open();
   h.click('agents');
   assert.deepEqual(h.forCreate(), ['agents', 'dev-box', 'discord']);

package/tests/projects_hub_pre_uat.mjs

@@ -241,11 +241,10 @@ test('no wall-clock promises, no operator vocabulary on the stranger’s path',
   assert.doesNotMatch(HUB, /about five minutes/, 'the empty state');
   assert.doesNotMatch(HUB, /a runner does the real work/, 'the mine fine print');
   assert.doesNotMatch(SCRIPT, /pinned platform core/, 'the review Shape row');
-  /* The wizard creates hosting_shape 'cloud-host', whose owner-facing name became
-     "cloud host" at ADR 0323 — "its own server" was ambiguous between that shape and
-     a dedicated one, and said nothing about WHO runs it. The assertion still guards the
-     same property this test is about: owner vocabulary, and no wall-clock promise. */
-  assert.match(SCRIPT, /\['Shape', 'Cloud host — we stand it up and run it for you, on the platform’s current release'\]/);
+  /* Since ADR 0345 (task 1004351) the review names the HALL as hosted by us and gives the
+     APP its own row. The assertion still guards the same property this test is about:
+     owner vocabulary, and no wall-clock promise. */
+  assert.ok(SCRIPT.includes("['Builders\\' hall', 'Hosted by us, on the platform’s current release'],"), 'the review names the hall as hosted by us');
   assert.doesNotMatch(HUB, /\/new-project<\/code> assistant/, 'the done panel’s closing line');
   assert.match(HUB, /Sign-in switches on after the GitHub steps|switch sign-in on/, 'the address step does not promise sign-in "just works"');
   assert.doesNotMatch(HUB, /Sign-in, sharing, everything just works/);

package/tests/provision.mjs

@@ -130,25 +130,25 @@ t('planCorePinRefresh: a trailing file: pin → refresh; a current one → no-op
   // The W3 shape: repo pins 1.19.2, control plane runs 1.19.196 → refresh (heals
   // the silent-rollback hazard before the next repo-driven deploy).
   assert.deepEqual(
-    P.planCorePinRefresh({ pinnedDep: 'file:vendor/bongos-core-1.19.2.tgz', coreVersion: '1.19.196' }),
+    P.planCorePinRefresh({ pinnedDep: 'file:vendor/bongos-core-1.19.2.tgz', version: '1.0.0', coreVersion: '1.19.196' }),
     { action: 'refresh', pinned: '1.19.2' });
   // Pin already matches the running core → nothing to commit.
   assert.deepEqual(
-    P.planCorePinRefresh({ pinnedDep: 'file:vendor/bongos-core-1.19.196.tgz', coreVersion: '1.19.196' }),
+    P.planCorePinRefresh({ pinnedDep: 'file:vendor/bongos-core-1.19.196.tgz', version: '1.0.0', coreVersion: '1.19.196' }),
     { action: 'current', pinned: '1.19.196' });
   // A non-canonical file: pin can't be compared → refresh heals it to canonical.
   assert.equal(
-    P.planCorePinRefresh({ pinnedDep: 'file:vendor/core.tgz', coreVersion: '1.19.196' }).action,
+    P.planCorePinRefresh({ pinnedDep: 'file:vendor/core.tgz', version: '1.0.0', coreVersion: '1.19.196' }).action,
     'refresh');
 });
 
 t('planCorePinRefresh: registry pins and absent deps are skipped, never rewritten', () => {
   // Registry pin (ADR 0134): npm resolves it within its range — not ours to vendor.
-  assert.equal(P.planCorePinRefresh({ pinnedDep: '^1.19.100', coreVersion: '1.19.196' }).action, 'skip');
-  assert.equal(P.planCorePinRefresh({ pinnedDep: '1.19.196', coreVersion: '1.19.196' }).action, 'skip');
+  assert.equal(P.planCorePinRefresh({ pinnedDep: '^1.19.100', version: '1.0.0', coreVersion: '1.19.196' }).action, 'skip');
+  assert.equal(P.planCorePinRefresh({ pinnedDep: '1.19.196', version: '1.0.0', coreVersion: '1.19.196' }).action, 'skip');
   // No @bongos/core dependency at all → not ours to invent.
-  assert.equal(P.planCorePinRefresh({ pinnedDep: undefined, coreVersion: '1.19.196' }).action, 'skip');
-  assert.equal(P.planCorePinRefresh({ pinnedDep: '', coreVersion: '1.19.196' }).action, 'skip');
+  assert.equal(P.planCorePinRefresh({ pinnedDep: undefined, version: '1.0.0', coreVersion: '1.19.196' }).action, 'skip');
+  assert.equal(P.planCorePinRefresh({ pinnedDep: '', version: '1.0.0', coreVersion: '1.19.196' }).action, 'skip');
 });
 
 t('safeVersionLabel: passes clean semver, rejects any shell metacharacter', () => {

package/tests/provisioning_starter_bundles.mjs

@@ -37,7 +37,6 @@ import {
   OPTIONAL_MODULES,
   STARTER_BUNDLES,
   HUB_ONLY_MODULES,
-  RETIRED_MODULES,
   RULED_TEAM_SHAPES,
   bundleForProjectType,
   allStarterBundles,
@@ -336,9 +335,6 @@ test('the opt-in catalog declared for the picker IS the on-disk opt-in set', ()
   const onDisk = manifestsOnDisk();
   const optInOnDisk = [...onDisk.values()]
     .filter((m) => m.default !== true && !HUB_ONLY_MODULES.includes(m.key))
-    // A RETIRED module is still on disk while its removal lands, and must already
-    // be gone from the catalog — so it is the one permitted absence (task 1003886).
-    .filter((m) => !RETIRED_MODULES.includes(m.key))
     .map((m) => m.key)
     .sort();
 
@@ -350,24 +346,6 @@ test('the opt-in catalog declared for the picker IS the on-disk opt-in set', ()
     'the picker\'s catalog has drifted from the manifests — a module was added, removed, or flipped its default');
 });
 
-test('a RETIRED module is withdrawn everywhere an owner could still reach it', () => {
-  // The retirement is only real if it holds at every offer point at once. A key
-  // left in any one of them is still a module a new project can end up with,
-  // which is exactly what the withdrawal exists to stop (task 1003886).
-  for (const key of RETIRED_MODULES) {
-    assert.ok(!OPTIONAL_MODULES.some((m) => m.key === key),
-      `retired module "${key}" is still a row the creation picker offers`);
-    for (const [type, bundle] of Object.entries(STARTER_BUNDLES)) {
-      assert.ok(!bundle.modules.includes(key),
-        `retired module "${key}" is still preselected by the "${type}" bundle`);
-    }
-    // Posting it directly is a real answer that resolves to nothing, not a
-    // non-answer: the key is DROPPED, exactly as an unknown one would be.
-    assert.deepEqual(normalizeModuleSelection([key]), [],
-      `retired module "${key}" is still accepted when an owner posts it directly`);
-  }
-});
-
 test('every opt-in module carries owner-facing copy, and no module jargon rides along', () => {
   for (const row of OPTIONAL_MODULES) {
     assert.ok(row.label && row.label.length <= 40, `"${row.key}" needs a short label`);

package/tests/publish_branch_route.mjs

@@ -9,12 +9,10 @@
 //   1. src/bongos/github-push.js — the push/PR/status logic, exercised through the
 //      injectable exec + fetch seams (deps.exec / deps.fetchImpl / deps.token /
 //      deps.repoInfo / deps.mkdtemp / deps.rmtmp).
-//   2. The route wiring — a STRUCTURAL guard that POST/GET publish* are
-//      requireBuilder and DO NOT carry auth.allowBoxScope. That absence is what
-//      makes a box-scoped session 403 (#919/ADR 0053). box_scope_session.mjs
-//      proves requireBuilder's box gate; this proves the publish routes never opt
-//      out of it — a future edit that added allowBoxScope would reintroduce the
-//      "a leaked box token can ship arbitrary code" hole, and this test fails first.
+//   2. The route wiring — a STRUCTURAL guard that POST/GET publish* and the
+//      attest route are requireBuilder-gated, so an unauthenticated caller (or a
+//      session of an undeclared source — tests/government_session_scope.mjs) can
+//      never publish.
 //
 // Run:  node tests/publish_branch_route.mjs
 
@@ -407,8 +405,7 @@ await t('getPublishStatus: merged, workflow EXISTS but no successful run yet →
 });
 
 // ===========================================================================
-// Layer 2 — STRUCTURAL guard: the publish routes are requireBuilder and carry
-// NO allowBoxScope (so a box-scoped session is denied — #919 regression guard).
+// Layer 2 — STRUCTURAL guard: the publish routes are requireBuilder-gated.
 // ===========================================================================
 function findRouteLayer(router, routePath, method) {
   return router.stack.find(
@@ -419,36 +416,31 @@ function handlesOf(layer) {
   return layer.route.stack.map((s) => s.handle);
 }
 
-await t('POST /tasks/:id/publish-branch: requireBuilder present, allowBoxScope ABSENT', async () => {
+await t('POST /tasks/:id/publish-branch: requireBuilder present', async () => {
   const router = buildTasksRouter();
   const layer = findRouteLayer(router, '/tasks/:id/publish-branch', 'post');
   assert.ok(layer, 'the publish-branch POST route must be registered');
   const handles = handlesOf(layer);
   assert.ok(handles.includes(auth.requireBuilder), 'must be requireBuilder-gated');
-  assert.ok(!handles.includes(auth.allowBoxScope), 'must NOT carry allowBoxScope — a box session must be denied (#919)');
 });
 
-await t('GET /tasks/:id/publish-status: requireBuilder present, allowBoxScope ABSENT', async () => {
+await t('GET /tasks/:id/publish-status: requireBuilder present', async () => {
   const router = buildTasksRouter();
   const layer = findRouteLayer(router, '/tasks/:id/publish-status', 'get');
   assert.ok(layer, 'the publish-status GET route must be registered');
   const handles = handlesOf(layer);
   assert.ok(handles.includes(auth.requireBuilder), 'must be requireBuilder-gated');
-  assert.ok(!handles.includes(auth.allowBoxScope), 'must NOT carry allowBoxScope');
 });
 
 // task 1169 (ADR 0058): the laptop ci-land attest endpoint. It posts the trustless
-// gate-author-trust commit status for a Metic+ author, so the SAME #919 box-scope
-// guard the publish routes carry applies here — a box session must reauth, never
-// self-attest. The structural guard proves it never opts out of requireBuilder's
-// box gate (no allowBoxScope), matching publish-branch / publish-status exactly.
-await t('POST /tasks/:id/attest-gate: requireBuilder present, allowBoxScope ABSENT', async () => {
+// gate-author-trust commit status for a Metic+ author, so it carries the same
+// requireBuilder gate as publish-branch / publish-status.
+await t('POST /tasks/:id/attest-gate: requireBuilder present', async () => {
   const router = buildTasksRouter();
   const layer = findRouteLayer(router, '/tasks/:id/attest-gate', 'post');
   assert.ok(layer, 'the attest-gate POST route must be registered');
   const handles = handlesOf(layer);
   assert.ok(handles.includes(auth.requireBuilder), 'must be requireBuilder-gated');
-  assert.ok(!handles.includes(auth.allowBoxScope), 'must NOT carry allowBoxScope — a box session must reauth, never self-attest (#919)');
 });
 
 // task 1002645: the attest call is the ONE moment the laptop ci-land tells the

package/tests/publish_manifest.mjs

@@ -57,8 +57,7 @@ const PUBLISH = [
   'modules/lifecycle/db.js',
   'modules/grading/grader.js',
   'modules/hall-ui/public/work.js',
-  'modules/dev-box/boxes.js',
-  'modules/provisioning/provisioning.js',  // instance-hosting control plane — CORE like its sibling dev-box (task 2135)
+  'modules/provisioning/provisioning.js',  // instance-hosting control plane — CORE (task 2135)
   // served-at-runtime surfaces a standalone must carry (task 2078) — their absence
   // from the packaged core 404'd the hall UI + /docs on demo.cloudbongos.com
   'clients/bongos-client/bongos-client.global.js', // /lib/bongos-client.js (window.BongosClient)

package/tests/rank_tier_single_source.mjs

@@ -12,8 +12,7 @@
 //      modules/discord/discord-channels.js): dependency-free substrate
 //      (permission-path-check runs in a bare git hook), source-parsed literals
 //      (src/bongos/db.js — gate-review.js + diagram-facts.js regex its text),
-//      standalone CLIs (sequence), the require-free dev-box
-//      module template (boxes.js), zero-dep catalog + its text-parsing auditor
+//      standalone CLIs (sequence), zero-dep catalog + its text-parsing auditor
 //      (route-rank-check), and the hall browser statics.
 //   3. NO NEW parallel map can land: a repo scan flags any rank→number map or
 //      rank-ladder array literal outside the allowlist below, both directions —
@@ -38,7 +37,6 @@ const lifecycleDb = require(path.join(ROOT, 'modules', 'lifecycle', 'db.js'));
 const ppc = require(path.join(ROOT, 'src', 'bongos', 'permission-path-check.js'));
 const rrc = require(path.join(ROOT, 'src', 'bongos', 'route-rank-check.js'));
 const sequence = require(path.join(ROOT, 'scripts', 'gds', 'sequence.js'));
-const boxes = require(path.join(ROOT, 'modules', 'dev-box', 'boxes.js'));
 const catalog = require(path.join(ROOT, 'modules', 'government', 'catalog.js'));
 
 const LADDER = kernel.LIVE_RANK_LADDER;
@@ -81,15 +79,6 @@ test('1-based local copies match: permission-path-check, sequence CLI', () => {
   assert.deepEqual(sequence.RANK_TIER, TIER, 'sequence.js CLI copy drifted');
 });
 
-test('0-based local copies match: dev-box boxes.js', () => {
-  for (const [name, map] of [['boxes', boxes.RANK_ORDER]]) {
-    assert.deepEqual(Object.keys(map).sort(), [...RANK_KEYS].sort(), `${name} keys drifted`);
-    for (const r of RANK_KEYS) {
-      assert.equal(map[r], TIER[r] - 1, `${name}.RANK_ORDER.${r} must be tier-1 (0-based)`);
-    }
-  }
-});
-
 test('ladder mirrors match: governance catalog, route-rank-check', () => {
   assert.deepEqual([...catalog.RANK_ORDER], [...LADDER]);
   assert.deepEqual([...rrc.PERMISSION_RANK_ORDER], [...LADDER]);
@@ -192,7 +181,6 @@ const MAP_ALLOWLIST = new Set([
   'src/bongos/db.js',
   'src/bongos/permission-path-check.js',
   'scripts/gds/sequence.js',
-  'modules/dev-box/boxes.js',
   'modules/hall-ui/public/builders.js',
   // task 1003206 carved the hall page scripts up. builders.js KEPT its map (the
   // renderers read it through the injected ctx), while goals-page.js's travelled

package/tests/repo_map.mjs

@@ -87,10 +87,9 @@ test('extractor parses functions, classes, arrow consts, and module.exports', ()
   // exercise the pure extractor against the real auth.js + a known class file
   const r = run(['--json']);
   const model = JSON.parse(r.stdout);
-  // cf-tunnel.js moved modules/dev-box/ -> scripts/gds/ in task 1943 (ADR 0111 §2,
-  // shared control-plane clients). Pin the extractor against its current home.
-  const cfTunnel = model.allSyms.find((s) => s.name === 'CfTunnelApi' && s.file === 'scripts/gds/cf-tunnel.js');
-  assert.ok(cfTunnel && cfTunnel.kind === 'class', 'class declarations are detected');
+  // DoApi is a plain `class X extends Y` declaration in a control-plane client.
+  const doApi = model.allSyms.find((s) => s.name === 'DoApi' && s.file === 'scripts/gds/do-api.js');
+  assert.ok(doApi && doApi.kind === 'class', 'class declarations are detected');
   const apiCall = model.allSyms.find((s) => s.name === 'apiCall' && s.file === 'scripts/gds/cli-lib.js');
   assert.ok(apiCall && apiCall.exported && apiCall.kind === 'fn', 'exported arrow/fn const detected with export flag');
 });

package/tests/runner_drift.mjs

@@ -77,9 +77,9 @@ t('assessRunnerUnit: a drop-in that ADDS an ExecStart without clearing leaves th
 t('runnerScriptPath: node + a relative script resolves against WorkingDirectory; a wrapper resolves to null', () => {
   assert.equal(runnerScriptPath({ workingDirectory: INSTANCE, execStart: '/usr/bin/node node_modules/@bongos/core/scripts/gds/provision.js run-intents --apply' }),
     `${INSTANCE}/node_modules/@bongos/core/scripts/gds/provision.js`);
-  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env node /abs/core/scripts/gds/box.js run-intents' }), '/abs/core/scripts/gds/box.js');
-  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '-/usr/bin/node scripts/gds/box.js' }), '/w/scripts/gds/box.js', 'systemd exec prefixes are stripped');
-  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env NODE_ENV=production node --max-old-space-size=512 scripts/gds/box.js' }), '/w/scripts/gds/box.js', 'env assignments and node flags are skipped');
+  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env node /abs/core/scripts/gds/provision.js run-intents' }), '/abs/core/scripts/gds/provision.js');
+  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '-/usr/bin/node scripts/gds/provision.js' }), '/w/scripts/gds/provision.js', 'systemd exec prefixes are stripped');
+  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env NODE_ENV=production node --max-old-space-size=512 scripts/gds/provision.js' }), '/w/scripts/gds/provision.js', 'env assignments and node flags are skipped');
   assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env bash infra/core-node.sh scripts/gds/provision.js' }), null,
     'a shell wrapper decides at runtime which core it loads — the gate must not guess');
 });
@@ -130,24 +130,6 @@ t('runnerBanner: names the runner core + path, and flags a differing instance co
   assert.equal(runnerBanner({ runnerVersion: null, runnerRoot: '/r', instanceVersion: null, instanceRoot: '/i' }), 'runner core ? from /r (no installed core at /i)');
 });
 
-// box.js run-intents is the other runner the incident class covers — it opens with the same line.
-const { cmdRunIntents: boxRunIntents } = await import('../scripts/gds/box.js');
-{
-  const lines = [];
-  const origLog = console.log;
-  const origRoot = process.env.BONGOS_INSTANCE_ROOT;
-  process.env.BONGOS_INSTANCE_ROOT = '/no/such/instance';
-  console.log = (l) => lines.push(String(l));
-  try { await boxRunIntents({ query: async () => ({ rows: [] }) }, {}, null, { apply: false }); }
-  finally {
-    console.log = origLog;
-    if (origRoot === undefined) delete process.env.BONGOS_INSTANCE_ROOT; else process.env.BONGOS_INSTANCE_ROOT = origRoot;
-  }
-  t('box.js run-intents opens with the runner core version line', () => {
-    assert.match(lines[0], /^runner core \d+\.\d+\.\d+ from .+ \(no installed core at \/no\/such\/instance\)$/);
-  });
-}
-
 const { runnerDriftRows } = await import('../scripts/gds/doctor.js');
 
 t('doctor maps each verdict to a row: ok → ok, drift → FAIL with the fix, unresolved → warn', () => {