@bongos/core 1.19.1066 → 1.19.1067

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -2651,7 +2651,7 @@
2651
2651
  "surface": "builders",
2652
2652
  "title": "Studio",
2653
2653
  "states_read": ["focus","out","full","full-back","approvals","approvals-before","approvals-phone","approvals-note","approved","sent-back"],
2654
- "files_hash": "e1041dfa74aca8dd",
2654
+ "files_hash": "30f4407e6abacbb0",
2655
2655
  "reading_hash": "e52bb7163191d85a",
2656
2656
  "counts": {"lines":45,"placed":23,"shared":5,"unplaced":17},
2657
2657
  "omitted": {"data":7},
@@ -2667,18 +2667,18 @@
2667
2667
  {"key":"L0008","section":"Good morning, {…}","text":"Approval queue","placement":"placed","file":"modules/hall-ui/public/studio.html","line":55,"string_id":"20c98a4b630f"},
2668
2668
  {"key":"L0009","section":"Good morning, {…}","text":"1 page applied, waiting for you","placement":"unplaced","state":"approved"},
2669
2669
  {"key":"L0010","section":"Good morning, {…}","text":"2 pages applied, waiting for you","placement":"unplaced"},
2670
- {"key":"L0011","section":"Good morning, {…}","text":"to tend now · {…}","placement":"placed","file":"modules/hall-ui/public/studio.js","line":215,"string_id":"1b88ce51fd84"},
2670
+ {"key":"L0011","section":"Good morning, {…}","text":"to tend now · {…}","placement":"placed","file":"modules/hall-ui/public/studio.js","line":218,"string_id":"1b88ce51fd84"},
2671
2671
  {"key":"L0012","section":"The copy and visuals that {…} in task #1899","text":"The copy and visuals that {…} in task #1899","placement":"unplaced"},
2672
- {"key":"L0013","section":"The copy and visuals that {…} in task #1899","text":"It shipped and it is live. Say what you see — your review coaches the grader and never blocks what shipped.","placement":"placed","file":"modules/hall-ui/public/studio.js","line":213,"string_id":"a28aa368453f"},
2673
- {"key":"L0014","section":"The copy and visuals that {…} in task #1899","text":"What you saw","placement":"placed","file":"modules/hall-ui/public/studio.js","line":173,"string_id":"1d5bfd09068c"},
2674
- {"key":"L0015","section":"The copy and visuals that {…} in task #1899","text":"— your words, in your voice. Needed for a note or a follow-up.","placement":"placed","file":"modules/hall-ui/public/studio.js","line":173,"string_id":"d3afa6d6dd9e"},
2675
- {"key":"L0016","section":"The copy and visuals that {…} in task #1899","text":"The headline lands, but the sub-line reads like a brochure.","placement":"placed","file":"modules/hall-ui/public/studio.js","line":173,"string_id":"027e9420daa2","attr":"placeholder"},
2676
- {"key":"L0017","section":"The copy and visuals that {…} in task #1899","text":"Looks good","placement":"placed","file":"modules/hall-ui/public/studio.js","line":173,"string_id":"73677b6839d7"},
2677
- {"key":"L0018","section":"The copy and visuals that {…} in task #1899","text":"Note it","placement":"placed","file":"modules/hall-ui/public/studio.js","line":173,"string_id":"73c72974f4f9"},
2678
- {"key":"L0019","section":"The copy and visuals that {…} in task #1899","text":"Needs work","placement":"placed","file":"modules/hall-ui/public/studio.js","line":173,"string_id":"3970d299c95a"},
2679
- {"key":"L0020","section":"The copy and visuals that {…} in task #1899","text":"Open this review","placement":"placed","file":"modules/hall-ui/public/studio.js","line":215,"string_id":"1cb80282de09"},
2680
- {"key":"L0021","section":"The copy and visuals that {…} in task #1899","text":"Let it be for now","placement":"placed","file":"modules/hall-ui/public/studio.js","line":215,"string_id":"d6a78b9e5368"},
2681
- {"key":"L0022","section":"The copy and visuals that {…} in task #1899","text":"and {…} more waiting{…}","placement":"placed","file":"modules/hall-ui/public/studio.js","line":288,"string_id":"d86265f99668"},
2672
+ {"key":"L0013","section":"The copy and visuals that {…} in task #1899","text":"It shipped and it is live. Say what you see — your review coaches the grader and never blocks what shipped.","placement":"placed","file":"modules/hall-ui/public/studio.js","line":216,"string_id":"a28aa368453f"},
2673
+ {"key":"L0014","section":"The copy and visuals that {…} in task #1899","text":"What you saw","placement":"placed","file":"modules/hall-ui/public/studio.js","line":176,"string_id":"1d5bfd09068c"},
2674
+ {"key":"L0015","section":"The copy and visuals that {…} in task #1899","text":"— your words, in your voice. Needed for a note or a follow-up.","placement":"placed","file":"modules/hall-ui/public/studio.js","line":176,"string_id":"d3afa6d6dd9e"},
2675
+ {"key":"L0016","section":"The copy and visuals that {…} in task #1899","text":"The headline lands, but the sub-line reads like a brochure.","placement":"placed","file":"modules/hall-ui/public/studio.js","line":176,"string_id":"027e9420daa2","attr":"placeholder"},
2676
+ {"key":"L0017","section":"The copy and visuals that {…} in task #1899","text":"Looks good","placement":"placed","file":"modules/hall-ui/public/studio.js","line":176,"string_id":"73677b6839d7"},
2677
+ {"key":"L0018","section":"The copy and visuals that {…} in task #1899","text":"Note it","placement":"placed","file":"modules/hall-ui/public/studio.js","line":176,"string_id":"73c72974f4f9"},
2678
+ {"key":"L0019","section":"The copy and visuals that {…} in task #1899","text":"Needs work","placement":"placed","file":"modules/hall-ui/public/studio.js","line":176,"string_id":"3970d299c95a"},
2679
+ {"key":"L0020","section":"The copy and visuals that {…} in task #1899","text":"Open this review","placement":"placed","file":"modules/hall-ui/public/studio.js","line":218,"string_id":"1cb80282de09"},
2680
+ {"key":"L0021","section":"The copy and visuals that {…} in task #1899","text":"Let it be for now","placement":"placed","file":"modules/hall-ui/public/studio.js","line":218,"string_id":"d6a78b9e5368"},
2681
+ {"key":"L0022","section":"The copy and visuals that {…} in task #1899","text":"and {…} more waiting{…}","placement":"placed","file":"modules/hall-ui/public/studio.js","line":291,"string_id":"d86265f99668"},
2682
2682
  {"key":"L0023","section":"The copy and visuals that {…} in task #1899","text":"The copy desk — every flagged string","placement":"placed","file":"modules/hall-ui/public/studio.html","line":76,"string_id":"2dc061096c48"},
2683
2683
  {"key":"L0024","section":"The copy and visuals that {…} in task #1899","text":"The task board — all work","placement":"placed","file":"modules/hall-ui/public/studio.html","line":77,"string_id":"599fd0e82d1c"},
2684
2684
  {"key":"L0025","section":"footer","text":"Sign out","placement":"shared","file":"modules/hall-ui/public/shell.js","line":473,"string_id":"1883ad7f07fc"},
@@ -97,6 +97,6 @@
97
97
  studio.js mounts it with its own WRITE_ROUTES. -->
98
98
  <script src="/builders/approval-queue-lib.js"></script>
99
99
  <script src="/builders/approval-queue.js"></script>
100
- <script src="/builders/studio.js?v=2026-09-28-approvals"></script>
100
+ <script src="/builders/studio.js?v=2026-09-28-tw14"></script>
101
101
  </body>
102
102
  </html>
@@ -8,10 +8,13 @@
8
8
  // So this is NOT a queue table. It aggregates the artist's real work — the two
9
9
  // surfaces the rest of goal 1000074 built — and presents it ONE PIECE AT A TIME,
10
10
  // a stone to tend in a calm garden, with the rest waiting quietly:
11
- // 1. REVIEW REQUESTS (R04, cascade.js) — a copy/visual ship files a two-step
12
- // artist review at `backlog`, discipline 'artist', source 'cascade'. The
13
- // two steps (coach the grader, then remake/tweak) live on the task record;
14
- // this room names them and opens the door.
11
+ // 1. REVIEW REQUESTS (R04, cascade.js) — RETIRED, draining. A copy/visual
12
+ // ship used to file a two-step artist review at `backlog`, discipline
13
+ // 'artist', source 'cascade'. Tweak Mode removed that rule (task 1004325 /
14
+ // BV2.TW14, ADR 0341 D9), so no new reviews arrive; the ones already filed
15
+ // still show here so they can be answered (they may still hold a deploy
16
+ // under the strict artist gate, ADR 0241). TW16 rebuilds this room as the
17
+ // Tweak Mode home, and this queue goes with it once it is empty.
15
18
  // 2. FLAGGED COPY (R02, copy-desk) — open flags over the words the product
16
19
  // shows people. Best-effort: an instance without the copy-desk module has
17
20
  // no queue, and the room degrades to reviews alone rather than erroring.
@@ -46,9 +49,9 @@
46
49
  let busy = false; // a verdict is in flight — one at a time, so a double-click cannot file twice
47
50
  let tended = false; // at least one verdict landed this sitting, so an emptied garden reads as finished
48
51
 
49
- // Bound the reviews read. cascade.js files a review per qualifying ship and they
50
- // sit at backlog until claimed or dismissed ("dismissable rather than nagging"),
51
- // so this queue grows without bound over the project's life — the unbounded-read
52
+ // Bound the reviews read. cascade.js USED to file a review per qualifying ship
53
+ // (no longer, since TW14: the queue only drains now), and they sit at backlog
54
+ // until claimed or dismissed, so this queue could grow without bound — the unbounded-read
52
55
  // shape modules/hall-ui/CLAUDE.md flags as a repeat bug (the Work board's backlog,
53
56
  // Home's next-up card, the Goals rollup all had it). 50 is far more than a focus
54
57
  // queue tends at once; the footer links to the copy desk and board are the
@@ -240,8 +243,8 @@
240
243
  function emptyCard(done) {
241
244
  const heading = done ? 'You have tended everything waiting' : 'Nothing waits right now';
242
245
  const body = done
243
- ? 'That is the whole garden. Come back when work ships, or start again from the top.'
244
- : 'A quiet moment — either good news or an unread queue. When work with copy or visuals ships, a review appears here for you.';
246
+ ? 'That is the whole garden. Come back when someone flags a line, or start again from the top.'
247
+ : 'A quiet moment. When someone flags a line of copy, it waits here for you.';
245
248
  const restart = done
246
249
  ? '<div class="studio-card__actions studio-empty__actions"><button type="button" class="btn-ghost" data-restart>Start over</button></div>'
247
250
  : '';
@@ -21,7 +21,9 @@
21
21
  // mechanism, its idempotency and its non-blocking property are proved by the
22
22
  // tests' own declarations, and R04 (task 1003115) writes the first production
23
23
  // entry. A mechanism whose first real rule is written by the task that needs it
24
- // is honest; one that ships a rule nobody asked for is a guess.
24
+ // is honest; one that ships a rule nobody asked for is a guess. (R04's artist
25
+ // review has since been removed by Tweak Mode, TW14; the removal proposal and
26
+ // the idea cascade remain. See the note above COPY_VISUAL_MODULES.)
25
27
  //
26
28
  // THE FOUR PROPERTIES THAT MAKE IT SAFE, each of which the tests pin:
27
29
  //
@@ -87,32 +89,34 @@
87
89
  // board has not triaged has, precisely, no classification yet.
88
90
  //
89
91
  // ---------------------------------------------------------------------------
90
- // The first production rule (R04 of goal 1000074, task 1003115).
92
+ // The artist review that USED to be the first rule (removed, TW14).
91
93
  // ---------------------------------------------------------------------------
92
94
  //
93
- // THE ARTIST REVIEW. "Every shipped work with copy or visuals becomes a Review
94
- // task for an artist, in two steps" (the criterion artist-review-task-on-ship).
95
- // This is the rule that makes that true, and it is the whole of R04's build: the
96
- // mechanism (ADR 0242) and its four safety properties already exist and are
97
- // tested; R04 writes the one declaration.
95
+ // R04 (task 1003115) wrote the first production entry here: `artist-review-on-
96
+ // ship`, which filed a two-step artist review at backlog for every ship with
97
+ // copy or visuals. It is GONE (task 1004325 / BV2.TW14, ADR 0341 D9). The reviews
98
+ // were one per ship, and 34 of the 39 it filed were abandoned, 33 with no note.
99
+ // Tweak Mode replaced it: the PAGE is the unit an artist works on, and a ship
100
+ // that changes a page's words now WRITES NOTHING. The page reads "changed since
101
+ // last tweak" because drift is DERIVED (ADR 0341 D8, modules/copy-desk/
102
+ // page-status.js driftFor): the page's current reading against the lines its
103
+ // last round left. Nothing to store, so nothing here to file.
98
104
  //
99
- // TWO GUARDS THAT KEEP IT FROM MISFIRING, both pinned in the tests:
100
- // • It excludes `source === CASCADE_SOURCE`. Without that, the artist review
101
- // task it generates — discipline 'artist', so it matches its own predicate —
102
- // would on ship generate a review OF the review, and so on. The exclusion
103
- // makes the generation a single hop, never a chain.
104
- // • "Copy or visuals" is a NARROW, explicit predicate (hasCopyOrVisualWork),
105
- // not "every ship". A cascade that fired on everything would bury the artist,
106
- // and the criterion's "dismissable rather than nagging" would be a lie.
105
+ // Do not bring a per-ship artist rule back to "mark the page": the mark already
106
+ // exists, derived, and a stored one would be a second record of what the
107
+ // readings and the ledger say.
107
108
  //
108
- // It does NOT block anything (ADR 0241 draws the line: an artist may hold a
109
- // DEPLOY, decided per project, never a builder's ship; that gate is a separate
110
- // build). The generated task is a `backlog` request that triage may dismiss.
109
+ // What stays, and why:
110
+ // • `hasCopyOrVisualWork` stays exported. The grader's advisory reader lens
111
+ // (ADR 0298, scripts/gds/ship-grade.js) is scoped by it.
112
+ // • The runner still resolves `ctx.artistGate` and `ctx.changedFiles` when a
113
+ // caller injects them (routes/lifecycle.js does). No production rule reads
114
+ // either today; the reads are shared with the removal rule's (ship-files.js
115
+ // memoises them), so they cost nothing, and ADR 0341 D9 keeps the runner.
116
+ // • Review rows already filed (source 'cascade', ref prefix `cascade-artist-
117
+ // review-on-ship-`) are ordinary data. The artist gate (ADR 0241) and the
118
+ // studio still read them; nothing deletes them.
111
119
 
112
- // The modules whose shipped work puts user-facing copy or visuals in front of a
113
- // person. Kept as an explicit set rather than inferred, because "is this
114
- // copy/visual work" is a judgement the rule should state out loud and a test
115
- // should be able to pin — an inferred predicate is the kind that quietly widens.
116
120
  // The removal rule's key, lifted out of its declaration so the SURFACE that
117
121
  // answers a removal proposal (task 1004095 / BV2.R16) can find those proposals
118
122
  // without hand-typing the string. The key is half of every generated row's
@@ -120,6 +124,11 @@
120
124
  // reader that silently returns nothing the day the key changes.
121
125
  const REMOVAL_RULE_KEY = 'removal-proposed-on-ship';
122
126
 
127
+ // The modules whose shipped work puts user-facing copy or visuals in front of a
128
+ // person. Kept as an explicit set rather than inferred, because "is this
129
+ // copy/visual work" is a judgement the predicate should state out loud and a
130
+ // test should be able to pin — an inferred predicate is the kind that quietly
131
+ // widens.
123
132
  const COPY_VISUAL_MODULES = Object.freeze([
124
133
  'copy-desk', // the copy registry + proposals (goal 1000074's own spine)
125
134
  'hall-ui', // the builders' hall — the most-seen surface
@@ -142,8 +151,9 @@ function isUiSurfacePath(p) { return typeof p === 'string' && UI_SURFACE_PATH.te
142
151
  // `changedFiles` is what the work actually CHANGED (task 1004201). The label
143
152
  // alone missed most UI work: of 19 recent ships that changed page files, 14 had
144
153
  // module_key null — the goal forest (task 1003480) shipped its overflowing
145
- // titles with no visual lens and no review. Owner decision 2026-09-23: every UI
146
- // change gets a visual review, and this is the predicate that files it.
154
+ // titles with no visual lens. Owner decision 2026-09-23: every UI change gets a
155
+ // visual lens. Since TW14 no cascade files a review on it; the grader's reader
156
+ // lens (ADR 0298) is what this predicate scopes.
147
157
  function hasCopyOrVisualWork(task, changedFiles) {
148
158
  if (!task) return false;
149
159
  if (task.source === 'copy-proposal') return true; // a copy change that landed via the copy desk (ADR 0233)
@@ -153,44 +163,6 @@ function hasCopyOrVisualWork(task, changedFiles) {
153
163
  return false;
154
164
  }
155
165
 
156
- // The two-step artist review body. STEP 1 records where the grade was blind;
157
- // STEP 2 remakes the copy/visuals with both routes explicitly offered — R04's
158
- // brief, verbatim in intent.
159
- //
160
- // STEP 1 ASKS FOR COACHING AGAIN, because there is now a lens listening.
161
- //
162
- // The history, because the wording is load-bearing: STEP 1 originally said
163
- // "coach the grader", which asked for something no artist could do (task
164
- // 1003937, ADR 0298) — the panel's four lenses read completion, code quality,
165
- // security and runtime cost, and not one read a sentence, so four consecutive
166
- // reviews found the same wall. The step was rewritten to ask for the RECORD
167
- // instead, and that version carried an explicit instruction not to restore the
168
- // coaching wording early, because the wording is the signal for which world we
169
- // are in.
170
- //
171
- // Task 1003977 shipped the fifth lens: an ADVISORY 'reader', scoped to
172
- // copy-bearing diffs by THIS FILE'S hasCopyOrVisualWork — the same predicate
173
- // that fires this cascade, so an artist review and the copy lens cover exactly
174
- // the same set by construction, and widening one widens both. The voice guide
175
- // it waited on is docs/voice.md (task 1003976). So there is a counterpart to
176
- // coach, it has a written standard to be coached against, and the record the
177
- // interim wording collected is what both were built from.
178
- //
179
- // What has NOT changed: the reader is non-gating and cannot hold a ship (ADR
180
- // 0241 keeps the artist's judgement on the deploy), so this review is still a
181
- // request triage may dismiss.
182
- function artistReviewBody(task) {
183
- return [
184
- `This is an ARTIST REVIEW, generated automatically because task ${task.id} put copy or visuals in front of a person. It is a REQUEST, not a gate — it blocks nothing that shipped, and triage may dismiss it.`,
185
- '',
186
- `STEP 1 — COACH THE READER. Pull how the grader judged task ${task.id} (GET /tasks/${task.id}?include=grade) and find the 'reader' row in signals.workers, with its copy_score in rubric_scores. That lens read the changed copy against docs/voice.md and cited rule ids. Say where it was RIGHT, where it was WRONG, and — the valuable one — what it did not see at all. A finding it filed that you disagree with is worth as much as one it missed: both are corrections to a lens that is listening, which is what this step could not ask for before task 1003977 shipped it (ADR 0298). If the miss is because no rule in docs/voice.md reaches it, that is a gap in the GUIDE — file it against the guide rather than expecting the lens to invent a rule at grade time. Two cases where there will be no reader row and that is not a fault: a ship that took the trivial-diff path (a single generalist shot, no panel), and one where the lens errored — it is advisory, so an outage is recorded and nothing is blocked.`,
187
- '',
188
- 'STEP 2 — REMAKE OR TWEAK the copy/visuals if they need it. Your choice of route, both offered on purpose: OUTSIDE the AI chat (edit the surface directly and land it through the copy desk or the normal pipeline), or WITH it (draft in chat, then land). Either way it lands as a claimed, graded, shipped task like everything else — there is no live CMS (goal 1000074\'s hard rule).',
189
- '',
190
- 'If the copy and visuals are fine and there was nothing the grade missed, DISMISS this in triage. That is a real, expected outcome — not a failure.',
191
- ].join('\n');
192
- }
193
-
194
166
  // The removal proposal's body (task 1004090 / BV2.R15, ADR 0313).
195
167
  //
196
168
  // IT ASKS, IT DOES NOT TELL. Every line here is written so a reader confirms or
@@ -235,44 +207,25 @@ function removalProposalBody(task, ctx) {
235
207
  return lines.join('\n');
236
208
  }
237
209
 
238
- // Production rules. The artist review is the first (R04); add another by
239
- // appending an entry, never by touching the runner (ADR 0242).
210
+ // Production rules. Add one by appending an entry, never by touching the runner
211
+ // (ADR 0242). The artist review (R04) was the first and is gone (TW14, ADR 0341
212
+ // D9; see the note above COPY_VISUAL_MODULES), so the removal proposal is the
213
+ // only ship rule today.
240
214
  const CASCADES = Object.freeze([
241
- Object.freeze({
242
- key: 'artist-review-on-ship',
243
- discipline: 'artist',
244
- kind: 'unclassified',
245
- // The anti-recursion guard (source !== CASCADE_SOURCE) is FIRST so a
246
- // cascade-generated task is rejected before any other test runs.
247
- //
248
- // The project's artist_gate at 'off' means "not generated" (ADR 0241 §2's
249
- // table, task 1003575) — the one level at which this rule files nothing. It
250
- // is read from ctx, never from branding, so the predicate stays pure; an
251
- // absent ctx (a caller that resolved no policy) files, because the gate's
252
- // default is 'strict' and silence must not be read as an opt-out.
253
- //
254
- // A changed-files list that hit GitHub's read cap FILES (task 1004201): a UI
255
- // file may sit past the cap, and a padded PR must not skip its review.
256
- when: (t, ctx) => (ctx || {}).artistGate !== 'off'
257
- && t.source !== CASCADE_SOURCE
258
- && (hasCopyOrVisualWork(t, (ctx || {}).changedFiles) || (ctx || {}).changedFilesTruncated === true),
259
- title: (t) => `Artist review: the copy and visuals that shipped in task ${t.id}`,
260
- body: artistReviewBody,
261
- }),
262
215
  Object.freeze({
263
216
  key: REMOVAL_RULE_KEY,
264
217
  // ENGINEER, not artist: confirming asks whether deleted code is genuinely
265
218
  // gone or was moved, which is a question about the diff.
266
219
  discipline: 'engineer',
267
220
  kind: 'unclassified',
268
- // The anti-recursion guard FIRST, the same order and for the same reason as
269
- // the rule above — a cascade-generated task must never cascade.
221
+ // The anti-recursion guard FIRST: a cascade-generated task must never
222
+ // cascade, so it is rejected before any other test runs.
270
223
  //
271
224
  // The candidates are resolved ONCE into ctx by runCascadesForShip, never
272
225
  // here: a `when` is pure and synchronous by contract, and this derivation is
273
226
  // a network read. An absent ctx therefore means "nothing was derived" and
274
- // files nothing — the opposite default to the artist gate above, and
275
- // deliberately so: silence about a removal must never be read as a removal.
227
+ // files nothing, deliberately: silence about a removal must never be read
228
+ // as a removal.
276
229
  when: (t, ctx) => t.source !== CASCADE_SOURCE
277
230
  && Array.isArray((ctx || {}).removals) && (ctx || {}).removals.length > 0,
278
231
  title: (t) => `Was this removed? Task ${t.id} deleted earlier shipped work`,
@@ -418,9 +371,9 @@ function cascadesFor(task, rules = CASCADES, ctx = {}, trigger = TRIGGERS.ship)
418
371
 
419
372
  // The createTask payload for one matched rule. The attribution preamble is
420
373
  // prepended here rather than left to each rule, so no rule can forget it.
421
- // `ctx` reaches body() as a second argument, mirroring when(). The artist rule
422
- // ignores it; the removal rule needs it, because what a ship deleted is derived
423
- // per run and is not a property of the task row.
374
+ // `ctx` reaches body() as a second argument, mirroring when(). The removal rule
375
+ // needs it, because what a ship deleted is derived per run and is not a property
376
+ // of the task row.
424
377
  function cascadeTaskSpec(rule, task, trigger = TRIGGERS.ship, ctx = {}) {
425
378
  const body = String(rule.body(task, ctx) || '').trim();
426
379
  const preamble =
@@ -559,9 +512,9 @@ async function runCascadesForShip(shipped, deps = {}) {
559
512
  catch (e) { report.errors.push(`cascade: artistGateMode() threw (${e && e.message}) — policy unread`); }
560
513
  }
561
514
  // WHAT THIS SHIP CHANGED (task 1004201), from the server's own view of the
562
- // merged pull request, so the artist review keys on the work rather than a
563
- // module_key label. A resolver that throws is reported and leaves the key
564
- // unset: the label-based match still stands and the ship costs nothing.
515
+ // merged pull request, so a rule can key on the work rather than a
516
+ // module_key label (the artist review did, until TW14 removed it). A resolver
517
+ // that throws is reported and leaves the key unset, and the ship costs nothing.
565
518
  if (typeof deps.changedFiles === 'function') {
566
519
  try {
567
520
  const changed = await deps.changedFiles(task);
@@ -650,7 +603,6 @@ module.exports = {
650
603
  COPY_VISUAL_MODULES,
651
604
  hasCopyOrVisualWork,
652
605
  isUiSurfacePath,
653
- artistReviewBody,
654
606
  cascadeSourceRef,
655
607
  assertRuleShape,
656
608
  validateCascades,
@@ -79,16 +79,16 @@ function registerSeams() {
79
79
  getTask: (id) => db.getTask(id),
80
80
  findTaskBySourceRef: (ref) => db.findTaskBySourceRef(ref),
81
81
  createTask: (spec) => db.createTask(spec),
82
- // The project's artist gate (ADR 0241, task 1003575). Resolved through the
83
- // doorway's one reader rather than from branding().project, so the level that
84
- // decides whether a review is FILED and the level that decides whether one
85
- // HOLDS a deploy can never be read differently. At 'off' the artist-review
86
- // rule files nothing.
82
+ // The project's artist gate (ADR 0241, task 1003575), resolved through the
83
+ // doorway's one reader rather than from branding().project. The artist-review
84
+ // rule that read it was removed by Tweak Mode (TW14, ADR 0341 D9), so no
85
+ // production rule reads it today; the runner still offers it as policy.
87
86
  artistGateMode: () => api.artistGate.artistGateMode(),
88
- // WHAT THIS SHIP CHANGED (task 1004201): the merged PR's paths, so a UI
89
- // change files its artist review whatever its module_key label says. The
90
- // NAMED function, not a closure, for the reason removalCandidates gives below;
91
- // the arrow only hands it this ship's shared reads.
87
+ // WHAT THIS SHIP CHANGED (task 1004201): the merged PR's paths. No rule reads
88
+ // them since TW14, and they cost nothing extra: sharedPrReads memoises the
89
+ // same two GitHub reads removalCandidates makes. The NAMED function, not a
90
+ // closure, for the reason removalCandidates gives below; the arrow only hands
91
+ // it this ship's shared reads.
92
92
  changedFiles: (task) => shipFiles.changedFilesForTask(task, pr),
93
93
  // WHAT THIS SHIP DELETED (task 1004090 / BV2.R15, ADR 0313). The derivation
94
94
  // asks GitHub what the pull request actually changed and blames the deleted