@bongos/core 1.19.1065 → 1.19.1067

package/modules/lifecycle/cascade.js

@@ -21,7 +21,9 @@
 // mechanism, its idempotency and its non-blocking property are proved by the
 // tests' own declarations, and R04 (task 1003115) writes the first production
 // entry. A mechanism whose first real rule is written by the task that needs it
-// is honest; one that ships a rule nobody asked for is a guess.
+// is honest; one that ships a rule nobody asked for is a guess. (R04's artist
+// review has since been removed by Tweak Mode, TW14; the removal proposal and
+// the idea cascade remain. See the note above COPY_VISUAL_MODULES.)
 //
 // THE FOUR PROPERTIES THAT MAKE IT SAFE, each of which the tests pin:
 //
@@ -87,32 +89,34 @@
 //               board has not triaged has, precisely, no classification yet.
 //
 // ---------------------------------------------------------------------------
-// The first production rule (R04 of goal 1000074, task 1003115).
+// The artist review that USED to be the first rule (removed, TW14).
 // ---------------------------------------------------------------------------
 //
-// THE ARTIST REVIEW. "Every shipped work with copy or visuals becomes a Review
-// task for an artist, in two steps" (the criterion artist-review-task-on-ship).
-// This is the rule that makes that true, and it is the whole of R04's build: the
-// mechanism (ADR 0242) and its four safety properties already exist and are
-// tested; R04 writes the one declaration.
+// R04 (task 1003115) wrote the first production entry here: `artist-review-on-
+// ship`, which filed a two-step artist review at backlog for every ship with
+// copy or visuals. It is GONE (task 1004325 / BV2.TW14, ADR 0341 D9). The reviews
+// were one per ship, and 34 of the 39 it filed were abandoned, 33 with no note.
+// Tweak Mode replaced it: the PAGE is the unit an artist works on, and a ship
+// that changes a page's words now WRITES NOTHING. The page reads "changed since
+// last tweak" because drift is DERIVED (ADR 0341 D8, modules/copy-desk/
+// page-status.js driftFor): the page's current reading against the lines its
+// last round left. Nothing to store, so nothing here to file.
 //
-// TWO GUARDS THAT KEEP IT FROM MISFIRING, both pinned in the tests:
-//   • It excludes `source === CASCADE_SOURCE`. Without that, the artist review
-//     task it generates — discipline 'artist', so it matches its own predicate —
-//     would on ship generate a review OF the review, and so on. The exclusion
-//     makes the generation a single hop, never a chain.
-//   • "Copy or visuals" is a NARROW, explicit predicate (hasCopyOrVisualWork),
-//     not "every ship". A cascade that fired on everything would bury the artist,
-//     and the criterion's "dismissable rather than nagging" would be a lie.
+// Do not bring a per-ship artist rule back to "mark the page": the mark already
+// exists, derived, and a stored one would be a second record of what the
+// readings and the ledger say.
 //
-// It does NOT block anything (ADR 0241 draws the line: an artist may hold a
-// DEPLOY, decided per project, never a builder's ship; that gate is a separate
-// build). The generated task is a `backlog` request that triage may dismiss.
+// What stays, and why:
+//   • `hasCopyOrVisualWork` stays exported. The grader's advisory reader lens
+//     (ADR 0298, scripts/gds/ship-grade.js) is scoped by it.
+//   • The runner still resolves `ctx.artistGate` and `ctx.changedFiles` when a
+//     caller injects them (routes/lifecycle.js does). No production rule reads
+//     either today; the reads are shared with the removal rule's (ship-files.js
+//     memoises them), so they cost nothing, and ADR 0341 D9 keeps the runner.
+//   • Review rows already filed (source 'cascade', ref prefix `cascade-artist-
+//     review-on-ship-`) are ordinary data. The artist gate (ADR 0241) and the
+//     studio still read them; nothing deletes them.
 
-// The modules whose shipped work puts user-facing copy or visuals in front of a
-// person. Kept as an explicit set rather than inferred, because "is this
-// copy/visual work" is a judgement the rule should state out loud and a test
-// should be able to pin — an inferred predicate is the kind that quietly widens.
 // The removal rule's key, lifted out of its declaration so the SURFACE that
 // answers a removal proposal (task 1004095 / BV2.R16) can find those proposals
 // without hand-typing the string. The key is half of every generated row's
@@ -120,6 +124,11 @@
 // reader that silently returns nothing the day the key changes.
 const REMOVAL_RULE_KEY = 'removal-proposed-on-ship';
 
+// The modules whose shipped work puts user-facing copy or visuals in front of a
+// person. Kept as an explicit set rather than inferred, because "is this
+// copy/visual work" is a judgement the predicate should state out loud and a
+// test should be able to pin — an inferred predicate is the kind that quietly
+// widens.
 const COPY_VISUAL_MODULES = Object.freeze([
   'copy-desk',    // the copy registry + proposals (goal 1000074's own spine)
   'hall-ui',      // the builders' hall — the most-seen surface
@@ -142,8 +151,9 @@ function isUiSurfacePath(p) { return typeof p === 'string' && UI_SURFACE_PATH.te
 // `changedFiles` is what the work actually CHANGED (task 1004201). The label
 // alone missed most UI work: of 19 recent ships that changed page files, 14 had
 // module_key null — the goal forest (task 1003480) shipped its overflowing
-// titles with no visual lens and no review. Owner decision 2026-09-23: every UI
-// change gets a visual review, and this is the predicate that files it.
+// titles with no visual lens. Owner decision 2026-09-23: every UI change gets a
+// visual lens. Since TW14 no cascade files a review on it; the grader's reader
+// lens (ADR 0298) is what this predicate scopes.
 function hasCopyOrVisualWork(task, changedFiles) {
   if (!task) return false;
   if (task.source === 'copy-proposal') return true;        // a copy change that landed via the copy desk (ADR 0233)
@@ -153,44 +163,6 @@ function hasCopyOrVisualWork(task, changedFiles) {
   return false;
 }
 
-// The two-step artist review body. STEP 1 records where the grade was blind;
-// STEP 2 remakes the copy/visuals with both routes explicitly offered — R04's
-// brief, verbatim in intent.
-//
-// STEP 1 ASKS FOR COACHING AGAIN, because there is now a lens listening.
-//
-// The history, because the wording is load-bearing: STEP 1 originally said
-// "coach the grader", which asked for something no artist could do (task
-// 1003937, ADR 0298) — the panel's four lenses read completion, code quality,
-// security and runtime cost, and not one read a sentence, so four consecutive
-// reviews found the same wall. The step was rewritten to ask for the RECORD
-// instead, and that version carried an explicit instruction not to restore the
-// coaching wording early, because the wording is the signal for which world we
-// are in.
-//
-// Task 1003977 shipped the fifth lens: an ADVISORY 'reader', scoped to
-// copy-bearing diffs by THIS FILE'S hasCopyOrVisualWork — the same predicate
-// that fires this cascade, so an artist review and the copy lens cover exactly
-// the same set by construction, and widening one widens both. The voice guide
-// it waited on is docs/voice.md (task 1003976). So there is a counterpart to
-// coach, it has a written standard to be coached against, and the record the
-// interim wording collected is what both were built from.
-//
-// What has NOT changed: the reader is non-gating and cannot hold a ship (ADR
-// 0241 keeps the artist's judgement on the deploy), so this review is still a
-// request triage may dismiss.
-function artistReviewBody(task) {
-  return [
-    `This is an ARTIST REVIEW, generated automatically because task ${task.id} put copy or visuals in front of a person. It is a REQUEST, not a gate — it blocks nothing that shipped, and triage may dismiss it.`,
-    '',
-    `STEP 1 — COACH THE READER. Pull how the grader judged task ${task.id} (GET /tasks/${task.id}?include=grade) and find the 'reader' row in signals.workers, with its copy_score in rubric_scores. That lens read the changed copy against docs/voice.md and cited rule ids. Say where it was RIGHT, where it was WRONG, and — the valuable one — what it did not see at all. A finding it filed that you disagree with is worth as much as one it missed: both are corrections to a lens that is listening, which is what this step could not ask for before task 1003977 shipped it (ADR 0298). If the miss is because no rule in docs/voice.md reaches it, that is a gap in the GUIDE — file it against the guide rather than expecting the lens to invent a rule at grade time. Two cases where there will be no reader row and that is not a fault: a ship that took the trivial-diff path (a single generalist shot, no panel), and one where the lens errored — it is advisory, so an outage is recorded and nothing is blocked.`,
-    '',
-    'STEP 2 — REMAKE OR TWEAK the copy/visuals if they need it. Your choice of route, both offered on purpose: OUTSIDE the AI chat (edit the surface directly and land it through the copy desk or the normal pipeline), or WITH it (draft in chat, then land). Either way it lands as a claimed, graded, shipped task like everything else — there is no live CMS (goal 1000074\'s hard rule).',
-    '',
-    'If the copy and visuals are fine and there was nothing the grade missed, DISMISS this in triage. That is a real, expected outcome — not a failure.',
-  ].join('\n');
-}
-
 // The removal proposal's body (task 1004090 / BV2.R15, ADR 0313).
 //
 // IT ASKS, IT DOES NOT TELL. Every line here is written so a reader confirms or
@@ -235,44 +207,25 @@ function removalProposalBody(task, ctx) {
   return lines.join('\n');
 }
 
-// Production rules. The artist review is the first (R04); add another by
-// appending an entry, never by touching the runner (ADR 0242).
+// Production rules. Add one by appending an entry, never by touching the runner
+// (ADR 0242). The artist review (R04) was the first and is gone (TW14, ADR 0341
+// D9; see the note above COPY_VISUAL_MODULES), so the removal proposal is the
+// only ship rule today.
 const CASCADES = Object.freeze([
-  Object.freeze({
-    key: 'artist-review-on-ship',
-    discipline: 'artist',
-    kind: 'unclassified',
-    // The anti-recursion guard (source !== CASCADE_SOURCE) is FIRST so a
-    // cascade-generated task is rejected before any other test runs.
-    //
-    // The project's artist_gate at 'off' means "not generated" (ADR 0241 §2's
-    // table, task 1003575) — the one level at which this rule files nothing. It
-    // is read from ctx, never from branding, so the predicate stays pure; an
-    // absent ctx (a caller that resolved no policy) files, because the gate's
-    // default is 'strict' and silence must not be read as an opt-out.
-    //
-    // A changed-files list that hit GitHub's read cap FILES (task 1004201): a UI
-    // file may sit past the cap, and a padded PR must not skip its review.
-    when: (t, ctx) => (ctx || {}).artistGate !== 'off'
-      && t.source !== CASCADE_SOURCE
-      && (hasCopyOrVisualWork(t, (ctx || {}).changedFiles) || (ctx || {}).changedFilesTruncated === true),
-    title: (t) => `Artist review: the copy and visuals that shipped in task ${t.id}`,
-    body: artistReviewBody,
-  }),
   Object.freeze({
     key: REMOVAL_RULE_KEY,
     // ENGINEER, not artist: confirming asks whether deleted code is genuinely
     // gone or was moved, which is a question about the diff.
     discipline: 'engineer',
     kind: 'unclassified',
-    // The anti-recursion guard FIRST, the same order and for the same reason as
-    // the rule above — a cascade-generated task must never cascade.
+    // The anti-recursion guard FIRST: a cascade-generated task must never
+    // cascade, so it is rejected before any other test runs.
     //
     // The candidates are resolved ONCE into ctx by runCascadesForShip, never
     // here: a `when` is pure and synchronous by contract, and this derivation is
     // a network read. An absent ctx therefore means "nothing was derived" and
-    // files nothing — the opposite default to the artist gate above, and
-    // deliberately so: silence about a removal must never be read as a removal.
+    // files nothing, deliberately: silence about a removal must never be read
+    // as a removal.
     when: (t, ctx) => t.source !== CASCADE_SOURCE
       && Array.isArray((ctx || {}).removals) && (ctx || {}).removals.length > 0,
     title: (t) => `Was this removed? Task ${t.id} deleted earlier shipped work`,
@@ -418,9 +371,9 @@ function cascadesFor(task, rules = CASCADES, ctx = {}, trigger = TRIGGERS.ship)
 
 // The createTask payload for one matched rule. The attribution preamble is
 // prepended here rather than left to each rule, so no rule can forget it.
-// `ctx` reaches body() as a second argument, mirroring when(). The artist rule
-// ignores it; the removal rule needs it, because what a ship deleted is derived
-// per run and is not a property of the task row.
+// `ctx` reaches body() as a second argument, mirroring when(). The removal rule
+// needs it, because what a ship deleted is derived per run and is not a property
+// of the task row.
 function cascadeTaskSpec(rule, task, trigger = TRIGGERS.ship, ctx = {}) {
   const body = String(rule.body(task, ctx) || '').trim();
   const preamble =
@@ -559,9 +512,9 @@ async function runCascadesForShip(shipped, deps = {}) {
       catch (e) { report.errors.push(`cascade: artistGateMode() threw (${e && e.message}) — policy unread`); }
     }
     // WHAT THIS SHIP CHANGED (task 1004201), from the server's own view of the
-    // merged pull request, so the artist review keys on the work rather than a
-    // module_key label. A resolver that throws is reported and leaves the key
-    // unset: the label-based match still stands and the ship costs nothing.
+    // merged pull request, so a rule can key on the work rather than a
+    // module_key label (the artist review did, until TW14 removed it). A resolver
+    // that throws is reported and leaves the key unset, and the ship costs nothing.
     if (typeof deps.changedFiles === 'function') {
       try {
         const changed = await deps.changedFiles(task);
@@ -650,7 +603,6 @@ module.exports = {
   COPY_VISUAL_MODULES,
   hasCopyOrVisualWork,
   isUiSurfacePath,
-  artistReviewBody,
   cascadeSourceRef,
   assertRuleShape,
   validateCascades,

package/modules/lifecycle/db-ship.js

@@ -18,6 +18,7 @@ const doneWhen = require('./done-when.js');
 const { THETES_GRADUATION_THRESHOLD, maybeAutoGraduateToThetes, foldWorktreeName } = require('./db-rank-authz.js');
 const { mostRecentClaimHolderId, sealSessionLog, staleClaimHourPredicate } = require('./db-shared.js');
 const { LIVE_STATUSES } = require('./dead-deps.js');
+const { isPageTweak } = require('./page-tweak-hold.js');
 
 // shouldRefuseClaimResolve — may THIS caller resolve THIS claim? (task 1003767)
 //
@@ -346,8 +347,15 @@ async function resolveClaim({ claimId, builderId, outcome, notesMd, valueSummary
 // row, re-landing books a FRESH 'task.shipped' row — the reward is fully
 // re-earnable, exactly as the ADR promises. Caller passes its ship txn client
 // so the credit commits atomically with the status flip.
-async function awardLandingCredit(client, { taskId, creditedBuilderId, creditsReward, kind }) {
+async function awardLandingCredit(client, { taskId, creditedBuilderId, creditsReward, kind, source = null }) {
   const reward = seams.resolveOptional('reward');
+  // ADR 0341 D10 (task 1004324): a page tweak's per-task stream is its ARTIST's, on the
+  // artist lane, in place of the shipper's estimate (economy reads the payee); the
+  // applier keeps its cost-plus session reward, which is booked elsewhere.
+  if (reward && isPageTweak({ source })) {
+    const artist = reward.awardArtistPageCredit ? await reward.awardArtistPageCredit(client, { taskId }) : null;
+    return { creditsAwarded: 0, ideaBonus: null, artist };
+  }
   if (!reward || creditedBuilderId == null || !(Number(creditsReward) > 0)) {
     return { creditsAwarded: 0, ideaBonus: null };
   }
@@ -510,7 +518,7 @@ async function shipTask({ taskId, builderId, landAssurance }, deps = {}) {
   // under NODE_ENV==='test', so a regression test can drive the txn with a
   // SQL-aware fakeClient. Production callers omit deps → module pool.
   const activePool = (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : pool;
-  const { shipRow, graduationBuilder, rankGraduation, actualShipperId, closedClaimCount, creditedBuilderId, creditsAwarded, ideaBonus, justUnlocked } = await withTx(async (client) => {
+  const { shipRow, graduationBuilder, rankGraduation, actualShipperId, closedClaimCount, creditedBuilderId, creditsAwarded, ideaBonus, artistCredit, justUnlocked } = await withTx(async (client) => {
     const { rows } = await client.query(
       `UPDATE tasks
           SET status = 'shipped',
@@ -521,7 +529,7 @@ async function shipTask({ taskId, builderId, landAssurance }, deps = {}) {
               needs_rebase_at = NULL,
               updated_at = now()
         WHERE id = $1 AND status = 'confirmed'
-        RETURNING id, title, status, shipped_at, shipped_by, security_sensitive, value_summary, credits_reward, kind`,
+        RETURNING id, title, status, shipped_at, shipped_by, security_sensitive, value_summary, credits_reward, kind, source`,
       [taskId, builderId]
     );
     if (rows.length === 0) {
@@ -626,6 +634,7 @@ async function shipTask({ taskId, builderId, landAssurance }, deps = {}) {
       creditedBuilderId,
       creditsReward: rows[0].credits_reward,
       kind: rows[0].kind,
+      source: rows[0].source,
     });
     // task 1679 pattern: state-based achievement reconcile now that the credit
     // (above) + the ship count are reflected in this txn. SAVEPOINT-wrapped so
@@ -647,7 +656,7 @@ async function shipTask({ taskId, builderId, landAssurance }, deps = {}) {
     return {
       shipRow: rows[0], graduationBuilder, rankGraduation, actualShipperId,
       closedClaimCount: closedClaims.length,
-      creditedBuilderId, creditsAwarded: landing.creditsAwarded, ideaBonus: landing.ideaBonus, justUnlocked,
+      creditedBuilderId, creditsAwarded: landing.creditsAwarded, ideaBonus: landing.ideaBonus, artistCredit: landing.artist || null, justUnlocked,
     };
   }, { pool: activePool });
   if (closedClaimCount > 0) {
@@ -677,7 +686,7 @@ async function shipTask({ taskId, builderId, landAssurance }, deps = {}) {
     // ADR 0120: the per-task reward that landed on THIS ship (0 on a re-ship /
     // reconciler re-sweep — idempotent). The ship route surfaces it so the
     // builder sees "credits landed" at ship, not at confirm.
-    creditedBuilderId, creditsAwarded, ideaBonus, justUnlocked,
+    creditedBuilderId, creditsAwarded, ideaBonus, artistCredit, justUnlocked,
   };
 }
 

package/modules/lifecycle/routes/lifecycle.js

@@ -79,16 +79,16 @@ function registerSeams() {
       getTask: (id) => db.getTask(id),
       findTaskBySourceRef: (ref) => db.findTaskBySourceRef(ref),
       createTask: (spec) => db.createTask(spec),
-      // The project's artist gate (ADR 0241, task 1003575). Resolved through the
-      // doorway's one reader rather than from branding().project, so the level that
-      // decides whether a review is FILED and the level that decides whether one
-      // HOLDS a deploy can never be read differently. At 'off' the artist-review
-      // rule files nothing.
+      // The project's artist gate (ADR 0241, task 1003575), resolved through the
+      // doorway's one reader rather than from branding().project. The artist-review
+      // rule that read it was removed by Tweak Mode (TW14, ADR 0341 D9), so no
+      // production rule reads it today; the runner still offers it as policy.
       artistGateMode: () => api.artistGate.artistGateMode(),
-      // WHAT THIS SHIP CHANGED (task 1004201): the merged PR's paths, so a UI
-      // change files its artist review whatever its module_key label says. The
-      // NAMED function, not a closure, for the reason removalCandidates gives below;
-      // the arrow only hands it this ship's shared reads.
+      // WHAT THIS SHIP CHANGED (task 1004201): the merged PR's paths. No rule reads
+      // them since TW14, and they cost nothing extra: sharedPrReads memoises the
+      // same two GitHub reads removalCandidates makes. The NAMED function, not a
+      // closure, for the reason removalCandidates gives below; the arrow only hands
+      // it this ship's shared reads.
       changedFiles: (task) => shipFiles.changedFilesForTask(task, pr),
       // WHAT THIS SHIP DELETED (task 1004090 / BV2.R15, ADR 0313). The derivation
       // asks GitHub what the pull request actually changed and blames the deleted