@bongos/core 1.19.1059 → 1.19.1061

package/modules/copy-desk/tests/copy_page_next.mjs

@@ -0,0 +1,184 @@
+// modules/copy-desk/tests/copy_page_next.mjs — the recommendation, pure
+// (task 1004318 / BV2.TW07, ADR 0341 D8).
+//
+// The done-when: the recommendation follows the order on a fixture and skips
+// held pages. The fixture below has a page in every tier and every way a page
+// can be left out:
+//
+//   asked      builders:work (2 askers), landing:privacy (1, the OLDER ask),
+//              builders:tasks (1, the newer ask)
+//   changed    builders:goals (4 lines, alice's pass), status:board (1 line,
+//              bob's pass)
+//   untweaked  landing:index, builders:ideas (an unheld draft, taken over),
+//              status:explore: surface order, though the inventory lists
+//              builders first
+//   tweaked    landing:projects (twice, no drift): last
+//   skipped    builders:studio (held by bob, and asked for), landing:about
+//              (submitted: in flight)
+//
+// "Take next" through the real claim is tests/copy_desk_page_next.mjs (root).
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const pages = require('../pages.js');
+const status = require('../page-status.js');
+const F = require('./fixtures/page-tweak.cjs');
+
+let passed = 0;
+let failed = 0;
+async function test(name, fn) {
+  try { await fn(); passed++; console.log(`  ok  ${name}`); }
+  catch (err) { failed++; console.log(`  FAIL ${name}`); console.log(`     ${err.stack || err.message}`); }
+}
+
+// --- the fixture: F's four pages plus six more -----------------------------
+const page = (id, title) => ({ id, surface: id.split(':')[0], title, path: `/${id.split(':')[1]}`, files: [`${id}.html`] });
+const INVENTORY = {
+  schema: 1,
+  surfaces: F.INVENTORY.surfaces,
+  pages: [
+    ...F.INVENTORY.pages,
+    page('builders:work', 'Work'),
+    page('builders:goals', 'Goals'),
+    page('builders:tasks', 'Tasks'),
+    page('builders:ideas', 'Ideas'),
+    page('landing:privacy', 'Privacy'),
+    page('landing:about', 'About'),
+    page('status:board', 'Board'),
+  ],
+};
+const line = (key, text, placement = 'placed') => ({ key, section: 'body', text, placement });
+const READINGS = {
+  schema: 1,
+  pages: [
+    ...F.READINGS.pages,
+    { id: 'builders:goals', lines: [line('L0001', 'Nav', 'shared'), line('L0002', 'A'), line('L0003', 'W'), line('L0004', 'X'), line('L0005', 'Y'), line('L0006', 'Z')] },
+    { id: 'status:board', lines: [line('L0001', 'One'), line('L0002', 'Two, reworded')] },
+  ],
+};
+const shipped = (id, pageId, n, artist, linesAfter, at) => F.row({
+  id, status: 'shipped', source_ref: pages.roundSourceRef(pageId, n), shipped_at: new Date(at), grade_passed: true,
+  artist_id: artist.id, artist_login: artist.login,
+  description: F.describe({ pageId, submittedAt: at, lines: [{ key: 'L0002', section: 'body', before: 'b', after: 'a' }], appliedAt: at, linesAfter }),
+});
+const TASKS = [
+  ...F.TASKS,
+  shipped('401', 'builders:goals', 1, F.ALICE, ['A', 'B', 'C', 'D', 'E'], '2026-09-10T10:00:00Z'),
+  shipped('402', 'status:board', 1, F.BOB, ['One', 'Two'], '2026-09-11T10:00:00Z'),
+  // An unheld draft: released without submitting. The claim takes it over.
+  F.row({
+    id: '403', status: 'ready', source_ref: pages.roundSourceRef('builders:ideas', 1),
+    description: F.describe({ pageId: 'builders:ideas', submittedAt: '2026-09-20T10:00:00Z', draft: true, lines: [] }),
+  }),
+  // Submitted: a frozen batch, no holder. In flight.
+  F.row({
+    id: '404', status: 'ready', source_ref: pages.roundSourceRef('landing:about', 1),
+    description: F.describe({ pageId: 'landing:about', submittedAt: '2026-09-21T10:00:00Z', lines: [{ key: 'L0002', section: 'body', before: 'x', after: 'y' }] }),
+  }),
+];
+const ASKS = [
+  { page_id: 'builders:work', askers: 2, oldest_ask_at: new Date('2026-09-15T00:00:00Z') },
+  { page_id: 'landing:privacy', askers: 1, oldest_ask_at: new Date('2026-09-01T00:00:00Z') },
+  { page_id: 'builders:tasks', askers: 1, oldest_ask_at: new Date('2026-09-20T00:00:00Z') },
+  { page_id: 'builders:studio', askers: 3, oldest_ask_at: new Date('2026-08-01T00:00:00Z') },
+  { page_id: 'landing:gone', askers: 5, oldest_ask_at: new Date('2026-08-01T00:00:00Z') }, // not in the inventory
+];
+
+const next = (builderId, over = {}) => status.composeNext({ inventory: INVENTORY, readings: READINGS, tasks: TASKS, asks: ASKS, builderId, alternatives: 99, ...over });
+const order = (out) => [out.recommended, ...out.alternatives].filter(Boolean).map((c) => c.page_id);
+
+const EXPECTED = [
+  'builders:work', 'landing:privacy', 'builders:tasks',
+  'builders:goals', 'status:board',
+  'landing:index', 'builders:ideas', 'status:explore',
+  'landing:projects',
+];
+
+await test('the order on the fixture: asked, changed, untweaked (surface order), tweaked last', () => {
+  const out = next(F.ALICE.id);
+  assert.deepEqual(order(out), EXPECTED);
+  assert.deepEqual([...new Set([out.recommended, ...out.alternatives].map((c) => c.tier))], ['asked', 'changed', 'untweaked', 'tweaked']);
+  assert.equal(out.candidates, EXPECTED.length);
+});
+
+await test('held and in-flight pages are never recommended, and are named in skipped', () => {
+  const out = next(F.ALICE.id);
+  assert.ok(!order(out).includes('builders:studio'), 'held by bob, though three people asked for it');
+  assert.ok(!order(out).includes('landing:about'), 'submitted: in flight');
+  assert.deepEqual(out.skipped.map((s) => [s.page_id, s.reason]), [['builders:studio', 'page_held'], ['landing:about', 'page_in_flight']]);
+  assert.deepEqual(out.skipped[0].holder, { id: F.BOB.id, login: 'bob' });
+  assert.equal(out.skipped[1].state, 'submitted');
+  assert.equal(out.resume, null);
+});
+
+await test("the caller's own held page is Resume, not a recommendation", () => {
+  const out = next(F.BOB.id);
+  assert.equal(out.resume.page_id, 'builders:studio');
+  assert.equal(out.resume.task_id, '202');
+  assert.equal(out.resume.take.path, '/copy-desk/pages/builders:studio/claim');
+  assert.ok(!order(out).includes('builders:studio'));
+  assert.ok(!out.skipped.some((s) => s.page_id === 'builders:studio'));
+});
+
+await test("the caller's own CLI claim (applying) is in flight, not Resume", () => {
+  const tasks = TASKS.map((t) => (t.id === '202' ? { ...t, holder_worktree: true } : t));
+  const out = next(F.BOB.id, { tasks });
+  assert.equal(out.resume, null);
+  assert.deepEqual(out.skipped.find((s) => s.page_id === 'builders:studio').reason, 'page_in_flight');
+});
+
+await test('each candidate carries its why, in the mock\'s words', () => {
+  const out = next(F.ALICE.id);
+  const by = (id) => [out.recommended, ...out.alternatives].find((c) => c.page_id === id);
+  assert.equal(out.recommended.why, '2 people asked for it');
+  assert.equal(out.recommended.why_line, 'builders hall · 2 people asked for it · untweaked');
+  assert.equal(by('landing:privacy').why_line, 'landing · 1 person asked for it · untweaked');
+  assert.equal(by('builders:goals').why, '4 lines changed since your last pass', 'alice made the last pass');
+  assert.equal(by('builders:goals').changed_lines, 4, 'shared lines never count');
+  assert.equal(by('status:board').why, '1 line changed since the last pass', 'bob made it, not the caller');
+  assert.equal(by('status:explore').why_line, 'status · untweaked');
+  assert.equal(by('landing:projects').why, 'text tweaked 2x, nothing changed since');
+  assert.equal(by('builders:ideas').draft_round.task_id, '403', 'the draft the claim takes over is named');
+  assert.equal(out.recommended.take.path, '/copy-desk/pages/builders:work/claim');
+});
+
+await test('ties: more askers first, then the oldest ask; more changed lines first', () => {
+  const asks = [
+    { page_id: 'landing:privacy', askers: 1, oldest_ask_at: new Date('2026-09-25T00:00:00Z') },
+    { page_id: 'builders:tasks', askers: 1, oldest_ask_at: new Date('2026-09-02T00:00:00Z') },
+  ];
+  assert.deepEqual(order(next(F.ALICE.id, { asks })).slice(0, 2), ['builders:tasks', 'landing:privacy'], 'oldest ask wins the tie');
+  const more = [{ page_id: 'builders:tasks', askers: 3, oldest_ask_at: new Date('2026-09-26T00:00:00Z') }, ...asks];
+  assert.equal(next(F.ALICE.id, { asks: more }).recommended.page_id, 'builders:tasks');
+});
+
+await test('asked_pages counts every inventory page with an open ask, held ones too', () => {
+  assert.equal(next(F.ALICE.id).asked_pages, 4);
+});
+
+await test('pick another: the next few, four by default', () => {
+  const out = status.composeNext({ inventory: INVENTORY, readings: READINGS, tasks: TASKS, asks: ASKS, builderId: F.ALICE.id });
+  assert.equal(out.alternatives.length, status.NEXT_ALTERNATIVES);
+  assert.equal(status.NEXT_ALTERNATIVES, 4);
+  assert.deepEqual(order(out), EXPECTED.slice(0, 5));
+});
+
+await test('no readings: drift is unknown, so no page is "changed", and tweaked pages sort last', () => {
+  const out = next(F.ALICE.id, { readings: null });
+  assert.ok(![out.recommended, ...out.alternatives].some((c) => c.tier === 'changed'));
+  assert.deepEqual(order(out).slice(-3), ['landing:projects', 'builders:goals', 'status:board']);
+  assert.equal(out.alternatives.find((c) => c.page_id === 'builders:goals').why, 'text tweaked 1x');
+});
+
+await test('nothing left to take: recommended is null, never a held page', () => {
+  const inventory = { ...INVENTORY, pages: INVENTORY.pages.filter((p) => ['builders:studio', 'landing:about'].includes(p.id)) };
+  const out = next(F.ALICE.id, { inventory });
+  assert.equal(out.recommended, null);
+  assert.deepEqual(out.alternatives, []);
+  assert.equal(out.skipped.length, 2);
+});
+
+console.log(`\ncopy_page_next: ${passed} passed, ${failed} failed`);
+if (failed) process.exit(1);

package/modules/lifecycle/lifecycle.js

@@ -26,6 +26,7 @@ const activity = require('./activity');
 const mingle = require('./mingle');
 const pageTweakReads = require('./page-tweak-reads');
 const pageTweakClaim = require('./page-tweak-claim');
+const pageTweakWrite = require('./page-tweak-write');
 
 module.exports = {
   // --- retired doorway leaks (ADR 0093 §3) ---------------------------------
@@ -118,6 +119,13 @@ module.exports = {
   // it is page-shaped because the find-or-create has to share the claim's
   // transaction. See modules/lifecycle/page-tweak-claim.js.
   webClaimPageTweak: (...a) => pageTweakClaim.webClaimPageTweak(...a),
+  // The page draft's autosave and the submit (task 1004319 / BV2.TW08, ADR 0341
+  // D4, D11): a holder-guarded description write that skips an unchanged save,
+  // and the submit's one transaction (engineer tasks for unplaced lines, the
+  // frozen batch, the web claim released, the round back to ready). D11 names
+  // updateTaskDescription and releaseClaim; see modules/lifecycle/page-tweak-write.js.
+  updateHeldTaskDescription: (...a) => pageTweakWrite.updateHeldTaskDescription(...a),
+  submitPageTweak: (...a) => pageTweakWrite.submitPageTweak(...a),
   listVersions: (...a) => db.listVersions(...a),
   versionProgress: (...a) => db.versionProgress(...a),
   recentShippedTasks: (...a) => db.recentShippedTasks(...a),

package/modules/lifecycle/page-tweak-reads.js

@@ -37,10 +37,17 @@ const api = require('../../src/module-api');
 //     per task), joined once, rather than a correlated subquery per task:
 //     claims has no full index on task_id, so a per-row LATERAL would scan it
 //     once per round.
-async function listPageTweakTasks() {
+//
+// `pageId` narrows it to ONE page's rounds (task 1004319 / TW08): the draft
+// autosave runs this on every debounced save, and a page's rounds are a handful
+// while the instance's grow without bound. The prefix is matched with left(),
+// not LIKE, the page claim's own rule (an `_` in an id is never a wildcard).
+async function listPageTweakTasks({ pageId = null } = {}) {
+  const prefix = pageId ? `page-tweak/${pageId}/` : null;
   const { rows } = await api.pool.query(
     `WITH pt AS (
        SELECT t.id FROM tasks t WHERE t.source = 'page-tweak'
+          AND ($1::text IS NULL OR left(t.source_ref, length($1::text)) = $1::text)
      ), web AS (
        SELECT DISTINCT ON (c.task_id) c.task_id, c.builder_id
          FROM claims c JOIN pt ON pt.id = c.task_id
@@ -60,7 +67,9 @@ async function listPageTweakTasks() {
        LEFT JOIN web wc ON wc.task_id = t.id
        LEFT JOIN builders ab ON ab.id = wc.builder_id
       WHERE t.source = 'page-tweak'
-      ORDER BY t.id ASC`
+        AND ($1::text IS NULL OR left(t.source_ref, length($1::text)) = $1::text)
+      ORDER BY t.id ASC`,
+    [prefix]
   );
   return rows;
 }

package/modules/lifecycle/page-tweak-write.js

@@ -0,0 +1,192 @@
+// modules/lifecycle/page-tweak-write.js — the page draft save and the submit
+// (task 1004319 / BV2.TW08, ADR 0341 D4, D7, D11).
+//
+// On the `lifecycle` port because tasks and claims are this module's tables and
+// copy-desk may only cross the wall through a port (ADR 0083, ADR 0093 §2). What
+// the draft and the batch SAY (the fenced blocks, the resolution against the page
+// reading, the engineer task an unplaced line files) is copy-desk's and is handed
+// in as a function; the transaction and the holder check are lifecycle's.
+//
+// BOTH ARE HOLDER-ONLY. The caller must hold the task's open WEB claim
+// (worktree_name NULL and creator_session_id NULL, the claim the page claim
+// takes). The check runs inside the transaction, after the task row is locked
+// FOR UPDATE, the same lock claimTask and the page claim take, so a save cannot
+// interleave with a claim or a release of the same round.
+//
+// AN AUTOSAVE THAT CHANGES NOTHING WRITES NOTHING. The editor autosaves often
+// (it debounces; the server accepts a whole-draft replace). When the composed
+// description equals the stored one, the transaction ends without an UPDATE, so
+// `updated_at` and every reader that sorts by it stay where they were.
+//
+// ADR 0341 D11 names the port entries updateTaskDescription, webClaimTask and
+// releaseClaim. They landed page-shaped, as TW06's webClaimPageTweak did: the
+// description update is holder-guarded (updateHeldTaskDescription, so no caller
+// can rewrite a task it does not hold through the port), and the release runs
+// INSIDE the submit's transaction (submitPageTweak), because the batch, the
+// engineer tasks and the release must commit together or not at all.
+//
+// Outcomes are returned, not thrown, so the route maps each to a named answer:
+//   saved | unchanged | submitted
+//   not_found      no such task
+//   wrong_source   the task is not of the source the caller named
+//   not_held       the caller does not hold its open web claim (holder named)
+//   refused        copy-desk's function refused (its refusal is passed back)
+
+'use strict';
+
+const api = require('../../src/module-api');
+const db = require('./db');
+
+function activePoolFor(deps) {
+  return (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : api.pool;
+}
+
+// Lock the task, then read its open claim. Returns { task, claim } or an outcome.
+async function lockHeld(client, { taskId, builderId, source }) {
+  const { rows } = await client.query(
+    `SELECT id, status, title, description, source, source_ref, version_id, goal_id, touches
+       FROM tasks WHERE id = $1 FOR UPDATE`,
+    [taskId]
+  );
+  const task = rows[0];
+  if (!task) return { outcome: 'not_found' };
+  if (source && task.source !== source) return { outcome: 'wrong_source', task };
+  const { rows: held } = await client.query(
+    `SELECT c.id, c.builder_id, c.worktree_name, c.creator_session_id, b.github_login, b.display_name
+       FROM claims c JOIN builders b ON b.id = c.builder_id
+      WHERE c.task_id = $1 AND c.released_at IS NULL
+      LIMIT 1`,
+    [taskId]
+  );
+  const claim = held[0] || null;
+  const web = !!claim && claim.worktree_name == null && claim.creator_session_id == null;
+  if (!claim || !web || String(claim.builder_id) !== String(builderId)) {
+    return {
+      outcome: 'not_held',
+      task,
+      holder: claim ? { id: String(claim.builder_id), login: claim.github_login || null, name: claim.display_name || null, writing: web } : null,
+    };
+  }
+  return { task, claim };
+}
+
+// updateHeldTaskDescription({ taskId, builderId, source, compose }, deps)
+//
+//   compose(task) -> { ok: true, description } | { ok: false, code, detail }
+//
+// The page draft's autosave (PUT /copy-desk/pages/:pageId/draft). Writes the
+// composed description when it differs from the stored one.
+async function updateHeldTaskDescription({ taskId, builderId, source = null, compose }, deps = {}) {
+  const client = await activePoolFor(deps).connect();
+  try {
+    await client.query('BEGIN');
+    const held = await lockHeld(client, { taskId, builderId, source });
+    if (held.outcome) { await client.query('ROLLBACK'); return held; }
+    const r = compose(held.task);
+    if (!r || !r.ok) { await client.query('ROLLBACK'); return { outcome: 'refused', refusal: r, task: held.task }; }
+    if (r.description === held.task.description) {
+      await client.query('ROLLBACK');
+      return { outcome: 'unchanged', task: held.task };
+    }
+    const { rows } = await client.query(
+      `UPDATE tasks SET description = $2, updated_at = now() WHERE id = $1
+       RETURNING id, status, description, source_ref, updated_at`,
+      [taskId, r.description]
+    );
+    await client.query('COMMIT');
+    return { outcome: 'saved', task: rows[0] };
+  } catch (err) {
+    await client.query('ROLLBACK').catch(() => {});
+    throw err;
+  } finally {
+    client.release();
+  }
+}
+
+// submitPageTweak({ taskId, builderId, versionId, freeze }, deps)
+//
+//   freeze(task) -> { ok: true, unplaced: [{ sourceRef, title, description, touches }],
+//                     description(unplacedTaskIds) -> string }
+//                 | { ok: false, code, detail }
+//
+// The submit (POST /copy-desk/pages/:pageId/submit), one transaction:
+//   1. each unplaced rewrite files its engineer task (source page-tweak-unplaced,
+//      backlog, engineer), or finds the one its source ref already filed;
+//   2. the description gains the frozen `page-tweak` block naming those tasks;
+//   3. the artist's web claim is RELEASED (outcome 'partial': their part is done
+//      and the task goes on) and the task returns to `ready`, so the round reads
+//      `submitted` and sits in the /tweak queue (ADR 0341 D7).
+// The released claim is the one the payee rule reads (ADR 0341 D10).
+async function submitPageTweak({ taskId, builderId, versionId = null, freeze }, deps = {}) {
+  const createTask = deps.createTask || db.createTask;
+  const client = await activePoolFor(deps).connect();
+  try {
+    await client.query('BEGIN');
+    const held = await lockHeld(client, { taskId, builderId, source: 'page-tweak' });
+    if (held.outcome) { await client.query('ROLLBACK'); return held; }
+    const plan = freeze(held.task);
+    if (!plan || !plan.ok) { await client.query('ROLLBACK'); return { outcome: 'refused', refusal: plan, task: held.task }; }
+
+    // The engineer tasks an earlier submit of this round already filed, in ONE
+    // read (a resubmit after a send-back finds them). Only the missing ones go
+    // through createTask, the single create chokepoint, one at a time.
+    const wanted = plan.unplaced || [];
+    const existing = new Map();
+    if (wanted.length) {
+      const { rows: found } = await client.query(
+        'SELECT id, source_ref FROM tasks WHERE source = $1 AND source_ref = ANY($2::text[])',
+        [wanted[0].source, wanted.map((u) => u.sourceRef)]
+      );
+      for (const f of found) if (!existing.has(f.source_ref)) existing.set(f.source_ref, String(f.id));
+    }
+    const filed = [];
+    for (const u of wanted) {
+      if (existing.has(u.sourceRef)) { filed.push({ id: existing.get(u.sourceRef), key: u.key, created: false }); continue; }
+      const t = await createTask({
+        versionId: versionId != null ? versionId : held.task.version_id,
+        // The building version's catch-all goal, declared out loud (BV1.R11),
+        // exactly as the round itself and a copy proposal land.
+        allowCatchAll: true,
+        title: u.title,
+        description: u.description,
+        // BACKLOG (ADR 0341 D4): an engineer's triage decides when, and the
+        // page does not wait for it.
+        status: 'backlog',
+        kind: 'feature',
+        discipline: 'engineer',
+        priority: 4,
+        touches: u.touches || [],
+        source: u.source,
+        sourceRef: u.sourceRef,
+        createdBy: builderId,
+      }, { client });
+      filed.push({ id: String(t.id), key: u.key, created: true });
+    }
+
+    const description = plan.description(filed.map((f) => f.id));
+    const { rows } = await client.query(
+      `UPDATE tasks SET description = $2, status = 'ready', updated_at = now() WHERE id = $1
+       RETURNING id, status, description, source_ref, updated_at`,
+      [taskId, description]
+    );
+    await releaseClaim(client, held.claim.id);
+    await client.query('COMMIT');
+    return { outcome: 'submitted', task: rows[0], unplaced_tasks: filed, released_claim_id: String(held.claim.id) };
+  } catch (err) {
+    await client.query('ROLLBACK').catch(() => {});
+    throw err;
+  } finally {
+    client.release();
+  }
+}
+
+// Release one claim inside the caller's transaction. The task's status is the
+// caller's to set (the submit sets `ready` with the same UPDATE as the batch).
+async function releaseClaim(client, claimId, outcome = 'partial') {
+  await client.query(
+    'UPDATE claims SET released_at = now(), outcome = $2 WHERE id = $1 AND released_at IS NULL',
+    [claimId, outcome]
+  );
+}
+
+module.exports = { updateHeldTaskDescription, submitPageTweak };

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1059",
+  "version": "1.19.1061",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.1059",
+      "version": "1.19.1061",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1059",
+  "version": "1.19.1061",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -7655,5 +7655,17 @@
       "id": "1004317",
       "text": "An artist can now claim a whole page to rewrite in one step. If the page has no open round, one is created for them. If someone else is already on it, they are told who. Anyone, artist or not, can ask for a page to be worked o"
     }
+  ],
+  "1.19.1060": [
+    {
+      "id": "1004318",
+      "text": "An artist can now ask \"what should I tweak next?\" and get one page back, with the reason in plain words, such as \"2 people asked for it\". Pages people asked for come first, then pages whose words changed since their last tweak"
+    }
+  ],
+  "1.19.1061": [
+    {
+      "id": "1004319",
+      "text": "An artist's page rewrite is now saved as they type and can be submitted. The draft rests on the page's own tweak task, and saving the same words again changes nothing. Submitting freezes the rewrite for a /tweak session to app"
+    }
   ]
 }

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.1059'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.1061'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/copy_desk_flags_db.mjs

@@ -285,6 +285,18 @@ await test('resolvePageAsks closes the open asks filed before the ship, stamped
   assert.equal(await flagsLib.countPageAskers(SURF), 0);
 });
 
+// The recommendation's read (task 1004318 / TW07): one grouped row per page
+// with an open ask, distinct askers and the oldest open ask.
+await test('pageAskSummary groups open asks by page: distinct askers, the oldest ask', async () => {
+  assert.equal((await flagsLib.pageAskSummary()).some((r) => r.page_id === SURF), false, 'resolved asks are not counted');
+  const first = (await pageIns({ by: B })).rows[0];
+  await pool.query("UPDATE copy_desk_flags SET flagged_at = now() - interval '2 days' WHERE id = $1", [first.id]);
+  await pageIns({ by: A });
+  const row = (await flagsLib.pageAskSummary()).find((r) => r.page_id === SURF);
+  assert.equal(row.askers, 2);
+  assert.equal(new Date(row.oldest_ask_at).getTime(), new Date((await pool.query('SELECT flagged_at FROM copy_desk_flags WHERE id = $1', [first.id])).rows[0].flagged_at).getTime());
+});
+
 // --- cleanup --------------------------------------------------------------
 await clean();
 await pool.query('DELETE FROM builders WHERE id = ANY($1)', [[A, B]]).catch(() => {});

package/tests/copy_desk_page_claim.mjs

@@ -18,140 +18,25 @@ import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
 import { makeRunner } from './helpers.mjs';
+import { installPageLedger } from './fixtures/page-ledger.mjs';
 
 process.env.NODE_ENV = 'test';
 const require = createRequire(import.meta.url);
 const F = require('../modules/copy-desk/tests/fixtures/page-tweak.cjs');
 const api = require('../src/module-api.js');
 
-// --- the ledger -------------------------------------------------------------
-const db = {
-  builders: new Map([
-    ['7', { id: '7', status: 'active', github_login: 'alice', display_name: 'Alice', preferred_disciplines: ['artist'] }],
-    ['8', { id: '8', status: 'active', github_login: 'bob', display_name: 'Bob', preferred_disciplines: ['engineer', 'artist'] }],
-    ['9', { id: '9', status: 'active', github_login: 'carol', display_name: 'Carol', preferred_disciplines: ['engineer'] }],
-  ]),
-  tasks: [],
-  claims: [],
-  flags: [],
-  seq: { task: 5000, claim: 9000, flag: 100 },
-  building: true,
-};
+// --- the ledger: the shared stateful fake (tests/fixtures/page-ledger.mjs) ---
+const { db, seen } = installPageLedger(api, {
+  builders: [
+    { id: '7', github_login: 'alice', display_name: 'Alice', preferred_disciplines: ['artist'] },
+    { id: '8', github_login: 'bob', display_name: 'Bob', preferred_disciplines: ['engineer', 'artist'] },
+    { id: '9', github_login: 'carol', display_name: 'Carol', preferred_disciplines: ['engineer'] },
+  ],
+});
 const ALICE = '7';
 const BOB = '8';
 const CAROL = '9';
 
-// The advisory lock, as a mutex per key: a second locker waits until the first
-// commits or rolls back. That is what makes the race case below a real race.
-const locks = new Map();
-async function lock(key, owner) {
-  while (locks.has(key)) await locks.get(key).done;
-  let release;
-  const done = new Promise((r) => { release = r; });
-  locks.set(key, { owner, done, release });
-}
-function unlockAll(owner) {
-  for (const [k, v] of [...locks]) if (v.owner === owner) { locks.delete(k); v.release(); }
-}
-
-const flat = (sql) => String(sql).replace(/\s+/g, ' ').trim();
-const seen = [];
-let clientSeq = 0;
-
-async function answer(q, p, owner) {
-  seen.push(q);
-  // Yield on every statement, so two concurrent requests really interleave:
-  // without the page lock, both would read "no open round" and both create.
-  await new Promise((r) => setImmediate(r));
-  if (/^(BEGIN|COMMIT|ROLLBACK)$/.test(q)) {
-    if (q !== 'BEGIN') unlockAll(owner);
-    return { rows: [] };
-  }
-  if (/pg_advisory_xact_lock\(hashtext\(\$1\)\)/.test(q)) {
-    assert.ok(owner, 'the page lock must be taken on the transaction client');
-    await lock(p[0], owner);
-    return { rows: [] };
-  }
-  if (/^SELECT id, status, github_login, display_name FROM builders WHERE id = \$1/.test(q)) {
-    const b = db.builders.get(String(p[0]));
-    return { rows: b ? [b] : [] };
-  }
-  if (/^SELECT preferred_disciplines FROM builders WHERE id = \$1/.test(q)) {
-    const b = db.builders.get(String(p[0]));
-    return { rows: b ? [{ preferred_disciplines: b.preferred_disciplines }] : [] };
-  }
-  if (/FROM tasks WHERE source = \$1 AND left\(source_ref, length\(\$2\)\) = \$2 ORDER BY id ASC FOR UPDATE/.test(q)) {
-    return { rows: db.tasks.filter((t) => t.source === p[0] && String(t.source_ref).startsWith(p[1])).map((t) => ({ ...t })) };
-  }
-  if (/FROM claims c JOIN builders b ON b\.id = c\.builder_id WHERE c\.task_id = \$1 AND c\.released_at IS NULL/.test(q)) {
-    const c = db.claims.find((x) => String(x.task_id) === String(p[0]) && x.released_at == null);
-    if (!c) return { rows: [] };
-    const b = db.builders.get(String(c.builder_id));
-    return { rows: [{ ...c, github_login: b.github_login, display_name: b.display_name }] };
-  }
-  if (/^INSERT INTO claims \(task_id, builder_id, worktree_name, requested_worktree_name, head_sha, creator_session_id\) VALUES \(\$1, \$2, NULL, NULL, NULL, NULL\)/.test(q)) {
-    if (db.claims.some((x) => String(x.task_id) === String(p[0]) && x.released_at == null)) {
-      throw Object.assign(new Error('duplicate key'), { code: '23505', constraint: 'uniq_active_claim_per_task' });
-    }
-    const c = { id: String(++db.seq.claim), task_id: String(p[0]), builder_id: String(p[1]), worktree_name: null, creator_session_id: null, claimed_at: new Date().toISOString(), released_at: null };
-    db.claims.push(c);
-    return { rows: [{ ...c }] };
-  }
-  if (/^UPDATE tasks SET status = 'active', updated_at = now\(\) WHERE id = \$1/.test(q)) {
-    db.tasks.find((t) => String(t.id) === String(p[0])).status = 'active';
-    return { rows: [] };
-  }
-  // createTask's reads: the catch-all goal of the version, and its scope.
-  if (/FROM goals g JOIN versions v ON v\.id = g\.version_id WHERE g\.version_id = \$1 AND g\.title = \$2/.test(q)) {
-    return { rows: [{ id: '77', version_status: 'building' }] };
-  }
-  if (/^SELECT scope_modules FROM goals WHERE id = \$1/.test(q)) return { rows: [{ scope_modules: [] }] };
-  if (/^INSERT INTO tasks \(version_id, title, description, status, touches,/.test(q)) {
-    assert.ok(owner, 'the round must be created inside the claim transaction');
-    const t = {
-      id: String(++db.seq.task), version_id: p[0], title: p[1], description: p[2], status: p[3], touches: p[4],
-      credits_reward: p[10], source: p[11], source_ref: p[12], kind: p[14], discipline: p[15], requires_rank: p[20], goal_id: p[22], created_by: p[23],
-    };
-    db.tasks.push(t);
-    return { rows: [{ ...t }] };
-  }
-  if (/^SELECT id, name, status, scope_doc_path, started_at, shipped_at, done_when FROM versions/.test(q)) {
-    return { rows: db.building ? [{ id: 'V9', name: 'V9', status: 'building' }] : [{ id: 'V8', name: 'V8', status: 'shipped' }] };
-  }
-  // The flag SQL (the page ask).
-  if (/FROM copy_desk_flags f WHERE f\.scope = 'page' AND f\.page_id = \$1 AND f\.flagged_by = \$2 AND f\.status = 'open'/.test(q)) {
-    return { rows: db.flags.filter((x) => x.scope === 'page' && x.page_id === p[0] && String(x.flagged_by) === String(p[1]) && x.status === 'open').slice(0, 1) };
-  }
-  if (/^INSERT INTO copy_desk_flags/.test(q)) {
-    const [scope, surface, stringId, reason, kind, , , , , by, pageId] = p;
-    // The CHECKs of copy_desk_002, so the fake refuses what Postgres would.
-    assert.equal((scope === 'page'), (pageId != null), 'copy_desk_flags_target_chk');
-    if (scope === 'page') assert.equal(surface, pageId, 'copy_desk_flags_page_surface_chk');
-    const dup = db.flags.find((x) => x.status === 'open' && String(x.flagged_by) === String(by) && x.surface === surface && (x.string_id || '') === (stringId || ''));
-    if (dup) throw Object.assign(new Error('dup'), { code: '23505' });
-    const row = { id: String(++db.seq.flag), scope, surface, string_id: stringId, page_id: pageId, reason, kind, flagged_by: String(by), flagged_at: new Date().toISOString(), status: 'open' };
-    db.flags.push(row);
-    return { rows: [{ ...row }] };
-  }
-  if (/COUNT\(DISTINCT flagged_by\)::int AS askers FROM copy_desk_flags WHERE scope = 'page' AND page_id = \$1 AND status = 'open'/.test(q)) {
-    return { rows: [{ askers: new Set(db.flags.filter((x) => x.scope === 'page' && x.page_id === p[0] && x.status === 'open').map((x) => x.flagged_by)).size }] };
-  }
-  if (/^UPDATE copy_desk_flags SET status = 'resolved', resolved_task_id = \$2, resolved_by = \$3/.test(q)) {
-    const hit = db.flags.filter((x) => x.scope === 'page' && x.page_id === p[0] && x.status === 'open' && new Date(x.flagged_at) <= new Date(p[3]));
-    for (const x of hit) Object.assign(x, { status: 'resolved', resolved_task_id: String(p[1]), resolved_by: String(p[2]), resolution_note: p[4] });
-    return { rows: hit.map((x) => ({ id: x.id })) };
-  }
-  throw new Error(`unexpected SQL: ${q.slice(0, 160)}`);
-}
-
-api.pool = {
-  query: (sql, params = []) => answer(flat(sql), params, null),
-  async connect() {
-    const owner = ++clientSeq;
-    return { query: (sql, params = []) => answer(flat(sql), params, owner), release() { unlockAll(owner); } };
-  },
-};
-
 api.requireBuilder = (req, res, next) => {
   req.builder = { id: String(req.headers['x-builder'] || ALICE), rank: 'metic' };
   next();