@bongos/core 1.19.1057 → 1.19.1059

package/modules/lifecycle/page-tweak-claim.js

@@ -0,0 +1,184 @@
+// modules/lifecycle/page-tweak-claim.js — the page claim: find or create a page's
+// open tweak round and WEB-claim it, in one transaction (task 1004317 / BV2.TW06,
+// ADR 0341 D2 and D5).
+//
+// On the `lifecycle` port because tasks and claims are this module's tables and
+// copy-desk may only cross the wall through a port (ADR 0083, ADR 0093 §2). What
+// a round IS (its source ref, title, body, and which unheld rounds a writer may
+// take over) is copy-desk's, and is handed in; the transaction is lifecycle's.
+//
+// THE LOCK. Everything runs under pg_advisory_xact_lock(hashtext('page-tweak/' ||
+// page_id)), so two artists claiming the same page serialise: the second reads
+// the round the first created, and is refused `held` naming the first. The page's
+// existing rounds are also read FOR UPDATE, which is the lock every other claim
+// path takes (claimTask), so a CLI claim of the same task cannot interleave.
+//
+// A WEB CLAIM (ADR 0341 D5): worktree_name NULL and creator_session_id NULL, the
+// bind_session=false claim the hall's Claim button already takes. Migration
+// core_204's one-bound-claim-per-(session, worktree) index excludes NULL sessions,
+// so a web claim never collides with the artist's CLI work, and the reads
+// (page-tweak-reads.js) recognise it by exactly those two NULLs.
+//
+// WHAT THIS DOES NOT RUN, and why. claimTask's gates are for a builder taking
+// CODE work into a worktree: the rank floor, goal membership, the owed-rebase
+// gate, dependency and touches checks. A page round is not that. Its one gate is
+// the craft (ADR 0341 D5: `builders.preferred_disciplines` includes artist, read
+// here through help-requests' own reader, never from the request), plus the
+// inactive-builder refusal every claim carries. The round has no rank floor
+// (D2), no dependencies, and its applier later takes an ordinary CLI claim
+// through claimTask with every gate intact.
+//
+// Outcomes are returned, not thrown, so the route maps each to its named answer:
+//   created | claimed | resumed        the caller now holds the round (writing)
+//   held          another builder holds it (holder named)
+//   in_flight     the round is past writing (submitted, applying, waiting for
+//                 the artist, landing), so a writing claim would pull it back
+//   not_an_artist / builder_inactive / no_open_version
+
+'use strict';
+
+const api = require('../../src/module-api');
+const db = require('./db');
+const helpRequests = require('./help-requests');
+
+const SOURCE = 'page-tweak';
+const TERMINAL = Object.freeze(['shipped', 'abandoned']);
+
+function lockKey(pageId) { return `${SOURCE}/${pageId}`; }
+
+// The claim projection the route answers with.
+const CLAIM_COLS = 'id, task_id, builder_id, worktree_name, creator_session_id, claimed_at';
+
+async function insertWebClaim(client, taskId, builderId) {
+  const { rows } = await client.query(
+    `INSERT INTO claims (task_id, builder_id, worktree_name, requested_worktree_name, head_sha, creator_session_id)
+     VALUES ($1, $2, NULL, NULL, NULL, NULL)
+     RETURNING ${CLAIM_COLS}`,
+    [taskId, builderId]
+  );
+  await client.query(`UPDATE tasks SET status = 'active', updated_at = now() WHERE id = $1`, [taskId]);
+  return rows[0];
+}
+
+// 'page-tweak/landing:index/r2' -> 2 (0 when the ref carries no round).
+function roundNumber(sourceRef) {
+  const m = /\/r([1-9][0-9]*)$/.exec(String(sourceRef || ''));
+  return m ? Number(m[1]) : 0;
+}
+
+// webClaimPageTweak({ pageId, builderId, versionId, round }, deps)
+//
+//   round.title(n), round.description(n), round.sourceRef(n)   copy-desk's format
+//   round.touches, round.creditsReward
+//   round.canTakeOver(task)   may a writer take over this UNHELD open round?
+//   versionId                 where a NEW round lands (null: nothing is building)
+//
+// deps.pool is honoured only under NODE_ENV=test (the #538 test seam).
+async function webClaimPageTweak({ pageId, builderId, versionId = null, round }, deps = {}) {
+  const activePool = (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : api.pool;
+  const createTask = deps.createTask || db.createTask;
+  const prefix = `${SOURCE}/${pageId}/`;
+  const client = await activePool.connect();
+  try {
+    await client.query('BEGIN');
+    await client.query('SELECT pg_advisory_xact_lock(hashtext($1))', [lockKey(pageId)]);
+
+    const { rows: builderRows } = await client.query(
+      'SELECT id, status, github_login, display_name FROM builders WHERE id = $1', [builderId]
+    );
+    if (!builderRows[0] || builderRows[0].status === 'inactive') {
+      await client.query('ROLLBACK');
+      return { outcome: 'builder_inactive' };
+    }
+    const crafts = await helpRequests.craftsForBuilder(builderId, { pool: client });
+    if (!crafts.includes('artist')) {
+      await client.query('ROLLBACK');
+      return { outcome: 'not_an_artist' };
+    }
+
+    // Every round of this page, oldest first. `left(...) = prefix` rather than
+    // LIKE: a page id is [a-z0-9-:], and LIKE would read an `_` as a wildcard
+    // the day the id rule widens.
+    const { rows: rounds } = await client.query(
+      `SELECT id, status, title, description, source_ref, touches, credits_reward, goal_id, version_id
+         FROM tasks
+        WHERE source = $1 AND left(source_ref, length($2)) = $2
+        ORDER BY id ASC
+        FOR UPDATE`,
+      [SOURCE, prefix]
+    );
+    const open = [...rounds].reverse().find((t) => !TERMINAL.includes(t.status)) || null;
+
+    if (open) {
+      const { rows: held } = await client.query(
+        `SELECT c.${CLAIM_COLS.split(', ').join(', c.')}, b.github_login, b.display_name
+           FROM claims c JOIN builders b ON b.id = c.builder_id
+          WHERE c.task_id = $1 AND c.released_at IS NULL
+          LIMIT 1`,
+        [open.id]
+      );
+      const claim = held[0] || null;
+      const roundNo = roundNumber(open.source_ref);
+      if (claim) {
+        const web = claim.worktree_name == null && claim.creator_session_id == null;
+        if (String(claim.builder_id) !== String(builderId)) {
+          await client.query('ROLLBACK');
+          return {
+            outcome: 'held',
+            task: open,
+            round: roundNo,
+            holder: { id: String(claim.builder_id), login: claim.github_login || null, name: claim.display_name || null },
+            holder_is_writing: web,
+          };
+        }
+        await client.query('ROLLBACK');
+        // The caller's own web claim is Resume. Their own CLI claim means they
+        // are APPLYING this round (a self-applied tweak): not writing it.
+        return web
+          ? { outcome: 'resumed', task: open, round: roundNo, claim }
+          : { outcome: 'in_flight', task: open, round: roundNo, status: open.status };
+      }
+      if (!round.canTakeOver(open)) {
+        await client.query('ROLLBACK');
+        return { outcome: 'in_flight', task: open, round: roundNo, status: open.status };
+      }
+      const taken = await insertWebClaim(client, open.id, builderId);
+      await client.query('COMMIT');
+      return { outcome: 'claimed', task: { ...open, status: 'active' }, round: roundNo, claim: taken };
+    }
+
+    if (versionId == null) {
+      await client.query('ROLLBACK');
+      return { outcome: 'no_open_version' };
+    }
+    // n = one plus the earlier rounds, whatever their status (ADR 0341 D2); the
+    // max guards the never-repeat rule if a round row was ever removed.
+    const n = Math.max(rounds.length, ...rounds.map((t) => roundNumber(t.source_ref))) + 1;
+    const task = await createTask({
+      versionId,
+      // ADR 0341 D2: a round lands in the building version's catch-all goal,
+      // exactly as a copy proposal does. Declared out loud (BV1.R11).
+      allowCatchAll: true,
+      title: round.title(n),
+      description: round.description(n),
+      status: 'ready',
+      kind: 'feature',
+      discipline: 'artist',
+      creditsReward: round.creditsReward,
+      touches: round.touches,
+      source: SOURCE,
+      sourceRef: round.sourceRef(n),
+      createdBy: builderId,
+    }, { client });
+    const claim = await insertWebClaim(client, task.id, builderId);
+    await client.query('COMMIT');
+    return { outcome: 'created', task: { ...task, status: 'active' }, round: n, claim };
+  } catch (err) {
+    await client.query('ROLLBACK').catch(() => {});
+    throw err;
+  } finally {
+    client.release();
+  }
+}
+
+module.exports = { webClaimPageTweak, lockKey, roundNumber };

package/modules/lifecycle/page-tweak-reads.js

@@ -0,0 +1,87 @@
+// modules/lifecycle/page-tweak-reads.js — the two ledger reads Tweak Mode's
+// status, changelog, drift and tally are derived from (task 1004316 / BV2.TW05,
+// ADR 0341 D7, D8, D10). Read-only; no state transition lives here.
+//
+// On the `lifecycle` port because tasks and claims are this module's tables and
+// copy-desk may only cross the wall through a port (ADR 0083, ADR 0093 §2). The
+// derivation itself is copy-desk's (modules/copy-desk/page-status.js); these
+// return the rows it reads, column for column, with no projection in between,
+// so a field added here reaches the derivation without a second mapper to
+// forget.
+
+'use strict';
+
+const api = require('../../src/module-api');
+
+// Every page-tweak task, oldest first, with what the round state (D7) and the
+// changelog (D8) need beside the task itself:
+//
+//   grade_passed      the task's grade (task_grades holds one row per task, the
+//                     latest). A completed round with a passed grade is waiting
+//                     for the artist; with a failed one it is still applying.
+//   holder_*          the ACTIVE claim, if any. holder_worktree is true for a CLI
+//                     claim (a worktree: the applier) and false for a web claim
+//                     (bind_session=false, no worktree: the artist writing).
+//   artist_*          the round's artist, the payee rule of D10: the builder of
+//                     the latest WEB claim on the task, which is the one the
+//                     submit released. Never a field in the description, which
+//                     the task's editors could change.
+//
+// THE QUERY PLAN, since this read backs all three page routes:
+//   * `t.source = 'page-tweak'` is served by idx_tasks_source_ref, which leads
+//     on (source) (migrations/core_240_artist_gate_indexes.sql), so the scan is
+//     bounded to the page-tweak rows, not the whole task table.
+//   * the active claim is a plain join: uniq_active_claim_per_task allows at
+//     most one row per task, and its partial index serves it.
+//   * the latest web claim is ONE pass over claims (the `web` CTE, DISTINCT ON
+//     per task), joined once, rather than a correlated subquery per task:
+//     claims has no full index on task_id, so a per-row LATERAL would scan it
+//     once per round.
+async function listPageTweakTasks() {
+  const { rows } = await api.pool.query(
+    `WITH pt AS (
+       SELECT t.id FROM tasks t WHERE t.source = 'page-tweak'
+     ), web AS (
+       SELECT DISTINCT ON (c.task_id) c.task_id, c.builder_id
+         FROM claims c JOIN pt ON pt.id = c.task_id
+        WHERE c.worktree_name IS NULL AND c.creator_session_id IS NULL
+        ORDER BY c.task_id, c.claimed_at DESC, c.id DESC
+     )
+     SELECT t.id, t.status, t.title, t.description, t.source_ref, t.touches,
+            t.shipped_at, t.created_at, t.updated_at,
+            g.passed AS grade_passed,
+            ac.builder_id AS holder_id, hb.github_login AS holder_login,
+            (ac.worktree_name IS NOT NULL) AS holder_worktree,
+            wc.builder_id AS artist_id, ab.github_login AS artist_login
+       FROM tasks t
+       LEFT JOIN task_grades g ON g.task_id = t.id
+       LEFT JOIN claims ac ON ac.task_id = t.id AND ac.released_at IS NULL
+       LEFT JOIN builders hb ON hb.id = ac.builder_id
+       LEFT JOIN web wc ON wc.task_id = t.id
+       LEFT JOIN builders ab ON ab.id = wc.builder_id
+      WHERE t.source = 'page-tweak'
+      ORDER BY t.id ASC`
+  );
+  return rows;
+}
+
+// The ships that changed a page since its last round (D8): shipped tasks after
+// `since` whose touches meet the page's files. The array-overlap operator is the
+// same one the parallel-safety check uses, served by idx_tasks_touches_gin.
+async function shippedTasksTouchingSince({ files, since, limit = 50 } = {}) {
+  const list = Array.isArray(files) ? files.map(String).filter(Boolean) : [];
+  if (!list.length || !since) return [];
+  const { rows } = await api.pool.query(
+    `SELECT t.id, t.title, t.shipped_at
+       FROM tasks t
+      WHERE t.status = 'shipped'
+        AND t.shipped_at > $2::timestamptz
+        AND t.touches && $1::text[]
+      ORDER BY t.shipped_at ASC, t.id ASC
+      LIMIT $3`,
+    [list, since, Math.max(1, Math.min(200, Number(limit) || 50))]
+  );
+  return rows;
+}
+
+module.exports = { listPageTweakTasks, shippedTasksTouchingSince };

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1057",
+  "version": "1.19.1059",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.1057",
+      "version": "1.19.1059",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1057",
+  "version": "1.19.1059",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -7643,5 +7643,17 @@
       "id": "1004315",
       "text": "Every page of the project now has a written reading: all the words it actually shows, in order, grouped under its headings. Each line says where the words live. Some come from a known place in the code, some are shared by ever"
     }
+  ],
+  "1.19.1058": [
+    {
+      "id": "1004316",
+      "text": "Every page now has a status that is worked out from the project's own record, with nothing new to keep in sync. For each page you can see whether it is untweaked or text tweaked and how many times, a history of each round (who"
+    }
+  ],
+  "1.19.1059": [
+    {
+      "id": "1004317",
+      "text": "An artist can now claim a whole page to rewrite in one step. If the page has no open round, one is created for them. If someone else is already on it, they are told who. Anyone, artist or not, can ask for a page to be worked o"
+    }
   ]
 }

package/scripts/gds/publish-manifest.js

@@ -124,6 +124,13 @@ const PUBLISH_ALLOWLIST = [
   // only because that is where their generator has always written them.
   'docs/copy-registry.json',
   'docs/copy-inventory.md',          // the human twin, generated in the same pass
+  // Tweak Mode's two page artifacts (ADR 0341 D1, task 1004316), the same kind
+  // of runtime data: modules/copy-desk/page-data.js reads both on every page
+  // status read, and neither generator can run on a deployed box (the reader
+  // opens a browser against a source tree). Without the inventory an instance
+  // answers 503 page_inventory_missing; without the readings drift reads unknown.
+  'docs/page-inventory.json',
+  'docs/page-readings.json',
   'docs/file-map.md',
   'docs/repo-map.md',
   'docs/handoff-template.md',         // the portable session-handoff format (methodology)

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.1057'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.1059'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/copy_desk_flags_db.mjs

@@ -78,6 +78,10 @@ await pool.query('INSERT INTO tasks (id) VALUES ($1) ON CONFLICT (id) DO NOTHING
 // migrated DB has already run it.
 const MIGRATION = fs.readFileSync(path.join(ROOT, 'modules/copy-desk/migrations/copy_desk_001_flags.sql'), 'utf8');
 await pool.query(MIGRATION);
+// TW06 (task 1004317): the page-ask widening, applied on top, twice (idempotent).
+const MIGRATION_002 = fs.readFileSync(path.join(ROOT, 'modules/copy-desk/migrations/copy_desk_002_page_asks.sql'), 'utf8');
+await pool.query(MIGRATION_002);
+await pool.query(MIGRATION_002);
 
 // Every row this test writes carries a surface nothing else uses, so cleanup is
 // exact and it can never delete a real flag.
@@ -241,6 +245,46 @@ await test('closeFlag returns null on a second call — the route answers 409 fr
   assert.equal(second, null);
 });
 
+// --- page asks (task 1004317 / TW06, copy_desk_002) -----------------------
+// A page ask's surface IS its page id, so these use SURF as the page id and the
+// cleanup above still catches every row.
+console.log('copy_desk_flags — page asks (copy_desk_002)');
+
+const pageIns = (o = {}) => pool.query(
+  `INSERT INTO copy_desk_flags (scope, surface, string_id, page_id, reason, flagged_by)
+   VALUES ($1,$2,$3,$4,$5,$6) RETURNING *`,
+  [o.scope ?? 'page', o.surface ?? SURF, o.string_id ?? null, 'page_id' in o ? o.page_id : SURF, REASON, o.by ?? B]
+);
+
+await test('a page ask inserts through the real write, pointing at its page', async () => {
+  const norm = flagsLib.normalizePageAsk({ reason: REASON }, SURF);
+  const row = await flagsLib.insertFlag(norm.value, B);
+  assert.deepEqual([row.scope, row.page_id, row.surface, row.status], ['page', SURF, SURF, 'open']);
+  assert.equal((await flagsLib.findOpenPageAsk(SURF, B)).id, row.id);
+  assert.equal(await flagsLib.countPageAskers(SURF), 1);
+});
+
+await test('the same builder cannot hold two open asks on one page (the 001 index)', async () => {
+  await assert.rejects(() => pageIns(), (e) => e.code === '23505');
+});
+
+await test("scope 'page' needs a page_id, and only scope 'page' may carry one", async () => {
+  await assert.rejects(() => pageIns({ page_id: null, by: A }), (e) => e.code === '23514');
+  await assert.rejects(() => pageIns({ scope: 'string', string_id: 'pg1', by: A }), (e) => e.code === '23514');
+});
+
+await test("a page ask's surface must be its page id", async () => {
+  await assert.rejects(() => pageIns({ page_id: 'landing:index', by: A }), (e) => e.code === '23514');
+});
+
+await test('resolvePageAsks closes the open asks filed before the ship, stamped with the task', async () => {
+  const ids = await flagsLib.resolvePageAsks({ pageId: SURF, taskId: T, resolvedBy: A, shippedAt: new Date(Date.now() + 60000).toISOString() });
+  assert.equal(ids.length, 1);
+  const { rows } = await pool.query("SELECT status, resolved_task_id, resolved_by FROM copy_desk_flags WHERE scope = 'page' AND page_id = $1", [SURF]);
+  assert.deepEqual(rows.map((r) => [r.status, String(r.resolved_task_id), String(r.resolved_by)]), [['resolved', String(T), String(A)]]);
+  assert.equal(await flagsLib.countPageAskers(SURF), 0);
+});
+
 // --- cleanup --------------------------------------------------------------
 await clean();
 await pool.query('DELETE FROM builders WHERE id = ANY($1)', [[A, B]]).catch(() => {});