@bongos/core 1.19.1044 → 1.19.1045

package/modules/hall-ui/public/work.js

@@ -36,6 +36,10 @@
   // file's exact variants (date-only fmtDate; a 2200ms clearing toast).
   // fmtAgo / toAuth / getJSON / postJSON stay local below.
   const { escapeHtml, $, fmtNum, errCode, errDetails } = window.OTB; // task 1002462: envelope readers
+  // The hall's ONE claim/release refusal copy (task 1003458). This board's own
+  // copy is gone: a second surface that wants a claim button consumes this
+  // instead of lifting the switch, which is how the two drifted apart before.
+  const { friendlyClaimError, makeClaimAction } = window.OTBClaimAction;
   // Shared task-domain helpers (task 1002463). These lived in two copies here and
   // in the other board and had already drifted — goals-page.js had silently lost
   // friendlyBatchReason's MODULE_CONFLICT case. Destructured so every call site
@@ -180,6 +184,18 @@
     return data;
   }
 
+  // The hall's ONE claim/release action (task 1003458). Everything this board
+  // used to hand-roll four times — the POST, the refusal sentence, the
+  // stale-view refresh, the all-or-nothing batch report — lives in
+  // claim-action.js now; doClaim/doRelease/doBulkClaim/doBulkRelease below keep
+  // only what is genuinely this page: button text, the re-entrancy guard, the
+  // confirm() wording and the selection. friendlyBatchReason is injected rather
+  // than imported there, so claim-action.js stays dependency-free.
+  // refreshLive is a hoisted declaration; toast and API are already bound above.
+  const claimAction = makeClaimAction({
+    postJSON, toast, API, refresh: refreshLive, describeBatchReason: friendlyBatchReason,
+  });
+
   // ---- paginated lists (task 1931/1955 → kit, task 2170) --------------------
   // All four Work-page lists paginate through the shared OTBKit pager (the
   // canonical copy of the helper that used to live here). localStorage keys are
@@ -627,51 +643,6 @@
       }
     }
   }
-
-  // ---- claim / release actions ---------------------------------------------
-
-  // Map the server's typed error code to a builder-readable line. The codes are
-  // exactly those POST /claims and POST /claims/:id/resolve can return.
-  function friendlyActionError(status, data) {
-    // task 1002462: read the ADR 0116 envelope. `data.error` is an OBJECT, so the
-    // old `const code = data && data.error` compared a string to an object and
-    // EVERY case below fell through to the generic default — a wrong-but-plausible
-    // toast on every claim/release refusal.
-    const det = errDetails(data);
-    switch (errCode(data)) {
-      case 'ALREADY_CLAIMED':
-        return 'Someone else claimed that task first. The board will refresh.';
-      case 'TASK_NOT_READY':
-        return 'That task is no longer ready to be claimed.';
-      case 'TOUCHES_CONFLICT': {
-        const titles = Array.isArray(det.conflicts) ? det.conflicts.map((c) => c.title).filter(Boolean) : [];
-        return titles.length
-          ? `That task overlaps an active claim: ${titles.join('; ')}. Wait for it to ship.`
-          : 'That task overlaps another active claim. Wait for it to ship.';
-      }
-      case 'DEPS_NOT_SHIPPED':
-        return 'That task waits on unshipped dependencies. Pick another for now.';
-      case 'rank_too_low_for_task':
-      case 'XENOS_RESTRICTED':
-      case 'INSUFFICIENT_RANK':
-        return 'Your rank is not yet high enough for that task.';
-      case 'newcomer_must_ship_first':
-        return det.what_to_do || 'Ship your current claim before opening another.';
-      case 'NOT_YOUR_CLAIM':
-        return 'That claim is not yours to release.';
-      case 'ALREADY_RESOLVED':
-        return 'That claim was already resolved. The board will refresh.';
-      case 'BUILDER_INACTIVE':
-        return 'Your account is inactive. Contact an Archon.';
-      default:
-        return `The board could not complete that (${status}). Try again.`;
-    }
-  }
-
-  // Maps a single batch-item failure reason (POST /claims/batch,
-  // /claims/batch/validate) to a builder-readable fragment. Distinct from
-  // friendlyActionError above because a batch item's shape differs (reason,
-  // not error; extra fields like conflictsWithTaskId/module_key).
   async function copyText(text) {
     try { await navigator.clipboard.writeText(text); return true; }
     catch (_) {
@@ -735,18 +706,15 @@
   async function scheduleValidate(key, ids) {
     if (validateDebounce) clearTimeout(validateDebounce);
     validateDebounce = setTimeout(async () => {
-      try {
-        const result = await postJSON(`${API}/claims/batch/validate`, { task_ids: ids });
-        validateCache.key = key;
-        validateCache.parallelSafe = !!result.parallel_safe;
-        validateCache.byId = new Map((result.results || []).map((r) => [String(r.task_id), r]));
-      } catch (_) {
-        // Best-effort — leave Parallel disabled-with-a-generic-title on failure
-        // rather than risk copying a prompt for tasks we couldn't verify.
-        validateCache.key = key;
-        validateCache.parallelSafe = false;
-        validateCache.byId = new Map();
-      }
+      // The dry run lives in claim-action.js with the rest of the claim path; it
+      // is best-effort there, so a failure lands as parallelSafe:false with an
+      // empty map rather than a throw — Parallel stays disabled with a generic
+      // title instead of copying a prompt for tasks nobody verified. The
+      // debounce, the cache key and the re-render stay here: page furniture.
+      const out = await claimAction.validateMany(ids);
+      validateCache.key = key;
+      validateCache.parallelSafe = out.parallelSafe;
+      validateCache.byId = out.byId;
       renderBulkToolbar();
     }, 350);
   }
@@ -911,33 +879,8 @@
     const btn = $('#bulk-claim-btn');
     if (btn) { btn.disabled = true; btn.textContent = 'Claiming…'; }
     try {
-      if (ids.length === 1) {
-        await postJSON(`${API}/claims`, { task_id: ids[0], bind_session: false });
-        toast(`You claimed #${ids[0]}. Open a terminal to start work.`);
-      } else {
-        await postJSON(`${API}/claims/batch`, { task_ids: ids, bind_session: false });
-        toast(`Claimed ${ids.length} tasks. Open a terminal to start work.`);
-      }
-      selection.claim.clear();
-      await refreshLive();
-    } catch (err) {
-      if (err && err.message === 'redirecting to auth') return;
-      // task 1002462: same envelope defect — this tested `err.data.error === 'batch_failed'`
-      // against an object, so an all-or-nothing batch refusal rendered as the generic toast
-      // and the per-task reasons were dropped on the floor.
-      if (err.status === 409 && errCode(err.data) === 'batch_failed') {
-        // One read covers both envelopes — errDetails falls back to the body (task 1003657).
-        const bdet = errDetails(err.data);
-        const failures = Array.isArray(bdet.failures) ? bdet.failures : [];
-        const lines = failures.map((f) => `#${f.task_id} (${friendlyBatchReason(f)})`);
-        toast(lines.length
-          ? `The batch could not be claimed — ${lines.join('; ')}.`
-          : 'The batch could not be claimed. It was left untouched (all-or-nothing).');
-        await refreshLive().catch(() => {});
-      } else {
-        toast(friendlyActionError(err.status, err.data));
-        if (err.status === 409) await refreshLive().catch(() => {});
-      }
+      const out = await claimAction.claimMany(ids);
+      if (out.ok) selection.claim.clear();
     } finally {
       renderBulkToolbar();
     }
@@ -952,22 +895,8 @@
     const btn = $('#bulk-release-btn');
     if (btn) { btn.disabled = true; btn.textContent = 'Releasing…'; }
     try {
-      if (entries.length === 1) {
-        await postJSON(`${API}/claims/${encodeURIComponent(entries[0][0])}/resolve`, { outcome: 'abandoned' });
-        toast(`Released #${entries[0][1]}. It returns to the queue.`);
-      } else {
-        const result = await postJSON(`${API}/claims/batch/release`, { claim_ids: entries.map(([cid]) => Number(cid)) });
-        const released = Array.isArray(result.released) ? result.released.length : 0;
-        const failed = Array.isArray(result.failures) ? result.failures.length : 0;
-        toast(failed
-          ? `Released ${released} of ${entries.length} — ${failed} could not be released.`
-          : `Released ${released} tasks. They return to the queue.`);
-      }
-      selection.release.clear();
-      await refreshLive();
-    } catch (err) {
-      if (err && err.message === 'redirecting to auth') return;
-      toast(friendlyActionError(err.status, err.data));
+      const out = await claimAction.releaseMany(entries);
+      if (out.ok) selection.release.clear();
     } finally {
       renderBulkToolbar();
     }
@@ -979,18 +908,10 @@
     pending.add(key);
     if (btn) { btn.disabled = true; btn.textContent = 'Claiming…'; }
     try {
-      // bind_session:false — a web claim has no working session, so leave it
-      // unbound (see claims.js resolveCreatorSessionId) and the builder can ship
-      // it later from any of their own terminals.
-      await postJSON(`${API}/claims`, { task_id: Number(taskId), bind_session: false });
-      toast(`You claimed #${taskId}. Open a terminal to start work.`);
-      await refreshLive();
-    } catch (err) {
-      if (err && err.message === 'redirecting to auth') return;
-      toast(friendlyActionError(err.status, err.data));
-      // A conflict/already-claimed means our view is stale — pull fresh truth.
-      if (err.status === 409) await refreshLive().catch(() => {});
-      if (btn) { btn.disabled = false; btn.textContent = 'Claim'; }
+      const out = await claimAction.claim(taskId);
+      // Leave the button disabled while the page is navigating to sign-in —
+      // re-enabling it invites a click that cannot land.
+      if (!out.ok && !out.redirected && btn) { btn.disabled = false; btn.textContent = 'Claim'; }
     } finally {
       pending.delete(key);
     }
@@ -1003,17 +924,8 @@
     pending.add(key);
     if (btn) { btn.disabled = true; btn.textContent = 'Releasing…'; }
     try {
-      // No DELETE /claims/:id exists — release is resolve(outcome=abandoned),
-      // the same path /builder-release uses. Scoped to the caller's own claim
-      // server-side (NOT_YOUR_CLAIM).
-      await postJSON(`${API}/claims/${encodeURIComponent(claimId)}/resolve`, { outcome: 'abandoned' });
-      toast(`Released #${taskId}. It returns to the queue.`);
-      await refreshLive();
-    } catch (err) {
-      if (err && err.message === 'redirecting to auth') return;
-      toast(friendlyActionError(err.status, err.data));
-      if (err.status === 409) await refreshLive().catch(() => {});
-      if (btn) { btn.disabled = false; btn.textContent = 'Release'; }
+      const out = await claimAction.release(claimId, taskId);
+      if (!out.ok && !out.redirected && btn) { btn.disabled = false; btn.textContent = 'Release'; }
     } finally {
       pending.delete(key);
     }

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1044",
+  "version": "1.19.1045",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.1044",
+      "version": "1.19.1045",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1044",
+  "version": "1.19.1045",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -7565,5 +7565,11 @@
       "id": "1003518",
       "text": "A blocker that was linked to the wrong task — a duplicate, or a mistake — can now be unlinked, and the task goes back to being claimable if nothing else was holding it. Before this the only way out was to mark the blocker reso"
     }
+  ],
+  "1.19.1045": [
+    {
+      "id": "1003458",
+      "text": "The Tasks board and the Goals page now claim and release work through one shared piece of code instead of two copies that had already drifted apart — the same refusal was worded differently on each page, and one had lost its \""
+    }
   ]
 }

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.1044'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.1045'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');