@bongos/core 1.19.1027 → 1.19.1028

package/tests/my_projects_surface.mjs

@@ -19,10 +19,11 @@
 //   2. WHETHER ANYTHING LEAKED. No: every /my-projects* route is sign-in-gated
 //      and reads the caller's OWN identity off the session. This is the half the
 //      audit could not confirm, so it is asserted here rather than described.
-//   3. WHAT IS STILL MISSING. The invitations half has no caller anywhere — no
-//      surface fetches the invite list, so a builder holding an invitation still
-//      cannot act on it. That is tracked work (task 1002970, idea 1000903), and
-//      pinning it keeps a known gap from decaying back into an unknown one.
+//   3. WHAT WAS STILL MISSING. The invitations half had no caller anywhere — no
+//      surface fetched the invite list, so a builder holding an invitation could
+//      not act on it. Closed by task 1003774: the hub's /projects?view=mine now
+//      reads GET /my-projects/invites (idea 1000903). The pin below flipped from
+//      "no surface calls this" to "some surface does" for the same reason.
 //
 // Static reads only (no import of the app, no DB) → runs in the `unit` gate.
 //
@@ -88,13 +89,11 @@ test('every /my-projects handler reads the caller identity from the session', ()
     'no /my-projects handler may take the account id from the request body or query');
 });
 
-// ── 3. the gap that is left, named and tracked ─────────────────────────────
-test('the invitations API still has no caller — the tracked gap, pinned', () => {
-  // Deliberately asserts a MISSING feature. Task 1003308 removed the only
-  // surface that fetched invitations, so a builder who holds one has nowhere to
-  // accept or decline it. Task 1002970 (blocked on task 1002969) and idea
-  // 1000903 own the replacement; this pin exists so the gap stays visible until
-  // one of them lands, and so it is impossible to close this quietly.
+// ── 3. the gap is closed — a surface now calls the invite list ──────────────
+test('an invitations surface exists — the hub reads GET /my-projects/invites (task 1003774)', () => {
+  // The quoted form is the actual fetch-call shape (`API + '/my-projects/invites'`);
+  // matching on that, rather than the bare path, keeps a doc comment that merely
+  // NAMES the route from satisfying this on its own.
   const surfaces = [];
   const modules = path.join(ROOT, 'modules');
   for (const key of fs.readdirSync(modules)) {
@@ -102,11 +101,24 @@ test('the invitations API still has no caller — the tracked gap, pinned', () =
     if (!fs.existsSync(pub)) continue;
     for (const f of fs.readdirSync(pub)) {
       if (!/\.(js|html)$/.test(f)) continue;
-      if (fs.readFileSync(path.join(pub, f), 'utf8').includes('/my-projects/invites')) {
+      if (fs.readFileSync(path.join(pub, f), 'utf8').includes("'/my-projects/invites'")) {
         surfaces.push(`modules/${key}/public/${f}`);
       }
     }
   }
-  assert.deepEqual(surfaces, [],
-    `an invitations surface exists now (${surfaces.join(', ')}) — good: delete this pin and close task 1002970 / idea 1000903`);
+  assert.ok(surfaces.length > 0,
+    'no surface calls GET /my-projects/invites — the gap task 1003774 closed is back open');
+});
+
+// ── 4. the accept flip stays retired (ADR 0335) ─────────────────────────────
+// Task 1003774 restores the invitations list but deliberately does NOT wire an
+// Accept button to POST /my-projects/invites/:id/accept: that hub-only flip
+// never admits anyone into the project's own instance (ADR 0335), so it is a
+// dead end the moment a caller exists to press it. Each invite renders as a
+// way IN (a link to the project) instead — signing in there is the acceptance
+// act (task 1002969).
+test('the hub never calls the accept route — ADR 0335 retired that flip', () => {
+  const html = read('modules/public-landing/public/projects.html');
+  assert.doesNotMatch(html, /invites\/[^'"]*\/accept/,
+    'a hub caller of the accept route reopens the dead end ADR 0335 closed — render the invite as a link into the project instead');
 });

package/tests/public_landing_projects.mjs

@@ -508,3 +508,43 @@ test('a stamped asset still serves — the query string is not part of the filen
   assert.equal(res.status, 200, 'express.static must ignore the ?v= when resolving the file');
   assert.match(res.body, /\.shell\{/, 'and it must be the real stylesheet');
 });
+
+// ── #view-mine: invitations, projects-you-build-on, join-by-URL (task 1003774) ──
+// The hall's my-projects page was deleted in task 1003308 on the owner's own
+// decision that this is a hub surface; these three reads/actions were left with
+// nowhere to live until now. loadMemberships() already fetched GET /my-projects
+// for the map's Apply button (R10, task 1002286) — this just renders the rest
+// of what that same read carries, plus the separate invites list.
+test('#view-mine reads the invitations list, alongside the building-on and join surfaces', async () => {
+  const { body } = await request('/projects', 'game.test.local');
+  assert.match(body, /\/my-projects\/invites/, 'GET /my-projects/invites must be called');
+  assert.match(body, /id="invitesList"/);
+  assert.match(body, /id="buildingList"/);
+  assert.match(body, /\/my-projects\/join/, 'the join-by-URL field must post to /my-projects/join');
+  assert.match(body, /id="joinOrigin"/);
+  assert.match(body, /id="joinNote"/, 'the applicant note (task 1002330) rides along, and stays optional');
+  assert.match(body, /\/my-projects\/'\s*\+\s*encodeURIComponent/, 'Leave must address the project by its own client id');
+  assert.match(body, /origin = 'https:\/\/' \+ origin/,
+    'a bare host ("grove.cloudbongos.com") must be assumed https:// rather than sent as-is — the server\'s origin lookup is an exact match');
+});
+
+test('an invite renders as a way INTO the project, never the retired accept flip (ADR 0335)', async () => {
+  const { body } = await request('/projects', 'game.test.local');
+  // the hub-only accept flip never admits anyone to the project's own instance
+  // (ADR 0335) — a caller of it here would reopen the exact dead end that ADR
+  // retired, so the invite's action is an outbound link instead
+  assert.doesNotMatch(body, /invites\/[^'"]*\/accept/, 'no caller of the retired hub accept route');
+  assert.match(body, /Open project/, 'the invite links into the project — signing in there is the acceptance act');
+  assert.match(body, /'\/my-projects\/invites\/' \+ encodeURIComponent\([^)]+\) \+ '\/decline'/,
+    'decline still works: it only clears the hub\'s own pending row');
+});
+
+test('the map card\'s Apply button reads as truly inert once applied, with a live status region (R10 fixups)', async () => {
+  const page = await request('/projects', 'game.test.local');
+  assert.match(page.body, /id="cardApplyMsg" role="status" aria-live="polite"/, 'the apply outcome must be announced to assistive tech');
+  const stamped = (page.body.match(/\/assets\/cosmos\.css\?v=[0-9a-f]+/) || [])[0];
+  assert.ok(stamped, 'need a stamped URL to fetch');
+  const css = await request(stamped);
+  assert.match(css.body, /\.btn\.ghost:disabled\{/, 'a disabled ghost button (the Applied state) must not keep full-strength styling');
+  assert.match(css.body, /\.projCard \.cardActions \.projMsg\{flex-basis:100%;?\}/, 'the outcome must sit under the buttons, not beside them');
+});