@bongos/core 1.19.1007 → 1.19.1009

package/modules/hall-ui/public/ideas.js

@@ -264,7 +264,11 @@
 
     renderRecommendation(draft);
 
-    $('#fi-meter').hidden = false;
+    formRendered = true;
+    // The meter is unhidden through the disclosure, which owns the rule for both
+    // directions; setting it here as well would be a second source of truth for
+    // the same visibility and is what let the reopen case rot unnoticed.
+    setDisclosure(fullOpen);
     renderMeterSkeleton();
   }
 
@@ -902,24 +906,78 @@
     return true;
   }
 
-  async function main() {
-    // THE QUEUE IS LOADED FIRST, AND UNCONDITIONALLY. The composer and the spark
-    // queue are independent surfaces that happen to share a page: the queue needs
-    // no template. Loading it after the template check meant one failed fetch took
-    // BOTH down — the reported symptom was "Could not load the idea template" AND a
-    // queue stuck on "Loading…" forever, which read as two bugs and was one.
-    // A surface that does not depend on the failure must not be hostage to it.
-    loadQueue();
+  // ---------------------------------------------------------------------------
+  // the disclosure (task 1004087 / spec R04, decision 18)
+  // ---------------------------------------------------------------------------
+  //
+  // THE FULL IDEA FORM IS CLOSED UNTIL SOMEONE ASKS FOR IT, and this is the
+  // whole point of the fold. Decision 18 put the five questions on the same
+  // surface as the one-line composer and named that the riskiest call in the
+  // spec: a spark's value is that it costs nothing to have, and a five-field
+  // form standing permanently open under the fast path is exactly how a page
+  // starts feeling like something to be filled in.
+  //
+  // So "on the same surface" is spent on ONE press, and nothing else. While the
+  // form is shut this page does not fetch the template, does not wire the
+  // per-keystroke scorer, and does not hold the rail reserve open — the one-line
+  // path is the first thing under the heading at full width, and it is ready
+  // before any of the Full Idea machinery has run.
+  //
+  // Closing again HIDES, it does not discard: the draft lives in localStorage
+  // exactly as it did before, so the toggle is reversible in both directions and
+  // the button can say so without lying.
+
+  let fullBooted = false;   // the template read was STARTED once
+  let formRendered = false; // ...and actually produced a form (and so a meter)
+  let fullOpen = false;
+
+  // The rail reserve belongs to the meter, so it arrives and leaves with it.
+  // style.css reserves `--rail-right-w` from `.app-content--railed > main` at the
+  // wide breakpoint whether or not anything is in the rail, which is why this is
+  // a class toggle and not simply `#fi-meter.hidden`.
+  function setRail(on) {
+    const c = document.getElementById('fi-content');
+    if (!c || !c.classList) return;
+    if (on) c.classList.add('app-content--railed');
+    else c.classList.remove('app-content--railed');
+  }
 
-    // Quick filing (R08) is a THIRD independent surface on this page, offered
-    // only outside develop mode — developing a spark always produces a Full
-    // Idea, never a fresh quick report (see the section's own header comment).
-    if (DEVELOP_ID) {
-      const scroll = $('#fq-compose-scroll');
-      if (scroll) scroll.hidden = true;
-    } else {
-      bootQuickComposer();
+  function setDisclosure(open) {
+    fullOpen = open;
+    const form = $('#fi-form');
+    const btn = $('#fi-open');
+    const note = $('#fi-disclose-note');
+    if (form) form.hidden = !open;
+    if (btn) {
+      btn.setAttribute('aria-expanded', open ? 'true' : 'false');
+      btn.textContent = open ? 'Put the five questions away' : 'Answer the five questions';
+    }
+    if (note) {
+      note.textContent = open
+        ? 'Putting them away keeps your draft — it is saved as you type.'
+        : 'Nothing you have typed above is lost by opening this.';
     }
+    // The meter is the form's readout, so it follows the form BOTH WAYS — and the
+    // condition is written as one expression rather than a hide-only branch
+    // because the hide-only version was a real bug: `renderForm` is the only
+    // thing that ever unhid the meter, `bootFullIdea` runs it at most once, so
+    // opening, closing and opening again brought the form and the rail back with
+    // the readout gone for good — the rail reserve held open for a panel that
+    // was no longer there, which is the exact anti-pattern the fold removes.
+    //
+    // `formRendered`, not `fullBooted`: the boot flag is set BEFORE the template
+    // read, so it is true even when that read failed and there is no meter to
+    // show. An empty meter is a readout claiming a score of nothing.
+    const meter = $('#fi-meter');
+    if (meter) meter.hidden = !(open && formRendered);
+    setRail(open);
+  }
+
+  // Everything the Full Idea half needs, run at most once and never on the fast
+  // path. Returns nothing: its failures are stated on the page, as before.
+  async function bootFullIdea() {
+    if (fullBooted) return;
+    fullBooted = true;
 
     const r = await api.inbox.getInboxTemplate({});
     if (!r.ok || !r.data || !r.data.template) {
@@ -958,5 +1016,58 @@
     }
   }
 
+  async function openFullIdea() {
+    setDisclosure(true);
+    await bootFullIdea();
+  }
+
+  async function toggleFullIdea() {
+    if (fullOpen) { setDisclosure(false); return; }
+    await openFullIdea();
+  }
+
+  async function main() {
+    // THE QUEUE IS LOADED FIRST, AND UNCONDITIONALLY. The composer and the spark
+    // queue are independent surfaces that happen to share a page: the queue needs
+    // no template. Loading it after the template check meant one failed fetch took
+    // BOTH down — the reported symptom was "Could not load the idea template" AND a
+    // queue stuck on "Loading…" forever, which read as two bugs and was one.
+    // A surface that does not depend on the failure must not be hostage to it.
+    loadQueue();
+
+    // Quick filing (R08) is a THIRD independent surface on this page, offered
+    // only outside develop mode — developing a spark always produces a Full
+    // Idea, never a fresh quick report (see the section's own header comment).
+    if (DEVELOP_ID) {
+      const scroll = $('#fq-compose-scroll');
+      if (scroll) scroll.hidden = true;
+    } else {
+      bootQuickComposer();
+    }
+
+    const openBtn = $('#fi-open');
+    if (openBtn) openBtn.addEventListener('click', toggleFullIdea);
+    setDisclosure(false);
+
+    // THE THREE CASES A SHUT FORM WOULD STRAND (task 1004087 / spec R04). The
+    // done-when is "no dead links", and a link that lands on a page whose
+    // relevant half is folded away is dead in the only sense that matters to
+    // whoever followed it:
+    //
+    //   ?develop=<id>  the spark queue's own rows, and /idea/:id — the whole
+    //                  request is "develop this", so arriving at a shut form
+    //                  would be the page ignoring it.
+    //   #full          the deep link anything else uses to mean "the composer",
+    //                  including /idea/:id's fallback action.
+    //   a saved draft  half-written work already in localStorage. Leaving it
+    //                  behind a press nobody knows to make is how "a partial
+    //                  draft is not lost on navigation" (R152) quietly stops
+    //                  being true — the draft would still be there and no one
+    //                  would ever see it again.
+    if (DEVELOP_ID || location.hash === '#full' || readDraft()) {
+      await openFullIdea();
+    }
+  }
+
   main();
 })();

package/modules/hall-ui/public/ideas.states.json

@@ -1,5 +1,5 @@
 {
-  "_": "The hall's IDEA COMPOSER through modules/ui-design/kit/render.js (task 1003305). The five questions are rendered from GET /inbox/template and the spark queue from GET /inbox/sparks, so the populated form needs the hall-preview harness; the kit's own stub answers neither and renders the honest `could not load the idea template` line instead, which is the `no-template` state below.\n\n  node scripts/hall-preview/server.js --port 4612 --fixture-me\n  node modules/ui-design/kit/render.js --states modules/hall-ui/public/ideas.states.json --base-in http://builders.localhost:4612 --base-out http://builders.localhost:4612\n\nThe right rail is the shell's `.app-content--railed` reserve, so the 62rem breakpoint is exercised at 1440 and stacked at 390/320 — which is the whole reason all three widths are rendered.",
+  "_": "The hall's IDEA COMPOSER through modules/ui-design/kit/render.js (task 1003305). The five questions are rendered from GET /inbox/template and the spark queue from GET /inbox/sparks, so the populated form needs the hall-preview harness; the kit's own stub answers neither and renders the honest `could not load the idea template` line instead, which is the `no-template` state below.\n\n  node scripts/hall-preview/server.js --port 4612 --fixture-me\n  node modules/ui-design/kit/render.js --states modules/hall-ui/public/ideas.states.json --base-in http://builders.localhost:4612 --base-out http://builders.localhost:4612\n\nTHE FOLD (task 1004087 / spec R04) is why there are now three states rather than two. `compose` is what a builder actually lands on — the one-line composer at the top, the Full Idea form folded away behind one press, and NO rail reserve, which is the whole reason that state is rendered at 1440 as well as at 390/320. `full` is the same page one press later: the five questions, the meter, and the rail. Rendering only one of them would measure half the page, and the half that is measured on every arrival is the first.",
   "page": "/ideas",
   "surface": "hall-ui",
   "stub": { "prefix": "/builders/" },
@@ -8,7 +8,8 @@
   "_console": "The 501 is the harness, not the page: the meter re-scores through POST /inbox/score on every keystroke and scripts/hall-preview/server.js answers every write with preview_readonly by design. Declared rather than hidden.",
   "ignoreConsole": ["/api/(gds|bongos)/", "\\b401\\b", "\\b404\\b", "\\b501\\b", "Unauthorized", "Not Found", "Not Implemented", "load failed"],
   "states": {
-    "compose": { "auth": true, "actions": [["wait", 700]], "expect": { "visible": ["#fi-form", "#fi-fields", "#fi-queue"] } },
+    "compose": { "auth": true, "actions": [["wait", 700]], "expect": { "visible": ["#fq-form", "#fi-queue", "#fi-open"] } },
+    "full": { "auth": true, "actions": [["wait", 700], ["click", "#fi-open"], ["wait", 700]], "expect": { "visible": ["#fi-form", "#fi-fields", "#fi-meter"] } },
     "develop": { "auth": true, "url": "/ideas?develop=1000884", "actions": [["wait", 700]], "expect": { "visible": ["#fi-develop"] } }
   },
   "reducedMotion": { "auth": true, "actions": [["wait", 700]] }

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1007",
+  "version": "1.19.1009",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.1007",
+      "version": "1.19.1009",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.1007",
+  "version": "1.19.1009",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.1007'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.1009'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/fixtures/ideator-prefold/README.md

@@ -0,0 +1,36 @@
+# The pre-fold ideas page — a frozen baseline
+
+Byte copies of `modules/hall-ui/public/ideas.html` and `ideas.js` as they stood at commit
+**`f375a1f9`**, the commit immediately before the Full Idea form was folded behind a
+disclosure (task [#1004087](https://cloudbongos.com/builders#/task/1004087), spec R04).
+
+They exist so `tests/ideator_one_line_path_proof.mjs` can measure the current filing path
+against **the page that actually existed**, rather than against a description of it. A
+described baseline agrees with the current page because whoever wrote it made it agree;
+these can only agree if the code does.
+
+Re-cut them to check they have not drifted:
+
+```bash
+git show f375a1f9:modules/hall-ui/public/ideas.js > tests/fixtures/ideator-prefold/ideas.js.baseline
+git show f375a1f9:modules/hall-ui/public/ideas.html > tests/fixtures/ideator-prefold/ideas.html.baseline
+```
+
+## Do not edit these, and do not "fix" them
+
+They are **evidence, not source**. Every finding in
+[`docs/governance/<redacted>.md`](../../../docs/governance/<redacted>.md)
+is a comparison against them, so editing one silently turns a measurement into a tautology.
+The proof's last claim exists for exactly that: it asserts the baseline still fetches the
+template unconditionally, still knows nothing about a disclosure, and is still a different
+file from the live page — so tidying these into agreement reds the suite instead of passing
+quietly.
+
+## Why the `.baseline` extension
+
+Not decoration, and not a way around a gate. `scripts/gds/fitness-ratchets.js` measures
+cross-file duplication over `git ls-files '*.js'`, and a frozen copy of a live file is, by
+construction, ~500 duplicate windows against it. That metric exists to find copy/paste a
+maintainer should collapse; collapsing *this* copy would destroy the only thing it is for.
+The extension states what the file is — recorded evidence, never loaded, never edited — and
+keeps the duplication ratchet honest about the code it was written to police.

package/tests/fixtures/ideator-prefold/ideas.html.baseline

@@ -0,0 +1,210 @@
+<!doctype html>
+<html lang="en">
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width, initial-scale=1">
+  <title>Ideas — {{worldName}}</title>
+  <meta name="description" content="Write a Full Idea: five questions that turn a thought into a baseline scope of work someone else can deliver against, with a live completeness score.">
+  <link rel="icon" href="data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 32 32'><text x='16' y='24' font-size='24' text-anchor='middle' font-family='sans-serif'>⌂</text></svg>">
+  <link rel="preconnect" href="https://fonts.googleapis.com">
+  <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
+  <link rel="stylesheet" href="/builders/style.css?v=2026-07-02-shell1">
+  <link rel="stylesheet" href="/builders/ideas.css">
+</head>
+<body data-page="ideas" data-page-title="Ideas">
+
+<div class="app">
+  <aside class="app-sidebar" id="app-sidebar" aria-label="Primary"></aside>
+  <div class="app-scrim" id="app-scrim" hidden></div>
+  <div class="app-body">
+    <header class="app-topbar" id="app-topbar"></header>
+    <!-- --railed reserves the room the meter occupies (style.css, "the right
+         rail"). This page used to take that room by overriding
+         `.app-content > main` from its own sheet, which is a page editing shell
+         layout — invisible from the shell, and it hard-coded a topbar height. -->
+    <div class="app-content app-content--railed">
+      <!-- The page's own name, in the LABEL voice — the display face is saved for
+           section headings (the work.html precedent, task 1003304). The page had
+           no h1 at all, so it failed one-header-main-h1 on every render. -->
+      <div class="page-head page-head--board">
+        <h1 class="page-head__h">Ideas</h1>
+        <p class="page-head__sub" id="fi-sub">Loading the idea template…</p>
+      </div>
+
+      <main id="hall-main">
+        <!-- The spark queue (task 1002930 / R154). ABOVE the composer, because
+             "what is already waiting" is the thing to scan before starting
+             something new — and because a queue nobody sees is not a pickup
+             surface. Collapsed to a single line when empty so it never pushes the
+             composer down the page for nothing. -->
+        <section class="scroll" id="fi-queue-scroll" aria-labelledby="fi-queue-h">
+          <h2 id="fi-queue-h" class="scroll__h">Waiting to be developed</h2>
+          <p class="scroll__lede">
+            Ideas whose author has said "I had the thought but not the full picture".
+            Anyone can develop one — the author keeps the credit for having had it,
+            and you are recorded as its developer.
+          </p>
+          <div id="fi-queue"><p class="fi-note">Loading…</p></div>
+        </section>
+
+        <!-- Quick filing (task 1003069 / R08, goal 1000071 "Idea routing") —
+             the hall's first bug/idea report, separate from the Full Idea
+             composer below: title + kind + optional body + a goal picker fed
+             by the R07 suggester. A routed capture must never carry
+             grade='full' (routing.js NEVER_ROUTE_GRADE), so this cannot share
+             a submit with the form below it. Hidden while developing a spark
+             (?develop=<id>) — that surface always turns someone else's
+             existing thought into a Full Idea, never a fresh quick report. -->
+        <section class="scroll" id="fq-compose-scroll" aria-labelledby="fq-compose-h">
+          <h2 id="fq-compose-h" class="scroll__h">File a bug or idea</h2>
+          <p class="scroll__lede">
+            A quick report — title, what's going on, and where it belongs. Pick a goal
+            and it lands there as a task the moment you file; leave it on "no goal" and
+            it waits in the inbox for triage.
+          </p>
+
+          <form id="fq-form" novalidate>
+            <label class="fi-label" for="fq-title">Title</label>
+            <input type="text" id="fq-title" class="fi-input" maxlength="200" autocomplete="off"
+                   placeholder="what's wrong, or what you'd like to see">
+
+            <label class="fi-label" for="fq-kind">Kind</label>
+            <!-- task 1003453: the options are FILLED from /me.task_kinds at boot
+                 (ideas.js), not written here. This markup used to spell the whole
+                 vocabulary and had gone stale against the DB CHECK exactly as the
+                 two board filters had — a third copy nobody was watching. The one
+                 option left is the degraded fallback: if the read never lands, a
+                 bug can still be filed. -->
+            <select id="fq-kind" class="fi-input">
+              <option value="bug" selected>Bug</option>
+            </select>
+
+            <label class="fi-label" for="fq-body">Details <span class="fi-hint">(optional)</span></label>
+            <textarea id="fq-body" class="fi-text" rows="4"
+                      placeholder="repro steps, context, anything that helps…"></textarea>
+
+            <label class="fi-label" for="fq-goal">
+              Goal
+              <span class="fi-hint">Suggested as you type; leave it on "no goal" and it waits for triage.</span>
+            </label>
+            <select id="fq-goal" class="fi-input"></select>
+
+            <!-- GRAVITY (task 1004083 / spec R02) — what will actually catch this
+                 thought, stated before it is released. It sits under the picker
+                 because it is the picker's consequence, and because the picker's
+                 own option labels cannot carry it: "No goal (homeless)" is false
+                 for a bug (ADR 0262 routes it to the maintenance goal), and a
+                 named goal is false for a judgment kind (routing.js
+                 NEVER_ROUTE_KINDS). The verdict comes from the server's real
+                 landing matrix — see POST /inbox/preview-landing — never from a
+                 second copy of the rules in ideas.js. Hidden until there is
+                 something true to say. -->
+            <p class="fi-gravity" id="fq-gravity" role="status" aria-live="polite" hidden></p>
+
+            <p class="fi-err" id="fq-err" role="alert"></p>
+            <p class="fi-result" id="fq-result" role="status" aria-live="polite"></p>
+
+            <!-- The receipt that outlives the confirmation above (task 1004082 /
+                 spec R01). #fq-result is the live announcement for the filing
+                 just made and dies with the page; this list is the durable
+                 record of the last few, read back from localStorage on load so
+                 a thought filed before a reload is still traceable here. -->
+            <section class="fi-receipts" id="fq-receipts" aria-labelledby="fq-receipts-h" hidden>
+              <h3 class="fi-receipts__h" id="fq-receipts-h">Recent filings</h3>
+              <ol class="fi-receipts__list" id="fq-receipts-list"></ol>
+              <p class="fi-receipts__note" id="fq-receipts-note" hidden></p>
+            </section>
+
+            <div class="fi-actions">
+              <button type="submit" class="btn" id="fq-submit">File it</button>
+            </div>
+          </form>
+        </section>
+
+        <!-- The composer. The idea detail view lives on its own page (R153). -->
+        <section class="scroll" id="fi-compose-scroll" aria-labelledby="fi-compose-h">
+          <h2 id="fi-compose-h" class="scroll__h">Write a Full Idea</h2>
+          <p class="scroll__lede">
+            A Full Idea answers five questions, so that someone else can deliver against it
+            without having to interview you first. Open to every role — the score below is
+            the only filter, and it counts substance, not who you are.
+          </p>
+
+          <form id="fi-form" novalidate>
+            <!-- DEVELOP MODE (R154): when the composer was opened from a spark,
+                 this block carries the spark's own words and the title becomes a
+                 read-only fact rather than a field — developing an idea must not
+                 quietly rename it out from under its author. -->
+            <div class="fi-develop" id="fi-develop" hidden>
+              <p class="fi-develop__label">Developing a Big Idea Spark</p>
+              <p class="fi-develop__title" id="fi-develop-title"></p>
+              <p class="fi-develop__body" id="fi-develop-body"></p>
+              <p class="fi-develop__who" id="fi-develop-who"></p>
+            </div>
+
+            <label class="fi-label" for="fi-title" id="fi-title-label">
+              Title
+              <span class="fi-hint">One line. This is what the idea is called everywhere else.</span>
+            </label>
+            <input type="text" id="fi-title" class="fi-input" maxlength="200" autocomplete="off"
+                   placeholder="what the idea is, in one line">
+
+            <!-- The five fields are rendered from GET /inbox/template — the R141
+                 declaration — never hand-written here. A hard-coded form is the
+                 same "second copy of the rules" defect as a hard-coded scorer,
+                 one step earlier, and it would silently ignore a per-project
+                 template (R156). -->
+            <div id="fi-fields" class="fi-fields">
+              <p class="fi-note">Loading the five questions…</p>
+            </div>
+
+            <!-- The scope recommendation (BV2.R13). Rendered from the same
+                 GET /inbox/template read as the fields above, and for the same
+                 reason: the two values are a closed vocabulary the database
+                 enforces, so a hand-written pair of radios here would be a
+                 second copy of it, free to drift. -->
+            <div id="fi-rec" class="fi-rec"></div>
+
+            <p class="fi-err" id="fi-err" role="alert"></p>
+
+            <div class="fi-actions">
+              <button type="submit" class="btn" id="fi-submit" disabled>File this idea</button>
+              <button type="button" class="btn btn--ghost" id="fi-clear">Discard draft</button>
+              <span class="fi-draft" id="fi-draft" role="status" aria-live="polite"></span>
+            </div>
+          </form>
+        </section>
+      </main>
+
+      <footer class="app-foot" id="app-foot"></footer>
+    </div>
+  </div>
+</div>
+
+<!-- The meter rides along beside the form on a wide screen and above it on a
+     narrow one (the shell's .app-rail decides). It is a READOUT, never an input:
+     every number in it comes from the server's own scorer. -->
+<aside class="fi-meter app-rail" id="fi-meter" aria-labelledby="fi-meter-h" hidden>
+  <h2 class="fi-meter__h" id="fi-meter-h">Completeness</h2>
+  <div class="fi-gauge">
+    <div class="fi-gauge__track"><div class="fi-gauge__fill" id="fi-gauge-fill"></div></div>
+    <p class="fi-gauge__n" id="fi-gauge-n" role="status" aria-live="polite">—</p>
+  </div>
+  <ul class="fi-meter__list" id="fi-meter-list"></ul>
+  <p class="fi-meter__note">
+    Counted, not judged: each question is worth the same, and earns its share in
+    proportion to how much real text it carries. Whitespace and padding score nothing.
+  </p>
+</aside>
+
+<div id="toast" class="toast" role="status" aria-live="polite" data-visible="0"></div>
+
+<script src="/builders/shell.js?v=2026-09-22-movefeedback1"></script>
+<script src="/builders/palette.js" defer></script>
+<script src="/builders/dom-utils.js?v=2026-06-23-contrib"></script>
+<!-- task 1003069 (R08) — the quick-filing form's routed result links a task
+     through window.OTBTaskDetail.href(); guarded if this ever loads without it. -->
+<script src="/builders/task-detail.js?v=2026-07-03-taskdetail2" defer></script>
+<script src="/builders/ideas.js?v=2026-08-22-r154"></script>
+</body>
+</html>