@bongos/core 1.19.1005 → 1.19.1006

package/docs/copy-registry.json

@@ -3,17 +3,17 @@
   "generator": "scripts/gds/copy-inventory.js",
   "goal": 1000074,
   "counts": {
-    "strings": 1946,
-    "unique_ids": 1684,
-    "certain": 1946,
+    "strings": 1950,
+    "unique_ids": 1687,
+    "certain": 1950,
     "heuristic": 0,
-    "duplicate_ids": 180
+    "duplicate_ids": 181
   },
   "surfaces": {
     "builders-hall": {
       "at": "modules/hall-ui/public",
       "files": 97,
-      "strings": 1455
+      "strings": 1459
     },
     "status-dashboard": {
       "at": "modules/status-ui/public",
@@ -580,6 +580,16 @@
         "modules/hall-ui/public/goals-render.js:1039"
       ]
     },
+    {
+      "id": "688cc6dd38ee",
+      "surface": "builders-hall",
+      "text": "Asked of you",
+      "occurrences": 2,
+      "at": [
+        "modules/hall-ui/public/collab.html:48",
+        "modules/hall-ui/public/collab.html:122"
+      ]
+    },
     {
       "id": "b2656d0b2402",
       "surface": "builders-hall",
@@ -1176,8 +1186,8 @@
       "text": "Post reply",
       "occurrences": 2,
       "at": [
-        "modules/hall-ui/public/collab.js:161",
-        "modules/hall-ui/public/collab.js:674"
+        "modules/hall-ui/public/collab.js:168",
+        "modules/hall-ui/public/collab.js:738"
       ]
     },
     {
@@ -2710,7 +2720,7 @@
       "surface": "builders-hall",
       "text": "Answering is optional and declining costs nothing. Nobody is assigned by being asked.",
       "file": "modules/hall-ui/public/collab.html",
-      "line": 106,
+      "line": 143,
       "origin": "html-text",
       "confidence": "certain"
     },
@@ -2813,6 +2823,15 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
+    {
+      "id": "9b02ba5e6d23",
+      "surface": "builders-hall",
+      "text": "Asked of others",
+      "file": "modules/hall-ui/public/collab.html",
+      "line": 131,
+      "origin": "html-text",
+      "confidence": "certain"
+    },
     {
       "id": "688cc6dd38ee",
       "surface": "builders-hall",
@@ -2822,6 +2841,15 @@
       "origin": "html-text",
       "confidence": "certain"
     },
+    {
+      "id": "688cc6dd38ee",
+      "surface": "builders-hall",
+      "text": "Asked of you",
+      "file": "modules/hall-ui/public/collab.html",
+      "line": 122,
+      "origin": "html-text",
+      "confidence": "certain"
+    },
     {
       "id": "b2656d0b2402",
       "surface": "builders-hall",
@@ -3556,7 +3584,7 @@
       "surface": "builders-hall",
       "text": "Close this ask",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 263,
+      "line": 270,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3700,7 +3728,7 @@
       "surface": "builders-hall",
       "text": "Copy all {…} for Session Start",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 401,
+      "line": 461,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -3754,7 +3782,7 @@
       "surface": "builders-hall",
       "text": "Copy for Session Start",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 130,
+      "line": 137,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4006,7 +4034,7 @@
       "surface": "builders-hall",
       "text": "Could not load requests — reload to try again.",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 744,
+      "line": 808,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -6985,7 +7013,7 @@
       "surface": "builders-hall",
       "text": "Moot — the metrics stack was removed on the 15th, so there is nothing left to rotate.",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 161,
+      "line": 168,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7493,6 +7521,15 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
+    {
+      "id": "4016b9cf8d57",
+      "surface": "builders-hall",
+      "text": "None of your asks have been settled yet.",
+      "file": "modules/hall-ui/public/collab.html",
+      "line": 134,
+      "origin": "html-text",
+      "confidence": "certain"
+    },
     {
       "id": "428a62539050",
       "surface": "builders-hall",
@@ -7534,7 +7571,7 @@
       "surface": "builders-hall",
       "text": "Not now",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 587,
+      "line": 651,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7628,6 +7665,15 @@
       "origin": "js-notice",
       "confidence": "certain"
     },
+    {
+      "id": "1376762e97db",
+      "surface": "builders-hall",
+      "text": "Nothing anyone asked of you has been settled yet.",
+      "file": "modules/hall-ui/public/collab.html",
+      "line": 125,
+      "origin": "html-text",
+      "confidence": "certain"
+    },
     {
       "id": "cd652d04d616",
       "surface": "builders-hall",
@@ -8236,7 +8282,7 @@
       "surface": "builders-hall",
       "text": "Post reply",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 161,
+      "line": 168,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8245,7 +8291,7 @@
       "surface": "builders-hall",
       "text": "Post reply",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 674,
+      "line": 738,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -8623,7 +8669,7 @@
       "surface": "builders-hall",
       "text": "Read the full ask",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 127,
+      "line": 133,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8875,7 +8921,7 @@
       "surface": "builders-hall",
       "text": "Replied.",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 670,
+      "line": 734,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -9244,7 +9290,7 @@
       "surface": "builders-hall",
       "text": "Say yes",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 587,
+      "line": 651,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9568,7 +9614,7 @@
       "surface": "builders-hall",
       "text": "Show all {…}",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 355,
+      "line": 415,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -9784,7 +9830,7 @@
       "surface": "builders-hall",
       "text": "Someone helped",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 289,
+      "line": 296,
       "origin": "js-markup",
       "confidence": "certain"
     },

package/docs/module-api-changelog.md

@@ -2484,5 +2484,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.1003 with no explicit bump. run 36030644887. (task 1002620)
   1.19.1005 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.1004 with no explicit bump. run 36032559593. (task 1002620)
+  1.19.1006 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.1005 with no explicit bump. run 36036374443. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/collab-lib.js

@@ -560,6 +560,36 @@
     return !!req.needs_craft && crafts.indexOf(req.needs_craft) !== -1;
   }
 
+  // ---- the archive (task 1004224) -------------------------------------------
+  //
+  // HOW AN ASK ENDED, in one sentence. This is the only thing an archived row has
+  // that an open one does not, and it is the whole reason the archive is worth
+  // drawing: a row that left the board without anybody watching it go has to be
+  // able to say why, or the page has silently disappeared its own history.
+  //
+  // THE AUTOMATIC CLOSE IS NAMED, NOT DISGUISED. `settled_reason` is the server's
+  // word for "the ledger did this", and a row carrying one has no person behind
+  // it — `settled_by` is null. Rendering that as "Closed" with no author would
+  // read as an anonymous human, and rendering it as if the asker had closed it
+  // would attribute an act to someone who never performed one. So it says what
+  // happened: the task shipped.
+  //
+  // PURE, and total — every row gets a sentence. A settled row whose reason and
+  // settler are both absent is a real state (settled before ADR 0330 added
+  // `settled_by`), and "Closed." is the true thing to say about it.
+  function outcomeLine(req) {
+    if (!req) return '';
+    var status = String(req.status || '');
+    if (status === 'open') return '';
+    if (req.settled_reason === 'task_shipped') {
+      var t = req.task_id == null ? '' : ' ' + req.task_id;
+      return 'Closed by itself when task' + t + ' shipped.';
+    }
+    var who = req.settled_by_name || req.settled_by_login || '';
+    if (status === 'withdrawn') return who ? 'Withdrawn by ' + who + '.' : 'Withdrawn.';
+    return who ? 'Closed by ' + who + '.' : 'Closed.';
+  }
+
   // A reply is capped at the same length as an ask. Stated here so the page can
   // refuse before the round trip and the counter can read from one number.
   var MAX_REPLY = 4000;
@@ -584,5 +614,6 @@
     queueStartPrompt: queueStartPrompt, contextSentence: contextSentence,
     saidLabel: saidLabel, replyAuthor: replyAuthor, threadOf: threadOf,
     canClose: canClose, validateReplyBody: validateReplyBody, MAX_REPLY: MAX_REPLY,
+    outcomeLine: outcomeLine,
   };
 })();

package/modules/hall-ui/public/collab.css

@@ -300,3 +300,47 @@
    that ring, not a replacement for it. */
 .cb-reply-input:focus { border-color: var(--accent-ink); }
 .cb-reply-actions { display: flex; gap: 8px; margin: 7px 0 0; }
+
+/* ---- the archive (task 1004224) -------------------------------------------
+   History, not a queue. The whole section is a <details> that starts closed:
+   the three open blocks are what a reader came to Collab for, and an archive
+   that opened on its own would push them up the screen on behalf of work that
+   is already finished.
+
+   It is deliberately QUIETER than the blocks above it — no faces stack in the
+   head, no age pills in the rows, no accent anywhere. DESIGN.md spends the
+   accent on what is pressable or live, and nothing in here is either. */
+.cb-archive { margin-top: 18px; }
+.cb-archive__summary {
+  display: flex;
+  align-items: baseline;
+  gap: 9px;
+  cursor: pointer;
+  list-style: none;
+  padding: 2px 0;
+}
+.cb-archive__summary::-webkit-details-marker { display: none; }
+/* The disclosure triangle drawn as the hall draws its own, and rotated by the
+   element's own open state — no script, so it can never disagree with the
+   section it labels. */
+.cb-archive__summary::before {
+  content: "›";
+  display: inline-block;
+  color: var(--ink-faint);
+  transition: transform 120ms ease;
+}
+.cb-archive[open] > .cb-archive__summary::before { transform: rotate(90deg); }
+.cb-archive .cb-block__head { margin-bottom: 4px; }
+
+/* An archived row carries no thread, no controls and no age, so it sits lighter
+   than the row it used to be — the same words, visibly spent.
+
+   IN INK, NEVER IN OPACITY. The copy desk's own lesson (task 1003471): a state
+   drawn as opacity dims the PANEL through the row as well as the row's words,
+   which is why that page read muddy rather than quiet. The row's title steps
+   down to the soft ink and the sub line is already there. */
+.cb-row--archived .ov-row__title { color: var(--ink-soft); }
+/* On the facts line beside the direction and the context chip, so it reads as
+   one more fact about the ask rather than as an action in the column where
+   actions live. */
+.cb-outcome { color: var(--ink-faint); }

package/modules/hall-ui/public/collab.html

@@ -100,6 +100,43 @@
           </div>
         </section>
 
+        <!-- THE ARCHIVE (task 1004224, owner direction). Settled asks used to
+             simply vanish, which stopped being tolerable once the ledger began
+             settling them on its own: a row can now leave the board with nobody
+             watching it go. Two lists, because "what was asked of me" and "what I
+             asked of others" are different questions — a merged list would need a
+             per-row label saying which, and that is the same fact said worse.
+
+             CLOSED BY DEFAULT, and the whole section is behind one <details>.
+             This is history, not a queue: the page's three open blocks are what a
+             reader came for, and an archive that opened on its own would push
+             them up the screen on behalf of work that is finished. -->
+        <details class="scroll cb-block cb-archive" id="cb-archive">
+          <summary class="cb-archive__summary">
+            <span class="scroll__h">Archive</span>
+            <span class="cb-block__n" id="cb-archive-n"></span>
+          </summary>
+          <div class="view-zone view-zone--band cb-band">
+            <section class="cb-block" aria-labelledby="cb-arch-in-h">
+              <div class="cb-block__head">
+                <h3 class="scroll__h" id="cb-arch-in-h">Asked of you <span class="cb-block__n" id="cb-arch-in-n"></span></h3>
+              </div>
+              <ul class="ov-rows" id="cb-arch-in"></ul>
+              <div class="empty-state cb-empty" id="cb-arch-in-empty" hidden><p>Nothing anyone asked of you has been settled yet.</p></div>
+              <button class="btn-ghost cb-more" id="cb-arch-in-more" type="button" aria-expanded="false" aria-controls="cb-arch-in" hidden></button>
+            </section>
+
+            <section class="cb-block" aria-labelledby="cb-arch-out-h">
+              <div class="cb-block__head">
+                <h3 class="scroll__h" id="cb-arch-out-h">Asked of others <span class="cb-block__n" id="cb-arch-out-n"></span></h3>
+              </div>
+              <ul class="ov-rows" id="cb-arch-out"></ul>
+              <div class="empty-state cb-empty" id="cb-arch-out-empty" hidden><p>None of your asks have been settled yet.</p></div>
+              <button class="btn-ghost cb-more" id="cb-arch-out-more" type="button" aria-expanded="false" aria-controls="cb-arch-out" hidden></button>
+            </section>
+          </div>
+        </details>
+
         <!-- The one sentence of rules, said ONCE, at the foot. Answering is
              optional by design (ADR 0187 §3), and the page still says so; it
              just stops saying it first. -->
@@ -114,7 +151,7 @@
 <script src="/builders/shell.js?v=2026-09-22-movefeedback1"></script>
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/dom-utils.js?v=2026-06-23-contrib"></script>
-<script src="/builders/collab-lib.js?v=2026-09-23-sessionstart"></script>
-<script src="/builders/collab.js?v=2026-09-23-sessionstart"></script>
+<script src="/builders/collab-lib.js?v=2026-09-24-archive"></script>
+<script src="/builders/collab.js?v=2026-09-24-archive"></script>
 </body>
 </html>

package/modules/hall-ui/public/collab.js

@@ -114,7 +114,13 @@
   // do by hand the one thing it knows they came to do. It sits beside the door in
   // the CLOSED state on purpose — taking the ask away does not require reading it
   // here first.
-  function askHtml(req, key) {
+  //
+  // `spent` (task 1004224) drops the copy control on an ARCHIVED row. Copying an
+  // ask for a session start is the affordance for GOING AND DOING IT, and the
+  // one thing that is certain about an archived ask is that nobody is waiting on
+  // it. The door onto the full words stays: reading what was asked is the whole
+  // reason the archive exists.
+  function askHtml(req, key, spent) {
     const s = L.summaryOf(req.what_is_stuck);
     let html = `<span class="ov-row__title">${escapeHtml(s.title)}</span>`;
     if (s.lead) html += `<p class="ov-row__sub">${escapeHtml(s.lead)}</p>`;
@@ -127,9 +133,10 @@
       ? `<button class="cb-ask__door" type="button" data-ask-toggle aria-expanded="false" aria-controls="${fid}">Read the full ask</button>`
       : '';
     const full = s.more ? `<p class="cb-ask__full" id="${fid}" hidden>${escapeHtml(s.more)}</p>` : '';
-    return html + `<div class="cb-ask">${door}
-        <button class="cb-ask__copy" type="button" data-ask-copy="${escapeHtml(String(req.id))}">Copy for Session Start</button>
-      </div>${full}`;
+    const copy = spent ? ''
+      : `<button class="cb-ask__copy" type="button" data-ask-copy="${escapeHtml(String(req.id))}">Copy for Session Start</button>`;
+    if (!door && !copy) return html + full;
+    return html + `<div class="cb-ask">${door}${copy}</div>${full}`;
   }
 
   // ---- the thread (task 1004216, ADR 0330) -----------------------------------
@@ -314,6 +321,59 @@
     </li>`;
   }
 
+  // ---- the archive (task 1004224) ---------------------------------------------
+  //
+  // An archived row is a settled ask, and what it owes a reader is ONE fact the
+  // open rows never carry: how it ended. L.outcomeLine writes that sentence (and
+  // names the ledger when the ledger did it, rather than leaving an automatic
+  // close looking like an anonymous person). Everything else is deliberately
+  // LESS than an open row: no thread, no close control, no copy-for-session, no
+  // age pill. Those are all affordances for acting on an ask, and an archived ask
+  // is not actionable — a reply box under a closed question is an invitation to
+  // answer something nobody is waiting for. The face, the words and the context
+  // chip stay, because that is what makes the row recognisable as the one you
+  // remember.
+  //
+  // `dir` is which side of the ask the reader is on, and it picks both the face
+  // and the sentence: 'in' on the asks made OF them (the asker's face), 'out' on
+  // the asks they made (the addressee's). Exactly the pairing forMeRow and
+  // mineRow use, which is why an archived row reads like the open row it was.
+  function archiveRow(dir) {
+    return (req, nowMs, extra, key) => {
+      const outcome = L.outcomeLine(req);
+      // THE OUTCOME SITS WITH THE FACTS, NOT IN THE RIGHT COLUMN, and that is
+      // `mineRow`'s precedent rather than a new idea (artist verdict, task
+      // 1004041). Both archive lists are half-width, so the right column here is
+      // a few centimetres wide — a sentence put in it breaks mid-clause, and
+      // "Closed by itself when task / 1004200 shipped." is two lines saying one
+      // thing. How an ask ended IS a fact about it, so it reads in the line that
+      // holds the other facts, and the row keeps no right column at all: there
+      // is nothing on an archived row to act on.
+      const fact = outcome ? `<span class="ov-fact cb-outcome">${escapeHtml(outcome)}</span>` : '';
+      return `<li class="ov-row ov-row--lead cb-row cb-row--archived" data-id="${escapeHtml(String(req.id))}"${extra ? ' data-extra hidden' : ''}>
+        ${faceHtml(L.faceOf(req, dir))}
+        <div class="ov-row__main">${askHtml(req, key, true)}
+          <div class="ov-row__facts">${directionFact(req, dir)}${contextChip(req)}${fact}</div>
+        </div>
+      </li>`;
+    };
+  }
+
+  // The archive's own load, kept OUT of the page's opening fan-out on purpose.
+  // It is behind a closed <details>, so making the three blocks a reader actually
+  // came for wait on a fourth read of history would be paying for the one thing
+  // on the page nobody is looking at. Best-effort for the same reason the mingle
+  // panel is: an archive that will not load must never take Collab down with it.
+  async function loadArchive(nowMs) {
+    const r = await api.request('GET', '/help-requests/archive');
+    const inRows = (r.ok && r.data && r.data.asked_of_you) || [];
+    const outRows = (r.ok && r.data && r.data.asked_of_others) || [];
+    paintBlock('arch-in', inRows, archiveRow('in'), nowMs, false);
+    paintBlock('arch-out', outRows, archiveRow('out'), nowMs, false);
+    const total = $('#cb-archive-n');
+    if (total) total.textContent = inRows.length + outRows.length ? String(inRows.length + outRows.length) : '';
+  }
+
   // ---- a block: count, faces, the newest three, the door to the rest -----------
   //
   // `key` names the block's ids (cb-<key>, cb-<key>-n, -faces, -empty, -more).
@@ -542,6 +602,10 @@
         : `With no ${axis} set, only asks addressed to you by name land in your block.`;
     }
 
+    // The archive, after the blocks are painted. Best-effort: history that will
+    // not load must not take the board down with it.
+    try { await loadArchive(nowMs); } catch (_) { /* the archive stays as it was */ }
+
     // The social half. Best-effort and LAST: an introductions read that fails
     // must never take the help requests down with it — those are the page.
     try { await loadMingle(); } catch (_) { /* the panel stays as it was */ }

package/modules/lifecycle/collab-settle.js

@@ -0,0 +1,77 @@
+// modules/lifecycle/collab-settle.js — settle the collab tables from the ledger
+// at most once per short window, however many list routes ask (task 1004224).
+//
+// WHY THIS EXISTS. `settleFromLedger` is idempotent and bounded, so calling it on
+// every list read is CORRECT — but one Collab page load fans out across four
+// help-request routes plus, on other surfaces, three recommendation ones, and
+// each of those fired its own UPDATE. Three to six of them found nothing and
+// wrote nothing, which is wasted write volume on a read path and, with many
+// builders opening Collab at once, avoidable row-lock contention on the same
+// still-open rows. The settles were right; their FREQUENCY was not.
+//
+// A TIME WINDOW, NOT A PER-REQUEST MEMO. The obvious fix — settle once per
+// request — does not help, because the page's four reads are four separate HTTP
+// requests and there is no request to share. What they do share is a few hundred
+// milliseconds, so this collapses a burst into one write.
+//
+// THE WINDOW IS SHORT ON PURPOSE. It is a burst collapser, not a cache: the
+// latency it can add is bounded by WINDOW_MS, so a task that ships now is
+// reflected on the next load a second later rather than on some poller's
+// schedule. Making it minutes would turn a correctness property into a staleness
+// budget nobody asked for.
+//
+// FAILURE DOES NOT POISON THE WINDOW. A settle that throws clears its own
+// timestamp, so the next read retries instead of waiting out a window on the
+// strength of an attempt that did nothing. The inverse — marking the window on
+// entry and never clearing — would turn one transient database error into a
+// silent stall.
+//
+// PER PROCESS, and that is fine. Several web processes each settling once per
+// window is still an order of magnitude fewer writes than every route settling
+// on every read, and the UPDATE is idempotent, so a second process racing the
+// first simply finds nothing to do.
+
+'use strict';
+
+const WINDOW_MS = 1000;
+
+const lastRun = new Map();
+const inFlight = new Map();
+
+// `key` names the table being settled, so the two collab tables do not share a
+// window — a Collab page load settles help requests, and a surface that reads
+// recommendations must not be told the work is already done because somebody
+// opened Collab a moment ago.
+//
+// A settle already in flight is AWAITED rather than skipped: two concurrent
+// requests should both see the settled rows, and returning early from the second
+// would hand it the pre-settle state while claiming the settle had happened.
+function throttled(key, run) {
+  const now = Date.now();
+  const pending = inFlight.get(key);
+  if (pending) return pending;
+  const last = lastRun.get(key);
+  if (last != null && now - last < WINDOW_MS) return Promise.resolve(null);
+
+  lastRun.set(key, now);
+  const p = Promise.resolve()
+    .then(run)
+    .catch((err) => {
+      // Let the next read try again rather than waiting out a window on the
+      // strength of an attempt that wrote nothing.
+      lastRun.delete(key);
+      throw err;
+    })
+    .finally(() => { inFlight.delete(key); });
+  inFlight.set(key, p);
+  return p;
+}
+
+// Test seam. The window is real time, so a test that wanted to observe two
+// settles would otherwise have to sleep.
+function _reset() {
+  lastRun.clear();
+  inFlight.clear();
+}
+
+module.exports = { WINDOW_MS, throttled, _reset };