@bongos/core 1.18.19 → 1.19.3

package/scripts/gds/sequence.js

@@ -218,6 +218,31 @@ function haltReasons(task, { rank, claimableIds = null } = {}) {
   return reasons;
 }
 
+// Walk the plan in order and return the first task that clears the halt matrix,
+// plus the ones passed over on the way.
+//
+// Topological order is a DEPENDENCY ordering, not a runnability ordering: a
+// blocked task that sorts first used to hide every independent ready task
+// behind it, so --next reported "nothing runnable" on a goal with claimable
+// work (reproduced 2026-08-05 on goal 1000030 — a backlog perf task sat at
+// position 0 while two ready tasks sat at 1 and 2). Scanning past it does NOT
+// weaken any gate: a task is still only offered if it clears haltReasons() on
+// its own, and deps are part of that (an unmet dep leaves status != 'ready').
+//
+// Skipping is never silent — the caller reports `skipped` — because "here is
+// task 3" without "1 and 2 need a human" would quietly bury work.
+function pickNext(plan, { rank, claimableIds = null } = {}) {
+  const skipped = [];
+  for (const task of plan) {
+    const reasons = haltReasons(task, { rank, claimableIds });
+    if (!reasons.length) return { next: task, skipped };
+    skipped.push({ id: task.id, title: task.title, reasons });
+  }
+  // Nothing in the plan clears. The head's reasons are the ones worth printing
+  // (it is the task the chain actually wants next); the rest become the count.
+  return { next: null, skipped, head: plan[0] || null };
+}
+
 function summarize(tasks) {
   return tasks.reduce(
     (acc, t) => ({
@@ -323,6 +348,21 @@ function printHalt(task, reasons) {
   console.log('\nThis one needs a human. Everything already shipped stays shipped.');
 }
 
+// The tasks --next walked past. Printed BEFORE the pick so the skip is the
+// first thing read, not a footnote under the answer.
+function printSkipped(skipped) {
+  if (!skipped.length) return;
+  const n = skipped.length;
+  console.log(`Skipped ${n} task${n === 1 ? '' : 's'} that can't run yet:`);
+  for (const s of skipped) {
+    const [first, ...rest] = s.reasons;
+    const also = rest.length ? ` (also: ${rest.map((r) => r.code).join(', ')})` : '';
+    console.log(`  • task ${s.id} — [${first.code}] ${first.detail}${also}`);
+    console.log(`      ${s.title}`);
+  }
+  console.log('');
+}
+
 // -------------------------------------------------------------------------
 // Main
 // -------------------------------------------------------------------------
@@ -376,20 +416,38 @@ async function main() {
       console.log(opts.json ? JSON.stringify(payload, null, 2) : `${HALT_REASONS.chain_complete} in ${scope}.`);
       process.exit(0);
     }
-    const reasons = haltReasons(head, { rank, claimableIds });
-    if (reasons.length) {
-      const payload = { next: null, stop: reasons[0].code, reasons, task: { id: head.id, title: head.title } };
+    // Scan the whole plan, not just the head — a blocked task at position 0
+    // must not hide runnable work behind it (see pickNext).
+    const { next: pick, skipped } = pickNext(plan, { rank, claimableIds });
+    if (!pick) {
+      // Everything was skipped, so skipped[0] IS the head — reuse its reasons
+      // rather than recomputing them and risking the two printouts diverging.
+      const reasons = skipped[0].reasons;
+      const payload = {
+        next: null,
+        stop: reasons[0].code,
+        reasons,
+        task: { id: head.id, title: head.title },
+        tried: plan.length,
+        skipped,
+      };
       if (opts.json) console.log(JSON.stringify(payload, null, 2));
-      else printHalt(head, reasons);
+      else {
+        printHalt(head, reasons);
+        if (plan.length > 1) {
+          console.log(`\nChecked all ${plan.length} open tasks in ${scope} — none can run right now.`);
+        }
+      }
       process.exit(1);
     }
     const remaining = summarize(plan);
     if (opts.json) {
-      console.log(JSON.stringify({ next: head, remaining, scope }, null, 2));
+      console.log(JSON.stringify({ next: pick, remaining, scope, skipped }, null, 2));
     } else {
-      console.log(`Next in ${scope}: task ${head.id} — ${head.title}`);
-      console.log(`  ${head.credits_reward ?? 0}c · ${fmtMinutes(head.est_minutes_calibrated ?? head.est_minutes ?? 0)} · ${remaining.count - 1} more after this`);
-      console.log(`  node scripts/gds/claim.js ${head.id}`);
+      printSkipped(skipped);
+      console.log(`Next in ${scope}: task ${pick.id} — ${pick.title}`);
+      console.log(`  ${pick.credits_reward ?? 0}c · ${fmtMinutes(pick.est_minutes_calibrated ?? pick.est_minutes ?? 0)} · ${remaining.count - 1} more open in this chain`);
+      console.log(`  node scripts/gds/claim.js ${pick.id}`);
     }
     process.exit(0);
   }
@@ -415,6 +473,7 @@ module.exports = {
   topoOrder,
   chainFrom,
   haltReasons,
+  pickNext,
   summarize,
   HALT_REASONS,
   RANK_TIER,