@bongos/core 1.17.2 → 1.17.3

package/scripts/hall-preview/README.md

@@ -0,0 +1,103 @@
+# Hall preview harness
+
+The dev-box sandbox previews the **game only** — `/builders` 404s there (idea 490) — so
+hall-ui changes are reviewed here: a DB-less fixture server that serves the **real**
+`modules/hall-ui/public` files through the **real** serving seams (boot-time `?v=`
+content-hash stamping, `{{token}}` replacement, `window.__BRANDING__`/`__MODULES__`
+injection, theme markup), answering every `/api/gds|bongos/*` read from checked-in
+fixtures. Proven recipe from tasks 1723/1742, checked in by task 2167.
+
+## Quickstart
+
+```bash
+node scripts/hall-preview/server.js                 # neutral pack, port 4600
+# → browse http://builders.localhost:4600/          (Chromium resolves *.localhost;
+#   the builders. host prefix exercises the real subdomain serving path)
+```
+
+| Flag | Effect |
+|---|---|
+| `--port 4600` | listen port |
+| `--brand config/branding.json` | serve the instance pack (default: `config/branding.neutral.json`, the vanilla skin) |
+| `--modules-off dev-box,provisioning` | report those modules disabled in `window.__MODULES__` — verifies `moduleOn()` gating (Harbor nav item, Instances/Start-a-project widgets must vanish) |
+| `--empty` | drain every array in every fixture — the empty-state screenshot pass |
+
+Writes are not wired: any `POST/PATCH/DELETE` answers `501 preview_readonly`.
+A GET with no fixture answers 404 and logs
+`no fixture: <path>` — that log line names the exact file to add.
+
+## Fixtures
+
+`fixtures/<path>.json`, slashes as `__` (`/me/recent-ships` → `me__recent-ships.json`).
+Query strings are ignored. Id-bearing paths try the exact file first
+(`goals__25.json`), then a generic fallback (`goals__detail.json`, `tasks__detail.json`,
+`analytics__builder.json`, …) so one fixture serves any id.
+
+Refresh from live data (needs a GDS CLI session; read-only; Archon-gated endpoints
+skip for lower ranks and keep the checked-in synthetic empties):
+
+```bash
+node scripts/hall-preview/refresh-fixtures.js
+```
+
+Box/terminal endpoints are deliberately never snapshotted (connection details).
+
+## The evidence matrix (per page-redesign ship)
+
+Screenshot every changed page at **{light, dark} × {1280w, 390w}**, plus one
+instance-pack run (`--brand config/branding.json`) proving the theming contract
+survives. With the Playwright MCP (`npx playwright install chrome` once):
+
+1. `browser_navigate` → the page. `browser_console_messages` must show **0 errors**.
+2. 1280w: `browser_resize 1280×900` → `browser_take_screenshot` (fullPage for tall pages).
+3. dark: `browser_evaluate` `() => { localStorage.setItem('hall-theme','dark'); location.reload(); }` → screenshot. (Reset with `'light'`.)
+4. 390w: `browser_resize 390×844` → light + dark screenshots.
+
+## Seam assertions (copy-paste `browser_evaluate` snippets)
+
+The hard seams every redesign must keep. Run on each changed page:
+
+```js
+// 1. Window is the ONLY scroller — no inner scroll pane may appear.
+() => [...document.querySelectorAll('.app-content *')].filter((el) => {
+  const s = getComputedStyle(el);
+  return /(auto|scroll)/.test(s.overflowY) && el.scrollHeight > el.clientHeight + 1
+    && !el.matches('.section-rail, .kit-tabs');   // the two sanctioned x-scroll strips
+}).map((el) => el.className).join(',') || 'OK'
+
+// 2. Deep-link overlay namespace intact: #/idea/N opens the overlay…
+() => { location.hash = '#/idea/1';
+  return new Promise((r) => setTimeout(() => r(
+    document.querySelector('.deeplink-overlay, #deeplink') ? 'overlay OK' : 'OVERLAY BROKEN'), 400)); }
+
+// …and #/task/N navigates to the task page (task-detail.js redirect).
+() => { location.hash = '#/task/5'; return 'expect navigation to /task/5'; }
+
+// 3. Index hash views: exactly one .view visible per hash.
+() => ['#home', '#standing', '#leaderboard'].map((h) => { location.hash = h;
+  return `${h}:${[...document.querySelectorAll('main .view, main [id^="view-"]')]
+    .filter((v) => !v.hidden).length}`; }).join(' ')   // each → :1
+
+// 4. Goals sub-routes: #/goal/25 opens detail; back restores the list.
+() => { location.hash = '#/goal/25'; return new Promise((r) => setTimeout(() =>
+  r(document.querySelector('#goal-detail, [data-goal-view="detail"]') ? 'detail OK' : 'BROKEN'), 400)); }
+
+// 5. SSE nudge triggered one refetch (the harness emits a single nudge ~1.2s
+// after connect): watch the network panel, or count via a fixture hit log line.
+```
+
+Module gating: rerun the page with `--modules-off dev-box,provisioning` — the
+Harbor nav item and the Instances/Start-a-project widgets must be absent, with
+zero console errors.
+
+## Gotchas
+
+- **Worktrees have no `node_modules`** — the server resolves `express` via node's
+  upward walk (the main checkout's copy). The `src/` seams always load from *this*
+  tree, so a worktree's edits are exactly what renders.
+- The harness serves pages **pre-auth** (its page handlers register before
+  `mountInternalSurfaces`). Auth-gated *page* behavior (sign-in redirects, Archon
+  gates) is server truth — do not judge it here; assets and 404s fall through to
+  the real internal-surface code.
+- The SSE fixture logs one console error against JSON-fixture parsing on some
+  pages — pages tolerate it; a page's own console must otherwise be clean.

package/scripts/hall-preview/fixtures/access-requests.json

@@ -0,0 +1 @@
+{ "requests": [] }

package/scripts/hall-preview/fixtures/achievements.json

@@ -0,0 +1,76 @@
+{
+  "achievements": [
+    {
+      "id": "first-ship",
+      "name": "First Ship",
+      "description": "Ship your first task.",
+      "icon": "📦",
+      "credit_bonus": 1,
+      "sort_order": 10
+    },
+    {
+      "id": "first-claim",
+      "name": "First Claim",
+      "description": "Claim your first task.",
+      "icon": "🪙",
+      "credit_bonus": 1,
+      "sort_order": 20
+    },
+    {
+      "id": "first-parallel-claim",
+      "name": "First Parallel Claim",
+      "description": "Hold two simultaneous claims; ship both successfully.",
+      "icon": "⚓",
+      "credit_bonus": 2,
+      "sort_order": 30
+    },
+    {
+      "id": "streak-3",
+      "name": "Streak: 3 Nights",
+      "description": "Ship a task in 3 consecutive local-time nights (>=15min; cleanup/refactor now counts).",
+      "icon": "🔥",
+      "credit_bonus": 2,
+      "sort_order": 40
+    },
+    {
+      "id": "streak-7",
+      "name": "Streak: 7 Nights",
+      "description": "Ship a task in 7 consecutive local-time nights (>=15min; cleanup/refactor now counts).",
+      "icon": "🌋",
+      "credit_bonus": 5,
+      "sort_order": 50
+    },
+    {
+      "id": "art-pipeline-shipper",
+      "name": "Art Pipeline Shipper",
+      "description": "Ship a task whose touches[] include the art/ pipeline.",
+      "icon": "🎨",
+      "credit_bonus": 2,
+      "sort_order": 60
+    },
+    {
+      "id": "subtractor",
+      "name": "Subtractor",
+      "description": "Earn the net-negative ship bonus on 3 ships — across your work you have deleted more than you have added.",
+      "icon": "🪓",
+      "credit_bonus": 2,
+      "sort_order": 65
+    },
+    {
+      "id": "gds-shipper",
+      "name": "GDS Shipper",
+      "description": "Ship a task whose touches[] include src/gds/ or scripts/gds/.",
+      "icon": "⚙️",
+      "credit_bonus": 2,
+      "sort_order": 70
+    },
+    {
+      "id": "breaking-the-100c-bar",
+      "name": "Breaking the 100c Bar",
+      "description": "Cross 100 total credits.",
+      "icon": "💯",
+      "credit_bonus": 5,
+      "sort_order": 80
+    }
+  ]
+}

package/scripts/hall-preview/fixtures/analytics__builder.json

@@ -0,0 +1,251 @@
+{
+  "builder_id": 95,
+  "window_days": 90,
+  "ship_rate": [
+    {
+      "day": "2026-06-22",
+      "n": 2
+    },
+    {
+      "day": "2026-06-23",
+      "n": 3
+    },
+    {
+      "day": "2026-06-25",
+      "n": 7
+    },
+    {
+      "day": "2026-06-26",
+      "n": 8
+    },
+    {
+      "day": "2026-06-27",
+      "n": 12
+    },
+    {
+      "day": "2026-06-28",
+      "n": 17
+    },
+    {
+      "day": "2026-06-29",
+      "n": 9
+    },
+    {
+      "day": "2026-06-30",
+      "n": 5
+    },
+    {
+      "day": "2026-07-02",
+      "n": 7
+    },
+    {
+      "day": "2026-07-03",
+      "n": 17
+    },
+    {
+      "day": "2026-07-04",
+      "n": 6
+    },
+    {
+      "day": "2026-07-05",
+      "n": 11
+    },
+    {
+      "day": "2026-07-10",
+      "n": 6
+    }
+  ],
+  "cost_trend": [
+    {
+      "day": "2026-06-22",
+      "total_usd": 33.45,
+      "n_tasks": 0,
+      "per_work": 16.73
+    },
+    {
+      "day": "2026-06-23",
+      "total_usd": 131.56,
+      "n_tasks": 0,
+      "per_work": 33
+    },
+    {
+      "day": "2026-06-24",
+      "total_usd": 0,
+      "n_tasks": 0,
+      "per_work": 33
+    },
+    {
+      "day": "2026-06-25",
+      "total_usd": 194.21,
+      "n_tasks": 0,
+      "per_work": 29.94
+    },
+    {
+      "day": "2026-06-26",
+      "total_usd": 74.35,
+      "n_tasks": 0,
+      "per_work": 21.68
+    },
+    {
+      "day": "2026-06-27",
+      "total_usd": 16.08,
+      "n_tasks": 0,
+      "per_work": 14.05
+    },
+    {
+      "day": "2026-06-28",
+      "total_usd": 24.24,
+      "n_tasks": 0,
+      "per_work": 9.67
+    },
+    {
+      "day": "2026-06-29",
+      "total_usd": 57.04,
+      "n_tasks": 0,
+      "per_work": 9.15
+    },
+    {
+      "day": "2026-07-02",
+      "total_usd": 198.6,
+      "n_tasks": 0,
+      "per_work": 10.42
+    },
+    {
+      "day": "2026-07-03",
+      "total_usd": 297.04,
+      "n_tasks": 0,
+      "per_work": 11.8
+    },
+    {
+      "day": "2026-07-04",
+      "total_usd": 0.74,
+      "n_tasks": 0,
+      "per_work": 11.05
+    },
+    {
+      "day": "2026-07-05",
+      "total_usd": 154.61,
+      "n_tasks": 0,
+      "per_work": 11.36
+    },
+    {
+      "day": "2026-07-06",
+      "total_usd": 0.6,
+      "n_tasks": 0,
+      "per_work": 11.37
+    },
+    {
+      "day": "2026-07-10",
+      "total_usd": 59.44,
+      "n_tasks": 0,
+      "per_work": 11.29
+    }
+  ],
+  "duration_trend": [
+    {
+      "day": "2026-06-22",
+      "avg_actual": 28,
+      "avg_est": 40
+    },
+    {
+      "day": "2026-06-23",
+      "avg_actual": 125,
+      "avg_est": 147
+    },
+    {
+      "day": "2026-06-25",
+      "avg_actual": 242,
+      "avg_est": 283
+    },
+    {
+      "day": "2026-06-26",
+      "avg_actual": 16,
+      "avg_est": 184
+    },
+    {
+      "day": "2026-06-27",
+      "avg_actual": 12,
+      "avg_est": 154
+    },
+    {
+      "day": "2026-06-28",
+      "avg_actual": 85,
+      "avg_est": 140
+    },
+    {
+      "day": "2026-06-29",
+      "avg_actual": 19,
+      "avg_est": 221
+    },
+    {
+      "day": "2026-06-30",
+      "avg_actual": 12,
+      "avg_est": 150
+    },
+    {
+      "day": "2026-07-03",
+      "avg_actual": 15,
+      "avg_est": 60
+    },
+    {
+      "day": "2026-07-04",
+      "avg_actual": 17,
+      "avg_est": 270
+    },
+    {
+      "day": "2026-07-05",
+      "avg_actual": 8,
+      "avg_est": 65
+    },
+    {
+      "day": "2026-07-10",
+      "avg_actual": 8,
+      "avg_est": 108
+    }
+  ],
+  "grade_trend": [],
+  "top_kinds": [
+    {
+      "kind": "feature",
+      "n": 62
+    },
+    {
+      "kind": "refactor",
+      "n": 12
+    },
+    {
+      "kind": "bug",
+      "n": 11
+    },
+    {
+      "kind": "infra",
+      "n": 7
+    },
+    {
+      "kind": "decision",
+      "n": 6
+    },
+    {
+      "kind": "cleanup",
+      "n": 5
+    },
+    {
+      "kind": "learning-capture",
+      "n": 4
+    },
+    {
+      "kind": "spike",
+      "n": 3
+    }
+  ],
+  "headline": {
+    "total_shipped": 110,
+    "total_cost_usd": 1241.96,
+    "cost_per_task": 11.29,
+    "avg_duration_min": 39,
+    "confirmation_rate": 0.85,
+    "resolved_claims": 136,
+    "grade_pass_rate": null,
+    "graded_n": 0
+  }
+}

package/scripts/hall-preview/fixtures/audit-log.json

@@ -0,0 +1 @@
+{ "rows": [] }

package/scripts/hall-preview/fixtures/boxes__cost-ledger.json

@@ -0,0 +1 @@
+{ "totals_by_builder": [], "ledger": [] }

package/scripts/hall-preview/fixtures/builders__active-claims.json

@@ -0,0 +1 @@
+{ "claims": [] }

package/scripts/hall-preview/fixtures/builders__directory.json

@@ -0,0 +1,81 @@
+{
+  "builders": [
+    {
+      "id": "25",
+      "github_login": "IAMMASTERQUA",
+      "display_name": "IAMMASTERQUA",
+      "avatar_url": "https://avatars.githubusercontent.com/u/290184380?v=4",
+      "rank": "metic"
+    },
+    {
+      "id": "95",
+      "github_login": "jaxri",
+      "display_name": "Jackson Rini",
+      "avatar_url": "https://avatars.githubusercontent.com/u/64553469?v=4",
+      "rank": "metic"
+    },
+    {
+      "id": "3",
+      "github_login": "LarsCode",
+      "display_name": "LarsCode",
+      "avatar_url": "https://avatars.githubusercontent.com/u/35337514?v=4",
+      "rank": "xenos"
+    },
+    {
+      "id": "51",
+      "github_login": "MrTenkpro",
+      "display_name": "MrTenkpro",
+      "avatar_url": "https://avatars.githubusercontent.com/u/291558470?v=4",
+      "rank": "xenos"
+    },
+    {
+      "id": "50",
+      "github_login": "Svensson-CMD",
+      "display_name": "Svensson-CMD",
+      "avatar_url": "https://avatars.githubusercontent.com/u/290959655?v=4",
+      "rank": "xenos"
+    },
+    {
+      "id": "71",
+      "github_login": "erikwils",
+      "display_name": "erikwils",
+      "avatar_url": "https://avatars.githubusercontent.com/u/51457175?v=4",
+      "rank": "xenos"
+    },
+    {
+      "id": "70",
+      "github_login": "kingaonline",
+      "display_name": "kingaonline",
+      "avatar_url": "https://avatars.githubusercontent.com/u/293641659?v=4",
+      "rank": "thetes"
+    },
+    {
+      "id": "57",
+      "github_login": "largekristensen-svg",
+      "display_name": "largekristensen-svg",
+      "avatar_url": "https://avatars.githubusercontent.com/u/292408002?v=4",
+      "rank": "xenos"
+    },
+    {
+      "id": "1",
+      "github_login": "lars589",
+      "display_name": "lars589",
+      "avatar_url": "https://avatars.githubusercontent.com/u/283020391?v=4",
+      "rank": "archon"
+    },
+    {
+      "id": "94",
+      "github_login": "scootermack",
+      "display_name": "scootermack",
+      "avatar_url": "https://avatars.githubusercontent.com/u/295990394?v=4",
+      "rank": "metic"
+    },
+    {
+      "id": "27",
+      "github_login": "willHermesLines",
+      "display_name": "willHermesLines",
+      "avatar_url": "https://avatars.githubusercontent.com/u/267458743?v=4",
+      "rank": "xenos"
+    }
+  ]
+}

package/scripts/hall-preview/fixtures/builders__roster.json

@@ -0,0 +1 @@
+{ "builders": [] }