@bongos/core 1.17.1 → 1.17.3

package/server.js

@@ -1,212 +0,0 @@
-const http = require('http');
-const path = require('path');
-const express = require('express');
-const { Server, matchMaker } = require('colyseus');
-const { WebSocketTransport } = require('@colyseus/ws-transport');
-const { isApiShapedPath, apiNotFoundBody } = require('./src/bongos/api-path-404');
-const uptimePoller = require('./src/bongos/uptime-poller');
-const moduleLoader = require('./src/module-loader/loader');
-const { mountInternalSurfaces, isStatusHost } = require('./src/bongos/serve-internal');
-const { isModuleEnabled } = require('./src/modules');
-const seams = require('./src/module-seams');
-
-const PORT = Number(process.env.PORT) || 3000;
-const HOST = process.env.HOST || '127.0.0.1';
-
-const app = express();
-app.disable('x-powered-by');
-// Behind Cloudflare → Caddy → Node. Trust the immediate proxy so
-// req.secure / x-forwarded-proto reflect reality for OAuth callbacks.
-app.set('trust proxy', 1);
-
-// All non-game surfaces — /healthz, /version, /api/gds, the Dev Box download
-// redirects, and the status + builders hosts — are served by the shared internal
-// surface module (ADR 0062 R51, task 1190). This also calls mountModuleRoutes,
-// which runs each enabled module's route factory — including the game module's,
-// which registers the game.staticRoot / game.registerRooms / game.precreateWorldRoom
-// seam ports before the code below resolves them (ADR 0083 / BV1.R49).
-// Mounted before the game tail below so /builders/* + the status host
-// short-circuit ahead of the game static middleware.
-mountInternalSurfaces(app);
-
-app.use((req, res, next) => {
-  // From here down: only the game host. Skip if request was for the status
-  // host (it should already be handled, but defense in depth).
-  if (isStatusHost(req)) return res.status(404).type('text/plain').send('not found');
-  next();
-});
-
-app.use(
-  '/vendor/phaser.min.js',
-  express.static(path.join(__dirname, 'node_modules/phaser/dist/phaser.min.js'), {
-    maxAge: '1d',
-  })
-);
-
-app.use(
-  '/vendor/colyseus.js',
-  express.static(path.join(__dirname, 'node_modules/colyseus.js/dist/colyseus.js'), {
-    maxAge: '1d',
-  })
-);
-
-// Game static files — served from the game module's public/ dir (modules/game/public/).
-// The path is provided by the game module via the game.staticRoot seam port, registered
-// by modules/game/routes/game.js when the loader runs mountModuleRoutes above.
-// If the game module is disabled (vanilla Cloud Bongos boot) these blocks are simply
-// skipped — no game assets served, no 404.html, no client JS. The platform API still
-// works via mountInternalSurfaces above.
-const _gameStaticRoot = seams.resolveOptional('game.staticRoot');
-if (_gameStaticRoot) {
-  const gamePublic = _gameStaticRoot();
-
-  // Tile-asset cache strategy (task #55 + #160 + #176).
-  //
-  // Three buckets:
-  //   1. Content-hashed atlas (atlas-<sha8>.png + atlas-<sha8>.json if any)
-  //      Filename changes with content → safe to cache forever. Marked
-  //      immutable so browsers / CF skip revalidation entirely.
-  //   2. Stable-URL files paired with bucket 1 (atlas-index.json, manifest.json,
-  //      atlas.json). URLs don't change across deploys but contents do, so
-  //      they get a short TTL — a deploy is visible within ~1 minute. atlas.json
-  //      lives here because tilePalette.js still hardcodes its URL; until the
-  //      build hashes it (idea_inbox follow-up), the short TTL is what prevents
-  //      the post-deploy "new PNG + stale frame coords" mismatch window.
-  //   3. Legacy unhashed per-tile PNGs + everything else under /assets/tiles
-  //      Short TTL (5 min) until they migrate to content-hashed names. The
-  //      old 1-day TTL is what caused the 2026-05-10 stale-atlas incident.
-  app.use(
-    '/assets/tiles',
-    express.static(path.join(gamePublic, 'assets/tiles'), {
-      setHeaders: (res, filePath) => {
-        const name = path.basename(filePath);
-        if (/^atlas-[a-f0-9]{8,}\.(png|json)$/.test(name)) {
-          res.setHeader('Cache-Control', 'public, max-age=31536000, immutable');
-        } else if (
-          name === 'atlas-index.json' ||
-          name === 'manifest.json' ||
-          name === 'atlas.json'
-        ) {
-          res.setHeader('Cache-Control', 'public, max-age=60');
-        } else {
-          res.setHeader('Cache-Control', 'public, max-age=300');
-        }
-      },
-    })
-  );
-
-  // HTML + game JS — short TTL so deploys are visible quickly. .js files in
-  // game/ are not content-hashed today (V1 shortcut), so a long TTL would
-  // compound the stale-art class of bugs into stale-code bugs.
-  app.use(
-    express.static(gamePublic, {
-      extensions: ['html'],
-      setHeaders: (res, filePath) => {
-        if (/\.(html|js|json)$/.test(filePath)) {
-          res.setHeader('Cache-Control', 'public, max-age=60');
-        } else {
-          res.setHeader('Cache-Control', 'public, max-age=300');
-        }
-      },
-    })
-  );
-}
-
-// Themed 404 for the game host. Anything that didn't resolve to an API route,
-// the status/builders hosts, or a static file lands here.
-// The status host has its own plain-text 404 above; we don't poach it.
-// API-SHAPED paths get a JSON 404 with a corrective hint — never the HTML island
-// page — so a caller that missed the /api/gds mount (curl /tasks, /gds/*, an
-// /api/* typo) gets a self-describing error instead of HTML that JSON.parse-faults
-// on the client (V4.R14 / #952). The match is broader than the old `/api/` test:
-// it also catches the bare GDS resource roots a human hits without the prefix.
-app.use((req, res) => {
-  if (isStatusHost(req)) return res.status(404).type('text/plain').send('not found');
-  res.status(404);
-  if (isApiShapedPath(req.path)) {
-    return res.json(apiNotFoundBody(req.path));
-  }
-  if (req.method === 'GET' && req.accepts('html')) {
-    res.setHeader('Cache-Control', 'public, max-age=60');
-    const gameStaticRoot = seams.resolveOptional('game.staticRoot');
-    if (gameStaticRoot) {
-      return res.sendFile(path.join(gameStaticRoot(), '404.html'));
-    }
-    return res.type('text/plain').send('404 — not found');
-  }
-  return res.type('text/plain').send('404 — you have washed ashore on the wrong island');
-});
-
-const httpServer = http.createServer(app);
-
-const gameServer = new Server({
-  transport: new WebSocketTransport({ server: httpServer }),
-});
-
-// The PRODUCT/game rooms (world + queue) — registered via the game module's seam
-// port (game.registerRooms), wired by modules/game/routes/game.js at loader mount
-// time. Only called when the game module is enabled (OTB does; vanilla skips).
-// The game-less platform entrypoint (src/platform-server.js) never constructs a
-// Colyseus server at all. The builders' hall live channel is NOT a Colyseus room —
-// it rides the SSE endpoint (src/bongos/routes/live.js, ADR 0069).
-const _registerRooms = seams.resolveOptional('game.registerRooms');
-if (_registerRooms) {
-  _registerRooms(gameServer);
-} else {
-  console.log('[game] game module disabled — no Colyseus rooms registered');
-}
-
-uptimePoller.start();
-
-// task 1134 — the server-owned publish reconciler (drives 'confirmed' tasks whose
-// branch has merged + deployed to 'shipped' on a timer, ADR 0055). CARVED into the
-// lifecycle module at BV1.R86 (ADR 0093 §1): it now starts via the loader's
-// startModulePollers (a declared poller — modules/lifecycle/pollers/publish-
-// reconciler.js), in the listen callback below alongside the Discord bot + routine
-// timers — so server.js no longer reaches into the lifecycle module to start it.
-// No-op without a push credential (local dev/tests); kill-switch via
-// PUBLISH_RECONCILER_DISABLED. Unref'd timers, best-effort — never takes the
-// game/API down.
-
-// task 1382 (ADR 0078 amendment) — server-internal routine timers (peer-vote-tally,
-// weekly, in-process; no model, no external cron). CARVED into the autonomy module
-// at BV1.R83 (ADR 0093 §1): it now starts via the loader's startModulePollers (a
-// declared poller — modules/autonomy/pollers/routine-timers.js), in the listen
-// callback below alongside the Discord bot poller. server.js is still the only
-// startModulePollers caller (not the game-less platform entrypoint), so a second
-// always-on instance can't double-run. Kill-switch ROUTINE_TIMERS_DISABLED stays.
-
-httpServer.listen(PORT, HOST, async () => {
-  console.log(`Amazonprimea listening on ${HOST}:${PORT}`);
-  // Pre-create the singleton WorldRoom so clients can use
-  // `client.join('world')` (existing-only, no auto-create on overflow). The
-  // precreate function is provided by the game module via the seam port
-  // game.precreateWorldRoom; idempotent + failure-tolerant.
-  const _precreate = seams.resolveOptional('game.precreateWorldRoom');
-  if (_precreate) {
-    await _precreate(matchMaker);
-  }
-
-  // Start each ENABLED module's web-process background pollers through the loader
-  // — module-agnostic: it requires modules/<key>/pollers/<name>.js and fires
-  // start(). The Discord bot (ADR 0033) is one such poller; a vanilla instance
-  // with discord off simply has no poller to start, and never reads a webhook/bot
-  // token. Non-blocking + failure-isolated by the loader (a poller problem must
-  // never take the game/API down) — the module-agnostic successor to the
-  // hardcoded discordBot.start() block (ADR 0083 / BV1.R47, task 1416).
-  moduleLoader.startModulePollers({}, { isEnabled: isModuleEnabled });
-});
-
-// Graceful shutdown — stop the in-process pollers, then stop each module poller
-// (e.g. close the Discord gateway socket cleanly on a systemd restart / Ctrl-C so
-// we don't leave a zombie session for Discord to reap). stopModulePollers awaits
-// each stop and isolates errors, so a stuck poller never blocks the exit (BV1.R47).
-for (const sig of ['SIGTERM', 'SIGINT']) {
-  process.on(sig, () => {
-    // The publish reconciler + routine timers now stop via
-    // moduleLoader.stopModulePollers() — the lifecycle module's publish-reconciler
-    // poller (carved BV1.R86) + the autonomy module's routine-timers poller
-    // (carved BV1.R83 / ADR 0093 §1).
-    moduleLoader.stopModulePollers().finally(() => process.exit(0));
-  });
-}

package/tests/art_key.mjs

@@ -1,121 +0,0 @@
-// tests/art_key.mjs
-//
-// Unit smoke for modules/art-pipeline/art-key.js (task 1281, moved BV1.R48) — the GDS-delivered SHARED Gemini
-// key for newcomers. Covers the pure entitlement decision (xenos in; thetes+ out;
-// unknown rank fails closed), the env/file key loader, and the describeArtKey
-// payload shape. The route (routes/me.js) + the local sync (fetch-art-key.js) and
-// the pipeline tier (gen_api.py) are exercised by the endpoint smoke + manual
-// resolution check; here we cover the logic without pg or network.
-//
-// Hermetic: the "not configured" cases unset SHARED_ART_GEMINI_KEY and repoint
-// HOME at an empty temp dir so the ~/.config/otb/gemini-shared.json fallback can't
-// resolve to a real operator file on the test machine.
-//
-// Run:  node tests/art_key.mjs
-
-import { strict as assert } from 'node:assert';
-import { createRequire } from 'node:module';
-import { mkdtempSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-
-const require = createRequire(import.meta.url);
-const a = require('../modules/art-pipeline/art-key.js');
-const db = require('../modules/lifecycle/db.js');
-
-let passed = 0;
-let failed = 0;
-function t(name, fn) {
-  try { fn(); passed++; console.log(`  PASS  ${name}`); }
-  catch (e) { failed++; console.log(`  FAIL  ${name}\n        ${e.message}`); }
-}
-
-// Run a thunk with SHARED_ART_GEMINI_KEY + HOME forced to known values, restoring
-// both afterward so cases don't leak into each other.
-function withEnv({ key, emptyHome }, fn) {
-  const origKey = process.env.SHARED_ART_GEMINI_KEY;
-  const origHome = process.env.HOME;
-  if (key === null) delete process.env.SHARED_ART_GEMINI_KEY;
-  else if (key !== undefined) process.env.SHARED_ART_GEMINI_KEY = key;
-  if (emptyHome) process.env.HOME = mkdtempSync(join(tmpdir(), 'otb-artkey-'));
-  try { fn(); }
-  finally {
-    if (origKey === undefined) delete process.env.SHARED_ART_GEMINI_KEY;
-    else process.env.SHARED_ART_GEMINI_KEY = origKey;
-    process.env.HOME = origHome;
-  }
-}
-
-console.log('entitlement boundary:');
-
-t('SHARED_ART_KEY_MAX_TIER is the xenos tier (1)', () => {
-  assert.equal(a.SHARED_ART_KEY_MAX_TIER, db.REQUIRES_RANK_TIER.xenos);
-  assert.equal(a.SHARED_ART_KEY_MAX_TIER, 1);
-});
-
-t('xenos is entitled (reason newcomer)', () => {
-  assert.deepEqual(a.entitlementFor('xenos'), { entitled: true, reason: 'newcomer' });
-});
-
-t('thetes / metic / archon are NOT entitled (reason rank_above_newcomer)', () => {
-  for (const rank of ['thetes', 'metic', 'archon']) {
-    assert.deepEqual(a.entitlementFor(rank), { entitled: false, reason: 'rank_above_newcomer' }, rank);
-  }
-});
-
-t('unknown / absent rank fails closed (reason unknown_rank)', () => {
-  for (const rank of [undefined, null, '', 'wizard', 'helot']) {
-    assert.deepEqual(a.entitlementFor(rank), { entitled: false, reason: 'unknown_rank' }, String(rank));
-  }
-});
-
-console.log('\nkey loader (env wins; trimmed):');
-
-t('loadSharedGeminiKey returns the env key, trimmed', () => {
-  withEnv({ key: '  AIza-test-123  ' }, () => {
-    assert.equal(a.loadSharedGeminiKey(), 'AIza-test-123');
-    assert.equal(a.sharedGeminiKeyConfigured(), true);
-  });
-});
-
-t('not configured when env unset and no operator file (empty HOME)', () => {
-  withEnv({ key: null, emptyHome: true }, () => {
-    assert.equal(a.loadSharedGeminiKey(), null);
-    assert.equal(a.sharedGeminiKeyConfigured(), false);
-  });
-});
-
-console.log('\ndescribeArtKey (the GET /me/art-key payload, sans secret):');
-
-t('xenos + configured: entitled, configured, shared_key placeholder is null', () => {
-  withEnv({ key: 'AIza-shared' }, () => {
-    const d = a.describeArtKey({ rank: 'xenos' });
-    assert.equal(d.entitled, true);
-    assert.equal(d.configured, true);
-    assert.equal(d.reason, 'newcomer');
-    assert.equal(d.rank, 'xenos');
-    // The pure describe never embeds the secret — the route attaches it.
-    assert.equal(d.shared_key, null);
-  });
-});
-
-t('thetes: not entitled even when a key is configured (the withdraw signal)', () => {
-  withEnv({ key: 'AIza-shared' }, () => {
-    const d = a.describeArtKey({ rank: 'thetes' });
-    assert.equal(d.entitled, false);
-    assert.equal(d.reason, 'rank_above_newcomer');
-    assert.equal(d.configured, true);
-    assert.equal(d.shared_key, null);
-  });
-});
-
-t('xenos but unconfigured: entitled yet configured=false (sync no-ops)', () => {
-  withEnv({ key: null, emptyHome: true }, () => {
-    const d = a.describeArtKey({ rank: 'xenos' });
-    assert.equal(d.entitled, true);
-    assert.equal(d.configured, false);
-  });
-});
-
-console.log(`\n${passed} passed, ${failed} failed`);
-process.exit(failed === 0 ? 0 : 1);

package/tests/day_cycle.mjs

@@ -1,197 +0,0 @@
-// tests/day_cycle.mjs
-//
-// The pure math behind the #639 time-of-day lighting. No Phaser, no DOM — the
-// fx/lighting.js glue is a thin shell over these functions, so getting the
-// math right here is most of the feature.
-//
-// Run:  node tests/day_cycle.mjs
-
-import { strict as assert } from 'node:assert';
-import {
-  DEFAULT_PERIOD_MS,
-  KEYFRAMES,
-  SKY_PHASES,
-  wrap01,
-  phaseFromClock,
-  lerpColor,
-  bracket,
-  tintAt,
-  parseSkyOverride,
-} from '../modules/game/public/game/fx/dayCycle.js';
-
-let passed = 0;
-function test(name, fn) {
-  try {
-    fn();
-    console.log(`  ok  ${name}`);
-    passed++;
-  } catch (e) {
-    console.error(`  FAIL ${name}: ${e.message}`);
-    process.exitCode = 1;
-  }
-}
-
-const chan = (c) => [(c >> 16) & 0xff, (c >> 8) & 0xff, c & 0xff];
-
-// ---------- wrap01 -------------------------------------------------------
-
-test('wrap01 maps any real into [0,1)', () => {
-  assert.equal(wrap01(0), 0);
-  assert.equal(wrap01(0.5), 0.5);
-  assert.equal(wrap01(1), 0);
-  assert.ok(Math.abs(wrap01(1.25) - 0.25) < 1e-9);
-  assert.ok(Math.abs(wrap01(-0.25) - 0.75) < 1e-9);
-  assert.ok(Math.abs(wrap01(-2.1) - 0.9) < 1e-9);
-});
-
-// ---------- phaseFromClock ----------------------------------------------
-
-test('phaseFromClock is 0 at the epoch and 0.5 at half a period', () => {
-  assert.equal(phaseFromClock(0), 0);
-  assert.equal(phaseFromClock(DEFAULT_PERIOD_MS / 2), 0.5);
-});
-
-test('phaseFromClock wraps each period', () => {
-  assert.equal(phaseFromClock(DEFAULT_PERIOD_MS), 0);
-  assert.ok(Math.abs(phaseFromClock(DEFAULT_PERIOD_MS * 1.25) - 0.25) < 1e-9);
-});
-
-test('phaseFromClock is deterministic — shared across clients by construction', () => {
-  const now = 1_700_000_123_456;
-  assert.equal(phaseFromClock(now), phaseFromClock(now));
-  // Two clients a few seconds apart see ~the same phase (period is minutes).
-  const skew = phaseFromClock(now + 3000) - phaseFromClock(now);
-  assert.ok(Math.abs(skew) < 0.01, `3s skew tiny: ${skew}`);
-});
-
-test('phaseFromClock guards a non-positive period', () => {
-  assert.equal(phaseFromClock(1234, 0), 0);
-  assert.equal(phaseFromClock(1234, -5), 0);
-});
-
-// ---------- lerpColor ----------------------------------------------------
-
-test('lerpColor returns the endpoints at f=0 and f=1', () => {
-  assert.equal(lerpColor(0x000000, 0xffffff, 0), 0x000000);
-  assert.equal(lerpColor(0x000000, 0xffffff, 1), 0xffffff);
-});
-
-test('lerpColor blends channel-by-channel at the midpoint', () => {
-  // (0,128,255) is the per-channel midpoint of black and 0x00ffff... use a
-  // clean case: midpoint of 0x000000 and 0x804020 is (64,32,16).
-  assert.deepEqual(chan(lerpColor(0x000000, 0x804020, 0.5)), [64, 32, 16]);
-});
-
-test('lerpColor clamps f outside [0,1]', () => {
-  assert.equal(lerpColor(0x102030, 0xa0b0c0, -1), 0x102030);
-  assert.equal(lerpColor(0x102030, 0xa0b0c0, 2), 0xa0b0c0);
-});
-
-// ---------- bracket / tintAt --------------------------------------------
-
-test('tintAt hits each keyframe exactly at its phase', () => {
-  for (const kf of KEYFRAMES) {
-    const { color, alpha } = tintAt(kf.t);
-    assert.equal(color, kf.color, `${kf.name}@${kf.t} color`);
-    assert.ok(Math.abs(alpha - kf.alpha) < 1e-9, `${kf.name}@${kf.t} alpha`);
-  }
-});
-
-test('high noon is fully transparent (base art at full strength)', () => {
-  assert.equal(tintAt(SKY_PHASES.midday).alpha, 0);
-  // The whole noon plateau holds at alpha 0.
-  assert.equal(tintAt(0.45).alpha, 0);
-  assert.equal(tintAt(0.50).alpha, 0);
-});
-
-test('golden hour is the warm hero state', () => {
-  const t = tintAt(SKY_PHASES.golden);
-  const [r, g, b] = chan(t.color);
-  assert.ok(r > g && g > b, `amber: r>g>b got ${r},${g},${b}`);
-  assert.ok(t.alpha > 0.3, `visible: ${t.alpha}`);
-  assert.equal(t.name, 'golden');
-});
-
-test('night is a dark blue-dominant tint', () => {
-  const [r, g, b] = chan(tintAt(0).color);
-  assert.ok(b > r && b > g, `blue-dominant: ${r},${g},${b}`);
-  assert.ok(tintAt(0).alpha > 0.5, 'strong');
-});
-
-test('the wrap segment interpolates nightfall → deep night across midnight', () => {
-  // phase 0.94 sits between the 0.88 nightfall keyframe and the 0.00 deep-night
-  // keyframe (read circularly). Alpha must land strictly between the two.
-  const { alpha } = tintAt(0.94);
-  assert.ok(alpha > 0.64 && alpha < 0.72, `between nightfall and deep night: ${alpha}`);
-});
-
-test('bracket picks the wrap segment for late-night phases', () => {
-  const b = bracket(0.95);
-  assert.equal(b.from.t, 0.88);
-  assert.equal(b.to.t, 0.00);
-  assert.ok(b.f > 0 && b.f < 1);
-});
-
-test('tintAt is continuous and total over the whole cycle (no gaps/throws)', () => {
-  let prev = tintAt(0);
-  for (let i = 1; i <= 1000; i++) {
-    const p = i / 1000;
-    const cur = tintAt(p);
-    assert.ok(cur.alpha >= 0 && cur.alpha <= 1, `alpha in range @${p}`);
-    // No discontinuous jump bigger than the largest keyframe-to-keyframe step.
-    assert.ok(Math.abs(cur.alpha - prev.alpha) < 0.05, `smooth @${p}`);
-    prev = cur;
-  }
-});
-
-test('tintAt wraps: phase 1.0 equals phase 0.0', () => {
-  assert.deepEqual(tintAt(1.0), tintAt(0.0));
-  assert.deepEqual(tintAt(1.5), tintAt(0.5));
-});
-
-// ---------- parseSkyOverride --------------------------------------------
-
-test('parseSkyOverride: absent / blank => null (run the live clock)', () => {
-  assert.equal(parseSkyOverride(null), null);
-  assert.equal(parseSkyOverride(undefined), null);
-  assert.equal(parseSkyOverride(''), null);
-  assert.equal(parseSkyOverride('   '), null);
-});
-
-test('parseSkyOverride: mood names (case-insensitive) => their phase', () => {
-  assert.equal(parseSkyOverride('golden'), SKY_PHASES.golden);
-  assert.equal(parseSkyOverride('NIGHT'), SKY_PHASES.night);
-  assert.equal(parseSkyOverride('Dusk'), SKY_PHASES.dusk);
-});
-
-test('parseSkyOverride: raw fractions, wrapped into [0,1)', () => {
-  assert.equal(parseSkyOverride('0.68'), 0.68);
-  assert.equal(parseSkyOverride('0'), 0);
-  assert.ok(Math.abs(parseSkyOverride('1.25') - 0.25) < 1e-9);
-});
-
-test('parseSkyOverride: garbage => null', () => {
-  assert.equal(parseSkyOverride('banana'), null);
-  assert.equal(parseSkyOverride('NaN'), null);
-});
-
-// ---------- data sanity --------------------------------------------------
-
-test('KEYFRAMES are sorted, valid colours, alphas in [0,1]', () => {
-  for (let i = 0; i < KEYFRAMES.length; i++) {
-    const kf = KEYFRAMES[i];
-    assert.ok(kf.t >= 0 && kf.t < 1, `t in [0,1): ${kf.t}`);
-    assert.ok(kf.alpha >= 0 && kf.alpha <= 1, `alpha in [0,1]: ${kf.alpha}`);
-    assert.ok(Number.isInteger(kf.color) && kf.color >= 0 && kf.color <= 0xffffff, 'color 24-bit');
-    if (i > 0) assert.ok(kf.t > KEYFRAMES[i - 1].t, `strictly ascending @${i}`);
-  }
-});
-
-test('SKY_PHASES all resolve into [0,1) and round-trip through tintAt', () => {
-  for (const [name, p] of Object.entries(SKY_PHASES)) {
-    assert.ok(p >= 0 && p < 1, `${name} phase in range`);
-    assert.doesNotThrow(() => tintAt(p), `${name} tints`);
-  }
-});
-
-console.log(`\nday_cycle: ${passed} passed`);